hyalo-cli 0.10.0

#![allow(clippy::missing_errors_doc)]
use anyhow::{Context, Result};
use std::path::{Path, PathBuf};

use crate::output::{CommandOutcome, Format, format_success};

/// Delete a snapshot index file.
///
/// If `path` is `None`, defaults to `<dir>/.hyalo-index`.
/// Returns a user error if the file does not exist.
pub fn drop_index(
    dir: &Path,
    path: Option<&Path>,
    format: Format,
    allow_outside_vault: bool,
) -> Result<CommandOutcome> {
    let index_path: PathBuf = match path {
        Some(p) => p.to_path_buf(),
        None => dir.join(".hyalo-index"),
    };

    // Vault boundary check: only applies when the caller specified a custom path.
    // Fail closed — if canonicalization fails we refuse the operation rather than
    // allowing a potentially out-of-vault deletion.
    if path.is_some() && !allow_outside_vault {
        let canonical_dir = hyalo_core::discovery::canonicalize_vault_dir(dir)?;
        match dunce::canonicalize(&index_path) {
            Ok(canonical_path) => {
                if !canonical_path.starts_with(&canonical_dir) {
                    let out = crate::output::format_error(
                        format,
                        "index path is outside the vault boundary",
                        Some(&index_path.display().to_string()),
                        Some("use --allow-outside-vault to override"),
                        None,
                    );
                    return Ok(CommandOutcome::UserError(out));
                }
            }
            Err(e) => {
                let details = format!("failed to resolve index path for boundary check: {e}");
                let out = crate::output::format_error(
                    format,
                    "could not verify that index path is inside the vault",
                    Some(&index_path.display().to_string()),
                    Some(
                        "ensure the path is accessible and inside the vault, or use --allow-outside-vault",
                    ),
                    Some(&details),
                );
                return Ok(CommandOutcome::UserError(out));
            }
        }
    }

    match std::fs::remove_file(&index_path) {
        Ok(()) => {}
        Err(e) if e.kind() == std::io::ErrorKind::NotFound => {
            let out = crate::output::format_error(
                format,
                "index file not found",
                Some(&index_path.display().to_string()),
                Some("create one with `hyalo create-index`"),
                None,
            );
            return Ok(CommandOutcome::UserError(out));
        }
        Err(e) => {
            return Err(e)
                .with_context(|| format!("failed to delete index file: {}", index_path.display()));
        }
    }

    let result = serde_json::json!({
        "deleted": index_path.display().to_string(),
    });

    Ok(CommandOutcome::success(format_success(format, &result)))
}