use std::path::{Path, PathBuf};
use std::process::Command;
mod common;
fn scratch(name: &str) -> PathBuf {
common::scratch("htl-cli-decl", name)
}
fn write(path: &Path, text: &str) {
std::fs::create_dir_all(path.parent().unwrap()).unwrap();
std::fs::write(path, text).unwrap();
}
fn messages(root: &Path, target: &str) -> Vec<String> {
let out = Command::new(common::htl_bin())
.arg("check")
.arg(target)
.arg("--format")
.arg("json")
.arg("--no-cache")
.current_dir(root)
.output()
.unwrap();
let v: serde_json::Value = serde_json::from_str(&String::from_utf8_lossy(&out.stdout))
.expect("stdout is one JSON document");
v["diagnostics"]
.as_array()
.expect("diagnostics array")
.iter()
.map(|d| {
let rule = d["rule"]
.as_str()
.or_else(|| d["kind"].as_str())
.unwrap_or("");
format!("{rule}: {}", d["message"].as_str().unwrap_or(""))
})
.collect()
}
const DECL: &str = "local record xlib\n connect: function(string): boolean\nend\nreturn xlib\n";
const USE: &str = "local xlib = require(\"xlib\")\nprint(xlib.connect(\"h\"))\n";
#[test]
fn two_declarations_of_one_module_are_reported() {
let root = scratch("two-decls");
write(&root.join("htl.toml"), "[check]\npaths = [\"sdk\"]\n");
write(&root.join("types/xlib.d.tl"), DECL);
write(&root.join("sdk/xlib.d.tl"), DECL);
write(&root.join("src/use.tl"), USE);
let msgs = messages(&root, "src/use.tl");
let found: Vec<&String> = msgs
.iter()
.filter(|m| m.contains("duplicate-declaration"))
.collect();
assert_eq!(found.len(), 1, "one report for one module: {msgs:?}");
let m = found[0];
assert!(m.contains("types/xlib.d.tl"), "names the one read: {m}");
assert!(m.contains("sdk/xlib.d.tl"), "names the shadowed one: {m}");
assert!(m.contains("is read"), "says which is which: {m}");
}
#[test]
fn a_source_alongside_a_declaration_is_not_a_collision() {
let root = scratch("source-wins");
write(&root.join("htl.toml"), "[check]\npaths = [\"sdk\"]\n");
write(
&root.join("types/xlib.d.tl"),
"local record xlib\n connect: function(string): boolean\nend\nreturn xlib\n",
);
write(
&root.join("sdk/xlib.tl"),
"local record xlib\nend\nfunction xlib.connect(_: string): boolean\n return true\nend\nreturn xlib\n",
);
write(&root.join("src/use.tl"), USE);
let msgs = messages(&root, "src/use.tl");
assert!(
!msgs.iter().any(|m| m.contains("duplicate-declaration")),
"a source is not a second declaration: {msgs:?}"
);
}
#[test]
fn a_single_declaration_is_silent() {
let root = scratch("single");
write(&root.join("htl.toml"), "[lint]\n");
write(&root.join("types/xlib.d.tl"), DECL);
write(&root.join("src/use.tl"), USE);
let msgs = messages(&root, "src/use.tl");
assert!(
!msgs.iter().any(|m| m.contains("duplicate-declaration")),
"nothing to report: {msgs:?}"
);
}