hpkg 1.0.0

A native Rust crate to parse Haiku's binary package and repo formats
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
use std::path::{Path, PathBuf};
use std::fs::File;
use std::io::Write;
use std::mem::size_of;
use std::error::Error;

use flate2::write::ZlibEncoder;
use flate2::Compression;
use zstd::stream::write::Encoder as ZstdEncoder;

use crate::hpkg_common::*;
use crate::repository::{RepositoryHeaderV2, PackageInfo};

// Package attribute IDs (same as package.rs for package attributes)
const ATTR_PACKAGE: u16 = 54;
const ATTR_PACKAGE_SUMMARY: u16 = 16;
const ATTR_PACKAGE_DESCRIPTION: u16 = 17;
const ATTR_PACKAGE_VENDOR: u16 = 18;
const ATTR_PACKAGE_PACKAGER: u16 = 19;
const ATTR_PACKAGE_FLAGS: u16 = 20;
const ATTR_PACKAGE_ARCHITECTURE: u16 = 21;
const ATTR_PACKAGE_VERSION_MAJOR: u16 = 22;
const ATTR_PACKAGE_VERSION_MINOR: u16 = 23;
const ATTR_PACKAGE_VERSION_MICRO: u16 = 24;
const ATTR_PACKAGE_VERSION_REVISION: u16 = 25;
const ATTR_PACKAGE_COPYRIGHT: u16 = 26;
const ATTR_PACKAGE_LICENSE: u16 = 27;
const ATTR_PACKAGE_PROVIDES: u16 = 28;
const ATTR_PACKAGE_REQUIRES: u16 = 29;
const ATTR_PACKAGE_CHECKSUM: u16 = 35;
const ATTR_PACKAGE_URL: u16 = 38;
const ATTR_PACKAGE_SOURCE_URL: u16 = 39;
const ATTR_PACKAGE_INSTALL_PATH: u16 = 40;

/// A builder for creating HPKR repository cache files.
///
/// # Example
///
/// ```no_run
/// use hpkg::repository_writer::RepositoryWriter;
/// use hpkg::repository::PackageInfo;
/// use hpkg::hpkg_common::{B_HPKG_COMPRESSION_ZLIB, ARCH_X86_64};
///
/// let mut writer = RepositoryWriter::new("/tmp/test.hpkr");
/// writer.set_name("TestRepo")
///       .set_summary("A test repository")
///       .set_vendor("Test")
///       .set_architecture(ARCH_X86_64)
///       .set_compression(B_HPKG_COMPRESSION_ZLIB);
///
/// let mut pkg = PackageInfo::new();
/// pkg.name = Some("hello".to_string());
/// pkg.summary = Some("A hello package".to_string());
/// pkg.vendor = Some("Test".to_string());
/// writer.add_package(pkg);
/// writer.finish().unwrap();
/// ```
pub struct RepositoryWriter {
    path: PathBuf,
    compression: u16,
    chunk_size: u32,
    name: Option<String>,
    identifier: Option<String>,
    base_url: Option<String>,
    vendor: Option<String>,
    summary: Option<String>,
    priority: Option<u8>,
    architecture: Option<u64>,
    license_names: Vec<String>,
    license_texts: Vec<String>,
    packages: Vec<PackageInfo>,
}

impl RepositoryWriter {
    pub fn new<P: AsRef<Path>>(path: P) -> Self {
        RepositoryWriter {
            path: path.as_ref().to_path_buf(),
            compression: B_HPKG_COMPRESSION_NONE,
            chunk_size: 65536,
            name: None,
            identifier: None,
            base_url: None,
            vendor: None,
            summary: None,
            priority: None,
            architecture: None,
            license_names: Vec::new(),
            license_texts: Vec::new(),
            packages: Vec::new(),
        }
    }

    pub fn set_name(&mut self, name: &str) -> &mut Self {
        self.name = Some(name.to_string());
        self
    }
    pub fn set_identifier(&mut self, id: &str) -> &mut Self {
        self.identifier = Some(id.to_string());
        self
    }
    pub fn set_base_url(&mut self, url: &str) -> &mut Self {
        self.base_url = Some(url.to_string());
        self
    }
    pub fn set_vendor(&mut self, vendor: &str) -> &mut Self {
        self.vendor = Some(vendor.to_string());
        self
    }
    pub fn set_summary(&mut self, summary: &str) -> &mut Self {
        self.summary = Some(summary.to_string());
        self
    }
    pub fn set_priority(&mut self, priority: u8) -> &mut Self {
        self.priority = Some(priority);
        self
    }
    pub fn set_architecture(&mut self, arch: u64) -> &mut Self {
        self.architecture = Some(arch);
        self
    }
    pub fn add_license(&mut self, name: &str, text: &str) -> &mut Self {
        self.license_names.push(name.to_string());
        self.license_texts.push(text.to_string());
        self
    }
    pub fn set_compression(&mut self, compression: u16) -> &mut Self {
        self.compression = compression;
        self
    }
    pub fn add_package(&mut self, pkg: PackageInfo) -> &mut Self {
        self.packages.push(pkg);
        self
    }

    /// Build and write the HPKR repository file.
    pub fn finish(&mut self) -> Result<(), Box<dyn Error>> {
        // 1. Serialize repository info section (BMessage flat format)
        let info_buf = self.serialize_info();
        let info_length = info_buf.len() as u32;

        // 2. Serialize package list (attribute tree, no string table)
        let pkg_strings: Vec<u8> = Vec::new();
        let mut pkg_tree: Vec<u8> = Vec::new();
        let pkg_strings_count: u64 = 0;
        self.serialize_package_list(&mut pkg_tree)?;
        let pkg_strings_length = pkg_strings.len() as u64;
        let package_length = (pkg_strings_length + pkg_tree.len() as u64) as u64;

        // 3. Assemble uncompressed heap: [info][pkg_strings][pkg_tree]
        let mut heap = Vec::new();
        heap.extend_from_slice(&info_buf);
        heap.extend_from_slice(&pkg_strings);
        heap.extend_from_slice(&pkg_tree);
        let heap_size_uncompressed = heap.len() as u64;

        // 4. Chunk and compress
        let chunk_count = (heap_size_uncompressed + self.chunk_size as u64 - 1) / self.chunk_size as u64;
        let mut compressed_chunks: Vec<Vec<u8>> = Vec::new();
        let mut chunk_size_table: Vec<u16> = Vec::new();

        for i in 0..chunk_count {
            let start = (i * self.chunk_size as u64) as usize;
            let end = std::cmp::min(start + self.chunk_size as usize, heap.len());
            let chunk_data = &heap[start..end];

            let compressed = match self.compression {
                B_HPKG_COMPRESSION_NONE => chunk_data.to_vec(),
                B_HPKG_COMPRESSION_ZLIB => {
                    let mut encoder = ZlibEncoder::new(Vec::new(), Compression::default());
                    encoder.write_all(chunk_data)?;
                    let c = encoder.finish()?;
                    if c.len() < chunk_data.len() { c } else { chunk_data.to_vec() }
                }
                B_HPKG_COMPRESSION_ZSTD => {
                    let mut encoder = ZstdEncoder::new(Vec::new(), 3)?;
                    encoder.write_all(chunk_data)?;
                    let c = encoder.finish()?;
                    if c.len() < chunk_data.len() { c } else { chunk_data.to_vec() }
                }
                _ => return Err(From::from(format!("Unknown compression: {}", self.compression))),
            };
            compressed_chunks.push(compressed);
        }

        let mut heap_size_compressed: u64 = 0;
        if self.compression == B_HPKG_COMPRESSION_NONE {
            heap_size_compressed = heap_size_uncompressed;
        } else {
            for (i, chunk) in compressed_chunks.iter().enumerate() {
                heap_size_compressed += chunk.len() as u64;
                if i < compressed_chunks.len() - 1 {
                    chunk_size_table.push((chunk.len() as u16).wrapping_sub(1));
                }
            }
            heap_size_compressed += (chunk_size_table.len() * 2) as u64;
        }

        let header_size = size_of::<RepositoryHeaderV2>() as u16;
        let header = RepositoryHeaderV2 {
            magic: u32::from_ne_bytes([b'h', b'p', b'k', b'r']),
            header_size: header_size.to_be(),
            version: 2u16.to_be(),
            total_size: (header_size as u64 + heap_size_compressed).to_be(),
            minor_version: 0u16.to_be(),
            heap_compression: self.compression.to_be(),
            heap_chunk_size: self.chunk_size.to_be(),
            heap_size_compressed: heap_size_compressed.to_be(),
            heap_size_uncompressed: heap_size_uncompressed.to_be(),
            info_length: info_length.to_be(),
            reserved1: 0u32.to_be(),
            package_length: package_length.to_be(),
            package_strings_length: pkg_strings_length.to_be(),
            package_strings_count: pkg_strings_count.to_be(),
        };

        let mut f = File::create(&self.path)?;
        let header_bytes = unsafe {
            std::slice::from_raw_parts(
                &header as *const RepositoryHeaderV2 as *const u8,
                size_of::<RepositoryHeaderV2>(),
            )
        };
        f.write_all(header_bytes)?;

        for chunk in &compressed_chunks {
            f.write_all(chunk)?;
        }

        if self.compression != B_HPKG_COMPRESSION_NONE {
            for &cookie in &chunk_size_table {
                f.write_all(&cookie.to_be_bytes())?;
            }
        }

        f.sync_all()?;
        Ok(())
    }

    // -----------------------------------------------------------------
    // Info section serialization (BMessage flat format, Haiku-compatible)
    // -----------------------------------------------------------------

    /// Build the repository info section as a proper BMessage flat buffer.
    /// The format matches Haiku's BMessage::Flatten() output so that both
    /// the Rust reader (byte-scanning) and Haiku C tools can parse it.
    fn serialize_info(&self) -> Vec<u8> {
        const B_STRING_TYPE: u32 = 0x43535452; // 'CSTR' (GCC multi-char order)
        const B_INT8_TYPE: u32   = 0x42595445; // 'BYTE' (GCC multi-char order)

        let mut fields: Vec<BMessageField> = Vec::new();

        let string_fields: &[(&str, Option<&str>)] = &[
            ("name", self.name.as_deref()),
            ("identifier", self.identifier.as_deref()),
            ("baseurl", self.base_url.as_deref()),
            ("vendor", self.vendor.as_deref()),
            ("summary", self.summary.as_deref()),
        ];
        for &(name, value) in string_fields {
            if let Some(v) = value {
                let encoded = encode_bmessage_string(v);
                add_bmessage_field(&mut fields, name, B_STRING_TYPE, false, encoded);
            }
        }

        for (i, name) in self.license_names.iter().enumerate() {
            add_bmessage_field(&mut fields, "licenseName", B_STRING_TYPE, false, encode_bmessage_string(name));
            if let Some(text) = self.license_texts.get(i) {
                add_bmessage_field(&mut fields, "licenseText", B_STRING_TYPE, false, encode_bmessage_string(text));
            }
        }

        if let Some(p) = self.priority {
            add_bmessage_field(&mut fields, "priority", B_INT8_TYPE, true, vec![p]);
        }
        if let Some(a) = self.architecture {
            add_bmessage_field(&mut fields, "architecture", B_INT8_TYPE, true, vec![a as u8]);
        }

        build_bmessage_buffer(&fields)
    }
}

// ---------------------------------------------------------------------------
// BMessage flat format helpers (Haiku-compatible BMessage::Flatten output)
// ---------------------------------------------------------------------------

/// Encode a string value for the BMessage data section:
/// [size:u32 LE][data\0] where size includes the null terminator.
fn encode_bmessage_string(value: &str) -> Vec<u8> {
    let encoded = value.as_bytes();
    let str_len = encoded.len() as u32 + 1;
    let mut buf = Vec::new();
    buf.extend_from_slice(&str_len.to_le_bytes());
    buf.extend_from_slice(encoded);
    buf.push(0);
    buf
}

/// Add a value to a field, grouping by (name, type_code) to support
/// multi-value fields (e.g. multiple licenseName entries).
fn add_bmessage_field(fields: &mut Vec<BMessageField>, name: &str,
    type_code: u32, fixed_size: bool, value: Vec<u8>)
{
    if let Some(f) = fields.iter_mut().find(|f| f.name == name && f.type_code == type_code) {
        f.values.push(value);
    } else {
        fields.push(BMessageField {
            name: name.to_string(),
            type_code,
            fixed_size,
            values: vec![value],
        });
    }
}

struct BMessageField {
    name: String,
    type_code: u32,
    fixed_size: bool,
    values: Vec<Vec<u8>>,
}

/// Build a complete BMessage flat buffer from a list of fields.
///
/// Format (all multi-byte values are little-endian):
///
/// [68-byte message header]
///   magic 'HMF1' (4)
///   what (4)
///   flags (4)
///   target (4, -1)
///   current_specifier (4, -1)
///   message_area (4, -1)
///   reply_port (4, -1)
///   reply_target (4, -1)
///   reply_team (4, -1)
///   data_size (4)
///   field_count (4)
///   hash_table_size (4, =5)
///   hash_table (5 * 4 = 20 bytes)
///
/// [field headers, 24 bytes each]
///   flags (2), name_length (2), type_code (4), count (4),
///   data_size (4), offset (4), next_field (4)
///
/// [data section]
///   [field_name\0][value_data]... for each field
fn build_bmessage_buffer(fields: &[BMessageField]) -> Vec<u8> {
    // --- data section ---
    let mut data: Vec<u8> = Vec::new();
    let mut field_headers: Vec<[u8; 24]> = Vec::new();

    for field in fields {
        let name_offset = data.len() as u32;
        let name_bytes = field.name.as_bytes();
        let name_len = name_bytes.len() as u16 + 1;

        // Write field name (null-terminated)
        data.extend_from_slice(name_bytes);
        data.push(0);

        // Write all values for this field
        for value in &field.values {
            data.extend_from_slice(value);
        }

        // Compute data_size = total bytes of values (not including field name)
        let values_start = name_offset + name_len as u32;
        let data_size = data.len() as u32 - values_start;
        let count = field.values.len() as u32;

        let flags: u16 = if field.fixed_size { 3 } else { 1 };
        let mut fh = [0u8; 24];
        fh[0..2].copy_from_slice(&flags.to_le_bytes());
        fh[2..4].copy_from_slice(&name_len.to_le_bytes());
        fh[4..8].copy_from_slice(&field.type_code.to_le_bytes());
        fh[8..12].copy_from_slice(&count.to_le_bytes());
        fh[12..16].copy_from_slice(&data_size.to_le_bytes());
        fh[16..20].copy_from_slice(&name_offset.to_le_bytes());
        field_headers.push(fh);
    }

    // --- hash table ---
    const HASH_TABLE_SIZE: u32 = 5;
    let mut hash_table = vec![-1i32; HASH_TABLE_SIZE as usize];

    for (i, field) in fields.iter().enumerate() {
        let hash = (hash_name(&field.name) % HASH_TABLE_SIZE) as usize;
        let next = hash_table[hash];
        hash_table[hash] = i as i32;
        field_headers[i][20..24].copy_from_slice(&next.to_le_bytes());
    }

    // Pad data to 4-byte boundary (BMessage convention)
    while data.len() % 4 != 0 {
        data.push(0);
    }

    // --- message header (68 bytes) ---
    let field_count = fields.len() as u32;
    let data_size = data.len() as u32;

    let mut buf = Vec::with_capacity(68 + field_headers.len() * 24 + data.len());

    // magic
    buf.extend_from_slice(b"HMF1");
    // what
    buf.extend_from_slice(&0u32.to_le_bytes());
    // flags (B_LENDIAN = 1, so Haiku's Unflatten won't byte-swap)
    buf.extend_from_slice(&1u32.to_le_bytes());
    // target, current_specifier, message_area = -1
    buf.extend_from_slice(&(-1i32).to_le_bytes());
    buf.extend_from_slice(&(-1i32).to_le_bytes());
    buf.extend_from_slice(&(-1i32).to_le_bytes());
    // reply_port, reply_target, reply_team = -1
    buf.extend_from_slice(&(-1i32).to_le_bytes());
    buf.extend_from_slice(&(-1i32).to_le_bytes());
    buf.extend_from_slice(&(-1i32).to_le_bytes());
    // data_size, field_count
    buf.extend_from_slice(&data_size.to_le_bytes());
    buf.extend_from_slice(&field_count.to_le_bytes());
    // hash_table_size, hash_table
    buf.extend_from_slice(&HASH_TABLE_SIZE.to_le_bytes());
    for &entry in &hash_table {
        buf.extend_from_slice(&entry.to_le_bytes());
    }

    // --- field headers ---
    for fh in &field_headers {
        buf.extend_from_slice(fh);
    }

    // --- data section ---
    buf.extend_from_slice(&data);

    buf
}

/// BMessage hash function (matches Haiku's `hash_name()`).
fn hash_name(name: &str) -> u32 {
    let mut hash: u32 = 0;
    for &byte in name.as_bytes() {
        hash = (hash << 7) ^ (hash >> 24);
        hash ^= byte as u32;
    }
    hash ^= hash << 12;
    hash
}

impl RepositoryWriter { // continued
    // -----------------------------------------------------------------
    // Package list serialization (attribute tree)
    // -----------------------------------------------------------------

    fn serialize_package_list(&self, buf: &mut Vec<u8>) -> Result<(), Box<dyn Error>> {
        for pkg in &self.packages {
            let pkg_name = pkg.name.as_deref().unwrap_or("");
            let has_children = pkg.summary.is_some()
                || pkg.description.is_some()
                || pkg.vendor.is_some()
                || pkg.packager.is_some()
                || pkg.flags != 0
                || pkg.architecture.is_some()
                || pkg.version_major.is_some()
                || pkg.version_minor.is_some()
                || pkg.version_micro.is_some()
                || pkg.version_revision.is_some()
                || !pkg.copyrights.is_empty()
                || !pkg.licenses.is_empty()
                || !pkg.provides.is_empty()
                || !pkg.requires.is_empty()
                || pkg.checksum.is_some()
                || pkg.url.is_some()
                || pkg.source_url.is_some()
                || pkg.install_path.is_some();

            write_attr_tag(buf, ATTR_PACKAGE, HPKG_ATTR_TYPE_STRING, HPKG_ATTR_ENCODING_STRING_INLINE, has_children);
            write_string_inline(buf, pkg_name);

            if has_children {
                self.serialize_package_attributes(buf, pkg)?;
                write_unsigned_leb128(buf, 0);
            }
        }
        Ok(())
    }

    fn serialize_package_attributes(&self, buf: &mut Vec<u8>, pkg: &PackageInfo) -> Result<(), Box<dyn Error>> {
        // String attributes (single)
        let string_attrs: &[(u16, Option<&str>)] = &[
            (ATTR_PACKAGE_SUMMARY, pkg.summary.as_deref()),
            (ATTR_PACKAGE_DESCRIPTION, pkg.description.as_deref()),
            (ATTR_PACKAGE_VENDOR, pkg.vendor.as_deref()),
            (ATTR_PACKAGE_PACKAGER, pkg.packager.as_deref()),
            (ATTR_PACKAGE_VERSION_MAJOR, pkg.version_major.as_deref()),
            (ATTR_PACKAGE_VERSION_MINOR, pkg.version_minor.as_deref()),
            (ATTR_PACKAGE_VERSION_MICRO, pkg.version_micro.as_deref()),
            (ATTR_PACKAGE_CHECKSUM, pkg.checksum.as_deref()),
            (ATTR_PACKAGE_URL, pkg.url.as_deref()),
            (ATTR_PACKAGE_SOURCE_URL, pkg.source_url.as_deref()),
            (ATTR_PACKAGE_INSTALL_PATH, pkg.install_path.as_deref()),
        ];
        for &(id, value) in string_attrs {
            if let Some(v) = value {
                write_attr_tag(buf, id, HPKG_ATTR_TYPE_STRING, HPKG_ATTR_ENCODING_STRING_INLINE, false);
                write_string_inline(buf, v);
            }
        }

        // Integer attributes
        if pkg.flags != 0 {
            write_attr_tag(buf, ATTR_PACKAGE_FLAGS, HPKG_ATTR_TYPE_UINT, uint_encoding(pkg.flags as u64), false);
            write_int_value(buf, pkg.flags as u64, uint_encoding(pkg.flags as u64));
        }
        if let Some(arch) = &pkg.architecture {
            if let Ok(v) = string_to_arch(arch) {
                write_attr_tag(buf, ATTR_PACKAGE_ARCHITECTURE, HPKG_ATTR_TYPE_UINT, uint_encoding(v), false);
                write_int_value(buf, v, uint_encoding(v));
            }
        }
        if let Some(rev) = pkg.version_revision {
            write_attr_tag(buf, ATTR_PACKAGE_VERSION_REVISION, HPKG_ATTR_TYPE_UINT, uint_encoding(rev), false);
            write_int_value(buf, rev, uint_encoding(rev));
        }

        // Multi-value strings
        let list_attrs: &[(u16, &[String])] = &[
            (ATTR_PACKAGE_COPYRIGHT, &pkg.copyrights),
            (ATTR_PACKAGE_LICENSE, &pkg.licenses),
            (ATTR_PACKAGE_PROVIDES, &pkg.provides),
            (ATTR_PACKAGE_REQUIRES, &pkg.requires),
        ];
        for &(id, list) in list_attrs {
            for item in list {
                write_attr_tag(buf, id, HPKG_ATTR_TYPE_STRING, HPKG_ATTR_ENCODING_STRING_INLINE, false);
                write_string_inline(buf, item);
            }
        }

        Ok(())
    }
}

/// Convert an architecture string back to its constant value. Returns an error
/// if the string is not a known architecture name.
fn string_to_arch(s: &str) -> Result<u64, Box<dyn Error>> {
    match s {
        "any" => Ok(ARCH_ANY),
        "x86" => Ok(ARCH_X86),
        "x86_gcc2" => Ok(ARCH_X86_GCC2),
        "source" => Ok(ARCH_SOURCE),
        "x86_64" => Ok(ARCH_X86_64),
        "ppc" => Ok(ARCH_PPC),
        "arm" => Ok(ARCH_ARM),
        "m68k" => Ok(ARCH_M68K),
        "sparc" => Ok(ARCH_SPARC),
        "arm64" => Ok(ARCH_ARM64),
        "riscv64" => Ok(ARCH_RISCV64),
        _ => {
            if let Some(num) = s.strip_prefix("arch_") {
                num.parse::<u64>().map_err(|_| From::from(format!("Unknown architecture: {}", s)))
            } else {
                Err(From::from(format!("Unknown architecture: {}", s)))
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::repository::Repository;

    #[test]
    fn test_writer_round_trip_uncompressed() {
        let tmp = std::env::temp_dir().join("test_repo_uncompressed.hpkr");
        let _ = std::fs::remove_file(&tmp);

        {
            let mut writer = RepositoryWriter::new(&tmp);
            writer.set_name("TestRepo")
                  .set_summary("A test repository")
                  .set_vendor("Test Vendor")
                  .set_architecture(ARCH_X86_64)
                  .set_priority(1)
                  .set_compression(B_HPKG_COMPRESSION_NONE);

            let mut pkg = PackageInfo::new();
            pkg.name = Some("hello".to_string());
            pkg.summary = Some("A hello package".to_string());
            pkg.vendor = Some("Test".to_string());
            pkg.architecture = Some("x86_64".to_string());
            pkg.version_major = Some("1".to_string());
            pkg.version_minor = Some("0".to_string());
            pkg.version_revision = Some(1);
            pkg.licenses.push("MIT".to_string());
            pkg.provides.push("hello = 1.0".to_string());
            writer.add_package(pkg);

            let mut pkg2 = PackageInfo::new();
            pkg2.name = Some("world".to_string());
            pkg2.summary = Some("A world package".to_string());
            pkg2.architecture = Some("x86_64".to_string());
            writer.add_package(pkg2);

            writer.finish().expect("write should succeed");
        }

        let repo = Repository::load(&tmp).expect("should load written repository");
        assert_eq!(repo.info.name.as_deref(), Some("TestRepo"));
        assert_eq!(repo.info.summary.as_deref(), Some("A test repository"));
        assert_eq!(repo.info.vendor.as_deref(), Some("Test Vendor"));
        assert_eq!(repo.info.priority, Some(1));
        assert_eq!(repo.packages.len(), 2);

        // Check first package
        let pkg = &repo.packages[0];
        assert_eq!(pkg.name.as_deref(), Some("hello"));
        assert_eq!(pkg.summary.as_deref(), Some("A hello package"));
        assert_eq!(pkg.vendor.as_deref(), Some("Test"));
        assert_eq!(pkg.architecture.as_deref(), Some("x86_64"));
        assert_eq!(pkg.version_major.as_deref(), Some("1"));

        let _ = std::fs::remove_file(&tmp);
    }

    #[test]
    fn test_writer_round_trip_zlib() {
        let tmp = std::env::temp_dir().join("test_repo_zlib.hpkr");
        let _ = std::fs::remove_file(&tmp);

        {
            let mut writer = RepositoryWriter::new(&tmp);
            writer.set_name("ZlibRepo")
                  .set_summary("Zlib compressed repo test")
                  .set_vendor("Test")
                  .set_architecture(ARCH_X86_64)
                  .set_compression(B_HPKG_COMPRESSION_ZLIB);

            let mut pkg = PackageInfo::new();
            pkg.name = Some("test_pkg".to_string());
            pkg.summary = Some("A zlib test package".to_string());
            writer.add_package(pkg);

            writer.finish().expect("write should succeed");
        }

        let repo = Repository::load(&tmp).expect("should load zlib repo");
        assert_eq!(repo.info.name.as_deref(), Some("ZlibRepo"));
        assert_eq!(repo.packages.len(), 1);
        assert_eq!(repo.packages[0].name.as_deref(), Some("test_pkg"));

        let _ = std::fs::remove_file(&tmp);
    }
}