horus 0.2.0

A small, modular Rust framework for building coding agents
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
use std::collections::BTreeMap;
use std::collections::BTreeSet;
use std::io;
use std::io::Write;
use std::sync::Arc;
use std::sync::Mutex;

use serde::Deserialize;
use serde::Serialize;
use sha2::Digest;
use sha2::Sha256;
use uuid::Uuid;

use super::NetworkAccess;
use super::SandboxApprovalRequest;
use super::SandboxAuthorization;
use super::SandboxPermissions;
use crate::Error;
use crate::Result;
use crate::backend::checkpoint::CheckpointStore;
use crate::backend::model::ToolCall;
use crate::preview_json;
use crate::protocol::EventMsg;
use crate::protocol::FrontendBlock;
use crate::protocol::FrontendCommand;
use crate::protocol::FrontendContribution;
use crate::protocol::FrontendEvent;
use crate::protocol::FrontendSlot;
use crate::protocol::FrontendTone;
use crate::protocol::FrontendWidget;
use crate::protocol::ReviewDecision;

const CAPABILITY: &str = "sandbox";
const POLICY_KEY: &str = "sandbox.approval_policy";
const MAX_SESSION_APPROVALS: usize = 64;

/// Whether approval-required tools pause before sandboxed execution.
#[derive(Debug, Clone, Copy, Default, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum ApprovalPolicy {
    #[default]
    On,
    Allow,
    AllowNetwork,
}

impl ApprovalPolicy {
    fn label(self) -> &'static str {
        match self {
            Self::On => "on",
            Self::Allow => "allow (no network)",
            Self::AllowNetwork => "allow (network)",
        }
    }

    fn network_access(self) -> NetworkAccess {
        match self {
            Self::On | Self::Allow => NetworkAccess::Denied,
            Self::AllowNetwork => NetworkAccess::Allowed,
        }
    }
}

#[derive(Default)]
struct ApprovalState {
    policy: ApprovalPolicy,
    approved_for_session: BTreeSet<[u8; 32]>,
}

pub(super) struct Approval {
    default_policy: ApprovalPolicy,
    states: Mutex<BTreeMap<String, ApprovalState>>,
}

impl Approval {
    pub(super) fn new(default_policy: ApprovalPolicy) -> Self {
        Self {
            default_policy,
            states: Mutex::new(BTreeMap::new()),
        }
    }

    pub(super) fn frontend(&self) -> FrontendContribution {
        FrontendContribution {
            capability: CAPABILITY.into(),
            commands: vec![FrontendCommand {
                name: "permissions".into(),
                arguments: "<on|allow|network>".into(),
                description: "set approvals and sandbox network access".into(),
            }],
            widgets: vec![widget(self.default_policy)],
            references: Vec::new(),
            active_input: None,
        }
    }

    pub(super) fn render(&self, event: &EventMsg) -> Option<FrontendBlock> {
        let EventMsg::ExecApprovalRequest(request) = event else {
            return None;
        };
        let tools = request
            .calls
            .iter()
            .map(|call| format!("{} {}", call.name, preview_json(&call.arguments)))
            .collect::<Vec<_>>()
            .join("\n  ");
        Some(FrontendBlock {
            id: None,
            group: None,
            append: false,
            pending: false,
            text: format!(
                "approve? [y] once · [a] session · [N] deny · [q] abort\n{}\n  {tools}",
                request.reason
            ),
            format: crate::protocol::FrontendBlockFormat::PlainText,
            tone: FrontendTone::Warning,
        })
    }

    pub(super) async fn initialize(
        &self,
        session_id: &str,
        checkpoints: &Arc<dyn CheckpointStore>,
    ) -> Result<Vec<FrontendEvent>> {
        let policy = checkpoints
            .load_state(session_id, POLICY_KEY)
            .await?
            .map(serde_json::from_value)
            .transpose()?
            .unwrap_or(self.default_policy);
        self.states.lock().map_err(|_| state_lock_error())?.insert(
            session_id.into(),
            ApprovalState {
                policy,
                approved_for_session: BTreeSet::new(),
            },
        );
        Ok(vec![FrontendEvent::Widget {
            capability: CAPABILITY.into(),
            item: widget(policy),
        }])
    }

    pub(super) async fn command(
        &self,
        session_id: &str,
        checkpoints: &Arc<dyn CheckpointStore>,
        command: &str,
        arguments: &str,
    ) -> Result<Vec<FrontendEvent>> {
        if command != "permissions" {
            return Err(Error::Unknown(format!("sandbox command `{command}`")));
        }
        let policy = match arguments.trim() {
            "on" => ApprovalPolicy::On,
            "allow" => ApprovalPolicy::Allow,
            "network" => ApprovalPolicy::AllowNetwork,
            "" => {
                let policy = self.state_policy(session_id)?;
                return Ok(vec![render(widget(policy).text, FrontendTone::Neutral)]);
            }
            _ => {
                return Ok(vec![render(
                    "! usage: permissions <on|allow|network>",
                    FrontendTone::Warning,
                )]);
            }
        };
        checkpoints
            .save_state(session_id, POLICY_KEY, &serde_json::to_value(policy)?)
            .await?;
        let mut states = self.states.lock().map_err(|_| state_lock_error())?;
        let state = states
            .get_mut(session_id)
            .ok_or_else(state_not_initialized)?;
        state.policy = policy;
        state.approved_for_session.clear();
        drop(states);
        Ok(vec![
            FrontendEvent::Widget {
                capability: CAPABILITY.into(),
                item: widget(policy),
            },
            render(
                format!("â—† permissions set to {}", policy.label()),
                FrontendTone::Success,
            ),
        ])
    }

    pub(super) fn authorize(
        &self,
        session_id: &str,
        calls: &[ToolCall],
        mutation_call_ids: &[String],
    ) -> Result<SandboxAuthorization> {
        let (policy, approved_for_session) = {
            let states = self.states.lock().map_err(|_| state_lock_error())?;
            let state = states.get(session_id).ok_or_else(state_not_initialized)?;
            (state.policy, state.approved_for_session.clone())
        };
        let calls_by_id = calls
            .iter()
            .map(|call| (call.call_id.as_str(), call))
            .collect::<BTreeMap<_, _>>();
        let mut approved = Vec::new();
        let mut requested = Vec::new();
        for call_id in mutation_call_ids {
            let call = calls_by_id
                .get(call_id.as_str())
                .ok_or_else(|| Error::Tool(format!("unknown mutation call `{call_id}`")))?;
            if policy != ApprovalPolicy::On
                || approved_for_session.contains(&call_key(session_id, call)?)
            {
                approved.push(call_id.clone());
            } else {
                requested.push(call_id.clone());
            }
        }
        let permissions = SandboxPermissions::new(session_id, policy.network_access(), approved);
        if requested.is_empty() {
            return Ok(SandboxAuthorization::Execute(permissions));
        }
        Ok(SandboxAuthorization::Approval {
            request: SandboxApprovalRequest {
                id: Uuid::new_v4().to_string(),
                reason: "one or more tools can mutate files or execute code".into(),
                call_ids: requested,
            },
            permissions,
        })
    }

    pub(super) fn resolve(
        &self,
        session_id: &str,
        calls: &[ToolCall],
        approval_call_ids: &[String],
        decision: &ReviewDecision,
        mut permissions: SandboxPermissions,
    ) -> Result<SandboxPermissions> {
        if !matches!(
            decision,
            ReviewDecision::Approved | ReviewDecision::ApprovedForSession
        ) {
            return Ok(permissions);
        }
        let calls_by_id = calls
            .iter()
            .map(|call| (call.call_id.as_str(), call))
            .collect::<BTreeMap<_, _>>();
        for call_id in approval_call_ids {
            if !calls_by_id.contains_key(call_id.as_str()) {
                return Err(Error::Tool(format!(
                    "approval references unknown call `{call_id}`"
                )));
            }
        }
        permissions.allow_mutations(approval_call_ids.iter().cloned());
        if !matches!(decision, ReviewDecision::ApprovedForSession) {
            return Ok(permissions);
        }
        let keys = approval_call_ids
            .iter()
            .map(|call_id| call_key(session_id, calls_by_id[call_id.as_str()]))
            .collect::<Result<Vec<_>>>()?;
        let mut states = self.states.lock().map_err(|_| state_lock_error())?;
        let state = states
            .get_mut(session_id)
            .ok_or_else(state_not_initialized)?;
        for key in keys {
            if state.approved_for_session.len() >= MAX_SESSION_APPROVALS {
                state.approved_for_session.clear();
            }
            state.approved_for_session.insert(key);
        }
        Ok(permissions)
    }

    pub(super) fn shutdown(&self, session_id: &str) -> Result<()> {
        self.states
            .lock()
            .map_err(|_| state_lock_error())?
            .remove(session_id);
        Ok(())
    }

    fn state_policy(&self, session_id: &str) -> Result<ApprovalPolicy> {
        self.states
            .lock()
            .map_err(|_| state_lock_error())?
            .get(session_id)
            .map(|state| state.policy)
            .ok_or_else(state_not_initialized)
    }
}

fn widget(policy: ApprovalPolicy) -> FrontendWidget {
    FrontendWidget {
        id: "approval_policy".into(),
        slot: FrontendSlot::Header,
        text: match policy {
            ApprovalPolicy::On => "approval ON".into(),
            ApprovalPolicy::Allow => "approval ALLOW".into(),
            ApprovalPolicy::AllowNetwork => "approval NETWORK".into(),
        },
        tone: if policy == ApprovalPolicy::On {
            FrontendTone::Neutral
        } else {
            FrontendTone::Warning
        },
        action: None,
    }
}

fn render(text: impl Into<String>, tone: FrontendTone) -> FrontendEvent {
    FrontendEvent::Render {
        capability: CAPABILITY.into(),
        block: FrontendBlock {
            id: None,
            group: None,
            append: false,
            pending: false,
            text: text.into(),
            format: crate::protocol::FrontendBlockFormat::PlainText,
            tone,
        },
    }
}

fn call_key(session_id: &str, call: &ToolCall) -> Result<[u8; 32]> {
    let mut writer = DigestWriter(Sha256::new());
    serde_json::to_writer(&mut writer, &(session_id, &call.name, &call.arguments))?;
    Ok(writer.0.finalize().into())
}

struct DigestWriter(Sha256);

impl Write for DigestWriter {
    fn write(&mut self, buffer: &[u8]) -> io::Result<usize> {
        self.0.update(buffer);
        Ok(buffer.len())
    }

    fn flush(&mut self) -> io::Result<()> {
        Ok(())
    }
}

fn state_lock_error() -> Error {
    Error::Stopped("approval state lock poisoned".into())
}

fn state_not_initialized() -> Error {
    Error::Stopped("approval state is not initialized".into())
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn only_network_permission_enables_backend_network() {
        assert_eq!(ApprovalPolicy::On.network_access(), NetworkAccess::Denied);
        assert_eq!(
            ApprovalPolicy::Allow.network_access(),
            NetworkAccess::Denied
        );
        assert_eq!(
            ApprovalPolicy::AllowNetwork.network_access(),
            NetworkAccess::Allowed
        );
    }

    #[test]
    fn approval_grants_only_the_reviewed_call() {
        let approval = Approval::new(ApprovalPolicy::On);
        approval
            .states
            .lock()
            .expect("approval state")
            .insert("session".into(), ApprovalState::default());
        let calls = [ToolCall {
            call_id: "write".into(),
            name: "write_file".into(),
            arguments: serde_json::json!({"path": "a"}),
        }];
        let SandboxAuthorization::Approval {
            request,
            permissions,
        } = approval
            .authorize("session", &calls, &["write".into()])
            .expect("authorization")
        else {
            panic!("approval required");
        };
        assert!(!permissions.for_call("write").mutation);

        let permissions = approval
            .resolve(
                "session",
                &calls,
                &request.call_ids,
                &ReviewDecision::Approved,
                permissions,
            )
            .expect("resolution");
        assert!(permissions.for_call("write").mutation);
    }
}