hk 1.45.0

A tool for managing git hooks
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113

use crate::Result;
use std::path::PathBuf;
use std::process::Command;

#[derive(Debug, clap::Args)]
pub struct PythonCheckAst {
    /// Files to check
    #[clap(required = true)]
    pub files: Vec<PathBuf>,
}

impl PythonCheckAst {
    pub async fn run(&self) -> Result<()> {
        let mut found_invalid = false;

        for file_path in &self.files {
            if !is_valid_python_syntax(file_path)? {
                println!("{}", file_path.display());
                found_invalid = true;
            }
        }

        if found_invalid {
            return Err(eyre::eyre!("Files with invalid Python syntax found"));
        }

        Ok(())
    }
}

fn is_valid_python_syntax(path: &PathBuf) -> Result<bool> {
    // Use python -m py_compile to check syntax
    // This is more reliable than ast.parse as it catches all syntax errors
    let output = Command::new("python3")
        .arg("-m")
        .arg("py_compile")
        .arg(path)
        .output();

    match output {
        Ok(result) => Ok(result.status.success()),
        Err(_) => {
            // If python3 is not available, try python
            let output = Command::new("python")
                .arg("-m")
                .arg("py_compile")
                .arg(path)
                .output();

            match output {
                Ok(result) => Ok(result.status.success()),
                Err(_) => {
                    // If neither python3 nor python is available, skip the file
                    Ok(true)
                }
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::fs;
    use tempfile::NamedTempFile;

    #[test]
    fn test_valid_python() {
        let file = NamedTempFile::new().unwrap();
        fs::write(
            file.path(),
            r#"
def hello():
    print("Hello, world!")
"#,
        )
        .unwrap();

        // This test will pass if Python is available
        if let Ok(valid) = is_valid_python_syntax(&file.path().to_path_buf()) {
            assert!(valid);
        }
    }

    #[test]
    fn test_invalid_python() {
        let file = NamedTempFile::new().unwrap();
        fs::write(
            file.path(),
            r#"
def hello(:
    print("Invalid syntax"
"#,
        )
        .unwrap();

        // This test will pass if Python is available
        if let Ok(valid) = is_valid_python_syntax(&file.path().to_path_buf()) {
            assert!(!valid);
        }
    }

    #[test]
    fn test_empty_file() {
        let file = NamedTempFile::new().unwrap();
        fs::write(file.path(), "").unwrap();

        if let Ok(valid) = is_valid_python_syntax(&file.path().to_path_buf()) {
            // Empty file is valid Python
            assert!(valid);
        }
    }
}