hjkl-form 0.3.0

Vim-modal forms for hjkl-based apps.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
//! Form-level FSM. Routes keys between focus navigation, field
//! delegation, and submit firing.

use crate::field::Field;
use crate::form::{Form, FormEvent, FormMode};
use crate::validate::validate_field;
use hjkl_engine::{Input, Key, VimMode, step};

impl Form {
    /// Route a key event through the form. Returns an event if the
    /// keystroke produced one (focus moved, value changed, submit
    /// fired, etc.).
    pub fn handle_input(&mut self, input: Input) -> Option<FormEvent> {
        if self.fields.is_empty() {
            return None;
        }
        match self.mode {
            FormMode::Normal => self.handle_normal(input),
            FormMode::Insert => self.handle_insert(input),
        }
    }

    fn handle_normal(&mut self, input: Input) -> Option<FormEvent> {
        // `gg` is the only two-key chord we model at the form level —
        // every other input clears the pending state.
        let was_pending_g = self.pending_g;
        if input.key != Key::Char('g') || input.ctrl || input.alt {
            self.pending_g = false;
        }

        // Esc cancels the form (host decides whether to close).
        if input.key == Key::Esc {
            return Some(FormEvent::Cancelled);
        }

        // Focus-navigation keys that work uniformly regardless of
        // focused-field type.
        if let Some(ev) = self.try_navigate(input, was_pending_g) {
            return Some(ev);
        }

        // Per-field-type handling.
        let field_kind = field_kind(&self.fields[self.focused]);
        match field_kind {
            FieldKind::Checkbox => self.handle_normal_checkbox(input),
            FieldKind::Select => self.handle_normal_select(input),
            FieldKind::Submit => self.handle_normal_submit(input),
            FieldKind::SingleLineText | FieldKind::MultiLineText => {
                self.handle_normal_text(input, field_kind == FieldKind::SingleLineText)
            }
        }
    }

    fn try_navigate(&mut self, input: Input, was_pending_g: bool) -> Option<FormEvent> {
        let len = self.fields.len();
        let mut moved = false;
        let prev = self.focused;
        match input.key {
            Key::Char('j') | Key::Down | Key::Tab if !input.ctrl && !input.alt => {
                self.focused = (self.focused + 1) % len;
                moved = true;
            }
            Key::Char('k') | Key::Up if !input.ctrl && !input.alt => {
                self.focused = self.focused.saturating_sub(1);
                moved = true;
            }
            // BackTab on most terminals comes through as Tab + shift;
            // crossterm-bridged inputs use Key::Tab with shift.
            Key::Tab if input.shift => {
                self.focused = self.focused.saturating_sub(1);
                moved = true;
            }
            Key::Char('g') if !input.ctrl && !input.alt && !input.shift => {
                if was_pending_g {
                    self.focused = 0;
                    moved = true;
                } else {
                    self.pending_g = true;
                    return None;
                }
            }
            Key::Char('G') if !input.ctrl && !input.alt => {
                self.focused = len - 1;
                moved = true;
            }
            _ => {}
        }
        if moved {
            if prev != self.focused {
                // Run blur validator on the previous field.
                validate_field(&mut self.fields[prev]);
                self.bump_dirty();
            }
            return Some(FormEvent::Changed);
        }
        None
    }

    fn handle_normal_checkbox(&mut self, input: Input) -> Option<FormEvent> {
        match input.key {
            Key::Char(' ') | Key::Enter => {
                if let Field::Checkbox(c) = &mut self.fields[self.focused] {
                    c.value = !c.value;
                }
                self.bump_dirty();
                Some(FormEvent::Changed)
            }
            _ => None,
        }
    }

    fn handle_normal_select(&mut self, input: Input) -> Option<FormEvent> {
        match input.key {
            Key::Char('l') | Key::Right if !input.ctrl && !input.alt => {
                if let Field::Select(s) = &mut self.fields[self.focused]
                    && !s.options.is_empty()
                {
                    s.index = (s.index + 1) % s.options.len();
                }
                self.bump_dirty();
                Some(FormEvent::Changed)
            }
            Key::Char('h') | Key::Left if !input.ctrl && !input.alt => {
                if let Field::Select(s) = &mut self.fields[self.focused]
                    && !s.options.is_empty()
                {
                    s.index = if s.index == 0 {
                        s.options.len() - 1
                    } else {
                        s.index - 1
                    };
                }
                self.bump_dirty();
                Some(FormEvent::Changed)
            }
            _ => None,
        }
    }

    fn handle_normal_submit(&mut self, input: Input) -> Option<FormEvent> {
        if input.key == Key::Enter || (input.key == Key::Char(' ') && !input.ctrl && !input.alt) {
            return Some(self.try_submit_event());
        }
        None
    }

    fn handle_normal_text(&mut self, input: Input, _single_line: bool) -> Option<FormEvent> {
        // i/I/a/A enter Insert mode — forward through vim::step so the
        // engine performs its own Normal→Insert transition.
        let entering_insert = matches!(
            input.key,
            Key::Char('i') | Key::Char('I') | Key::Char('a') | Key::Char('A')
        ) && !input.ctrl
            && !input.alt;

        let prev_gen_before;
        if let Field::SingleLineText(f) | Field::MultiLineText(f) = &mut self.fields[self.focused] {
            prev_gen_before = f.editor.buffer().dirty_gen();
            let _ = step(&mut f.editor, input);
            if entering_insert && f.editor.vim_mode() == VimMode::Insert {
                f.enter_gen = prev_gen_before;
                self.mode = FormMode::Insert;
                return Some(FormEvent::Changed);
            }
        }
        // Other motion keys (h/l/w/b/etc) just forwarded; emit Changed
        // so renderers refresh cursor.
        Some(FormEvent::Changed)
    }

    fn handle_insert(&mut self, input: Input) -> Option<FormEvent> {
        // Single-line text: Enter jumps to next field instead of
        // inserting a newline.
        let single = matches!(self.fields[self.focused], Field::SingleLineText(_));
        if single && input.key == Key::Enter {
            let len = self.fields.len();
            if self.focused + 1 < len {
                let prev = self.focused;
                self.focused += 1;
                validate_field(&mut self.fields[prev]);
                self.bump_dirty();
            }
            return Some(FormEvent::Changed);
        }

        // Forward to the focused field's editor.
        if let Field::SingleLineText(f) | Field::MultiLineText(f) = &mut self.fields[self.focused] {
            let before_gen = f.editor.buffer().dirty_gen();
            let _ = step(&mut f.editor, input);
            let after_mode = f.editor.vim_mode();
            let after_gen = f.editor.buffer().dirty_gen();
            if after_mode == VimMode::Normal {
                // User pressed Esc — leave insert mode.
                self.mode = FormMode::Normal;
                let prev_focus = self.focused;
                validate_field(&mut self.fields[prev_focus]);
                self.bump_dirty();
                return Some(FormEvent::Changed);
            }
            if after_gen != before_gen {
                self.bump_dirty();
                return Some(FormEvent::Changed);
            }
        }
        None
    }

    /// Run all validators; if all pass, fire the submit closure.
    /// Returns the appropriate `FormEvent`.
    fn try_submit_event(&mut self) -> FormEvent {
        match self.try_submit() {
            Some(outcome) => FormEvent::Submitted(outcome),
            None => FormEvent::ValidationFailed,
        }
    }
}

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum FieldKind {
    SingleLineText,
    MultiLineText,
    Select,
    Checkbox,
    Submit,
}

fn field_kind(field: &Field) -> FieldKind {
    match field {
        Field::SingleLineText(_) => FieldKind::SingleLineText,
        Field::MultiLineText(_) => FieldKind::MultiLineText,
        Field::Select(_) => FieldKind::Select,
        Field::Checkbox(_) => FieldKind::Checkbox,
        Field::Submit(_) => FieldKind::Submit,
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::field::{CheckboxField, FieldMeta, SelectField, SubmitField, TextFieldEditor};
    use crate::submit::SubmitOutcome;
    use std::sync::Arc;
    use std::sync::atomic::{AtomicBool, Ordering};

    fn key(c: char) -> Input {
        Input {
            key: Key::Char(c),
            ..Input::default()
        }
    }

    fn special(k: Key) -> Input {
        Input {
            key: k,
            ..Input::default()
        }
    }

    fn make_form() -> Form {
        Form::new()
            .with_field(Field::SingleLineText(TextFieldEditor::with_meta(
                FieldMeta::new("Name"),
                1,
            )))
            .with_field(Field::SingleLineText(TextFieldEditor::with_meta(
                FieldMeta::new("Email"),
                1,
            )))
            .with_field(Field::Checkbox(CheckboxField::new(FieldMeta::new("Save"))))
            .with_field(Field::Select(SelectField::new(
                FieldMeta::new("Format"),
                vec!["json".into(), "yaml".into(), "toml".into()],
            )))
            .with_field(Field::Submit(SubmitField::new(FieldMeta::new("Submit"))))
    }

    #[test]
    fn j_advances_focus() {
        let mut form = make_form();
        form.handle_input(key('j'));
        assert_eq!(form.focused(), 1);
    }

    #[test]
    fn j_past_end_wraps_to_zero() {
        let mut form = make_form();
        for _ in 0..form.fields.len() {
            form.handle_input(key('j'));
        }
        assert_eq!(form.focused(), 0);
    }

    #[test]
    fn k_past_zero_saturates() {
        let mut form = make_form();
        form.handle_input(key('k'));
        assert_eq!(form.focused(), 0);
    }

    #[test]
    fn gg_jumps_to_zero() {
        let mut form = make_form();
        form.handle_input(key('j'));
        form.handle_input(key('j'));
        assert_eq!(form.focused(), 2);
        form.handle_input(key('g'));
        form.handle_input(key('g'));
        assert_eq!(form.focused(), 0);
    }

    #[test]
    fn capital_g_jumps_to_last() {
        let mut form = make_form();
        let last = form.fields.len() - 1;
        form.handle_input(Input {
            key: Key::Char('G'),
            shift: true,
            ..Input::default()
        });
        assert_eq!(form.focused(), last);
    }

    #[test]
    fn i_on_text_enters_insert() {
        let mut form = make_form();
        form.handle_input(key('i'));
        assert_eq!(form.mode, FormMode::Insert);
    }

    #[test]
    fn esc_after_insert_returns_to_normal() {
        let mut form =
            make_form().with_field(Field::Submit(SubmitField::new(FieldMeta::new("Sub"))));
        // Enter insert, type a char, then Esc.
        form.handle_input(key('i'));
        assert_eq!(form.mode, FormMode::Insert);
        form.handle_input(key('x'));
        form.handle_input(special(Key::Esc));
        assert_eq!(form.mode, FormMode::Normal);
    }

    #[test]
    fn enter_on_submit_fires_submit_fn() {
        let fired = Arc::new(AtomicBool::new(false));
        let f2 = fired.clone();
        let mut form = make_form().with_submit(Box::new(move || {
            f2.store(true, Ordering::SeqCst);
            SubmitOutcome::Ok
        }));
        // Jump to last (Submit) field.
        form.handle_input(Input {
            key: Key::Char('G'),
            shift: true,
            ..Input::default()
        });
        let ev = form.handle_input(special(Key::Enter));
        assert!(matches!(ev, Some(FormEvent::Submitted(SubmitOutcome::Ok))));
        assert!(fired.load(Ordering::SeqCst));
    }

    #[test]
    fn submit_with_failing_validator_does_not_fire() {
        let fired = Arc::new(AtomicBool::new(false));
        let f2 = fired.clone();
        let mut name = TextFieldEditor::with_meta(FieldMeta::new("Name").required(true), 1);
        name.validator = Some(Box::new(|s: &str| {
            if s.is_empty() {
                Err("required".into())
            } else {
                Ok(())
            }
        }));
        let mut form = Form::new()
            .with_field(Field::SingleLineText(name))
            .with_field(Field::Submit(SubmitField::new(FieldMeta::new("Submit"))))
            .with_submit(Box::new(move || {
                f2.store(true, Ordering::SeqCst);
                SubmitOutcome::Ok
            }));
        form.handle_input(key('j'));
        let ev = form.handle_input(special(Key::Enter));
        assert!(matches!(ev, Some(FormEvent::ValidationFailed)));
        assert!(!fired.load(Ordering::SeqCst));
    }

    #[test]
    fn enter_in_insert_jumps_focus_to_next() {
        let mut form = make_form();
        form.handle_input(key('i'));
        assert_eq!(form.mode, FormMode::Insert);
        form.handle_input(special(Key::Enter));
        assert_eq!(form.focused(), 1);
        // Stays in Insert after the focus jump.
        assert_eq!(form.mode, FormMode::Insert);
    }

    #[test]
    fn checkbox_toggles_on_space() {
        let mut form = make_form();
        // Move to checkbox at index 2.
        form.handle_input(key('j'));
        form.handle_input(key('j'));
        assert_eq!(form.focused(), 2);
        form.handle_input(key(' '));
        if let Field::Checkbox(c) = &form.fields[2] {
            assert!(c.value);
        } else {
            panic!("expected checkbox");
        }
    }

    #[test]
    fn select_cycles_on_h_l() {
        let mut form = make_form();
        // Move to select at index 3.
        for _ in 0..3 {
            form.handle_input(key('j'));
        }
        assert_eq!(form.focused(), 3);
        form.handle_input(key('l'));
        if let Field::Select(s) = &form.fields[3] {
            assert_eq!(s.index, 1);
        } else {
            panic!("expected select");
        }
        form.handle_input(key('h'));
        form.handle_input(key('h'));
        if let Field::Select(s) = &form.fields[3] {
            assert_eq!(s.index, 2); // wrapped
        } else {
            panic!("expected select");
        }
    }
}