hive-router 0.2.0

GraphQL router for Federation, part of the Hive platform
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
use crate::query_planner::{
    tests::testkit::{build_query_plan_with_defaults, init_logger},
    utils::parsing::parse_operation,
};
use std::error::Error;

/// Regression test: multiple inline fragments on the same concrete type inside an abstract type
/// fragment should all be evaluated, not just the first one.
/// Uses `account(id:)` (concrete parent type `Account`) with a `... on Node` abstract fragment
/// to force the `expand_abstract_fragment` path, where two `... on Account` inline fragments
/// must both be collected and merged so all their fields appear in the query plan.
#[test]
fn multiple_inline_fragments_on_same_concrete_type_within_interface_fragment(
) -> Result<(), Box<dyn Error>> {
    init_logger();
    let document = parse_operation(
        r#"
        query {
          account(id: "a1") {
            ... on Node {
              ... on Account {
                id
              }
              ... on Account {
                username
              }
            }
          }
        }
        "#,
    );
    let query_plan = build_query_plan_with_defaults(
        "fixture/tests/corrupted-supergraph-node-id.supergraph.graphql",
        document,
    )?;

    insta::assert_snapshot!(format!("{}", query_plan), @r#"
    QueryPlan {
      Fetch(service: "a") {
        {
          account(id: "a1") {
            id
            username
          }
        }
      },
    },
    "#);

    Ok(())
}

/// Regression test: when an abstract-type fragment carries a directive (e.g. `@include`)
/// and a nested concrete-type fragment carries another `@include` with a *different*
/// argument, both conditions must be preserved in the query plan. Because `@include`/
/// `@skip` are non-repeatable, the parent directive must be carried by an outer wrapper
/// fragment around the inner one.
#[test]
fn nested_same_name_directives_on_abstract_and_concrete_fragments() -> Result<(), Box<dyn Error>> {
    init_logger();
    let document = parse_operation(
        r#"
        query ($parent: Boolean!, $child: Boolean!) {
          account(id: "a1") {
            ... on Node @include(if: $parent) {
              ... on Account @include(if: $child) {
                username
              }
            }
          }
        }
        "#,
    );
    let query_plan = build_query_plan_with_defaults(
        "fixture/tests/corrupted-supergraph-node-id.supergraph.graphql",
        document,
    )?;

    insta::assert_snapshot!(format!("{}", query_plan), @r#"
    QueryPlan {
      Fetch(service: "a") {
        query ($child:Boolean!,$parent:Boolean!) {
          account(id: "a1") {
            ... on Account @include(if: $parent) {
              ... on Account @include(if: $child) {
                username
              }
            }
          }
        }
      },
    },
    "#);

    Ok(())
}

/// When the parent abstract fragment and the nested concrete fragment carry the
/// *same* directive with the *same* argument, the duplicate must be collapsed —
/// no redundant nesting should appear in the plan.
#[test]
fn nested_same_directive_same_arg_on_abstract_and_concrete_fragments() -> Result<(), Box<dyn Error>>
{
    init_logger();
    let document = parse_operation(
        r#"
        query ($cond: Boolean!) {
          account(id: "a1") {
            ... on Node @include(if: $cond) {
              ... on Account @include(if: $cond) {
                username
              }
            }
          }
        }
        "#,
    );
    let query_plan = build_query_plan_with_defaults(
        "fixture/tests/corrupted-supergraph-node-id.supergraph.graphql",
        document,
    )?;

    insta::assert_snapshot!(format!("{}", query_plan), @r#"
    QueryPlan {
      Fetch(service: "a") {
        query ($cond:Boolean!) {
          account(id: "a1") {
            ... on Account @include(if: $cond) {
              username
            }
          }
        }
      },
    },
    "#);

    Ok(())
}

/// When the parent abstract fragment carries `@skip` and the nested concrete fragment
/// carries `@include`, both directives must be preserved (different names, so they can
/// be merged onto the same fragment).
#[test]
fn nested_different_directives_on_abstract_and_concrete_fragments() -> Result<(), Box<dyn Error>> {
    init_logger();
    let document = parse_operation(
        r#"
        query ($skip: Boolean!, $include: Boolean!) {
          account(id: "a1") {
            ... on Node @skip(if: $skip) {
              ... on Account @include(if: $include) {
                username
              }
            }
          }
        }
        "#,
    );
    let query_plan = build_query_plan_with_defaults(
        "fixture/tests/corrupted-supergraph-node-id.supergraph.graphql",
        document,
    )?;

    let plan_str = format!("{}", query_plan);
    assert!(
        plan_str.contains("$skip"),
        "parent @skip directive must be preserved: {plan_str}"
    );
    assert!(
        plan_str.contains("$include"),
        "child @include directive must be preserved: {plan_str}"
    );

    insta::assert_snapshot!(plan_str, @r#"
    QueryPlan {
      Fetch(service: "a") {
        query ($include:Boolean!,$skip:Boolean!) {
          account(id: "a1") {
            ... on Account @skip(if: $skip) @include(if: $include) {
              username
            }
          }
        }
      },
    },
    "#);

    Ok(())
}

/// When the parent abstract fragment carries `@include` and the nested concrete fragment
/// has *no* directive, the parent's `@include` must be merged onto the concrete fragment.
#[test]
fn parent_directive_only_on_abstract_fragment() -> Result<(), Box<dyn Error>> {
    init_logger();
    let document = parse_operation(
        r#"
        query ($parent: Boolean!) {
          account(id: "a1") {
            ... on Node @include(if: $parent) {
              ... on Account {
                username
              }
            }
          }
        }
        "#,
    );
    let query_plan = build_query_plan_with_defaults(
        "fixture/tests/corrupted-supergraph-node-id.supergraph.graphql",
        document,
    )?;

    insta::assert_snapshot!(format!("{}", query_plan), @r#"
    QueryPlan {
      Fetch(service: "a") {
        query ($parent:Boolean!) {
          account(id: "a1") {
            ... on Account @include(if: $parent) {
              username
            }
          }
        }
      },
    },
    "#);

    Ok(())
}

/// Reusing the same named fragment with different `@include` conditions on the same
/// concrete parent must preserve both conditions as separate wrappers.
#[test]
fn reusable_fragment_with_mixed_include_conditions_on_concrete_parent() -> Result<(), Box<dyn Error>>
{
    init_logger();
    let document = parse_operation(
        r#"
        query ($first: Boolean!, $second: Boolean!) {
          account(id: "a1") {
            ...AccountFields @include(if: $first)
            ...AccountFields @include(if: $second)
          }
        }

        fragment AccountFields on Account {
          username
        }
        "#,
    );
    let query_plan = build_query_plan_with_defaults(
        "fixture/tests/corrupted-supergraph-node-id.supergraph.graphql",
        document,
    )?;

    insta::assert_snapshot!(format!("{}", query_plan), @r#"
    QueryPlan {
      Fetch(service: "a") {
        query ($first:Boolean!,$second:Boolean!) {
          account(id: "a1") {
            ... on Account @include(if: $first) {
              ...a
            }
            ... on Account @include(if: $second) {
              ...a
            }
          }
        }
        fragment a on Account {
          username
        }
      },
    },
    "#);

    Ok(())
}

/// Reusing the same named fragment with different `@include` conditions under an
/// abstract parent must keep both conditions through type expansion.
#[test]
fn reusable_fragment_with_mixed_include_conditions_on_abstract_parent() -> Result<(), Box<dyn Error>>
{
    init_logger();
    let document = parse_operation(
        r#"
        query ($first: Boolean!, $second: Boolean!) {
          account(id: "a1") {
            ... on Node {
              ...AccountFields @include(if: $first)
              ...AccountFields @include(if: $second)
            }
          }
        }

        fragment AccountFields on Account {
          username
        }
        "#,
    );
    let query_plan = build_query_plan_with_defaults(
        "fixture/tests/corrupted-supergraph-node-id.supergraph.graphql",
        document,
    )?;

    insta::assert_snapshot!(format!("{}", query_plan), @r#"
    QueryPlan {
      Fetch(service: "a") {
        query ($first:Boolean!,$second:Boolean!) {
          account(id: "a1") {
            ... on Account @include(if: $first) {
              ...a
            }
            ... on Account @include(if: $second) {
              ...a
            }
          }
        }
        fragment a on Account {
          username
        }
      },
    },
    "#);

    Ok(())
}

#[test]
fn simple_inline_fragment() -> Result<(), Box<dyn Error>> {
    init_logger();
    let document = parse_operation(
        r#"
            query {
              products {
                price {
                  amount
                  currency
                }
                ... on Product {
                  isAvailable
                }
              }
            }"#,
    );
    let query_plan =
        build_query_plan_with_defaults("fixture/tests/testing.supergraph.graphql", document)?;

    insta::assert_snapshot!(format!("{}", query_plan), @r#"
    QueryPlan {
      Sequence {
        Fetch(service: "store") {
          {
            products {
              __typename
              id
            }
          }
        },
        Flatten(path: "products") {
          Fetch(service: "info") {
            {
              ... on Product {
                __typename
                id
              }
            } =>
            {
              ... on Product {
                isAvailable
                uuid
              }
            }
          },
        },
        Flatten(path: "products") {
          Fetch(service: "cost") {
            {
              ... on Product {
                __typename
                uuid
              }
            } =>
            {
              ... on Product {
                price {
                  amount
                  currency
                }
              }
            }
          },
        },
      },
    },
    "#);

    Ok(())
}

#[test]
fn fragment_spread() -> Result<(), Box<dyn Error>> {
    init_logger();
    let document = parse_operation(
        r#"
        fragment ProductInfo on Product {
          isAvailable
        }

        query {
          products {
            price {
              amount
              currency
            }
            ...ProductInfo
          }
        }"#,
    );
    let query_plan =
        build_query_plan_with_defaults("fixture/tests/testing.supergraph.graphql", document)?;

    insta::assert_snapshot!(format!("{}", query_plan), @r#"
    QueryPlan {
      Sequence {
        Fetch(service: "store") {
          {
            products {
              __typename
              id
            }
          }
        },
        Flatten(path: "products") {
          Fetch(service: "info") {
            {
              ... on Product {
                __typename
                id
              }
            } =>
            {
              ... on Product {
                isAvailable
                uuid
              }
            }
          },
        },
        Flatten(path: "products") {
          Fetch(service: "cost") {
            {
              ... on Product {
                __typename
                uuid
              }
            } =>
            {
              ... on Product {
                price {
                  amount
                  currency
                }
              }
            }
          },
        },
      },
    },
    "#);

    Ok(())
}