1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509
// Copyright 2018 Alex Ostrovski
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//! Serializing byte buffers as hex strings with `serde`.
//!
//! # Problem
//!
//! Sometimes, you need to serialize a byte buffer (say, a newtype around `[u8; 32]` or `Vec<u8>`)
//! as a hex string. The problem is, the newtype in question can be defined in another crate
//! (for example, cryptographic types from [`sodiumoxide`]), so you can't implement `Serialize` /
//! `Deserialize` for the type due to Rust orphaning rules. (Or maybe `Serialize` / `Deserialize`
//! *are* implemented, but not in the desirable way.)
//!
//! # Solution
//!
//! The core of this crate is the [`Hex`] trait. It provides methods `serialize`
//! and `deserialize`, which signatures match the ones expected by `serde`. These methods
//! use the other two required methods of the trait. As all trait methods have no `self` argument,
//! the trait *can* be implemented for external types; the implementor may be an empty `enum`
//! designated specifically for this purpose. The implementor can then be used
//! for (de)serialization with the help of the `#[serde(with)]` attribute.
//!
//! [`sodiumoxide`]: https://crates.io/crates/sodiumoxide
//! [`Hex`]: trait.Hex.html
//!
//! # Examples
//!
//! ```
//! // Assume this type is defined in an external crate.
//! pub struct Buffer([u8; 8]);
//!
//! impl Buffer {
//! pub fn from_slice(slice: &[u8]) -> Option<Self> {
//! // snip
//! # unimplemented!()
//! }
//! }
//!
//! impl AsRef<[u8]> for Buffer {
//! fn as_ref(&self) -> &[u8] {
//! &self.0
//! }
//! }
//!
//! // We define in our crate:
//! # extern crate serde;
//! # #[macro_use] extern crate serde_derive;
//! extern crate hex_buffer_serde;
//! use hex_buffer_serde::Hex;
//!
//! # use std::borrow::Cow;
//! enum BufferHex {} // a single-purpose type for use in `#[serde(with)]`
//! impl Hex<Buffer> for BufferHex {
//! fn create_bytes(buffer: &Buffer) -> Cow<[u8]> {
//! buffer.as_ref().into()
//! }
//!
//! fn from_bytes(bytes: &[u8]) -> Result<Buffer, String> {
//! Buffer::from_slice(bytes).ok_or_else(|| "invalid byte length".to_owned())
//! }
//! }
//!
//! #[derive(Serialize, Deserialize)]
//! pub struct Example {
//! #[serde(with = "BufferHex")]
//! buffer: Buffer,
//! // other fields...
//! }
//!
//! # fn main() {}
//! ```
//!
//! # Use with internal types
//!
//! The crate could still be useful if you have control over the serialized buffer type.
//! `Hex<T>` has a blanket implementation for types `T` satisfying certain constraints:
//! `AsRef<[u8]>` and `TryFromSlice` (which is a makeshift replacement for `TryFrom<&[u8]>`
//! until `TryFrom` is stabilized). If these constraints are satisfied, you can
//! use `HexForm::<T>` in `#[serde(with)]`:
//!
//! ```
//! # extern crate serde;
//! # #[macro_use] extern crate serde_derive;
//! # extern crate hex_buffer_serde;
//! // It is necessary for `Hex` to be in scope in order
//! // for `serde`-generated code to use its `serialize` / `deserialize` methods.
//! use hex_buffer_serde::{Hex, HexForm, TryFromSlice, TryFromSliceError};
//!
//! pub struct OurBuffer([u8; 8]);
//!
//! impl TryFromSlice for OurBuffer {
//! type Error = TryFromSliceError;
//!
//! fn try_from_slice(slice: &[u8]) -> Result<Self, Self::Error> {
//! // snip
//! # unimplemented!()
//! }
//! }
//!
//! impl AsRef<[u8]> for OurBuffer {
//! fn as_ref(&self) -> &[u8] {
//! &self.0
//! }
//! }
//!
//! #[derive(Serialize, Deserialize)]
//! pub struct Example {
//! #[serde(with = "HexForm::<OurBuffer>")]
//! buffer: OurBuffer,
//! // other fields...
//! }
//!
//! # fn main() {}
//! ```
#![deny(missing_docs, missing_debug_implementations)]
extern crate failure;
#[macro_use]
extern crate failure_derive;
extern crate hex;
extern crate serde;
// Testing imports.
#[cfg(test)]
extern crate bincode;
#[cfg(test)]
#[macro_use]
extern crate serde_derive;
#[cfg(test)]
#[macro_use]
extern crate serde_json;
#[cfg(test)]
extern crate serde_cbor;
use serde::{de::Visitor, Deserializer, Serializer};
use std::{borrow::Cow, fmt, marker::PhantomData};
/// Fallible conversion from a byte slice.
///
/// This trait is needed until `TryFrom` is stabilized.
pub trait TryFromSlice: Sized {
/// Error that can occur during conversion.
type Error;
/// Tries to perform the conversion.
fn try_from_slice(slice: &[u8]) -> Result<Self, Self::Error>;
}
impl TryFromSlice for Vec<u8> {
type Error = &'static str; // should be `!`, but it's not stable yet
fn try_from_slice(slice: &[u8]) -> Result<Self, Self::Error> {
Ok(slice.to_vec())
}
}
/// Error converting a slice into an array.
#[derive(Debug, Fail)]
#[fail(display = "failed to convert slice to array")]
pub struct TryFromSliceError;
macro_rules! impl_for_array {
($($n:expr,)+) => {
$(
impl TryFromSlice for [u8; $n] {
type Error = TryFromSliceError;
fn try_from_slice(slice: &[u8]) -> Result<Self, Self::Error> {
if slice.len() != $n {
Err(TryFromSliceError)
} else {
let mut bytes = [0; $n];
bytes.copy_from_slice(slice);
Ok(bytes)
}
}
}
)+
}
}
impl_for_array!(
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25,
26, 27, 28, 29, 30, 31, 32, 40, 48, 64, 80, 96, 128, 160, 192, 256,
);
/// Provides hex-encoded (de)serialization for `serde`.
///
/// Note that the trait is automatically implemented for types that
/// implement `AsRef<[u8]>` and [`TryFromSlice`].
///
/// [`TryFromSlice`]: trait.TryFromSlice.html
pub trait Hex<T> {
/// Converts the value into bytes. This is used for serialization.
///
/// The returned buffer can be either borrowed from the type, or created by the method.
fn create_bytes(value: &T) -> Cow<[u8]>;
/// Creates a value from the byte slice.
///
/// # Errors
///
/// If this method fails, it should return a human-readable error description conforming
/// to `serde` conventions (no upper-casing of the first letter, no punctuation at the end).
fn from_bytes(bytes: &[u8]) -> Result<T, String>;
/// Serializes the value for `serde`. This method is not meant to be overridden.
///
/// The serialization is a lower-case hex string
/// for [human-readable][hr] serializers (e.g., JSON or TOML), and the original bytes
/// returned by [`create_bytes`] for non-human-readable ones.
///
/// [hr]: https://docs.rs/serde/^1.0/serde/trait.Serializer.html#method.is_human_readable
/// [`create_bytes`]: #tymethod.create_bytes
fn serialize<S: Serializer>(value: &T, serializer: S) -> Result<S::Ok, S::Error> {
let value = Self::create_bytes(value);
if serializer.is_human_readable() {
serializer.serialize_str(&hex::encode(value))
} else {
serializer.serialize_bytes(value.as_ref())
}
}
/// Deserializes a value using `serde`. This method is not meant to be overridden.
///
/// If the deserializer is [human-readable][hr] (e.g., JSON or TOML), this method
/// expects a hex-encoded string. Otherwise, the method expects a byte array.
///
/// [hr]: https://docs.rs/serde/^1.0/serde/trait.Deserializer.html#method.is_human_readable
fn deserialize<'de, D>(deserializer: D) -> Result<T, D::Error>
where
D: Deserializer<'de>,
{
use serde::de::Error as DeError;
struct HexVisitor;
impl<'de> Visitor<'de> for HexVisitor {
type Value = Vec<u8>;
fn expecting(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.write_str("hex-encoded byte array")
}
fn visit_str<E: DeError>(self, value: &str) -> Result<Self::Value, E> {
hex::decode(value).map_err(E::custom)
}
// See the `deserializing_flattened_field` test for an example why this is needed.
fn visit_bytes<E: DeError>(self, value: &[u8]) -> Result<Self::Value, E> {
Ok(value.to_vec())
}
}
struct BytesVisitor;
impl<'de> Visitor<'de> for BytesVisitor {
type Value = Vec<u8>;
fn expecting(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.write_str("byte array")
}
fn visit_bytes<E: DeError>(self, value: &[u8]) -> Result<Self::Value, E> {
Ok(value.to_vec())
}
}
let maybe_bytes = if deserializer.is_human_readable() {
deserializer.deserialize_str(HexVisitor)
} else {
deserializer.deserialize_bytes(BytesVisitor)
};
maybe_bytes.and_then(|bytes| Self::from_bytes(&bytes).map_err(D::Error::custom))
}
}
/// A dummy container for use inside `#[serde(with)]` attribute.
///
/// # Why a separate container?
///
/// We need a separate type (instead of just using `impl<T> Hex<T> for T`)
/// both for code clarity and because otherwise invocations within generated `serde` code
/// would be ambiguous for types implementing `Serialize` / `Deserialize`.
#[derive(Debug)]
pub struct HexForm<T>(PhantomData<T>);
impl<T> Hex<T> for HexForm<T>
where
T: AsRef<[u8]> + TryFromSlice,
<T as TryFromSlice>::Error: fmt::Display,
{
fn create_bytes(buffer: &T) -> Cow<[u8]> {
Cow::Borrowed(buffer.as_ref())
}
fn from_bytes(bytes: &[u8]) -> Result<T, String> {
T::try_from_slice(bytes).map_err(|e| e.to_string())
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn internal_type() {
pub struct Buffer([u8; 8]);
impl AsRef<[u8]> for Buffer {
fn as_ref(&self) -> &[u8] {
&self.0
}
}
impl TryFromSlice for Buffer {
type Error = TryFromSliceError;
fn try_from_slice(slice: &[u8]) -> Result<Self, Self::Error> {
<[u8; 8]>::try_from_slice(slice).map(Buffer)
}
}
#[derive(Serialize, Deserialize)]
struct Test {
#[serde(with = "HexForm::<Buffer>")]
buffer: Buffer,
other_field: String,
}
let json = json!({ "buffer": "0001020304050607", "other_field": "abc" });
let value: Test = serde_json::from_value(json.clone()).unwrap();
assert!(
value
.buffer
.0
.iter()
.enumerate()
.all(|(i, &byte)| i == usize::from(byte))
);
let json_copy = serde_json::to_value(&value).unwrap();
assert_eq!(json, json_copy);
}
#[test]
fn internal_type_with_derived_serde_code() {
#[derive(Serialize, Deserialize)]
pub struct Buffer([u8; 8]);
impl AsRef<[u8]> for Buffer {
fn as_ref(&self) -> &[u8] {
&self.0
}
}
impl TryFromSlice for Buffer {
type Error = TryFromSliceError;
fn try_from_slice(slice: &[u8]) -> Result<Self, Self::Error> {
<[u8; 8]>::try_from_slice(slice).map(Buffer)
}
}
// here, a hex form should be used.
#[derive(Serialize, Deserialize)]
struct HexTest {
#[serde(with = "HexForm::<Buffer>")]
buffer: Buffer,
other_field: String,
}
// ...and here, we may use original `serde` code.
#[derive(Serialize, Deserialize)]
struct OriginalTest {
buffer: Buffer,
other_field: String,
}
let test = HexTest {
buffer: Buffer([1; 8]),
other_field: "a".to_owned(),
};
assert_eq!(
serde_json::to_value(test).unwrap(),
json!({
"buffer": "0101010101010101",
"other_field": "a",
})
);
let test = OriginalTest {
buffer: Buffer([1; 8]),
other_field: "a".to_owned(),
};
assert_eq!(
serde_json::to_value(test).unwrap(),
json!({
"buffer": [1, 1, 1, 1, 1, 1, 1, 1],
"other_field": "a",
})
);
}
#[test]
fn external_type() {
#[derive(Debug, PartialEq, Eq)]
pub struct Buffer([u8; 8]);
enum BufferHex {}
impl Hex<Buffer> for BufferHex {
fn create_bytes(buffer: &Buffer) -> Cow<[u8]> {
Cow::Borrowed(&buffer.0)
}
fn from_bytes(bytes: &[u8]) -> Result<Buffer, String> {
if bytes.len() == 8 {
let mut inner = [0; 8];
inner.copy_from_slice(bytes);
Ok(Buffer(inner))
} else {
Err("invalid buffer length".to_owned())
}
}
}
#[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
struct Test {
#[serde(with = "BufferHex")]
buffer: Buffer,
other_field: String,
}
let json = json!({ "buffer": "0001020304050607", "other_field": "abc" });
let value: Test = serde_json::from_value(json.clone()).unwrap();
assert!(
value
.buffer
.0
.iter()
.enumerate()
.all(|(i, &byte)| i == usize::from(byte))
);
let json_copy = serde_json::to_value(&value).unwrap();
assert_eq!(json, json_copy);
// Test binary / non-human readable format.
let buffer = bincode::serialize(&value).unwrap();
// Conversion to hex is needed to be able to search for a pattern.
let buffer_hex = hex::encode(&buffer);
// Check that the buffer is stored in the serialization compactly,
// as original bytes.
let needle = "0001020304050607";
assert!(buffer_hex.contains(needle));
let value_copy: Test = bincode::deserialize(&buffer).unwrap();
assert_eq!(value_copy, value);
}
#[test]
fn deserializing_flattened_field() {
// The fields in the flattened structure are somehow read with
// a human-readable `Deserializer`, even if the original `Deserializer`
// is not human-readable.
#[derive(Debug, PartialEq, Serialize, Deserialize)]
struct Inner {
#[serde(with = "HexForm")]
x: Vec<u8>,
#[serde(with = "HexForm")]
y: [u8; 16],
}
#[derive(Debug, PartialEq, Serialize, Deserialize)]
struct Outer {
#[serde(flatten)]
inner: Inner,
z: String,
}
let value = Outer {
inner: Inner {
x: vec![1; 8],
y: [0; 16],
},
z: "test".to_owned(),
};
let bytes = serde_cbor::to_vec(&value).unwrap();
let bytes_hex = hex::encode(&bytes);
// Check that byte buffers are stored in the binary form.
assert!(bytes_hex.contains(&"01".repeat(8)));
assert!(bytes_hex.contains(&"00".repeat(16)));
let value_copy = serde_cbor::from_slice(&bytes).unwrap();
assert_eq!(value, value_copy);
}
}