hermit-run 0.4.0

Hermit: a deterministic Linux execution engine for reproducible runs, record and replay, and concurrency-race search.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
/*
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 * All rights reserved.
 *
 * This source code is licensed under the BSD-style license found in the
 * LICENSE file in the root directory of this source tree.
 */

use reverie::Errno;
use reverie::Guest;
use reverie::syscalls::AddrMut;
use reverie::syscalls::EpollWait;
use reverie::syscalls::MemoryAccess;
use reverie::syscalls::Poll;
use reverie::syscalls::PollFd;
use reverie::syscalls::Ppoll;
use reverie::syscalls::Pselect6;
use reverie::syscalls::Recvfrom;
use reverie::syscalls::Recvmsg;
use reverie::syscalls::Select;
use reverie::syscalls::Timespec;
use reverie::syscalls::family::SockOptFamily;

use super::Replayer;
use crate::event::PollEvent;
use crate::event::PpollEvent;
use crate::event::SelectEvent;
use crate::event::fd_set_bytes;

fn replay_pollfds<M: MemoryAccess>(
    memory: &mut M,
    fds_address: Option<AddrMut<'_, PollFd>>,
    nfds: usize,
    result: Result<i64, Errno>,
    fds_pointer_present: bool,
    fds: Option<Vec<PollFd>>,
) -> Result<(), Errno> {
    assert_eq!(
        fds_address.is_some(),
        fds_pointer_present,
        "recorded pollfd pointer shape diverged during replay"
    );

    if matches!(result, Ok(_) | Err(Errno::EINTR)) {
        assert_eq!(fds.is_some(), fds_pointer_present);
        if let Ok(updated) = result {
            assert!(updated >= 0);
            assert!((updated as usize) <= nfds);
        }
    } else if !matches!(result, Err(Errno::EFAULT)) {
        assert!(fds.is_none());
    }

    if let Some(fds) = fds {
        assert!(fds.len() <= nfds);
        if matches!(result, Ok(_) | Err(Errno::EINTR)) {
            assert_eq!(fds.len(), nfds);
        }
        let address = fds_address.expect("recorded pollfd output requires a pointer");
        let write_result = memory.write_values(address, &fds);
        if matches!(result, Err(Errno::EFAULT)) {
            // The same page boundary that made Linux return EFAULT can make
            // this replay write fault after restoring an earlier prefix. Keep
            // going so ppoll can also restore its captured timeout, then return
            // the recorded errno unchanged.
            if let Err(error) = write_result {
                tracing::trace!(?error, "partial pollfd replay write returned an error");
            }
        } else {
            write_result?;
        }
    }
    Ok(())
}

fn replay_poll_event<M: MemoryAccess>(
    memory: &mut M,
    fds_address: Option<AddrMut<'_, PollFd>>,
    nfds: usize,
    event: PollEvent,
) -> Result<i64, Errno> {
    let PollEvent {
        result,
        fds_pointer_present,
        fds,
    } = event;
    replay_pollfds(memory, fds_address, nfds, result, fds_pointer_present, fds)?;
    result
}

fn replay_ppoll_event<M: MemoryAccess>(
    memory: &mut M,
    fds_address: Option<AddrMut<'_, libc::pollfd>>,
    timeout_address: Option<AddrMut<'_, Timespec>>,
    nfds: usize,
    event: PpollEvent,
) -> Result<i64, Errno> {
    let PpollEvent {
        result,
        fds_pointer_present,
        fds,
        timeout_pointer_present,
        timeout,
    } = event;

    replay_pollfds(
        memory,
        fds_address.map(|address| address.cast::<PollFd>()),
        nfds,
        result,
        fds_pointer_present,
        fds,
    )?;

    assert_eq!(
        timeout_address.is_some(),
        timeout_pointer_present,
        "recorded ppoll timeout pointer shape diverged during replay"
    );
    if !matches!(result, Err(Errno::EFAULT)) {
        assert_eq!(timeout.is_some(), timeout_pointer_present);
    }
    if let Some(timeout) = timeout {
        let address = timeout_address.expect("recorded ppoll timeout requires a pointer");
        // Linux preserves the ppoll result when remaining-time copyout faults.
        // Restore the exact captured value when possible, but never replace the
        // recorded result with a replay-only memory error.
        if let Err(error) = memory.write_value(address, &timeout) {
            tracing::trace!(?error, "ppoll timeout replay write returned an error");
        }
    }

    result
}

fn write_bytes<M: MemoryAccess>(
    memory: &mut M,
    pointer: *mut libc::c_void,
    bytes: &[u8],
) -> Result<(), Errno> {
    if bytes.is_empty() {
        return Ok(());
    }
    let address = AddrMut::<u8>::from_raw(pointer as usize).ok_or(Errno::EFAULT)?;
    memory.write_exact(address.cast(), bytes)
}

fn replay_select_event<M: MemoryAccess>(
    memory: &mut M,
    nfds: i32,
    fd_set_addresses: [Option<AddrMut<'_, libc::fd_set>>; 3],
    timeout_address: Option<AddrMut<'_, u8>>,
    event: SelectEvent,
) -> Result<i64, Errno> {
    let SelectEvent {
        result,
        fd_sets,
        timeout,
    } = event;
    let length = fd_set_bytes(nfds);
    for (address, bytes) in fd_set_addresses.into_iter().zip(fd_sets) {
        let Some(bytes) = bytes else {
            assert!(
                address.is_none() || result.is_err(),
                "recorded select omitted a set the kernel copied out"
            );
            continue;
        };
        assert!(bytes.len() <= length);
        let address = address.expect("recorded select set output requires a pointer");
        let write_result = write_bytes(memory, address.as_raw() as *mut libc::c_void, &bytes);
        if matches!(result, Err(Errno::EFAULT)) {
            // As for ppoll: the fault that ended the recorded copy-out may end
            // this one too. The recorded errno is still the result.
            if let Err(error) = write_result {
                tracing::trace!(?error, "partial select set replay write returned an error");
            }
        } else {
            write_result?;
        }
    }
    if let Some(timeout) = timeout {
        let address = timeout_address.expect("recorded select timeout requires a pointer");
        // Linux keeps the select result when the remaining-time write faults.
        if let Err(error) = write_bytes(memory, address.as_raw() as *mut libc::c_void, &timeout) {
            tracing::trace!(?error, "select timeout replay write returned an error");
        }
    }
    result
}

fn cmsg_align(length: usize) -> Option<usize> {
    let alignment = std::mem::size_of::<usize>();
    length
        .checked_add(alignment - 1)
        .map(|value| value & !(alignment - 1))
}

fn scm_rights_fds(control: &[u8]) -> Vec<i32> {
    let header_size = std::mem::size_of::<libc::cmsghdr>();
    let data_offset = cmsg_align(header_size).unwrap();
    let mut offset: usize = 0;
    let mut fds = Vec::new();

    while offset
        .checked_add(header_size)
        .is_some_and(|end| end <= control.len())
    {
        // The recorded control buffer has native cmsghdr layout but may not be
        // aligned as a Vec<u8>, so read the header without assuming alignment.
        let header = unsafe {
            std::ptr::read_unaligned(control.as_ptr().add(offset).cast::<libc::cmsghdr>())
        };
        let length = header.cmsg_len;
        let Some(end) = offset.checked_add(length) else {
            break;
        };
        if length < data_offset || end > control.len() {
            break;
        }

        if header.cmsg_level == libc::SOL_SOCKET && header.cmsg_type == libc::SCM_RIGHTS {
            let (fd_bytes, _) =
                control[offset + data_offset..end].as_chunks::<{ std::mem::size_of::<i32>() }>();
            for bytes in fd_bytes {
                let fd = i32::from_ne_bytes(*bytes);
                if fd >= 0 {
                    fds.push(fd);
                }
            }
        }

        let Some(aligned_length) = cmsg_align(length) else {
            break;
        };
        let Some(next) = offset.checked_add(aligned_length) else {
            break;
        };
        if next <= offset {
            break;
        }
        offset = next;
    }
    fds
}

impl Replayer {
    pub(super) async fn handle_epoll_wait<G: Guest<Self>>(
        &self,
        guest: &mut G,
        syscall: EpollWait,
    ) -> Result<i64, Errno> {
        let event = next_event!(guest, EpollWait)?;
        if event.replay_kernel_side_effect {
            let actual = guest.inject(syscall).await;
            assert_eq!(
                actual,
                Ok(event.updated as i64),
                "replayed epoll_wait kernel side effect diverged"
            );
        }
        assert_eq!(
            event.events.len(),
            event.updated * std::mem::size_of::<libc::epoll_event>()
        );
        assert!(event.updated <= syscall.maxevents() as usize);

        if !event.events.is_empty() {
            guest
                .memory()
                .write_exact(syscall.events().ok_or(Errno::EFAULT)?.cast(), &event.events)?;
        }
        Ok(event.updated as i64)
    }

    pub(super) async fn handle_poll<G: Guest<Self>>(
        &self,
        guest: &mut G,
        syscall: Poll,
    ) -> Result<i64, Errno> {
        let event = next_event!(guest, Poll)?;
        replay_poll_event(
            &mut guest.memory(),
            syscall.fds(),
            syscall.nfds() as usize,
            event,
        )
    }

    pub(super) async fn handle_ppoll<G: Guest<Self>>(
        &self,
        guest: &mut G,
        syscall: Ppoll,
    ) -> Result<i64, Errno> {
        let event = next_event!(guest, Ppoll)?;
        replay_ppoll_event(
            &mut guest.memory(),
            syscall.fds(),
            syscall.timeout(),
            syscall.nfds() as usize,
            event,
        )
    }

    pub(super) async fn handle_select<G: Guest<Self>>(
        &self,
        guest: &mut G,
        syscall: Select,
    ) -> Result<i64, Errno> {
        let event = next_event!(guest, Select)?;
        replay_select_event(
            &mut guest.memory(),
            syscall.nfds(),
            [syscall.readfds(), syscall.writefds(), syscall.exceptfds()],
            syscall.timeout().map(AddrMut::cast),
            event,
        )
    }

    pub(super) async fn handle_pselect6<G: Guest<Self>>(
        &self,
        guest: &mut G,
        syscall: Pselect6,
    ) -> Result<i64, Errno> {
        let event = next_event!(guest, Select)?;
        replay_select_event(
            &mut guest.memory(),
            syscall.nfds(),
            [syscall.readfds(), syscall.writefds(), syscall.exceptfds()],
            syscall.timeout().map(AddrMut::cast),
            event,
        )
    }

    pub(super) async fn handle_sockopt_family<G: Guest<Self>>(
        &self,
        guest: &mut G,
        syscall: SockOptFamily,
    ) -> Result<i64, Errno> {
        let event = next_event!(guest, SockOpt)?;

        // A NULL value buffer is valid when the recorded value is empty.
        if let Some(address) = syscall.value() {
            guest
                .memory()
                .write_exact(address.cast::<u8>(), &event.value)?;
        } else if !event.value.is_empty() {
            return Err(Errno::EFAULT);
        }

        // Write out the length parameter.
        guest
            .memory()
            .write_value(syscall.value_len().ok_or(Errno::EFAULT)?, &event.length)?;

        Ok(0)
    }

    pub(super) async fn handle_recvmsg<G: Guest<Self>>(
        &self,
        guest: &mut G,
        syscall: Recvmsg,
    ) -> Result<i64, Errno> {
        let event = next_event!(guest, Recvmsg)?;
        let cloexec = syscall.flags() & libc::MSG_CMSG_CLOEXEC != 0;
        for fd in scm_rights_fds(&event.control) {
            self.reserve_replay_fd(guest, fd, cloexec).await;
        }

        let message_address = syscall.msg().ok_or(Errno::EFAULT)?;
        let mut message: libc::msghdr = guest.memory().read_value(message_address)?;
        let iovecs = crate::read_iovecs(&guest.memory(), &message)?;
        assert_eq!(iovecs.len(), event.iovs.len());

        for (iovec, bytes) in iovecs.into_iter().zip(&event.iovs) {
            assert!(bytes.len() <= iovec.iov_len);
            write_bytes(&mut guest.memory(), iovec.iov_base, bytes)?;
        }

        assert!(event.name.len() <= message.msg_namelen as usize);
        assert!(event.control.len() <= message.msg_controllen);
        write_bytes(&mut guest.memory(), message.msg_name, &event.name)?;
        write_bytes(&mut guest.memory(), message.msg_control, &event.control)?;

        message.msg_namelen = event.name_len;
        message.msg_controllen = event.control_len;
        message.msg_flags = event.flags;
        guest.memory().write_value(message_address, &message)?;

        Ok(event.result)
    }

    pub(super) async fn handle_recvfrom<G: Guest<Self>>(
        &self,
        guest: &mut G,
        syscall: Recvfrom,
    ) -> Result<i64, Errno> {
        let buf = next_event!(guest, Bytes)?;

        assert!(buf.len() <= syscall.len());

        // Write out the buffer.
        guest
            .memory()
            .write_exact(syscall.buf().unwrap(), &buf)
            .unwrap();
        Ok(buf.len() as i64)
    }
}

#[cfg(test)]
mod tests {
    use reverie::syscalls::LocalMemory;
    use reverie::syscalls::PollFlags;

    use super::*;

    #[test]
    fn replay_poll_restores_outputs_before_returning_efault() {
        let mut output = libc::pollfd {
            fd: 3,
            events: libc::POLLIN,
            revents: 0x1234,
        };
        let event = PollEvent {
            result: Err(Errno::EFAULT),
            fds_pointer_present: true,
            fds: Some(vec![PollFd {
                fd: 3,
                events: PollFlags::POLLIN,
                revents: PollFlags::POLLIN,
            }]),
        };
        let result = replay_poll_event(
            &mut LocalMemory::new(),
            AddrMut::<libc::pollfd>::from_raw((&mut output as *mut libc::pollfd) as usize)
                .map(|address| address.cast::<PollFd>()),
            1,
            event,
        );

        assert_eq!(result, Err(Errno::EFAULT));
        assert_eq!(output.revents, libc::POLLIN);
    }

    #[test]
    fn replay_ppoll_restores_outputs_and_exact_timeout_before_efault() {
        let mut output = libc::pollfd {
            fd: 5,
            events: libc::POLLIN,
            revents: 0x1234,
        };
        let mut timeout = Timespec {
            tv_sec: 3,
            tv_nsec: 456_789_123,
        };
        let recorded_timeout = Timespec {
            tv_sec: 3,
            tv_nsec: 456_780_001,
        };
        let event = PpollEvent {
            result: Err(Errno::EFAULT),
            fds_pointer_present: true,
            fds: Some(vec![PollFd {
                fd: 5,
                events: PollFlags::POLLIN,
                revents: PollFlags::POLLIN,
            }]),
            timeout_pointer_present: true,
            timeout: Some(recorded_timeout),
        };
        let result = replay_ppoll_event(
            &mut LocalMemory::new(),
            AddrMut::from_raw((&mut output as *mut libc::pollfd) as usize),
            AddrMut::from_raw((&mut timeout as *mut Timespec) as usize),
            1,
            event,
        );

        assert_eq!(result, Err(Errno::EFAULT));
        assert_eq!(output.revents, libc::POLLIN);
        assert_eq!(timeout, recorded_timeout);
    }

    #[test]
    fn replay_poll_restores_outputs_before_returning_eintr() {
        let mut output = libc::pollfd {
            fd: 11,
            events: libc::POLLIN,
            revents: 0x1234,
        };
        let event = PollEvent {
            result: Err(Errno::EINTR),
            fds_pointer_present: true,
            fds: Some(vec![PollFd {
                fd: 11,
                events: PollFlags::POLLIN,
                revents: PollFlags::empty(),
            }]),
        };
        let result = replay_poll_event(
            &mut LocalMemory::new(),
            AddrMut::<libc::pollfd>::from_raw((&mut output as *mut libc::pollfd) as usize)
                .map(|address| address.cast::<PollFd>()),
            1,
            event,
        );

        assert_eq!(result, Err(Errno::EINTR));
        assert_eq!(output.revents, 0);
    }

    #[test]
    fn replay_einval_performs_no_pollfd_write() {
        let event = PollEvent {
            result: Err(Errno::EINVAL),
            fds_pointer_present: true,
            fds: None,
        };
        let result = replay_poll_event(
            &mut LocalMemory::new(),
            AddrMut::from_raw(1),
            usize::MAX,
            event,
        );

        assert_eq!(result, Err(Errno::EINVAL));
    }
}

#[cfg(test)]
mod current_main_tests {
    use std::io;

    use reverie::syscalls::LocalMemory;
    use reverie::syscalls::MemoryAccess;
    use reverie::syscalls::PollFlags;

    use super::*;

    struct FailSecondWrite {
        memory: LocalMemory,
        writes: usize,
    }

    impl MemoryAccess for FailSecondWrite {
        fn read_vectored(
            &self,
            read_from: &[io::IoSlice],
            write_to: &mut [io::IoSliceMut],
        ) -> Result<usize, Errno> {
            self.memory.read_vectored(read_from, write_to)
        }

        fn write_vectored(
            &mut self,
            _read_from: &[io::IoSlice],
            _write_to: &mut [io::IoSliceMut],
        ) -> Result<usize, Errno> {
            unreachable!("write_exact dispatches through the overridden write method")
        }

        fn write(&mut self, address: AddrMut<u8>, bytes: &[u8]) -> Result<usize, Errno> {
            self.writes += 1;
            if self.writes == 2 {
                Err(Errno::EFAULT)
            } else {
                self.memory.write(address, bytes)
            }
        }
    }

    #[test]
    fn replay_ppoll_restores_exact_timeout_and_successful_pollfds() {
        let mut output_fd = libc::pollfd {
            fd: 7,
            events: libc::POLLIN,
            revents: 0,
        };
        let mut output_timeout = Timespec {
            tv_sec: 0,
            tv_nsec: 0,
        };
        let recorded_timeout = Timespec {
            tv_sec: 3,
            tv_nsec: 456_789_123,
        };
        let event = PpollEvent {
            result: Ok(1),
            fds_pointer_present: true,
            fds: Some(vec![PollFd {
                fd: 7,
                events: PollFlags::POLLIN,
                revents: PollFlags::POLLIN,
            }]),
            timeout_pointer_present: true,
            timeout: Some(recorded_timeout),
        };

        let result = replay_ppoll_event(
            &mut LocalMemory::new(),
            AddrMut::from_raw((&mut output_fd as *mut libc::pollfd) as usize),
            AddrMut::from_raw((&mut output_timeout as *mut Timespec) as usize),
            1,
            event,
        );

        assert_eq!(result, Ok(1));
        assert_eq!(output_fd.revents, libc::POLLIN);
        assert_eq!(output_timeout, recorded_timeout);
    }

    #[test]
    fn replay_ppoll_restores_exact_timeout_before_recorded_error() {
        let mut output_timeout = Timespec {
            tv_sec: 0,
            tv_nsec: 0,
        };
        let recorded_timeout = Timespec {
            tv_sec: 2,
            tv_nsec: 345_678_901,
        };
        let event = PpollEvent {
            result: Err(Errno::EINTR),
            fds_pointer_present: false,
            fds: None,
            timeout_pointer_present: true,
            timeout: Some(recorded_timeout),
        };

        let result = replay_ppoll_event(
            &mut LocalMemory::new(),
            None,
            AddrMut::from_raw((&mut output_timeout as *mut Timespec) as usize),
            0,
            event,
        );

        assert_eq!(result, Err(Errno::EINTR));
        assert_eq!(output_timeout, recorded_timeout);
    }

    #[test]
    fn replay_ppoll_writes_ready_fds_and_preserves_result_on_timeout_copyout_error() {
        let mut output_fd = libc::pollfd {
            fd: 7,
            events: libc::POLLIN,
            revents: 0,
        };
        let mut output_timeout = Timespec {
            tv_sec: 9,
            tv_nsec: 876_543_210,
        };
        let original_timeout = output_timeout;
        let event = PpollEvent {
            result: Ok(1),
            fds_pointer_present: true,
            fds: Some(vec![PollFd {
                fd: 7,
                events: PollFlags::POLLIN,
                revents: PollFlags::POLLIN,
            }]),
            timeout_pointer_present: true,
            timeout: Some(Timespec {
                tv_sec: 3,
                tv_nsec: 456_789_123,
            }),
        };
        let mut memory = FailSecondWrite {
            memory: LocalMemory::new(),
            writes: 0,
        };

        let result = replay_ppoll_event(
            &mut memory,
            AddrMut::from_raw((&mut output_fd as *mut libc::pollfd) as usize),
            AddrMut::from_raw((&mut output_timeout as *mut Timespec) as usize),
            1,
            event,
        );

        assert_eq!(result, Ok(1));
        assert_eq!(memory.writes, 2);
        assert_eq!(output_fd.revents, libc::POLLIN);
        assert_eq!(output_timeout, original_timeout);
    }

    #[test]
    fn replay_poll_restores_fds_before_returning_a_recorded_error() {
        // THE ORDERING IS THE FIX. The old replayer returned the recorded error
        // before writing anything, so a guest that recorded a partial `revents`
        // copy-out saw its own pre-syscall sentinels instead.
        let mut observed = [PollFd {
            fd: 7,
            events: PollFlags::POLLIN,
            revents: PollFlags::empty(),
        }];
        let event = PollEvent {
            result: Err(Errno::EFAULT),
            fds_pointer_present: true,
            fds: Some(vec![PollFd {
                fd: 7,
                events: PollFlags::POLLIN,
                revents: PollFlags::POLLIN,
            }]),
        };

        let result = replay_poll_event(
            &mut LocalMemory::new(),
            AddrMut::from_raw(observed.as_mut_ptr() as usize),
            observed.len(),
            event,
        );

        assert_eq!(result, Err(Errno::EFAULT));
        assert_eq!(
            observed[0].revents,
            PollFlags::POLLIN,
            "the recorded partial copy-out must be restored even though the call errored"
        );
    }

    #[test]
    fn replay_poll_early_error_with_pollfd_pointer_performs_no_fd_write() {
        let event = PollEvent {
            result: Err(Errno::EINVAL),
            fds_pointer_present: true,
            fds: None,
        };
        let mut memory = FailSecondWrite {
            memory: LocalMemory::new(),
            writes: 0,
        };

        let result = replay_poll_event(&mut memory, AddrMut::from_raw(1), usize::MAX, event);

        assert_eq!(result, Err(Errno::EINVAL));
        assert_eq!(memory.writes, 0);
    }

    #[test]
    fn replay_ppoll_early_error_with_pollfd_pointer_performs_no_fd_write() {
        let event = PpollEvent {
            result: Err(Errno::EINVAL),
            fds_pointer_present: true,
            fds: None,
            timeout_pointer_present: false,
            timeout: None,
        };
        let mut memory = FailSecondWrite {
            memory: LocalMemory::new(),
            writes: 0,
        };

        let result = replay_ppoll_event(&mut memory, AddrMut::from_raw(1), None, usize::MAX, event);

        assert_eq!(result, Err(Errno::EINVAL));
        assert_eq!(memory.writes, 0);
    }

    #[test]
    fn replay_select_restores_sets_and_exact_timeout() {
        let mut readfds: libc::fd_set = unsafe { std::mem::zeroed() };
        unsafe { libc::FD_SET(3, &mut readfds) };
        let mut timeout = libc::timeval {
            tv_sec: 2,
            tv_usec: 0,
        };
        let recorded_timeout = libc::timeval {
            tv_sec: 1,
            tv_usec: 999_873,
        };
        let recorded_timeout_bytes = unsafe {
            std::slice::from_raw_parts(
                (&recorded_timeout as *const libc::timeval).cast::<u8>(),
                std::mem::size_of::<libc::timeval>(),
            )
        }
        .to_vec();
        let event = SelectEvent {
            result: Ok(0),
            fd_sets: [Some(vec![0; 8]), None, None],
            timeout: Some(recorded_timeout_bytes),
        };
        let result = replay_select_event(
            &mut LocalMemory::new(),
            4,
            [
                AddrMut::from_raw((&mut readfds as *mut libc::fd_set) as usize),
                None,
                None,
            ],
            AddrMut::from_raw((&mut timeout as *mut libc::timeval) as usize),
            event,
        );

        assert_eq!(result, Ok(0));
        assert!(!unsafe { libc::FD_ISSET(3, &readfds) });
        assert_eq!(timeout.tv_sec, recorded_timeout.tv_sec);
        assert_eq!(timeout.tv_usec, recorded_timeout.tv_usec);
    }

    #[test]
    fn replay_select_restores_only_the_recorded_prefix_before_efault() {
        // Recorded: the read set was partly copied out (its first long), then
        // the kernel faulted before reaching the write set.
        let mut readfds: libc::fd_set = unsafe { std::mem::zeroed() };
        let mut writefds: libc::fd_set = unsafe { std::mem::zeroed() };
        unsafe {
            libc::FD_SET(3, &mut readfds);
            libc::FD_SET(100, &mut readfds);
            libc::FD_SET(5, &mut writefds);
        }
        let event = SelectEvent {
            result: Err(Errno::EFAULT),
            fd_sets: [Some(vec![0b0100_0000, 0, 0, 0, 0, 0, 0, 0]), None, None],
            timeout: None,
        };
        let result = replay_select_event(
            &mut LocalMemory::new(),
            128,
            [
                AddrMut::from_raw((&mut readfds as *mut libc::fd_set) as usize),
                AddrMut::from_raw((&mut writefds as *mut libc::fd_set) as usize),
                None,
            ],
            None,
            event,
        );

        assert_eq!(result, Err(Errno::EFAULT));
        assert!(!unsafe { libc::FD_ISSET(3, &readfds) });
        assert!(unsafe { libc::FD_ISSET(6, &readfds) });
        // Past the recorded prefix, and the set the kernel never reached,
        // keep the guest's own bytes.
        assert!(unsafe { libc::FD_ISSET(100, &readfds) });
        assert!(unsafe { libc::FD_ISSET(5, &writefds) });
    }
}