harn-lint 0.10.122

Linter for the Harn programming language
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167

use super::*;

#[test]
fn push_pr_without_prior_secret_scan_warns() {
    let diags = lint_source(
        r#"
pipeline default(task) {
  const client = mcp_connect("harn", [])
  mcp_call(client, "git::push_pr", {title: "unsafe"})
}
"#,
    );

    assert!(
        has_rule(&diags, "pr-open-without-secret-scan"),
        "expected pr-open-without-secret-scan warning, got: {diags:?}"
    );
}

#[test]
fn push_pr_after_secret_scan_is_not_flagged() {
    let diags = lint_source(
        r#"
pipeline default(task) {
  const diff = "token = ghp_123"
  const findings = secret_scan(diff)
  if len(findings) == 0 {
    const client = mcp_connect("harn", [])
    mcp_call(client, "git::push_pr", {title: "safe"})
  }
}
"#,
    );

    assert!(
        !has_rule(&diags, "pr-open-without-secret-scan"),
        "secret_scan before push_pr should satisfy the lint, got: {diags:?}"
    );
}

#[test]
fn branch_local_secret_scan_does_not_cover_outer_pr_open() {
    let diags = lint_source(
        r#"
pipeline default(task) {
  if true {
    secret_scan("diff")
  }
  const client = mcp_connect("harn", [])
  mcp_call(client, "git::push_pr", {title: "still unsafe"})
}
"#,
    );

    assert!(
        has_rule(&diags, "pr-open-without-secret-scan"),
        "branch-local secret_scan should not satisfy a later unconditional PR-open, got: {diags:?}"
    );
}

#[test]
fn migrated_scan_covers_legacy_pr_open() {
    let diags = lint_source(
        r#"
fn main(harness: Harness) {
  const client = mcp_connect("harn", [])
  harness.tools.mcp_call(client, "harn.secret_scan", {content: "diff"})
  mcp_call(client, "git::push_pr", {title: "safe"})
}
"#,
    );

    assert!(
        !has_rule(&diags, "pr-open-without-secret-scan"),
        "canonical scan must cover a legacy PR-open, got: {diags:?}"
    );
}

#[test]
fn legacy_scan_covers_migrated_pr_open() {
    let diags = lint_source(
        r#"
fn main(harness: Harness) {
  const client = mcp_connect("harn", [])
  mcp_call(client, "harn.secret_scan", {content: "diff"})
  harness.tools.mcp_call(client, "git::push_pr", {title: "safe"})
}
"#,
    );

    assert!(
        !has_rule(&diags, "pr-open-without-secret-scan"),
        "legacy scan must cover a canonical PR-open, got: {diags:?}"
    );
}

#[test]
fn migrated_scan_covers_migrated_pr_open() {
    let diags = lint_source(
        r#"
fn main(harness: Harness) {
  const client = mcp_connect("harn", [])
  harness.tools.mcp_call(client, "harn.secret_scan", {content: "diff"})
  harness.tools.mcp_call(client, "git::push_pr", {title: "safe"})
}
"#,
    );

    assert!(
        !has_rule(&diags, "pr-open-without-secret-scan"),
        "fully canonical scan and PR-open must pair, got: {diags:?}"
    );
}

#[test]
fn migrated_pr_open_without_scan_warns() {
    let diags = lint_source(
        r#"
fn main(harness: Harness) {
  const client = mcp_connect("harn", [])
  harness.tools.mcp_call(client, "git::push_pr", {title: "unsafe"})
}
"#,
    );

    assert!(
        has_rule(&diags, "pr-open-without-secret-scan"),
        "canonical PR-open must retain the secret-scan guard, got: {diags:?}"
    );
}

#[test]
fn colliding_non_harness_scan_method_does_not_count_as_scan() {
    let diags = lint_source(
        r#"
fn main(harness: Harness) {
  const client = mcp_connect("harn", [])
  const proxy = {}
  proxy.mcp_call(client, "harn.secret_scan", {content: "diff"})
  mcp_call(client, "git::push_pr", {title: "unsafe"})
}
"#,
    );

    assert!(
        has_rule(&diags, "pr-open-without-secret-scan"),
        "unrelated scan method must not satisfy the guard, got: {diags:?}"
    );
}

#[test]
fn colliding_non_harness_pr_open_method_is_not_flagged() {
    let diags = lint_source(
        r#"
fn main(harness: Harness) {
  const client = mcp_connect("harn", [])
  const proxy = {}
  proxy.mcp_call(client, "git::push_pr", {title: "not a host call"})
}
"#,
    );

    assert!(
        !has_rule(&diags, "pr-open-without-secret-scan"),
        "unrelated PR-open method must not trigger the guard, got: {diags:?}"
    );
}