harn-lint 0.10.122

Linter for the Harn programming language
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49

use harn_lexer::Span;
use harn_parser::{DiagnosticCode as Code, SNode};

use super::Linter;
use crate::diagnostic::{LintDiagnostic, LintSeverity};

impl Linter<'_> {
    pub(super) fn check_harness_method_effect_policy(
        &mut self,
        object: &SNode,
        method: &str,
        args: &[SNode],
        span: Span,
    ) {
        let connector_denial =
            self.connector_effect_export_stack
                .last()
                .cloned()
                .and_then(|export| {
                    let capability = self.harness_capability_of(object)?.to_string();
                    harn_vm::connector_export_denied_harness_method_reason(
                        &export,
                        &capability,
                        method,
                    )
                    .map(|reason| (export, capability, reason))
                });

        if let Some((export, capability, reason)) = connector_denial {
            self.diagnostics.push(LintDiagnostic {
                code: Code::LintConnectorEffectPolicy,
                rule: "connector-effect-policy".into(),
                message: format!(
                    "connector export `{export}` calls disallowed capability \
                     `harness.{capability}.{method}`: {reason}"
                ),
                span,
                severity: LintSeverity::Warning,
                suggestion: Some(format!(
                    "move `harness.{capability}.{method}` out of `{export}` or configure \
                     a trusted connector effect-policy override"
                )),
                fix: None,
            });
        }

        self.check_redundant_clone_args(method, args);
    }
}