harn-hostlib 0.10.50

//! Integration tests for `hostlib_tools_git` against a real fixture repo.
//!
//! These tests require `git` on `$PATH`. CI installs it; local dev usually
//! has it. If it's missing the tests are skipped via [`ensure_git`].
//!
//! Read-only tests share a single fixture repository via [`shared_fixture`]
//! so the binary spawns ~10 `git` subprocesses at first use instead of ~10
//! per test (~100+ total). On Windows runners — where process creation is
//! expensive and AV scanning of fresh tempdirs adds latency — the shared
//! fixture is what keeps the integration suite fast under load. The single
//! mutating test (`git_status_reports_dirty_paths`) keeps building its own
//! repo so it does not pollute the shared one.

use std::path::Path;
use std::process::Command;
use std::sync::Arc;
use std::sync::OnceLock;

use harn_hostlib::{tools::ToolsCapability, BuiltinRegistry, HostlibCapability, HostlibError};
use harn_vm::VmValue;
use tempfile::TempDir;

fn registry() -> BuiltinRegistry {
    let mut registry = BuiltinRegistry::new();
    ToolsCapability.register_builtins(&mut registry);
    registry
}

fn dict_arg(entries: &[(&str, VmValue)]) -> Vec<VmValue> {
    let mut map: harn_vm::value::DictMap = Default::default();
    for (k, v) in entries {
        map.insert(harn_vm::value::intern_key(k), v.clone());
    }
    vec![VmValue::dict(map)]
}

fn vm_string(s: &str) -> VmValue {
    VmValue::String(arcstr::ArcStr::from(s))
}

fn ensure_git() -> bool {
    Command::new("git").arg("--version").output().is_ok()
}

/// Build a `repo` argument from a filesystem path. Centralized so every
/// test gets the same `Path::to_string_lossy` handling on Windows (where
/// the path renders with backslashes that `git -C` accepts unchanged).
fn repo_arg(repo: &Path) -> (&'static str, VmValue) {
    ("repo", vm_string(&repo.to_string_lossy()))
}

/// Invoke `hostlib_tools_git` with `args`. Wraps the boilerplate every
/// test would otherwise repeat (build a registry, look up the entry, wrap
/// args in a Vm dict).
fn invoke(args: &[(&str, VmValue)]) -> Result<VmValue, HostlibError> {
    let reg = registry();
    let entry = reg.find("hostlib_tools_git").unwrap();
    (entry.handler)(&dict_arg(args))
}

/// Initialize a tiny git repo with two commits, configured locally so the
/// test never reads global git config.
fn fixture_repo() -> TempDir {
    let dir = TempDir::new().unwrap();
    populate_fixture_repo(dir.path());
    dir
}

fn populate_fixture_repo(repo: &Path) {
    run_git(repo, &["init", "-q", "-b", "main"]);
    run_git(repo, &["config", "user.email", "tester@example.com"]);
    run_git(repo, &["config", "user.name", "Tester"]);
    run_git(repo, &["config", "commit.gpgsign", "false"]);

    std::fs::write(repo.join("a.txt"), "first\n").unwrap();
    run_git(repo, &["add", "a.txt"]);
    run_git(repo, &["commit", "-q", "-m", "first commit"]);

    std::fs::write(repo.join("a.txt"), "first\nsecond\n").unwrap();
    std::fs::write(repo.join("b.txt"), "new file\n").unwrap();
    run_git(repo, &["add", "a.txt", "b.txt"]);
    run_git(repo, &["commit", "-q", "-m", "second commit"]);

    run_git(
        repo,
        &[
            "remote",
            "add",
            "origin",
            "https://example.invalid/repo.git",
        ],
    );
}

/// Shared, lazily-initialized fixture repo for tests that only read git
/// state. The `TempDir` lives in a static `OnceLock` and is built once per
/// test binary on first use — subsequent callers reuse it.
///
/// Mutating tests (currently `git_status_reports_dirty_paths`) must keep
/// using [`fixture_repo`] so they do not leak dirty-tree state into other
/// tests. `OnceLock<TempDir>` is never dropped on normal process exit,
/// which means the directory persists until the OS cleans `$TMPDIR` —
/// matching how unshared `TempDir`s are cleaned up if a test panics.
fn shared_fixture() -> &'static Path {
    static FIXTURE: OnceLock<TempDir> = OnceLock::new();
    FIXTURE
        .get_or_init(|| {
            let dir = TempDir::new().unwrap();
            populate_fixture_repo(dir.path());
            dir
        })
        .path()
}

fn run_git(repo: &Path, args: &[&str]) {
    let mut cmd = Command::new("git");
    // Drop ambient GIT_* env vars so the test isn't perturbed by an
    // outer `git push` hook (which would otherwise leak GIT_DIR etc.
    // into the subprocess and silently break our tempdir isolation).
    for (key, _) in std::env::vars() {
        if key.starts_with("GIT_") {
            cmd.env_remove(&key);
        }
    }
    let output = cmd
        .arg("-C")
        .arg(repo)
        .args(args)
        .output()
        .unwrap_or_else(|err| {
            panic!(
                "git {} {} failed: {err}",
                args.first().unwrap_or(&""),
                repo.display()
            )
        });
    assert!(
        output.status.success(),
        "git {} (cwd={}) status={:?} stderr={}",
        args.join(" "),
        repo.display(),
        output.status,
        String::from_utf8_lossy(&output.stderr)
    );
}

fn dict_get<'a>(value: &'a VmValue, key: &str) -> &'a VmValue {
    match value {
        VmValue::Dict(d) => d.get(key).expect("key present"),
        other => panic!("not a dict: {other:?}"),
    }
}

fn list_of(value: &VmValue) -> &Arc<Vec<VmValue>> {
    match value {
        VmValue::List(l) => l,
        other => panic!("expected list, got {other:?}"),
    }
}

#[test]
fn git_log_returns_structured_entries() {
    if !ensure_git() {
        eprintln!("skipping: git not installed");
        return;
    }
    let result = invoke(&[("operation", vm_string("log")), repo_arg(shared_fixture())]).unwrap();
    let data = dict_get(&result, "data");
    let commits = list_of(data);
    assert_eq!(commits.len(), 2);
    if let VmValue::Dict(latest) = &commits[0] {
        if let Some(VmValue::String(s)) = latest.get("subject") {
            assert_eq!(s.as_str(), "second commit");
        }
        if let Some(VmValue::String(sha)) = latest.get("sha") {
            assert_eq!(sha.len(), 40);
        }
    }
}

#[test]
fn git_log_max_count_limits_results() {
    if !ensure_git() {
        return;
    }
    let result = invoke(&[
        ("operation", vm_string("log")),
        repo_arg(shared_fixture()),
        ("max_count", VmValue::Int(1)),
    ])
    .unwrap();
    let data = dict_get(&result, "data");
    assert_eq!(list_of(data).len(), 1);
}

#[test]
fn git_status_reports_dirty_paths() {
    if !ensure_git() {
        return;
    }
    // The only mutating test in this binary: it writes an untracked file
    // before calling status. Use a fresh, isolated repo so the dirty
    // state never leaks into the [`shared_fixture`] used by the read-only
    // tests above and below.
    let repo = fixture_repo();
    std::fs::write(repo.path().join("c.txt"), "untracked\n").unwrap();

    let result = invoke(&[("operation", vm_string("status")), repo_arg(repo.path())]).unwrap();
    let data = dict_get(&result, "data");
    let entries = list_of(data);
    assert!(entries.iter().any(|e| match dict_get(e, "path") {
        VmValue::String(s) => s.as_str() == "c.txt",
        _ => false,
    }));
}

#[test]
fn git_current_branch_returns_main() {
    if !ensure_git() {
        return;
    }
    let result = invoke(&[
        ("operation", vm_string("current_branch")),
        repo_arg(shared_fixture()),
    ])
    .unwrap();
    let data = dict_get(&result, "data");
    if let VmValue::String(s) = data {
        assert_eq!(s.as_str(), "main");
    } else {
        panic!("expected string branch name, got {data:?}");
    }
}

#[test]
fn git_remote_list_returns_origin() {
    if !ensure_git() {
        return;
    }
    let result = invoke(&[
        ("operation", vm_string("remote_list")),
        repo_arg(shared_fixture()),
    ])
    .unwrap();
    let data = dict_get(&result, "data");
    let remotes = list_of(data);
    assert_eq!(remotes.len(), 1);
    if let VmValue::Dict(d) = &remotes[0] {
        assert!(matches!(d.get("name"), Some(VmValue::String(s)) if s.as_str() == "origin"));
        assert!(matches!(
            d.get("url"),
            Some(VmValue::String(s)) if s.as_str() == "https://example.invalid/repo.git"
        ));
    }
}

#[test]
fn git_blame_returns_authors_per_line() {
    if !ensure_git() {
        return;
    }
    let result = invoke(&[
        ("operation", vm_string("blame")),
        repo_arg(shared_fixture()),
        ("path", vm_string("a.txt")),
    ])
    .unwrap();
    let data = dict_get(&result, "data");
    let lines = list_of(data);
    assert_eq!(lines.len(), 2);
    if let VmValue::Dict(first) = &lines[0] {
        assert!(matches!(
            first.get("author"),
            Some(VmValue::String(s)) if s.as_str() == "Tester"
        ));
        assert!(matches!(first.get("line"), Some(VmValue::Int(1))));
    }
}

#[test]
fn git_show_emits_patch_text() {
    if !ensure_git() {
        return;
    }
    let result = invoke(&[
        ("operation", vm_string("show")),
        repo_arg(shared_fixture()),
        ("rev", vm_string("HEAD")),
    ])
    .unwrap();
    let data = dict_get(&result, "data");
    if let VmValue::String(s) = data {
        assert!(s.contains("second commit"));
        assert!(s.contains("b.txt"));
    } else {
        panic!("expected string");
    }
}

#[test]
fn git_diff_handles_clean_repo() {
    if !ensure_git() {
        return;
    }
    let result = invoke(&[("operation", vm_string("diff")), repo_arg(shared_fixture())]).unwrap();
    let data = dict_get(&result, "data");
    if let VmValue::String(s) = data {
        assert!(s.is_empty(), "expected empty diff, got `{s}`");
    }
}

#[test]
fn git_branch_list_returns_main() {
    if !ensure_git() {
        return;
    }
    let result = invoke(&[
        ("operation", vm_string("branch_list")),
        repo_arg(shared_fixture()),
    ])
    .unwrap();
    let data = dict_get(&result, "data");
    let branches = list_of(data);
    assert_eq!(branches.len(), 1);
    if let VmValue::Dict(d) = &branches[0] {
        assert!(matches!(d.get("name"), Some(VmValue::String(s)) if s.as_str() == "main"));
    }
}

#[test]
fn git_rejects_flag_lookalike_revs() {
    if !ensure_git() {
        return;
    }
    let err = invoke(&[
        ("operation", vm_string("show")),
        repo_arg(shared_fixture()),
        ("rev", vm_string("--exec=rm")),
    ])
    .unwrap_err();
    assert!(matches!(
        err,
        HostlibError::InvalidParameter { param: "rev", .. }
    ));
}

#[test]
fn git_rejects_unknown_operation() {
    let reg = registry();
    let entry = reg.find("hostlib_tools_git").unwrap();
    let err = (entry.handler)(&dict_arg(&[("operation", vm_string("rm-rf"))])).unwrap_err();
    assert!(matches!(
        err,
        HostlibError::InvalidParameter {
            param: "operation",
            ..
        }
    ));
}