harn-cli 0.10.16

CLI for the Harn programming language — run, test, REPL, format, and lint
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
use std::fs;
use std::path::{Path, PathBuf};

use crate::cli::{ProvidersBuildCapabilitiesArgs, ProvidersBuildConfigArgs};

const PROVIDER_CONFIG_GENERATED_HEADER: &str = "\
# @generated by `harn provider catalog build-config`; do not edit directly.
# Edit crates/harn-vm/src/llm/catalog_sources/**/*.toml instead.
";
const PROVIDER_CAPABILITIES_GENERATED_HEADER: &str = "\
# @generated by `harn provider catalog build-capabilities`; do not edit directly.
# Edit crates/harn-vm/src/llm/capability_sources/**/*.toml instead.
";

pub(crate) fn run_build_config(args: &ProvidersBuildConfigArgs) -> Result<(), String> {
    let generated = generated_provider_config(&args.source_dir)?;

    if args.check {
        match fs::read_to_string(&args.output) {
            Ok(existing) if existing == generated.body => {
                println!("provider config snapshot is up to date");
                return Ok(());
            }
            Ok(_) | Err(_) => {
                eprintln!(
                    "error: generated provider config is stale or missing: {}",
                    args.output.display()
                );
                return Err("provider config snapshot drifted".to_string());
            }
        }
    }

    if let Some(parent) = args.output.parent() {
        fs::create_dir_all(parent).map_err(|error| {
            format!(
                "failed to create provider config directory {}: {error}",
                parent.display()
            )
        })?;
    }
    fs::write(&args.output, generated.body)
        .map_err(|error| format!("failed to write {}: {error}", args.output.display()))?;
    println!(
        "wrote {} from {} TOML fragments",
        args.output.display(),
        generated.fragment_count
    );
    Ok(())
}

pub(crate) fn run_build_capabilities(args: &ProvidersBuildCapabilitiesArgs) -> Result<(), String> {
    let generated = generated_provider_capabilities(&args.source_dir)?;

    if args.check {
        match fs::read_to_string(&args.output) {
            Ok(existing) if existing == generated.body => {
                println!("provider capability snapshot is up to date");
                return Ok(());
            }
            Ok(_) | Err(_) => {
                eprintln!(
                    "error: generated provider capability snapshot is stale or missing: {}",
                    args.output.display()
                );
                return Err("provider capability snapshot drifted".to_string());
            }
        }
    }

    if let Some(parent) = args.output.parent() {
        fs::create_dir_all(parent).map_err(|error| {
            format!(
                "failed to create provider capability directory {}: {error}",
                parent.display()
            )
        })?;
    }
    fs::write(&args.output, generated.body)
        .map_err(|error| format!("failed to write {}: {error}", args.output.display()))?;
    println!(
        "wrote {} from {} TOML fragments",
        args.output.display(),
        generated.fragment_count
    );
    Ok(())
}

struct GeneratedProviderConfig {
    body: String,
    fragment_count: usize,
}

fn generated_provider_config(source_dir: &Path) -> Result<GeneratedProviderConfig, String> {
    let mut fragments = Vec::new();
    collect_toml_fragments(source_dir, &mut fragments)?;
    fragments.sort();
    if fragments.is_empty() {
        return Err(format!(
            "provider catalog source directory has no TOML fragments: {}",
            source_dir.display()
        ));
    }

    let mut body = String::from(PROVIDER_CONFIG_GENERATED_HEADER);
    for path in &fragments {
        let fragment = fs::read_to_string(path)
            .map_err(|error| format!("failed to read {}: {error}", path.display()))?;
        // Reject bare `key = value` lines that appear before the first table
        // header in a model fragment. Fragments are concatenated as raw text, so
        // any such leading key binds at runtime to the PREVIOUS fragment's last
        // model table instead of this fragment's first model — silently
        // mislabeling a model's tier/open_weight/strengths across the fragment
        // boundary. Keep every model key inside an explicit `[models.X]` table so
        // concatenation can never reattach it. Scoped to `60-models/`: other
        // fragment dirs (defaults, routing, aliases) legitimately set root-level
        // `ProvidersConfig` fields like `default_provider`.
        let label = fragment_label(source_dir, path);
        if is_model_fragment(&label) {
            if let Some(error) = leading_bare_key_error(&label, &fragment) {
                return Err(error);
            }
        }
        body.push_str("\n# --- source: ");
        body.push_str(&label);
        body.push_str(" ---\n");
        body.push_str(fragment.trim_end());
        body.push('\n');
    }

    let parsed = harn_vm::llm_config::parse_config_toml_with_diagnostics(&body)
        .map_err(|error| format!("generated provider config does not parse: {error}"))?;
    if !parsed.diagnostics.is_empty() {
        let rendered = parsed
            .diagnostics
            .iter()
            .map(ToString::to_string)
            .collect::<Vec<_>>()
            .join("\n");
        return Err(format!(
            "generated provider config contains unknown fields:\n{rendered}"
        ));
    }
    let default_issues = harn_vm::llm_config::model_default_issues(&parsed.config);
    if !default_issues.is_empty() {
        return Err(format!(
            "generated provider config has invalid model defaults:\n{}",
            default_issues.join("\n")
        ));
    }

    Ok(GeneratedProviderConfig {
        body,
        fragment_count: fragments.len(),
    })
}

fn generated_provider_capabilities(source_dir: &Path) -> Result<GeneratedProviderConfig, String> {
    let mut fragments = Vec::new();
    collect_toml_fragments(source_dir, &mut fragments)?;
    fragments.sort();
    if fragments.is_empty() {
        return Err(format!(
            "provider capability source directory has no TOML fragments: {}",
            source_dir.display()
        ));
    }

    let mut body = String::from(PROVIDER_CAPABILITIES_GENERATED_HEADER);
    for path in &fragments {
        let fragment = fs::read_to_string(path)
            .map_err(|error| format!("failed to read {}: {error}", path.display()))?;
        body.push_str("\n# --- source: ");
        body.push_str(&fragment_label(source_dir, path));
        body.push_str(" ---\n");
        body.push_str(fragment.trim_end());
        body.push('\n');
    }

    let parsed = toml::from_str::<harn_vm::llm::capabilities::CapabilitiesFile>(&body)
        .map_err(|error| format!("generated provider capabilities do not parse: {error}"))?;

    // Opinionated footgun gate: refuse to generate (or pass --check on) a
    // capability matrix that declares a known-footgun provider/model/config
    // combo (e.g. a tool route with reasoning forced off, or an OpenRouter
    // Harmony tool route with no clean-sub-provider pin). Data-driven over the
    // matrix — see harn_vm::llm::capability_audit.
    let audit = harn_vm::llm::capability_audit::audit_capabilities(&parsed);
    if !audit.is_clean() {
        return Err(format!(
            "capability matrix footgun check failed:\n{}",
            audit.render()
        ));
    }

    Ok(GeneratedProviderConfig {
        body,
        fragment_count: fragments.len(),
    })
}

fn collect_toml_fragments(dir: &Path, fragments: &mut Vec<PathBuf>) -> Result<(), String> {
    let mut entries = Vec::new();
    let read_dir = fs::read_dir(dir).map_err(|error| {
        format!(
            "failed to read provider catalog source dir {}: {error}",
            dir.display()
        )
    })?;
    for entry in read_dir {
        let entry = entry.map_err(|error| {
            format!(
                "failed to read provider catalog source dir entry in {}: {error}",
                dir.display()
            )
        })?;
        entries.push(entry.path());
    }
    entries.sort();

    for path in entries {
        if path.is_dir() {
            collect_toml_fragments(&path, fragments)?;
        } else if path.extension().and_then(|extension| extension.to_str()) == Some("toml") {
            fragments.push(path);
        }
    }
    Ok(())
}

fn fragment_label(source_dir: &Path, path: &Path) -> String {
    path.strip_prefix(source_dir)
        .unwrap_or(path)
        .to_string_lossy()
        .replace('\\', "/")
}

/// True when a fragment label names a `60-models/` model fragment, where bare
/// keys are model metadata that must live inside a `[models.X]` table. Other
/// source dirs (`00-base`, `20-routing`, `40-defaults`, ...) legitimately set
/// root-level `ProvidersConfig` fields like `default_provider`, so the
/// leading-bare-key guard does not apply to them.
fn is_model_fragment(label: &str) -> bool {
    label.starts_with("60-models/") || label.contains("/60-models/")
}

/// Return an error message when `fragment` has any bare `key = value` line
/// before its first `[table]` header. Such a key has no table to belong to
/// inside the fragment, so after the fragments are concatenated as raw text it
/// silently attaches to the PREVIOUS fragment's last table — the leading-key
/// bleed that mislabels a model across the fragment boundary. Comments and
/// blank lines before the first table are fine; only assignment lines are
/// rejected. Returns `None` when the fragment is clean.
fn leading_bare_key_error(label: &str, fragment: &str) -> Option<String> {
    for (line_number, raw) in fragment.lines().enumerate() {
        let line = raw.trim();
        if line.is_empty() || line.starts_with('#') {
            continue;
        }
        if line.starts_with('[') {
            // Reached the first table header without seeing a bare key: clean.
            return None;
        }
        // A non-comment, non-blank, non-header line before the first table.
        // Only `key = value` assignments are the bleed hazard.
        if line.contains('=') {
            let key = line.split('=').next().unwrap_or(line).trim();
            return Some(format!(
                "provider catalog fragment {label} has a leading bare key `{key}` on line {} \
                 before its first [table] header. Move it inside the model's `[models.X]` table: \
                 a bare key before the first table binds to the PREVIOUS fragment's last model \
                 after concatenation, silently mislabeling that model.",
                line_number + 1
            ));
        }
    }
    None
}

#[cfg(test)]
mod tests {
    use std::fs;

    use super::{generated_provider_config, leading_bare_key_error};

    #[test]
    fn rejects_leading_bare_key_before_first_table() {
        let fragment = "\
# a comment is fine
tier = \"mid\"
open_weight = true
[models.\"x\"]
name = \"X\"
";
        let error =
            leading_bare_key_error("60-models/test.toml", fragment).expect("leading key rejected");
        assert!(error.contains("leading bare key `tier`"), "got: {error}");
        assert!(error.contains("line 2"), "should report the line: {error}");
    }

    #[test]
    fn accepts_fragment_with_only_comments_before_first_table() {
        let fragment = "\
# header comment
# another note

[models.\"x\"]
name = \"X\"
tier = \"mid\"
open_weight = true
";
        assert!(leading_bare_key_error("60-models/test.toml", fragment).is_none());
    }

    #[test]
    fn accepts_keys_inside_tables() {
        // Bare keys AFTER a table header belong to that table and are allowed.
        let fragment = "\
[models.\"x\"]
name = \"X\"
tier = \"mid\"
[models.\"y\"]
name = \"Y\"
tier = \"frontier\"
";
        assert!(leading_bare_key_error("60-models/test.toml", fragment).is_none());
    }

    #[test]
    fn generated_config_rejects_unknown_model_fields() {
        let tempdir = tempfile::tempdir().expect("tempdir");
        let model_dir = tempdir.path().join("60-models");
        fs::create_dir_all(&model_dir).expect("create model dir");
        fs::write(
            model_dir.join("bad.toml"),
            r#"
[models."demo/bad"]
name = "Bad"
provider = "demo"
context_window = 8192
fast_mode = true
"#,
        )
        .expect("write fragment");

        let error = match generated_provider_config(tempdir.path()) {
            Ok(_) => panic!("unknown field should be rejected"),
            Err(error) => error,
        };
        assert!(
            error.contains("generated provider config contains unknown fields"),
            "got: {error}"
        );
        assert!(error.contains("fast_mode"), "got: {error}");
        assert!(error.contains("serving_tiers"), "got: {error}");
    }

    #[test]
    fn generated_config_rejects_unknown_logical_default() {
        let tempdir = tempfile::tempdir().expect("tempdir");
        let defaults_dir = tempdir.path().join("40-defaults");
        fs::create_dir_all(&defaults_dir).expect("create defaults dir");
        fs::write(
            defaults_dir.join("generation.toml"),
            r#"
[model_defaults."logical:not-in-catalog"]
temperature = 1.0
"#,
        )
        .expect("write fragment");

        let error = match generated_provider_config(tempdir.path()) {
            Ok(_) => panic!("unknown logical selector should be rejected"),
            Err(error) => error,
        };
        assert!(
            error.contains("logical:not-in-catalog references an unknown logical model"),
            "got: {error}"
        );
    }

    #[test]
    fn generated_config_rejects_malformed_route_tombstone() {
        let tempdir = tempfile::tempdir().expect("tempdir");
        let defaults_dir = tempdir.path().join("40-defaults");
        fs::create_dir_all(&defaults_dir).expect("create defaults dir");
        fs::write(
            defaults_dir.join("generation.toml"),
            r#"
[model_defaults."provider/model"]
_unset = ["not_a_generation_default"]
"#,
        )
        .expect("write fragment");

        let error = match generated_provider_config(tempdir.path()) {
            Ok(_) => panic!("invalid route tombstone should be rejected"),
            Err(error) => error,
        };
        assert!(
            error.contains("_unset must be a non-empty list of supported route-default keys"),
            "got: {error}"
        );
    }
}