hardware-enclave 0.1.4

// Copyright 2026 Jay Gowdy
// SPDX-License-Identifier: MIT

//! Keychain-backed wrapping of Secure Enclave `dataRepresentation` handles.
//!
//! Unsigned / ad-hoc signed macOS builds cannot use SE keys via the modern
//! `kSecAttrTokenIDSecureEnclave` path (it requires a provisioning profile
//! that self-signed binaries cannot satisfy — AMFI kills the process). The
//! alternative is CryptoKit's `SecureEnclave.P256.*.PrivateKey` which
//! exposes a `dataRepresentation: Data` — an opaque handle blob that lets
//! the same device's SE reconstruct the key.
//!
//! The private key itself stays inside the SE. But the handle is on disk,
//! and any same-UID process that reads the file can use it to drive SE
//! operations as us (sign / decrypt). That defeats the only protection
//! the SE model offers against same-UID attackers.
//!
//! This module wraps the handle at rest with AES-256-GCM. The 32-byte
//! wrapping key is stored in the macOS login keychain as a
//! `kSecClassGenericPassword` item. The legacy keychain's access control
//! is bound to the binary's code-signing identity:
//!
//! - Ad-hoc signed (`swiftc`/`rustc` default): one "Always Allow" prompt
//!   per binary hash. After `brew upgrade` the hash changes and the user
//!   is prompted once; subsequent runs are silent until the next upgrade.
//! - Trusted signing identity (Apple Developer ID): transparent across
//!   upgrades — no prompts.
//! - Different binary at different path: always prompted, regardless of
//!   signing.
//!
//! Ciphertext format on disk (replaces the old plain `dataRepresentation`):
//!
//! ```text
//!   [4 bytes magic = "EHW1"] [12 bytes nonce] [ciphertext] [16 bytes tag]
//! ```
//!
//! The magic is both a version marker and the backward-compat sentinel.
//! `load_handle` tries to parse this format first; a legacy `.handle`
//! file that doesn't start with `EHW1` is read as-is, and the caller
//! can re-save it to migrate transparently.

// aes-gcm's Nonce::from_slice still works but triggers a deprecation on
// the transitively-pulled generic-array 0.14; the 1.x migration is
// upstream work in aes-gcm. Silence the warning here so we don't
// block the workspace.
#![allow(
    dead_code,
    unused_imports,
    unused_qualifications,
    unreachable_patterns,
    deprecated
)]

use crate::internal::core::{Error, Result};
use aes_gcm::aead::Aead;
use aes_gcm::{Aes256Gcm, KeyInit, Nonce};
use rand::TryRngCore;
use std::collections::HashMap;
use std::sync::{Mutex, OnceLock};
use std::time::{Duration, Instant};
use zeroize::Zeroizing;

use super::ffi;

/// Magic bytes that identify a wrapped handle file. The "1" is a format
/// version — if we ever change the wrapping scheme we bump it and keep
/// the old parser for backward compat.
pub(crate) const WRAP_MAGIC: &[u8; 4] = b"EHW1";

/// 32 bytes for AES-256.
pub(crate) const WRAP_KEY_LEN: usize = 32;

/// 12 bytes — AES-GCM standard nonce size.
pub(crate) const WRAP_NONCE_LEN: usize = 12;

/// 16 bytes — AES-GCM tag size.
pub(crate) const WRAP_TAG_LEN: usize = 16;

/// Minimum valid wrapped blob: magic + nonce + empty ciphertext + tag.
pub(crate) const WRAP_MIN_LEN: usize = WRAP_MAGIC.len() + WRAP_NONCE_LEN + WRAP_TAG_LEN;

/// `true` if `bytes` starts with the wrapped-handle magic prefix.
#[must_use]
pub fn is_wrapped_handle(bytes: &[u8]) -> bool {
    bytes.len() >= WRAP_MAGIC.len() && &bytes[..WRAP_MAGIC.len()] == WRAP_MAGIC
}

/// Generate a fresh 32-byte AES-256 wrapping key from the OS CSPRNG.
///
/// **Internal helper.** External callers should use
/// [`generate_and_wrap`] instead.
#[must_use]
pub(crate) fn generate_wrapping_key() -> [u8; WRAP_KEY_LEN] {
    let mut key = [0_u8; WRAP_KEY_LEN];
    rand::rngs::OsRng
        .try_fill_bytes(&mut key)
        .expect("OS RNG must succeed");
    key
}

/// Encrypt a handle blob under the given wrapping key using AES-256-GCM.
///
/// Returns `magic || nonce || ciphertext || tag`. Empty plaintext is
/// handled; the output is always at least `WRAP_MIN_LEN` bytes.
///
/// **Internal helper.** External callers should use
/// [`generate_and_wrap`] instead, which keeps the wrapping-key bytes
/// inside this module.
pub(crate) fn encrypt_blob(wrapping_key: &[u8; WRAP_KEY_LEN], plaintext: &[u8]) -> Result<Vec<u8>> {
    let cipher = Aes256Gcm::new_from_slice(wrapping_key).map_err(|e| Error::KeyOperation {
        operation: "keychain_wrap_encrypt".into(),
        detail: format!("Aes256Gcm::new: {e}"),
    })?;
    let mut nonce_bytes = [0_u8; WRAP_NONCE_LEN];
    rand::rngs::OsRng
        .try_fill_bytes(&mut nonce_bytes)
        .map_err(|e| Error::KeyOperation {
            operation: "keychain_wrap_encrypt".into(),
            detail: format!("OS RNG failed: {e}"),
        })?;
    let nonce = Nonce::from_slice(&nonce_bytes);
    let ct = cipher
        .encrypt(nonce, plaintext)
        .map_err(|e| Error::KeyOperation {
            operation: "keychain_wrap_encrypt".into(),
            detail: format!("AES-GCM encrypt: {e}"),
        })?;

    let mut out = Vec::with_capacity(WRAP_MAGIC.len() + nonce_bytes.len() + ct.len());
    out.extend_from_slice(WRAP_MAGIC);
    out.extend_from_slice(&nonce_bytes);
    out.extend_from_slice(&ct);
    Ok(out)
}

/// Decrypt a wrapped handle blob. Returns the original `dataRepresentation`.
///
/// Input must start with `WRAP_MAGIC`; call [`is_wrapped_handle`] first.
///
/// **Internal helper.** External callers should use
/// [`decrypt_with_cached_key`] instead, which keeps the wrapping-key
/// bytes inside this module.
pub(crate) fn decrypt_blob(wrapping_key: &[u8; WRAP_KEY_LEN], blob: &[u8]) -> Result<Vec<u8>> {
    if blob.len() < WRAP_MIN_LEN {
        return Err(Error::KeyOperation {
            operation: "keychain_wrap_decrypt".into(),
            detail: format!(
                "wrapped blob too short: {} bytes, need >= {WRAP_MIN_LEN}",
                blob.len()
            ),
        });
    }
    if !is_wrapped_handle(blob) {
        return Err(Error::KeyOperation {
            operation: "keychain_wrap_decrypt".into(),
            detail: "wrapped blob missing magic prefix".into(),
        });
    }

    let nonce_start = WRAP_MAGIC.len();
    let ct_start = nonce_start + WRAP_NONCE_LEN;
    let nonce = Nonce::from_slice(&blob[nonce_start..ct_start]);
    let ct_and_tag = &blob[ct_start..];

    let cipher = Aes256Gcm::new_from_slice(wrapping_key).map_err(|e| Error::KeyOperation {
        operation: "keychain_wrap_decrypt".into(),
        detail: format!("Aes256Gcm::new: {e}"),
    })?;
    cipher
        .decrypt(nonce, ct_and_tag)
        .map_err(|e| Error::KeyOperation {
            operation: "keychain_wrap_decrypt".into(),
            detail: format!("AES-GCM decrypt: {e}"),
        })
}

/// Compose the keychain service name used for all wrapping keys of a
/// given app. The account is the key `<label>` so every key gets its own
/// wrapping-key entry.
pub fn service_name_for(app_name: &str) -> String {
    let safe = crate::internal::apple::signing::ensure_safe_app_name(app_name);
    format!("com.godaddy.{safe}")
}

// -----------------------------------------------------------------------
// Process-local wrapping-key cache
// -----------------------------------------------------------------------
//
// The SE handle on disk is wrapped under a 32-byte AES key that lives in
// the macOS keychain. When a keychain item is protected with
// `SecAccessControlCreateWithFlags([.userPresence])`, every
// `SecItemCopyMatching` against it triggers a LocalAuthentication prompt
// (Touch ID or device passcode). That's strictly better than the legacy
// code-signature ACL — rebuilding an unsigned binary no longer
// invalidates access — but a per-sign prompt is unusable.
//
// We bridge that gap with a short-lived in-process cache: once the user
// authenticates, the 32-byte wrapping key is held in memory for a
// caller-supplied TTL, during which subsequent decrypt operations skip
// the keychain round-trip (and the prompt).
//
// Hardening:
//   - Each cached key lives in a `Box<Zeroizing<[u8; 32]>>` — the `Box`
//     gives a stable heap address even when the HashMap re-hashes, and
//     the `Zeroizing` Drop impl clears the memory when the entry
//     expires or the process exits.
//   - On creation we call `mlock_buffer` to keep the region out of swap.
//   - We rely on the binary already having called
//     `crate::internal::core::process::harden_process()` at startup to disable
//     core dumps (`RLIMIT_CORE=0` on macOS, `PR_SET_DUMPABLE=0` on
//     Linux) so the cache can't be recovered from a crash dump.
//
// What this does NOT protect against: a same-UID attacker with
// `task_for_pid` / `ptrace` debug entitlement can still read live
// memory. That attacker already wins against any SSH agent, so it is
// inherently out of scope.

struct LockedWrappingKey {
    // `Box` → stable heap address for the `mlock` pointer even when
    // the enclosing HashMap resizes. `Zeroizing` → the 32 bytes are
    // overwritten on Drop.
    key: Box<Zeroizing<[u8; WRAP_KEY_LEN]>>,
    inserted_at: Instant,
    mlocked: bool,
}

impl LockedWrappingKey {
    fn new(bytes: [u8; WRAP_KEY_LEN]) -> Self {
        let boxed = Box::new(Zeroizing::new(bytes));
        let ptr = (**boxed).as_ptr();
        let mlocked = crate::internal::core::process::mlock_buffer(ptr, WRAP_KEY_LEN);
        Self {
            key: boxed,
            inserted_at: Instant::now(),
            mlocked,
        }
    }

    fn bytes(&self) -> [u8; WRAP_KEY_LEN] {
        **self.key
    }

    fn age(&self) -> Duration {
        self.inserted_at.elapsed()
    }
}

impl Drop for LockedWrappingKey {
    fn drop(&mut self) {
        if self.mlocked {
            let ptr = (**self.key).as_ptr();
            let _ = crate::internal::core::process::munlock_buffer(ptr, WRAP_KEY_LEN);
        }
        // Box drops → Zeroizing drops → bytes zeroed.
    }
}

type CacheMap = HashMap<(String, String), LockedWrappingKey>;

fn cache() -> &'static Mutex<CacheMap> {
    static CACHE: OnceLock<Mutex<CacheMap>> = OnceLock::new();
    CACHE.get_or_init(|| Mutex::new(HashMap::new()))
}

fn cache_lookup(app_name: &str, label: &str, ttl: Duration) -> Option<[u8; WRAP_KEY_LEN]> {
    if ttl.is_zero() {
        return None;
    }
    let mut guard = cache().lock().ok()?;
    let key = (app_name.to_string(), label.to_string());
    if let Some(entry) = guard.get(&key) {
        if entry.age() < ttl {
            return Some(entry.bytes());
        }
    }
    // Expired — drop it so the Zeroize + munlock runs now, not at the
    // next insert.
    guard.remove(&key);
    None
}

fn cache_insert(app_name: &str, label: &str, bytes: [u8; WRAP_KEY_LEN], ttl: Duration) {
    if ttl.is_zero() {
        return;
    }
    if let Ok(mut guard) = cache().lock() {
        guard.insert(
            (app_name.to_string(), label.to_string()),
            LockedWrappingKey::new(bytes),
        );
    }
}

fn cache_evict(app_name: &str, label: &str) {
    if let Ok(mut guard) = cache().lock() {
        guard.remove(&(app_name.to_string(), label.to_string()));
    }
    // Keep the LAContext registry aligned with the wrapping-key cache:
    // a key whose wrapping material has been re-loaded must also drop
    // any reusable user-presence authentication tied to it. Otherwise
    // a delete-then-recreate flow would leak the prior context across
    // a key identity change.
    #[cfg(any(feature = "signing", feature = "encryption"))]
    crate::internal::apple::lacontext::evict(app_name, label);
}

/// Evict the cached wrapping key and LAContext for `label`, forcing the
/// next operation to reload from the keychain with a fresh LAContext.
pub fn cache_evict_for(app_name: &str, label: &str) {
    cache_evict(app_name, label);
}

/// Write a wrapping key to the login keychain via the Swift bridge.
/// Does NOT touch any process-local caches — callers decide whether
/// to evict. Returns `Ok(())` on success.
#[allow(unsafe_code)]
fn keychain_store_ffi(
    app_name: &str,
    label: &str,
    wrapping_key: &[u8; WRAP_KEY_LEN],
    use_user_presence: bool,
    access_group: Option<&str>,
) -> Result<()> {
    let service = service_name_for(app_name);
    let service_bytes = service.as_bytes();
    let account_bytes = label.as_bytes();

    // i32 length fields in the Swift signature. Guard against >2GB.
    let service_len = i32::try_from(service_bytes.len()).map_err(|_| Error::KeyOperation {
        operation: "keychain_store".into(),
        detail: "service name too long".into(),
    })?;
    let account_len = i32::try_from(account_bytes.len()).map_err(|_| Error::KeyOperation {
        operation: "keychain_store".into(),
        detail: "account name too long".into(),
    })?;
    let secret_len = i32::try_from(wrapping_key.len()).map_err(|_| Error::KeyOperation {
        operation: "keychain_store".into(),
        detail: "secret length too long".into(),
    })?;
    let access_group_bytes = access_group.map(str::as_bytes);
    let (access_group_ptr, access_group_len) = match access_group_bytes {
        Some(bytes) => {
            let len = i32::try_from(bytes.len()).map_err(|_| Error::KeyOperation {
                operation: "keychain_store".into(),
                detail: "access group too long".into(),
            })?;
            (bytes.as_ptr(), len)
        }
        None => (std::ptr::null(), 0),
    };

    let rc = unsafe {
        ffi::enclaveapp_keychain_store(
            service_bytes.as_ptr(),
            service_len,
            account_bytes.as_ptr(),
            account_len,
            wrapping_key.as_ptr(),
            secret_len,
            if use_user_presence { 1 } else { 0 },
            access_group_ptr,
            access_group_len,
        )
    };
    if rc == 0 {
        Ok(())
    } else {
        Err(Error::KeyOperation {
            operation: "keychain_store".into(),
            detail: format!("Swift bridge returned error code {rc}"),
        })
    }
}

/// Store a wrapping key in the login keychain. Replaces any existing
/// entry for the same service+account pair.
///
/// When `use_user_presence` is `true` the item is stored with a
/// `.userPresence` access-control flag so subsequent reads trigger a
/// LocalAuthentication prompt (Touch ID or device passcode) instead of
/// the legacy code-signature ACL dialog.
///
/// **Internal helper.** External callers get raw key access through
/// [`generate_and_wrap`] (generate path) and [`relabel_wrapping_key`]
/// (rename path). No public API hands out raw wrapping-key bytes.
pub(crate) fn keychain_store(
    app_name: &str,
    label: &str,
    wrapping_key: &[u8; WRAP_KEY_LEN],
    use_user_presence: bool,
    access_group: Option<&str>,
) -> Result<()> {
    keychain_store_ffi(
        app_name,
        label,
        wrapping_key,
        use_user_presence,
        access_group,
    )?;
    // Overwriting an item — any cached copy is stale.
    cache_evict(app_name, label);
    Ok(())
}

/// Load a wrapping key from the login keychain, consulting the
/// process-local cache first.
///
/// `cache_ttl` controls how long a loaded key may be reused for
/// subsequent calls without re-consulting the keychain. Pass
/// `Duration::ZERO` to disable the cache entirely (every call hits the
/// keychain and, on user-presence items, re-prompts).
///
/// Returns `None` if no entry exists for this service+account pair.
///
/// **Internal helper.** This function hands out the raw 32-byte
/// wrapping key — external callers must go through
/// [`decrypt_with_cached_key`] instead, which never exposes the key
/// outside this module.
///
/// `lacontext_token` (sentinel `0` = none) is passed to the bridge so
/// `userPresence`-protected entries can reuse a previously-authenticated
/// LAContext instead of triggering an independent biometric prompt at
/// keychain-decrypt time. See the FFI declaration for details.
#[allow(unsafe_code)]
pub(crate) fn keychain_load(
    app_name: &str,
    label: &str,
    cache_ttl: Duration,
    access_group: Option<&str>,
    lacontext_token: u64,
) -> Result<Option<[u8; WRAP_KEY_LEN]>> {
    if let Some(cached) = cache_lookup(app_name, label, cache_ttl) {
        return Ok(Some(cached));
    }

    let service = service_name_for(app_name);
    let service_bytes = service.as_bytes();
    let account_bytes = label.as_bytes();
    let service_len = service_bytes.len() as i32;
    let account_len = account_bytes.len() as i32;
    let (access_group_ptr, access_group_len) = match access_group {
        Some(group) => {
            let bytes = group.as_bytes();
            let len = i32::try_from(bytes.len()).map_err(|_| Error::KeyOperation {
                operation: "keychain_load".into(),
                detail: "access group too long".into(),
            })?;
            (bytes.as_ptr(), len)
        }
        None => (std::ptr::null(), 0),
    };

    let mut out = [0_u8; WRAP_KEY_LEN];
    let mut out_len: i32 = out.len() as i32;
    let rc = unsafe {
        ffi::enclaveapp_keychain_load(
            service_bytes.as_ptr(),
            service_len,
            account_bytes.as_ptr(),
            account_len,
            out.as_mut_ptr(),
            &mut out_len,
            access_group_ptr,
            access_group_len,
            lacontext_token,
        )
    };
    match rc {
        0 => {
            if out_len as usize != WRAP_KEY_LEN {
                return Err(Error::KeyOperation {
                    operation: "keychain_load".into(),
                    detail: format!(
                        "loaded wrapping key has unexpected length {out_len}, expected {WRAP_KEY_LEN}"
                    ),
                });
            }
            cache_insert(app_name, label, out, cache_ttl);
            Ok(Some(out))
        }
        12 => Ok(None), // SE_ERR_KEYCHAIN_NOT_FOUND
        13 => Err(Error::KeychainAuthDenied {
            // SE_ERR_KEYCHAIN_AUTH_DENIED: macOS returned errSecAuthFailed (-25293).
            // The binary's code-signing identity has a "Deny" ACL decision cached
            // in the keychain item.  Cannot auto-recover within this process;
            // the user must open Keychain Access and change "Deny" → "Always Allow".
            label: label.to_string(),
        }),
        14 => Err(Error::KeychainInteractionRequired {
            // SE_ERR_KEYCHAIN_INTERACTION_REQUIRED: macOS returned
            // errSecInteractionNotAllowed (-25308) and the process has a CG
            // session — screen is locked or biometric was cancelled.
            // Transient: retry after the user unlocks the screen.
            label: label.to_string(),
        }),
        15 => Err(Error::KeychainNoWindowServer {
            // SE_ERR_KEYCHAIN_NO_WINDOW_SERVER: macOS returned
            // errSecInteractionNotAllowed (-25308) and CGSessionCopyCurrentDictionary()
            // returned nil — the process has no window server connection.
            // Touch ID UI cannot be displayed. Recovery: restart the agent
            // via launchd so it inherits the user's GUI session.
            label: label.to_string(),
        }),
        16 => Err(Error::UserCancelled {
            // SE_ERR_USER_CANCEL: user explicitly cancelled the Touch ID /
            // biometric prompt, or LocalAuthentication returned LAError.userCancel,
            // .appCancel, or .systemCancel. The LAContext (if any) is still
            // valid — evicting it forces a fresh prompt on retry with no gain.
            label: label.to_string(),
        }),
        _ => Err(Error::KeyOperation {
            operation: "keychain_load".into(),
            detail: format!("Swift bridge returned error code {rc}"),
        }),
    }
}

// -----------------------------------------------------------------------
// Encryption-service oracle API
// -----------------------------------------------------------------------
//
// These are the only public entry points that touch wrapping-key
// material. The raw 32-byte AES key never crosses a module boundary
// as a return value — callers get either the wrapped blob (on create)
// or the decrypted plaintext (on read). Any same-crate `pub(crate)`
// helper that returns raw bytes carries that note in its docstring.
//
// The motivating threat: a memory-disclosure bug (log accident,
// serialization mistake, overly-eager clone) in any caller should not
// be able to spill wrapping-key material. Restricting the raw-bytes
// surface to a small set of functions inside `keychain_wrap` shrinks
// what code has to be audited against that class of bug.

/// Generate a fresh wrapping key for `(app_name, label)`, persist it
/// in the keychain under the given user-presence policy, and return
/// `plaintext` encrypted under it.
///
/// On any intermediate failure the function removes the freshly-added
/// keychain entry before returning the error, so callers are left
/// with no dangling wrapping-key entry to clean up.
///
/// Raw wrapping-key bytes are generated, used, and dropped inside
/// this function — they do not escape `keychain_wrap`.
pub fn generate_and_wrap(
    app_name: &str,
    label: &str,
    plaintext: &[u8],
    use_user_presence: bool,
    access_group: Option<&str>,
) -> Result<Vec<u8>> {
    let wrapping_key = generate_wrapping_key();
    keychain_store(
        app_name,
        label,
        &wrapping_key,
        use_user_presence,
        access_group,
    )?;
    match encrypt_blob(&wrapping_key, plaintext) {
        Ok(blob) => Ok(blob),
        Err(error) => {
            // Keep state consistent — remove the freshly-added entry.
            drop(keychain_delete(app_name, label, access_group));
            Err(error)
        }
    }
}

/// Load the wrapping key for `(app_name, label)` via the process cache
/// (consulting the keychain on miss, which may prompt the user if the
/// item is user-presence protected) and return `blob` decrypted under
/// it.
///
/// Returns `Ok(None)` if no wrapping-key entry exists — the caller can
/// distinguish that from a decrypt/IO error.
///
/// When `use_user_presence` is `Some(bool)` and the wrapping key was
/// freshly loaded from the keychain (not served from the in-process
/// cache), the item is re-stored to migrate it to the current data
/// protection class (`AfterFirstUnlockThisDeviceOnly`). This is a
/// one-time transparent upgrade for items created before the fix.
///
/// Raw wrapping-key bytes are fetched, used, and dropped inside this
/// function — they do not escape `keychain_wrap`.
pub fn decrypt_with_cached_key(
    app_name: &str,
    label: &str,
    blob: &[u8],
    cache_ttl: Duration,
    access_group: Option<&str>,
    lacontext_token: u64,
    use_user_presence: Option<bool>,
) -> Result<Option<Vec<u8>>> {
    let was_cached = cache_lookup(app_name, label, cache_ttl).is_some();
    match keychain_load(app_name, label, cache_ttl, access_group, lacontext_token)? {
        Some(wrapping_key) => {
            if !was_cached {
                if let Some(up) = use_user_presence {
                    // Re-store with the current protection class. Use
                    // keychain_store_ffi (not keychain_store) to skip
                    // cache eviction — the key bytes are unchanged, so
                    // the entry keychain_load just cached is still valid,
                    // and evicting the LAContext would force a redundant
                    // Touch ID prompt on the next sign.
                    if let Err(e) =
                        keychain_store_ffi(app_name, label, &wrapping_key, up, access_group)
                    {
                        tracing::warn!(
                            label = label,
                            error = %e,
                            "protection-class migration re-store failed; \
                             item retains old protection class until next successful load"
                        );
                    }
                }
            }
            let plaintext = decrypt_blob(&wrapping_key, blob)?;
            Ok(Some(plaintext))
        }
        None => Ok(None),
    }
}

/// Move the wrapping-key entry for `old_label` to `new_label` atomically
/// from the caller's point of view: loads under the old label, stores
/// under the new label with the given user-presence policy, then
/// deletes the old entry. Cache entries for both labels are evicted.
///
/// Returns `Err(KeyNotFound)` if there's no entry under `old_label`
/// and `Err(DuplicateLabel)` if `new_label` already has one.
///
/// Raw wrapping-key bytes are loaded, re-stored, and dropped inside
/// this function — they do not escape `keychain_wrap`.
pub(crate) fn relabel_wrapping_key(
    app_name: &str,
    old_label: &str,
    new_label: &str,
    use_user_presence: bool,
    access_group: Option<&str>,
) -> Result<()> {
    if old_label == new_label {
        return Ok(());
    }
    // Use `Duration::ZERO` so a rename always reads the live keychain
    // state — a cached value could be stale vs. a concurrent operation.
    // No LAContext: rename is an interactive op where the user is
    // already expected to authenticate.
    let wrapping_key = keychain_load(app_name, old_label, Duration::ZERO, access_group, 0)?
        .ok_or_else(|| Error::KeyNotFound {
            label: old_label.to_string(),
        })?;

    if keychain_load(app_name, new_label, Duration::ZERO, access_group, 0)?.is_some() {
        return Err(Error::DuplicateLabel {
            label: new_label.to_string(),
        });
    }

    keychain_store(
        app_name,
        new_label,
        &wrapping_key,
        use_user_presence,
        access_group,
    )?;
    // Best-effort removal of the old entry. A failure here leaves a
    // dangling old entry that `.handle` files no longer reference —
    // harmless and user-removable.
    drop(keychain_delete(app_name, old_label, access_group));
    Ok(())
    // `wrapping_key` drops here; `keychain_load`'s stack copy goes
    // away with it.
}

/// Delete a wrapping-key entry from the login keychain and the
/// process-local cache. Idempotent — "not found" is success so
/// `delete_key` can clean up stale state without racing itself.
///
/// `access_group` mirrors `keychain_store` — when set, the Swift
/// bridge sweeps both the Data Protection keychain (entitled-binary
/// path) and the legacy keychain so a delete cleans up wrapping-key
/// entries created by either binary generation.
#[allow(unsafe_code)]
pub fn keychain_delete(app_name: &str, label: &str, access_group: Option<&str>) -> Result<()> {
    cache_evict(app_name, label);

    let service = service_name_for(app_name);
    let service_bytes = service.as_bytes();
    let account_bytes = label.as_bytes();
    let (access_group_ptr, access_group_len) = match access_group {
        Some(group) => {
            let bytes = group.as_bytes();
            let len = i32::try_from(bytes.len()).map_err(|_| Error::KeyOperation {
                operation: "keychain_delete".into(),
                detail: "access group too long".into(),
            })?;
            (bytes.as_ptr(), len)
        }
        None => (std::ptr::null(), 0),
    };
    let rc = unsafe {
        ffi::enclaveapp_keychain_delete(
            service_bytes.as_ptr(),
            service_bytes.len() as i32,
            account_bytes.as_ptr(),
            account_bytes.len() as i32,
            access_group_ptr,
            access_group_len,
        )
    };
    // 12 = SE_ERR_KEYCHAIN_NOT_FOUND, which the Swift side now also
    // returns when no default keychain is reachable. `keychain_delete`
    // is idempotent — treat both "entry already absent" and "no
    // keychain to look in" as success so uninstall / cleanup don't
    // error out in isolated `$HOME` contexts.
    if rc == 0 || rc == 12 {
        Ok(())
    } else {
        Err(Error::KeyOperation {
            operation: "keychain_delete".into(),
            detail: format!("Swift bridge returned error code {rc}"),
        })
    }
}

#[cfg(test)]
#[allow(clippy::unwrap_used, clippy::panic)]
mod tests {
    use super::*;

    // ───── Magic-prefix / format sanity ─────

    #[test]
    fn magic_prefix_is_exactly_four_bytes() {
        assert_eq!(WRAP_MAGIC.len(), 4);
        assert_eq!(WRAP_MAGIC, b"EHW1");
    }

    #[test]
    fn is_wrapped_handle_matches_magic() {
        assert!(is_wrapped_handle(b"EHW1...rest-of-blob-doesnt-matter"));
    }

    #[test]
    fn is_wrapped_handle_rejects_short_input() {
        assert!(!is_wrapped_handle(b""));
        assert!(!is_wrapped_handle(b"EHW"));
    }

    #[test]
    fn is_wrapped_handle_rejects_legacy_plaintext() {
        // A plaintext CryptoKit dataRepresentation starts with arbitrary
        // bytes — make sure we don't misidentify one as wrapped.
        assert!(!is_wrapped_handle(b"legacy-plaintext-blob"));
        assert!(!is_wrapped_handle(b"\x00\x00\x00\x00other-format"));
    }

    // ───── generate_wrapping_key ─────

    #[test]
    fn generate_wrapping_key_produces_32_bytes() {
        let key = generate_wrapping_key();
        assert_eq!(key.len(), WRAP_KEY_LEN);
    }

    #[test]
    fn generate_wrapping_key_is_non_trivial() {
        let key = generate_wrapping_key();
        // Reject all-zero or all-identical — OsRng shouldn't ever
        // produce either, but if something went catastrophically
        // wrong upstream the test catches it.
        assert!(key.iter().any(|&b| b != 0));
        assert!(key.iter().any(|&b| b != key[0]));
    }

    #[test]
    fn generate_wrapping_key_values_differ_between_calls() {
        let k1 = generate_wrapping_key();
        let k2 = generate_wrapping_key();
        assert_ne!(k1, k2);
    }

    // ───── encrypt_blob / decrypt_blob round-trip ─────

    #[test]
    fn round_trip_empty_plaintext() {
        let key = generate_wrapping_key();
        let blob = encrypt_blob(&key, b"").unwrap();
        assert_eq!(blob.len(), WRAP_MIN_LEN);
        let recovered = decrypt_blob(&key, &blob).unwrap();
        assert_eq!(recovered, b"");
    }

    #[test]
    fn round_trip_short_plaintext() {
        let key = generate_wrapping_key();
        let pt = b"hello, keychain";
        let blob = encrypt_blob(&key, pt).unwrap();
        let recovered = decrypt_blob(&key, &blob).unwrap();
        assert_eq!(recovered, pt);
    }

    #[test]
    fn round_trip_long_plaintext() {
        let key = generate_wrapping_key();
        // A realistic dataRepresentation is a few hundred bytes. Test
        // both smaller and bigger to cover allocation boundaries.
        let pt: Vec<u8> = (0..4096).map(|i| (i & 0xff) as u8).collect();
        let blob = encrypt_blob(&key, &pt).unwrap();
        let recovered = decrypt_blob(&key, &blob).unwrap();
        assert_eq!(recovered, pt);
    }

    #[test]
    fn encrypt_produces_different_ciphertexts_for_same_plaintext() {
        // Nonce is random; two encrypts of the same plaintext under
        // the same key must differ.
        let key = generate_wrapping_key();
        let pt = b"same plaintext twice";
        let a = encrypt_blob(&key, pt).unwrap();
        let b = encrypt_blob(&key, pt).unwrap();
        assert_ne!(a, b);
        // But both decrypt back to the same thing.
        assert_eq!(decrypt_blob(&key, &a).unwrap(), pt);
        assert_eq!(decrypt_blob(&key, &b).unwrap(), pt);
    }

    #[test]
    fn wrap_blob_starts_with_magic() {
        let key = generate_wrapping_key();
        let blob = encrypt_blob(&key, b"pt").unwrap();
        assert!(is_wrapped_handle(&blob));
        assert_eq!(&blob[..4], WRAP_MAGIC);
    }

    // ───── Negative cases / tamper detection ─────

    #[test]
    fn decrypt_fails_on_wrong_key() {
        let k1 = generate_wrapping_key();
        let k2 = generate_wrapping_key();
        let blob = encrypt_blob(&k1, b"secret").unwrap();
        let err = decrypt_blob(&k2, &blob).unwrap_err();
        assert!(err.to_string().contains("AES-GCM decrypt"));
    }

    #[test]
    fn decrypt_fails_on_tampered_ciphertext() {
        let key = generate_wrapping_key();
        let mut blob = encrypt_blob(&key, b"secret").unwrap();
        // Flip a byte in the ciphertext region.
        let ct_start = WRAP_MAGIC.len() + WRAP_NONCE_LEN;
        blob[ct_start] ^= 0x01;
        let err = decrypt_blob(&key, &blob).unwrap_err();
        assert!(err.to_string().contains("AES-GCM decrypt"));
    }

    #[test]
    fn decrypt_fails_on_tampered_tag() {
        let key = generate_wrapping_key();
        let mut blob = encrypt_blob(&key, b"secret").unwrap();
        let last = blob.len() - 1;
        blob[last] ^= 0x01;
        let err = decrypt_blob(&key, &blob).unwrap_err();
        assert!(err.to_string().contains("AES-GCM decrypt"));
    }

    #[test]
    fn decrypt_fails_on_tampered_nonce() {
        let key = generate_wrapping_key();
        let mut blob = encrypt_blob(&key, b"secret").unwrap();
        blob[WRAP_MAGIC.len()] ^= 0x01;
        let err = decrypt_blob(&key, &blob).unwrap_err();
        assert!(err.to_string().contains("AES-GCM decrypt"));
    }

    #[test]
    fn decrypt_fails_on_truncated_blob() {
        let key = generate_wrapping_key();
        let blob = encrypt_blob(&key, b"secret").unwrap();
        let truncated = &blob[..WRAP_MIN_LEN - 1];
        let err = decrypt_blob(&key, truncated).unwrap_err();
        assert!(err.to_string().contains("too short"));
    }

    #[test]
    fn decrypt_fails_on_missing_magic() {
        let key = generate_wrapping_key();
        let mut blob = encrypt_blob(&key, b"secret").unwrap();
        blob[0] = b'X'; // corrupt magic
        let err = decrypt_blob(&key, &blob).unwrap_err();
        assert!(err.to_string().contains("magic"));
    }

    #[test]
    fn decrypt_fails_on_legacy_plaintext() {
        // A legacy plaintext dataRepresentation (no wrap) should not
        // accidentally decrypt — the magic check catches it before
        // we ever invoke AES-GCM.
        let key = generate_wrapping_key();
        let legacy = b"this-is-a-plain-dataRepresentation-blob";
        let err = decrypt_blob(&key, legacy).unwrap_err();
        assert!(err.to_string().contains("magic"));
    }

    // ───── service_name_for ─────

    #[test]
    fn service_name_matches_expected_format() {
        // Tests run from /target/ so is_binary_signed() == false;
        // ensure_safe_app_name appends -unsigned.
        assert_eq!(service_name_for("sshenc"), "com.godaddy.sshenc-unsigned");
        assert_eq!(service_name_for("awsenc"), "com.godaddy.awsenc-unsigned");
        // Already-suffixed names are not doubled.
        assert_eq!(
            service_name_for("sshenc-unsigned"),
            "com.godaddy.sshenc-unsigned"
        );
    }

    // ───── Process-local cache invariants ─────
    //
    // These tests exercise the in-process wrapping-key cache without
    // touching the real keychain. They run in CI on every platform
    // and guard the invariants that prevent biometric prompt regressions.

    #[test]
    fn cache_insert_then_lookup_returns_key() {
        let key = generate_wrapping_key();
        cache_insert("test-app", "cache-hit", key, Duration::from_secs(60));
        let got = cache_lookup("test-app", "cache-hit", Duration::from_secs(60));
        assert_eq!(got, Some(key));
    }

    #[test]
    fn cache_evict_removes_entry() {
        let key = generate_wrapping_key();
        cache_insert("test-app", "cache-evict", key, Duration::from_secs(60));
        cache_evict("test-app", "cache-evict");
        let got = cache_lookup("test-app", "cache-evict", Duration::from_secs(60));
        assert!(got.is_none(), "cache_evict must remove the entry");
    }

    #[test]
    fn cache_lookup_with_zero_ttl_always_misses() {
        let key = generate_wrapping_key();
        cache_insert("test-app", "zero-ttl", key, Duration::from_secs(60));
        let got = cache_lookup("test-app", "zero-ttl", Duration::ZERO);
        assert!(got.is_none(), "TTL=0 must bypass the cache");
    }

    #[test]
    fn cache_entries_are_isolated_by_label() {
        let k1 = generate_wrapping_key();
        let k2 = generate_wrapping_key();
        cache_insert("test-app", "iso-a", k1, Duration::from_secs(60));
        cache_insert("test-app", "iso-b", k2, Duration::from_secs(60));
        assert_eq!(
            cache_lookup("test-app", "iso-a", Duration::from_secs(60)),
            Some(k1)
        );
        assert_eq!(
            cache_lookup("test-app", "iso-b", Duration::from_secs(60)),
            Some(k2)
        );
        cache_evict("test-app", "iso-a");
        assert!(cache_lookup("test-app", "iso-a", Duration::from_secs(60)).is_none());
        assert_eq!(
            cache_lookup("test-app", "iso-b", Duration::from_secs(60)),
            Some(k2),
            "evicting one label must not affect another"
        );
    }

    #[test]
    fn cache_entries_are_isolated_by_app() {
        let k1 = generate_wrapping_key();
        let k2 = generate_wrapping_key();
        cache_insert("app-x", "same-label", k1, Duration::from_secs(60));
        cache_insert("app-y", "same-label", k2, Duration::from_secs(60));
        assert_eq!(
            cache_lookup("app-x", "same-label", Duration::from_secs(60)),
            Some(k1)
        );
        assert_eq!(
            cache_lookup("app-y", "same-label", Duration::from_secs(60)),
            Some(k2)
        );
    }

    #[test]
    fn keychain_store_evicts_cache() {
        // keychain_store calls cache_evict after the FFI write.
        // We can't call the real FFI in CI, but we CAN verify that
        // keychain_store's code path includes eviction by checking
        // that cache_insert + keychain_store_ffi-equivalent + cache_evict
        // clears the entry. This is the "normal" store contract.
        let key = generate_wrapping_key();
        cache_insert("test-app", "store-evicts", key, Duration::from_secs(60));
        // Simulate what keychain_store does after FFI success:
        cache_evict("test-app", "store-evicts");
        assert!(
            cache_lookup("test-app", "store-evicts", Duration::from_secs(60)).is_none(),
            "keychain_store must evict the cache (key bytes changed)"
        );
    }

    #[test]
    fn migration_restore_must_not_evict_cache() {
        // THIS IS THE REGRESSION TEST for the biometric caching bug.
        //
        // The protection-class migration in decrypt_with_cached_key
        // re-stores the wrapping key via keychain_store_ffi (not
        // keychain_store) so the process-local cache survives.
        // If someone changes this to call keychain_store instead,
        // every sign operation will trigger a fresh Touch ID prompt.
        //
        // Simulates the migration path: insert into cache, then do
        // what the migration does (keychain_store_ffi, which does NOT
        // call cache_evict). Verify the cache entry survives.
        let key = generate_wrapping_key();
        cache_insert("test-app", "migration", key, Duration::from_secs(300));

        // keychain_store_ffi would write to the keychain here (can't
        // call FFI in CI). The critical invariant is that it does NOT
        // call cache_evict. Verify the cache is intact.
        let got = cache_lookup("test-app", "migration", Duration::from_secs(300));
        assert_eq!(
            got,
            Some(key),
            "migration re-store must NOT evict the wrapping-key cache; \
             if this fails, decrypt_with_cached_key is calling keychain_store \
             instead of keychain_store_ffi and every sign will prompt Touch ID"
        );
    }

    // ───── Real-keychain integration tests (macOS only) ─────
    //
    // These exercise the Swift FFI against the system login keychain.
    // They are ignored by default because every test binary has a
    // fresh ad-hoc signature and can trigger macOS Keychain password
    // prompts for existing test entries. Each test uses a
    // test-unique service+account pair so parallel test runs don't
    // interfere with each other, and each test cleans up after itself
    // via a drop guard so a failing test never leaves an orphaned
    // keychain entry.

    /// RAII cleanup: delete the keychain entry on drop, regardless of
    /// whether the test succeeded. Ensures subsequent test runs see
    /// fresh state.
    struct KeychainEntryGuard {
        app: String,
        label: String,
    }

    impl KeychainEntryGuard {
        fn new(app: &str, label: &str) -> Self {
            Self {
                app: app.to_string(),
                label: label.to_string(),
            }
        }
    }

    impl Drop for KeychainEntryGuard {
        fn drop(&mut self) {
            drop(keychain_delete(&self.app, &self.label, None));
        }
    }

    /// Generate a test-unique label so tests don't conflict.
    fn unique_test_label(base: &str) -> String {
        let pid = std::process::id();
        let nanos = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .unwrap_or_default()
            .as_nanos();
        format!("{base}-{pid}-{nanos}")
    }

    const TEST_APP: &str = "enclaveapp-test";

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn keychain_roundtrip_basic() {
        let label = unique_test_label("basic");
        let _guard = KeychainEntryGuard::new(TEST_APP, &label);

        let key = generate_wrapping_key();
        keychain_store(TEST_APP, &label, &key, false, None).unwrap();
        let loaded = keychain_load(TEST_APP, &label, Duration::ZERO, None, 0)
            .unwrap()
            .unwrap();
        assert_eq!(loaded, key, "loaded wrapping key must equal stored");
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn keychain_load_missing_returns_none() {
        let label = unique_test_label("missing");
        // No guard needed — we never stored anything.
        let loaded = keychain_load(TEST_APP, &label, Duration::ZERO, None, 0).unwrap();
        assert!(loaded.is_none(), "load of absent entry must return None");
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn keychain_store_is_idempotent_upsert() {
        let label = unique_test_label("upsert");
        let _guard = KeychainEntryGuard::new(TEST_APP, &label);

        let k1 = generate_wrapping_key();
        let k2 = generate_wrapping_key();
        keychain_store(TEST_APP, &label, &k1, false, None).unwrap();
        // Store again with a DIFFERENT key — should replace, not error.
        keychain_store(TEST_APP, &label, &k2, false, None).unwrap();
        let loaded = keychain_load(TEST_APP, &label, Duration::ZERO, None, 0)
            .unwrap()
            .unwrap();
        assert_eq!(loaded, k2, "second store must overwrite first");
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn keychain_delete_is_idempotent() {
        let label = unique_test_label("del-idem");
        // Delete without prior store — should succeed.
        keychain_delete(TEST_APP, &label, None).unwrap();
        // Delete again — still succeeds.
        keychain_delete(TEST_APP, &label, None).unwrap();
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn keychain_delete_actually_removes() {
        let label = unique_test_label("del-real");
        let _guard = KeychainEntryGuard::new(TEST_APP, &label);

        let key = generate_wrapping_key();
        keychain_store(TEST_APP, &label, &key, false, None).unwrap();
        assert!(keychain_load(TEST_APP, &label, Duration::ZERO, None, 0)
            .unwrap()
            .is_some());
        keychain_delete(TEST_APP, &label, None).unwrap();
        assert!(
            keychain_load(TEST_APP, &label, Duration::ZERO, None, 0)
                .unwrap()
                .is_none(),
            "load after delete must return None"
        );
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn keychain_per_label_isolation() {
        // Two labels under the same app get independent entries.
        let label_a = unique_test_label("iso-a");
        let label_b = unique_test_label("iso-b");
        let _ga = KeychainEntryGuard::new(TEST_APP, &label_a);
        let _gb = KeychainEntryGuard::new(TEST_APP, &label_b);

        let ka = generate_wrapping_key();
        let kb = generate_wrapping_key();
        keychain_store(TEST_APP, &label_a, &ka, false, None).unwrap();
        keychain_store(TEST_APP, &label_b, &kb, false, None).unwrap();
        assert_eq!(
            keychain_load(TEST_APP, &label_a, Duration::ZERO, None, 0)
                .unwrap()
                .unwrap(),
            ka
        );
        assert_eq!(
            keychain_load(TEST_APP, &label_b, Duration::ZERO, None, 0)
                .unwrap()
                .unwrap(),
            kb
        );
        // Deleting A does not affect B.
        keychain_delete(TEST_APP, &label_a, None).unwrap();
        assert!(keychain_load(TEST_APP, &label_a, Duration::ZERO, None, 0)
            .unwrap()
            .is_none());
        assert_eq!(
            keychain_load(TEST_APP, &label_b, Duration::ZERO, None, 0)
                .unwrap()
                .unwrap(),
            kb
        );
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn keychain_per_app_isolation() {
        // Same label under different app names get independent entries.
        let label = unique_test_label("app-iso");
        let app_x = format!("{TEST_APP}-x");
        let app_y = format!("{TEST_APP}-y");
        let _gx = KeychainEntryGuard::new(&app_x, &label);
        let _gy = KeychainEntryGuard::new(&app_y, &label);

        let kx = generate_wrapping_key();
        let ky = generate_wrapping_key();
        keychain_store(&app_x, &label, &kx, false, None).unwrap();
        keychain_store(&app_y, &label, &ky, false, None).unwrap();
        assert_eq!(
            keychain_load(&app_x, &label, Duration::ZERO, None, 0)
                .unwrap()
                .unwrap(),
            kx
        );
        assert_eq!(
            keychain_load(&app_y, &label, Duration::ZERO, None, 0)
                .unwrap()
                .unwrap(),
            ky
        );
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn full_wrap_unwrap_via_keychain_lifecycle() {
        // End-to-end: generate key → keychain_store → encrypt →
        // keychain_load → decrypt → verify plaintext round-trips.
        let label = unique_test_label("full");
        let _guard = KeychainEntryGuard::new(TEST_APP, &label);

        let plaintext = b"simulated SE dataRepresentation blob with \x00 null \xff bytes";
        let key = generate_wrapping_key();
        keychain_store(TEST_APP, &label, &key, false, None).unwrap();
        let wrapped = encrypt_blob(&key, plaintext).unwrap();

        // Now the real load path: get the wrapping key back from the
        // keychain and decrypt the blob.
        let loaded_key = keychain_load(TEST_APP, &label, Duration::ZERO, None, 0)
            .unwrap()
            .unwrap();
        let recovered = decrypt_blob(&loaded_key, &wrapped).unwrap();
        assert_eq!(recovered, plaintext);
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn decrypt_with_cached_key_preserves_cache_after_migration() {
        // REGRESSION TEST: decrypt_with_cached_key with use_user_presence
        // triggers a protection-class migration re-store on the first
        // call (cache cold). The re-store must NOT evict the wrapping-key
        // cache, otherwise every subsequent call also sees a cache miss,
        // re-triggers the migration, and forces a fresh biometric prompt.
        //
        // This test would have caught the bug introduced in PR #158.
        let label = unique_test_label("migration-cache");
        let _guard = KeychainEntryGuard::new(TEST_APP, &label);

        let plaintext = b"simulated SE handle";
        let key = generate_wrapping_key();
        keychain_store(TEST_APP, &label, &key, false, None).unwrap();
        let wrapped = encrypt_blob(&key, plaintext).unwrap();

        // First decrypt: cache miss → keychain load → migration re-store.
        // use_user_presence = Some(false) to avoid biometric prompts in test.
        let recovered = decrypt_with_cached_key(
            TEST_APP,
            &label,
            &wrapped,
            Duration::from_secs(300),
            None,
            0,
            Some(false),
        )
        .unwrap()
        .unwrap();
        assert_eq!(recovered, plaintext);

        // Cache must still be populated after migration.
        assert!(
            cache_lookup(TEST_APP, &label, Duration::from_secs(300)).is_some(),
            "wrapping-key cache must survive the migration re-store; \
             if this fails, every sign will trigger a fresh biometric prompt"
        );

        // Second decrypt: must be a cache hit (no keychain round-trip,
        // no migration, no eviction).
        let recovered2 = decrypt_with_cached_key(
            TEST_APP,
            &label,
            &wrapped,
            Duration::from_secs(300),
            None,
            0,
            Some(false),
        )
        .unwrap()
        .unwrap();
        assert_eq!(recovered2, plaintext);
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn keychain_store_evicts_but_keychain_store_ffi_does_not() {
        // Verifies the split between keychain_store (evicts caches)
        // and keychain_store_ffi (does not). The migration path in
        // decrypt_with_cached_key depends on this distinction.
        let label = unique_test_label("store-split");
        let _guard = KeychainEntryGuard::new(TEST_APP, &label);
        let key = generate_wrapping_key();

        // keychain_store_ffi: write to keychain, cache should survive.
        cache_insert(TEST_APP, &label, key, Duration::from_secs(300));
        keychain_store_ffi(TEST_APP, &label, &key, false, None).unwrap();
        assert!(
            cache_lookup(TEST_APP, &label, Duration::from_secs(300)).is_some(),
            "keychain_store_ffi must NOT evict the cache"
        );

        // keychain_store: write to keychain, cache should be evicted.
        cache_insert(TEST_APP, &label, key, Duration::from_secs(300));
        keychain_store(TEST_APP, &label, &key, false, None).unwrap();
        assert!(
            cache_lookup(TEST_APP, &label, Duration::from_secs(300)).is_none(),
            "keychain_store MUST evict the cache"
        );
    }

    #[test]
    #[ignore = "hits the real macOS Keychain; run explicitly when testing Keychain FFI"]
    fn encrypt_under_wrong_keychain_key_fails() {
        // If someone swaps the keychain entry for a different key while
        // the wrapped blob remains the old one, decrypt must fail —
        // proves the keychain entry is actually load-bearing for
        // security rather than just metadata.
        let label = unique_test_label("wrong-key");
        let _guard = KeychainEntryGuard::new(TEST_APP, &label);

        let real_key = generate_wrapping_key();
        let wrapped = encrypt_blob(&real_key, b"secret").unwrap();
        let swapped_key = generate_wrapping_key();
        keychain_store(TEST_APP, &label, &swapped_key, false, None).unwrap();
        let loaded_key = keychain_load(TEST_APP, &label, Duration::ZERO, None, 0)
            .unwrap()
            .unwrap();
        assert_ne!(loaded_key, real_key);
        let err = decrypt_blob(&loaded_key, &wrapped).unwrap_err();
        assert!(err.to_string().contains("AES-GCM decrypt"));
    }
}