guppy 0.17.26

Track and query Cargo dependency graphs.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
// Copyright (c) The cargo-guppy Contributors
// SPDX-License-Identifier: MIT OR Apache-2.0

use fixtures::{
    json::{self, JsonFixture},
    package_id,
};
use guppy::{
    PackageId,
    graph::{
        BuildTargetId, BuildTargetKind, DependencyDirection, DotWrite, PackageDotVisitor,
        PackageLink, PackageMetadata,
        feature::{FeatureId, FeatureLabel, StandardFeatures, named_feature_filter},
    },
};
use std::{collections::HashSet, fmt, iter};

mod small {
    use super::*;
    use crate::feature_helpers::assert_features_for_package;
    use fixtures::json::METADATA_CYCLE_FEATURES_BASE;
    use guppy::graph::PackageGraph;
    use pretty_assertions::assert_eq;

    // Test workspace_default_members field.
    #[test]
    fn metadata_default_members() {
        let graph = PackageGraph::from_json(include_str!(
            "../../../fixtures/small/metadata_default_members.json"
        ))
        .expect("valid metadata");

        let workspace = graph.workspace();
        let default_members: Vec<_> = workspace.default_members().collect();

        assert_eq!(default_members.len(), 1, "workspace has one default member");
        assert_eq!(
            default_members[0].name(),
            "testcrate",
            "default member is testcrate"
        );

        // Test that default_member_ids also works.
        let default_member_ids: Vec<_> = workspace.default_member_ids().collect();
        assert_eq!(
            default_member_ids.len(),
            1,
            "workspace has one default member ID"
        );
    }

    // Test specific details extracted from metadata1.json.
    #[test]
    fn metadata1() {
        let metadata1 = JsonFixture::metadata1();
        metadata1.verify();

        let graph = metadata1.graph();

        assert_eq!(
            graph.workspace().target_directory(),
            "/fakepath/testcrate/target",
            "target directory matches"
        );

        let testcrate = graph
            .metadata(&package_id(json::METADATA1_TESTCRATE))
            .expect("root crate should exist");
        let mut root_deps: Vec<_> = testcrate.direct_links().collect();

        assert_eq!(root_deps.len(), 1, "the root crate has one dependency");
        let link = root_deps.pop().expect("the root crate has one dependency");
        // XXX test for details of dependency edges as well?
        assert!(link.normal().is_present(), "normal dependency is defined");
        assert!(link.build().is_present(), "build dependency is defined");
        assert!(link.dev().is_present(), "dev dependency is defined");

        // Print out dot graphs for small subgraphs.
        static EXPECTED_DOT: &str = r#"digraph {
    0 [label="winapi-x86_64-pc-windows-gnu"]
    11 [label="mach"]
    13 [label="winapi"]
    14 [label="libc"]
    20 [label="winapi-i686-pc-windows-gnu"]
    26 [label="region"]
    31 [label="bitflags"]
    11 -> 14 [label="libc"]
    13 -> 20 [label="winapi-i686-pc-windows-gnu"]
    13 -> 0 [label="winapi-x86_64-pc-windows-gnu"]
    26 -> 31 [label="bitflags"]
    26 -> 14 [label="libc"]
    26 -> 11 [label="mach"]
    26 -> 13 [label="winapi"]
}
"#;
        let package_set = graph
            .query_forward(iter::once(&package_id(json::METADATA1_REGION)))
            .unwrap()
            .resolve();
        assert_eq!(
            EXPECTED_DOT,
            format!("{}", package_set.display_dot(NameVisitor)),
            "dot output matches"
        );

        // For reverse reachable ensure that the arrows are in the correct direction.
        static EXPECTED_DOT_REVERSED: &str = r#"digraph {
    1 [label="datatest"]
    9 [label="serde_yaml"]
    15 [label="dtoa"]
    18 [label="testcrate"]
    1 -> 9 [label="serde_yaml"]
    9 -> 15 [label="dtoa"]
    18 -> 1 [label="datatest"]
}
"#;
        let package_set = graph
            .query_reverse(iter::once(&package_id(json::METADATA1_DTOA)))
            .unwrap()
            .resolve();

        assert_eq!(
            EXPECTED_DOT_REVERSED,
            format!("{}", package_set.display_dot(NameVisitor)),
            "reversed dot output matches"
        );

        // ---

        // Check that resolve_with works by dropping all edges into libc (compare to example above).
        static EXPECTED_DOT_NO_LIBC: &str = r#"digraph {
    0 [label="winapi-x86_64-pc-windows-gnu"]
    11 [label="mach"]
    13 [label="winapi"]
    20 [label="winapi-i686-pc-windows-gnu"]
    26 [label="region"]
    31 [label="bitflags"]
    13 -> 20 [label="winapi-i686-pc-windows-gnu"]
    13 -> 0 [label="winapi-x86_64-pc-windows-gnu"]
    26 -> 31 [label="bitflags"]
    26 -> 11 [label="mach"]
    26 -> 13 [label="winapi"]
}
"#;
        let package_set = graph
            .query_forward(iter::once(&package_id(json::METADATA1_REGION)))
            .unwrap()
            .resolve_with_fn(|_, link| link.to().name() != "libc");
        assert_eq!(
            EXPECTED_DOT_NO_LIBC,
            format!("{}", package_set.display_dot(NameVisitor)),
            "dot output matches"
        );

        // ---

        let feature_graph = graph.feature_graph();
        assert_eq!(feature_graph.feature_count(), 506, "feature count");
        assert_eq!(feature_graph.link_count(), 631, "link count");
        let feature_set = feature_graph
            .query_workspace(StandardFeatures::All)
            .resolve();
        let root_ids: Vec<_> = feature_set.root_ids(DependencyDirection::Forward).collect();
        let testcrate_id = package_id(json::METADATA1_TESTCRATE);
        let expected = vec![FeatureId::named(&testcrate_id, "datatest")];
        assert_eq!(root_ids, expected, "feature graph root IDs match");
    }

    proptest_suite!(metadata1);

    #[test]
    fn metadata2() {
        let metadata2 = JsonFixture::metadata2();
        metadata2.verify();

        let feature_graph = metadata2.graph().feature_graph();
        assert_eq!(feature_graph.feature_count(), 484, "feature count");
        assert_eq!(feature_graph.link_count(), 589, "link count");
        let root_ids: Vec<_> = feature_graph
            .query_workspace(StandardFeatures::None)
            .resolve()
            .root_ids(DependencyDirection::Forward)
            .collect();
        let testcrate_id = package_id(json::METADATA2_TESTCRATE);
        let expected = vec![FeatureId::base(&testcrate_id)];
        assert_eq!(root_ids, expected, "feature graph root IDs match");
    }

    proptest_suite!(metadata2);

    #[test]
    fn metadata_dups() {
        let metadata_dups = JsonFixture::metadata_dups();
        metadata_dups.verify();
    }

    proptest_suite!(metadata_dups);

    #[test]
    fn metadata_cycle1() {
        let metadata_cycle1 = JsonFixture::metadata_cycle1();
        metadata_cycle1.verify();
    }

    proptest_suite!(metadata_cycle1);

    #[test]
    fn metadata_cycle2() {
        let metadata_cycle2 = JsonFixture::metadata_cycle2();
        metadata_cycle2.verify();
    }

    proptest_suite!(metadata_cycle2);

    #[test]
    fn metadata_cycle_features() {
        let metadata_cycle_features = JsonFixture::metadata_cycle_features();
        metadata_cycle_features.verify();
        let feature_graph = metadata_cycle_features.graph().feature_graph();

        let base_id = package_id(METADATA_CYCLE_FEATURES_BASE);
        let default_id = FeatureId::named(&base_id, "default");

        // default, default-enable and default-transitive are default features.
        for &f in &["default", "default-enable", "default-transitive"] {
            let this_id = FeatureId::named(&base_id, f);
            assert!(
                feature_graph
                    .is_default_feature(this_id)
                    .expect("valid feature ID"),
                "{f} is a default feature",
            );
            assert!(
                feature_graph
                    .depends_on(default_id, this_id)
                    .expect("valid feature IDs"),
                "{default_id} should depend on {this_id} but does not",
            );
        }

        // helper-enable and helper-transitive are *not* default features even though they are
        // enabled by the cyclic dev dependency. But the dependency relation is present.
        for &f in &["helper-enable", "helper-transitive"] {
            let this_id = FeatureId::named(&base_id, f);
            assert!(
                !feature_graph
                    .is_default_feature(this_id)
                    .expect("valid feature ID"),
                "{f} is NOT a default feature",
            );
            assert!(
                feature_graph
                    .depends_on(default_id, this_id)
                    .expect("valid feature IDs"),
                "{default_id} should depend on {this_id} but does not",
            );
        }
    }

    proptest_suite!(metadata_cycle_features);

    #[test]
    fn metadata_self_dev_cycle() {
        // This fixture exercises both kinds of cycle at once:
        //
        // * `base` declares a path dev-dependency on itself, placing it
        //   in a single-node SCC with a self-loop in both the package
        //   graph and the feature graph.
        // * `cycle-a` and `cycle-b` form a 2-node multi-SCC via a regular
        //   forward edge and a dev back-edge -- a classic dev-cycle.
        //
        // The single-node SCC must still be treated as a forward root
        // (and `helper` as a reverse root), and both directions of link
        // iteration must surface the self-edge alongside the
        // `base -> helper` edge. `all_cycles()` must report both kinds
        // of cycle in topological order.
        let fixture = JsonFixture::metadata_self_dev_cycle();
        fixture.verify();

        let graph = fixture.graph();
        let base_id = package_id(json::METADATA_SELF_DEV_CYCLE_BASE);
        let helper_id = package_id(json::METADATA_SELF_DEV_CYCLE_HELPER);
        let cycle_a_id = package_id(json::METADATA_SELF_DEV_CYCLE_CYCLE_A);
        let cycle_b_id = package_id(json::METADATA_SELF_DEV_CYCLE_CYCLE_B);

        // `all_cycles()` reports both cycles:
        //
        // * `base`'s single-node SCC has a self-loop (cycle of length 1).
        // * `{cycle-a, cycle-b}` is a 2-node multi-SCC.
        //
        // Within the multi-SCC, nodes are returned in non-dev order:
        // `cycle-a -> cycle-b` is the regular edge, so `cycle-a`
        // precedes `cycle-b`.
        //
        // `helper` has no self-loop and is not on any cycle.
        let cycles: Vec<Vec<&PackageId>> = graph.cycles().all_cycles().collect();
        assert_eq!(cycles, vec![vec![&base_id], vec![&cycle_a_id, &cycle_b_id]],);

        let cycles = graph.cycles();
        assert!(
            cycles.is_cyclic(&base_id, &base_id).expect("known id"),
            "base is on a self-loop cycle",
        );
        assert!(
            !cycles.is_cyclic(&helper_id, &helper_id).expect("known id"),
            "helper has no self-loop and is not on any cycle",
        );
        assert!(
            !cycles.is_cyclic(&base_id, &helper_id).expect("known ids"),
            "base and helper are in different SCCs",
        );
        // Multi-SCC membership: both `cycle-a` and `cycle-b` are on a
        // cycle individually, and they lie on a common cycle pairwise.
        assert!(
            cycles
                .is_cyclic(&cycle_a_id, &cycle_a_id)
                .expect("known id"),
            "cycle-a is in a 2-node SCC",
        );
        assert!(
            cycles
                .is_cyclic(&cycle_b_id, &cycle_b_id)
                .expect("known id"),
            "cycle-b is in a 2-node SCC",
        );
        assert!(
            cycles
                .is_cyclic(&cycle_a_id, &cycle_b_id)
                .expect("known ids"),
            "cycle-a and cycle-b share a multi-node SCC",
        );
        // The base self-loop SCC and the cycle-a/cycle-b SCC are
        // distinct, even though both are cyclic.
        assert!(
            !cycles.is_cyclic(&base_id, &cycle_a_id).expect("known ids"),
            "base and cycle-a are in different SCCs",
        );

        let direct: HashSet<(PackageId, PackageId)> = graph
            .metadata(&base_id)
            .expect("known id")
            .direct_links()
            .map(|link| (link.from().id().clone(), link.to().id().clone()))
            .collect();
        assert_eq!(
            direct,
            HashSet::from([
                (base_id.clone(), base_id.clone()),
                (base_id.clone(), helper_id.clone()),
            ]),
        );

        // `directly_depends_on(x, x)` is true iff `x` has a self-loop edge.
        // `base` has a path-self dev-dependency, so it does; `helper` does
        // not.
        assert!(
            graph
                .directly_depends_on(&base_id, &base_id)
                .expect("known id"),
            "base directly depends on itself via its path-self dev-dep",
        );
        assert!(
            !graph
                .directly_depends_on(&helper_id, &helper_id)
                .expect("known id"),
            "helper has no self-edge",
        );

        // Forward query from `base`.
        let resolved_forward = graph
            .query_forward([&base_id])
            .expect("base is a known package id")
            .resolve();
        let resolved_ids: HashSet<PackageId> = resolved_forward
            .package_ids(DependencyDirection::Forward)
            .cloned()
            .collect();
        assert_eq!(
            resolved_ids,
            HashSet::from([base_id.clone(), helper_id.clone()])
        );

        let forward_roots: Vec<PackageId> = resolved_forward
            .root_ids(DependencyDirection::Forward)
            .cloned()
            .collect();
        assert_eq!(forward_roots, vec![base_id.clone()]);

        let forward_links: HashSet<(PackageId, PackageId)> = resolved_forward
            .links(DependencyDirection::Forward)
            .map(|link| (link.from().id().clone(), link.to().id().clone()))
            .collect();
        assert_eq!(
            forward_links,
            HashSet::from([
                (base_id.clone(), base_id.clone()),
                (base_id.clone(), helper_id.clone()),
            ]),
        );

        // Reverse query from `helper`.
        let resolved_reverse = graph
            .query_reverse([&helper_id])
            .expect("helper is a known package id")
            .resolve();
        let resolved_reverse_ids: HashSet<PackageId> = resolved_reverse
            .package_ids(DependencyDirection::Reverse)
            .cloned()
            .collect();
        assert_eq!(
            resolved_reverse_ids,
            HashSet::from([base_id.clone(), helper_id.clone()]),
        );

        let reverse_roots: Vec<PackageId> = resolved_reverse
            .root_ids(DependencyDirection::Reverse)
            .cloned()
            .collect();
        assert_eq!(reverse_roots, vec![helper_id.clone()]);

        let reverse_links: HashSet<(PackageId, PackageId)> = resolved_reverse
            .links(DependencyDirection::Reverse)
            .map(|link| (link.from().id().clone(), link.to().id().clone()))
            .collect();
        assert_eq!(
            reverse_links,
            HashSet::from([
                (base_id.clone(), base_id.clone()),
                (base_id.clone(), helper_id.clone()),
            ]),
        );

        let feature_graph = graph.feature_graph();
        let base_feature = FeatureId::new(&base_id, FeatureLabel::Base);
        let helper_feature = FeatureId::new(&helper_id, FeatureLabel::Base);

        // The same contract for `directly_depends_on` holds in the feature
        // graph: `base/[base]` has a self-loop (from the path dev-dep),
        // while `helper/[helper]` does not. No `SelfLoop` warning is
        // emitted here, since the loop comes from a dependency
        // declaration rather than a `[features]` entry.
        assert!(
            feature_graph
                .directly_depends_on(base_feature, base_feature)
                .expect("base/[base] is a valid feature id"),
            "base/[base] directly depends on itself",
        );
        assert!(
            !feature_graph
                .directly_depends_on(helper_feature, helper_feature)
                .expect("helper/[helper] is a valid feature id"),
            "helper/[helper] has no self-edge",
        );

        let resolved_feature = feature_graph
            .query_forward([base_feature])
            .expect("base/[base] is a valid feature id")
            .resolve();
        let feature_forward_roots: HashSet<FeatureId<'_>> = resolved_feature
            .root_ids(DependencyDirection::Forward)
            .collect();
        assert!(
            feature_forward_roots.contains(&base_feature),
            "feature graph forward roots should contain base/[base], got {feature_forward_roots:?}",
        );

        // Feature-graph cycle membership mirrors the package graph: the
        // self-loop on `base/[base]` makes it cyclic; `helper/[helper]`
        // has no self-loop and is not on any cycle.
        let feature_cycles = feature_graph.cycles();
        assert!(
            feature_cycles
                .is_cyclic(base_feature, base_feature)
                .expect("base/[base] is a valid feature id"),
            "base/[base] is on a self-loop cycle in the feature graph",
        );
        assert!(
            !feature_cycles
                .is_cyclic(helper_feature, helper_feature)
                .expect("helper/[helper] is a valid feature id"),
            "helper/[helper] has no self-loop and is not on any cycle",
        );
        // The feature graph surfaces cycles from both kinds of cycle
        // in the package graph:
        //
        // * `base/[base]` self-loops from the package-level dev-dep.
        // * `base/extra` self-loops because the dev-dep declares
        //   `features = ["extra"]`, making `extra` reachable from itself
        //   via the dev-dep edge.
        // * `cycle-a/[base]` and `cycle-b/[base]` lie on the package-level
        //   2-node SCC, lifted into the feature graph.
        let base_extra_feature = FeatureId::new(&base_id, FeatureLabel::Named("extra"));
        let cycle_a_feature = FeatureId::new(&cycle_a_id, FeatureLabel::Base);
        let cycle_b_feature = FeatureId::new(&cycle_b_id, FeatureLabel::Base);
        let feature_cycle_members: HashSet<FeatureId<'_>> =
            feature_graph.cycles().all_cycles().flatten().collect();
        assert_eq!(
            feature_cycle_members,
            HashSet::from([
                base_feature,
                base_extra_feature,
                cycle_a_feature,
                cycle_b_feature,
            ]),
        );
    }

    proptest_suite!(metadata_self_dev_cycle);

    // Test Windows path handling in fixtures with path dependencies.
    #[test]
    fn metadata_cycle1_windows() {
        // Same drive: workspace on C:, path dep also on C:.
        // The path dependency should be stored as a relative path.
        let fixture = JsonFixture::metadata_cycle1_windows();
        fixture.verify();

        let graph = fixture.graph();
        let helper = graph
            .metadata(&package_id(json::METADATA_CYCLE1_WINDOWS_HELPER))
            .expect("helper package exists");

        let source = helper.source();
        assert!(source.is_path(), "helper should be a path dependency");
        let path = source.local_path().expect("path dependency has local path");
        // Same drive should produce a relative path.
        assert_eq!(
            path.as_str(),
            "../testcycles-helper",
            "same-drive path dependency should be relative"
        );
    }

    proptest_suite!(metadata_cycle1_windows);

    #[test]
    fn metadata_cycle1_windows_different_drives() {
        // Different drives: workspace on C:, path dep on D:.
        // The path dependency should fall back to the absolute path.
        let fixture = JsonFixture::metadata_cycle1_windows_different_drives();
        fixture.verify();

        let graph = fixture.graph();
        let helper = graph
            .metadata(&package_id(
                json::METADATA_CYCLE1_WINDOWS_DIFFERENT_DRIVES_HELPER,
            ))
            .expect("helper package exists");

        let source = helper.source();
        assert!(source.is_path(), "helper should be a path dependency");
        let path = source.local_path().expect("path dependency has local path");
        // Different drives cannot be relative, so the absolute path is stored.
        // The path is normalized to forward slashes on Unix but not on Windows.
        #[cfg(windows)]
        let expected = r"D:\libs\testcycles-helper";
        #[cfg(not(windows))]
        let expected = "D:/libs/testcycles-helper";
        assert_eq!(
            path.as_str(),
            expected,
            "different-drive path dependency should be absolute"
        );
    }

    proptest_suite!(metadata_cycle1_windows_different_drives);

    // Test that Windows metadata with backslash paths is normalized to forward
    // slashes on Unix, so all path operations work correctly. On Windows, the
    // paths should remain with backslashes.
    #[test]
    fn windows_metadata_path_normalization() {
        // Use the different drives fixture since it's more interesting: it has
        // paths on different drives which cannot be made relative.
        let fixture = JsonFixture::metadata_cycle1_windows_different_drives();
        let graph = fixture.graph();

        // On Unix: backslashes should be normalized to forward slashes.
        // On Windows: forward slashes should not appear in absolute paths.
        #[cfg(not(windows))]
        let bad_sep = '\\';
        #[cfg(windows)]
        let bad_sep = '/';

        let root = graph.workspace().root();
        assert!(
            !root.as_str().contains(bad_sep),
            "workspace root should not contain '{}': {}",
            bad_sep,
            root
        );
        assert!(root.parent().is_some(), "workspace root should have parent");

        let target_dir = graph.workspace().target_directory();
        assert!(
            !target_dir.as_str().contains(bad_sep),
            "target directory should not contain '{}': {}",
            bad_sep,
            target_dir
        );

        for package in graph.packages() {
            let manifest = package.manifest_path();
            assert!(
                !manifest.as_str().contains(bad_sep),
                "manifest_path should not contain '{}': {}",
                bad_sep,
                manifest
            );

            for target in package.build_targets() {
                let path = target.path();
                assert!(
                    !path.as_str().contains(bad_sep),
                    "build target path should not contain '{}': {}",
                    bad_sep,
                    path
                );
            }
        }
    }

    #[test]
    fn metadata_targets1() {
        let metadata_targets1 = JsonFixture::metadata_targets1();
        metadata_targets1.verify();

        let package_graph = metadata_targets1.graph();
        let package_set = package_graph.resolve_all();
        let feature_graph = metadata_targets1.graph().feature_graph();
        assert_eq!(feature_graph.feature_count(), 38, "feature count");

        // Some code that might be useful for debugging.
        if false {
            for (source, target, edge) in feature_graph
                .resolve_all()
                .links(DependencyDirection::Forward)
            {
                let source_metadata = package_graph.metadata(source.package_id()).unwrap();
                let target_metadata = package_graph.metadata(target.package_id()).unwrap();

                println!(
                    "feature link: {}:{} {} -> {}:{} {} {:?}",
                    source_metadata.name(),
                    source_metadata.version(),
                    source.label(),
                    target_metadata.name(),
                    target_metadata.version(),
                    target.label(),
                    edge
                );
            }
        }

        assert_eq!(feature_graph.link_count(), 58, "feature link count");

        // Check that resolve_packages + a feature filter works.
        let feature_set = package_set.to_feature_set(named_feature_filter(
            StandardFeatures::Default,
            ["foo", "bar"].iter().copied(),
        ));
        let dep_a_id = package_id(json::METADATA_TARGETS1_DEP_A);
        assert!(
            feature_set
                .contains((&dep_a_id, FeatureLabel::Named("foo")))
                .expect("valid feature ID")
        );
        assert!(
            feature_set
                .contains((&dep_a_id, FeatureLabel::Named("bar")))
                .expect("valid feature ID")
        );
        assert!(
            !feature_set
                .contains((&dep_a_id, FeatureLabel::Named("baz")))
                .expect("valid feature ID")
        );
        assert!(
            !feature_set
                .contains((&dep_a_id, FeatureLabel::Named("quux")))
                .expect("valid feature ID")
        );

        assert_features_for_package(
            &feature_set,
            &package_id(json::METADATA_TARGETS1_TESTCRATE),
            Some(&[FeatureLabel::Base]),
            "testcrate",
        );
        assert_features_for_package(
            &feature_set,
            &dep_a_id,
            Some(&[
                FeatureLabel::Base,
                FeatureLabel::Named("bar"),
                FeatureLabel::Named("foo"),
            ]),
            "dep a",
        );
        assert_features_for_package(
            &feature_set,
            &package_id(json::METADATA_TARGETS1_LAZY_STATIC_1),
            Some(&[FeatureLabel::Base]),
            "lazy_static",
        );
    }

    proptest_suite!(metadata_targets1);

    #[test]
    fn metadata_build_targets1() {
        let metadata_build_targets1 = JsonFixture::metadata_build_targets1();
        metadata_build_targets1.verify();
    }

    // No need for proptests because there are no dependencies involved.

    #[test]
    fn metadata_proc_macro1() {
        let metadata = JsonFixture::metadata_proc_macro1();
        metadata.verify();
        let graph = metadata.graph();

        let package = graph
            .metadata(&package_id(json::METADATA_PROC_MACRO1_MACRO))
            .expect("valid package ID");
        assert!(package.is_proc_macro(), "is proc macro");

        let build_target_kind = package
            .build_target(&BuildTargetId::Library)
            .expect("library package is present")
            .kind();
        assert_eq!(
            build_target_kind,
            BuildTargetKind::ProcMacro,
            "build target kind matches"
        );
    }

    // No need for proptests because this is a really simple test.
}

mod large {
    use super::*;
    use fixtures::dep_helpers::GraphAssert;

    #[test]
    fn metadata_libra() {
        let metadata_libra = JsonFixture::metadata_libra();
        metadata_libra.verify();
    }

    proptest_suite!(metadata_libra);

    #[test]
    fn metadata_libra_f0091a4() {
        let metadata = JsonFixture::metadata_libra_f0091a4();
        metadata.verify();
    }

    proptest_suite!(metadata_libra_f0091a4);

    #[test]
    fn metadata_libra_9ffd93b() {
        let metadata = JsonFixture::metadata_libra_9ffd93b();
        metadata.verify();

        let graph = metadata.graph();
        graph.assert_depends_on(
            &package_id(json::METADATA_LIBRA_ADMISSION_CONTROL_SERVICE),
            &package_id(json::METADATA_LIBRA_EXECUTOR_UTILS),
            DependencyDirection::Forward,
            "admission-control-service should depend on executor-utils",
        );
        graph.assert_not_depends_on(
            &package_id(json::METADATA_LIBRA_EXECUTOR_UTILS),
            &package_id(json::METADATA_LIBRA_ADMISSION_CONTROL_SERVICE),
            DependencyDirection::Forward,
            "executor-utils should not depend on admission-control-service",
        );

        let proc_macro_packages: Vec<_> = graph
            .workspace()
            .iter_by_path()
            .filter_map(|(_, metadata)| {
                if metadata.is_proc_macro() {
                    Some(metadata.name())
                } else {
                    None
                }
            })
            .collect();
        assert_eq!(
            proc_macro_packages,
            ["num-variants", "libra-crypto-derive"],
            "proc macro packages"
        );

        let build_script_packages: Vec<_> = graph
            .workspace()
            .iter_by_path()
            .filter_map(|(_, metadata)| {
                if metadata.has_build_script() {
                    Some(metadata.name())
                } else {
                    None
                }
            })
            .collect();
        assert_eq!(
            build_script_packages,
            [
                "admission-control-proto",
                "libra-dev",
                "debug-interface",
                "libra-metrics",
                "storage-proto",
                "libra_fuzzer_fuzz",
                "libra-types"
            ],
            "build script packages"
        );

        let mut build_dep_but_no_build_script: Vec<_> = graph
            .resolve_all()
            .links(DependencyDirection::Forward)
            .filter_map(|link| {
                if link.build().is_present() && !link.from().has_build_script() {
                    Some(link.from().name())
                } else {
                    None
                }
            })
            .collect();
        build_dep_but_no_build_script.sort_unstable();
        assert_eq!(
            build_dep_but_no_build_script,
            ["libra-mempool", "rusoto_signature"],
            "packages with build deps but no build scripts"
        );
    }

    proptest_suite!(metadata_libra_9ffd93b);

    #[test]
    fn mnemos_b3b4da9() {
        let metadata = JsonFixture::mnemos_b3b4da9();
        metadata.verify();
    }

    proptest_suite!(mnemos_b3b4da9);

    #[test]

    fn hyper_util_7afb1ed() {
        let metadata = JsonFixture::hyper_util_7afb1ed();
        metadata.verify();
    }

    proptest_suite!(hyper_util_7afb1ed);
}

mod guppy_tests {
    use super::*;
    use fixtures::json::METADATA_GUPPY_CARGO_GUPPY;
    use guppy::PackageId;

    #[test]
    fn metadata_guppy_44b62fa() {
        let metadata = JsonFixture::metadata_guppy_44b62fa();
        metadata.verify();

        // This is --no-deps metadata: check that there are no dependency edges at all.
        let graph = metadata.graph();
        let package = graph
            .metadata(&PackageId::new(METADATA_GUPPY_CARGO_GUPPY))
            .expect("cargo-guppy package found");
        assert_eq!(
            package.direct_links().count(),
            0,
            "no-deps => package has no direct links"
        );
        assert_eq!(graph.link_count(), 0, "no-deps => no edges");
    }

    proptest_suite!(metadata_guppy_44b62fa);
}

struct NameVisitor;

impl PackageDotVisitor for NameVisitor {
    fn visit_package(&self, package: PackageMetadata<'_>, f: &mut DotWrite<'_, '_>) -> fmt::Result {
        write!(f, "{}", package.name())
    }

    fn visit_link(&self, link: PackageLink<'_>, f: &mut DotWrite<'_, '_>) -> fmt::Result {
        write!(f, "{}", link.dep_name())
    }
}