guardrail 0.1.0

Defensive guardrails for AI coding agents — block destructive commands via hooks
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
use std::path::{Path, PathBuf};
use std::{env, fs};

use anyhow::Context;

use crate::model::{GuardrailConfig, Rule};

/// Resolve an XDG base directory, falling back to `$HOME/<fallback_suffix>`.
///
/// Used by config, cache, and journal modules to locate guardrail directories
/// via the XDG Base Directory Specification.
#[must_use]
pub fn xdg_dir(env_var: &str, fallback_suffix: &str) -> PathBuf {
    env::var(env_var)
        .map(PathBuf::from)
        .unwrap_or_else(|_| {
            PathBuf::from(env::var("HOME").unwrap_or_default()).join(fallback_suffix)
        })
}

const DEFAULTS_YAML: &str = include_str!("../rules/defaults.yaml");

// ═══════════════════════════════════════════════════════════════════
// RuleProvider trait — composable, mockable rule sources
// ═══════════════════════════════════════════════════════════════════

/// A source of guardrail rules. Implement for custom rule backends
/// (embedded, filesystem, remote, in-memory for testing).
pub trait RuleProvider {
    /// Provider name (for logging/diagnostics).
    fn name(&self) -> &str;

    /// Load rules from this provider.
    ///
    /// # Errors
    ///
    /// Returns an error if rules can't be loaded or parsed.
    fn rules(&self) -> anyhow::Result<Vec<Rule>>;
}

// ═══════════════════════════════════════════════════════════════════
// Built-in providers
// ═══════════════════════════════════════════════════════════════════

/// Compiled-in default rules (embedded via `include_str!`).
pub struct DefaultsProvider;

impl RuleProvider for DefaultsProvider {
    #[allow(clippy::unnecessary_literal_bound)]
    fn name(&self) -> &str { "defaults" }

    fn rules(&self) -> anyhow::Result<Vec<Rule>> {
        Ok(serde_yaml::from_str(DEFAULTS_YAML)?)
    }
}

/// Loads rules from a `rules.d/` directory. Each `.yaml` file is a
/// rule suite that can be independently added or removed.
pub struct DirectoryProvider {
    pub dir: PathBuf,
}

impl RuleProvider for DirectoryProvider {
    #[allow(clippy::unnecessary_literal_bound)]
    fn name(&self) -> &str { "directory" }

    fn rules(&self) -> anyhow::Result<Vec<Rule>> {
        let mut rules = Vec::new();
        if !self.dir.is_dir() {
            return Ok(rules);
        }
        let mut paths: Vec<_> = fs::read_dir(&self.dir)?
            .filter_map(Result::ok)
            .map(|e| e.path())
            .filter(|p| p.extension().is_some_and(|e| e == "yaml" || e == "yml"))
            .collect();
        paths.sort();
        for path in paths {
            let content = fs::read_to_string(&path)
                .with_context(|| format!("reading {}", path.display()))?;
            let batch: Vec<Rule> = serde_yaml::from_str(&content)
                .with_context(|| format!("parsing {}", path.display()))?;
            rules.extend(batch);
        }
        Ok(rules)
    }
}

/// In-memory rule provider for testing.
pub struct MockProvider {
    pub label: String,
    pub rules: Vec<Rule>,
}

impl RuleProvider for MockProvider {
    fn name(&self) -> &str { &self.label }

    fn rules(&self) -> anyhow::Result<Vec<Rule>> {
        Ok(self.rules.clone())
    }
}

// ═══════════════════════════════════════════════════════════════════
// Rule resolution — merges providers + config
// ═══════════════════════════════════════════════════════════════════

/// Collect rules from all providers, then apply config filters.
///
/// # Errors
///
/// Returns an error if any provider fails.
pub fn resolve(
    providers: &[&dyn RuleProvider],
    config: &GuardrailConfig,
) -> anyhow::Result<Vec<Rule>> {
    let mut all_rules = providers
        .iter()
        .map(|p| {
            p.rules()
                .with_context(|| format!("loading rules from provider '{}'", p.name()))
        })
        .collect::<anyhow::Result<Vec<_>>>()?
        .into_iter()
        .flatten()
        .collect::<Vec<_>>();

    all_rules.extend(config.extra_rules.clone());

    let filtered = all_rules
        .into_iter()
        .filter(|r| config.is_category_enabled(r.category))
        .filter(|r| !config.disabled_rules.contains(&r.name))
        .collect();

    Ok(filtered)
}

// ═══════════════════════════════════════════════════════════════════
// Convenience functions
// ═══════════════════════════════════════════════════════════════════

/// Load compiled-in default rules.
///
/// # Panics
///
/// Panics if the compiled-in `defaults.yaml` fails to parse, which
/// indicates a build-time invariant violation.
#[must_use]
pub fn default_rules() -> Vec<Rule> {
    DefaultsProvider.rules().expect("compiled-in defaults.yaml must be valid")
}

/// Shikumi config path: `~/.config/guardrail/guardrail.yaml`
#[must_use]
pub fn config_path() -> PathBuf {
    config_dir().join("guardrail.yaml")
}

/// Shikumi config directory: `~/.config/guardrail/`
#[must_use]
pub fn config_dir() -> PathBuf {
    xdg_dir("XDG_CONFIG_HOME", ".config").join("guardrail")
}

/// Rules.d directory: `~/.config/guardrail/rules.d/`
#[must_use]
pub fn rules_dir() -> PathBuf {
    config_dir().join("rules.d")
}

/// Load user config from disk. Returns default if file doesn't exist.
///
/// # Errors
///
/// Returns an error if the file exists but can't be parsed.
pub fn load_user_config(path: &Path) -> anyhow::Result<GuardrailConfig> {
    if !path.exists() {
        return Ok(GuardrailConfig::default());
    }
    let content = fs::read_to_string(path)
        .with_context(|| format!("reading {}", path.display()))?;
    serde_yaml::from_str(&content)
        .with_context(|| format!("parsing {}", path.display()))
}

/// Legacy convenience: merge defaults + user config.
///
/// # Panics
///
/// Panics if the mock provider fails, which should never happen
/// since mock providers always succeed.
#[must_use]
pub fn resolve_rules(defaults: &[Rule], config: &GuardrailConfig) -> Vec<Rule> {
    let provider = MockProvider { label: "defaults".into(), rules: defaults.to_vec() };
    resolve(&[&provider], config).expect("mock provider cannot fail")
}

// ═══════════════════════════════════════════════════════════════════
// Tests
// ═══════════════════════════════════════════════════════════════════

#[cfg(test)]
mod tests {
    use super::*;
    use crate::model::Category;
    use std::collections::BTreeMap;
    use tempfile::TempDir;

    fn test_rule(name: &str, category: Category) -> Rule {
        Rule::builder(name, name)
            .message(format!("{name} rule"))
            .category(category)
            .build()
    }

    // ─── DefaultsProvider ────────────────────────────────────────

    #[test]
    fn defaults_parse() {
        let rules = DefaultsProvider.rules().unwrap();
        assert!(rules.len() >= 25, "expected 25+ default rules, got {}", rules.len());
    }

    #[test]
    fn defaults_have_all_categories() {
        let rules = DefaultsProvider.rules().unwrap();
        let cats: std::collections::BTreeSet<Category> =
            rules.iter().map(|r| r.category).collect();
        for cat in [
            Category::Filesystem, Category::Git, Category::Database,
            Category::Kubernetes, Category::Nix, Category::Docker,
            Category::Secrets, Category::Terraform, Category::Flux,
        ] {
            assert!(cats.contains(&cat), "missing category: {cat:?}");
        }
    }

    // ─── DirectoryProvider ───────────────────────────────────────

    #[test]
    fn directory_provider_loads_yaml() {
        let dir = TempDir::new().unwrap();
        let yaml = serde_yaml::to_string(&vec![
            test_rule("custom-fs", Category::Filesystem),
        ]).unwrap();
        fs::write(dir.path().join("custom.yaml"), &yaml).unwrap();

        let provider = DirectoryProvider { dir: dir.path().to_path_buf() };
        let rules = provider.rules().unwrap();
        assert_eq!(rules.len(), 1);
        assert_eq!(rules[0].name, "custom-fs");
    }

    #[test]
    fn directory_provider_loads_multiple_files() {
        let dir = TempDir::new().unwrap();
        fs::write(dir.path().join("a.yaml"),
            serde_yaml::to_string(&vec![test_rule("rule-a", Category::Git)]).unwrap()
        ).unwrap();
        fs::write(dir.path().join("b.yaml"),
            serde_yaml::to_string(&vec![test_rule("rule-b", Category::Docker)]).unwrap()
        ).unwrap();

        let provider = DirectoryProvider { dir: dir.path().to_path_buf() };
        let rules = provider.rules().unwrap();
        assert_eq!(rules.len(), 2);
    }

    #[test]
    fn directory_provider_deterministic_order() {
        let dir = TempDir::new().unwrap();
        fs::write(dir.path().join("z.yaml"),
            serde_yaml::to_string(&vec![test_rule("z-rule", Category::Git)]).unwrap()
        ).unwrap();
        fs::write(dir.path().join("a.yaml"),
            serde_yaml::to_string(&vec![test_rule("a-rule", Category::Git)]).unwrap()
        ).unwrap();

        let provider = DirectoryProvider { dir: dir.path().to_path_buf() };
        let rules = provider.rules().unwrap();
        assert_eq!(rules[0].name, "a-rule"); // sorted by filename
        assert_eq!(rules[1].name, "z-rule");
    }

    #[test]
    fn directory_provider_empty_dir() {
        let dir = TempDir::new().unwrap();
        let provider = DirectoryProvider { dir: dir.path().to_path_buf() };
        assert!(provider.rules().unwrap().is_empty());
    }

    #[test]
    fn directory_provider_missing_dir() {
        let provider = DirectoryProvider { dir: PathBuf::from("/nonexistent") };
        assert!(provider.rules().unwrap().is_empty());
    }

    // ─── MockProvider ────────────────────────────────────────────

    #[test]
    fn mock_provider() {
        let provider = MockProvider {
            label: "test".into(),
            rules: vec![test_rule("mock", Category::Filesystem)],
        };
        assert_eq!(provider.name(), "test");
        assert_eq!(provider.rules().unwrap().len(), 1);
    }

    // ─── resolve() ───────────────────────────────────────────────

    #[test]
    fn resolve_merges_multiple_providers() {
        let p1 = MockProvider {
            label: "a".into(),
            rules: vec![test_rule("rule-a", Category::Filesystem)],
        };
        let p2 = MockProvider {
            label: "b".into(),
            rules: vec![test_rule("rule-b", Category::Git)],
        };
        let config = GuardrailConfig::default();
        let rules = resolve(&[&p1, &p2], &config).unwrap();
        assert_eq!(rules.len(), 2);
    }

    #[test]
    fn resolve_applies_category_toggle() {
        let p = MockProvider {
            label: "test".into(),
            rules: vec![
                test_rule("fs-rule", Category::Filesystem),
                test_rule("git-rule", Category::Git),
            ],
        };
        let mut cats = BTreeMap::new();
        cats.insert(Category::Git, false);
        let config = GuardrailConfig { categories: cats, ..Default::default() };
        let rules = resolve(&[&p], &config).unwrap();
        assert_eq!(rules.len(), 1);
        assert_eq!(rules[0].name, "fs-rule");
    }

    #[test]
    fn resolve_applies_disabled_rules() {
        let p = MockProvider {
            label: "test".into(),
            rules: vec![
                test_rule("keep", Category::Filesystem),
                test_rule("drop", Category::Filesystem),
            ],
        };
        let config = GuardrailConfig {
            disabled_rules: vec!["drop".into()],
            ..Default::default()
        };
        let rules = resolve(&[&p], &config).unwrap();
        assert_eq!(rules.len(), 1);
        assert_eq!(rules[0].name, "keep");
    }

    #[test]
    fn resolve_appends_extra_rules() {
        let p = MockProvider { label: "test".into(), rules: vec![] };
        let config = GuardrailConfig {
            extra_rules: vec![test_rule("extra", Category::Secrets)],
            ..Default::default()
        };
        let rules = resolve(&[&p], &config).unwrap();
        assert_eq!(rules.len(), 1);
        assert_eq!(rules[0].name, "extra");
    }

    #[test]
    fn resolve_extra_rules_respect_category_toggle() {
        let p = MockProvider { label: "test".into(), rules: vec![] };
        let mut cats = BTreeMap::new();
        cats.insert(Category::Secrets, false);
        let config = GuardrailConfig {
            categories: cats,
            extra_rules: vec![test_rule("extra-secret", Category::Secrets)],
            ..Default::default()
        };
        let rules = resolve(&[&p], &config).unwrap();
        assert!(rules.is_empty());
    }

    // ─── Legacy convenience ──────────────────────────────────────

    #[test]
    fn resolve_rules_legacy() {
        let defaults = default_rules();
        let config = GuardrailConfig {
            disabled_rules: vec!["rm-rf-root".into()],
            ..Default::default()
        };
        let rules = resolve_rules(&defaults, &config);
        assert!(!rules.iter().any(|r| r.name == "rm-rf-root"));
    }

    #[test]
    fn empty_config_returns_all_defaults() {
        let defaults = default_rules();
        let config = GuardrailConfig::default();
        let rules = resolve_rules(&defaults, &config);
        assert_eq!(rules.len(), defaults.len());
    }

    // ─── Suite file loading ──────────────────────────────────────

    #[test]
    fn akeyless_suite_parses() {
        let yaml = include_str!("../rules/akeyless.yaml");
        let rules: Vec<Rule> = serde_yaml::from_str(yaml).unwrap();
        assert!(rules.len() >= 30, "expected 30+ akeyless rules, got {}", rules.len());
        assert!(rules.iter().all(|r| r.category == Category::Akeyless));
    }

    #[test]
    fn aws_suite_parses() {
        let yaml = include_str!("../rules/aws.yaml");
        let rules: Vec<Rule> = serde_yaml::from_str(yaml).unwrap();
        assert!(rules.len() >= 20, "expected 20+ aws rules, got {}", rules.len());
        assert!(rules.iter().all(|r| r.category == Category::Cloud));
    }

    #[test]
    fn gcp_suite_parses() {
        let yaml = include_str!("../rules/gcp.yaml");
        let rules: Vec<Rule> = serde_yaml::from_str(yaml).unwrap();
        assert!(rules.len() >= 10);
    }

    #[test]
    fn azure_suite_parses() {
        let yaml = include_str!("../rules/azure.yaml");
        let rules: Vec<Rule> = serde_yaml::from_str(yaml).unwrap();
        assert!(rules.len() >= 15);
    }

    #[test]
    fn process_suite_parses() {
        let yaml = include_str!("../rules/process.yaml");
        let rules: Vec<Rule> = serde_yaml::from_str(yaml).unwrap();
        assert!(rules.len() >= 5);
        assert!(rules.iter().all(|r| r.category == Category::Process));
    }

    #[test]
    fn network_suite_parses() {
        let yaml = include_str!("../rules/network.yaml");
        let rules: Vec<Rule> = serde_yaml::from_str(yaml).unwrap();
        assert!(rules.len() >= 5);
        assert!(rules.iter().all(|r| r.category == Category::Network));
    }

    #[test]
    fn nosql_suite_parses() {
        let yaml = include_str!("../rules/nosql.yaml");
        let rules: Vec<Rule> = serde_yaml::from_str(yaml).unwrap();
        assert!(rules.len() >= 5);
        assert!(rules.iter().all(|r| r.category == Category::Nosql));
    }

    #[test]
    fn sql_suite_parses() {
        let yaml = include_str!("../rules/sql.yaml");
        let rules: Vec<Rule> = serde_yaml::from_str(yaml).unwrap();
        assert!(rules.len() >= 35, "expected 35+ sql rules, got {}", rules.len());
        assert!(rules.iter().all(|r| r.category == Category::Database));
    }

    // ─── load_user_config ─────────────────────────────────────

    #[test]
    fn load_user_config_missing_file_returns_default() {
        let config = load_user_config(std::path::Path::new("/nonexistent/config.yaml")).unwrap();
        assert!(config.categories.is_empty());
        assert!(config.extra_rules.is_empty());
        assert!(config.disabled_rules.is_empty());
    }

    #[test]
    fn load_user_config_valid_yaml() {
        let dir = TempDir::new().unwrap();
        let path = dir.path().join("guardrail.yaml");
        fs::write(&path, r#"
categories:
  git: false
disabledRules:
  - rm-rf-root
extraRules:
  - name: custom
    pattern: "danger"
    severity: warn
    message: "custom rule"
    category: secrets
"#).unwrap();
        let config = load_user_config(&path).unwrap();
        assert_eq!(config.categories.get(&Category::Git), Some(&false));
        assert_eq!(config.disabled_rules, vec!["rm-rf-root"]);
        assert_eq!(config.extra_rules.len(), 1);
        assert_eq!(config.extra_rules[0].name, "custom");
    }

    #[test]
    fn load_user_config_invalid_yaml_returns_error() {
        let dir = TempDir::new().unwrap();
        let path = dir.path().join("bad.yaml");
        fs::write(&path, "not: [valid: yaml: {{{{").unwrap();
        let result = load_user_config(&path);
        assert!(result.is_err());
    }

    #[test]
    fn load_user_config_empty_file() {
        let dir = TempDir::new().unwrap();
        let path = dir.path().join("empty.yaml");
        fs::write(&path, "").unwrap();
        // Empty YAML should deserialize as null -> error or default
        // serde_yaml::from_str("") returns an error for GuardrailConfig
        let result = load_user_config(&path);
        // Empty string in YAML is tricky — it may err or return default depending on version
        // Just ensure it doesn't panic
        let _ = result;
    }

    #[test]
    fn load_user_config_empty_object() {
        let dir = TempDir::new().unwrap();
        let path = dir.path().join("empty-obj.yaml");
        fs::write(&path, "{}").unwrap();
        let config = load_user_config(&path).unwrap();
        assert!(config.categories.is_empty());
    }

    // ─── config_path / config_dir / rules_dir ───────────────────

    #[test]
    fn config_dir_respects_xdg() {
        // config_dir reads XDG_CONFIG_HOME; we verify the return value includes "guardrail"
        let dir = config_dir();
        assert!(
            dir.ends_with("guardrail"),
            "config_dir should end with 'guardrail', got: {}",
            dir.display()
        );
    }

    #[test]
    fn config_path_ends_with_yaml() {
        let path = config_path();
        assert!(
            path.ends_with("guardrail.yaml"),
            "config_path should end with guardrail.yaml, got: {}",
            path.display()
        );
    }

    #[test]
    fn rules_dir_ends_with_rules_d() {
        let dir = rules_dir();
        assert!(
            dir.ends_with("rules.d"),
            "rules_dir should end with rules.d, got: {}",
            dir.display()
        );
    }

    #[test]
    fn xdg_dir_uses_env_var_when_set() {
        let dir = xdg_dir("HOME", ".fallback");
        assert!(
            !dir.to_string_lossy().is_empty(),
            "xdg_dir should return a non-empty path"
        );
    }

    #[test]
    fn xdg_dir_fallback_includes_suffix() {
        let dir = xdg_dir("NONEXISTENT_XDG_VAR_FOR_TEST_12345", ".some-fallback");
        assert!(
            dir.to_string_lossy().contains(".some-fallback"),
            "expected fallback suffix in path, got: {}",
            dir.display()
        );
    }

    #[test]
    fn rules_dir_is_child_of_config_dir() {
        let cd = config_dir();
        let rd = rules_dir();
        assert!(
            rd.starts_with(&cd),
            "rules_dir ({}) should be inside config_dir ({})",
            rd.display(), cd.display()
        );
    }

    // ─── DirectoryProvider edge cases ───────────────────────────

    #[test]
    fn directory_provider_ignores_non_yaml_files() {
        let dir = TempDir::new().unwrap();
        let yaml = serde_yaml::to_string(&vec![test_rule("yaml-rule", Category::Git)]).unwrap();
        fs::write(dir.path().join("rules.yaml"), &yaml).unwrap();
        fs::write(dir.path().join("readme.md"), "# not a rule file").unwrap();
        fs::write(dir.path().join("rules.json"), "{}").unwrap();
        fs::write(dir.path().join("notes.txt"), "random text").unwrap();

        let provider = DirectoryProvider { dir: dir.path().to_path_buf() };
        let rules = provider.rules().unwrap();
        assert_eq!(rules.len(), 1);
        assert_eq!(rules[0].name, "yaml-rule");
    }

    #[test]
    fn directory_provider_loads_yml_extension() {
        let dir = TempDir::new().unwrap();
        let yaml = serde_yaml::to_string(&vec![test_rule("yml-rule", Category::Nix)]).unwrap();
        fs::write(dir.path().join("rules.yml"), &yaml).unwrap();

        let provider = DirectoryProvider { dir: dir.path().to_path_buf() };
        let rules = provider.rules().unwrap();
        assert_eq!(rules.len(), 1);
        assert_eq!(rules[0].name, "yml-rule");
    }

    #[test]
    fn directory_provider_invalid_yaml_returns_error() {
        let dir = TempDir::new().unwrap();
        fs::write(dir.path().join("bad.yaml"), "not: [valid: yaml: {{{{").unwrap();

        let provider = DirectoryProvider { dir: dir.path().to_path_buf() };
        let result = provider.rules();
        assert!(result.is_err());
    }

    // ─── resolve() edge cases ───────────────────────────────────

    #[test]
    fn resolve_with_no_providers() {
        let config = GuardrailConfig::default();
        let rules = resolve(&[], &config).unwrap();
        assert!(rules.is_empty());
    }

    #[test]
    fn resolve_disabled_extra_rules() {
        let p = MockProvider { label: "test".into(), rules: vec![] };
        let config = GuardrailConfig {
            extra_rules: vec![test_rule("extra", Category::Filesystem)],
            disabled_rules: vec!["extra".into()],
            ..Default::default()
        };
        let rules = resolve(&[&p], &config).unwrap();
        assert!(rules.is_empty(), "extra rule should be disabled by name");
    }

    #[test]
    fn resolve_multiple_category_toggles() {
        let p = MockProvider {
            label: "test".into(),
            rules: vec![
                test_rule("fs", Category::Filesystem),
                test_rule("git", Category::Git),
                test_rule("k8s", Category::Kubernetes),
                test_rule("db", Category::Database),
            ],
        };
        let mut cats = BTreeMap::new();
        cats.insert(Category::Filesystem, false);
        cats.insert(Category::Kubernetes, false);
        let config = GuardrailConfig { categories: cats, ..Default::default() };
        let rules = resolve(&[&p], &config).unwrap();
        assert_eq!(rules.len(), 2);
        assert!(rules.iter().all(|r| r.category != Category::Filesystem && r.category != Category::Kubernetes));
    }

    // ─── resolve() error propagation ───────────────────────────

    struct FailingProvider;
    impl RuleProvider for FailingProvider {
        #[allow(clippy::unnecessary_literal_bound)]
        fn name(&self) -> &str { "failing" }
        fn rules(&self) -> anyhow::Result<Vec<Rule>> {
            anyhow::bail!("provider exploded")
        }
    }

    #[test]
    fn resolve_propagates_provider_error() {
        let config = GuardrailConfig::default();
        let result = resolve(&[&FailingProvider], &config);
        assert!(result.is_err());
        let msg = format!("{:#}", result.unwrap_err());
        assert!(
            msg.contains("failing"),
            "error should mention provider name, got: {msg}"
        );
    }

    #[test]
    fn resolve_fails_on_first_bad_provider() {
        let good = MockProvider {
            label: "good".into(),
            rules: vec![test_rule("ok", Category::Git)],
        };
        let config = GuardrailConfig::default();
        let result = resolve(&[&good, &FailingProvider], &config);
        assert!(result.is_err());
    }

    // ── Suite uniqueness ────────────────────────────────────────

    #[test]
    fn all_suites_have_unique_rule_names() {
        let mut all_names = std::collections::BTreeSet::new();
        let mut dupes = vec![];
        for yaml_str in [
            include_str!("../rules/defaults.yaml"),
            include_str!("../rules/akeyless.yaml"),
            include_str!("../rules/aws.yaml"),
            include_str!("../rules/gcp.yaml"),
            include_str!("../rules/azure.yaml"),
            include_str!("../rules/process.yaml"),
            include_str!("../rules/network.yaml"),
            include_str!("../rules/nosql.yaml"),
            include_str!("../rules/sql.yaml"),
        ] {
            let rules: Vec<Rule> = serde_yaml::from_str(yaml_str).unwrap();
            for rule in rules {
                if !all_names.insert(rule.name.clone()) {
                    dupes.push(rule.name);
                }
            }
        }
        assert!(dupes.is_empty(), "duplicate rule names across suites: {dupes:?}");
    }
}