gruff-rs 0.4.0

Rust static analyzer and quality linter for CI: dead-code, complexity, security, secrets, and architecture rules with deterministic SARIF/JSON output and baseline support.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
use super::*;

pub(crate) fn missing_path_diagnostics(missing_paths: &[String]) -> Vec<RunDiagnostic> {
    missing_paths
        .iter()
        .map(|missing_path| RunDiagnostic {
            diagnostic_type: "missing-path".to_string(),
            message: format!("Input path does not exist: {missing_path}"),
            file_path: Some(missing_path.clone()),
            line: None,
        })
        .collect()
}

// ADR-014: when excludeFromScore is set on a Security or SensitiveData
// rule, surface a non-fatal warning so the choice is user-visible.
// rule_settings is a HashMap, so sort matched rule ids before emitting
// for deterministic output. Custom rules can't reach this state — the
// config loader rejects excludeFromScore outside `enabled` for them.
fn excluded_security_rule_diagnostics(config: &Config) -> Vec<RunDiagnostic> {
    let mut ids = collect_excluded_security_rule_ids(config);
    ids.sort_by_key(|(rule_id, _)| *rule_id);
    ids.into_iter()
        .map(|(rule_id, pillar)| excluded_security_rule_diagnostic(rule_id, pillar))
        .collect()
}

fn collect_excluded_security_rule_ids(config: &Config) -> Vec<(&str, Pillar)> {
    let registry = rules::builtin_registry();
    config
        .rule_settings
        .iter()
        .filter(|(_, setting)| setting.exclude_from_score == Some(true))
        .filter_map(|(rule_id, _)| {
            let definition = registry.get(rule_id)?;
            matches!(definition.pillar, Pillar::Security | Pillar::SensitiveData)
                .then_some((rule_id.as_str(), definition.pillar))
        })
        .collect()
}

fn excluded_security_rule_diagnostic(rule_id: &str, pillar: Pillar) -> RunDiagnostic {
    RunDiagnostic {
        diagnostic_type: "excluded-security-rule-from-score".to_string(),
        message: format!(
            "Rule `{rule_id}` ({pillar:?} pillar) is configured with `excludeFromScore: true`; its findings still surface but no longer affect the composite score."
        ),
        file_path: None,
        line: None,
    }
}

pub(crate) fn sort_and_dedupe_findings(findings: &mut Vec<Finding>) {
    findings.sort_by(|left, right| {
        (
            left.file_path.as_str(),
            left.line.unwrap_or_default(),
            left.rule_id.as_str(),
            left.message.as_str(),
        )
            .cmp(&(
                right.file_path.as_str(),
                right.line.unwrap_or_default(),
                right.rule_id.as_str(),
                right.message.as_str(),
            ))
    });
    findings.dedup_by(|left, right| left.fingerprint == right.fingerprint);
}

pub(crate) fn apply_report_exclusions(
    findings: Vec<Finding>,
    exclusions: &[ExclusionRule],
) -> (
    Vec<Finding>,
    Vec<SuppressionSummary>,
    Vec<SuppressedFinding>,
) {
    if exclusions.is_empty() {
        return (findings, Vec::new(), Vec::new());
    }

    let mut summaries = initial_suppression_summaries(exclusions);
    let (kept, suppressed) = partition_excluded_findings(findings, exclusions, &mut summaries);
    (kept, summaries, suppressed)
}

fn initial_suppression_summaries(exclusions: &[ExclusionRule]) -> Vec<SuppressionSummary> {
    exclusions
        .iter()
        .enumerate()
        .map(|(index, exclusion)| SuppressionSummary {
            index,
            rule: exclusion.selector.clone(),
            paths: exclusion.paths.clone(),
            message_contains: exclusion.message_contains.clone(),
            reason: exclusion.reason.clone(),
            suppressed: 0,
        })
        .collect()
}

fn partition_excluded_findings(
    findings: Vec<Finding>,
    exclusions: &[ExclusionRule],
    summaries: &mut [SuppressionSummary],
) -> (Vec<Finding>, Vec<SuppressedFinding>) {
    let mut kept = Vec::with_capacity(findings.len());
    let mut suppressed = Vec::new();
    let path_matchers: Vec<Vec<PathMatcher>> = exclusions
        .iter()
        .map(|exclusion| compile_path_matchers(&exclusion.paths))
        .collect();
    for finding in findings {
        match exclusions
            .iter()
            .enumerate()
            .position(|(index, exclusion)| {
                exclusion_matches_finding_with_paths(exclusion, &path_matchers[index], &finding)
            }) {
            Some(index) => {
                summaries[index].suppressed += 1;
                suppressed.push(SuppressedFinding {
                    finding,
                    suppression: summaries[index].clone(),
                });
            }
            None => kept.push(finding),
        }
    }
    (kept, suppressed)
}

fn exclusion_matches_finding_with_paths(
    exclusion: &ExclusionRule,
    path_matchers: &[PathMatcher],
    finding: &Finding,
) -> bool {
    if !exclusion.rule_ids.contains(&finding.rule_id) {
        return false;
    }
    if !path_matchers.is_empty() {
        let file_path = normalize_report_path(&finding.file_path);
        if !path_matchers
            .iter()
            .any(|matcher| matcher.matches(&file_path))
        {
            return false;
        }
    }
    exclusion
        .message_contains
        .as_ref()
        .is_none_or(|message| finding.message.contains(message))
}

pub(crate) fn run_analysis_in_project(
    project_root: &Path,
    options: &AnalysisOptions,
    config: &Config,
) -> Result<AnalysisReport, String> {
    let mut discovery = discover_sources(project_root, options, config);
    let mut diagnostics = missing_path_diagnostics(&discovery.missing_paths);
    diagnostics.extend(excluded_security_rule_diagnostics(config));
    let diff_filter = resolve_diff_filter(project_root, options, &discovery.files)?;
    let pre_diff_rust_paths = rust_display_paths(&discovery.files);
    apply_diff_file_selection(&mut discovery, diff_filter.as_ref());
    let coverage = project_coverage(
        project_root,
        options,
        config,
        &discovery,
        &pre_diff_rust_paths,
        diff_filter.as_ref(),
    );
    let inputs = collect_report_inputs(
        project_root,
        options,
        config,
        discovery,
        diagnostics,
        coverage,
        diff_filter.as_ref(),
    )?;
    let mut report = build_report(project_root, options, config, inputs);
    record_history_if_requested(project_root, options, config, &mut report);
    Ok(report)
}

pub(crate) fn apply_gate_diagnostic(report: &mut AnalysisReport, gate: Option<&Gate>) {
    let Some(gate) = gate else {
        return;
    };
    let diagnostic = match gate.scope_precondition_error(report) {
        Some(message) => RunDiagnostic {
            diagnostic_type: "gate-config-error".to_string(),
            message,
            file_path: None,
            line: None,
        },
        None => gate.diagnostic(report),
    };
    report.diagnostics.push(diagnostic);
}

fn collect_report_inputs(
    project_root: &Path,
    options: &AnalysisOptions,
    config: &Config,
    discovery: DiscoveryResult,
    mut diagnostics: Vec<RunDiagnostic>,
    coverage: ProjectCoverage,
    diff_filter: Option<&ResolvedDiffFilter>,
) -> Result<ReportInputs, String> {
    let analysed_paths = analysed_display_paths(&discovery.files);
    let AnalysisArtifacts {
        mut findings,
        function_blocks_by_file,
    } = analyse_discovered_sources_with_artifacts(
        project_root,
        &discovery.files,
        config,
        coverage,
        has_symbol_scope_diff(diff_filter),
        &mut diagnostics,
    );
    sort_and_dedupe_findings(&mut findings);
    let all_findings = findings.clone();
    let (baseline_resolution, all_findings_summary) =
        resolve_baseline(project_root, options, &mut findings)?;
    let (findings, summaries, suppressed_findings) =
        apply_report_exclusions(findings, &config.exclusions);
    let (baseline_report, per_rule_deltas) = split_baseline_resolution(baseline_resolution);
    let inputs = ReportInputs {
        discovery,
        diagnostics,
        findings,
        baseline_report,
        suppressions: report_suppressions(summaries, suppressed_findings),
        per_rule_deltas,
        suppressed_count: None,
        all_findings_summary: Some(all_findings_summary),
        all_findings,
    };
    Ok(apply_changed_region_to_inputs(
        project_root,
        options,
        config,
        inputs,
        diff_filter,
        &analysed_paths,
        &function_blocks_by_file,
    ))
}

fn has_symbol_scope_diff(diff_filter: Option<&ResolvedDiffFilter>) -> bool {
    diff_filter.is_some_and(|filter| filter.scope == ChangedScope::Symbol)
}

fn report_suppressions(
    summaries: Vec<SuppressionSummary>,
    suppressed_findings: Vec<SuppressedFinding>,
) -> ReportSuppressions {
    ReportSuppressions {
        summaries,
        suppressed_findings,
    }
}

/// Run the changed-region filter over an already-assembled report and re-pack
/// the filtered findings, suppressions, deltas, and suppressed-count back into
/// `ReportInputs`. With no diff filter the inputs pass through untouched.
/// `discovery` and `baseline_report` pass through unchanged - the filter only
/// narrows findings to the changed region.
fn apply_changed_region_to_inputs(
    project_root: &Path,
    options: &AnalysisOptions,
    config: &Config,
    inputs: ReportInputs,
    diff_filter: Option<&ResolvedDiffFilter>,
    analysed_paths: &BTreeSet<String>,
    function_blocks_by_file: &BTreeMap<String, Vec<FunctionBlock>>,
) -> ReportInputs {
    let Some(diff_filter) = diff_filter else {
        return inputs;
    };
    let discovery = inputs.discovery.clone();
    let baseline_report = inputs.baseline_report.clone();
    let all_findings = inputs.all_findings.clone();
    let report = build_report(project_root, options, config, inputs);
    let report = apply_changed_region_filter(
        report,
        &diff_filter.patch,
        analysed_paths,
        config,
        function_blocks_by_file,
        diff_filter.scope,
    );
    let all_findings_summary =
        changed_scope_all_summary(&all_findings, diff_filter, function_blocks_by_file);
    ReportInputs {
        discovery,
        all_findings_summary: Some(all_findings_summary),
        diagnostics: report.diagnostics,
        findings: report.findings,
        baseline_report,
        suppressions: ReportSuppressions {
            summaries: report.suppressions,
            suppressed_findings: report.suppressed_findings,
        },
        per_rule_deltas: report.per_rule_deltas,
        suppressed_count: report.suppressed_count,
        all_findings,
    }
}

fn changed_scope_all_summary(
    all_findings: &[Finding],
    diff_filter: &ResolvedDiffFilter,
    function_blocks_by_file: &BTreeMap<String, Vec<FunctionBlock>>,
) -> Summary {
    summarize_changed_findings(
        all_findings,
        &diff_filter.patch,
        function_blocks_by_file,
        diff_filter.scope,
    )
}

fn split_baseline_resolution(
    resolution: Option<BaselineResolution>,
) -> (Option<BaselineReport>, Option<Vec<RuleDelta>>) {
    let Some(BaselineResolution { report, deltas }) = resolution else {
        return (None, None);
    };
    let deltas = (!report.generated && !deltas.is_empty()).then_some(deltas);
    (Some(report), deltas)
}

pub(crate) fn analysed_display_paths(files: &[SourceFile]) -> BTreeSet<String> {
    files.iter().map(|file| file.display_path.clone()).collect()
}

fn rust_display_paths(files: &[SourceFile]) -> BTreeSet<String> {
    files
        .iter()
        .filter(|file| file.is_rust)
        .map(|file| file.display_path.clone())
        .collect()
}

fn project_coverage(
    project_root: &Path,
    options: &AnalysisOptions,
    config: &Config,
    discovery: &DiscoveryResult,
    pre_diff_rust_paths: &BTreeSet<String>,
    diff_filter: Option<&ResolvedDiffFilter>,
) -> ProjectCoverage {
    let analysed_rust_files = rust_display_paths(&discovery.files);
    if !config.is_rule_enabled("dead-code.unused-private-item-candidate") {
        return ProjectCoverage {
            discoverable_rust_files: analysed_rust_files.clone(),
            analysed_rust_files,
            diff_selection_narrowed: false,
            parse_incomplete: false,
        };
    }

    let discoverable_rust_files = discover_project_rust_universe(project_root, options, config);
    let diff_selection_narrowed = diff_filter.is_some_and(|filter| {
        !filter.explicit_ranges && !pre_diff_rust_paths.is_subset(&analysed_rust_files)
    });
    ProjectCoverage {
        discoverable_rust_files,
        analysed_rust_files,
        diff_selection_narrowed,
        parse_incomplete: false,
    }
}

fn discover_project_rust_universe(
    project_root: &Path,
    options: &AnalysisOptions,
    config: &Config,
) -> BTreeSet<String> {
    let mut universe_options = options.clone();
    universe_options.paths = vec![PathBuf::from(".")];
    universe_options.diff = None;
    rust_display_paths(&discover_sources(project_root, &universe_options, config).files)
}

#[cfg(test)]
pub(crate) fn project_coverage_for_test(
    project_root: &Path,
    options: &AnalysisOptions,
    config: &Config,
) -> Result<ProjectCoverage, String> {
    let mut discovery = discover_sources(project_root, options, config);
    let diff_filter = resolve_diff_filter(project_root, options, &discovery.files)?;
    let pre_diff_rust_paths = rust_display_paths(&discovery.files);
    apply_diff_file_selection(&mut discovery, diff_filter.as_ref());
    Ok(project_coverage(
        project_root,
        options,
        config,
        &discovery,
        &pre_diff_rust_paths,
        diff_filter.as_ref(),
    ))
}

pub(crate) struct AnalysisArtifacts {
    pub(crate) findings: Vec<Finding>,
    pub(crate) function_blocks_by_file: BTreeMap<String, Vec<FunctionBlock>>,
}

pub(crate) fn analyse_discovered_sources_with_artifacts(
    project_root: &Path,
    files: &[SourceFile],
    config: &Config,
    coverage: ProjectCoverage,
    retain_function_blocks: bool,
    diagnostics: &mut Vec<RunDiagnostic>,
) -> AnalysisArtifacts {
    let capabilities = AnalysisCapabilities::from_config(config);
    let (parsed_sources, read_diagnostics) =
        crate::project::read_and_parse_sources_with_options(files, capabilities.parse_rust);
    diagnostics.extend(read_diagnostics);
    let mut blocks_by_file = BTreeMap::new();

    let mut findings = if capabilities.project_context {
        let project_context = build_project_context(project_root, &parsed_sources, coverage);
        diagnostics.extend(project_context.diagnostics.iter().cloned());
        analyse_project(&project_context, config, diagnostics)
    } else {
        Vec::new()
    };
    for parsed_source in &parsed_sources {
        let source_unit = parsed_source.as_source_unit();
        if retain_function_blocks {
            let source_artifacts =
                crate::analyse_source_with_artifacts(&source_unit, config, retain_function_blocks);
            if let Some(blocks) = source_artifacts.function_blocks {
                blocks_by_file.insert(parsed_source.file.display_path.clone(), blocks);
            }
            findings.extend(source_artifacts.findings);
        } else {
            findings.extend(crate::analyse_source(&source_unit, config));
        }
        diagnostics.extend(parsed_source.diagnostics.iter().cloned());
    }
    AnalysisArtifacts {
        findings,
        function_blocks_by_file: blocks_by_file,
    }
}

#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub(crate) struct AnalysisCapabilities {
    parse_rust: bool,
    project_context: bool,
}

impl AnalysisCapabilities {
    pub(crate) fn from_config(config: &Config) -> Self {
        let registry = rules::builtin_registry();
        let mut capabilities = Self {
            parse_rust: false,
            project_context: false,
        };

        for definition in registry.definitions() {
            if !config.is_rule_enabled(definition.id) {
                continue;
            }
            capabilities.include_builtin_rule(definition);
        }

        for rule in &config.custom_rules {
            if config.is_rule_enabled(&rule.id) {
                capabilities.include_custom_rule(rule);
            }
        }

        capabilities
    }

    fn include_builtin_rule(&mut self, definition: &rules::RuleDefinition) {
        match definition.kind {
            rules::RuleKind::Project => {
                self.project_context = true;
                self.parse_rust = true;
            }
            rules::RuleKind::Rust => {
                self.parse_rust = true;
            }
            rules::RuleKind::Text => {
                if text_rule_needs_rust_ast(definition.id) {
                    self.parse_rust = true;
                }
            }
        }
    }

    fn include_custom_rule(&mut self, rule: &CustomRule) {
        match rule.scope {
            CustomRuleScope::Text | CustomRuleScope::RustCode | CustomRuleScope::Comments => {}
        }
    }
}

fn text_rule_needs_rust_ast(rule_id: &str) -> bool {
    rule_id == "sensitive-data.hardcoded-env-value"
}

pub(crate) fn record_history_if_requested(
    project_root: &Path,
    options: &AnalysisOptions,
    config: &Config,
    report: &mut AnalysisReport,
) {
    if let Some(history_file) = &options.history_file {
        record_history(
            project_root,
            history_file,
            &report.findings,
            config,
            &mut report.diagnostics,
        );
    }
}

pub(crate) struct ReportInputs {
    pub(crate) discovery: DiscoveryResult,
    pub(crate) diagnostics: Vec<RunDiagnostic>,
    pub(crate) findings: Vec<Finding>,
    pub(crate) baseline_report: Option<BaselineReport>,
    pub(crate) suppressions: ReportSuppressions,
    pub(crate) per_rule_deltas: Option<Vec<RuleDelta>>,
    pub(crate) suppressed_count: Option<usize>,
    pub(crate) all_findings_summary: Option<Summary>,
    pub(crate) all_findings: Vec<Finding>,
}

pub(crate) fn build_report(
    project_root: &Path,
    options: &AnalysisOptions,
    config: &Config,
    inputs: ReportInputs,
) -> AnalysisReport {
    let ReportInputs {
        discovery,
        diagnostics,
        findings,
        baseline_report,
        suppressions,
        per_rule_deltas,
        suppressed_count,
        all_findings_summary,
        all_findings: _,
    } = inputs;
    let summary = summarize(&findings);
    let score = score_report(&findings, config);
    AnalysisReport {
        schema_version: "gruff.analysis.v2".to_string(),
        tool: ToolInfo {
            name: "gruff-rs".to_string(),
            version: VERSION.to_string(),
        },
        run: RunInfo {
            project_root: project_root.display().to_string(),
            format: options.format.as_str().to_string(),
            fail_on: options.fail_on.as_str().to_string(),
            generated_at: Utc::now().to_rfc3339(),
        },
        summary,
        paths: PathSummary {
            analysed_files: discovery.files.len(),
            ignored_paths: discovery.ignored_paths,
            ignored_path_details: discovery.ignored_path_details,
            missing_paths: discovery.missing_paths,
        },
        diagnostics,
        suppressions: suppressions.summaries,
        findings,
        suppressed_count,
        score,
        baseline: baseline_report,
        per_rule_deltas,
        suppressed_findings: suppressions.suppressed_findings,
        all_findings_summary,
    }
}