grin_chain 5.4.0

Chain implementation for grin, a simple, private and scalable cryptocurrency implementation based on the Mimblewimble chain format.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
// Copyright 2021 The Grin Developers
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

//! Manages the reconsitution of a txhashset from segments produced by the
//! segmenter

use std::sync::Arc;

use crate::core::core::hash::{Hash, Hashed};
use crate::core::core::{pmmr, pmmr::ReadablePMMR};
use crate::core::core::{
	BlockHeader, BlockSums, OutputIdentifier, Segment, SegmentIdentifier, SegmentType,
	SegmentTypeIdentifier, TxKernel,
};
use crate::error::Error;
use crate::txhashset::{BitmapAccumulator, BitmapChunk, TxHashSet};
use crate::types::{Tip, TxHashsetWriteStatus};
use crate::util::secp::pedersen::RangeProof;
use crate::util::{RwLock, StopState};
use crate::SyncState;

use crate::pibd_params;
use crate::store;
use crate::txhashset;

use croaring::Bitmap;

/// Desegmenter for rebuilding a txhashset from PIBD segments
#[derive(Clone)]
pub struct Desegmenter {
	txhashset: Arc<RwLock<TxHashSet>>,
	header_pmmr: Arc<RwLock<txhashset::PMMRHandle<BlockHeader>>>,
	archive_header: BlockHeader,
	store: Arc<store::ChainStore>,

	genesis: BlockHeader,

	default_bitmap_segment_height: u8,
	default_output_segment_height: u8,
	default_rangeproof_segment_height: u8,
	default_kernel_segment_height: u8,
	segment_apply_batch_size: usize,

	bitmap_accumulator: BitmapAccumulator,
	bitmap_segment_cache: Vec<Segment<BitmapChunk>>,
	output_segment_cache: Vec<Segment<OutputIdentifier>>,
	rangeproof_segment_cache: Vec<Segment<RangeProof>>,
	kernel_segment_cache: Vec<Segment<TxKernel>>,

	bitmap_mmr_leaf_count: u64,
	bitmap_mmr_size: u64,

	/// Maximum number of segments to cache before we stop requesting others
	max_cached_segments: usize,

	/// In-memory 'raw' bitmap corresponding to contents of bitmap accumulator
	bitmap_cache: Option<Bitmap>,

	/// Flag indicating there are no more segments to request
	all_segments_complete: bool,

	latest_block_height: u64,
}

impl Desegmenter {
	/// Create a new segmenter based on the provided txhashset and the specified block header
	pub fn new(
		txhashset: Arc<RwLock<TxHashSet>>,
		header_pmmr: Arc<RwLock<txhashset::PMMRHandle<BlockHeader>>>,
		archive_header: BlockHeader,
		genesis: BlockHeader,
		store: Arc<store::ChainStore>,
	) -> Desegmenter {
		trace!("Creating new desegmenter");
		let mut retval = Desegmenter {
			txhashset,
			header_pmmr,
			archive_header,
			store,
			genesis,
			bitmap_accumulator: BitmapAccumulator::new(),
			default_bitmap_segment_height: pibd_params::BITMAP_SEGMENT_HEIGHT,
			default_output_segment_height: pibd_params::OUTPUT_SEGMENT_HEIGHT,
			default_rangeproof_segment_height: pibd_params::RANGEPROOF_SEGMENT_HEIGHT,
			default_kernel_segment_height: pibd_params::KERNEL_SEGMENT_HEIGHT,
			segment_apply_batch_size: pibd_params::SEGMENT_APPLY_BATCH_SIZE,
			bitmap_segment_cache: vec![],
			output_segment_cache: vec![],
			rangeproof_segment_cache: vec![],
			kernel_segment_cache: vec![],

			bitmap_mmr_leaf_count: 0,
			bitmap_mmr_size: 0,

			max_cached_segments: pibd_params::MAX_CACHED_SEGMENTS,

			bitmap_cache: None,

			all_segments_complete: false,

			latest_block_height: 0,
		};
		retval.calc_bitmap_mmr_sizes();
		retval
	}

	/// Reset all state
	pub fn reset(&mut self) {
		self.all_segments_complete = false;
		self.bitmap_segment_cache = vec![];
		self.output_segment_cache = vec![];
		self.rangeproof_segment_cache = vec![];
		self.kernel_segment_cache = vec![];
		self.bitmap_mmr_leaf_count = 0;
		self.bitmap_mmr_size = 0;
		self.bitmap_cache = None;
		self.bitmap_accumulator = BitmapAccumulator::new();
		self.latest_block_height = 0;
		self.calc_bitmap_mmr_sizes();
	}

	/// Return reference to the header used for validation
	pub fn header(&self) -> &BlockHeader {
		&self.archive_header
	}

	/// Return size of bitmap mmr
	pub fn expected_bitmap_mmr_size(&self) -> u64 {
		self.bitmap_mmr_size
	}

	/// Whether we have all the segments we need
	pub fn is_complete(&self) -> bool {
		self.all_segments_complete
	}

	/// Check progress, update status if needed, returns true if all required
	/// segments are in place
	pub fn check_progress(&mut self, status: Arc<SyncState>) -> Result<bool, Error> {
		let local_output_mmr_size;
		let local_kernel_mmr_size;
		let local_rangeproof_mmr_size;
		{
			let txhashset = self.txhashset.read();
			local_output_mmr_size = txhashset.output_mmr_size();
			local_kernel_mmr_size = txhashset.kernel_mmr_size();
			local_rangeproof_mmr_size = txhashset.rangeproof_mmr_size();
		}

		// going to try presenting PIBD progress as total leaves downloaded
		// total segments probably doesn't make much sense since the segment
		// sizes will be able to change over time, and representative block height
		// can be too lopsided if one pmmr completes faster, so perhaps just
		// use total leaves downloaded and display as a percentage
		let completed_leaves = pmmr::n_leaves(local_output_mmr_size)
			+ pmmr::n_leaves(local_rangeproof_mmr_size)
			+ pmmr::n_leaves(local_kernel_mmr_size);

		// Find latest 'complete' header.
		// First take lesser of rangeproof and output mmr sizes
		let latest_output_size = std::cmp::min(local_output_mmr_size, local_rangeproof_mmr_size);

		// Find first header in which 'output_mmr_size' and 'kernel_mmr_size' are greater than
		// given sizes

		let res = {
			let header_pmmr = self.header_pmmr.read();
			header_pmmr.get_first_header_with(
				latest_output_size,
				local_kernel_mmr_size,
				self.latest_block_height,
				self.store.clone(),
			)
		};

		if let Some(h) = res {
			self.latest_block_height = h.height;

			// TODO: Unwraps
			let tip = Tip::from_header(&h);
			let batch = self.store.batch()?;
			batch.save_pibd_head(&tip)?;
			batch.commit()?;

			status.update_pibd_progress(
				false,
				false,
				completed_leaves,
				self.latest_block_height,
				&self.archive_header,
			);
			if local_kernel_mmr_size == self.archive_header.kernel_mmr_size
				&& local_output_mmr_size == self.archive_header.output_mmr_size
				&& local_rangeproof_mmr_size == self.archive_header.output_mmr_size
				&& self.bitmap_cache.is_some()
			{
				// All is complete
				return Ok(true);
			}
		}

		Ok(false)
	}

	/// Once the PIBD set is downloaded, we need to ensure that the respective leaf sets
	/// match the bitmap (particularly in the case of outputs being spent after a PIBD catch-up)
	pub fn check_update_leaf_set_state(&self) -> Result<(), Error> {
		let mut header_pmmr = self.header_pmmr.write();
		let mut txhashset = self.txhashset.write();
		let mut _batch = self.store.batch()?;
		txhashset::extending(&mut header_pmmr, &mut txhashset, &mut _batch, |ext, _| {
			let extension = &mut ext.extension;
			if let Some(b) = &self.bitmap_cache {
				extension.update_leaf_sets(&b)?;
			}
			Ok(())
		})?;
		Ok(())
	}

	/// This is largely copied from chain.rs txhashset_write and related functions,
	/// the idea being that the txhashset version will eventually be removed
	pub fn validate_complete_state(
		&self,
		status: Arc<SyncState>,
		stop_state: Arc<StopState>,
	) -> Result<(), Error> {
		// Quick root check first:
		{
			let txhashset = self.txhashset.read();
			txhashset.roots()?.validate(&self.archive_header)?;
		}

		// TODO: Possibly Keep track of this in the DB so we can pick up where we left off if needed
		let last_rangeproof_validation_pos = 0;

		// Validate kernel history
		{
			debug!("desegmenter validation: rewinding and validating kernel history (readonly)");
			let txhashset = self.txhashset.read();
			let mut count = 0;
			let mut current = self.archive_header.clone();
			let total = current.height;
			txhashset::rewindable_kernel_view(&txhashset, |view, batch| {
				while current.height > 0 {
					view.rewind(&current)?;
					view.validate_root()?;
					current = batch.get_previous_header(&current)?;
					count += 1;
					if current.height % 100000 == 0 || current.height == total {
						status.on_setup(Some(total - current.height), Some(total), None, None);
					}
					if stop_state.is_stopped() {
						return Ok(());
					}
				}
				Ok(())
			})?;
			debug!(
				"desegmenter validation: validated kernel root on {} headers",
				count,
			);
		}

		if stop_state.is_stopped() {
			return Ok(());
		}

		// Check kernel MMR root for every block header.
		// Check NRD relative height rules for full kernel history.

		{
			let header_pmmr = self.header_pmmr.read();
			let txhashset = self.txhashset.read();
			let batch = self.store.batch()?;
			txhashset.verify_kernel_pos_index(
				&self.genesis,
				&header_pmmr,
				&batch,
				Some(status.clone()),
				Some(stop_state.clone()),
			)?;
		}

		if stop_state.is_stopped() {
			return Ok(());
		}

		status.on_setup(None, None, None, None);
		// Prepare a new batch and update all the required records
		{
			debug!("desegmenter validation: rewinding a 2nd time (writeable)");
			let mut header_pmmr = self.header_pmmr.write();
			let mut txhashset = self.txhashset.write();
			let mut batch = self.store.batch()?;
			txhashset::extending(
				&mut header_pmmr,
				&mut txhashset,
				&mut batch,
				|ext, batch| {
					let extension = &mut ext.extension;
					extension.rewind(&self.archive_header, batch)?;

					// Validate the extension, generating the utxo_sum and kernel_sum.
					// Full validation, including rangeproofs and kernel signature verification.
					let (utxo_sum, kernel_sum) = extension.validate(
						&self.genesis,
						false,
						&*status,
						Some(last_rangeproof_validation_pos),
						None,
						&self.archive_header,
						Some(stop_state.clone()),
					)?;

					if stop_state.is_stopped() {
						return Ok(());
					}

					// Save the block_sums (utxo_sum, kernel_sum) to the db for use later.
					batch.save_block_sums(
						&self.archive_header.hash(),
						BlockSums {
							utxo_sum,
							kernel_sum,
						},
					)?;

					Ok(())
				},
			)?;

			if stop_state.is_stopped() {
				return Ok(());
			}

			debug!("desegmenter_validation: finished validating and rebuilding");
			status.on_save();

			{
				// Save the new head to the db and rebuild the header by height index.
				let tip = Tip::from_header(&self.archive_header);

				batch.save_body_head(&tip)?;

				// Reset the body tail to the body head after a txhashset write
				batch.save_body_tail(&tip)?;
			}

			// Rebuild our output_pos index in the db based on fresh UTXO set.
			txhashset.init_output_pos_index(&header_pmmr, &batch)?;

			// Rebuild our NRD kernel_pos index based on recent kernel history.
			txhashset.init_recent_kernel_pos_index(&header_pmmr, &batch)?;

			// Commit all the changes to the db.
			batch.commit()?;

			debug!("desegmenter_validation: finished committing the batch (head etc.)");

			status.on_done();
		}
		Ok(())
	}

	/// Apply next set of segments that are ready to be appended to their respective trees,
	/// and kick off any validations that can happen.
	pub fn apply_next_segments(&mut self) -> Result<(), Error> {
		let next_bmp_idx = self.next_required_bitmap_segment_index();
		if let Some(bmp_idx) = next_bmp_idx {
			if let Some((idx, _seg)) = self
				.bitmap_segment_cache
				.iter()
				.enumerate()
				.find(|s| s.1.identifier().idx == bmp_idx)
			{
				self.apply_bitmap_segment(idx)?;
			} else {
				debug!(
					"desegmenter: waiting for bitmap segment idx {} (cache size {})",
					bmp_idx,
					self.bitmap_segment_cache.len()
				);
			}
		} else {
			// Check if we need to finalize bitmap
			if self.bitmap_cache == None {
				// Should have all the pieces now, finalize the bitmap cache
				self.finalize_bitmap()?;
			}

			// Check if we can apply the next output segment(s)
			if let Some(next_output_idx) = self.next_required_output_segment_index() {
				let segments = Self::take_segment_batch(
					&mut self.output_segment_cache,
					next_output_idx,
					self.segment_apply_batch_size,
				);
				if segments.is_empty() {
					debug!(
						"desegmenter: waiting for output segment idx {} (cache size {})",
						next_output_idx,
						self.output_segment_cache.len()
					);
				} else {
					self.apply_output_segments(segments)?;
				}
			} else if self.output_segment_cache.len() >= self.max_cached_segments {
				debug!(
					"desegmenter: dropping {} cached output segments waiting for next requirement",
					self.output_segment_cache.len()
				);
				self.output_segment_cache = vec![];
			}
			// Check if we can apply the next rangeproof segment
			if let Some(next_rp_idx) = self.next_required_rangeproof_segment_index() {
				let segments = Self::take_segment_batch(
					&mut self.rangeproof_segment_cache,
					next_rp_idx,
					self.segment_apply_batch_size,
				);
				if segments.is_empty() {
					debug!(
						"desegmenter: waiting for rangeproof segment idx {} (cache size {})",
						next_rp_idx,
						self.rangeproof_segment_cache.len()
					);
				} else {
					self.apply_rangeproof_segments(segments)?;
				}
			} else if self.rangeproof_segment_cache.len() >= self.max_cached_segments {
				debug!(
					"desegmenter: dropping {} cached rangeproof segments waiting for next requirement",
					self.rangeproof_segment_cache.len()
				);
				self.rangeproof_segment_cache = vec![];
			}
			// Check if we can apply the next kernel segment
			if let Some(next_kernel_idx) = self.next_required_kernel_segment_index() {
				let segments = Self::take_segment_batch(
					&mut self.kernel_segment_cache,
					next_kernel_idx,
					self.segment_apply_batch_size,
				);
				if segments.is_empty() {
					debug!(
						"desegmenter: waiting for kernel segment idx {} (cache size {})",
						next_kernel_idx,
						self.kernel_segment_cache.len()
					);
				} else {
					self.apply_kernel_segments(segments)?;
				}
			} else if self.kernel_segment_cache.len() >= self.max_cached_segments {
				debug!(
					"desegmenter: dropping {} cached kernel segments waiting for next requirement",
					self.kernel_segment_cache.len()
				);
				self.kernel_segment_cache = vec![];
			}
		}
		Ok(())
	}

	/// Return list of the next preferred segments the desegmenter needs based on
	/// the current real state of the underlying elements
	pub fn next_desired_segments(&mut self, max_elements: usize) -> Vec<SegmentTypeIdentifier> {
		let mut return_vec = vec![];
		// First check for required bitmap elements
		if self.bitmap_cache.is_none() {
			// Get current size of bitmap MMR
			let local_pmmr_size = self.bitmap_accumulator.readonly_pmmr().unpruned_size();
			// Get iterator over expected bitmap elements
			let mut identifier_iter = SegmentIdentifier::traversal_iter(
				self.bitmap_mmr_size,
				self.default_bitmap_segment_height,
			);
			// Advance iterator to next expected segment
			while let Some(id) = identifier_iter.next() {
				if id.segment_pos_range(self.bitmap_mmr_size).1 > local_pmmr_size {
					if !self.has_bitmap_segment_with_id(id) {
						return_vec.push(SegmentTypeIdentifier::new(SegmentType::Bitmap, id));
						if return_vec.len() >= max_elements {
							return return_vec;
						}
					}
				}
			}
		} else {
			// We have all required bitmap segments and have recreated our local
			// bitmap, now continue with other segments, evenly spreading requests
			// among MMRs
			let local_output_mmr_size;
			let local_kernel_mmr_size;
			let local_rangeproof_mmr_size;
			{
				let txhashset = self.txhashset.read();
				local_output_mmr_size = txhashset.output_mmr_size();
				local_kernel_mmr_size = txhashset.kernel_mmr_size();
				local_rangeproof_mmr_size = txhashset.rangeproof_mmr_size();
			}
			let total_output_segments = SegmentIdentifier::count_segments_required(
				self.archive_header.output_mmr_size,
				self.default_output_segment_height,
			);
			let mut elems_added = 0;
			if let Some(mut next_output_idx) = self.next_required_output_segment_index() {
				while (next_output_idx as usize) < total_output_segments {
					if self.output_segment_cache.len() >= self.max_cached_segments {
						break;
					}
					if elems_added == max_elements / 3 {
						break;
					}
					let output_id = SegmentIdentifier {
						height: self.default_output_segment_height,
						idx: next_output_idx,
					};
					let (_first, last) =
						output_id.segment_pos_range(self.archive_header.output_mmr_size);
					if last > local_output_mmr_size && !self.has_output_segment_with_id(output_id) {
						return_vec.push(SegmentTypeIdentifier::new(SegmentType::Output, output_id));
						elems_added += 1;
					}
					next_output_idx += 1;
				}
			}

			let total_rangeproof_segments = SegmentIdentifier::count_segments_required(
				self.archive_header.output_mmr_size,
				self.default_rangeproof_segment_height,
			);
			elems_added = 0;
			if let Some(mut next_rp_idx) = self.next_required_rangeproof_segment_index() {
				while (next_rp_idx as usize) < total_rangeproof_segments {
					if self.rangeproof_segment_cache.len() >= self.max_cached_segments {
						break;
					}
					if elems_added == max_elements / 3 {
						break;
					}
					let rp_id = SegmentIdentifier {
						height: self.default_rangeproof_segment_height,
						idx: next_rp_idx,
					};
					let (_first, last) =
						rp_id.segment_pos_range(self.archive_header.output_mmr_size);
					if last > local_rangeproof_mmr_size
						&& !self.has_rangeproof_segment_with_id(rp_id)
					{
						return_vec.push(SegmentTypeIdentifier::new(SegmentType::RangeProof, rp_id));
						elems_added += 1;
					}
					next_rp_idx += 1;
				}
			}

			let total_kernel_segments = SegmentIdentifier::count_segments_required(
				self.archive_header.kernel_mmr_size,
				self.default_kernel_segment_height,
			);
			elems_added = 0;
			if let Some(mut next_kernel_idx) = self.next_required_kernel_segment_index() {
				while (next_kernel_idx as usize) < total_kernel_segments {
					if self.kernel_segment_cache.len() >= self.max_cached_segments {
						break;
					}
					if elems_added == max_elements / 3 {
						break;
					}
					let k_id = SegmentIdentifier {
						height: self.default_kernel_segment_height,
						idx: next_kernel_idx,
					};
					let (_first, last) =
						k_id.segment_pos_range(self.archive_header.kernel_mmr_size);
					if last > local_kernel_mmr_size && !self.has_kernel_segment_with_id(k_id) {
						return_vec.push(SegmentTypeIdentifier::new(SegmentType::Kernel, k_id));
						elems_added += 1;
					}
					next_kernel_idx += 1;
				}
			}
		}
		// Always ensure we explicitly ask for the very next kernel segment we are waiting on.
		// The regular round-robin above can get saturated with outputs and rangeproofs while
		// the desegmenter is blocked on a missing kernel, so we force this one in.
		if let Some(next_kernel_idx) = self.next_required_kernel_segment_index() {
			let seg_id = SegmentIdentifier {
				height: self.default_kernel_segment_height,
				idx: next_kernel_idx,
			};
			let next_kernel_seg_id = SegmentTypeIdentifier::new(SegmentType::Kernel, seg_id);
			if !self.has_kernel_segment_with_id(seg_id)
				&& !return_vec.iter().any(|x| x == &next_kernel_seg_id)
			{
				if return_vec.len() >= max_elements {
					return_vec.pop();
				}
				return_vec.push(next_kernel_seg_id);
			}
		}
		if return_vec.is_empty() && self.bitmap_cache.is_some() {
			self.all_segments_complete = true;
		}
		return_vec
	}

	/// 'Finalize' the bitmap accumulator, storing an in-memory copy of the bitmap for
	/// use in further validation and setting the accumulator on the underlying txhashset
	pub fn finalize_bitmap(&mut self) -> Result<(), Error> {
		trace!(
			"pibd_desegmenter: finalizing and caching bitmap - accumulator root: {}",
			self.bitmap_accumulator.root()
		);
		self.bitmap_cache = Some(self.bitmap_accumulator.as_bitmap()?);

		// Set the txhashset's bitmap accumulator
		let mut header_pmmr = self.header_pmmr.write();
		let mut txhashset = self.txhashset.write();
		let mut batch = self.store.batch()?;
		txhashset::extending(
			&mut header_pmmr,
			&mut txhashset,
			&mut batch,
			|ext, _batch| {
				let extension = &mut ext.extension;
				extension.set_bitmap_accumulator(self.bitmap_accumulator.clone());
				Ok(())
			},
		)?;
		Ok(())
	}

	// Calculate and store number of leaves and positions in the bitmap mmr given the number of
	// outputs specified in the header. Should be called whenever the header changes
	fn calc_bitmap_mmr_sizes(&mut self) {
		// Number of leaves (BitmapChunks)
		self.bitmap_mmr_leaf_count =
			(pmmr::n_leaves(self.archive_header.output_mmr_size) + 1023) / 1024;
		trace!(
			"pibd_desegmenter - expected number of leaves in bitmap MMR: {}",
			self.bitmap_mmr_leaf_count
		);
		// Total size of Bitmap PMMR
		self.bitmap_mmr_size =
			1 + pmmr::peaks(pmmr::insertion_to_pmmr_index(self.bitmap_mmr_leaf_count))
				.last()
				.unwrap_or(
					&(pmmr::peaks(pmmr::insertion_to_pmmr_index(
						self.bitmap_mmr_leaf_count - 1,
					))
					.last()
					.unwrap()),
				)
				.clone();

		trace!(
			"pibd_desegmenter - expected size of bitmap MMR: {}",
			self.bitmap_mmr_size
		);
	}

	/// Cache a bitmap segment if we don't already have it
	fn cache_bitmap_segment(&mut self, in_seg: Segment<BitmapChunk>) {
		if self
			.bitmap_segment_cache
			.iter()
			.find(|i| i.identifier() == in_seg.identifier())
			.is_none()
		{
			self.bitmap_segment_cache.push(in_seg);
		}
	}

	/// Whether our list already contains this bitmap segment
	fn has_bitmap_segment_with_id(&self, seg_id: SegmentIdentifier) -> bool {
		self.bitmap_segment_cache
			.iter()
			.find(|i| i.identifier() == seg_id)
			.is_some()
	}

	/// Return an identifier for the next segment we need for the bitmap pmmr
	fn next_required_bitmap_segment_index(&self) -> Option<u64> {
		let local_bitmap_pmmr_size = self.bitmap_accumulator.readonly_pmmr().unpruned_size();
		let cur_segment_count = SegmentIdentifier::count_segments_required(
			local_bitmap_pmmr_size,
			self.default_bitmap_segment_height,
		);
		let total_segment_count = SegmentIdentifier::count_segments_required(
			self.bitmap_mmr_size,
			self.default_bitmap_segment_height,
		);
		if cur_segment_count == total_segment_count {
			None
		} else {
			Some(cur_segment_count as u64)
		}
	}

	/// Adds and validates a bitmap chunk
	pub fn add_bitmap_segment(
		&mut self,
		segment: Segment<BitmapChunk>,
		output_root_hash: Hash,
	) -> Result<(), Error> {
		trace!("pibd_desegmenter: add bitmap segment");
		segment.validate_with(
			self.bitmap_mmr_size, // Last MMR pos at the height being validated, in this case of the bitmap root
			None,
			self.archive_header.output_root, // Output root we're checking for
			self.archive_header.output_mmr_size,
			output_root_hash, // Other root
			true,
		)?;
		trace!("pibd_desegmenter: adding segment to cache");
		// All okay, add to our cached list of bitmap segments
		self.cache_bitmap_segment(segment);
		Ok(())
	}

	/// Apply a bitmap segment at the index cache
	pub fn apply_bitmap_segment(&mut self, idx: usize) -> Result<(), Error> {
		let segment = self.bitmap_segment_cache.remove(idx);
		trace!(
			"pibd_desegmenter: apply bitmap segment at segment idx {}",
			segment.identifier().idx
		);
		// Add leaves to bitmap accumulator
		let (_sid, _hash_pos, _hashes, _leaf_pos, leaf_data, _proof) = segment.parts();
		for chunk in leaf_data.into_iter() {
			self.bitmap_accumulator.append_chunk(chunk)?;
		}
		Ok(())
	}

	/// Whether our list already contains this bitmap segment
	fn has_output_segment_with_id(&self, seg_id: SegmentIdentifier) -> bool {
		self.output_segment_cache
			.iter()
			.find(|i| i.identifier() == seg_id)
			.is_some()
	}

	/// Cache an output segment if we don't already have it
	fn cache_output_segment(&mut self, in_seg: Segment<OutputIdentifier>) {
		if self
			.output_segment_cache
			.iter()
			.find(|i| i.identifier() == in_seg.identifier())
			.is_none()
		{
			self.output_segment_cache.push(in_seg);
		}
	}

	fn take_segment_batch<T>(
		cache: &mut Vec<Segment<T>>,
		start_idx: u64,
		max_segments: usize,
	) -> Vec<Segment<T>> {
		let mut result = Vec::new();
		let mut next_idx = start_idx;
		while result.len() < max_segments {
			if let Some(pos) = cache.iter().position(|s| s.identifier().idx == next_idx) {
				result.push(cache.remove(pos));
				next_idx += 1;
			} else {
				break;
			}
		}
		result
	}

	/// Apply a batch of output segments
	pub fn apply_output_segments(
		&mut self,
		segments: Vec<Segment<OutputIdentifier>>,
	) -> Result<(), Error> {
		if segments.is_empty() {
			return Ok(());
		}
		trace!(
			"pibd_desegmenter: applying {} output segment(s) starting at idx {}",
			segments.len(),
			segments.first().map(|s| s.identifier().idx).unwrap_or(0)
		);
		let mut header_pmmr = self.header_pmmr.write();
		let mut txhashset = self.txhashset.write();
		let mut batch = self.store.batch()?;
		txhashset::extending(
			&mut header_pmmr,
			&mut txhashset,
			&mut batch,
			|ext, _batch| {
				let extension = &mut ext.extension;
				for segment in segments {
					extension.apply_output_segment(segment)?;
				}
				Ok(())
			},
		)?;
		Ok(())
	}

	/// Return an identifier for the next segment we need for the output pmmr
	fn next_required_output_segment_index(&self) -> Option<u64> {
		let local_output_mmr_size;
		{
			let txhashset = self.txhashset.read();
			local_output_mmr_size = txhashset.output_mmr_size();
		}

		// Special case here. If the mmr size is 1, this is a fresh chain
		// with naught but a humble genesis block. We need segment 0, (and
		// also need to skip the genesis block when applying the segment)
		// note this is implementation-specific, the code for creating
		// a new chain creates the genesis block pmmr entries by default

		let mut cur_segment_count = if local_output_mmr_size == 1 {
			0
		} else {
			SegmentIdentifier::count_segments_required(
				local_output_mmr_size,
				self.default_output_segment_height,
			)
		};

		// When resuming, we need to ensure we're getting the previous segment if needed
		let theoretical_pmmr_size =
			SegmentIdentifier::pmmr_size(cur_segment_count, self.default_output_segment_height);
		if local_output_mmr_size < theoretical_pmmr_size {
			cur_segment_count -= 1;
		}

		let total_segment_count = SegmentIdentifier::count_segments_required(
			self.archive_header.output_mmr_size,
			self.default_output_segment_height,
		);
		trace!(
			"Next required output segment is {} of {}",
			cur_segment_count,
			total_segment_count
		);
		if cur_segment_count == total_segment_count {
			None
		} else {
			Some(cur_segment_count as u64)
		}
	}

	/// Adds a output segment
	pub fn add_output_segment(
		&mut self,
		segment: Segment<OutputIdentifier>,
		_bitmap_root: Option<Hash>,
	) -> Result<(), Error> {
		trace!("pibd_desegmenter: add output segment");
		// TODO: This, something very wrong, probably need to reset entire body sync
		// check bitmap root matches what we already have
		/*if bitmap_root != Some(self.bitmap_accumulator.root()) {

		}*/
		segment.validate_with(
			self.archive_header.output_mmr_size, // Last MMR pos at the height being validated
			self.bitmap_cache.as_ref(),
			self.archive_header.output_root, // Output root we're checking for
			self.archive_header.output_mmr_size,
			self.bitmap_accumulator.root(), // Other root
			false,
		)?;
		self.cache_output_segment(segment);
		Ok(())
	}

	/// Whether our list already contains this rangeproof segment
	fn has_rangeproof_segment_with_id(&self, seg_id: SegmentIdentifier) -> bool {
		self.rangeproof_segment_cache
			.iter()
			.find(|i| i.identifier() == seg_id)
			.is_some()
	}

	/// Cache a RangeProof segment if we don't already have it
	fn cache_rangeproof_segment(&mut self, in_seg: Segment<RangeProof>) {
		if self
			.rangeproof_segment_cache
			.iter()
			.find(|i| i.identifier() == in_seg.identifier())
			.is_none()
		{
			self.rangeproof_segment_cache.push(in_seg);
		}
	}

	/// Apply a batch of rangeproof segments
	pub fn apply_rangeproof_segments(
		&mut self,
		segments: Vec<Segment<RangeProof>>,
	) -> Result<(), Error> {
		if segments.is_empty() {
			return Ok(());
		}
		trace!(
			"pibd_desegmenter: applying {} rangeproof segment(s) starting at idx {}",
			segments.len(),
			segments.first().map(|s| s.identifier().idx).unwrap_or(0)
		);
		let mut header_pmmr = self.header_pmmr.write();
		let mut txhashset = self.txhashset.write();
		let mut batch = self.store.batch()?;
		txhashset::extending(
			&mut header_pmmr,
			&mut txhashset,
			&mut batch,
			|ext, _batch| {
				let extension = &mut ext.extension;
				for segment in segments {
					extension.apply_rangeproof_segment(segment)?;
				}
				Ok(())
			},
		)?;
		Ok(())
	}

	/// Return an identifier for the next segment we need for the rangeproof pmmr
	fn next_required_rangeproof_segment_index(&self) -> Option<u64> {
		let local_rangeproof_mmr_size;
		{
			let txhashset = self.txhashset.read();
			local_rangeproof_mmr_size = txhashset.rangeproof_mmr_size();
		}

		// Special case here. If the mmr size is 1, this is a fresh chain
		// with naught but a humble genesis block. We need segment 0, (and
		// also need to skip the genesis block when applying the segment)

		let mut cur_segment_count = if local_rangeproof_mmr_size == 1 {
			0
		} else {
			SegmentIdentifier::count_segments_required(
				local_rangeproof_mmr_size,
				self.default_rangeproof_segment_height,
			)
		};

		// When resuming, we need to ensure we're getting the previous segment if needed
		let theoretical_pmmr_size =
			SegmentIdentifier::pmmr_size(cur_segment_count, self.default_rangeproof_segment_height);
		if local_rangeproof_mmr_size < theoretical_pmmr_size {
			cur_segment_count -= 1;
		}

		let total_segment_count = SegmentIdentifier::count_segments_required(
			self.archive_header.output_mmr_size,
			self.default_rangeproof_segment_height,
		);
		trace!(
			"Next required rangeproof segment is {} of {}",
			cur_segment_count,
			total_segment_count
		);
		if cur_segment_count == total_segment_count {
			None
		} else {
			Some(cur_segment_count as u64)
		}
	}

	/// Adds a Rangeproof segment
	pub fn add_rangeproof_segment(&mut self, segment: Segment<RangeProof>) -> Result<(), Error> {
		trace!("pibd_desegmenter: add rangeproof segment");
		segment.validate(
			self.archive_header.output_mmr_size, // Last MMR pos at the height being validated
			self.bitmap_cache.as_ref(),
			self.archive_header.range_proof_root, // Range proof root we're checking for
		)?;
		self.cache_rangeproof_segment(segment);
		Ok(())
	}

	/// Whether our list already contains this kernel segment
	fn has_kernel_segment_with_id(&self, seg_id: SegmentIdentifier) -> bool {
		self.kernel_segment_cache
			.iter()
			.find(|i| i.identifier() == seg_id)
			.is_some()
	}

	/// Cache a Kernel segment if we don't already have it
	fn cache_kernel_segment(&mut self, in_seg: Segment<TxKernel>) {
		if self
			.kernel_segment_cache
			.iter()
			.find(|i| i.identifier() == in_seg.identifier())
			.is_none()
		{
			self.kernel_segment_cache.push(in_seg);
		}
	}

	/// Apply a batch of kernel segments at the index cache
	pub fn apply_kernel_segments(&mut self, segments: Vec<Segment<TxKernel>>) -> Result<(), Error> {
		if segments.is_empty() {
			return Ok(());
		}
		let first_idx = segments.first().map(|s| s.identifier().idx).unwrap_or(0);
		debug!(
			"pibd_desegmenter: applying {} kernel segment(s) starting at idx {}",
			segments.len(),
			first_idx
		);
		let mut header_pmmr = self.header_pmmr.write();
		let mut txhashset = self.txhashset.write();
		let mut batch = self.store.batch()?;
		txhashset::extending(
			&mut header_pmmr,
			&mut txhashset,
			&mut batch,
			|ext, _batch| {
				let extension = &mut ext.extension;
				for segment in segments {
					let seg_idx = segment.identifier().idx;
					if let Err(e) = extension.apply_kernel_segment(segment) {
						error!(
							"pibd_desegmenter: failed to apply kernel segment idx {}: {}",
							seg_idx, e
						);
						return Err(e);
					}
					debug!(
						"pibd_desegmenter: successfully applied kernel segment idx {}",
						seg_idx
					);
				}
				Ok(())
			},
		)?;
		Ok(())
	}

	/// Return an identifier for the next segment we need for the kernel pmmr
	fn next_required_kernel_segment_index(&self) -> Option<u64> {
		let local_kernel_mmr_size;
		{
			let txhashset = self.txhashset.read();
			local_kernel_mmr_size = txhashset.kernel_mmr_size();
		}

		let mut cur_segment_count = if local_kernel_mmr_size == 1 {
			0
		} else {
			SegmentIdentifier::count_segments_required(
				local_kernel_mmr_size,
				self.default_kernel_segment_height,
			)
		};

		// When resuming, we need to ensure we're getting the previous segment if needed
		let theoretical_pmmr_size =
			SegmentIdentifier::pmmr_size(cur_segment_count, self.default_kernel_segment_height);
		if local_kernel_mmr_size < theoretical_pmmr_size {
			cur_segment_count -= 1;
		}

		let total_segment_count = SegmentIdentifier::count_segments_required(
			self.archive_header.kernel_mmr_size,
			self.default_kernel_segment_height,
		);
		trace!(
			"Next required kernel segment is {} of {}",
			cur_segment_count,
			total_segment_count
		);
		if cur_segment_count == total_segment_count {
			None
		} else {
			Some(cur_segment_count as u64)
		}
	}

	/// Adds a Kernel segment
	pub fn add_kernel_segment(&mut self, segment: Segment<TxKernel>) -> Result<(), Error> {
		let idx = segment.identifier().idx;
		debug!(
			"pibd_desegmenter: received kernel segment idx {} (cache size {})",
			idx,
			self.kernel_segment_cache.len()
		);
		segment
			.validate(
				self.archive_header.kernel_mmr_size, // Last MMR pos at the height being validated
				None,
				self.archive_header.kernel_root, // Kernel root we're checking for
			)
			.map_err(|e| {
				error!(
					"pibd_desegmenter: kernel segment idx {} failed validation: {}",
					idx, e
				);
				e
			})?;
		self.cache_kernel_segment(segment);
		debug!(
			"pibd_desegmenter: cached kernel segment idx {} (cache size {})",
			idx,
			self.kernel_segment_cache.len()
		);
		Ok(())
	}
}