greentic-bundle 1.1.0

Greentic bundle authoring CLI scaffold with embedded i18n and answer-document contracts.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
use std::fs;
use std::path::Path;

use ed25519_dalek::SigningKey;
use ed25519_dalek::pkcs8::spki::der::pem::LineEnding;
use ed25519_dalek::pkcs8::{EncodePrivateKey, EncodePublicKey};
use greentic_bundle::build::signing::SigningConfig;
use greentic_distributor_client::signing::{
    TrustRoot, TrustedKey, key_id_for_public_key_pem, verify_artifact_dsse,
};
use serde_json::Value;
use sha2::{Digest, Sha256};
use tempfile::TempDir;

fn seed_workspace(root: &Path) {
    fs::create_dir_all(root.join("resolved")).expect("resolved dir");
    fs::create_dir_all(root.join("state/setup")).expect("setup dir");
    fs::create_dir_all(root.join("tenants/default")).expect("tenant dir");
    fs::create_dir_all(root.join("packs")).expect("packs dir");
    fs::create_dir_all(root.join("providers/messaging")).expect("provider dir");
    fs::write(
        root.join("bundle.yaml"),
        "\
schema_version: 1
bundle_id: demo-bundle
bundle_name: Demo Bundle
locale: en
mode: create
advanced_setup: true
app_packs:
  - pack-a
extension_providers:
  - provider-a
remote_catalogs:
  - file://catalog.json
hooks:
  - hook-a
subscriptions:
  - subscription-a
capabilities:
  - capability-a
setup_execution_intent: true
export_intent: false
",
    )
    .expect("bundle yaml");
    fs::write(root.join("tenants/default/tenant.gmap"), "_ = forbidden\n").expect("tenant gmap");
    fs::write(
        root.join("resolved/default.yaml"),
        "\
version: 1
tenant: default
project_root: /tmp/demo
bundle:
  bundle_id: demo-bundle
  bundle_name: Demo Bundle
  locale: en
  mode: create
  advanced_setup: true
  setup_execution_intent: true
  export_intent: false
policy:
  source:
    tenant_gmap: tenants/default/tenant.gmap
  default: forbidden
catalogs:
  - file://catalog.json
app_packs:
  - reference: pack-a
    policy: forbidden
extension_providers:
  - provider-a
hooks:
  - hook-a
subscriptions:
  - subscription-a
capabilities:
  - capability-a
",
    )
    .expect("resolved");
    fs::write(root.join("packs/pack-a.gtpack"), "pack-a-bytes").expect("pack file");
    fs::write(
        root.join("providers/messaging/provider-a.gtpack"),
        "provider-a-bytes",
    )
    .expect("provider file");
    fs::write(
        root.join("state/setup/provider-a.json"),
        r#"{"schema_version":1,"provider_id":"provider-a","source_kind":"legacy","form":{"id":"provider-a-setup","title":"Provider A Setup","version":"1.0.0","description":"Provider A provider configuration","questions":[]},"normalized_answers":{},"non_secret_config":{},"secret_values":{}}"#,
    )
    .expect("setup state");
    let lock = greentic_bundle::project::BundleLock {
        schema_version: greentic_bundle::project::LOCK_SCHEMA_VERSION,
        bundle_id: "demo-bundle".to_string(),
        env_id: None,
        requested_mode: "create".to_string(),
        execution: "execute".to_string(),
        cache_policy: "workspace-local".to_string(),
        tool_version: env!("CARGO_PKG_VERSION").to_string(),
        build_format_version: "bundle-lock-v1".to_string(),
        workspace_root: "bundle.yaml".to_string(),
        lock_file: "bundle.lock.json".to_string(),
        catalogs: vec![greentic_bundle::catalog::resolve::CatalogLockEntry {
            requested_ref: "file://catalog.json".to_string(),
            resolved_ref: "catalog.json".to_string(),
            digest: "sha256:abc".to_string(),
            source: "local_file".to_string(),
            item_count: 1,
            item_ids: vec!["provider-a".to_string()],
            cache_path: None,
        }],
        app_packs: vec![greentic_bundle::project::DependencyLock {
            reference: "pack-a".to_string(),
            digest: None,
        }],
        extension_providers: vec![greentic_bundle::project::DependencyLock {
            reference: "provider-a".to_string(),
            digest: None,
        }],
        setup_state_files: vec!["state/setup/provider-a.json".to_string()],
    };
    greentic_bundle::project::write_bundle_lock(root, &lock).expect("write lock");
}

#[test]
fn build_produces_byte_stable_artifact() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let artifact_one = root.join("one.gtbundle");
    let artifact_two = root.join("two.gtbundle");
    greentic_bundle::build::build_workspace(&root, Some(&artifact_one), false, false, None)
        .expect("build one");
    greentic_bundle::build::build_workspace(&root, Some(&artifact_two), false, false, None)
        .expect("build two");

    assert_eq!(
        fs::read(&artifact_one).expect("artifact one"),
        fs::read(&artifact_two).expect("artifact two")
    );
}

#[test]
fn inspect_output_is_stable() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let report_one = serde_json::to_string_pretty(
        &greentic_bundle::build::inspect_target(Some(&root), None).expect("inspect one"),
    )
    .expect("serialize one");
    let report_two = serde_json::to_string_pretty(
        &greentic_bundle::build::inspect_target(Some(&root), None).expect("inspect two"),
    )
    .expect("serialize two");
    assert_eq!(report_one, report_two);
}

#[test]
fn build_normalized_dir_includes_materialized_pack_and_provider_files() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let build_dir = root.join("state/build/demo-bundle/normalized");
    greentic_bundle::build::build_workspace(&root, None, false, false, None)
        .expect("build workspace");

    assert_eq!(
        fs::read(build_dir.join("packs/pack-a.gtpack")).expect("built pack"),
        b"pack-a-bytes"
    );
    assert_eq!(
        fs::read(build_dir.join("providers/messaging/provider-a.gtpack")).expect("built provider"),
        b"provider-a-bytes"
    );
}

// Setup wizard writes provider configuration to `.providers/<id>/` (envelope
// CBOR plus contract cache), workspace overrides to `assets/`, and tenant
// allow rules to `tenants/<t>/tenant.gmap`. Build must materialize these into
// the bundle so the runtime can resolve provider configs (skin, nav_links,
// jwt_signing_key) and serve per-tenant client config without depending on
// rebuilt setup state on the target host. Without this, `gtc start
// --target=aws --upload-bundle <dir>` produces an artifact that drops the
// wizard answers and the deployed runtime renders the default skin and fails
// JWT verification.
#[test]
fn build_normalized_dir_preserves_workspace_provider_config_and_assets() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    // Setup wizard outputs that today get silently dropped by the build.
    fs::create_dir_all(root.join(".providers/messaging-webchat-gui")).expect("dot-providers dir");
    fs::write(
        root.join(".providers/messaging-webchat-gui/config.envelope.cbor"),
        b"envelope-cbor-bytes",
    )
    .expect("envelope file");
    fs::create_dir_all(root.join(".providers/_contracts")).expect("contracts dir");
    fs::write(
        root.join(".providers/_contracts/abc123.contract.cbor"),
        b"contract-cbor-bytes",
    )
    .expect("contract file");
    fs::create_dir_all(root.join("assets/webchat-gui/config/tenants")).expect("assets dir");
    fs::write(
        root.join("assets/webchat-gui/config/tenants/demo.json"),
        br#"{"tenant_id":"demo","skin":"3aigent"}"#,
    )
    .expect("tenant overlay");

    let build_dir = root.join("state/build/demo-bundle/normalized");
    greentic_bundle::build::build_workspace(&root, None, false, false, None)
        .expect("build workspace");

    assert_eq!(
        fs::read(build_dir.join(".providers/messaging-webchat-gui/config.envelope.cbor"))
            .expect("envelope materialized"),
        b"envelope-cbor-bytes",
    );
    assert_eq!(
        fs::read(build_dir.join(".providers/_contracts/abc123.contract.cbor"))
            .expect("contract cache materialized"),
        b"contract-cbor-bytes",
    );
    assert_eq!(
        fs::read(build_dir.join("assets/webchat-gui/config/tenants/demo.json"))
            .expect("tenant overlay materialized"),
        br#"{"tenant_id":"demo","skin":"3aigent"}"#,
    );
    // tenant.gmap was already written by `seed_workspace`; it must survive the
    // build (current code drops it because the file isn't a `.gtpack`).
    assert_eq!(
        fs::read(build_dir.join("tenants/default/tenant.gmap")).expect("tenant gmap materialized"),
        b"_ = forbidden\n",
    );
}

#[test]
fn build_defaults_artifact_path_to_dist_directory() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let result =
        greentic_bundle::build::build_workspace(&root, None, false, false, None).expect("build");
    let expected = root.join("dist/demo-bundle.gtbundle");

    assert_eq!(result.artifact_path, expected.display().to_string());
    assert!(
        expected.exists(),
        "expected artifact at {}",
        expected.display()
    );
}

#[test]
fn inspect_workspace_keeps_workspace_target_not_temp_path() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let report = greentic_bundle::build::inspect_target(Some(&root), None).expect("inspect");
    assert_eq!(report.target, root.display().to_string());
}

#[test]
fn doctor_validates_workspace_and_artifact() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    let artifact = root.join("demo.gtbundle");
    greentic_bundle::build::build_workspace(&root, Some(&artifact), false, false, None)
        .expect("build");

    let workspace_report =
        greentic_bundle::build::doctor_target(Some(&root), None).expect("doctor workspace");
    let artifact_report =
        greentic_bundle::build::doctor_target(None, Some(&artifact)).expect("doctor artifact");
    assert!(workspace_report.ok);
    assert!(artifact_report.ok);
}

#[test]
fn inspect_artifact_includes_content_listing() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    let artifact = root.join("demo.gtbundle");
    greentic_bundle::build::build_workspace(&root, Some(&artifact), false, false, None)
        .expect("build");

    let report = greentic_bundle::build::inspect_target(None, Some(&artifact)).expect("inspect");
    let contents = report.contents.expect("artifact contents");

    assert!(contents.iter().any(|entry| entry == "bundle.yaml"));
    assert!(contents.iter().any(|entry| entry == "bundle-lock.json"));
    assert!(
        contents
            .iter()
            .any(|entry| entry == "resolved/default.yaml")
    );
}

#[test]
fn dry_run_export_computes_plan_without_writing_artifact() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    let build_dir = root.join("state/build/demo-bundle/normalized");
    let artifact = root.join("dry-run.gtbundle");

    greentic_bundle::build::build_workspace(&root, None, false, false, None)
        .expect("seed build dir");
    let result = greentic_bundle::build::export_build_dir(&build_dir, &artifact, true, false, None)
        .expect("dry-run export");
    assert_eq!(result.artifact_path, artifact.display().to_string());
    assert!(!artifact.exists());
}

#[test]
fn doctor_detects_lock_drift() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    fs::write(
        root.join("bundle.yaml"),
        "\
schema_version: 1
bundle_id: demo-bundle
bundle_name: Demo Bundle
locale: en
mode: create
advanced_setup: true
app_packs:
  - pack-b
extension_providers:
  - provider-a
remote_catalogs:
  - file://catalog.json
hooks:
  - hook-a
subscriptions:
  - subscription-a
capabilities:
  - capability-a
setup_execution_intent: true
export_intent: false
",
    )
    .expect("rewrite bundle");

    let report = greentic_bundle::build::doctor_target(Some(&root), None).expect("doctor");
    assert!(!report.ok);
    let drift = report
        .checks
        .iter()
        .find(|check| check.name == "lock drift")
        .expect("drift check");
    assert!(!drift.ok);
}

#[test]
fn doctor_reports_workspace_reader_validation_error_details() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let mut lock = greentic_bundle::project::read_bundle_lock(&root).expect("read lock");
    lock.workspace_root = "wrong.yaml".to_string();
    greentic_bundle::project::write_bundle_lock(&root, &lock).expect("rewrite lock");

    let report = greentic_bundle::build::doctor_target(Some(&root), None).expect("doctor");
    assert!(!report.ok);
    let reader = report
        .checks
        .iter()
        .find(|check| check.name == "reader validation")
        .expect("reader check");
    assert!(!reader.ok);
    assert!(
        reader
            .details
            .as_deref()
            .unwrap_or_default()
            .contains("unexpected workspace_root")
    );
}

#[test]
fn inspect_artifact_reads_embedded_manifest() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    let artifact = root.join("demo.gtbundle");
    greentic_bundle::build::build_workspace(&root, Some(&artifact), false, false, None)
        .expect("build");

    let report =
        greentic_bundle::build::inspect_target(None, Some(&artifact)).expect("inspect artifact");
    let value = serde_json::to_value(report).expect("to value");
    assert_eq!(
        value.pointer("/manifest/bundle_id").and_then(Value::as_str),
        Some("demo-bundle")
    );
}

#[test]
fn reader_opens_normalized_build_directory() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    let result =
        greentic_bundle::build::build_workspace(&root, None, false, false, None).expect("build");

    let opened = greentic_bundle_reader::open_build_dir(Path::new(&result.build_dir))
        .expect("open build dir");
    assert_eq!(opened.source_kind.as_str(), "build_dir");
    assert_eq!(opened.manifest.bundle_id, "demo-bundle");
    assert_eq!(
        opened
            .runtime_surface()
            .app_packs
            .iter()
            .map(|entry| entry.reference.clone())
            .collect::<Vec<_>>(),
        vec!["pack-a".to_string()]
    );
}

#[test]
fn reader_opens_artifact_and_exposes_runtime_surface() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    let artifact = root.join("demo.gtbundle");
    greentic_bundle::build::build_workspace(&root, Some(&artifact), false, false, None)
        .expect("build");

    let opened = greentic_bundle_reader::open_artifact(&artifact).expect("open artifact");
    assert_eq!(opened.source_kind.as_str(), "artifact");
    assert_eq!(
        opened
            .runtime_surface()
            .extension_providers
            .iter()
            .map(|entry| entry.reference.clone())
            .collect::<Vec<_>>(),
        vec!["provider-a".to_string()]
    );
}

#[test]
fn reader_runtime_surface_exposes_catalogs_and_file_views() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    let artifact = root.join("demo.gtbundle");
    greentic_bundle::build::build_workspace(&root, Some(&artifact), false, false, None)
        .expect("build");

    let surface = greentic_bundle_reader::open_artifact(&artifact)
        .expect("open artifact")
        .runtime_surface();
    assert_eq!(surface.bundle_id, "demo-bundle");
    assert_eq!(surface.execution, "execute");
    assert_eq!(surface.catalogs.len(), 1);
    assert_eq!(surface.catalogs[0].requested_ref, "file://catalog.json");
    assert_eq!(surface.hooks, vec!["hook-a".to_string()]);
    assert_eq!(surface.subscriptions, vec!["subscription-a".to_string()]);
    assert_eq!(surface.capabilities, vec!["capability-a".to_string()]);
    assert_eq!(surface.resolved_targets.len(), 1);
    assert_eq!(surface.resolved_targets[0].tenant, "default");
    assert_eq!(
        surface.resolved_targets[0].app_pack_policies[0].reference,
        "pack-a"
    );
    assert_eq!(
        surface.resolved_targets[0].app_pack_policies[0].policy,
        "forbidden"
    );
    assert_eq!(
        surface.generated_resolved_files[0].path,
        "resolved/default.yaml"
    );
    assert_eq!(
        surface.generated_resolved_files[0].kind,
        greentic_bundle_reader::BundleFileKind::Resolved
    );
    assert_eq!(
        surface.generated_setup_files[0].kind,
        greentic_bundle_reader::BundleFileKind::SetupState
    );
}

#[test]
fn build_accepts_quoted_scalars_and_inline_yaml_lists() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    fs::write(
        root.join("bundle.yaml"),
        "\
schema_version: 1
bundle_id: \"demo-bundle\"
bundle_name: \"Demo Bundle\"
locale: \"en\"
mode: \"create\"
advanced_setup: true
app_packs: [pack-a, pack-b]
extension_providers: [provider-a, provider-b]
remote_catalogs: [file://catalog-a.json, file://catalog-b.json]
hooks: [hook-a, hook-b]
subscriptions: [subscription-a, subscription-b]
capabilities: [capability-a, capability-b]
setup_execution_intent: true
export_intent: false
",
    )
    .expect("rewrite bundle yaml");

    let report =
        greentic_bundle::build::build_workspace(&root, None, false, false, None).expect("build");
    let opened = greentic_bundle_reader::open_build_dir(Path::new(&report.build_dir))
        .expect("open build dir");
    let surface = opened.runtime_surface();

    assert_eq!(surface.bundle_id, "demo-bundle");
    assert_eq!(surface.bundle_name, "Demo Bundle");
    assert_eq!(surface.locale, "en");
    assert_eq!(surface.requested_mode, "create");
    assert_eq!(
        opened
            .manifest
            .app_packs
            .iter()
            .map(String::as_str)
            .collect::<Vec<_>>(),
        vec!["pack-a", "pack-b"]
    );
    assert_eq!(
        opened
            .manifest
            .extension_providers
            .iter()
            .map(String::as_str)
            .collect::<Vec<_>>(),
        vec!["provider-a", "provider-b"]
    );
    assert_eq!(
        opened
            .manifest
            .catalogs
            .iter()
            .map(String::as_str)
            .collect::<Vec<_>>(),
        vec!["file://catalog-a.json", "file://catalog-b.json"]
    );
    assert_eq!(
        surface.hooks,
        vec!["hook-a".to_string(), "hook-b".to_string()]
    );
    assert_eq!(
        surface.subscriptions,
        vec!["subscription-a".to_string(), "subscription-b".to_string()]
    );
    assert_eq!(
        surface.capabilities,
        vec!["capability-a".to_string(), "capability-b".to_string()]
    );
}

#[test]
fn build_parses_nested_resolved_target_metadata() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    fs::write(
        root.join("resolved/default.yaml"),
        "\
version: 1
tenant: default
team: ops
project_root: /tmp/demo
bundle:
  bundle_id: demo-bundle
  bundle_name: Demo Bundle
  locale: en
  mode: create
policy:
  source:
    tenant_gmap: tenants/default/tenant.gmap
    team_gmap: tenants/default/teams/ops/team.gmap
app_packs:
  - reference: pack-a
    policy: public
  - reference: pack-b
    policy: forbidden
",
    )
    .expect("rewrite resolved");

    let report =
        greentic_bundle::build::build_workspace(&root, None, false, false, None).expect("build");
    let target = greentic_bundle_reader::open_build_dir(Path::new(&report.build_dir))
        .expect("open build dir")
        .runtime_surface()
        .resolved_targets
        .into_iter()
        .next()
        .expect("resolved target");

    assert_eq!(target.tenant, "default");
    assert_eq!(target.team.as_deref(), Some("ops"));
    assert_eq!(target.default_policy, "forbidden");
    assert_eq!(target.tenant_gmap, "tenants/default/tenant.gmap");
    assert_eq!(
        target.team_gmap.as_deref(),
        Some("tenants/default/teams/ops/team.gmap")
    );
    assert_eq!(
        target
            .app_pack_policies
            .iter()
            .map(|policy| (policy.reference.as_str(), policy.policy.as_str()))
            .collect::<Vec<_>>(),
        vec![("pack-a", "public"), ("pack-b", "forbidden")]
    );
}

#[test]
fn reader_rejects_mismatched_setup_file_contract() {
    let temp = TempDir::new().expect("tempdir");
    let build_dir = temp.path().join("normalized");
    fs::create_dir_all(&build_dir).expect("build dir");
    fs::write(
        build_dir.join("bundle-manifest.json"),
        r#"{
  "format_version":"gtbundle-v1",
  "bundle_id":"demo-bundle",
  "bundle_name":"Demo Bundle",
  "requested_mode":"create",
  "locale":"en",
  "artifact_extension":".gtbundle",
  "generated_resolved_files":["resolved/default.yaml"],
  "generated_setup_files":["state/setup/provider-a.json"],
  "app_packs":["pack-a"],
  "extension_providers":["provider-a"],
  "catalogs":["file://catalog.json"],
  "hooks":[],
  "subscriptions":[],
  "capabilities":[]
}"#,
    )
    .expect("write manifest");
    fs::write(
        build_dir.join("bundle-lock.json"),
        r#"{
  "schema_version":1,
  "bundle_id":"demo-bundle",
  "requested_mode":"create",
  "execution":"execute",
  "cache_policy":"workspace-local",
  "tool_version":"0.4.0",
  "build_format_version":"bundle-lock-v1",
  "workspace_root":"bundle.yaml",
  "lock_file":"bundle.lock.json",
  "catalogs":[],
  "app_packs":[{"reference":"pack-a"}],
  "extension_providers":[{"reference":"provider-a"}],
  "setup_state_files":[]
}"#,
    )
    .expect("write lock");

    let error = greentic_bundle_reader::open_build_dir(&build_dir).expect_err("mismatch error");
    assert!(error.details.contains("setup state files"));
}

#[test]
fn reader_rejects_build_dir_with_missing_listed_file() {
    let temp = TempDir::new().expect("tempdir");
    let build_dir = temp.path().join("normalized");
    fs::create_dir_all(build_dir.join("resolved")).expect("resolved dir");
    fs::write(
        build_dir.join("bundle-manifest.json"),
        r#"{
  "format_version":"gtbundle-v1",
  "bundle_id":"demo-bundle",
  "bundle_name":"Demo Bundle",
  "requested_mode":"create",
  "locale":"en",
  "artifact_extension":".gtbundle",
  "generated_resolved_files":["resolved/default.yaml"],
  "generated_setup_files":[],
  "app_packs":[],
  "extension_providers":[],
  "catalogs":[],
  "hooks":[],
  "subscriptions":[],
  "capabilities":[]
}"#,
    )
    .expect("write manifest");
    fs::write(
        build_dir.join("bundle-lock.json"),
        r#"{
  "schema_version":1,
  "bundle_id":"demo-bundle",
  "requested_mode":"create",
  "execution":"execute",
  "cache_policy":"workspace-local",
  "tool_version":"0.4.0",
  "build_format_version":"bundle-lock-v1",
  "workspace_root":"bundle.yaml",
  "lock_file":"bundle.lock.json",
  "catalogs":[],
  "app_packs":[],
  "extension_providers":[],
  "setup_state_files":[]
}"#,
    )
    .expect("write lock");
    fs::write(build_dir.join("bundle.yaml"), "bundle_id: demo-bundle\n").expect("bundle yaml");

    let error = greentic_bundle_reader::open_build_dir(&build_dir).expect_err("missing file");
    assert!(error.details.contains("missing required bundle file"));
    assert!(error.details.contains("resolved/default.yaml"));
}

#[test]
fn reader_rejects_artifact_with_missing_listed_file() {
    let temp = TempDir::new().expect("tempdir");
    let build_dir = temp.path().join("normalized");
    fs::create_dir_all(&build_dir).expect("build dir");
    fs::write(
        build_dir.join("bundle-manifest.json"),
        r#"{
  "format_version":"gtbundle-v1",
  "bundle_id":"demo-bundle",
  "bundle_name":"Demo Bundle",
  "requested_mode":"create",
  "locale":"en",
  "artifact_extension":".gtbundle",
  "generated_resolved_files":["resolved/default.yaml"],
  "generated_setup_files":[],
  "app_packs":[],
  "extension_providers":[],
  "catalogs":[],
  "hooks":[],
  "subscriptions":[],
  "capabilities":[]
}"#,
    )
    .expect("write manifest");
    fs::write(
        build_dir.join("bundle-lock.json"),
        r#"{
  "schema_version":1,
  "bundle_id":"demo-bundle",
  "requested_mode":"create",
  "execution":"execute",
  "cache_policy":"workspace-local",
  "tool_version":"0.4.0",
  "build_format_version":"bundle-lock-v1",
  "workspace_root":"bundle.yaml",
  "lock_file":"bundle.lock.json",
  "catalogs":[],
  "app_packs":[],
  "extension_providers":[],
  "setup_state_files":[]
}"#,
    )
    .expect("write lock");
    fs::write(build_dir.join("bundle.yaml"), "bundle_id: demo-bundle\n").expect("bundle yaml");
    let artifact = temp.path().join("broken.gtbundle");

    greentic_bundle::build::export_build_dir(&build_dir, &artifact, false, false, None)
        .expect("export");
    let error =
        greentic_bundle_reader::open_artifact(&artifact).expect_err("missing artifact file");
    assert!(
        error
            .details
            .contains("artifact entry resolved/default.yaml not found")
    );
    assert!(error.details.contains("resolved/default.yaml"));
}

// Phase 0 secret-leak hotfix regression test: archived setup-state JSON files
// must never carry plaintext secret_values, even when the source-of-truth on
// disk still does. See plans/next-gen-deployment.md P0.1.
#[test]
fn build_redacts_secret_values_in_archived_setup_state() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let setup_state_path = root.join("state/setup/provider-a.json");
    let leaked_token = "sk-PLAINTEXT-MUST-NOT-LEAK";
    fs::write(
        &setup_state_path,
        format!(
            r#"{{"schema_version":1,"provider_id":"provider-a","source_kind":"legacy","form":{{"id":"provider-a-setup","title":"Provider A Setup","version":"1.0.0","description":"Provider A provider configuration","questions":[]}},"normalized_answers":{{}},"non_secret_config":{{"region":"eu-west-1"}},"secret_values":{{"api_token":"{leaked_token}"}}}}"#
        ),
    )
    .expect("seed populated setup state");

    let artifact = root.join("redacted.gtbundle");
    greentic_bundle::build::build_workspace(&root, Some(&artifact), false, false, None)
        .expect("build");

    let extract_dir = root.join("extracted");
    greentic_bundle::bundle_fs::extract_bundle(&artifact, &extract_dir).expect("extract");

    let archived_bytes =
        fs::read(extract_dir.join("state/setup/provider-a.json")).expect("read archived state");
    let archived_str = String::from_utf8(archived_bytes.clone()).expect("utf8");
    assert!(
        !archived_str.contains(leaked_token),
        "archived setup-state must not contain plaintext token, got: {archived_str}"
    );
    let archived: Value = serde_json::from_slice(&archived_bytes).expect("parse archived");
    // B12: the redactor drops the legacy `secret_values` key entirely.
    assert!(archived.get("secret_values").is_none());
    assert_eq!(
        archived["non_secret_config"]["region"],
        Value::String("eu-west-1".to_string())
    );
    assert_eq!(
        archived["provider_id"],
        Value::String("provider-a".to_string())
    );

    // Source-of-truth on disk is untouched — runtime still reads plaintext from
    // here until Phase B replaces the in-memory map with SecretRef. Only the
    // archived copy is redacted.
    let source_str = fs::read_to_string(&setup_state_path).expect("read source state");
    assert!(
        source_str.contains(leaked_token),
        "source setup-state should retain plaintext until Phase B; got: {source_str}"
    );
}

// Codex adversarial review (PR #112) caught that the original hotfix only
// cleared `secret_values` and left the SAME token alive in `normalized_answers`
// (greentic-bundle/src/setup/persist.rs:84-105 writes both). This test
// exercises the real-shape state where normalized_answers holds the secret
// token under the secret-marked question ID and asserts the extracted archive
// bytes contain neither plaintext copy. See plans/next-gen-deployment.md P0.1.
#[test]
fn build_redacts_secrets_from_normalized_answers_in_archived_setup_state() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let setup_state_path = root.join("state/setup/provider-a.json");
    let leaked_token = "sk-PLAINTEXT-MUST-NOT-LEAK-VIA-NORMALIZED";
    fs::write(
        &setup_state_path,
        format!(
            r#"{{
                "schema_version":1,
                "provider_id":"provider-a",
                "source_kind":"legacy",
                "form":{{
                    "id":"provider-a-setup","title":"Provider A","version":"1.0.0",
                    "questions":[
                        {{"id":"api_token","kind":"string","title":"Token","required":true,"secret":true}},
                        {{"id":"region","kind":"string","title":"Region","required":true,"secret":false}}
                    ]
                }},
                "normalized_answers":{{"api_token":"{leaked_token}","region":"eu-west-1"}},
                "non_secret_config":{{"region":"eu-west-1"}},
                "secret_values":{{"api_token":"{leaked_token}"}}
            }}"#
        ),
    )
    .expect("seed real-shape setup state");

    let artifact = root.join("redacted.gtbundle");
    greentic_bundle::build::build_workspace(&root, Some(&artifact), false, false, None)
        .expect("build");

    let extract_dir = root.join("extracted");
    greentic_bundle::bundle_fs::extract_bundle(&artifact, &extract_dir).expect("extract");

    let archived_bytes =
        fs::read(extract_dir.join("state/setup/provider-a.json")).expect("read archived state");
    let archived_str = String::from_utf8(archived_bytes.clone()).expect("utf8");
    assert!(
        !archived_str.contains(leaked_token),
        "archived setup-state must not contain plaintext token in any field, got:\n{archived_str}"
    );

    let archived: Value = serde_json::from_slice(&archived_bytes).expect("parse archived");
    // B12: the redactor drops the legacy `secret_values` key entirely.
    assert!(archived.get("secret_values").is_none());
    assert_eq!(
        archived["normalized_answers"],
        serde_json::json!({"region": "eu-west-1"}),
        "normalized_answers must retain only non-secret keys"
    );
    assert_eq!(
        archived["non_secret_config"],
        serde_json::json!({"region": "eu-west-1"})
    );

    // Raw archive bytes (pre-extract) must not contain the token either,
    // closing the loop on any compression/encoding path that might preserve it.
    let raw_artifact_bytes = fs::read(&artifact).expect("read artifact");
    assert!(
        !contains_bytes(&raw_artifact_bytes, leaked_token.as_bytes()),
        "raw .gtbundle bytes must not contain plaintext token"
    );
}

fn contains_bytes(haystack: &[u8], needle: &[u8]) -> bool {
    haystack
        .windows(needle.len())
        .any(|window| window == needle)
}

// Phase 0 secret-leak hotfix regression test: any dev-store file or directory
// reaching the archive boundary must abort the build with a loud error rather
// than silently shipping. See plans/next-gen-deployment.md P0.1.
#[test]
fn bundle_fs_refuses_to_archive_dev_secrets_env_path() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    // Run the build pipeline once to produce a valid build_dir.
    greentic_bundle::build::build_workspace(&root, None, false, false, None)
        .expect("seed build dir");
    let build_dir = root.join("state/build/demo-bundle/normalized");
    assert!(build_dir.is_dir());

    // Inject a stray dev-store file as if upstream pipeline had a regression.
    let dev_dir = build_dir.join(".greentic/dev");
    fs::create_dir_all(&dev_dir).expect("dev dir");
    fs::write(dev_dir.join(".dev.secrets.env"), "GTC_API_TOKEN=leaked").expect("seed dev secret");

    let artifact = root.join("denylist.gtbundle");
    let err = greentic_bundle::bundle_fs::write_bundle(&build_dir, &artifact)
        .expect_err("denylist must bail");
    let msg = format!("{err:#}");
    assert!(
        msg.contains("refusing to archive"),
        "expected denylist bail; got: {msg}"
    );
    assert!(
        !artifact.exists(),
        "denylisted build must not produce artifact"
    );
}

// Same denylist invariant, exercised through the stray `.dev.secrets.env`
// filename pattern (the file pattern, not the directory pattern).
#[test]
fn bundle_fs_refuses_stray_dev_secrets_env_filename() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    greentic_bundle::build::build_workspace(&root, None, false, false, None)
        .expect("seed build dir");
    let build_dir = root.join("state/build/demo-bundle/normalized");
    fs::write(build_dir.join("packs/.dev.secrets.env"), "X=Y").expect("seed stray");

    let artifact = root.join("stray.gtbundle");
    let err = greentic_bundle::bundle_fs::write_bundle(&build_dir, &artifact)
        .expect_err("denylist must bail");
    assert!(format!("{err:#}").contains(".dev.secrets.env"));
}

// Phase 0 P0.2: end-to-end coverage that `doctor_target` plumbs the secret-leak
// scanner into both workspace and artifact reports and that a clean build
// surfaces a passing `secret-leak scan` check.
#[test]
fn doctor_target_includes_secret_scan_check_on_clean_bundle() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    let artifact = root.join("clean.gtbundle");
    greentic_bundle::build::build_workspace(&root, Some(&artifact), false, false, None)
        .expect("build");

    for report in [
        greentic_bundle::build::doctor_target(Some(&root), None).expect("doctor workspace"),
        greentic_bundle::build::doctor_target(None, Some(&artifact)).expect("doctor artifact"),
    ] {
        assert!(report.ok, "expected clean report, got {report:?}");
        let scan = report
            .checks
            .iter()
            .find(|check| check.name == "secret-leak scan")
            .expect("missing secret-leak scan check");
        assert!(
            scan.ok,
            "secret-leak scan check should be ok on clean build"
        );
    }
}

// Phase 0 P0.2: full-pipeline integration — bypass the redactor by writing a
// build dir with populated `secret_values` directly, then bundle via the raw
// `bundle_fs::write_bundle` (which only blocks dev-store *paths*, not JSON
// *content*). The doctor must catch the leak post-archive.
#[test]
fn doctor_target_flags_artifact_with_populated_secret_values_in_setup_state() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    // Run the normal pipeline once so the build_dir has a valid manifest/lock,
    // then overwrite the redacted setup-state with a leaky one before re-archiving.
    greentic_bundle::build::build_workspace(&root, None, false, false, None)
        .expect("seed build dir");
    let build_dir = root.join("state/build/demo-bundle/normalized");
    fs::write(
        build_dir.join("state/setup/provider-a.json"),
        br#"{
            "schema_version":1,
            "provider_id":"provider-a",
            "source_kind":"legacy",
            "form":{"id":"provider-a-setup","title":"Provider A","version":"1.0.0","questions":[
                {"id":"api_token","kind":"string","title":"Token","required":true,"secret":true}
            ]},
            "normalized_answers":{"api_token":"sk-LEAK-VIA-DOCTOR"},
            "non_secret_config":{},
            "secret_values":{"api_token":"sk-LEAK-VIA-DOCTOR"}
        }"#,
    )
    .expect("overwrite redacted state with leaky one");

    let artifact = root.join("leaky.gtbundle");
    greentic_bundle::bundle_fs::write_bundle(&build_dir, &artifact)
        .expect("write_bundle accepts dev-store-clean tree even with leaky JSON");

    let report = greentic_bundle::build::doctor_target(None, Some(&artifact)).expect("doctor");
    assert!(
        !report.ok,
        "doctor must flag leaky artifact, got {report:?}"
    );
    let kinds: Vec<&str> = report
        .checks
        .iter()
        .filter(|check| !check.ok && check.name.starts_with("secret-leak: "))
        .map(|check| check.name.as_str())
        .collect();
    assert!(
        kinds
            .iter()
            .any(|name| name.contains("secret_values populated")),
        "missing secret_values finding in {kinds:?}"
    );
    assert!(
        kinds
            .iter()
            .any(|name| name.contains("normalized_answers leak")),
        "missing normalized_answers finding in {kinds:?}"
    );
}

// C2: write_build_outputs --signing-key path produces a DSSE envelope sidecar
// at <artifact>.sig that verifies against the matching public key.
#[test]
fn build_with_signing_emits_verifiable_sig_sidecar() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let sk = SigningKey::from_bytes(&[42u8; 32]);
    let vk = sk.verifying_key();
    let priv_pem = sk.to_pkcs8_pem(LineEnding::LF).unwrap().to_string();
    let pub_pem = vk.to_public_key_pem(LineEnding::LF).unwrap();
    let key_dir = temp.path().join("keys");
    fs::create_dir_all(&key_dir).unwrap();
    let key_path = key_dir.join("signing.pem");
    fs::write(&key_path, &priv_pem).unwrap();
    fs::write(key_dir.join("signing.pem.pub"), &pub_pem).unwrap();

    let artifact = root.join("signed.gtbundle");
    let result = greentic_bundle::build::build_workspace(
        &root,
        Some(&artifact),
        false,
        false,
        Some(&SigningConfig {
            signing_key_path: key_path,
            key_id_override: None,
            builder_id: Some("greentic-bundle:test".into()),
            signature_path_override: None,
        }),
    )
    .expect("signed build");

    let sig_path = result.signature_path.expect("signature_path present");
    assert_eq!(sig_path, format!("{}.sig", artifact.display()));
    let envelope_bytes = fs::read(&sig_path).expect("read sig");

    let artifact_bytes = fs::read(&artifact).expect("read artifact");
    let expected_digest = hex::encode(Sha256::digest(&artifact_bytes));
    let key_id = key_id_for_public_key_pem(&pub_pem).unwrap();
    let trust = TrustRoot::new(vec![TrustedKey {
        key_id: key_id.clone(),
        public_key_pem: pub_pem,
    }]);
    let verified = verify_artifact_dsse(&envelope_bytes, &expected_digest, &trust).expect("verify");
    assert_eq!(verified.verified_key_ids, vec![key_id]);
    assert_eq!(
        verified.statement.predicate_type,
        "https://slsa.dev/provenance/v1"
    );
}

#[test]
fn build_without_signing_omits_signature_path() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);
    let artifact = root.join("unsigned.gtbundle");
    let result =
        greentic_bundle::build::build_workspace(&root, Some(&artifact), false, false, None)
            .expect("build");
    assert!(result.signature_path.is_none());
    let json = serde_json::to_value(&result).unwrap();
    assert!(
        json.get("signature_path").is_none(),
        "signature_path must be omitted via skip_serializing_if when absent, got {json}"
    );
    // Companion sidecar must not exist.
    assert!(!Path::new(&format!("{}.sig", artifact.display())).exists());
}

// Codex #2 + #3 regression: a mismatched --key-id must abort build_workspace
// BEFORE any .gtbundle is written. Otherwise a stale rotated id would leave
// the .gtbundle on disk paired with an envelope a verifier cannot trust.
#[test]
fn signing_config_validation_aborts_before_artifact_lands() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let sk = SigningKey::from_bytes(&[43u8; 32]);
    let priv_pem = sk.to_pkcs8_pem(LineEnding::LF).unwrap().to_string();
    let key_path = temp.path().join("k.pem");
    fs::write(&key_path, &priv_pem).unwrap();

    let artifact = root.join("never-lands.gtbundle");
    let err = greentic_bundle::build::build_workspace(
        &root,
        Some(&artifact),
        false,
        false,
        Some(&SigningConfig {
            signing_key_path: key_path,
            // Wrong key id for this private key.
            key_id_override: Some("deadbeefdeadbeefdeadbeefdeadbeef".into()),
            builder_id: None,
            signature_path_override: None,
        }),
    )
    .expect_err("mismatched --key-id must abort");
    assert!(format!("{err:#}").contains("does not match"));
    // Crucial: the .gtbundle must not exist — early validation gated it.
    assert!(!artifact.exists());
    assert!(!Path::new(&format!("{}.sig", artifact.display())).exists());
    assert!(!Path::new(&format!("{}.partial", artifact.display())).exists());
}

// Codex #1 regression at the workspace-build layer: --signature-output that
// equals the artifact path must abort before write_bundle runs.
#[test]
fn signature_path_collision_aborts_before_artifact_lands() {
    let temp = TempDir::new().expect("tempdir");
    let root = temp.path().join("bundle");
    seed_workspace(&root);

    let sk = SigningKey::from_bytes(&[44u8; 32]);
    let priv_pem = sk.to_pkcs8_pem(LineEnding::LF).unwrap().to_string();
    let key_path = temp.path().join("k.pem");
    fs::write(&key_path, &priv_pem).unwrap();

    let artifact = root.join("collide.gtbundle");
    let err = greentic_bundle::build::build_workspace(
        &root,
        Some(&artifact),
        false,
        false,
        Some(&SigningConfig {
            signing_key_path: key_path,
            key_id_override: None,
            builder_id: None,
            // Sidecar path == artifact path; refuse to overwrite the bundle
            // with its own envelope.
            signature_path_override: Some(artifact.clone()),
        }),
    )
    .expect_err("collision must abort");
    assert!(format!("{err:#}").contains("refusing to overwrite"));
    assert!(!artifact.exists());
}