gras 0.1.13

A Genetic Programming framework for Neural Architecture Search in Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
//! Engine tests — construction, run lifecycle, reproducibility, builder.

use super::*;
use crate::graph::node::Activation;
use crate::graph::topology::{CombineOp, TopologyOptions};
use flodl::nn::loss::mse_loss;

fn temp_data_dir() -> PathBuf {
    let dir = std::env::temp_dir().join(format!("gras_engine_test_{}", fastrand::u64(..)));
    let (inputs, targets) = crate::utils::data::make_sine(64);
    crate::utils::data::save_dataset(&dir, &crate::Dataset { inputs, targets }).unwrap();
    dir
}

fn test_trainer() -> crate::trainer::supervised::SupervisedTrainer {
    let dir = temp_data_dir();
    crate::trainer::supervised::SupervisedTrainer::new(
        &dir,
        1, // input_dim
        1, // output_dim
        crate::trainer::supervised::TrainingConfig {
            num_epochs: 1,
            ..Default::default()
        },
        |p, y| mse_loss(p, y),
    )
    .unwrap()
}

fn test_options() -> EngineOptions {
    EngineOptions {
        pop_size: Some(3),
        num_generations: Some(2),
        dedup_pop_and_fill: false,
        topology_options: TopologyOptions {
            hidden_dim: 4,
            ..Default::default()
        },
        hidden_dim_pool: 4..=4,
        selection: Some(SelectionMethod::Tournament { tournament_size: 2 }),
        crossover: Some(CrossoverMethod::OnePoint { action_prob: 0.5 }),
        mutation: MutationMethod::Activation { prob: 0.1 },
        results_dir: std::env::temp_dir().join(format!("gras_engine_res_{}", fastrand::u64(..))),

        ..Default::default()
    }
}

#[test]
fn test_engine_runs_and_checkpoints() {
    let data_dir = temp_data_dir();
    let mut engine = Engine::new(
        test_options(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    engine.run().unwrap();
    let imp_dir = engine.run_dir.join("improvements");
    assert!(imp_dir.exists());
    let mut json_files: Vec<_> = std::fs::read_dir(&imp_dir)
        .unwrap()
        .map(|e| e.unwrap().file_name().to_string_lossy().into_owned())
        .filter(|f| f.ends_with(".json"))
        .collect();
    json_files.sort();
    assert!(!json_files.is_empty());
    // One JSON per gen
    let num_gens = engine.options.num_generations.unwrap();
    assert_eq!(json_files.len(), num_gens);
    // Load the last generation's data
    let last_gen = num_gens - 1;
    let gen_file = format!(
        "gen_{:0width$}.json",
        last_gen,
        width = super::gen_width(num_gens)
    );
    let latest_json = std::fs::read_to_string(imp_dir.join(&gen_file)).unwrap();
    let v: serde_json::Value = serde_json::from_str(&latest_json).unwrap();
    // Verify gen JSON structure
    assert_eq!(v["generation"].as_u64().unwrap() as usize, last_gen);
    let individuals = v["individuals"].as_array().unwrap();
    assert_eq!(individuals.len(), engine.options.pop_size.unwrap());
    // Every individual should have valid topology
    for ind in individuals {
        let topo = Topology::from_json(ind["topology"].as_str().unwrap()).unwrap();
        assert_eq!(topo.validate(), Ok(()));
        assert!(ind["fitness"].is_f64());
        assert!(ind["params"].is_u64());
    }
    assert!(engine.run_dir.join("engine.json").exists());
    let fitness = engine.scores().iter().copied().reduce(f32::max).unwrap();
    assert!(fitness.is_finite());
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&engine.options.results_dir);
}

/// Every individual's `topo_hash` in each gen snapshot must be the canonical
/// xxh3 hash (16 hex chars) of its own topology string — the same hash
/// `robustness.csv` exposes as `topo_id`, so a hash copied from the CSV
/// resolves to the topology in the snapshots.
#[test]
fn test_gen_json_topo_hash_is_canonical() {
    let data_dir = temp_data_dir();
    let mut engine = Engine::new(
        EngineOptions {
            seed: Some(321),
            ..test_options()
        },
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    engine.run().unwrap();

    let imp_dir = engine.run_dir.join("improvements");
    let num_gens = engine.options.num_generations.unwrap();
    let width = super::gen_width(num_gens);
    let mut run_hashes: std::collections::HashSet<String> = std::collections::HashSet::new();

    for g in 0..num_gens {
        let stem = format!("gen_{g:0width$}");
        let raw = std::fs::read_to_string(imp_dir.join(format!("{stem}.json"))).unwrap();
        let v: serde_json::Value = serde_json::from_str(&raw).unwrap();
        // gen_seed is recorded and matches the public derivation formula
        // (reproducibility contract: replays use it for splits/batches).
        assert_eq!(
            v["gen_seed"].as_u64().unwrap(),
            crate::engine::derive_seed(321, g),
            "gen_seed must equal derive_seed(run_seed, generation)"
        );
        for ind in v["individuals"].as_array().unwrap() {
            let topo_json = ind["topology"].as_str().unwrap();
            let stored = ind["topo_hash"].as_str().unwrap();
            assert_eq!(stored.len(), 16, "topo_hash must be 16 hex chars");
            assert_eq!(
                stored,
                crate::utils::log_utils::topo_hash(topo_json),
                "topo_hash must match the canonical xxh3 hash of the topology"
            );
            // Self-describing individual: dropout_prob recorded, and the
            // embedded topology carries the same seed + dropout the engine
            // built the net with.
            let topo: crate::graph::topology::Topology =
                serde_json::from_str(topo_json).unwrap();
            assert_eq!(ind["seed"].as_u64().unwrap() as usize, topo.options.seed);
            assert!(
                ind["dropout_prob"].as_f64().is_some(),
                "individual must record dropout_prob"
            );
            // Per-epoch curves (D1): SupervisedTrainer ran 1 epoch here, so
            // each individual carries 1-entry curves and its final eval_loss
            // equals the recorded `loss`.
            let train: Vec<f32> = ind["train_losses"]
                .as_array()
                .map(|a| a.iter().map(|x| x.as_f64().unwrap() as f32).collect())
                .unwrap_or_default();
            let eval: Vec<f32> = ind["eval_losses"]
                .as_array()
                .map(|a| a.iter().map(|x| x.as_f64().unwrap() as f32).collect())
                .unwrap_or_default();
            assert_eq!(train.len(), 1, "train curve must cover the 1 epoch");
            assert_eq!(eval.len(), 1, "eval curve must cover the 1 epoch");
            if let Some(loss) = ind["loss"].as_f64() {
                assert!(
                    (eval[eval.len() - 1] as f64 - loss).abs() < 1e-6,
                    "final eval_losses entry must equal the recorded loss"
                );
            }
            run_hashes.insert(stored.to_string());
        }
    }

    // Every topology the CSV reports must exist in the snapshots.
    let csv = std::fs::read_to_string(engine.run_dir.join("robustness.csv")).unwrap();
    for line in csv.lines().skip(1) {
        let topo_id = line.split(',').next().unwrap();
        assert!(
            run_hashes.contains(topo_id),
            "csv topo_id {topo_id} must resolve in the gen snapshots"
        );
    }

    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&engine.options.results_dir);
}

/// Selection must keep the parallel metric arrays in lockstep with `pop`:
/// after `select()`, `pop[i] ↔ scores[i] ↔ eval_losses[i] ↔ param_counts[i]`
/// still all refer to the same individual.
#[test]
fn test_select_keeps_metrics_in_lockstep() {
    let data_dir = temp_data_dir();
    let mut engine = Engine::new(
        test_options(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();

    // Fake a just-evaluated generation: distinct scores with loss/params
    // derived from each score, so misalignment is detectable afterwards.
    let n = engine.pop.len();
    engine.scores = (0..n).map(|i| i as f32).collect();
    engine.eval_losses = engine.scores.iter().map(|&s| Some(s * 2.0)).collect();
    engine.param_counts = engine.scores.iter().map(|&s| s as usize * 10 + 1).collect();

    engine.select();

    assert_eq!(engine.pop.len(), n);
    assert_eq!(engine.scores.len(), n);
    assert_eq!(engine.eval_losses.len(), n);
    assert_eq!(engine.param_counts.len(), n);
    for i in 0..n {
        let s = engine.scores[i];
        assert_eq!(
            engine.eval_losses[i],
            Some(s * 2.0),
            "loss out of lockstep at {i}"
        );
        assert_eq!(
            engine.param_counts[i],
            s as usize * 10 + 1,
            "params out of lockstep at {i}"
        );
    }

    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&engine.options.results_dir);
}

#[test]
fn test_engine_to_json_replicates_experiment() {
    let data_dir = temp_data_dir();
    let mut engine = Engine::new(
        test_options(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    engine.run().unwrap();
    let json = engine.to_json().unwrap();
    let v: serde_json::Value = serde_json::from_str(&json).unwrap();
    assert_eq!(v["run_id"], engine.run_id);
    assert_eq!(v["pop_size"], 3);
    assert_eq!(v["run_seed"], engine.seed);
    assert!(v["history"].is_array());
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&engine.options.results_dir);
}

// test_engine_custom_fitness_invoked_every_individual removed — call counting is now trainer-internal

// test_engine_auto_detects_input_dim removed — dims now user-provided via trainer

// test_engine_batched_evaluation removed — batch budget is now trainer-internal

// test_engine_rejects_bad_budget removed — batch budget is now trainer-internal

#[test]
fn test_engine_maximize_direction() {
    let data_dir = temp_data_dir();
    let make_scorer = |dir: Direction| {
        Fitness::new(
            move |pred, _target| {
                let vec = pred.data().to_f32_vec().unwrap();
                Ok(vec.iter().sum::<f32>() / vec.len() as f32)
            },
            dir,
            "custom",
        )
    };
    let opts = EngineOptions {
        num_generations: Some(1),
        num_threads: 2,
        hidden_dim_pool: 4..=8,
        ..test_options()
    };
    let mut eng = Engine::new(
        opts.clone(),
        make_scorer(Direction::Maximize),
        test_trainer(),
    )
    .unwrap();
    eng.run().unwrap();
    let max_best = eng.scores().iter().copied().reduce(f32::max).unwrap();
    let mut eng = Engine::new(
        opts.clone(),
        make_scorer(Direction::Minimize),
        test_trainer(),
    )
    .unwrap();
    eng.run().unwrap();
    let min_best = eng.scores().iter().copied().reduce(f32::min).unwrap();
    assert!(max_best.is_finite());
    assert!(min_best.is_finite());
    assert_ne!(max_best, min_best);
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&opts.results_dir);
}

#[test]
fn test_engine_builder_chains_and_validates() {
    let opts = EngineOptions::builder()
        .set_pop_size(15)
        .set_num_generations(3)
        .set_seed(Some(42))
        .set_hidden_dim(16)
        .set_hidden_dim_pool(8..=32)
        .set_combine_op_pool(vec![CombineOp::Add, CombineOp::Mean])
        .set_activation_pool(vec![Activation::ReLU, Activation::GeLU])
        .set_selection(SelectionMethod::Tournament { tournament_size: 2 })
        .set_crossover(CrossoverMethod::OnePoint { action_prob: 0.5 })
        .set_mutation(MutationMethod::Activation { prob: 0.1 })
        .set_num_threads(2)
        .build()
        .unwrap();
    assert_eq!(opts.pop_size, Some(15));
    assert_eq!(opts.num_generations, Some(3));
    assert_eq!(opts.seed, Some(42));
    assert_eq!(opts.hidden_dim_pool, 8..=32);
    assert_eq!(opts.combine_op_pool, vec![CombineOp::Add, CombineOp::Mean]);

    assert!(EngineOptions::builder().set_pop_size(0).build().is_err());

    // set_mutation() is required — omitting it should error at build time.
    assert!(
        EngineOptions::builder()
            .set_pop_size(4)
            .set_num_generations(1)
            .set_hidden_dim_pool(4..=4)
            .build()
            .is_err()
    );
    let opts = EngineOptions::builder()
        .set_pop_size(4)
        .set_num_generations(1)
        .set_selection(SelectionMethod::Tournament { tournament_size: 2 })
        .set_crossover(CrossoverMethod::OnePoint { action_prob: 0.5 })
        .set_mutation(MutationMethod::Activation { prob: 0.1 })
        .set_combine_op_pool(vec![])
        .build()
        .unwrap();
    assert_eq!(opts.combine_op_pool.len(), 4);
    let opts = EngineOptions::builder()
        .set_pop_size(4)
        .set_num_generations(1)
        .set_selection(SelectionMethod::Tournament { tournament_size: 2 })
        .set_crossover(CrossoverMethod::OnePoint { action_prob: 0.5 })
        .set_mutation(MutationMethod::Activation { prob: 0.1 })
        .set_activation_pool(vec![])
        .build()
        .unwrap();
    assert_eq!(opts.activation_pool.len(), 16);
}

#[test]
fn test_engine_builder_one_shot() {
    let data_dir = temp_data_dir();
    let opts = EngineOptions::builder()
        .set_pop_size(4)
        .set_num_generations(1)
        .set_seed(Some(7))
        .set_hidden_dim_pool(4..=4)
        .set_selection(SelectionMethod::Tournament { tournament_size: 2 })
        .set_crossover(CrossoverMethod::OnePoint { action_prob: 0.5 })
        .set_mutation(MutationMethod::Activation { prob: 0.1 })
        .build()
        .unwrap();
    let mut engine = Engine::new(
        opts,
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    engine.run().unwrap();
    assert!(!engine.scores().is_empty());
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&engine.options.results_dir);
}

#[test]
fn test_engine_gp_sampling_varies_and_reproduces() {
    let data_dir = temp_data_dir();
    let pool = vec![
        Activation::Identity,
        Activation::ReLU,
        Activation::GeLU,
        Activation::SELU,
    ];
    let make_opts = || EngineOptions {
        pop_size: Some(8),
        num_generations: Some(1),
        seed: Some(99),
        hidden_dim_pool: 4..=16,
        combine_op_pool: vec![CombineOp::Add, CombineOp::Mean],
        activation_pool: pool.clone(),
        results_dir: std::env::temp_dir().join(format!("gras_gp_res_{}", fastrand::u64(..))),
        ..test_options()
    };
    let a = Engine::new(
        make_opts(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    let b = Engine::new(
        make_opts(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    let mut dims: Vec<usize> = Vec::new();
    for g in &a.pop {
        for n in &g.nodes {
            if let Some(d) = n.hidden_dim {
                if !dims.contains(&d) {
                    dims.push(d);
                }
            }
        }
    }
    dims.sort_unstable();
    assert!(dims.len() > 1, "hidden dims must vary: {dims:?}");
    for (ga, gb) in a.pop.iter().zip(b.pop.iter()) {
        assert_eq!(ga.options.hidden_dim, gb.options.hidden_dim);
        assert_eq!(crate::spec::Spec::from(ga), crate::spec::Spec::from(gb));
    }
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&a.options.results_dir);
    let _ = std::fs::remove_dir_all(&b.options.results_dir);
}

#[test]
fn test_engine_new_leaves_no_folder() {
    let data_dir = temp_data_dir();
    let opts = test_options();
    let engine = Engine::new(
        opts.clone(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    assert!(!engine.run_dir.exists());
    let mut engine = engine;
    engine.run().unwrap();
    assert!(engine.run_dir.exists());
    assert!(engine.run_dir.join("engine.json").exists());
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&opts.results_dir);
}

#[test]
fn test_engine_random_seed_recorded() {
    let data_dir = temp_data_dir();
    let opts = EngineOptions {
        seed: None,
        num_threads: 4,
        ..test_options()
    };
    let mut engine = Engine::new(
        opts.clone(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    engine.run().unwrap();
    let v: serde_json::Value = serde_json::from_str(&engine.to_json().unwrap()).unwrap();
    assert_eq!(v["run_seed"], engine.seed);
    let other = Engine::new(
        opts.clone(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    assert_ne!(other.seed, engine.seed);
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&opts.results_dir);
}

#[test]
fn test_engine_seeded_run_is_reproducible() {
    let data_dir = temp_data_dir();
    let make = || EngineOptions {
        seed: Some(123),
        num_threads: 3,
        dropout_prob: 0.0,
        ..test_options()
    };
    let mut a = Engine::new(
        make(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    let mut b = Engine::new(
        make(),
        Fitness::new(
            |p, y| Ok(mse_loss(p, y)?.item()? as f32),
            Direction::Minimize,
            "mse",
        ),
        test_trainer(),
    )
    .unwrap();
    a.run().unwrap();
    b.run().unwrap();
    // Seeded runs should produce identical scores
    assert_eq!(a.scores(), b.scores());
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&a.options.results_dir);
    let _ = std::fs::remove_dir_all(&b.options.results_dir);
}

/// The engine seed must flow down to the initial population: each topology's
/// `options.seed` is `derive_seed(run_seed, i)`, so the blueprint RNGs are
/// deterministic per individual. Two engines with the same seed must produce
/// identical populations (same dims, activations, connections).
#[test]
fn test_seed_flows_to_initial_population() {
    let data_dir = temp_data_dir();
    let make = || EngineOptions {
        seed: Some(2024),
        num_threads: 2,
        dropout_prob: 0.0,
        ..test_options()
    };
    let a = Engine::new(
        make(),
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        test_trainer(),
    )
    .unwrap();
    let b = Engine::new(
        make(),
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        test_trainer(),
    )
    .unwrap();

    // Per-individual seed derivation: pop[i].options.seed == derive_seed(run_seed, i)
    for (i, (ta, tb)) in a.pop.iter().zip(&b.pop).enumerate() {
        assert_eq!(
            ta.options.seed as u64,
            derive_seed(a.seed, i),
            "ind {i} seed must derive from run_seed"
        );
        assert_eq!(
            ta.options.seed, tb.options.seed,
            "ind {i} seed matches across runs"
        );
    }

    // Identical blueprints (Spec = JSON round-trip mirror of the topology)
    for (i, (ta, tb)) in a.pop.iter().zip(&b.pop).enumerate() {
        assert_eq!(
            crate::spec::Spec::from(ta),
            crate::spec::Spec::from(tb),
            "ind {i} blueprint"
        );
    }

    // A different seed must produce a different population (at least one individual)
    let c = Engine::new(
        EngineOptions {
            seed: Some(2025),
            ..make()
        },
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        test_trainer(),
    )
    .unwrap();
    let same = a
        .pop
        .iter()
        .zip(&c.pop)
        .all(|(ta, tc)| crate::spec::Spec::from(ta) == crate::spec::Spec::from(tc));
    assert!(!same, "different run_seed must change the population");

    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&a.options.results_dir);
    let _ = std::fs::remove_dir_all(&b.options.results_dir);
    let _ = std::fs::remove_dir_all(&c.options.results_dir);
}

/// The seed must flow through the *whole* run: initial pop → per-generation
/// derive_seed chain (selection/crossover/mutation/refill + trainer gen_seed)
/// → history. Two seeded runs must be identical in scores, population,
/// history, and the JSON on disk.
#[test]
fn test_seed_chains_through_entire_run() {
    let data_dir = temp_data_dir();
    let make = || EngineOptions {
        seed: Some(777),
        num_threads: 2,
        dropout_prob: 0.0,
        ..test_options()
    };
    let mut a = Engine::new(
        make(),
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        test_trainer(),
    )
    .unwrap();
    let mut b = Engine::new(
        make(),
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        test_trainer(),
    )
    .unwrap();
    a.run().unwrap();
    b.run().unwrap();

    // Final scores identical
    assert_eq!(a.scores(), b.scores());
    // Per-generation history identical (avg_score/avg_loss/avg_params/unique_topos)
    assert_eq!(a.history, b.history, "per-generation history must match");
    // Final population identical (selection/crossover/mutation all seeded)
    for (i, (ta, tb)) in a.pop.iter().zip(&b.pop).enumerate() {
        assert_eq!(
            crate::spec::Spec::from(ta),
            crate::spec::Spec::from(tb),
            "final pop ind {i}"
        );
    }
    // On-disk engine.json identical except run_id (time-based)
    let ja: serde_json::Value =
        serde_json::from_str(&std::fs::read_to_string(a.run_dir.join("engine.json")).unwrap())
            .unwrap();
    let jb: serde_json::Value =
        serde_json::from_str(&std::fs::read_to_string(b.run_dir.join("engine.json")).unwrap())
            .unwrap();
    assert_eq!(ja["run_seed"], jb["run_seed"]);
    // Compare options except results_dir (random temp dir differs per test)
    let mut oa = ja["options"].clone();
    let mut ob = jb["options"].clone();
    oa["results_dir"] = serde_json::Value::Null;
    ob["results_dir"] = serde_json::Value::Null;
    assert_eq!(oa, ob);
    assert_eq!(ja["history"], jb["history"]);
    assert_eq!(ja["robustness"], jb["robustness"]);

    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&a.options.results_dir);
    let _ = std::fs::remove_dir_all(&b.options.results_dir);
}

/// Full reproduction story: run a seeded experiment, read engine.json back,
/// and rebuild a fresh engine from the recorded seed + options. The new run
/// must be byte-identical in scores, history, and population.
#[test]
fn test_reproduce_from_engine_json() {
    let data_dir = temp_data_dir();
    let opts = EngineOptions {
        seed: Some(555),
        num_threads: 2,
        dropout_prob: 0.0,
        ..test_options()
    };
    let mut first = Engine::new(
        opts.clone(),
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        test_trainer(),
    )
    .unwrap();
    first.run().unwrap();

    // Read the JSON the experiment wrote
    let raw = std::fs::read_to_string(first.run_dir.join("engine.json")).unwrap();
    let v: serde_json::Value = serde_json::from_str(&raw).unwrap();
    let recorded_seed = v["run_seed"].as_u64().unwrap();
    assert_eq!(
        recorded_seed, first.seed,
        "engine.json must record the actual run seed"
    );
    assert_eq!(
        v["options"]["seed"].as_u64(),
        Some(recorded_seed),
        "options block must carry the resolved seed"
    );

    // Rebuild a fresh engine from the JSON: same seed + same options
    let mut replay = Engine::new(
        EngineOptions {
            seed: Some(recorded_seed),
            ..opts.clone()
        },
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        test_trainer(),
    )
    .unwrap();
    replay.run().unwrap();

    assert_eq!(
        first.scores(),
        replay.scores(),
        "scores must reproduce from engine.json"
    );
    assert_eq!(
        first.history, replay.history,
        "history must reproduce from engine.json"
    );
    for (i, (ta, tb)) in first.pop.iter().zip(&replay.pop).enumerate() {
        assert_eq!(
            crate::spec::Spec::from(ta),
            crate::spec::Spec::from(tb),
            "pop ind {i} must reproduce"
        );
    }

    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&first.options.results_dir);
    let _ = std::fs::remove_dir_all(&replay.options.results_dir);
}

/// Auto-generated seeds must also be recorded back into options.seed, so even
/// an unseeded run is reproducible from its engine.json afterwards.
#[test]
fn test_auto_seed_recorded_in_options() {
    let data_dir = temp_data_dir();
    let opts = EngineOptions {
        seed: None,
        num_threads: 2,
        ..test_options()
    };
    let mut engine = Engine::new(
        opts.clone(),
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        test_trainer(),
    )
    .unwrap();
    engine.run().unwrap();
    let v: serde_json::Value =
        serde_json::from_str(&std::fs::read_to_string(engine.run_dir.join("engine.json")).unwrap())
            .unwrap();
    let run_seed = v["run_seed"].as_u64().unwrap();
    assert_ne!(run_seed, 0);
    assert_eq!(
        v["options"]["seed"].as_u64(),
        Some(run_seed),
        "auto seed must be written back into options"
    );
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&opts.results_dir);
}

fn mse_scorer() -> impl Fn(&flodl::Variable, &flodl::Variable) -> flodl::tensor::Result<f32> {
    |p, y| Ok(mse_loss(p, y)?.item()? as f32)
}

/// Trainer over a shared data dir — resume tests need byte-identical data
/// across the interrupted run, the resumed run, and the uninterrupted control.
fn shared_trainer(data_dir: &PathBuf) -> crate::trainer::supervised::SupervisedTrainer {
    crate::trainer::supervised::SupervisedTrainer::new(
        data_dir,
        1,
        1,
        crate::trainer::supervised::TrainingConfig {
            num_epochs: 1,
            ..Default::default()
        },
        |p, y| mse_loss(p, y),
    )
    .unwrap()
}

/// Resume must be a seamless continuation: a run split at the frontier
/// (A runs 3 gens, then B resumes for 2 more via set_resume_from) must be
/// bit-identical — scores, population, history, robustness, engine.json — to
/// one uninterrupted run (C) with the combined 5 generations.
#[test]
fn test_resume_from_checkpoint_continues_exactly() {
    let data_dir = temp_data_dir();
    let make_opts = |gens: usize| EngineOptions {
        pop_size: Some(4),
        num_generations: Some(gens),
        seed: Some(31337),
        num_threads: 2,
        dropout_prob: 0.0,
        results_dir: std::env::temp_dir().join(format!("gras_resume_res_{}", fastrand::u64(..))),
        ..test_options()
    };

    // A: 3 generations, completed normally.
    let mut a = Engine::new(
        make_opts(3),
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        shared_trainer(&data_dir),
    )
    .unwrap();
    a.run().unwrap();
    assert!(
        a.run_dir.join("checkpoint.json").exists(),
        "run must write checkpoint.json"
    );
    assert_eq!(a.generation, 3);

    // B: resume A's run dir for 2 more generations.
    let mut b_opts = make_opts(2);
    b_opts.resume_from = Some(a.run_dir.clone());
    let mut b = Engine::new(
        b_opts,
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        shared_trainer(&data_dir),
    )
    .unwrap();
    assert_eq!(b.generation, 3, "resume starts at the checkpoint frontier");
    assert_eq!(b.seed, a.seed, "resume inherits the run seed");
    assert_eq!(
        b.pop.len(),
        a.pop.len(),
        "resume inherits the frontier population"
    );
    for (i, (ta, tb)) in a.pop.iter().zip(&b.pop).enumerate() {
        assert_eq!(
            crate::spec::Spec::from(ta),
            crate::spec::Spec::from(tb),
            "frontier pop ind {i}"
        );
    }
    assert_eq!(
        b.history, a.history,
        "resume restores the source run's history"
    );
    b.run().unwrap();
    assert_eq!(b.generation, 5);

    // C: the same 5 generations in one uninterrupted run.
    let mut c = Engine::new(
        make_opts(5),
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        shared_trainer(&data_dir),
    )
    .unwrap();
    c.run().unwrap();

    // The resumed run must match the uninterrupted run exactly.
    assert_eq!(
        b.scores(),
        c.scores(),
        "final scores must match the uninterrupted run"
    );
    assert_eq!(
        b.history.len(),
        c.history.len(),
        "history must span the whole search"
    );
    assert_eq!(
        b.history, c.history,
        "history must match the uninterrupted run"
    );
    for (i, (tb, tc)) in b.pop.iter().zip(&c.pop).enumerate() {
        assert_eq!(
            crate::spec::Spec::from(tb),
            crate::spec::Spec::from(tc),
            "final pop ind {i}"
        );
    }

    // On-disk artifacts are continuous and identical to the control.
    let jb: serde_json::Value =
        serde_json::from_str(&std::fs::read_to_string(b.run_dir.join("engine.json")).unwrap())
            .unwrap();
    let jc: serde_json::Value =
        serde_json::from_str(&std::fs::read_to_string(c.run_dir.join("engine.json")).unwrap())
            .unwrap();
    assert_eq!(jb["generation"], 5);
    assert_eq!(
        jb["history"], jc["history"],
        "engine.json history must match"
    );
    assert_eq!(
        jb["robustness"], jc["robustness"],
        "engine.json robustness must match"
    );
    // B's gen snapshots continue the numbering from the frontier.
    assert!(b.run_dir.join("improvements").join("gen_3.json").exists());
    assert!(b.run_dir.join("improvements").join("gen_4.json").exists());
    assert!(
        !b.run_dir.join("improvements").join("gen_0.json").exists(),
        "no gen re-run below the frontier"
    );

    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&a.options.results_dir);
    let _ = std::fs::remove_dir_all(&b.options.results_dir);
    let _ = std::fs::remove_dir_all(&c.options.results_dir);
}

#[test]
fn test_resume_requires_checkpoint() {
    let data_dir = temp_data_dir();
    let dir = std::env::temp_dir().join(format!("gras_no_ckpt_{}", fastrand::u64(..)));
    std::fs::create_dir_all(&dir).unwrap();
    let opts = EngineOptions {
        resume_from: Some(dir.clone()),
        ..test_options()
    };
    let res = Engine::new(
        opts,
        Fitness::new(mse_scorer(), Direction::Minimize, "mse"),
        test_trainer(),
    );
    assert!(
        res.is_err(),
        "resume from a dir without checkpoint.json must fail"
    );
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&dir);
}

#[test]
fn test_resume_and_prior_topology_are_exclusive() {
    let res = EngineOptions::builder()
        .set_pop_size(4)
        .set_num_generations(1)
        .set_selection(SelectionMethod::Tournament { tournament_size: 2 })
        .set_crossover(CrossoverMethod::OnePoint { action_prob: 0.5 })
        .set_mutation(MutationMethod::Activation { prob: 0.1 })
        .set_resume_from("results/some_run")
        .set_prior_topology("results/some_run/engine.json")
        .build();
    assert!(res.is_err(), "resume + prior topology must be rejected");
    // resume alone is fine at build time (existence is checked at Engine::new).
    let ok = EngineOptions::builder()
        .set_pop_size(4)
        .set_num_generations(1)
        .set_selection(SelectionMethod::Tournament { tournament_size: 2 })
        .set_crossover(CrossoverMethod::OnePoint { action_prob: 0.5 })
        .set_mutation(MutationMethod::Activation { prob: 0.1 })
        .set_resume_from("results/some_run")
        .build();
    assert!(ok.is_ok());
}

#[test]
fn test_fitness_custom_sees_pred_and_target() {
    let data_dir = temp_data_dir();
    let fitness = Fitness::new(
        |pred, y| Ok(flodl::l1_loss(pred, y)?.item()? as f32),
        Direction::Minimize,
        "l1",
    );
    let opts = EngineOptions {
        num_generations: Some(1),
        ..test_options()
    };
    let mut engine = Engine::new(opts.clone(), fitness, test_trainer()).unwrap();
    engine.run().unwrap();
    assert!(!engine.scores().is_empty());
    let _ = std::fs::remove_dir_all(&data_dir);
    let _ = std::fs::remove_dir_all(&opts.results_dir);
}

// test_engine_from_loss_with_diff removed — Fitness no longer has train_metric

#[test]
fn test_hidden_dim_stride() {
    let mut rng = fastrand::Rng::with_seed(42);
    // stride=16, pool 32..=64 → {32, 48, 64}
    let pool = 32..=64usize;
    let stride = 16;
    let mut seen = std::collections::HashSet::new();
    for _ in 0..200 {
        let v = Engine::sample_hidden_dim(&pool, stride, &mut rng);
        seen.insert(v);
        assert!(v >= 32 && v <= 64, "out of range: {v}");
        assert!((v - 32) % 16 == 0, "not on stride: {v}");
    }
    assert_eq!(seen, std::collections::HashSet::from([32, 48, 64]));

    // stride=1, pool 4..=8 → {4,5,6,7,8}
    let pool2 = 4..=8usize;
    let mut seen2 = std::collections::HashSet::new();
    for _ in 0..200 {
        seen2.insert(Engine::sample_hidden_dim(&pool2, 1, &mut rng));
    }
    assert_eq!(seen2, std::collections::HashSet::from([4, 5, 6, 7, 8]));

    // stride=16, pool 50..=100 → {50, 66, 82, 98}
    let pool3 = 50..=100usize;
    let mut seen3 = std::collections::HashSet::new();
    for _ in 0..200 {
        let v = Engine::sample_hidden_dim(&pool3, 16, &mut rng);
        seen3.insert(v);
        assert!((v - 50) % 16 == 0, "not on stride: {v}");
    }
    assert_eq!(seen3, std::collections::HashSet::from([50, 66, 82, 98]));
}