graphrag-core 0.2.0

Core portable library for GraphRAG - works on native and WASM
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
//! Query validation and verification for ROGRAG system
//!
//! Provides comprehensive validation of queries and responses to ensure
//! quality, safety, and appropriateness.

#[cfg(feature = "rograg")]
use crate::rograg::RogragResponse;
#[cfg(feature = "rograg")]
use crate::Result;
#[cfg(feature = "rograg")]
use serde::{Deserialize, Serialize};
#[cfg(feature = "rograg")]
use strum::{Display as StrumDisplay, EnumString};
#[cfg(feature = "rograg")]
use thiserror::Error;

/// Error types for validation
#[cfg(feature = "rograg")]
#[derive(Error, Debug)]
pub enum ValidationError {
    /// Query failed validation checks before processing.
    #[error("Query validation failed: {reason}")]
    QueryValidationFailed {
        /// Description of the validation failure.
        reason: String,
    },

    /// Generated response failed validation checks.
    #[error("Response validation failed: {reason}")]
    ResponseValidationFailed {
        /// Description of the validation failure.
        reason: String,
    },

    /// Content violates safety guidelines.
    #[error("Content safety violation: {violation_type}")]
    SafetyViolation {
        /// Type of safety violation detected.
        violation_type: String,
    },

    /// Response quality metrics below acceptable thresholds.
    #[error("Quality threshold not met: {metric} = {value}, required >= {threshold}")]
    QualityThresholdNotMet {
        /// Name of the quality metric that failed.
        metric: String,
        /// Actual value of the metric.
        value: f32,
        /// Required minimum threshold.
        threshold: f32,
    },
}

/// Configuration for validation behavior and thresholds.
///
/// Controls which validation checks are enabled and sets quality thresholds
/// for query and response validation.
#[cfg(feature = "rograg")]
#[derive(Debug, Clone)]
pub struct ValidationConfig {
    /// Enable validation of queries before processing.
    pub enable_query_validation: bool,
    /// Enable validation of responses after generation.
    pub enable_response_validation: bool,
    /// Enable safety checks for inappropriate content.
    pub enable_safety_checks: bool,
    /// Enable quality checks for response completeness and coherence.
    pub enable_quality_checks: bool,
    /// Minimum confidence threshold for acceptable responses (range: 0.0-1.0).
    pub min_confidence_threshold: f32,
    /// Maximum allowed response length in characters.
    pub max_response_length: usize,
    /// Minimum required response length in characters.
    pub min_response_length: usize,
    /// Enable coherence checking for logical flow.
    pub enable_coherence_check: bool,
    /// Enable relevance checking between query and response.
    pub enable_relevance_check: bool,
    /// Enable factual consistency checking within responses.
    pub enable_factual_consistency_check: bool,
}

#[cfg(feature = "rograg")]
impl Default for ValidationConfig {
    fn default() -> Self {
        Self {
            enable_query_validation: true,
            enable_response_validation: true,
            enable_safety_checks: true,
            enable_quality_checks: true,
            min_confidence_threshold: 0.3,
            max_response_length: 4096,
            min_response_length: 10,
            enable_coherence_check: true,
            enable_relevance_check: true,
            enable_factual_consistency_check: true,
        }
    }
}

/// Result of validation containing validity status and detailed metrics.
///
/// Provides comprehensive feedback on validation checks including
/// any issues found and quality metrics computed.
#[cfg(feature = "rograg")]
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ValidationResult {
    /// Whether the query or response passed all critical validation checks.
    pub is_valid: bool,
    /// Overall validation score (range: 0.0-1.0).
    pub validation_score: f32,
    /// List of validation issues found during checking.
    pub issues: Vec<ValidationIssue>,
    /// Recommended actions to improve quality.
    pub recommendations: Vec<String>,
    /// Detailed quality metrics for the validated content.
    pub quality_metrics: QualityMetrics,
}

/// A specific validation issue found during checking.
///
/// Describes a single problem identified during validation
/// with categorization and actionable recommendations.
#[cfg(feature = "rograg")]
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ValidationIssue {
    /// Category of the validation issue.
    pub issue_type: IssueType,
    /// Severity level of the issue.
    pub severity: IssueSeverity,
    /// Human-readable description of the issue.
    pub description: String,
    /// Optional recommendation for resolving the issue.
    pub recommendation: Option<String>,
}

/// Category of validation issue.
///
/// Classifies validation problems into distinct types
/// for filtering and reporting.
#[cfg(feature = "rograg")]
#[derive(Debug, Clone, StrumDisplay, EnumString, Serialize, Deserialize)]
pub enum IssueType {
    /// Content safety violations.
    Safety,
    /// Overall quality problems.
    Quality,
    /// Logical flow and coherence issues.
    Coherence,
    /// Query-response relevance mismatches.
    Relevance,
    /// Content length violations.
    Length,
    /// Low confidence scores.
    Confidence,
    /// Factual consistency problems.
    Consistency,
    /// Format or structure issues.
    Format,
}

/// Severity level of validation issue.
///
/// Indicates the importance and urgency of addressing
/// a validation problem.
#[cfg(feature = "rograg")]
#[derive(Debug, Clone, StrumDisplay, EnumString, Serialize, Deserialize)]
pub enum IssueSeverity {
    /// Minor issue, suggestion only.
    Low,
    /// Notable issue, should be addressed.
    Medium,
    /// Serious issue, requires attention.
    High,
    /// Critical issue, blocks processing.
    Critical,
}

/// Comprehensive quality metrics for validated content.
///
/// Provides numerical scores across multiple quality dimensions
/// for detailed assessment of response quality.
#[cfg(feature = "rograg")]
#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub struct QualityMetrics {
    /// Logical flow and coherence score (range: 0.0-1.0).
    pub coherence_score: f32,
    /// Query-response relevance score (range: 0.0-1.0).
    pub relevance_score: f32,
    /// Internal factual consistency score (range: 0.0-1.0).
    pub factual_consistency_score: f32,
    /// Response completeness score (range: 0.0-1.0).
    pub completeness_score: f32,
    /// Text readability score (range: 0.0-1.0).
    pub readability_score: f32,
    /// Source credibility score (range: 0.0-1.0).
    pub source_credibility_score: f32,
}

/// Query validator implementation
#[cfg(feature = "rograg")]
pub struct QueryValidator {
    config: ValidationConfig,
    safety_patterns: Vec<regex::Regex>,
    quality_checks: Vec<Box<dyn QualityCheck>>,
    coherence_checker: CoherenceChecker,
    relevance_checker: RelevanceChecker,
}

/// Trait for implementing custom quality checks.
///
/// Allows extensible quality validation by implementing
/// specialized checks for different quality aspects.
#[cfg(feature = "rograg")]
pub trait QualityCheck: Send + Sync {
    /// Perform the quality check on a response.
    fn check(&self, response: &RogragResponse) -> Result<QualityCheckResult>;
    /// Get the name of this quality check.
    fn name(&self) -> &str;
}

/// Result of a single quality check.
///
/// Contains pass/fail status, numerical score, and any
/// issues identified during the check.
#[cfg(feature = "rograg")]
#[derive(Debug, Clone)]
pub struct QualityCheckResult {
    /// Whether the quality check passed.
    pub passed: bool,
    /// Numerical quality score (range: 0.0-1.0).
    pub score: f32,
    /// List of validation issues found.
    pub issues: Vec<ValidationIssue>,
}

#[cfg(feature = "rograg")]
impl Default for QueryValidator {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(feature = "rograg")]
impl QueryValidator {
    /// Create a new query validator
    pub fn new() -> Self {
        Self::with_config(ValidationConfig::default())
    }

    /// Create a new query validator with custom configuration
    pub fn with_config(config: ValidationConfig) -> Self {
        let mut validator = Self {
            config,
            safety_patterns: vec![],
            quality_checks: vec![],
            coherence_checker: CoherenceChecker::new(),
            relevance_checker: RelevanceChecker::new(),
        };

        validator
            .initialize_safety_patterns()
            .expect("static safety patterns");
        validator.initialize_quality_checks();
        validator
    }

    /// Initialize safety patterns
    fn initialize_safety_patterns(&mut self) -> Result<()> {
        if self.config.enable_safety_checks {
            self.safety_patterns = vec![
                regex::Regex::new(r"\b(?:harm|violence|illegal|inappropriate|offensive)\b")?,
                regex::Regex::new(r"\b(?:hate|discrimination|bias|prejudice)\b")?,
                regex::Regex::new(r"\b(?:private|confidential|secret|classified)\b")?,
                // Add more safety patterns as needed
            ];
        }
        Ok(())
    }

    /// Initialize quality checks
    fn initialize_quality_checks(&mut self) {
        if self.config.enable_quality_checks {
            self.quality_checks.push(Box::new(LengthCheck::new(
                self.config.min_response_length,
                self.config.max_response_length,
            )));
            self.quality_checks.push(Box::new(ConfidenceCheck::new(
                self.config.min_confidence_threshold,
            )));
            self.quality_checks
                .push(Box::new(SourceCredibilityCheck::new()));
            self.quality_checks.push(Box::new(CompletenessCheck::new()));
        }
    }

    /// Validate a query before processing
    pub fn validate_query(&self, query: &str) -> Result<ValidationResult> {
        if !self.config.enable_query_validation {
            return Ok(ValidationResult {
                is_valid: true,
                validation_score: 1.0,
                issues: vec![],
                recommendations: vec![],
                quality_metrics: QualityMetrics::default(),
            });
        }

        let mut issues = Vec::new();

        // Check query length
        if query.trim().is_empty() {
            issues.push(ValidationIssue {
                issue_type: IssueType::Length,
                severity: IssueSeverity::Critical,
                description: "Query is empty".to_string(),
                recommendation: Some("Please provide a non-empty query".to_string()),
            });
        } else if query.len() > 1000 {
            issues.push(ValidationIssue {
                issue_type: IssueType::Length,
                severity: IssueSeverity::Medium,
                description: "Query is very long".to_string(),
                recommendation: Some(
                    "Consider shortening your query for better results".to_string(),
                ),
            });
        } else {
            // Query length is acceptable
        }

        // Safety checks
        if self.config.enable_safety_checks {
            for pattern in &self.safety_patterns {
                if pattern.is_match(&query.to_lowercase()) {
                    issues.push(ValidationIssue {
                        issue_type: IssueType::Safety,
                        severity: IssueSeverity::High,
                        description: "Query contains potentially inappropriate content".to_string(),
                        recommendation: Some(
                            "Please rephrase your query appropriately".to_string(),
                        ),
                    });
                    break;
                }
            }
        }

        // Check for basic structure
        if !query.contains(char::is_alphabetic) {
            issues.push(ValidationIssue {
                issue_type: IssueType::Format,
                severity: IssueSeverity::High,
                description: "Query contains no alphabetic characters".to_string(),
                recommendation: Some("Please provide a text-based query".to_string()),
            });
        }

        let has_critical_issues = issues
            .iter()
            .any(|i| matches!(i.severity, IssueSeverity::Critical));
        let validation_score = if has_critical_issues {
            0.0
        } else {
            1.0 - (issues.len() as f32 * 0.1).min(0.8)
        };

        Ok(ValidationResult {
            is_valid: !has_critical_issues,
            validation_score,
            issues,
            recommendations: vec![],
            quality_metrics: QualityMetrics::default(),
        })
    }

    /// Validate a response after generation
    pub fn validate_response(&self, response: &RogragResponse) -> Result<RogragResponse> {
        if !self.config.enable_response_validation {
            return Ok(response.clone());
        }

        let mut issues = Vec::new();
        let mut quality_metrics = QualityMetrics::default();

        // Run quality checks
        for check in &self.quality_checks {
            let result = check.check(response)?;
            if !result.passed {
                issues.extend(result.issues);
            }
        }

        // Coherence check
        if self.config.enable_coherence_check {
            let coherence_result = self.coherence_checker.check_coherence(response)?;
            quality_metrics.coherence_score = coherence_result.score;
            if !coherence_result.passed {
                issues.extend(coherence_result.issues);
            }
        }

        // Relevance check
        if self.config.enable_relevance_check {
            let relevance_result = self.relevance_checker.check_relevance(response)?;
            quality_metrics.relevance_score = relevance_result.score;
            if !relevance_result.passed {
                issues.extend(relevance_result.issues);
            }
        }

        // Factual consistency check
        if self.config.enable_factual_consistency_check {
            let consistency_score = self.check_factual_consistency(response)?;
            quality_metrics.factual_consistency_score = consistency_score;
            if consistency_score < 0.5 {
                issues.push(ValidationIssue {
                    issue_type: IssueType::Consistency,
                    severity: IssueSeverity::Medium,
                    description: "Response may contain factual inconsistencies".to_string(),
                    recommendation: Some("Verify information with additional sources".to_string()),
                });
            }
        }

        // Safety check on response content
        if self.config.enable_safety_checks {
            for pattern in &self.safety_patterns {
                if pattern.is_match(&response.content.to_lowercase()) {
                    issues.push(ValidationIssue {
                        issue_type: IssueType::Safety,
                        severity: IssueSeverity::High,
                        description: "Response contains potentially inappropriate content"
                            .to_string(),
                        recommendation: Some(
                            "Response should be reviewed before delivery".to_string(),
                        ),
                    });
                    break;
                }
            }
        }

        // Calculate overall quality metrics
        quality_metrics.completeness_score = self.calculate_completeness_score(response);
        quality_metrics.readability_score = self.calculate_readability_score(response);
        quality_metrics.source_credibility_score =
            self.calculate_source_credibility_score(response);

        let overall_quality = self.overall_quality(&quality_metrics);

        if overall_quality < 0.5 {
            issues.push(ValidationIssue {
                issue_type: IssueType::Quality,
                severity: IssueSeverity::Medium,
                description: format!(
                    "Overall response quality below threshold (score: {overall_quality:.2})"
                ),
                recommendation: Some(
                    "Refine prompt or retrieve additional sources to raise quality".to_string(),
                ),
            });
        }

        // Create validated response and fold quality into its confidence
        let mut validated_response = response.clone();
        validated_response.confidence =
            (validated_response.confidence * overall_quality).clamp(0.0, 1.0);

        // Apply any necessary modifications based on validation results
        if issues
            .iter()
            .any(|i| matches!(i.severity, IssueSeverity::Critical))
        {
            // For critical issues, modify the response
            validated_response.content = "I apologize, but I cannot provide a response to this query due to safety or quality concerns.".to_string();
            validated_response.confidence = 0.0;
            validated_response.is_refusal = true;
        }

        tracing::debug!(
            overall_quality,
            coherence = quality_metrics.coherence_score,
            relevance = quality_metrics.relevance_score,
            factual = quality_metrics.factual_consistency_score,
            completeness = quality_metrics.completeness_score,
            readability = quality_metrics.readability_score,
            source_credibility = quality_metrics.source_credibility_score,
            issue_count = issues.len(),
            "rograg validation summary"
        );

        Ok(validated_response)
    }

    /// Average of the quality dimensions that were actually computed.
    fn overall_quality(&self, m: &QualityMetrics) -> f32 {
        let mut total = 0.0_f32;
        let mut count = 0_u32;
        let mut accumulate = |enabled: bool, score: f32| {
            if enabled {
                total += score;
                count += 1;
            }
        };
        accumulate(self.config.enable_coherence_check, m.coherence_score);
        accumulate(self.config.enable_relevance_check, m.relevance_score);
        accumulate(
            self.config.enable_factual_consistency_check,
            m.factual_consistency_score,
        );
        // Completeness/readability/source credibility are always computed.
        total += m.completeness_score + m.readability_score + m.source_credibility_score;
        count += 3;
        if count == 0 {
            1.0
        } else {
            (total / count as f32).clamp(0.0, 1.0)
        }
    }

    /// Check factual consistency
    fn check_factual_consistency(&self, response: &RogragResponse) -> Result<f32> {
        // Simple heuristic: check for contradictions within the response
        let sentences: Vec<&str> = response.content.split(['.', '!', '?']).collect();

        // Look for obvious contradictions
        let mut contradiction_count = 0;
        let contradiction_patterns = [
            ("not", "is"),
            ("never", "always"),
            ("none", "all"),
            ("impossible", "possible"),
        ];

        for sentence in &sentences {
            let sentence_lower = sentence.to_lowercase();
            for (neg, pos) in &contradiction_patterns {
                if sentence_lower.contains(neg) && sentence_lower.contains(pos) {
                    contradiction_count += 1;
                }
            }
        }

        // Simple scoring based on contradiction density
        let max_contradictions = sentences.len().max(1);
        let consistency_score =
            1.0 - (contradiction_count as f32 / max_contradictions as f32).min(1.0);

        Ok(consistency_score)
    }

    /// Calculate completeness score
    fn calculate_completeness_score(&self, response: &RogragResponse) -> f32 {
        // Heuristic based on response length, source count, and subquery coverage
        let length_score = if response.content.len() > 100 {
            1.0
        } else {
            response.content.len() as f32 / 100.0
        };
        let source_score = if response.sources.len() > 2 {
            1.0
        } else {
            response.sources.len() as f32 / 2.0
        };
        let subquery_score = if response.subquery_results.len() > 1 {
            1.0
        } else {
            response.subquery_results.len() as f32
        };

        (length_score + source_score + subquery_score) / 3.0
    }

    /// Calculate readability score
    fn calculate_readability_score(&self, response: &RogragResponse) -> f32 {
        let text = &response.content;
        let word_count = text.split_whitespace().count();
        let sentence_count = text
            .chars()
            .filter(|&c| c == '.' || c == '!' || c == '?')
            .count()
            .max(1);

        // Simple readability heuristic
        let avg_words_per_sentence = word_count as f32 / sentence_count as f32;
        let avg_word_length =
            text.chars().filter(|c| c.is_alphabetic()).count() as f32 / word_count.max(1) as f32;

        // Score based on reasonable sentence and word lengths
        let sentence_score = if avg_words_per_sentence > 30.0 {
            0.5
        } else {
            1.0
        };
        let word_score = if avg_word_length > 8.0 { 0.7 } else { 1.0 };

        (sentence_score + word_score) / 2.0
    }

    /// Calculate source credibility score
    fn calculate_source_credibility_score(&self, response: &RogragResponse) -> f32 {
        if response.sources.is_empty() {
            return 0.0;
        }

        // Simple heuristic: more sources = higher credibility, up to a point
        let source_count_score = (response.sources.len() as f32 / 5.0).min(1.0);

        // Check for source diversity (simple heuristic)
        let unique_source_prefixes: std::collections::HashSet<String> = response
            .sources
            .iter()
            .map(|s| s.chars().take(10).collect())
            .collect();
        let diversity_score = unique_source_prefixes.len() as f32 / response.sources.len() as f32;

        (source_count_score + diversity_score) / 2.0
    }

    /// Get configuration
    pub fn get_config(&self) -> &ValidationConfig {
        &self.config
    }

    /// Update configuration
    pub fn update_config(&mut self, config: ValidationConfig) -> Result<()> {
        self.config = config;
        self.initialize_safety_patterns()?;
        self.quality_checks.clear();
        self.initialize_quality_checks();
        Ok(())
    }
}

/// Length check implementation
#[cfg(feature = "rograg")]
pub struct LengthCheck {
    min_length: usize,
    max_length: usize,
}

#[cfg(feature = "rograg")]
impl LengthCheck {
    /// Creates a new length check with specified minimum and maximum bounds.
    ///
    /// # Arguments
    ///
    /// * `min_length` - Minimum acceptable response length in characters
    /// * `max_length` - Maximum acceptable response length in characters
    pub fn new(min_length: usize, max_length: usize) -> Self {
        Self {
            min_length,
            max_length,
        }
    }
}

#[cfg(feature = "rograg")]
impl QualityCheck for LengthCheck {
    fn check(&self, response: &RogragResponse) -> Result<QualityCheckResult> {
        let length = response.content.len();
        let mut issues = Vec::new();

        if length < self.min_length {
            issues.push(ValidationIssue {
                issue_type: IssueType::Length,
                severity: IssueSeverity::Medium,
                description: format!("Response too short: {length} characters"),
                recommendation: Some("Response should be more detailed".to_string()),
            });
        }

        if length > self.max_length {
            issues.push(ValidationIssue {
                issue_type: IssueType::Length,
                severity: IssueSeverity::Medium,
                description: format!("Response too long: {length} characters"),
                recommendation: Some("Response should be more concise".to_string()),
            });
        }

        let score = if issues.is_empty() { 1.0 } else { 0.5 };

        Ok(QualityCheckResult {
            passed: issues.is_empty(),
            score,
            issues,
        })
    }

    fn name(&self) -> &str {
        "length_check"
    }
}

/// Confidence check implementation
#[cfg(feature = "rograg")]
pub struct ConfidenceCheck {
    min_confidence: f32,
}

#[cfg(feature = "rograg")]
impl ConfidenceCheck {
    /// Creates a new confidence check with the specified minimum threshold.
    ///
    /// # Arguments
    ///
    /// * `min_confidence` - Minimum acceptable confidence score (range: 0.0-1.0)
    pub fn new(min_confidence: f32) -> Self {
        Self { min_confidence }
    }
}

#[cfg(feature = "rograg")]
impl QualityCheck for ConfidenceCheck {
    fn check(&self, response: &RogragResponse) -> Result<QualityCheckResult> {
        let mut issues = Vec::new();

        if response.confidence < self.min_confidence {
            issues.push(ValidationIssue {
                issue_type: IssueType::Confidence,
                severity: IssueSeverity::High,
                description: format!("Low confidence: {:.2}", response.confidence),
                recommendation: Some("Consider gathering more information".to_string()),
            });
        }

        Ok(QualityCheckResult {
            passed: issues.is_empty(),
            score: response.confidence,
            issues,
        })
    }

    fn name(&self) -> &str {
        "confidence_check"
    }
}

/// Source credibility check implementation
#[cfg(feature = "rograg")]
pub struct SourceCredibilityCheck;

#[cfg(feature = "rograg")]
impl Default for SourceCredibilityCheck {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(feature = "rograg")]
impl SourceCredibilityCheck {
    /// Creates a new source credibility check with default configuration.
    pub fn new() -> Self {
        Self
    }
}

#[cfg(feature = "rograg")]
impl QualityCheck for SourceCredibilityCheck {
    fn check(&self, response: &RogragResponse) -> Result<QualityCheckResult> {
        let mut issues = Vec::new();

        if response.sources.is_empty() {
            issues.push(ValidationIssue {
                issue_type: IssueType::Quality,
                severity: IssueSeverity::Medium,
                description: "No sources provided".to_string(),
                recommendation: Some("Response should cite sources".to_string()),
            });
        }

        let score = if response.sources.is_empty() {
            0.0
        } else {
            0.8
        };

        Ok(QualityCheckResult {
            passed: !response.sources.is_empty(),
            score,
            issues,
        })
    }

    fn name(&self) -> &str {
        "source_credibility_check"
    }
}

/// Completeness check implementation
#[cfg(feature = "rograg")]
pub struct CompletenessCheck;

#[cfg(feature = "rograg")]
impl Default for CompletenessCheck {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(feature = "rograg")]
impl CompletenessCheck {
    /// Creates a new completeness check with default configuration.
    pub fn new() -> Self {
        Self
    }
}

#[cfg(feature = "rograg")]
impl QualityCheck for CompletenessCheck {
    fn check(&self, response: &RogragResponse) -> Result<QualityCheckResult> {
        let mut issues = Vec::new();

        // Check if response addresses the query
        let query_lower = response.query.to_lowercase();
        let answer_lower = response.content.to_lowercase();

        let query_words: std::collections::HashSet<&str> = query_lower
            .split_whitespace()
            .filter(|w| w.len() > 3) // Filter out short words
            .collect();

        let answer_words: std::collections::HashSet<&str> =
            answer_lower.split_whitespace().collect();

        let overlap = query_words.intersection(&answer_words).count();
        let relevance = if query_words.is_empty() {
            1.0
        } else {
            overlap as f32 / query_words.len() as f32
        };

        if relevance < 0.3 {
            issues.push(ValidationIssue {
                issue_type: IssueType::Relevance,
                severity: IssueSeverity::Medium,
                description: "Response may not fully address the query".to_string(),
                recommendation: Some("Ensure response directly answers the question".to_string()),
            });
        }

        Ok(QualityCheckResult {
            passed: relevance >= 0.3,
            score: relevance,
            issues,
        })
    }

    fn name(&self) -> &str {
        "completeness_check"
    }
}

/// Coherence checker
#[cfg(feature = "rograg")]
pub struct CoherenceChecker;

#[cfg(feature = "rograg")]
impl Default for CoherenceChecker {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(feature = "rograg")]
impl CoherenceChecker {
    /// Creates a new coherence checker with default configuration.
    pub fn new() -> Self {
        Self
    }

    /// Checks the logical flow and coherence of a response.
    ///
    /// Analyzes the response content for logical flow indicators such as
    /// connecting words and smooth transitions between ideas.
    ///
    /// # Arguments
    ///
    /// * `response` - The ROGRAG response to check for coherence
    ///
    /// # Returns
    ///
    /// A quality check result with coherence score and any identified issues
    pub fn check_coherence(&self, response: &RogragResponse) -> Result<QualityCheckResult> {
        let mut issues = Vec::new();

        // Simple coherence check: look for logical flow
        let sentences: Vec<&str> = response.content.split(['.', '!', '?']).collect();

        // Check for abrupt topic changes (very simple heuristic)
        let mut coherence_score = 1.0;

        if sentences.len() > 1 {
            // Look for connecting words that indicate good flow
            let connectors = [
                "however",
                "therefore",
                "furthermore",
                "additionally",
                "meanwhile",
                "consequently",
            ];
            let connector_count = sentences
                .iter()
                .filter(|s| connectors.iter().any(|c| s.to_lowercase().contains(c)))
                .count();

            coherence_score = (connector_count as f32 / sentences.len() as f32).min(1.0);

            if coherence_score < 0.3 {
                issues.push(ValidationIssue {
                    issue_type: IssueType::Coherence,
                    severity: IssueSeverity::Low,
                    description: "Response may lack logical flow".to_string(),
                    recommendation: Some(
                        "Consider improving transitions between ideas".to_string(),
                    ),
                });
            }
        }

        Ok(QualityCheckResult {
            passed: coherence_score >= 0.3,
            score: coherence_score,
            issues,
        })
    }
}

/// Relevance checker
#[cfg(feature = "rograg")]
pub struct RelevanceChecker;

#[cfg(feature = "rograg")]
impl Default for RelevanceChecker {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(feature = "rograg")]
impl RelevanceChecker {
    /// Creates a new relevance checker with default configuration.
    pub fn new() -> Self {
        Self
    }

    /// Checks the relevance between query and response.
    ///
    /// Analyzes semantic relevance by computing word overlap between
    /// the query and response using Jaccard similarity.
    ///
    /// # Arguments
    ///
    /// * `response` - The ROGRAG response to check for relevance
    ///
    /// # Returns
    ///
    /// A quality check result with relevance score and any identified issues
    pub fn check_relevance(&self, response: &RogragResponse) -> Result<QualityCheckResult> {
        let mut issues = Vec::new();

        // Check semantic relevance between query and answer
        let query_lower = response.query.to_lowercase();
        let answer_lower = response.content.to_lowercase();

        let query_words: Vec<&str> = query_lower.split_whitespace().collect();
        let answer_words: Vec<&str> = answer_lower.split_whitespace().collect();

        // Calculate word overlap
        let query_set: std::collections::HashSet<&str> = query_words.iter().copied().collect();
        let answer_set: std::collections::HashSet<&str> = answer_words.iter().copied().collect();

        let intersection = query_set.intersection(&answer_set).count();
        let union = query_set.union(&answer_set).count();

        let relevance_score = if union > 0 {
            intersection as f32 / union as f32
        } else {
            0.0
        };

        if relevance_score < 0.2 {
            issues.push(ValidationIssue {
                issue_type: IssueType::Relevance,
                severity: IssueSeverity::High,
                description: "Response appears unrelated to query".to_string(),
                recommendation: Some("Ensure response directly addresses the query".to_string()),
            });
        }

        Ok(QualityCheckResult {
            passed: relevance_score >= 0.2,
            score: relevance_score,
            issues,
        })
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::rograg::{
        IntentResult, ProcessingStats, QueryIntent, SubqueryResult, SubqueryResultType,
    };

    #[cfg(feature = "rograg")]
    fn create_test_response() -> RogragResponse {
        RogragResponse {
            query: "What is Entity Name?".to_string(),
            content: "Entity Name is a young boy character in Mark Twain's novels. He is adventurous and mischievous.".to_string(),
            confidence: 0.8,
            sources: vec!["source1".to_string(), "source2".to_string()],
            subquery_results: vec![
                SubqueryResult {
                    subquery: "What is Entity Name?".to_string(),
                    result_type: SubqueryResultType::LogicForm,
                    confidence: 0.8,
                    content: "Entity Name character info".to_string(),
                    sources: vec!["source1".to_string()],
                }
            ],
            intent_result: IntentResult {
                primary_intent: QueryIntent::Factual,
                secondary_intents: vec![],
                confidence: 0.8,
                should_refuse: false,
                refusal_reason: None,
                suggested_reformulation: None,
                complexity_score: 0.3,
            },
            processing_stats: ProcessingStats::default(),
            is_streaming: false,
            is_refusal: false,
        }
    }

    #[cfg(feature = "rograg")]
    #[test]
    fn test_query_validation_valid() {
        let validator = QueryValidator::new();
        let result = validator.validate_query("What is Entity Name?").unwrap();

        assert!(result.is_valid);
        assert!(result.validation_score > 0.8);
        assert!(result.issues.is_empty());
    }

    #[cfg(feature = "rograg")]
    #[test]
    fn test_query_validation_empty() {
        let validator = QueryValidator::new();
        let result = validator.validate_query("").unwrap();

        assert!(!result.is_valid);
        assert_eq!(result.validation_score, 0.0);
        assert!(!result.issues.is_empty());
    }

    #[cfg(feature = "rograg")]
    #[test]
    fn test_response_validation() {
        let validator = QueryValidator::new();
        let response = create_test_response();

        let validated = validator.validate_response(&response).unwrap();

        assert!(!validated.is_refusal);
        assert!(validated.confidence > 0.0);
    }

    #[cfg(feature = "rograg")]
    #[test]
    fn test_length_check() {
        let check = LengthCheck::new(10, 100);
        let response = create_test_response();

        let result = check.check(&response).unwrap();
        assert!(result.passed); // Should pass as the response is reasonable length
    }

    #[cfg(feature = "rograg")]
    #[test]
    fn test_confidence_check() {
        let check = ConfidenceCheck::new(0.5);
        let response = create_test_response();

        let result = check.check(&response).unwrap();
        assert!(result.passed); // Should pass as confidence is 0.8 > 0.5
    }

    #[cfg(feature = "rograg")]
    #[test]
    fn test_source_credibility_check() {
        let check = SourceCredibilityCheck::new();
        let response = create_test_response();

        let result = check.check(&response).unwrap();
        assert!(result.passed); // Should pass as response has sources
    }

    #[cfg(feature = "rograg")]
    #[test]
    fn test_coherence_check() {
        let checker = CoherenceChecker::new();
        let response = create_test_response();

        let result = checker.check_coherence(&response).unwrap();
        assert!(result.score >= 0.0);
    }

    #[cfg(feature = "rograg")]
    #[test]
    fn test_relevance_check() {
        let checker = RelevanceChecker::new();
        let response = create_test_response();

        let result = checker.check_relevance(&response).unwrap();
        assert!(result.score > 0.0); // Should have some relevance
    }

    #[cfg(feature = "rograg")]
    #[test]
    fn test_factual_consistency() {
        let validator = QueryValidator::new();
        let response = create_test_response();

        let consistency_score = validator.check_factual_consistency(&response).unwrap();
        assert!((0.0..=1.0).contains(&consistency_score));
    }
}