1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
// Copyright (c) 2024-2025 DeepGraph Inc.
// SPDX-License-Identifier: Apache-2.0
//
use std::collections::HashMap;
use crate::ast::ast::{DeleteStatement, Expression};
use crate::exec::write_stmt::data_stmt::DataStatementExecutor;
use crate::exec::write_stmt::{ExecutionContext, StatementExecutor};
use crate::exec::ExecutionError;
use crate::storage::{GraphCache, Node, Value};
use crate::txn::{state::OperationType, UndoOperation};
/// Executor for DELETE statements
pub struct DeleteExecutor {
statement: DeleteStatement,
}
impl DeleteExecutor {
/// Create a new DeleteExecutor
pub fn new(statement: DeleteStatement) -> Self {
Self { statement }
}
/// Check if a node matches a given pattern
fn node_matches_pattern(node: &Node, pattern: &crate::ast::ast::Node) -> bool {
// Check labels
if !pattern.labels.is_empty() {
// Node must have all labels from the pattern
for pattern_label in &pattern.labels {
if !node.labels.contains(pattern_label) {
return false;
}
}
}
// Check properties
if let Some(pattern_props) = &pattern.properties {
for prop in &pattern_props.properties {
let key = &prop.key;
// Get the property value from the node
let node_value = node.properties.get(key);
// For now, we'll do simple literal matching
// TODO: Support more complex expressions
match &prop.value {
Expression::Literal(lit) => {
// Convert the literal to a Value for comparison
let expected_value = match lit {
crate::ast::ast::Literal::String(s) => Value::String(s.clone()),
crate::ast::ast::Literal::Integer(i) => Value::Number(*i as f64),
crate::ast::ast::Literal::Float(f) => Value::Number(*f),
crate::ast::ast::Literal::Boolean(b) => Value::Boolean(*b),
crate::ast::ast::Literal::Null => Value::Null,
_ => {
log::warn!("Unsupported literal type in DELETE pattern");
return false;
}
};
if node_value != Some(&expected_value) {
return false;
}
}
_ => {
log::warn!(
"Complex property expressions in DELETE patterns not yet supported"
);
return false;
}
}
}
}
true
}
}
impl StatementExecutor for DeleteExecutor {
fn operation_type(&self) -> OperationType {
OperationType::Delete
}
fn operation_description(&self, context: &ExecutionContext) -> String {
let graph_name = context
.get_graph_name()
.unwrap_or_else(|_| "unknown".to_string());
let prefix = if self.statement.detach { "DETACH " } else { "" };
format!("{}DELETE nodes/edges in graph '{}'", prefix, graph_name)
}
}
impl DataStatementExecutor for DeleteExecutor {
fn execute_modification(
&self,
graph: &mut GraphCache,
context: &mut ExecutionContext,
) -> Result<(UndoOperation, usize), ExecutionError> {
let graph_name = context.get_graph_name()?;
let mut undo_operations = Vec::new();
let mut deleted_count = 0;
// Process each expression in DELETE statement
for expr in &self.statement.expressions {
match expr {
Expression::Pattern(pattern_expr) => {
// Handle pattern-based deletion (e.g., (c:Company {name: 'Google'}))
let pattern = &pattern_expr.pattern;
// For now, we only support simple node patterns, not full path patterns
if pattern.elements.len() == 1 {
if let crate::ast::ast::PatternElement::Node(node_pattern) =
&pattern.elements[0]
{
// Collect nodes that match the pattern
let node_ids_to_delete: Vec<String> = graph
.get_all_nodes()
.iter()
.filter(|node| Self::node_matches_pattern(node, node_pattern))
.map(|node| node.id.clone())
.collect();
// Delete matching nodes
for node_id in node_ids_to_delete {
// Get the node data before deleting it for undo
let node = if let Some(node) = graph.get_node(&node_id) {
node.clone()
} else {
log::error!("Node {} not found for deletion", node_id);
continue;
};
// Check for connected edges
let connected_edge_ids: Vec<String> = graph
.get_all_edges()
.iter()
.filter(|edge| {
edge.from_node == node_id || edge.to_node == node_id
})
.map(|edge| edge.id.clone())
.collect();
if self.statement.detach {
// DETACH DELETE: remove all connected edges first
for edge_id in connected_edge_ids {
// Get edge data before deleting for undo
let edge = if let Some(edge) = graph.get_edge(&edge_id) {
edge.clone()
} else {
log::error!("Edge {} not found for deletion", edge_id);
continue;
};
if let Err(e) = graph.remove_edge(&edge.id) {
log::error!(
"Failed to remove edge {} during DETACH DELETE: {}",
edge.id,
e
);
continue;
}
log::debug!(
"Removed edge {} during DETACH DELETE of node {}",
edge.id,
node_id
);
// Add undo operation for edge
undo_operations.push(UndoOperation::DeleteEdge {
graph_path: graph_name.clone(),
edge_id: edge.id.clone(),
deleted_edge: edge,
});
}
} else if !connected_edge_ids.is_empty() {
// Regular DELETE: cannot delete node with relationships
return Err(ExecutionError::RuntimeError(format!(
"Cannot delete node {} with relationships. Use DETACH DELETE to remove relationships first.",
node_id
)));
}
// Delete the node
if let Err(e) = graph.remove_node(&node_id) {
log::error!("Failed to delete node {}: {}", node_id, e);
continue;
}
log::debug!("Deleted node {} matching pattern", node_id);
deleted_count += 1;
// Add undo operation for node
undo_operations.push(UndoOperation::DeleteNode {
graph_path: graph_name.clone(),
node_id: node_id.clone(),
deleted_node: node,
});
}
} else if pattern.elements.len() == 3 {
// Handle edge patterns: (node)-[edge]->(node)
// TODO: Implement edge pattern matching
log::warn!("Edge pattern deletion not yet fully implemented");
}
} else {
log::warn!("Complex path patterns in DELETE not yet supported");
}
}
Expression::Variable(var) => {
// Delete nodes/edges identified by variable
let var_name = &var.name;
// First, collect nodes to delete
let node_ids_to_delete: Vec<String> = graph
.get_all_nodes()
.iter()
.filter(|node| node.id == *var_name || node.labels.contains(var_name))
.map(|node| node.id.clone())
.collect();
// Delete nodes
for node_id in node_ids_to_delete {
// Get the node data before deleting it for undo
let node = if let Some(node) = graph.get_node(&node_id) {
node.clone()
} else {
log::error!("Node {} not found for deletion", node_id);
continue;
};
// Check for connected edges
let connected_edge_ids: Vec<String> = graph
.get_all_edges()
.iter()
.filter(|edge| edge.from_node == node_id || edge.to_node == node_id)
.map(|edge| edge.id.clone())
.collect();
if self.statement.detach {
// DETACH DELETE: remove all connected edges first
for edge_id in connected_edge_ids {
// Get edge data before deleting for undo
let edge = if let Some(edge) = graph.get_edge(&edge_id) {
edge.clone()
} else {
log::error!("Edge {} not found for deletion", edge_id);
continue;
};
if let Err(e) = graph.remove_edge(&edge.id) {
log::error!(
"Failed to remove edge {} during DETACH DELETE: {}",
edge.id,
e
);
continue;
}
log::debug!(
"Removed edge {} during DETACH DELETE of node {}",
edge.id,
node_id
);
// Add undo operation for edge
undo_operations.push(UndoOperation::DeleteEdge {
graph_path: graph_name.clone(),
edge_id: edge.id.clone(),
deleted_edge: edge,
});
}
} else if !connected_edge_ids.is_empty() {
// Regular DELETE: cannot delete node with relationships
return Err(ExecutionError::RuntimeError(format!(
"Cannot delete node {} with relationships. Use DETACH DELETE to remove relationships first.",
node_id
)));
}
// Delete the node
if let Err(e) = graph.remove_node(&node_id) {
log::error!("Failed to delete node {}: {}", node_id, e);
continue;
}
log::debug!("Deleted node {}", node_id);
deleted_count += 1;
// Add undo operation for node
undo_operations.push(UndoOperation::DeleteNode {
graph_path: graph_name.clone(),
node_id: node_id.clone(),
deleted_node: node,
});
}
// Also look for edges to delete directly (when deleting edge variables)
let edge_ids_to_delete: Vec<String> = graph
.get_all_edges()
.iter()
.filter(|edge| edge.id == *var_name)
.map(|edge| edge.id.clone())
.collect();
for edge_id in edge_ids_to_delete {
// Get edge data before deleting for undo
let edge = if let Some(edge) = graph.get_edge(&edge_id) {
edge.clone()
} else {
log::error!("Edge {} not found for deletion", edge_id);
continue;
};
if let Err(e) = graph.remove_edge(&edge.id) {
log::error!("Failed to delete edge {}: {}", edge.id, e);
continue;
}
log::debug!("Deleted edge {}", edge.id);
deleted_count += 1;
// Add undo operation for edge
undo_operations.push(UndoOperation::DeleteEdge {
graph_path: graph_name.clone(),
edge_id: edge.id.clone(),
deleted_edge: edge,
});
}
}
_ => {
log::warn!(
"Complex expressions in DELETE not yet supported: {:?}",
expr
);
}
}
}
// Return the first undo operation if any
let undo_op =
undo_operations
.into_iter()
.next()
.unwrap_or_else(|| UndoOperation::DeleteNode {
graph_path: graph_name,
node_id: "no_operations".to_string(),
deleted_node: Node {
id: "no_operations".to_string(),
labels: vec![],
properties: HashMap::new(),
},
});
Ok((undo_op, deleted_count))
}
}