govctl 0.9.4

Project governance CLI for RFC, ADR, and Work Item management
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68

use super::{ensure_no_duplicates, ensure_work_item_id, invalid_state, validate_loop_id};
use crate::diagnostic::DiagnosticResult;
use crate::loop_state::{LoopRoundRecord, LoopRoundStatus};

pub(in crate::loop_state) fn validate_loop_round_record(
    record: &LoopRoundRecord,
) -> DiagnosticResult<()> {
    let round = &record.round_meta;
    validate_loop_id(&round.loop_id)?;
    if round.round_number == 0 {
        return Err(invalid_state(
            &round.loop_id,
            "loop round record round_number must be at least 1",
        ));
    }
    if round.max_rounds == 0 {
        return Err(invalid_state(
            &round.loop_id,
            "loop round record max_rounds must be at least 1",
        ));
    }
    if round.work.is_empty() {
        return Err(invalid_state(
            &round.loop_id,
            "loop round record work must not be empty",
        ));
    }
    ensure_no_duplicates(&round.work, "round.work", &round.loop_id)?;
    for work_id in &round.work {
        ensure_work_item_id(work_id, &round.loop_id)?;
    }
    ensure_non_empty_values(&record.summary.actions, "summary.actions", &round.loop_id)?;
    ensure_non_empty_values(
        &record.summary.changed_paths,
        "summary.changed_paths",
        &round.loop_id,
    )?;
    ensure_non_empty_values(
        &record.summary.verification,
        "summary.verification",
        &round.loop_id,
    )?;
    ensure_non_empty_values(&record.summary.blockers, "summary.blockers", &round.loop_id)?;
    ensure_non_empty_values(
        &record.summary.note_candidates,
        "summary.note_candidates",
        &round.loop_id,
    )?;
    if round.status == LoopRoundStatus::Closed && !record.has_required_summary_evidence() {
        return Err(invalid_state(
            &round.loop_id,
            "closed loop round record must include actions, changed_paths, and verification or blockers",
        ));
    }
    Ok(())
}

fn ensure_non_empty_values(values: &[String], field: &str, loop_id: &str) -> DiagnosticResult<()> {
    for value in values {
        if value.trim().is_empty() {
            return Err(invalid_state(
                loop_id,
                format!("loop round record {field} must not contain empty values"),
            ));
        }
    }
    Ok(())
}