govctl 0.17.0

Project governance CLI for RFC, ADR, and Work Item management
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204

use super::*;

// ============================================================================
// Accept Gate Tests (adr accept)
// ============================================================================

/// Accepting an ADR with no alternatives at all must fail.
#[test]
fn test_accept_blocked_without_alternatives() -> common::TestResult {
    let normalized =
        run_gate_commands(&[&["adr", "new", "Test ADR"], &["adr", "accept", "ADR-0001"]])?;

    assert_gate_error(&normalized, "accept without alternatives");
    assert_adr_gate_snapshot!(normalized);
    Ok(())
}

/// Accepting an ADR with only 1 alternative must fail (need at least 2).
#[test]
fn test_accept_blocked_with_only_one_alternative() -> common::TestResult {
    let normalized = run_gate_commands(&[
        &["adr", "new", "Test ADR"],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives",
            "--add",
            "Option A",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives[0]",
            "--tick",
            "accepted",
        ],
        &["adr", "accept", "ADR-0001"],
    ])?;

    assert_gate_error(&normalized, "accept with one alternative");
    assert_adr_gate_snapshot!(normalized);
    Ok(())
}

/// Accepting an ADR with 2 alternatives but none accepted must fail.
#[test]
fn test_accept_blocked_without_accepted() -> common::TestResult {
    let normalized = run_gate_commands(&[
        &["adr", "new", "Test ADR"],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives",
            "--add",
            "Option A",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives",
            "--add",
            "Option B",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives[0]",
            "--tick",
            "rejected",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives[1]",
            "--tick",
            "rejected",
        ],
        &["adr", "accept", "ADR-0001"],
    ])?;

    assert_gate_error(&normalized, "accept without accepted alternative");
    assert_adr_gate_snapshot!(normalized);
    Ok(())
}

/// `adr accept --force` bypasses alternatives-completeness gates.
#[test]
fn test_accept_force_bypasses_gates() -> common::TestResult {
    let normalized = run_gate_commands(&[
        &["adr", "new", "Test ADR"],
        // No alternatives, no decision - force should bypass all gates
        &["adr", "accept", "ADR-0001", "--force"],
        &["adr", "list"],
    ])?;

    assert_no_gate_error(&normalized, "forced accept");
    assert_adr_gate_snapshot!(normalized);
    Ok(())
}

/// A fully complete ADR (2 alts, 1 accepted, 1 rejected) can be accepted without --force.
#[test]
fn test_accept_succeeds_with_complete_adr() -> common::TestResult {
    let normalized = run_gate_commands(&[
        &["adr", "new", "Test ADR"],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "context",
            "--set",
            "We need to pick a storage layer.",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives",
            "--add",
            "Option A",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives",
            "--add",
            "Option B",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives[0]",
            "--tick",
            "accepted",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "alternatives[1]",
            "--tick",
            "rejected",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "decision",
            "--set",
            "We chose Option A.",
        ],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "consequences",
            "--set",
            "Faster reads, more memory.",
        ],
        &["adr", "accept", "ADR-0001"],
        &["adr", "list"],
    ])?;

    assert_no_gate_error(&normalized, "complete accept");
    assert_adr_gate_snapshot!(normalized);
    Ok(())
}

#[test]
fn test_accept_force_does_not_bypass_projection_ownership() -> common::TestResult {
    let normalized = run_gate_commands(&[
        &["adr", "new", "Test ADR"],
        &[
            "adr",
            "edit",
            "ADR-0001",
            "context",
            "--set",
            "### Options Considered",
        ],
        &["adr", "accept", "ADR-0001", "--force"],
        &["adr", "get", "ADR-0001", "status"],
    ])?;

    assert!(normalized.contains("error[E0307]"), "{normalized}");
    assert!(normalized.contains("content.context"), "{normalized}");
    assert!(
        normalized.contains("heading 'Options Considered'"),
        "{normalized}"
    );
    assert!(
        normalized.contains("$ govctl adr get ADR-0001 status\nproposed"),
        "{normalized}"
    );
    Ok(())
}