1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
//! Inside-out cloud discovery (uses AWS credentials to find unmapped assets).
#[cfg(feature = "cloud")]
use aws_config::{BehaviorVersion, SdkConfig};
#[cfg(feature = "cloud")]
use aws_sdk_ec2::Client as Ec2Client;
#[cfg(feature = "cloud")]
use aws_sdk_rds::Client as RdsClient;
#[cfg(feature = "cloud")]
use aws_sdk_route53::Client as Route53Client;
#[cfg(feature = "cloud")]
use aws_sdk_s3::Client as S3Client;
#[cfg(feature = "cloud")]
use gossan_core::{DiscoverySource, DomainTarget, HostTarget, ScanInput, Target};
#[cfg(feature = "cloud")]
use std::net::IpAddr;
#[cfg(feature = "cloud")]
use tracing::{error, info, warn};
/// Perform "Inside-Out" discovery by querying the AWS API for unmapped
/// assets. Uses the standard AWS credential chain (env vars,
/// `~/.aws/credentials`, IAM instance role).
///
/// Discovered assets are emitted directly via `ScanInput::emit_target`
///: the historical signature took an extra `out: &mut Vec<Target>`
/// buffer parameter that was retired when the streaming refactor
/// landed; the placeholder type after `&mut ` was deleted but the
/// signature wasn't fully fixed up, leaving the file uncompilable.
#[cfg(feature = "cloud")]
pub async fn discover_aws(input: &ScanInput) -> anyhow::Result<()> {
info!("starting inside-out cloud discovery for AWS");
let config = aws_config::defaults(BehaviorVersion::latest()).load().await;
discover_aws_with_config(input, &config).await
}
#[cfg(feature = "cloud")]
pub async fn discover_aws_with_config(input: &ScanInput, config: &SdkConfig) -> anyhow::Result<()> {
// 1. S3 Buckets
let s3 = S3Client::new(config);
match s3.list_buckets().send().await {
Ok(resp) => {
for bucket in resp.buckets() {
if let Some(name) = bucket.name() {
let domain = format!("{}.s3.amazonaws.com", name);
let target = Target::Domain(DomainTarget {
domain,
source: DiscoverySource::CloudDiscovery,
});
// Single emit, the duplicate `emit_target` at the
// call site was a leftover from the pre-streaming
// API where one push went to a local Vec and the
// other to the live channel. Now both are the same
// path so we'd be emitting every bucket twice.
input.emit_target(target).await;
}
}
}
Err(e) => {
// Adversarial: handle permission denied and rate limits gracefully
match e.as_service_error() {
Some(_) if e.to_string().contains("AccessDenied") => {
warn!("S3 list_buckets: Permission Denied. Skipping S3 inside-out discovery.");
}
Some(_)
if e.to_string().contains("Throttling")
|| e.to_string().contains("Rate exceeded") =>
{
error!("S3 list_buckets: Rate limited. AWS API is throttling requests.");
}
_ => warn!(
"S3 list_buckets failed: {}. credentials might be missing or invalid.",
e
),
}
}
}
// 2. EC2 Instances (Public/Private IPs)
let ec2 = Ec2Client::new(config);
match ec2.describe_instances().send().await {
Ok(resp) => {
for reservation in resp.reservations() {
for instance in reservation.instances() {
if let Some(ip) = instance.public_ip_address() {
if let Ok(parsed_ip) = ip.parse::<IpAddr>() {
let target = Target::Host(HostTarget {
ip: parsed_ip,
domain: instance.public_dns_name().map(String::from),
});
input.emit_target(target).await;
}
}
if let Some(ip) = instance.private_ip_address() {
if let Ok(parsed_ip) = ip.parse::<IpAddr>() {
let target = Target::Host(HostTarget {
ip: parsed_ip,
domain: instance.private_dns_name().map(String::from),
});
input.emit_target(target).await;
}
}
}
}
}
Err(e) => warn!("EC2 describe_instances failed: {}", e),
}
// 3. Route53 Zones/Records
let r53 = Route53Client::new(config);
match r53.list_hosted_zones().send().await {
Ok(resp) => {
for zone in resp.hosted_zones() {
let id = zone.id();
match r53
.list_resource_record_sets()
.hosted_zone_id(id)
.send()
.await
{
Ok(records) => {
for record in records.resource_record_sets() {
let name = record.name();
let target = Target::Domain(DomainTarget {
domain: name.trim_end_matches('.').to_string(),
source: DiscoverySource::CloudDiscovery,
});
input.emit_target(target).await;
}
}
Err(e) => warn!(
"Route53 list_resource_record_sets for zone {} failed: {}",
id, e
),
}
}
}
Err(e) => warn!("Route53 list_hosted_zones failed: {}", e),
}
// 4. RDS Instances
let rds = RdsClient::new(config);
match rds.describe_db_instances().send().await {
Ok(resp) => {
for db in resp.db_instances() {
if let Some(endpoint) = db.endpoint() {
if let Some(addr) = endpoint.address() {
let target = Target::Domain(DomainTarget {
domain: addr.to_string(),
source: DiscoverySource::CloudDiscovery,
});
input.emit_target(target).await;
}
}
}
}
Err(e) => warn!("RDS describe_db_instances failed: {}", e),
}
Ok(())
}
#[cfg(all(test, feature = "cloud"))]
mod tests {
use super::*;
use aws_sdk_s3::config::{Credentials, Region, SharedCredentialsProvider};
use hickory_resolver::TokioResolver;
use std::sync::Arc;
use tokio::sync::mpsc;
fn mock_scan_input() -> (ScanInput, mpsc::Receiver<Target>) {
// Streaming-API ScanInput. The pre-streaming literal-struct
// form (`targets: Vec<_>`, optional `live_tx`/`target_tx`)
// was retired; targets flow in via `target_rx` and the live
// channels are required, not optional.
let (target_tx, rx) = mpsc::channel(64);
let (in_tx, in_rx) = mpsc::channel::<Target>(64);
drop(in_tx); // no inbound seeds for these adversarial tests
let (live_tx, _live_rx) = mpsc::channel(64);
let input = ScanInput {
seed: "example.com".into(),
target_rx: tokio::sync::Mutex::new(in_rx),
live_tx,
target_tx,
resolver: Arc::new(
TokioResolver::builder_tokio()
.unwrap()
.build()
),
};
(input, rx)
}
#[tokio::test]
async fn test_aws_discovery_failure_modes() {
let (input, mut rx) = mock_scan_input();
// Adversarial Test: Connection Refused / Invalid Endpoint
let config = SdkConfig::builder()
.region(Region::new("us-east-1"))
// `credentials_provider` now takes a `SharedCredentialsProvider`
// wrapper. `Credentials::for_tests()` still produces a
// `Credentials`; wrap it explicitly.
.credentials_provider(SharedCredentialsProvider::new(Credentials::for_tests()))
.behavior_version(BehaviorVersion::latest())
.endpoint_url("http://localhost:1") // Guaranteed to fail
.build();
// discover_aws_with_config emits via input.emit_target now
// the historical `out: &mut Vec<Target>` parameter was removed
// when the streaming refactor replaced buffered fan-out with
// channel emission. We verify nothing was emitted by polling
// the channel rx instead.
let result = discover_aws_with_config(&input, &config).await;
assert!(
result.is_ok(),
"should not return error on API failures, just warn and continue"
);
assert!(
rx.try_recv().is_err(),
"no targets should reach the channel on a guaranteed-fail endpoint"
);
}
#[tokio::test]
async fn test_aws_discovery_partial_success_handling() {
let (input, _rx) = mock_scan_input();
// Adversarial Test: Empty responses should not cause issues.
// We can't easily mock the SDK responses without complex
// machinery, but we verify the code handles empty fields via
// `if let Some` and `for` loops. Documents the "Zero unwrap()"
// mandate.
let config = SdkConfig::builder()
.region(Region::new("us-east-1"))
// `credentials_provider` now takes a `SharedCredentialsProvider`
// wrapper. `Credentials::for_tests()` still produces a
// `Credentials`; wrap it explicitly.
.credentials_provider(SharedCredentialsProvider::new(Credentials::for_tests()))
.behavior_version(BehaviorVersion::latest())
.build();
// Will likely fail due to lack of real credentials in CI,
// which validates the "fail gracefully" requirement.
let _ = discover_aws_with_config(&input, &config).await;
}
}