god-graph 0.6.0-alpha

A graph-based LLM white-box optimization toolbox: topology validation, Lie group orthogonalization, tensor ring compression
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
//! Graph 核心实现
//!
//! 使用桶式邻接表(Bucket Adjacency List)和 Arena 分配器实现高性能图数据结构
//!
//! ## 内存布局说明
//!
//! 本实现采用**桶式邻接表**(Bucket Adjacency List)格式,而非传统 CSR(压缩稀疏行):
//!
//! | 特性 | 传统 CSR | 本实现(桶式邻接表) |
//! |------|----------|---------------------|
//! | 结构 | row_offsets + col_indices | `Vec<AdjBucket>`,每个 bucket 含独立 Vec |
//! | 增量更新 | ❌ 不支持(需 O(V+E) 重建) | ✅ O(1) 插入 |
//! | 空间效率 | ✅ 最优(无额外开销) | ⚠️ 略高(每节点一个 Vec 头) |
//! | 适用场景 | 静态图 | 动态图(频繁增删边) |
//!
//! 历史原因:早期代码使用 `CsrStorage` 命名,实际实现是桶式邻接表。
//! 为保持 API 稳定性,内部结构仍用此名,但文档已正名为**桶式邻接表**。

use core::fmt;

#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};

use crate::edge::{EdgeIndex, EdgeRef, EdgeStorage};
use crate::errors::{GraphError, GraphResult};
use crate::graph::traits::{GraphBase, GraphOps, GraphQuery};
use crate::node::{NodeIndex, NodeRef, NodeSlot};

/// 单个邻接桶,用于 O(1) 增量边插入
/// 使用 64 字节缓存行对齐,避免 false sharing
#[derive(Clone, Debug)]
#[repr(align(64))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub(crate) struct AdjBucket {
    neighbors: Vec<usize>,
    edge_indices: Vec<usize>,
    deleted_mask: Vec<u64>,
    deleted_count: usize,
    _padding: [u8; 8], // 确保 64 字节对齐
}

impl AdjBucket {
    fn new() -> Self {
        Self {
            neighbors: Vec::new(),
            edge_indices: Vec::new(),
            deleted_mask: Vec::new(),
            deleted_count: 0,
            _padding: [0; 8],
        }
    }

    #[inline]
    fn push(&mut self, target: usize, edge_idx: usize) {
        self.neighbors.push(target);
        self.edge_indices.push(edge_idx);
        let bit_idx = self.neighbors.len() - 1;
        let word_idx = bit_idx / 64;
        while self.deleted_mask.len() <= word_idx {
            self.deleted_mask.push(0);
        }
    }

    #[inline]
    fn mark_deleted(&mut self, pos: usize) {
        let word_idx = pos / 64;
        let bit = pos % 64;
        if word_idx < self.deleted_mask.len() {
            let mask = 1u64 << bit;
            if self.deleted_mask[word_idx] & mask == 0 {
                self.deleted_mask[word_idx] |= mask;
                self.deleted_count += 1;
            }
        }
    }

    #[inline]
    fn is_deleted(&self, pos: usize) -> bool {
        let word_idx = pos / 64;
        let bit = pos % 64;
        if word_idx >= self.deleted_mask.len() {
            return false;
        }
        self.deleted_mask[word_idx] & (1u64 << bit) != 0
    }

    #[inline]
    fn compact(&mut self) {
        if self.deleted_count == 0 {
            return;
        }
        let mut write_pos = 0;
        for read_pos in 0..self.neighbors.len() {
            if !self.is_deleted(read_pos) {
                if write_pos != read_pos {
                    self.neighbors[write_pos] = self.neighbors[read_pos];
                    self.edge_indices[write_pos] = self.edge_indices[read_pos];
                }
                write_pos += 1;
            }
        }
        self.neighbors.truncate(write_pos);
        self.edge_indices.truncate(write_pos);
        let words_needed = write_pos.div_ceil(64);
        self.deleted_mask.truncate(words_needed);
        for w in self.deleted_mask.iter_mut() {
            *w = 0;
        }
        self.deleted_count = 0;
    }

    #[inline]
    fn find(&self, target: usize) -> Option<usize> {
        self.neighbors
            .iter()
            .position(|&n| n == target)
            .filter(|&pos| !self.is_deleted(pos))
    }

    #[inline]
    fn len(&self) -> usize {
        self.neighbors.len() - self.deleted_count
    }

    #[inline]
    fn iter(&self) -> AdjBucketIter<'_> {
        AdjBucketIter {
            bucket: self,
            pos: 0,
        }
    }

    /// 获取有效邻居的快照(用于快照语义迭代器)
    #[inline]
    fn snapshot(&self) -> Vec<(usize, usize)> {
        self.iter().collect()
    }
}

/// 邻接桶迭代器
pub(crate) struct AdjBucketIter<'a> {
    bucket: &'a AdjBucket,
    pos: usize,
}

impl<'a> Iterator for AdjBucketIter<'a> {
    type Item = (usize, usize); // (target, edge_index)

    #[inline]
    fn next(&mut self) -> Option<Self::Item> {
        while self.pos < self.bucket.neighbors.len() {
            // 软件预取:预取下一批数据到 CPU 缓存(需要 nightly 特性)
            // 在稳定版 Rust 上使用 std::hint 或条件编译
            #[cfg(all(feature = "unstable", target_feature = "sse"))]
            {
                use core::arch::x86_64::_mm_prefetch;
                use core::arch::x86_64::_MM_HINT_T0;

                let prefetch_pos = self.pos + 4;
                if prefetch_pos < self.bucket.neighbors.len() {
                    // SAFETY: `_mm_prefetch` is a CPU hint instruction that doesn't modify memory.
                    // Pointers are derived from Vec which guarantees validity.
                    // Bounds are checked before this block (prefetch_pos < len).
                    unsafe {
                        _mm_prefetch(
                            self.bucket.neighbors.as_ptr().add(prefetch_pos) as *const i8,
                            _MM_HINT_T0,
                        );
                        _mm_prefetch(
                            self.bucket.edge_indices.as_ptr().add(prefetch_pos) as *const i8,
                            _MM_HINT_T0,
                        );
                    }
                }
            }

            let pos = self.pos;
            self.pos += 1;
            if !self.bucket.is_deleted(pos) {
                return Some((self.bucket.neighbors[pos], self.bucket.edge_indices[pos]));
            }
        }
        None
    }
}

/// 邻居迭代器(快照语义)
///
/// 在创建时捕获目标节点的 generation,迭代期间只返回该快照中的邻居
pub struct NeighborsIter {
    /// 原始邻居数据快照(target_idx, generation)
    snapshot: std::vec::IntoIter<(usize, u32)>,
}

impl NeighborsIter {
    pub(crate) fn new(snapshot: Vec<(usize, u32)>) -> Self {
        Self {
            snapshot: snapshot.into_iter(),
        }
    }
}

impl Iterator for NeighborsIter {
    type Item = NodeIndex;

    #[inline]
    fn next(&mut self) -> Option<Self::Item> {
        self.snapshot
            .next()
            .map(|(idx, generation)| NodeIndex::new(idx, generation))
    }
}

/// 关联边迭代器(快照语义)
///
/// 在创建时捕获边的 generation,迭代期间只返回该快照中的边
pub struct IncidentEdgesIter {
    /// 原始边数据快照(edge_idx, generation)
    snapshot: std::vec::IntoIter<(usize, u32)>,
}

impl IncidentEdgesIter {
    pub(crate) fn new(snapshot: Vec<(usize, u32)>) -> Self {
        Self {
            snapshot: snapshot.into_iter(),
        }
    }
}

impl Iterator for IncidentEdgesIter {
    type Item = EdgeIndex;

    #[inline]
    fn next(&mut self) -> Option<Self::Item> {
        self.snapshot
            .next()
            .map(|(idx, generation)| EdgeIndex::new(idx, generation))
    }
}

/// 邻接桶存储:桶式邻接表格式
///
/// ## 命名说明
///
/// 历史原因:早期代码使用 `CsrStorage` 命名,但实际实现是**桶式邻接表**(Bucket Adjacency List)。
/// 传统 CSR(压缩稀疏行)格式使用 `row_offsets + col_indices`,不支持 O(1) 增量更新。
/// 本实现使用 `Vec<AdjBucket>`,每个 bucket 含独立 `Vec`,支持 O(1) 插入和惰性删除。
///
/// 为保持 API 稳定性,保留 `CsrStorage` 别名,但推荐在新代码中使用 `AdjacencyBuckets`。
#[derive(Clone, Debug)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub(crate) struct AdjacencyBuckets {
    buckets: Vec<AdjBucket>,
    reverse_buckets: Vec<AdjBucket>,
    num_nodes: usize,
    needs_compact: bool,
}

/// 向后兼容别名
///
/// 历史原因:早期代码使用 `CsrStorage` 命名,但实际实现是桶式邻接表。
/// 为保持 API 稳定性保留此别名,但推荐在新代码中使用 `AdjacencyBuckets`。
#[deprecated(
    since = "0.3.1",
    note = "使用 AdjacencyBuckets 代替,命名更准确反映实现"
)]
#[allow(dead_code)]
pub(crate) type CsrStorage = AdjacencyBuckets;

impl AdjacencyBuckets {
    pub(crate) fn new() -> Self {
        let this = Self {
            buckets: Vec::new(),
            reverse_buckets: Vec::new(),
            num_nodes: 0,
            needs_compact: false,
        };
        // 验证空 Vec 的对齐(空指针 0 % 64 = 0,总是成立,但保留断言用于文档说明)
        debug_assert_eq!(
            this.buckets.as_ptr() as usize % 64,
            0,
            "buckets 初始对齐失败"
        );
        debug_assert_eq!(
            this.reverse_buckets.as_ptr() as usize % 64,
            0,
            "reverse_buckets 初始对齐失败"
        );
        this
    }

    /// 验证 buckets 的 64 字节对齐
    ///
    /// 使用运行时断言确保 Vec<AdjBucket> 的指针是 64 字节对齐的。
    /// AdjBucket 使用 #[repr(align(64))],但需要验证实际分配的对齐。
    ///
    /// ## Panics
    ///
    /// 如果对齐不正确会 panic,并输出详细的调试信息。
    #[inline]
    pub(crate) fn assert_aligned(&self) {
        let buckets_ptr = self.buckets.as_ptr() as usize;
        let reverse_ptr = self.reverse_buckets.as_ptr() as usize;
        assert_eq!(
            buckets_ptr % 64,
            0,
            "AdjacencyBuckets: buckets 未 64 字节对齐 (ptr={:#x}, mod={})",
            buckets_ptr,
            buckets_ptr % 64
        );
        assert_eq!(
            reverse_ptr % 64,
            0,
            "AdjacencyBuckets: reverse_buckets 未 64 字节对齐 (ptr={:#x}, mod={})",
            reverse_ptr,
            reverse_ptr % 64
        );
    }

    pub(crate) fn reserve(&mut self, nodes: usize, _edges: usize) {
        self.buckets.reserve(nodes);
        self.reverse_buckets.reserve(nodes);
        // 验证分配后的对齐
        self.assert_aligned();
    }

    fn ensure_capacity(&mut self, node_index: usize) {
        while self.buckets.len() <= node_index {
            self.buckets.push(AdjBucket::new());
        }
        while self.reverse_buckets.len() <= node_index {
            self.reverse_buckets.push(AdjBucket::new());
        }
        self.num_nodes = self.buckets.len();
        // 验证扩容后的对齐
        self.assert_aligned();
    }

    /// O(1) 添加边
    pub(crate) fn add_edge(&mut self, node_index: usize, target_index: usize, edge_index: usize) {
        self.ensure_capacity(node_index.max(target_index));
        self.buckets[node_index].push(target_index, edge_index);
        self.reverse_buckets[target_index].push(node_index, edge_index);
    }

    /// 标记边为已删除
    pub(crate) fn mark_edge_deleted(&mut self, node_index: usize, target_index: usize) {
        if let Some(pos) = self.buckets[node_index].find(target_index) {
            self.buckets[node_index].mark_deleted(pos);
            self.needs_compact = true;
        }
        if let Some(pos) = self.reverse_buckets[target_index].find(node_index) {
            self.reverse_buckets[target_index].mark_deleted(pos);
        }
    }

    pub(crate) fn compact(&mut self) {
        if !self.needs_compact {
            return;
        }
        for bucket in &mut self.buckets {
            bucket.compact();
        }
        for bucket in &mut self.reverse_buckets {
            bucket.compact();
        }
        self.needs_compact = false;
    }

    #[allow(dead_code)]
    pub(crate) fn neighbors_raw(&self, node_index: usize) -> impl Iterator<Item = usize> + '_ {
        self.buckets
            .get(node_index)
            .into_iter()
            .flat_map(|b| b.iter())
            .map(move |(target_idx, _)| target_idx)
    }

    #[allow(dead_code)]
    pub(crate) fn reverse_neighbors_raw(
        &self,
        node_index: usize,
    ) -> impl Iterator<Item = usize> + '_ {
        self.reverse_buckets
            .get(node_index)
            .into_iter()
            .flat_map(|b| b.iter())
            .map(move |(src_idx, _)| src_idx)
    }

    pub(crate) fn edge_indices_iter(&self, node_index: usize) -> impl Iterator<Item = usize> + '_ {
        self.buckets
            .get(node_index)
            .into_iter()
            .flat_map(|b| b.iter().map(|(_, ei)| ei))
    }

    /// 获取边索引的快照(用于快照语义迭代器)
    pub(crate) fn edge_indices_snapshot(&self, node_index: usize) -> Vec<usize> {
        self.edge_indices_iter(node_index).collect()
    }

    /// 获取邻居的快照(用于快照语义迭代器)
    pub(crate) fn neighbors_snapshot(&self, node_index: usize) -> Vec<(usize, usize)> {
        self.buckets
            .get(node_index)
            .map(|b| b.snapshot())
            .unwrap_or_default()
    }

    pub(crate) fn has_edge(&self, node_index: usize, target_index: usize) -> bool {
        self.buckets
            .get(node_index)
            .and_then(|b| b.find(target_index))
            .is_some()
    }

    pub(crate) fn degree(&self, node_index: usize) -> usize {
        self.buckets.get(node_index).map(|b| b.len()).unwrap_or(0)
    }

    pub(crate) fn in_degree(&self, node_index: usize) -> usize {
        self.reverse_buckets
            .get(node_index)
            .map(|b| b.len())
            .unwrap_or(0)
    }

    pub(crate) fn reverse_edge_indices_iter(
        &self,
        node_index: usize,
    ) -> impl Iterator<Item = usize> + '_ {
        self.reverse_buckets
            .get(node_index)
            .into_iter()
            .flat_map(|b| b.iter().map(|(_, ei)| ei))
    }

    pub(crate) fn clear(&mut self) {
        self.buckets.clear();
        self.reverse_buckets.clear();
        self.num_nodes = 0;
        self.needs_compact = false;
    }

    #[allow(dead_code)]
    pub(crate) fn num_nodes(&self) -> usize {
        self.num_nodes
    }
}

impl Default for AdjacencyBuckets {
    fn default() -> Self {
        Self::new()
    }
}

/// 图结构主实现
/// 使用缓存行对齐优化,减少 false sharing
#[derive(Clone)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(
    feature = "serde",
    serde(bound(
        serialize = "T: Serialize, E: Serialize",
        deserialize = "T: Deserialize<'de>, E: Deserialize<'de>"
    ))
)]
pub struct Graph<T, E> {
    nodes: Vec<NodeSlot<T>>,
    edges: Vec<EdgeStorage<E>>,
    csr: AdjacencyBuckets,
    node_count: usize,
    edge_count: usize,
    free_nodes: Vec<usize>,
    free_edges: Vec<usize>,
}

impl<T, E> fmt::Debug for Graph<T, E>
where
    T: fmt::Debug,
    E: fmt::Debug,
{
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("Graph")
            .field("node_count", &self.node_count)
            .field("edge_count", &self.edge_count)
            .finish()
    }
}

impl<T, E> Graph<T, E> {
    /// 创建新的有向图
    pub fn directed() -> Self {
        Self {
            nodes: Vec::new(),
            edges: Vec::new(),
            csr: AdjacencyBuckets::new(),
            node_count: 0,
            edge_count: 0,
            free_nodes: Vec::new(),
            free_edges: Vec::new(),
        }
    }

    /// 创建新的无向图
    pub fn undirected() -> Self {
        Self::directed()
    }

    /// 创建带预分配容量的有向图
    pub fn with_capacity(nodes: usize, edges: usize) -> Self {
        let mut graph = Self::directed();
        graph.reserve(nodes, edges);
        graph
    }

    /// 检查图是否为空
    #[inline]
    pub fn is_empty(&self) -> bool {
        self.node_count == 0
    }

    /// 清空图
    pub fn clear(&mut self) {
        self.nodes.clear();
        self.edges.clear();
        self.csr.clear();
        self.node_count = 0;
        self.edge_count = 0;
        self.free_nodes.clear();
        self.free_edges.clear();
    }

    /// 通过节点索引获取边数据
    pub fn get_edge_by_nodes(&self, from: NodeIndex, to: NodeIndex) -> GraphResult<&E> {
        for edge_idx in self.csr.edge_indices_iter(from.index()) {
            if edge_idx < self.edges.len() {
                let edge = &self.edges[edge_idx];
                if edge.is_occupied() && edge.target == to {
                    return edge
                        .data()
                        .ok_or(GraphError::EdgeNotFound { index: edge_idx });
                }
            }
        }
        Err(GraphError::EdgeNotFound { index: usize::MAX })
    }
}

impl<T, E> GraphBase for Graph<T, E> {
    type NodeData = T;
    type EdgeData = E;

    #[inline]
    fn node_count(&self) -> usize {
        self.node_count
    }

    #[inline]
    fn edge_count(&self) -> usize {
        self.edge_count
    }

    #[inline]
    fn contains_node(&self, index: NodeIndex) -> bool {
        if index.index() >= self.nodes.len() {
            return false;
        }
        let slot = &self.nodes[index.index()];
        slot.is_occupied() && slot.generation == index.generation()
    }

    #[inline]
    fn contains_edge(&self, index: EdgeIndex) -> bool {
        if index.index() >= self.edges.len() {
            return false;
        }
        let edge = &self.edges[index.index()];
        edge.is_occupied() && edge.generation == index.generation()
    }
}

impl<T, E> GraphQuery for Graph<T, E> {
    #[inline]
    fn get_node(&self, index: NodeIndex) -> GraphResult<&T> {
        if index.index() >= self.nodes.len() {
            return Err(GraphError::NodeNotFound {
                index: index.index(),
            });
        }
        let slot = &self.nodes[index.index()];
        if !slot.is_occupied() {
            return Err(GraphError::NodeNotFound {
                index: index.index(),
            });
        }
        if slot.generation != index.generation() {
            return Err(GraphError::NodeDeleted {
                index: index.index(),
                provided: index.generation(),
                current: slot.generation,
            });
        }
        slot.data().ok_or(GraphError::NodeNotFound {
            index: index.index(),
        })
    }

    #[inline]
    fn get_edge(&self, index: EdgeIndex) -> GraphResult<&E> {
        if index.index() >= self.edges.len() {
            return Err(GraphError::EdgeNotFound {
                index: index.index(),
            });
        }
        let edge = &self.edges[index.index()];
        if !edge.is_occupied() {
            return Err(GraphError::EdgeNotFound {
                index: index.index(),
            });
        }
        if edge.generation != index.generation() {
            return Err(GraphError::EdgeDeleted {
                index: index.index(),
                provided: index.generation(),
                current: edge.generation,
            });
        }
        edge.data().ok_or(GraphError::EdgeNotFound {
            index: index.index(),
        })
    }

    #[inline]
    fn edge_endpoints(&self, index: EdgeIndex) -> GraphResult<(NodeIndex, NodeIndex)> {
        if index.index() >= self.edges.len() {
            return Err(GraphError::EdgeNotFound {
                index: index.index(),
            });
        }
        let edge = &self.edges[index.index()];
        if !edge.is_occupied() {
            return Err(GraphError::EdgeNotFound {
                index: index.index(),
            });
        }
        if edge.generation != index.generation() {
            return Err(GraphError::EdgeDeleted {
                index: index.index(),
                provided: index.generation(),
                current: edge.generation,
            });
        }
        Ok((edge.source, edge.target))
    }

    /// 获取节点的邻居迭代器
    ///
    /// # 快照语义
    ///
    /// 迭代器在**创建时**捕获目标节点的邻居快照:
    /// - 返回的迭代器包含创建时的所有有效邻居
    /// - 迭代期间图的修改不会影响迭代器返回的内容
    /// - 如果邻居节点在迭代期间被删除,该节点会被跳过
    ///
    /// # 推荐用法
    ///
    /// ```
    /// # use god_gragh::prelude::*;
    /// # let mut graph = GraphBuilder::directed()
    /// #     .with_nodes(vec![1, 2, 3])
    /// #     .with_edges(vec![(0, 1, 1.0), (0, 2, 1.0)])
    /// #     .build().unwrap();
    /// # let node = graph.nodes().next().unwrap().index();
    /// // 安全:迭代器持有快照,迭代期间可以修改图
    /// for neighbor in graph.neighbors(node) {
    ///     println!("{:?}", graph[neighbor]);
    /// }
    /// ```
    #[inline]
    fn neighbors(&self, node: NodeIndex) -> impl Iterator<Item = NodeIndex> {
        let node_index = node.index();
        // 在创建时捕获邻居快照(包含 generation 信息)
        let snapshot: Vec<(usize, u32)> = self
            .csr
            .neighbors_snapshot(node_index)
            .into_iter()
            .map(|(target_idx, _edge_idx)| {
                let generation = self
                    .nodes
                    .get(target_idx)
                    .map(|n| n.generation)
                    .unwrap_or(0);
                (target_idx, generation)
            })
            .collect();
        NeighborsIter::new(snapshot)
    }

    /// 获取节点的关联边迭代器
    ///
    /// # 快照语义
    ///
    /// 迭代器在**创建时**捕获关联边的快照:
    /// - 返回的迭代器包含创建时的所有有效边
    /// - 迭代期间图的修改不会影响迭代器返回的内容
    /// - 如果边在迭代期间被删除,该边会被跳过
    ///
    /// # 推荐用法
    ///
    /// ```
    /// # use god_gragh::prelude::*;
    /// # let mut graph = GraphBuilder::directed()
    /// #     .with_nodes(vec![1, 2, 3])
    /// #     .with_edges(vec![(0, 1, 1.0), (0, 2, 1.0)])
    /// #     .build().unwrap();
    /// # let node = graph.nodes().next().unwrap().index();
    /// // 安全:迭代器持有快照,迭代期间可以修改图
    /// for edge_idx in graph.incident_edges(node) {
    ///     println!("{:?}", graph.get_edge(edge_idx).unwrap());
    /// }
    /// ```
    #[inline]
    fn incident_edges(&self, node: NodeIndex) -> impl Iterator<Item = EdgeIndex> {
        let node_index = node.index();
        // 在创建时捕获边索引快照(包含 generation 信息)
        let snapshot: Vec<(usize, u32)> = self
            .csr
            .edge_indices_snapshot(node_index)
            .into_iter()
            .map(|edge_idx| {
                let generation = self.edges.get(edge_idx).map(|e| e.generation).unwrap_or(0);
                (edge_idx, generation)
            })
            .collect();
        IncidentEdgesIter::new(snapshot)
    }

    #[inline]
    fn has_edge(&self, from: NodeIndex, to: NodeIndex) -> bool {
        self.csr.has_edge(from.index(), to.index())
    }

    #[inline]
    fn out_degree(&self, node: NodeIndex) -> GraphResult<usize> {
        if !self.contains_node(node) {
            return Err(GraphError::NodeNotFound {
                index: node.index(),
            });
        }
        Ok(self.csr.degree(node.index()))
    }

    #[inline]
    fn in_degree(&self, node: NodeIndex) -> GraphResult<usize> {
        if !self.contains_node(node) {
            return Err(GraphError::NodeNotFound {
                index: node.index(),
            });
        }
        Ok(self.csr.in_degree(node.index()))
    }

    #[inline]
    fn degree(&self, node: NodeIndex) -> GraphResult<usize> {
        let out_deg = self.out_degree(node)?;
        let in_deg = self.in_degree(node)?;
        Ok(out_deg + in_deg)
    }

    #[inline]
    fn nodes(&self) -> impl Iterator<Item = NodeRef<'_, T>> {
        self.nodes.iter().enumerate().filter_map(|(idx, slot)| {
            if slot.is_occupied() {
                Some(NodeRef::new(
                    NodeIndex::new(idx, slot.generation),
                    slot.data()?,
                ))
            } else {
                None
            }
        })
    }

    #[inline]
    fn edges(&self) -> impl Iterator<Item = EdgeRef<'_, E>> {
        self.edges.iter().enumerate().filter_map(|(idx, edge)| {
            if edge.is_occupied() {
                Some(EdgeRef::new(
                    EdgeIndex::new(idx, edge.generation),
                    edge.source,
                    edge.target,
                    edge.data()?,
                ))
            } else {
                None
            }
        })
    }
}

impl<T, E> GraphOps for Graph<T, E> {
    #[inline]
    fn add_node(&mut self, data: T) -> GraphResult<NodeIndex> {
        let (index, generation) = if let Some(free_idx) = self.free_nodes.pop() {
            let slot = &mut self.nodes[free_idx];
            let new_generation = slot.generation.wrapping_add(1);
            *slot = NodeSlot::new(new_generation, data);
            (free_idx, new_generation)
        } else {
            let index = self.nodes.len();
            let generation = 1u32;
            self.nodes.push(NodeSlot::new(generation, data));
            (index, generation)
        };

        self.node_count += 1;
        self.csr.ensure_capacity(index);
        Ok(NodeIndex::new(index, generation))
    }

    #[inline]
    fn remove_node(&mut self, index: NodeIndex) -> GraphResult<T> {
        if index.index() >= self.nodes.len() {
            return Err(GraphError::NodeNotFound {
                index: index.index(),
            });
        }

        let slot = &mut self.nodes[index.index()];
        if !slot.is_occupied() {
            return Err(GraphError::NodeNotFound {
                index: index.index(),
            });
        }
        if slot.generation != index.generation() {
            return Err(GraphError::NodeDeleted {
                index: index.index(),
                provided: index.generation(),
                current: slot.generation,
            });
        }

        // 删除出边
        let edge_indices: Vec<usize> = self.csr.edge_indices_iter(index.index()).collect();
        for edge_idx in edge_indices {
            if edge_idx < self.edges.len() {
                let edge = &self.edges[edge_idx];
                if edge.is_occupied() {
                    self.csr
                        .mark_edge_deleted(index.index(), edge.target.index());
                    let edge_slot = &mut self.edges[edge_idx];
                    edge_slot.data = None;
                    self.edge_count -= 1;
                    self.free_edges.push(edge_idx);
                }
            }
        }

        // 删除入边
        let incoming: Vec<usize> = self.csr.reverse_edge_indices_iter(index.index()).collect();
        for edge_idx in incoming {
            if edge_idx < self.edges.len() {
                let edge = &self.edges[edge_idx];
                if edge.is_occupied() {
                    self.csr
                        .mark_edge_deleted(edge.source.index(), index.index());
                    let edge_slot = &mut self.edges[edge_idx];
                    edge_slot.data = None;
                    self.edge_count -= 1;
                    self.free_edges.push(edge_idx);
                }
            }
        }

        self.csr.compact();

        let data = slot.data.take().ok_or(GraphError::NodeNotFound {
            index: index.index(),
        })?;
        self.node_count -= 1;
        self.free_nodes.push(index.index());

        Ok(data)
    }

    #[inline]
    fn add_edge(&mut self, from: NodeIndex, to: NodeIndex, data: E) -> GraphResult<EdgeIndex> {
        if !self.contains_node(from) {
            return Err(GraphError::NodeNotFound {
                index: from.index(),
            });
        }
        if !self.contains_node(to) {
            return Err(GraphError::NodeNotFound { index: to.index() });
        }

        let (index, generation) = if let Some(free_idx) = self.free_edges.pop() {
            let edge = &mut self.edges[free_idx];
            let new_generation = edge.generation.wrapping_add(1);
            *edge = EdgeStorage::new(from, to, data, new_generation);
            (free_idx, new_generation)
        } else {
            let index = self.edges.len();
            let generation = 1u32;
            self.edges
                .push(EdgeStorage::new(from, to, data, generation));
            (index, generation)
        };

        self.edge_count += 1;
        self.csr.add_edge(from.index(), to.index(), index);
        Ok(EdgeIndex::new(index, generation))
    }

    #[inline]
    fn remove_edge(&mut self, index: EdgeIndex) -> GraphResult<E> {
        if index.index() >= self.edges.len() {
            return Err(GraphError::EdgeNotFound {
                index: index.index(),
            });
        }

        let edge = &mut self.edges[index.index()];
        if !edge.is_occupied() {
            return Err(GraphError::EdgeNotFound {
                index: index.index(),
            });
        }
        if edge.generation != index.generation() {
            return Err(GraphError::EdgeDeleted {
                index: index.index(),
                provided: index.generation(),
                current: edge.generation,
            });
        }

        let source_index = edge.source.index();
        let target_index = edge.target.index();
        self.csr.mark_edge_deleted(source_index, target_index);

        let data = edge.data.take().ok_or(GraphError::EdgeNotFound {
            index: index.index(),
        })?;
        self.edge_count -= 1;
        self.free_edges.push(index.index());
        self.csr.compact();

        Ok(data)
    }

    #[inline]
    fn update_node(&mut self, index: NodeIndex, data: T) -> GraphResult<T> {
        if index.index() >= self.nodes.len() {
            return Err(GraphError::NodeNotFound {
                index: index.index(),
            });
        }

        let slot = &mut self.nodes[index.index()];
        if !slot.is_occupied() {
            return Err(GraphError::NodeNotFound {
                index: index.index(),
            });
        }
        if slot.generation != index.generation() {
            return Err(GraphError::NodeDeleted {
                index: index.index(),
                provided: index.generation(),
                current: slot.generation,
            });
        }

        let old_data = slot.data.replace(data);
        old_data.ok_or(GraphError::NodeNotFound {
            index: index.index(),
        })
    }

    #[inline]
    fn update_edge(&mut self, index: EdgeIndex, data: E) -> GraphResult<E> {
        if index.index() >= self.edges.len() {
            return Err(GraphError::EdgeNotFound {
                index: index.index(),
            });
        }

        let edge = &mut self.edges[index.index()];
        if !edge.is_occupied() {
            return Err(GraphError::EdgeNotFound {
                index: index.index(),
            });
        }
        if edge.generation != index.generation() {
            return Err(GraphError::EdgeDeleted {
                index: index.index(),
                provided: index.generation(),
                current: edge.generation,
            });
        }

        let old_data = edge.data.replace(data);
        old_data.ok_or(GraphError::EdgeNotFound {
            index: index.index(),
        })
    }

    #[inline]
    fn reserve(&mut self, additional_nodes: usize, additional_edges: usize) {
        self.nodes.reserve(additional_nodes);
        self.edges.reserve(additional_edges);
        self.csr.reserve(additional_nodes, additional_edges);
    }

    #[inline]
    fn clear(&mut self) {
        Graph::clear(self);
    }
}

impl<T, E> core::ops::Index<NodeIndex> for Graph<T, E> {
    type Output = T;

    #[inline]
    fn index(&self, index: NodeIndex) -> &Self::Output {
        self.get_node(index).expect("节点索引无效")
    }
}

/// # Safety
///
/// 此实现使用 `panic!` 而非 `Result`,因为 `IndexMut` trait 不允许返回 `Result`。
/// 对于需要安全访问的场景,请使用 `get_node_mut()` 方法。
///
/// # Panics
///
/// Panics if:
/// - 节点索引超出范围 (`index.index() >= self.nodes.len()`)
/// - 节点已被删除 (`slot.is_occupied() == false`)
/// - Generation 不匹配,索引已失效
///
/// # 示例
///
/// ```rust,should_panic
/// use god_gragh::graph::{Graph, traits::GraphOps};
///
/// let mut graph = Graph::<i32, f64>::directed();
/// let node = graph.add_node(42).unwrap();
/// graph.remove_node(node).unwrap();
///
/// // 这将 panic,因为节点已被删除
/// graph[node] = 100;
/// ```
impl<T, E> core::ops::IndexMut<NodeIndex> for Graph<T, E> {
    #[inline]
    fn index_mut(&mut self, index: NodeIndex) -> &mut Self::Output {
        if index.index() >= self.nodes.len() {
            panic!("节点索引无效:index={}", index.index());
        }
        let slot = &mut self.nodes[index.index()];
        if !slot.is_occupied() {
            panic!("节点索引无效:节点不存在");
        }
        if slot.generation != index.generation() {
            panic!("节点索引已失效:generation 不匹配");
        }
        slot.data.as_mut().expect("节点数据为空")
    }
}

impl<T, E> core::ops::Index<EdgeIndex> for Graph<T, E> {
    type Output = E;

    #[inline]
    fn index(&self, index: EdgeIndex) -> &Self::Output {
        self.get_edge(index).expect("边索引无效")
    }
}

/// # Safety
///
/// 此实现使用 `panic!` 而非 `Result`,因为 `IndexMut` trait 不允许返回 `Result`。
/// 对于需要安全访问的场景,请使用边数据可变访问方法。
///
/// # Panics
///
/// Panics if:
/// - 边索引超出范围 (`index.index() >= self.edges.len()`)
/// - 边已被删除 (`edge.is_occupied() == false`)
/// - Generation 不匹配,索引已失效
///
/// # 示例
///
/// ```
/// use god_gragh::graph::Graph;
/// use god_gragh::graph::traits::GraphOps;
///
/// let mut graph = Graph::directed();
/// let a = graph.add_node(1).unwrap();
/// let b = graph.add_node(2).unwrap();
/// let edge = graph.add_edge(a, b, 42.0).unwrap();
///
/// // 使用 IndexMut 修改边数据
/// graph[edge] = 100.0;
/// assert_eq!(graph[edge], 100.0);
/// ```
impl<T, E> core::ops::IndexMut<EdgeIndex> for Graph<T, E> {
    #[inline]
    fn index_mut(&mut self, index: EdgeIndex) -> &mut Self::Output {
        if index.index() >= self.edges.len() {
            panic!("边索引无效:index={}", index.index());
        }
        let edge = &mut self.edges[index.index()];
        if !edge.is_occupied() {
            panic!("边索引无效:边不存在");
        }
        if edge.generation != index.generation() {
            panic!("边索引已失效:generation 不匹配");
        }
        edge.data.as_mut().expect("边数据为空")
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_graph_creation() {
        let graph = Graph::<i32, f64>::directed();
        assert_eq!(graph.node_count(), 0);
        assert_eq!(graph.edge_count(), 0);
        assert!(graph.is_empty());
    }

    #[test]
    fn test_add_node() {
        let mut graph = Graph::<String, f64>::directed();
        let idx = graph.add_node("test".to_string()).unwrap();
        assert_eq!(graph.node_count(), 1);
        assert!(graph.contains_node(idx));
        assert_eq!(graph[idx], "test");
    }

    #[test]
    fn test_index_mut() {
        let mut graph = Graph::<String, f64>::directed();
        let idx = graph.add_node("initial".to_string()).unwrap();

        // 使用 IndexMut 修改节点数据
        graph[idx] = "modified".to_string();
        assert_eq!(graph[idx], "modified");

        // 修改多个节点
        let idx2 = graph.add_node("second".to_string()).unwrap();
        graph[idx2] = "second_modified".to_string();
        assert_eq!(graph[idx2], "second_modified");
    }

    #[test]
    fn test_remove_node() {
        let mut graph = Graph::<i32, f64>::directed();
        let idx = graph.add_node(42).unwrap();
        assert!(graph.contains_node(idx));

        let data = graph.remove_node(idx).unwrap();
        assert_eq!(data, 42);
        assert_eq!(graph.node_count(), 0);
        assert!(!graph.contains_node(idx));
    }

    #[test]
    fn test_add_edge() {
        let mut graph = Graph::<i32, f64>::directed();
        let a = graph.add_node(1).unwrap();
        let b = graph.add_node(2).unwrap();
        let edge = graph.add_edge(a, b, std::f64::consts::PI).unwrap();

        assert_eq!(graph.edge_count(), 1);
        assert!(graph.contains_edge(edge));
        assert_eq!(*graph.get_edge(edge).unwrap(), std::f64::consts::PI);
    }

    #[test]
    fn test_node_reuse() {
        let mut graph = Graph::<i32, f64>::directed();
        let idx1 = graph.add_node(1).unwrap();
        let _ = graph.remove_node(idx1).unwrap();
        let idx2 = graph.add_node(2).unwrap();

        assert_eq!(idx2.index(), idx1.index());
        assert!(idx2.generation() > idx1.generation());
    }

    #[test]
    fn test_neighbors() {
        let mut graph = Graph::<i32, f64>::directed();
        let a = graph.add_node(1).unwrap();
        let b = graph.add_node(2).unwrap();
        let c = graph.add_node(3).unwrap();
        graph.add_edge(a, b, 1.0).unwrap();
        graph.add_edge(a, c, 2.0).unwrap();

        let neighbors: Vec<_> = graph.neighbors(a).collect();
        assert_eq!(neighbors.len(), 2);
    }

    #[test]
    fn test_has_edge() {
        let mut graph = Graph::<i32, f64>::directed();
        let a = graph.add_node(1).unwrap();
        let b = graph.add_node(2).unwrap();
        graph.add_edge(a, b, 1.0).unwrap();

        assert!(graph.has_edge(a, b));
        assert!(!graph.has_edge(b, a));
    }
}