gitflow-gitlab 2.0.0

gf 的 GitLab 适配器,基于 glab CLI 提供 Issue/MR/Release/Review 等能力。GitLab adapter for gf via glab CLI.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
//! GitLab 认证提供者实现。
//!
//! 通过 `glab auth` CLI 命令实现 [`AuthProvider`] trait,支持登录、
//! 登出、状态查询及 Token 管理。
//! 异步方法通过 [`CommandRunner`] 抽象调用 `glab`,测试可注入自定义 runner
//! 以模拟成功或失败场景。环境变量读取通过 [`EnvSource`] 参数抽象,生产环境
//! 默认使用 [`RealEnv`],测试可通过 `with_runner_and_env` 注入自定义实现。

use async_trait::async_trait;
use gitflow_cli_adapter_utils::{EnvSource, RealEnv};
use gitflow_core::{
    CoreError, Result,
    auth::{AuthProvider, AuthStatus, HostAuthStatus},
};
use tracing::debug;

use crate::{
    error::parse_glab_error,
    runner::{CommandRunner, RealCommandRunner},
};

/// GitLab 认证提供者,通过 `glab` CLI 操作认证。
///
/// 命令执行通过 [`CommandRunner`] 抽象,生产环境默认使用
/// [`RealCommandRunner`],测试可注入自定义 runner 以模拟成功或失败场景。
/// 环境变量读取通过 [`EnvSource`] 参数抽象,生产环境默认使用 [`RealEnv`],
/// 测试可通过 `with_runner_and_env` 注入自定义实现。
///
/// # Examples
///
/// ```no_run
/// use gitflow_gitlab::GitLabAuthProvider;
///
/// let provider = GitLabAuthProvider::new();
/// ```
#[derive(Debug, Clone)]
pub struct GitLabAuthProvider<R: CommandRunner = RealCommandRunner, E: EnvSource = RealEnv> {
    /// 用于执行 `glab` CLI 命令的 runner。
    runner: R,
    /// 环境变量来源,生产环境为进程环境,测试可注入。
    env: E,
}

impl GitLabAuthProvider<RealCommandRunner, RealEnv> {
    /// 创建新的 GitLab 认证提供者,使用真实的进程执行器与进程环境。
    #[must_use]
    pub fn new() -> Self {
        Self {
            runner: RealCommandRunner,
            env: RealEnv,
        }
    }

    /// Create a new provider from a shared [`Session`].
    ///
    /// `AuthProvider` doesn't use repository context, so session.repo is ignored.
    /// This enables state reuse across multiple operations in workflow chains.
    #[must_use]
    pub fn with_session(_session: &gitflow_core::Session) -> Self {
        Self {
            runner: RealCommandRunner,
            env: RealEnv,
        }
    }
}

impl<R: CommandRunner> GitLabAuthProvider<R, RealEnv> {
    /// 使用自定义 [`CommandRunner`] 创建提供者,环境变量仍取自进程环境。
    ///
    /// 主要用于测试,可注入模拟 runner 以控制 `glab` CLI 的输出。
    #[must_use]
    pub fn with_runner(runner: R) -> Self {
        Self {
            runner,
            env: RealEnv,
        }
    }
}

impl<R: CommandRunner, E: EnvSource> GitLabAuthProvider<R, E> {
    /// 同时注入自定义 [`CommandRunner`] 与 [`EnvSource`]。
    ///
    /// 测试应优先使用本构造函数:注入的环境变量来源使测试不依赖进程环境,
    /// 因而既不会被并行测试污染,也不受开发者 shell 中已导出变量的影响。
    #[must_use]
    pub fn with_runner_and_env(runner: R, env: E) -> Self {
        Self { runner, env }
    }
}

impl Default for GitLabAuthProvider<RealCommandRunner, RealEnv> {
    fn default() -> Self {
        Self::new()
    }
}

#[async_trait]
impl<R: CommandRunner + 'static, E: EnvSource + 'static> AuthProvider for GitLabAuthProvider<R, E> {
    async fn login(&self, token: Option<&str>) -> Result<()> {
        debug!("spawning `glab auth login`");

        // If token is provided, pass it via stdin to avoid exposing it in
        // process arguments (visible to other users via `ps`).
        let output = if let Some(token) = token {
            self.runner
                .run_with_stdin("glab", &["auth", "login", "--stdin"], token.as_bytes())
                .await
                .map_err(|e| CoreError::Platform(format!("Failed to spawn glab auth login: {e}")))?
        } else {
            self.runner
                .run("glab", &["auth", "login"])
                .await
                .map_err(|e| CoreError::Platform(format!("Failed to spawn glab auth login: {e}")))?
        };

        if !output.status.success() {
            return Err(parse_glab_error(&output.stderr).into());
        }

        Ok(())
    }

    async fn logout(&self) -> Result<()> {
        debug!("spawning `glab auth logout`");

        let output = self
            .runner
            .run("glab", &["auth", "logout"])
            .await
            .map_err(|e| CoreError::Platform(format!("Failed to spawn glab auth logout: {e}")))?;

        if !output.status.success() {
            return Err(parse_glab_error(&output.stderr).into());
        }

        Ok(())
    }

    async fn status(&self) -> Result<AuthStatus> {
        debug!("spawning `glab auth status`");

        let output = self
            .runner
            .run("glab", &["auth", "status"])
            .await
            .map_err(|e| CoreError::Platform(format!("Failed to spawn glab auth status: {e}")))?;

        let stdout = String::from_utf8_lossy(&output.stdout);
        let stderr = String::from_utf8_lossy(&output.stderr);
        let combined = format!("{stdout}{stderr}");

        let hosts = parse_hosts_from_status(&combined);

        if !hosts.is_empty() {
            let logged_in = hosts.iter().any(|h| h.logged_in);
            let user = hosts
                .iter()
                .find(|h| h.logged_in)
                .and_then(|h| h.user.clone());

            return Ok(AuthStatus {
                logged_in,
                user,
                scopes: vec![],
                hosts,
            });
        }

        if !output.status.success() {
            let text = combined.to_lowercase();
            if text.contains("not logged in")
                || text.contains("no active account")
                || text.contains("not authenticated")
            {
                return Ok(AuthStatus {
                    logged_in: false,
                    user: None,
                    scopes: vec![],
                    hosts: vec![],
                });
            }

            return Err(parse_glab_error(&output.stderr).into());
        }

        Ok(AuthStatus {
            logged_in: false,
            user: None,
            scopes: vec![],
            hosts: vec![],
        })
    }

    async fn token(&self) -> Result<String> {
        // 环境变量优先(与 AuthChecker::is_authenticated 一致)
        if let Some(tok) = self.env.var("GL_TOKEN") {
            return Ok(tok);
        }

        debug!("spawning `glab auth status --show-token`");

        let host = self.env.var("GITLAB_HOST");
        let mut args: Vec<&str> = vec!["auth", "status", "--show-token"];
        if let Some(ref h) = host {
            args.push("--hostname");
            args.push(h);
        }

        let output =
            self.runner.run("glab", &args).await.map_err(|e| {
                CoreError::Platform(format!("Failed to spawn glab auth status: {e}"))
            })?;

        if !output.status.success() {
            return Err(parse_glab_error(&output.stderr).into());
        }

        let stdout = String::from_utf8_lossy(&output.stdout);
        // glab writes the status block (including the `Token found ...` line) to
        // stderr even on success; parse both streams like `status()` does.
        let stderr = String::from_utf8_lossy(&output.stderr);
        let combined = format!("{stdout}{stderr}");
        combined
            .lines()
            .find_map(|line| {
                if line.contains("Token found") {
                    line.rsplit_once(": ").map(|(_, t)| t.trim().to_string())
                } else {
                    None
                }
            })
            .filter(|t| !t.is_empty())
            .ok_or_else(|| {
                CoreError::Platform("No GitLab token found (run `glab auth login`)".into())
            })
    }
}

// AuthChecker 是同步 trait,必须使用 std::process::Command
#[allow(clippy::disallowed_types, reason = "AuthChecker is synchronous")]
impl<R: CommandRunner, E: EnvSource> gitflow_core::AuthChecker for GitLabAuthProvider<R, E> {
    fn is_authenticated(&self) -> bool {
        if self.env.var("GL_TOKEN").is_some() {
            return true;
        }

        let output = std::process::Command::new("glab")
            .args(["auth", "status"])
            .output();

        matches!(output, Ok(out) if out.status.success())
    }

    fn check_status(&self) -> gitflow_core::AuthCheckResult {
        // 1. 检查环境变量
        if self.env.var("GL_TOKEN").is_some() {
            return gitflow_core::AuthCheckResult {
                authenticated: true,
                user: None,
                reason: None,
                hint: None,
            };
        }

        // 2. 执行 glab auth status
        let output = match std::process::Command::new("glab")
            .args(["auth", "status"])
            .output()
        {
            Ok(out) => out,
            Err(e) => {
                return gitflow_core::AuthCheckResult {
                    authenticated: false,
                    user: None,
                    reason: Some(format!("Failed to execute glab: {e}")),
                    hint: Some("Install GitLab CLI: brew install glab".into()),
                };
            }
        };

        // 3. 解析结果
        if output.status.success() {
            let stdout = String::from_utf8_lossy(&output.stdout);
            let user = parse_user_from_status(&stdout);

            gitflow_core::AuthCheckResult {
                authenticated: true,
                user,
                reason: None,
                hint: None,
            }
        } else {
            let stderr = String::from_utf8_lossy(&output.stderr);

            gitflow_core::AuthCheckResult {
                authenticated: false,
                user: None,
                reason: Some(stderr.to_string()),
                hint: Some("Run `glab auth login` to authenticate".into()),
            }
        }
    }
}

/// 把 `glab auth status` 的 stdout+stderr 合并文本解析为按 host 分组的状态。
///
/// `glab` 对每个已配置 host 输出一个不含空白的裸行作为 host 标识
/// (如 `gitlab.com`、`192.168.230.23`),紧随其后是若干缩进的状态行。
/// 要求该裸行包含 `.`(域名或 IPv4 的共同特征),避免把单个单词的通用
/// 错误信息(如 `unauthorized`)误判成一个"host",从而掩盖真实的平台错误。
/// 无法识别出任何 host 行时返回空 `Vec`,由调用方回退到旧的整段文本判断。
fn parse_hosts_from_status(output: &str) -> Vec<HostAuthStatus> {
    let mut hosts = Vec::new();
    let mut current: Option<HostAuthStatus> = None;

    for line in output.lines() {
        let is_header = !line.starts_with(' ') && !line.starts_with('\t');
        let trimmed = line.trim();

        if is_header && !trimmed.is_empty() && !trimmed.contains(' ') && trimmed.contains('.') {
            if let Some(host) = current.take() {
                hosts.push(host);
            }
            current = Some(HostAuthStatus {
                host: trimmed.to_string(),
                logged_in: false,
                user: None,
            });
            continue;
        }

        if let Some(ref mut host) = current
            && trimmed.contains("Logged in to")
        {
            host.logged_in = true;
            host.user = parse_user_from_status(trimmed);
        }
    }

    if let Some(host) = current.take() {
        hosts.push(host);
    }

    hosts
}

fn parse_user_from_status(output: &str) -> Option<String> {
    for line in output.lines() {
        if let Some(pos) = line.find(" as ") {
            let after_as = &line[pos + 4..];
            if let Some(end) = after_as.find(' ') {
                let user = &after_as[..end];
                if !user.is_empty() {
                    return Some(user.to_string());
                }
            } else if !after_as.is_empty() {
                return Some(after_as.trim().to_string());
            }
        }
    }
    None
}

#[cfg(test)]
mod tests {
    use gitflow_cli_adapter_utils::MockEnv;

    use super::*;
    use crate::runner::MockCommandRunner;

    /// Build a provider whose environment is empty, so tests never depend on
    /// what the host shell exported.
    fn mock_provider(runner: MockCommandRunner) -> GitLabAuthProvider<MockCommandRunner, MockEnv> {
        GitLabAuthProvider::with_runner_and_env(runner, MockEnv::empty())
    }

    #[tokio::test]
    async fn test_should_short_circuit_token_when_env_var_present() {
        // 语义回归护栏:GL_TOKEN 命中时必须优先于 CLI 调用。
        let runner = MockCommandRunner::success("  ✓ Token found in keyring: glpat-from-cli\n");
        let provider = GitLabAuthProvider::with_runner_and_env(
            runner.clone(),
            MockEnv::with("GL_TOKEN", "glpat-from-env"),
        );

        let token = provider.token().await.expect("should get token");

        assert_eq!(token, "glpat-from-env");
        assert!(
            runner.recorded_calls().is_empty(),
            "env short-circuit must not spawn glab"
        );
    }

    #[tokio::test]
    async fn test_should_append_hostname_arg_when_gitlab_host_present() {
        // 语义回归护栏:GITLAB_HOST 命中时追加 --hostname。
        let stdout = "  ✓ Token found in operating system keyring: glpat-abcdef\n";
        let runner = MockCommandRunner::success(stdout);
        let provider = GitLabAuthProvider::with_runner_and_env(
            runner.clone(),
            MockEnv::with("GITLAB_HOST", "gitlab.example.com"),
        );

        provider.token().await.expect("should get token");

        assert_eq!(
            runner.recorded_calls()[0].1,
            vec![
                "auth",
                "status",
                "--show-token",
                "--hostname",
                "gitlab.example.com"
            ]
            .into_iter()
            .map(String::from)
            .collect::<Vec<_>>()
        );
    }

    #[test]
    fn test_should_construct_gitlab_auth_provider() {
        let provider = GitLabAuthProvider::new();
        let debug = format!("{provider:?}");
        assert!(debug.contains("GitLabAuthProvider"));
    }

    #[test]
    fn test_should_default_gitlab_auth_provider() {
        let provider = GitLabAuthProvider::default();
        let _ = format!("{provider:?}");
    }

    #[test]
    fn test_should_clone_gitlab_auth_provider() {
        let original = GitLabAuthProvider::new();
        let cloned = original.clone();
        let _ = format!("{cloned:?}");
    }

    #[test]
    fn test_should_parse_user_from_status_output() {
        let status = r"gitlab.com
  ✓ Logged in to gitlab.com as root (keyring)
  ✓ Git operations for gitlab.com configured to use ssh protocol.
";
        assert_eq!(parse_user_from_status(status), Some("root".to_string()));
    }

    #[test]
    fn test_should_parse_user_from_status_with_different_host() {
        let status = r"gitlab.com
  ✓ Logged in to gitlab.com as alice (oauth_token)
  ✓ Token: glpat-****
";
        assert_eq!(parse_user_from_status(status), Some("alice".to_string()));
    }

    #[test]
    fn test_should_return_none_when_no_user_in_status() {
        let status = "No active account found";
        assert!(parse_user_from_status(status).is_none());
    }

    #[test]
    fn test_should_return_none_for_empty_status() {
        assert!(parse_user_from_status("").is_none());
    }

    #[test]
    fn test_should_parse_user_without_suffix() {
        let status = "Logged in to gitlab.com as bob";
        assert_eq!(parse_user_from_status(status), Some("bob".to_string()));
    }

    #[test]
    fn test_should_report_authenticated_when_token_env_var_present() {
        use gitflow_core::AuthChecker;
        // AuthChecker 同步分支直接调用 std::process::Command,不读取注入的 runner;
        // env 短路才是本测试确定性的来源。
        let provider = GitLabAuthProvider::with_runner_and_env(
            MockCommandRunner::success(""),
            MockEnv::with("GL_TOKEN", "test_token"),
        );
        assert!(provider.is_authenticated());
    }

    #[test]
    fn test_should_report_authenticated_status_without_reason_when_token_env_var_present() {
        use gitflow_core::AuthChecker;
        // AuthChecker 同步分支直接调用 std::process::Command,不读取注入的 runner;
        // env 短路才是本测试确定性的来源。
        let provider = GitLabAuthProvider::with_runner_and_env(
            MockCommandRunner::success(""),
            MockEnv::with("GL_TOKEN", "test_token"),
        );
        let result = provider.check_status();
        assert!(result.authenticated);
        assert!(result.reason.is_none());
        assert!(result.hint.is_none());
    }

    // --- Failure-path tests using an injected MockCommandRunner ---

    #[tokio::test]
    async fn test_should_return_platform_error_when_glab_fails_for_login() {
        let runner = MockCommandRunner::failure("authentication failed", 256);
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.login(Some("glpat-token")).await;

        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_glab_fails_for_logout() {
        let runner = MockCommandRunner::failure("not logged in", 256);
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.logout().await;

        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_logged_out_status_when_glab_reports_not_logged_in() {
        let runner = MockCommandRunner::failure("not logged in to any GitLab hosts", 256);
        let provider = GitLabAuthProvider::with_runner(runner);

        let status = provider.status().await.expect("graceful logged-out status");

        assert!(!status.logged_in);
        assert!(status.user.is_none());
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_status_fails_unexpectedly() {
        let runner = MockCommandRunner::failure("internal server error", 256);
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.status().await;

        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_glab_fails_for_token() {
        let runner = MockCommandRunner::failure("no token found", 256);
        let provider = mock_provider(runner);

        let result = provider.token().await;

        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_error_when_stdout_has_no_token_line() {
        let runner = MockCommandRunner::success("");
        let provider = mock_provider(runner);

        let result = provider.token().await;

        assert!(result.is_err());
    }

    // --- Success-path tests using an injected MockCommandRunner ---

    #[test]
    fn test_should_construct_with_custom_runner() {
        let runner = MockCommandRunner::success("");
        let provider = GitLabAuthProvider::with_runner(runner);
        let debug = format!("{provider:?}");
        assert!(debug.contains("GitLabAuthProvider"));
    }

    #[tokio::test]
    async fn test_should_login_interactively() {
        let runner = MockCommandRunner::success("");
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.login(None).await;

        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_should_login_with_token_via_stdin() {
        let runner = MockCommandRunner::success("");
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.login(Some("glpat-secret-token")).await;

        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_should_logout_successfully() {
        let runner = MockCommandRunner::success("");
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.logout().await;

        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_should_return_logged_in_status_when_authenticated() {
        let stdout = r"gitlab.com
  ✓ Logged in to gitlab.com as testuser (keyring)
  ✓ Git operations for gitlab.com configured to use ssh protocol.
";
        let runner = MockCommandRunner::success(stdout);
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.status().await;

        assert!(result.is_ok());
        let status = result.unwrap();
        assert!(status.logged_in);
        assert_eq!(status.user, Some("testuser".to_string()));
        assert!(status.scopes.is_empty());
        assert_eq!(status.hosts.len(), 1);
        assert_eq!(status.hosts[0].host, "gitlab.com");
    }

    #[tokio::test]
    async fn test_should_report_authenticated_when_any_host_logged_in_in_mixed_status() {
        let combined = "gitlab.com\n  ! No token found (checked config file, keyring, and \
                        environment variables).\n192.168.230.23\n  ✓ Logged in to 192.168.230.23 \
                        as baoyuexing (keyring)\n";
        let runner = MockCommandRunner::failure(combined, 1);
        let provider = GitLabAuthProvider::with_runner(runner);

        let status = provider
            .status()
            .await
            .expect("should not error on mixed host status");

        assert!(status.logged_in);
        assert_eq!(status.user, Some("baoyuexing".to_string()));
        assert_eq!(status.hosts.len(), 2);
        assert_eq!(status.hosts[0].host, "gitlab.com");
        assert!(!status.hosts[0].logged_in);
        assert_eq!(status.hosts[1].host, "192.168.230.23");
        assert!(status.hosts[1].logged_in);
        assert_eq!(status.hosts[1].user, Some("baoyuexing".to_string()));
    }

    #[tokio::test]
    async fn test_should_not_treat_single_word_error_line_as_host() {
        let runner = MockCommandRunner::failure("unauthorized", 1);
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.status().await;

        assert!(
            result.is_err(),
            "a bare single-word error line must not be parsed as a fake host (expected Err, got \
             {result:?})"
        );
    }

    #[tokio::test]
    async fn test_should_return_token_successfully() {
        let stdout = "  ✓ Token found in operating system keyring: glpat-test12345\n";
        let runner = MockCommandRunner::success(stdout);
        let provider = mock_provider(runner);

        let result = provider.token().await;

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), "glpat-test12345");
    }

    #[tokio::test]
    async fn test_should_trim_whitespace_from_token() {
        let stdout = "  ✓ Token found in keyring: glpat-test12345  \n\n";
        let runner = MockCommandRunner::success(stdout);
        let provider = mock_provider(runner);

        let result = provider.token().await;

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), "glpat-test12345");
    }

    #[tokio::test]
    async fn test_should_extract_token_from_auth_status_show_token() {
        let stdout = "192.168.230.23\n  ✓ Logged in to 192.168.230.23 as baoyuexing (keyring)\n  \
                      ✓ Token found in operating system keyring: glpat-abcdef\n";
        let runner = MockCommandRunner::success(stdout);
        let provider = mock_provider(runner.clone());

        let token = provider.token().await.expect("should get token");

        assert_eq!(token, "glpat-abcdef");
        assert_eq!(
            runner.recorded_calls()[0].1,
            vec!["auth", "status", "--show-token"]
                .into_iter()
                .map(String::from)
                .collect::<Vec<_>>()
        );
    }

    #[tokio::test]
    async fn test_should_extract_token_from_stderr_like_real_glab() {
        // `glab auth status --show-token` writes the status block (including the
        // `Token found ...` line) to stderr while exiting 0. Regression test for
        // the real self-hosted GitLab smoke test (Issue #199).
        let stderr = "192.168.230.23\n  ✓ Logged in to 192.168.230.23 as baoyuexing (keyring)\n  \
                      ✓ Token found in operating system keyring: glpat-abcdef\n";
        let runner = MockCommandRunner::success_with_stderr("", stderr);
        let provider = mock_provider(runner);

        let token = provider
            .token()
            .await
            .expect("should get token from stderr");

        assert_eq!(token, "glpat-abcdef");
    }

    #[tokio::test]
    async fn test_should_error_when_no_token_found() {
        let stdout =
            "  ! No token found (checked config file, keyring, and environment variables).\n";
        let runner = MockCommandRunner::success(stdout);
        let provider = mock_provider(runner);

        let result = provider.token().await;

        assert!(result.is_err());
    }

    // --- Spawn-error tests using an injected MockCommandRunner ---

    #[tokio::test]
    async fn test_should_return_platform_error_when_login_spawn_fails() {
        let runner = MockCommandRunner::spawn_error();
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.login(None).await;

        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Platform(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_login_with_token_spawn_fails() {
        let runner = MockCommandRunner::spawn_error();
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.login(Some("glpat-token")).await;

        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Platform(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_logout_spawn_fails() {
        let runner = MockCommandRunner::spawn_error();
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.logout().await;

        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Platform(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_status_spawn_fails() {
        let runner = MockCommandRunner::spawn_error();
        let provider = GitLabAuthProvider::with_runner(runner);

        let result = provider.status().await;

        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Platform(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_token_spawn_fails() {
        let runner = MockCommandRunner::spawn_error();
        let provider = mock_provider(runner);

        let result = provider.token().await;

        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Platform(_)
        ));
    }
}