gitflow-github 1.0.0

gf 的 GitHub 适配器,基于 gh CLI 提供 Issue/PR/Release/Review 等能力。GitHub adapter for gf via gh CLI.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
//! GitHub Release 提供者实现。
//!
//! 通过 `gh` CLI 实现 [`ReleaseProvider`] trait,支持 Release 的创建、列表、
//! 查看、编辑、资源上传/下载及删除。
//! 命令执行通过 [`CommandRunner`] 抽象,捕获 stdout 并解析 JSON。

use async_trait::async_trait;
use gitflow_core::{
    CoreError, Result,
    release::{CreateReleaseArgs, ReleaseData, ReleaseProvider},
};
use tracing::debug;

use crate::{
    error::parse_gh_error,
    runner::{CommandRunner, RealCommandRunner},
};

/// `gh release list` 请求的 JSON 字段列表。
const RELEASE_LIST_FIELDS: &str = "tagName,name,isDraft,isPrerelease,createdAt,publishedAt";

/// `gh release view` 请求的 JSON 字段列表。
const RELEASE_VIEW_FIELDS: &str =
    "databaseId,tagName,name,body,isDraft,isPrerelease,author,createdAt,publishedAt,url";

/// GitHub Release 提供者,通过 `gh` CLI 操作。
///
/// 该结构体通过调用 `gh` CLI 实现 [`ReleaseProvider`] trait 的所有方法,
/// 使上层命令能够以统一的方式操作 GitHub Release。
///
/// 命令执行通过 [`CommandRunner`] 抽象,生产环境默认使用
/// [`RealCommandRunner`],测试可注入自定义 runner 以模拟成功或失败场景。
///
/// # Examples
///
/// ```no_run
/// use gitflow_github::GitHubReleaseProvider;
///
/// let provider = GitHubReleaseProvider::new("octocat/hello-world");
/// ```
#[derive(Debug, Clone)]
pub struct GitHubReleaseProvider<R: CommandRunner = RealCommandRunner> {
    /// GitHub `owner/repo`,如 `"byx-darwin/gitflow-cli"`。
    repo: String,
    /// 用于执行 `gh` CLI 命令的 runner。
    runner: R,
}

impl GitHubReleaseProvider<RealCommandRunner> {
    /// 创建新的 GitHub Release 提供者,使用真实的进程执行器。
    ///
    /// `repo` 格式为 `owner/repo`。
    #[must_use]
    pub fn new(repo: impl Into<String>) -> Self {
        Self {
            repo: repo.into(),
            runner: RealCommandRunner,
        }
    }
}

impl<R: CommandRunner> GitHubReleaseProvider<R> {
    /// 使用自定义 [`CommandRunner`] 创建提供者。
    ///
    /// 主要用于测试,可注入模拟 runner 以控制 `gh` CLI 的输出。
    /// `repo` 格式为 `owner/repo`。
    #[must_use]
    pub fn with_runner(repo: impl Into<String>, runner: R) -> Self {
        Self {
            repo: repo.into(),
            runner,
        }
    }
}

#[async_trait]
impl<R: CommandRunner + 'static> ReleaseProvider for GitHubReleaseProvider<R> {
    async fn create(&self, args: CreateReleaseArgs) -> Result<ReleaseData> {
        let mut cmd_args: Vec<&str> =
            vec!["release", "create", &args.tag_name, "--repo", &self.repo];

        if let Some(name) = &args.name {
            cmd_args.push("--title");
            cmd_args.push(name);
        }

        if let Some(body) = &args.body {
            cmd_args.push("--notes");
            cmd_args.push(body);
        }

        if args.draft {
            cmd_args.push("--draft");
        }

        if args.prerelease {
            cmd_args.push("--prerelease");
        }

        if let Some(commitish) = &args.target_commitish {
            cmd_args.push("--target");
            cmd_args.push(commitish);
        }

        debug!(
            repo = %self.repo,
            tag = %args.tag_name,
            "spawning `gh release create`"
        );

        let output = self
            .runner
            .run("gh", &cmd_args)
            .await
            .map_err(|e| CoreError::Platform(format!("Failed to spawn gh: {e}")))?;

        if !output.status.success() {
            return Err(parse_gh_error(&output.stderr).into());
        }

        // gh release create doesn't support --json, so we fetch the created release
        self.view(&args.tag_name).await
    }

    async fn list(&self) -> Result<Vec<ReleaseData>> {
        debug!(repo = %self.repo, "spawning `gh release list`");

        let output = self
            .runner
            .run(
                "gh",
                &[
                    "release",
                    "list",
                    "--repo",
                    &self.repo,
                    "--json",
                    RELEASE_LIST_FIELDS,
                ],
            )
            .await
            .map_err(|e| CoreError::Platform(format!("Failed to spawn gh: {e}")))?;

        if !output.status.success() {
            return Err(parse_gh_error(&output.stderr).into());
        }

        let releases: Vec<ReleaseData> =
            serde_json::from_slice(&output.stdout).map_err(CoreError::Serialization)?;

        Ok(releases)
    }

    async fn view(&self, tag_name: &str) -> Result<ReleaseData> {
        debug!(repo = %self.repo, tag = %tag_name, "spawning `gh release view`");

        let output = self
            .runner
            .run(
                "gh",
                &[
                    "release",
                    "view",
                    tag_name,
                    "--repo",
                    &self.repo,
                    "--json",
                    RELEASE_VIEW_FIELDS,
                ],
            )
            .await
            .map_err(|e| CoreError::Platform(format!("Failed to spawn gh: {e}")))?;

        if !output.status.success() {
            return Err(parse_gh_error(&output.stderr).into());
        }

        let release: ReleaseData =
            serde_json::from_slice(&output.stdout).map_err(CoreError::Serialization)?;

        Ok(release)
    }

    async fn edit(&self, tag_name: &str, args: CreateReleaseArgs) -> Result<ReleaseData> {
        let mut cmd_args: Vec<&str> = vec!["release", "edit", tag_name, "--repo", &self.repo];

        if let Some(name) = &args.name {
            cmd_args.push("--title");
            cmd_args.push(name);
        }

        if let Some(body) = &args.body {
            cmd_args.push("--notes");
            cmd_args.push(body);
        }

        if args.draft {
            cmd_args.push("--draft");
        }

        if args.prerelease {
            cmd_args.push("--prerelease");
        }

        if let Some(commitish) = &args.target_commitish {
            cmd_args.push("--target");
            cmd_args.push(commitish);
        }

        debug!(
            repo = %self.repo,
            tag = %tag_name,
            "spawning `gh release edit`"
        );

        let output = self
            .runner
            .run("gh", &cmd_args)
            .await
            .map_err(|e| CoreError::Platform(format!("Failed to spawn gh: {e}")))?;

        if !output.status.success() {
            return Err(parse_gh_error(&output.stderr).into());
        }

        // gh release edit doesn't support --json, so we fetch the edited release
        self.view(tag_name).await
    }

    async fn upload_asset(&self, tag_name: &str, file_path: &str, _asset_name: &str) -> Result<()> {
        debug!(
            repo = %self.repo,
            tag = %tag_name,
            file = %file_path,
            "spawning `gh release upload`"
        );

        let output = self
            .runner
            .run(
                "gh",
                &[
                    "release", "upload", tag_name, file_path, "--repo", &self.repo,
                ],
            )
            .await
            .map_err(|e| CoreError::Platform(format!("Failed to spawn gh: {e}")))?;

        if !output.status.success() {
            return Err(parse_gh_error(&output.stderr).into());
        }

        Ok(())
    }

    #[allow(clippy::disallowed_methods)]
    async fn download_asset(
        &self,
        tag_name: &str,
        asset_name: &str,
        dest_path: &str,
    ) -> Result<()> {
        debug!(
            repo = %self.repo,
            tag = %tag_name,
            asset = %asset_name,
            dest = %dest_path,
            "spawning `gh release download`"
        );

        // 下载到目标文件的父目录,然后重命名到目标路径
        let dest = std::path::PathBuf::from(dest_path);
        let parent = dest.parent().unwrap_or_else(|| std::path::Path::new("."));
        let parent_str = parent.to_str().ok_or_else(|| {
            CoreError::Platform(format!(
                "Destination directory is not valid UTF-8: {dest_path}"
            ))
        })?;

        let output = self
            .runner
            .run(
                "gh",
                &[
                    "release",
                    "download",
                    tag_name,
                    "--repo",
                    &self.repo,
                    "--pattern",
                    asset_name,
                    "--dir",
                    parent_str,
                ],
            )
            .await
            .map_err(|e| CoreError::Platform(format!("Failed to spawn gh: {e}")))?;

        if !output.status.success() {
            return Err(parse_gh_error(&output.stderr).into());
        }

        // gh 使用资源的实际文件名下载,尝试找到并移动
        let downloaded = parent.join(asset_name);
        if downloaded != dest && downloaded.exists() {
            std::fs::rename(&downloaded, &dest).map_err(|e| {
                CoreError::Platform(format!(
                    "Failed to move downloaded asset to {dest_path}: {e}"
                ))
            })?;
        }

        Ok(())
    }

    async fn delete(&self, tag_name: &str) -> Result<()> {
        debug!(repo = %self.repo, tag = %tag_name, "spawning `gh release delete`");

        let output = self
            .runner
            .run(
                "gh",
                &[
                    "release",
                    "delete",
                    tag_name,
                    "--repo",
                    &self.repo,
                    "--yes",
                    "--cleanup-tag",
                ],
            )
            .await
            .map_err(|e| CoreError::Platform(format!("Failed to spawn gh: {e}")))?;

        if !output.status.success() {
            // Idempotency: deleting an already-deleted release reports "not found".
            // Treat it as success so automation can safely re-run delete.
            if is_release_not_found(&output.stderr) {
                debug!(repo = %self.repo, tag = %tag_name, "release already deleted, treating as success");
                return Ok(());
            }
            return Err(parse_gh_error(&output.stderr).into());
        }

        Ok(())
    }
}

/// Detect whether `gh` reported that a release (or its tag) does not exist.
///
/// `gh release delete` returns a non-zero exit with a "not found" message when the
/// release was already deleted. `delete` treats this as idempotent success so that
/// automation can safely re-run deletion. Detection is intentionally conservative:
/// only messages mentioning a missing release/tag qualify, so unrelated errors
/// (auth, permission, network) still surface as failures.
///
/// Accepts both the JSON form (`{"message": "Not Found", "code": "NOT_FOUND"}`) and
/// plain-text stderr (`release not found`).
#[must_use]
fn is_release_not_found(stderr: &[u8]) -> bool {
    let text = String::from_utf8_lossy(stderr);
    let lower = text.to_ascii_lowercase();

    // JSON error shape: code NOT_FOUND or message contains "not found".
    if let Ok(json) = serde_json::from_slice::<serde_json::Value>(stderr) {
        let code_matches = json
            .get("code")
            .and_then(serde_json::Value::as_str)
            .is_some_and(|c| c == "NOT_FOUND");
        let msg_matches = json
            .get("message")
            .and_then(serde_json::Value::as_str)
            .is_some_and(|m| m.to_ascii_lowercase().contains("not found"));
        if code_matches || msg_matches {
            return true;
        }
    }

    // Plain-text form: mention of a missing release or tag.
    lower.contains("release not found")
        || (lower.contains("not found")
            && (lower.contains("release") || lower.contains("tag") || lower.contains("404")))
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::runner::{CommandOutput, MockCommandRunner};

    /// Test runner that records every invocation's arguments.
    ///
    /// Used to assert that the `gh release delete` call includes `--cleanup-tag`.
    /// Clones share the same recorded call list via `Arc<Mutex<...>>`.
    #[derive(Debug, Clone)]
    struct ArgsCapturingRunner {
        calls: std::sync::Arc<std::sync::Mutex<Vec<Vec<String>>>>,
    }

    impl ArgsCapturingRunner {
        fn new() -> Self {
            Self {
                calls: std::sync::Arc::new(std::sync::Mutex::new(Vec::new())),
            }
        }
    }

    #[async_trait::async_trait]
    impl CommandRunner for ArgsCapturingRunner {
        async fn run(&self, _program: &str, args: &[&str]) -> std::io::Result<CommandOutput> {
            self.calls
                .lock()
                .expect("lock calls")
                .push(args.iter().map(ToString::to_string).collect());
            Ok(CommandOutput {
                status: MockCommandRunner::make_exit_status(0),
                stdout: Vec::new(),
                stderr: Vec::new(),
            })
        }

        async fn run_with_stdin(
            &self,
            program: &str,
            args: &[&str],
            _stdin_data: &[u8],
        ) -> std::io::Result<CommandOutput> {
            self.run(program, args).await
        }
    }

    #[test]
    fn test_should_construct_github_release_provider() {
        let provider = GitHubReleaseProvider::new("octocat/hello-world");
        assert_eq!(provider.repo, "octocat/hello-world");
    }

    #[test]
    fn test_should_construct_github_release_provider_from_string() {
        let repo = String::from("octocat/hello-world");
        let provider = GitHubReleaseProvider::new(repo);
        assert_eq!(provider.repo, "octocat/hello-world");
    }

    #[test]
    fn test_should_deserialize_release_data_from_gh_output() {
        // 模拟 `gh release view --json ...` 的实际输出
        let gh_json = br#"{
            "id": 1001,
            "tagName": "v1.0.0",
            "name": "Version 1.0.0",
            "body": "Initial stable release",
            "draft": false,
            "prerelease": false,
            "author": {"login": "octocat", "id": "1"},
            "createdAt": "2026-01-01T00:00:00Z",
            "publishedAt": "2026-01-15T12:00:00Z",
            "url": "https://github.com/octocat/hello-world/releases/tag/v1.0.0"
        }"#;

        let release: ReleaseData = serde_json::from_slice(gh_json).expect("valid ReleaseData JSON");
        assert_eq!(release.id, 1001);
        assert_eq!(release.tag_name, "v1.0.0");
        assert_eq!(release.name.as_deref(), Some("Version 1.0.0"));
        assert_eq!(release.body.as_deref(), Some("Initial stable release"));
        assert!(!release.draft);
        assert!(!release.prerelease);
        assert_eq!(release.author.as_ref().unwrap().login, "octocat");
        assert_eq!(release.author.as_ref().unwrap().id, "1");
        assert_eq!(
            release.url,
            "https://github.com/octocat/hello-world/releases/tag/v1.0.0"
        );
    }

    #[test]
    fn test_should_deserialize_empty_release_list_from_gh_output() {
        let gh_json = b"[]";
        let releases: Vec<ReleaseData> =
            serde_json::from_slice(gh_json).expect("valid ReleaseData list");
        assert!(releases.is_empty());
    }

    #[test]
    fn test_should_deserialize_draft_release_from_gh_output() {
        let gh_json = br#"{
            "id": 5,
            "tagName": "v0.1.0-draft",
            "name": null,
            "body": null,
            "draft": true,
            "prerelease": true,
            "author": {"login": "dev", "id": "99"},
            "createdAt": "2026-03-01T00:00:00Z",
            "publishedAt": null,
            "url": "https://example.com/releases/5"
        }"#;

        let release: ReleaseData =
            serde_json::from_slice(gh_json).expect("valid draft ReleaseData");
        assert!(release.draft);
        assert!(release.prerelease);
        assert!(release.name.is_none());
        assert!(release.body.is_none());
        assert!(release.published_at.is_none());
    }

    #[test]
    fn test_should_debug_format_provider() {
        let provider = GitHubReleaseProvider::new("octocat/hello-world");
        let debug = format!("{provider:?}");
        assert!(debug.contains("GitHubReleaseProvider"));
        assert!(debug.contains("octocat/hello-world"));
    }

    #[test]
    fn test_should_create_provider_with_different_repos() {
        let r1 = GitHubReleaseProvider::new("org/repo-a");
        let r2 = GitHubReleaseProvider::new("org/repo-b");
        assert_eq!(r1.repo, "org/repo-a");
        assert_eq!(r2.repo, "org/repo-b");
    }

    #[test]
    fn test_should_clone_github_release_provider() {
        let original = GitHubReleaseProvider::new("owner/repo");
        let cloned = original.clone();
        assert_eq!(original.repo, cloned.repo);
    }

    // --- Failure-path tests using an injected MockCommandRunner ---

    fn sample_create_args() -> CreateReleaseArgs {
        CreateReleaseArgs {
            tag_name: "v1.0.0".to_string(),
            name: Some("Version 1.0.0".to_string()),
            body: Some("Release notes".to_string()),
            draft: false,
            prerelease: false,
            target_commitish: None,
        }
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_gh_fails_for_create() {
        let runner = MockCommandRunner::failure(r#"{"message": "Validation failed"}"#, 256);
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.create(sample_create_args()).await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_serialization_error_on_invalid_json_for_create() {
        // `create` succeeds, then re-fetches via `view`, whose invalid JSON fails parsing.
        let runner = MockCommandRunner::success("invalid json");
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.create(sample_create_args()).await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Serialization(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_gh_fails_for_list() {
        let runner = MockCommandRunner::failure(r#"{"message": "Forbidden"}"#, 256);
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.list().await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_serialization_error_on_invalid_json_for_list() {
        let runner = MockCommandRunner::success("invalid json");
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.list().await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Serialization(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_gh_fails_for_view() {
        let runner = MockCommandRunner::failure(r#"{"message": "Release not found"}"#, 256);
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.view("v1.0.0").await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_serialization_error_on_invalid_json_for_view() {
        let runner = MockCommandRunner::success("invalid json");
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.view("v1.0.0").await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Serialization(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_gh_fails_for_edit() {
        let runner = MockCommandRunner::failure(r#"{"message": "Release not found"}"#, 256);
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.edit("v1.0.0", sample_create_args()).await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_serialization_error_on_invalid_json_for_edit() {
        // `edit` succeeds, then re-fetches via `view`, whose invalid JSON fails parsing.
        let runner = MockCommandRunner::success("invalid json");
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.edit("v1.0.0", sample_create_args()).await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Serialization(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_gh_fails_for_delete() {
        // Non-"not found" failures must still surface as errors.
        let runner = MockCommandRunner::failure(r#"{"message": "Not logged in"}"#, 256);
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.delete("v1.0.0").await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_treat_missing_release_as_idempotent_success() {
        // gh reports "Release not found" when deleting an already-deleted release.
        // The delete must treat this as success (idempotent), not an error.
        let runner = MockCommandRunner::failure(r#"{"message": "Release not found"}"#, 256);
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.delete("v1.0.0").await;

        assert!(result.is_ok(), "expected Ok (idempotent), got {result:?}");
    }

    #[tokio::test]
    async fn test_should_treat_text_not_found_as_idempotent_success() {
        // gh may emit a plain-text "release not found" (non-JSON) stderr.
        // It must also be treated as idempotent success.
        let runner = MockCommandRunner::failure("release not found\n", 256);
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider.delete("v1.0.0").await;

        assert!(result.is_ok(), "expected Ok (idempotent), got {result:?}");
    }

    #[tokio::test]
    async fn test_should_pass_cleanup_tag_flag_on_delete() {
        // The `gh release delete` invocation must include `--cleanup-tag` so the
        // underlying git tag is removed alongside the GitHub Release record.
        let runner = ArgsCapturingRunner::new();
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner.clone());

        provider
            .delete("v1.0.0")
            .await
            .expect("delete must succeed");

        let calls = runner.calls.lock().expect("lock calls");
        let last = calls.last().expect("at least one gh call");
        assert!(
            last.contains(&"--cleanup-tag".to_string()),
            "delete args must include --cleanup-tag, got: {last:?}"
        );
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_gh_fails_for_upload_asset() {
        let runner = MockCommandRunner::failure(r#"{"message": "Upload failed"}"#, 256);
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider
            .upload_asset("v1.0.0", "/tmp/asset.tar.gz", "asset.tar.gz")
            .await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }

    #[tokio::test]
    async fn test_should_return_platform_error_when_gh_fails_for_download_asset() {
        let runner = MockCommandRunner::failure(r#"{"message": "Asset not found"}"#, 256);
        let provider = GitHubReleaseProvider::with_runner("owner/repo", runner);

        let result = provider
            .download_asset("v1.0.0", "asset.tar.gz", "/tmp/download/asset.tar.gz")
            .await;

        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            gitflow_core::CoreError::Cli(_)
        ));
    }
}