gitflow-cli 1.1.0

跨平台 Git 工程化工作流编排框架 CLI:统一封装 GitHub / GitLab / GitCode,配合 AI Agent Skills 覆盖需求到发布的完整工程循环。Cross-platform Git engineering workflow CLI.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
//! `gf workflow` 子命令实现。
//!
//! 管理工作流合同的创建、读取、归档和清理。
//! 合同存储在 `.cache/workflows/active/` 和 `.cache/workflows/archive/`。

// 本模块仅做本地文件 I/O(同步操作),无需 tokio::fs。
#![allow(
    clippy::disallowed_methods,
    clippy::disallowed_types,
    reason = "Workflow contract I/O is synchronous local file access, not async network I/O"
)]

use std::{
    collections::BTreeMap,
    fmt,
    io::Write,
    path::{Path, PathBuf},
};

use chrono::{DateTime, TimeDelta, Utc};
use clap::{Subcommand, ValueEnum};
use serde::{Deserialize, Serialize};

/// 工作流模式:完整模式(四阶段)或快速模式(跳过阶段二)。
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, ValueEnum)]
#[serde(rename_all = "lowercase")]
pub enum WorkflowMode {
    /// 完整四阶段流程。
    Full,
    /// 快速模式,跳过计划制定阶段。
    Fast,
}

impl fmt::Display for WorkflowMode {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            Self::Full => write!(f, "full"),
            Self::Fast => write!(f, "fast"),
        }
    }
}

/// 阶段状态。
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum PhaseStatus {
    /// 待处理。
    #[default]
    Pending,
    /// 进行中。
    InProgress,
    /// 已完成。
    Complete,
    /// 已跳过(快速模式下适用)。
    Skipped,
}

/// 阶段证据,记录各阶段的关键产出物。
#[derive(Debug, Default, Serialize, Deserialize)]
pub struct PhaseEvidence {
    /// Issue 链接。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub issue_url: Option<String>,
    /// 评论 ID。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub comment_id: Option<String>,
    /// 规格文件路径。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub spec_path: Option<String>,
    /// 票据清单(文件路径或 URL),mattpocock 路径阶段二 `to-tickets` 产出(Issue #141)。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub ticket_refs: Option<Vec<String>>,
    /// 用户是否已批准。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub user_approved: Option<bool>,
    /// 关联分支。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub branch: Option<String>,
    /// PR 链接。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub pr_url: Option<String>,
    /// 测试是否通过。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub tests_passed: Option<bool>,
    /// 流水线是否 OK。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub pipeline_ok: Option<bool>,
    /// 审查报告路径。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub review_report_path: Option<String>,
}

/// 工作流阶段。
#[derive(Debug, Default, Serialize, Deserialize)]
pub struct Phase {
    /// 阶段名称。
    pub name: String,
    /// 阶段状态。
    pub status: PhaseStatus,
    /// 开始时间(RFC 3339)。
    pub started_at: Option<String>,
    /// 完成时间(RFC 3339)。
    pub completed_at: Option<String>,
    /// 执行者。
    pub executor: Option<String>,
    /// 阶段证据。
    #[serde(default)]
    pub evidence: PhaseEvidence,
}

/// 关卡检查结果。
#[derive(Debug, Serialize, Deserialize, PartialEq, Eq)]
#[serde(rename_all = "snake_case")]
pub enum GateCheck {
    /// 通过。
    Pass,
    /// 缺少证据(证据名称)。
    MissingEvidence(String),
    /// 前一阶段未完成(阶段编号)。
    PhaseNotComplete(u8),
}

/// 工作流合同,记录从需求到交付的完整执行轨迹。
#[derive(Debug, Serialize, Deserialize)]
pub struct WorkflowContract {
    /// 合同版本。
    pub version: String,
    /// 工作流 ID(格式: `wf-YYYY-MM-DD-NNN`)。
    pub workflow_id: String,
    /// 标题。
    pub title: String,
    /// 模式。
    pub mode: WorkflowMode,
    /// 技能来源(`superpowers` / `mattpocock` / `inline`),启动时检测写入(Issue #141)。
    ///
    /// 旧合同可能缺失此字段,故为 `Option`;新合同由编排器在 Bootstrap 后必填。
    #[serde(skip_serializing_if = "Option::is_none")]
    pub skill_source: Option<String>,
    /// 创建时间(RFC 3339)。
    pub created_at: String,
    /// 更新时间(RFC 3339)。
    pub updated_at: String,
    /// 当前阶段(1-4)。
    pub current_phase: u8,
    /// 阶段映射(键 `"1"`-`"4"` 对应四个阶段,与合同 schema 保持一致)。
    pub phases: BTreeMap<String, Phase>,
}

impl WorkflowContract {
    /// 检查是否可以进入目标阶段。
    ///
    /// 根据当前各阶段状态和证据检查关卡条件:
    /// - 进入阶段二:阶段一必须完成且有 `issue_url`
    /// - 进入阶段三:任何模式都要求阶段一完成且有 `issue_url`;
    ///   快速模式在此之后跳过阶段二,完整模式还需阶段二完成且有 `spec_path` 和 `user_approved`
    /// - 进入阶段四:阶段三必须完成且有 `pr_url` 和 `tests_passed`
    #[must_use]
    pub fn can_enter_phase(&self, target: u8) -> GateCheck {
        match target {
            2 => {
                let Some(phase1) = self.phases.get("1") else {
                    return GateCheck::PhaseNotComplete(1);
                };
                if phase1.status != PhaseStatus::Complete {
                    return GateCheck::PhaseNotComplete(1);
                }
                if phase1.evidence.issue_url.is_none() {
                    return GateCheck::MissingEvidence("issue_url".into());
                }
                if self.mode == WorkflowMode::Full && phase1.evidence.comment_id.is_none() {
                    return GateCheck::MissingEvidence("comment_id".into());
                }
                GateCheck::Pass
            }
            3 => {
                // 无论快速还是完整模式,Phase 1 都必须完成且已产出 issue_url。
                let Some(phase1) = self.phases.get("1") else {
                    return GateCheck::PhaseNotComplete(1);
                };
                if phase1.status != PhaseStatus::Complete {
                    return GateCheck::PhaseNotComplete(1);
                }
                if phase1.evidence.issue_url.is_none() {
                    return GateCheck::MissingEvidence("issue_url".into());
                }
                // 快速模式在 Phase 1 通过后跳过 Phase 2。
                if self.mode == WorkflowMode::Fast {
                    return GateCheck::Pass;
                }
                let Some(phase2) = self.phases.get("2") else {
                    return GateCheck::PhaseNotComplete(2);
                };
                if phase2.status != PhaseStatus::Complete {
                    return GateCheck::PhaseNotComplete(2);
                }
                if phase2.evidence.spec_path.is_none() {
                    return GateCheck::MissingEvidence("spec_path".into());
                }
                if phase2.evidence.user_approved != Some(true) {
                    return GateCheck::MissingEvidence("user_approved".into());
                }
                GateCheck::Pass
            }
            4 => {
                let Some(phase3) = self.phases.get("3") else {
                    return GateCheck::PhaseNotComplete(3);
                };
                if phase3.status != PhaseStatus::Complete {
                    return GateCheck::PhaseNotComplete(3);
                }
                if phase3.evidence.pr_url.is_none() {
                    return GateCheck::MissingEvidence("pr_url".into());
                }
                if phase3.evidence.tests_passed != Some(true) {
                    return GateCheck::MissingEvidence("tests_passed".into());
                }
                GateCheck::Pass
            }
            _ => GateCheck::MissingEvidence("invalid phase".into()),
        }
    }
}

/// CLI 子命令枚举。
#[derive(Debug, Subcommand)]
pub enum WorkflowCommand {
    /// 创建新的 workflow 合同(自动分配当日不重复的 ID)。
    Create {
        /// 工作流标题。
        #[arg(long)]
        title: String,
        /// 工作流模式。
        #[arg(long, value_enum, default_value_t = WorkflowMode::Full)]
        mode: WorkflowMode,
    },
    /// 列出当前 active workflows。
    List,
    /// 查看 workflow 合同详情(JSON 格式)。
    Status {
        /// 工作流 ID。
        workflow_id: String,
    },
    /// 归档已完成的 workflow(仅阶段四完成才可归档)。
    Archive {
        /// 工作流 ID。
        workflow_id: String,
    },
    /// 清理过期归档。
    Cleanup {
        /// 超过多少天的归档会被清理(默认 90)。
        #[arg(long, default_value = "90")]
        older_than: i64,
    },
}

/// 处理 `gf workflow` 子命令。
///
/// # Errors
///
/// 返回错误当:
/// - 指定的 workflow 不存在。
/// - 文件读写失败。
/// - workflow 未完成时尝试归档。
/// - 归档目标已存在(拒绝覆盖)。
/// - 创建时标题为空或当日序号用尽。
pub fn handle(command: WorkflowCommand) -> miette::Result<()> {
    match command {
        WorkflowCommand::Create { title, mode } => create_workflow(&title, mode),
        WorkflowCommand::List => list_workflows(),
        WorkflowCommand::Status { workflow_id } => show_status(&workflow_id),
        WorkflowCommand::Archive { workflow_id } => archive_workflow(&workflow_id),
        WorkflowCommand::Cleanup { older_than } => cleanup_archives(older_than),
    }
}

/// 获取 active workflow 目录。
fn workflow_dir() -> PathBuf {
    let cwd = std::env::current_dir().unwrap_or_else(|_| PathBuf::from("."));
    cwd.join(".cache/workflows/active")
}

/// 获取归档目录。
fn archive_dir() -> PathBuf {
    let cwd = std::env::current_dir().unwrap_or_else(|_| PathBuf::from("."));
    cwd.join(".cache/workflows/archive")
}

/// 校验外部传入的 `workflow_id` 是否符合 `wf-YYYY-MM-DD-NNN` 格式。
///
/// `workflow_id` 会被拼接进文件路径,必须在使用前完成校验以阻止路径穿越
/// (例如 `../../etc/passwd`)。只接受形如 `wf-2026-07-09-001` 的字符串。
fn validate_workflow_id(workflow_id: &str) -> miette::Result<()> {
    let pattern = regex::Regex::new(r"^wf-\d{4}-\d{2}-\d{2}-\d{3}$")
        .map_err(|e| miette::miette!("内部错误:workflow_id 正则编译失败: {e}"))?;
    if pattern.is_match(workflow_id) {
        Ok(())
    } else {
        Err(miette::miette!(
            "无效的 workflow_id '{workflow_id}',格式应为 wf-YYYY-MM-DD-NNN"
        ))
    }
}

/// 列出所有 active workflows。
fn list_workflows() -> miette::Result<()> {
    let dir = workflow_dir();
    if !dir.exists() {
        println!("(无 active workflows)");
        return Ok(());
    }
    let mut found = 0;
    for entry in std::fs::read_dir(&dir).map_err(|e| miette::miette!("读取目录失败: {e}"))? {
        let entry = entry.map_err(|e| miette::miette!("读取条目失败: {e}"))?;
        let path = entry.path();
        if path.extension().and_then(|e| e.to_str()) == Some("json") {
            let content =
                std::fs::read_to_string(&path).map_err(|e| miette::miette!("读取合同失败: {e}"))?;
            let contract: WorkflowContract =
                serde_json::from_str(&content).map_err(|e| miette::miette!("解析合同失败: {e}"))?;
            println!(
                "  {} | {} | Phase {} | {}",
                contract.workflow_id, contract.title, contract.current_phase, contract.mode
            );
            found += 1;
        }
    }
    if found == 0 {
        println!("(无 active workflows)");
    } else {
        println!("\n共 {found} 个 active workflows");
    }
    Ok(())
}

/// 查看指定 workflow 的合同详情(JSON 格式)。
fn show_status(workflow_id: &str) -> miette::Result<()> {
    validate_workflow_id(workflow_id)?;
    let path = workflow_dir().join(format!("{workflow_id}.json"));
    if !path.exists() {
        return Err(miette::miette!("workflow {workflow_id} 不存在"));
    }
    let content =
        std::fs::read_to_string(&path).map_err(|e| miette::miette!("读取合同失败: {e}"))?;
    let contract: WorkflowContract =
        serde_json::from_str(&content).map_err(|e| miette::miette!("解析合同失败: {e}"))?;
    println!(
        "{}",
        serde_json::to_string_pretty(&contract).map_err(|e| miette::miette!("{e}"))?
    );
    print_gate_status(&contract);
    Ok(())
}

/// 打印合同各目标阶段的门控检查结果。
///
/// 遍历目标阶段 2-4,展示当前是否满足进入条件(复用 `can_enter_phase`)。
fn print_gate_status(contract: &WorkflowContract) {
    println!("\n门控检查(当前可进入的 Phase):");
    for target in 2u8..=4 {
        match contract.can_enter_phase(target) {
            GateCheck::Pass => println!("  Phase {target}: 可进入"),
            GateCheck::MissingEvidence(ev) => {
                println!("  Phase {target}: 阻止(缺少证据 {ev})");
            }
            GateCheck::PhaseNotComplete(p) => {
                println!("  Phase {target}: 阻止(阶段 {p} 未完成)");
            }
        }
    }
}

/// 创建新的 workflow 合同(使用默认目录)。
///
/// # Errors
///
/// 标题为空、目录创建/文件写入失败、或当日序号用尽时返回错误。
fn create_workflow(title: &str, mode: WorkflowMode) -> miette::Result<()> {
    let dir = workflow_dir();
    let id = create_workflow_at(&dir, &archive_dir(), title, mode)?;
    println!("✅ Workflow 已创建: {id}");
    println!("   合同: {}", dir.join(format!("{id}.json")).display());
    Ok(())
}

/// 在指定的 active/archive 目录下创建新合同,返回分配的 workflow ID。
///
/// ID 生成规则(Issue #142):
/// - 扫描 `active/` **与** `archive/` 的所有月份目录,取当日日期已占用的最大序号,
///   再取下一个空位——归档后的序号不会被复用
/// - 使用 `create_new`(`O_EXCL` 语义)原子写入;若目标已被并发创建占用,
///   自动顺延到下一个序号重试,保证同日不产生同名合同
///
/// # Errors
///
/// 标题为空、目录创建/文件写入失败、或当日序号用尽(999)时返回错误。
fn create_workflow_at(
    active_dir: &Path,
    archive_root: &Path,
    title: &str,
    mode: WorkflowMode,
) -> miette::Result<String> {
    if title.trim().is_empty() {
        return Err(miette::miette!("title 不能为空"));
    }
    let date = Utc::now().format("%Y-%m-%d").to_string();
    let mut seq = max_existing_seq(active_dir, archive_root, &date)?.saturating_add(1);
    loop {
        if seq > 999 {
            return Err(miette::miette!(
                "当日 workflow 序号已用尽(999),无法继续创建: {date}"
            ));
        }
        let id = format!("wf-{date}-{seq:03}");
        std::fs::create_dir_all(active_dir)
            .map_err(|e| miette::miette!("创建 active 目录失败: {e}"))?;
        let path = active_dir.join(format!("{id}.json"));
        match std::fs::OpenOptions::new()
            .write(true)
            .create_new(true)
            .open(&path)
        {
            Ok(mut file) => {
                let contract = new_contract(&id, title, mode);
                let json = serde_json::to_string_pretty(&contract)
                    .map_err(|e| miette::miette!("序列化合同失败: {e}"))?;
                file.write_all(json.as_bytes())
                    .map_err(|e| miette::miette!("写入合同失败: {e}"))?;
                return Ok(id);
            }
            Err(e) if e.kind() == std::io::ErrorKind::AlreadyExists => {
                seq = seq.saturating_add(1);
            }
            Err(e) => return Err(miette::miette!("创建合同文件失败: {e}")),
        }
    }
}

/// 扫描 active/ 与 archive/ 的所有月份目录,返回给定日期已占用的最大序号(无则 0)。
///
/// 合同按**归档时刻**的月份归档(见 [`archive_workflow_at`]),可能落在
/// 非合同日期的月份目录(如月末创建、次月归档),因此扫描全部月份目录。
///
/// # Errors
///
/// 读取归档根目录失败时返回错误。
fn max_existing_seq(active_dir: &Path, archive_root: &Path, date: &str) -> miette::Result<u32> {
    let prefix = format!("wf-{date}-");
    let mut dirs: Vec<PathBuf> = Vec::new();
    if active_dir.is_dir() {
        dirs.push(active_dir.to_path_buf());
    }
    if archive_root.is_dir() {
        for entry in std::fs::read_dir(archive_root)
            .map_err(|e| miette::miette!("读取归档根目录失败: {e}"))?
        {
            let path = entry
                .map_err(|e| miette::miette!("读取归档条目失败: {e}"))?
                .path();
            if path.is_dir() {
                dirs.push(path);
            }
        }
    }
    let mut max_seq = 0u32;
    for dir in &dirs {
        let Ok(entries) = std::fs::read_dir(dir) else {
            continue;
        };
        for entry in entries.flatten() {
            let file_name = entry.file_name();
            let Some(name) = file_name.to_str() else {
                continue;
            };
            let Some(stem) = name.strip_suffix(".json") else {
                continue;
            };
            let Some(seq_str) = stem.strip_prefix(&prefix) else {
                continue;
            };
            if let Ok(seq) = seq_str.parse::<u32>() {
                max_seq = max_seq.max(seq);
            }
        }
    }
    Ok(max_seq)
}

/// 构造全新合同对象(Phase 1 进行中,Phase 2-4 待处理)。
fn new_contract(workflow_id: &str, title: &str, mode: WorkflowMode) -> WorkflowContract {
    let now = Utc::now().to_rfc3339();
    let phase = |name: &str, status: PhaseStatus, started_at: Option<&str>| Phase {
        name: name.to_string(),
        status,
        started_at: started_at.map(String::from),
        completed_at: None,
        executor: None,
        evidence: PhaseEvidence::default(),
    };
    let mut phases = BTreeMap::new();
    phases.insert(
        "1".to_string(),
        phase("Clarification", PhaseStatus::InProgress, Some(&now)),
    );
    phases.insert(
        "2".to_string(),
        phase("Planning", PhaseStatus::Pending, None),
    );
    phases.insert(
        "3".to_string(),
        phase("Execution", PhaseStatus::Pending, None),
    );
    phases.insert(
        "4".to_string(),
        phase("Delivery", PhaseStatus::Pending, None),
    );
    WorkflowContract {
        version: "1.0".to_string(),
        workflow_id: workflow_id.to_string(),
        title: title.trim().to_string(),
        mode,
        skill_source: None,
        created_at: now.clone(),
        updated_at: now,
        current_phase: 1,
        phases,
    }
}

/// 归档已完成的 workflow。
///
/// 仅当当前阶段为四且阶段四状态为 `Complete` 时才可归档。
/// 归档按月分目录存放(`archive/YYYY-MM/`)。
///
/// # Errors
///
/// 归档目标已存在时拒绝覆盖并返回错误(防止 ID 复用导致历史丢失)。
fn archive_workflow(workflow_id: &str) -> miette::Result<()> {
    archive_workflow_at(&workflow_dir(), &archive_dir(), workflow_id)
}

/// 在指定的 active/archive 目录下归档已完成的 workflow。
///
/// 抽出目录参数便于单元测试注入临时目录,逻辑与 [`archive_workflow`] 一致。
///
/// # Errors
///
/// 归档目标已存在时拒绝覆盖并返回错误(Issue #142:防止静默覆盖历史合同)。
fn archive_workflow_at(
    active_dir: &Path,
    archive_root: &Path,
    workflow_id: &str,
) -> miette::Result<()> {
    validate_workflow_id(workflow_id)?;
    let src = active_dir.join(format!("{workflow_id}.json"));
    if !src.exists() {
        return Err(miette::miette!("workflow {workflow_id} 不存在"));
    }
    let content =
        std::fs::read_to_string(&src).map_err(|e| miette::miette!("读取合同失败: {e}"))?;
    let contract: WorkflowContract =
        serde_json::from_str(&content).map_err(|e| miette::miette!("解析合同失败: {e}"))?;
    let phase4_status = contract.phases.get("4").map(|p| p.status);
    if contract.current_phase != 4 || phase4_status != Some(PhaseStatus::Complete) {
        return Err(miette::miette!(
            "workflow 未完成(current_phase={}, phase_4_status={:?})",
            contract.current_phase,
            phase4_status
        ));
    }
    // 按月归档
    let now = Utc::now();
    let month_dir = archive_root.join(now.format("%Y-%m").to_string());
    std::fs::create_dir_all(&month_dir).map_err(|e| miette::miette!("创建归档目录失败: {e}"))?;
    let dst = month_dir.join(format!("{workflow_id}.json"));
    if dst.exists() {
        return Err(miette::miette!(
            "归档目标已存在: {},拒绝覆盖(可能是 workflow_id 复用,见 Issue #142)",
            dst.display()
        ));
    }
    std::fs::copy(&src, &dst).map_err(|e| miette::miette!("复制到归档失败: {e}"))?;
    std::fs::remove_file(&src).map_err(|e| miette::miette!("删除 active 合同失败: {e}"))?;
    println!("workflow {workflow_id} 已归档到 {}", month_dir.display());
    Ok(())
}

/// 清理超过指定天数的过期归档。
///
/// 逐月扫描归档目录,删除创建时间早于阈值的合同文件,
/// 并清理因此变为空的月份目录。
fn cleanup_archives(older_than_days: i64) -> miette::Result<()> {
    cleanup_archives_at(&archive_dir(), older_than_days)
}

/// 在指定归档目录下清理过期合同。
///
/// 抽出目录参数便于单元测试注入临时目录,逻辑与 [`cleanup_archives`] 一致。
fn cleanup_archives_at(dir: &Path, older_than_days: i64) -> miette::Result<()> {
    if !dir.exists() {
        println!("(无归档)");
        return Ok(());
    }
    let duration = TimeDelta::try_days(older_than_days)
        .ok_or_else(|| miette::miette!("无效的天数: {older_than_days}"))?;
    let threshold = Utc::now() - duration;
    let mut cleaned = 0;
    for month_entry in
        std::fs::read_dir(dir).map_err(|e| miette::miette!("读取归档目录失败: {e}"))?
    {
        let month_entry = month_entry.map_err(|e| miette::miette!("读取月份目录失败: {e}"))?;
        let month_dir = month_entry.path();
        if !month_dir.is_dir() {
            continue;
        }
        for entry in
            std::fs::read_dir(&month_dir).map_err(|e| miette::miette!("读取归档条目失败: {e}"))?
        {
            let entry = entry.map_err(|e| miette::miette!("读取文件失败: {e}"))?;
            let path = entry.path();
            if path.extension().and_then(|e| e.to_str()) != Some("json") {
                continue;
            }
            let content =
                std::fs::read_to_string(&path).map_err(|e| miette::miette!("读取合同失败: {e}"))?;
            let contract: WorkflowContract =
                serde_json::from_str(&content).map_err(|e| miette::miette!("解析合同失败: {e}"))?;
            if let Ok(created) = DateTime::parse_from_rfc3339(&contract.created_at)
                && created.with_timezone(&Utc) < threshold
            {
                std::fs::remove_file(&path)
                    .map_err(|e| miette::miette!("删除过期归档失败: {e}"))?;
                cleaned += 1;
            }
        }
        // 清理空月份目录
        if std::fs::read_dir(&month_dir).is_ok_and(|mut d| d.next().is_none()) {
            std::fs::remove_dir(&month_dir).ok();
        }
    }
    println!("已清理 {cleaned} 个过期归档");
    Ok(())
}

#[cfg(test)]
#[allow(
    clippy::panic,
    reason = "Test code: panic is acceptable for assertion failures"
)]
mod tests {
    use super::*;

    /// 从 mode 构造一个测试用基础合同(Phase 1 进行中,其余待处理)。
    ///
    /// 替代已移除的 `WorkflowContract::new`,统一改用 `serde_json::from_str`,
    /// 确保 Rust 类型始终与合同 schema 对齐。
    fn base_contract(mode: &str) -> WorkflowContract {
        let json = format!(
            r#"{{
  "version": "1.0",
  "workflow_id": "wf-2026-07-09-001",
  "title": "feat: test",
  "mode": "{mode}",
  "created_at": "2026-07-09T00:00:00Z",
  "updated_at": "2026-07-09T00:00:00Z",
  "current_phase": 1,
  "phases": {{
    "1": {{ "name": "Clarification", "status": "in_progress", "started_at": "2026-07-09T00:00:00Z" }},
    "2": {{ "name": "Planning", "status": "pending" }},
    "3": {{ "name": "Execution", "status": "pending" }},
    "4": {{ "name": "Delivery", "status": "pending" }}
  }}
}}"#
        );
        serde_json::from_str(&json).expect("deserialize base contract")
    }

    #[test]
    fn test_should_accept_valid_workflow_id() {
        assert!(validate_workflow_id("wf-2026-07-09-001").is_ok());
    }

    #[test]
    fn test_should_reject_workflow_id_with_path_traversal() {
        assert!(validate_workflow_id("../../etc/passwd").is_err());
        assert!(validate_workflow_id("wf-2026-07-09-001/../secret").is_err());
        assert!(validate_workflow_id("wf-2026-7-9-1").is_err());
        assert!(validate_workflow_id("").is_err());
    }

    #[test]
    fn test_should_reject_archive_with_path_traversal_id() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        std::fs::create_dir_all(&active).expect("create active");
        let result = archive_workflow_at(&active, &archive, "../../evil");
        assert!(
            result.is_err(),
            "path traversal id must be rejected before any file I/O"
        );
    }

    #[test]
    fn test_should_roundtrip_contract_serialization() {
        let contract = base_contract("fast");
        let json = serde_json::to_string_pretty(&contract).expect("serialize");
        let deserialized: WorkflowContract = serde_json::from_str(&json).expect("deserialize");
        assert_eq!(deserialized.workflow_id, contract.workflow_id);
        assert_eq!(deserialized.title, contract.title);
        assert!(matches!(deserialized.mode, WorkflowMode::Fast));
    }

    #[test]
    fn test_gate_1_to_2_blocks_without_issue_url() {
        let mut contract = base_contract("full");
        // 阶段一状态为 Complete 但缺少 issue_url
        contract.phases.get_mut("1").expect("phase 1").status = PhaseStatus::Complete;
        let result = contract.can_enter_phase(2);
        assert!(
            matches!(result, GateCheck::MissingEvidence(_)),
            "should block without issue_url"
        );
    }

    #[test]
    fn test_gate_1_to_2_passes_with_issue_url() {
        let mut contract = base_contract("full");
        let phase1 = contract.phases.get_mut("1").expect("phase 1");
        phase1.status = PhaseStatus::Complete;
        phase1.evidence.issue_url = Some("https://github.com/org/repo/issues/1".to_string());
        phase1.evidence.comment_id = Some("12345".to_string());
        let result = contract.can_enter_phase(2);
        assert!(matches!(result, GateCheck::Pass));
    }

    #[test]
    fn test_gate_2_to_3_fast_mode_passes_after_phase1() {
        let mut contract = base_contract("fast");
        let phase1 = contract.phases.get_mut("1").expect("phase 1");
        phase1.status = PhaseStatus::Complete;
        phase1.evidence.issue_url = Some("https://github.com/org/repo/issues/1".to_string());
        // 快速模式在 Phase 1 通过后跳过阶段二直接放行
        let result = contract.can_enter_phase(3);
        assert!(
            matches!(result, GateCheck::Pass),
            "fast mode should pass gate 3 once phase 1 is complete"
        );
    }

    #[test]
    fn test_gate_2_to_3_fast_mode_blocked_without_phase1() {
        // Phase 1 仍进行中:快速模式也不得绕过阶段一完成校验
        let contract = base_contract("fast");
        let result = contract.can_enter_phase(3);
        assert!(
            matches!(result, GateCheck::PhaseNotComplete(1)),
            "fast mode must not bypass phase 1 completion"
        );
    }

    #[test]
    fn test_gate_2_to_3_fast_mode_blocked_without_issue_url() {
        // Phase 1 完成但缺少 issue_url:快速模式仍需该证据
        let mut contract = base_contract("fast");
        contract.phases.get_mut("1").expect("phase 1").status = PhaseStatus::Complete;
        let result = contract.can_enter_phase(3);
        assert!(
            matches!(result, GateCheck::MissingEvidence(_)),
            "fast mode still requires issue_url"
        );
    }

    #[test]
    fn test_gate_3_to_4_never_fast_exempt() {
        let mut contract = base_contract("fast");
        // 先标记阶段三为完成(绕过 PhaseNotComplete 检查)
        contract.phases.get_mut("3").expect("phase 3").status = PhaseStatus::Complete;
        // Gate 3→4 没有快速豁免——即使 Fast 模式也需要证据
        let result = contract.can_enter_phase(4);
        assert!(
            matches!(result, GateCheck::MissingEvidence(_)),
            "Gate 3→4 must never be fast-exempt"
        );
    }

    /// 合同 schema / SKILL.md 示例:mode 为小写、phases 为对象。
    /// 该样例必须能被反序列化,防止 Rust 类型与合同 schema 偏离。
    const SCHEMA_EXAMPLE_CONTRACT: &str = r#"{
  "version": "1.0",
  "workflow_id": "wf-2026-07-09-001",
  "title": "feat: TOON 输出格式",
  "mode": "full",
  "created_at": "2026-07-09T02:59:32Z",
  "updated_at": "2026-07-09T03:30:00Z",
  "current_phase": 3,
  "phases": {
    "1": {
      "name": "Clarification",
      "status": "complete",
      "started_at": "2026-07-09T02:59:32Z",
      "completed_at": "2026-07-09T03:10:00Z",
      "executor": "claude-code-3.7",
      "evidence": {
        "issue_url": "https://github.com/org/repo/issues/74",
        "comment_id": "4921173903"
      }
    },
    "2": {
      "name": "Planning",
      "status": "complete",
      "started_at": "2026-07-09T03:10:00Z",
      "completed_at": "2026-07-09T03:20:00Z",
      "executor": "claude-code-3.7",
      "evidence": {
        "spec_path": "docs/superpowers/specs/2026-07-09-toon-design.md",
        "user_approved": true
      }
    },
    "3": {
      "name": "Execution",
      "status": "in_progress",
      "started_at": "2026-07-09T03:20:00Z",
      "completed_at": null,
      "executor": "subagent-task-3",
      "evidence": {}
    },
    "4": {
      "name": "Delivery",
      "status": "pending",
      "started_at": null,
      "completed_at": null,
      "executor": null,
      "evidence": {}
    }
  }
}"#;

    #[test]
    fn test_should_deserialize_schema_example_contract() {
        let contract: WorkflowContract =
            serde_json::from_str(SCHEMA_EXAMPLE_CONTRACT).expect("deserialize schema example");
        assert_eq!(contract.version, "1.0");
        assert!(matches!(contract.mode, WorkflowMode::Full));
        assert_eq!(contract.current_phase, 3);
        assert_eq!(contract.phases.len(), 4);
        let phase1 = contract.phases.get("1").expect("phase 1");
        assert_eq!(phase1.name, "Clarification");
        assert_eq!(phase1.status, PhaseStatus::Complete);
        assert_eq!(
            phase1.evidence.issue_url.as_deref(),
            Some("https://github.com/org/repo/issues/74")
        );
        let phase3 = contract.phases.get("3").expect("phase 3");
        assert_eq!(phase3.status, PhaseStatus::InProgress);
        let phase4 = contract.phases.get("4").expect("phase 4");
        assert_eq!(phase4.status, PhaseStatus::Pending);
    }

    #[test]
    fn test_should_serialize_mode_lowercase_and_phases_object() {
        let contract = base_contract("full");
        let json = serde_json::to_string(&contract).expect("serialize");
        // mode 必须是小写字符串,phases 必须是带字符串键的对象
        assert!(
            json.contains(r#""mode":"full""#),
            "mode must be lowercase: {json}"
        );
        assert!(
            json.contains(r#""phases":{"#),
            "phases must be an object: {json}"
        );
        assert!(
            json.contains(r#""1":"#),
            "phases must be keyed by string: {json}"
        );
    }

    #[test]
    fn test_should_omit_none_evidence_fields_on_serialize() {
        let mut contract = base_contract("full");
        let phase1 = contract.phases.get_mut("1").expect("phase 1");
        phase1.evidence.issue_url = Some("https://github.com/org/repo/issues/1".to_string());
        let json = serde_json::to_string(&contract).expect("serialize");
        // 已设置的字段应出现,未设置的 Option 不应序列化为 null
        assert!(
            json.contains(r#""issue_url":"https://github.com/org/repo/issues/1""#),
            "set evidence field must be present: {json}"
        );
        assert!(
            !json.contains(r#""comment_id":null"#),
            "unset evidence fields must be omitted: {json}"
        );
        assert!(
            !json.contains(r#""spec_path":null"#),
            "unset evidence fields must be omitted: {json}"
        );
        // 完全为空的 evidence 序列化为空对象而非一堆 null
        assert!(
            json.contains(r#""evidence":{}"#),
            "empty evidence should be an empty object: {json}"
        );
    }

    #[test]
    fn test_should_archive_completed_workflow() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        std::fs::create_dir_all(&active).expect("create active");

        let mut contract = base_contract("full");
        contract.current_phase = 4;
        contract.phases.get_mut("4").expect("phase 4").status = PhaseStatus::Complete;
        let id = contract.workflow_id.clone();
        std::fs::write(
            active.join(format!("{id}.json")),
            serde_json::to_string_pretty(&contract).expect("serialize"),
        )
        .expect("write contract");

        archive_workflow_at(&active, &archive, &id).expect("archive should succeed");

        assert!(
            !active.join(format!("{id}.json")).exists(),
            "active contract should be removed after archive"
        );
        let month = Utc::now().format("%Y-%m").to_string();
        assert!(
            archive.join(&month).join(format!("{id}.json")).exists(),
            "contract should be archived under YYYY-MM"
        );
    }

    #[test]
    fn test_should_reject_archive_of_incomplete_workflow() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        std::fs::create_dir_all(&active).expect("create active");

        // Phase 4 仍为 pending,不可归档
        let contract = base_contract("full");
        let id = contract.workflow_id.clone();
        std::fs::write(
            active.join(format!("{id}.json")),
            serde_json::to_string_pretty(&contract).expect("serialize"),
        )
        .expect("write contract");

        let result = archive_workflow_at(&active, &archive, &id);
        assert!(result.is_err(), "incomplete workflow must not be archived");
        assert!(
            active.join(format!("{id}.json")).exists(),
            "active contract must remain when archive is rejected"
        );
    }

    #[test]
    fn test_should_cleanup_only_expired_archives() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let archive = tmp.path().join("archive");
        let old_month = archive.join("2020-01");
        let fresh_month = archive.join(Utc::now().format("%Y-%m").to_string());
        std::fs::create_dir_all(&old_month).expect("create old month");
        std::fs::create_dir_all(&fresh_month).expect("create fresh month");

        // 过期合同(创建时间远早于阈值)
        let mut old = base_contract("full");
        old.created_at = "2020-01-01T00:00:00Z".to_string();
        std::fs::write(
            old_month.join("wf-2020-01-01-001.json"),
            serde_json::to_string(&old).expect("serialize"),
        )
        .expect("write old contract");

        // 新合同(刚创建,应保留)
        let mut fresh = base_contract("full");
        fresh.created_at = Utc::now().to_rfc3339();
        std::fs::write(
            fresh_month.join("wf-fresh-001.json"),
            serde_json::to_string(&fresh).expect("serialize"),
        )
        .expect("write fresh contract");

        cleanup_archives_at(&archive, 90).expect("cleanup should succeed");

        assert!(
            !old_month.join("wf-2020-01-01-001.json").exists(),
            "expired contract should be deleted"
        );
        assert!(
            !old_month.exists(),
            "empty month directory should be removed"
        );
        assert!(
            fresh_month.join("wf-fresh-001.json").exists(),
            "fresh contract should be retained"
        );
    }

    /// 今日日期(UTC),与 `create_workflow_at` 使用的日期一致。
    fn today() -> String {
        Utc::now().format("%Y-%m-%d").to_string()
    }

    /// 在归档目录预置一个今日日期、指定序号的合同文件。
    fn seed_archived(archive: &Path, seq: u32) {
        let date = today();
        let month_dir = archive.join(&date[..7]);
        std::fs::create_dir_all(&month_dir).expect("create month dir");
        let mut contract = base_contract("full");
        contract.workflow_id = format!("wf-{date}-{seq:03}");
        std::fs::write(
            month_dir.join(format!("wf-{date}-{seq:03}.json")),
            serde_json::to_string(&contract).expect("serialize"),
        )
        .expect("write archived contract");
    }

    /// 在 active 目录预置一个今日日期、指定序号的合同文件。
    fn seed_active(active: &Path, seq: u32) {
        let date = today();
        std::fs::create_dir_all(active).expect("create active dir");
        let mut contract = base_contract("full");
        contract.workflow_id = format!("wf-{date}-{seq:03}");
        std::fs::write(
            active.join(format!("wf-{date}-{seq:03}.json")),
            serde_json::to_string(&contract).expect("serialize"),
        )
        .expect("write active contract");
    }

    #[test]
    fn test_should_create_001_when_no_existing_contracts() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        let id = create_workflow_at(&active, &archive, "feat: test", WorkflowMode::Full)
            .expect("create should succeed");
        assert_eq!(id, format!("wf-{}-001", today()));
        assert!(active.join(format!("{id}.json")).exists());
    }

    /// Issue #142 复现:归档后 active/ 为空,下一个 ID 不得复用 -001。
    #[test]
    fn test_should_increment_id_after_previous_contract_archived() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        seed_archived(&archive, 1);
        let id = create_workflow_at(&active, &archive, "feat: second", WorkflowMode::Full)
            .expect("create should succeed");
        assert_eq!(
            id,
            format!("wf-{}-002", today()),
            "archived -001 must not be reused"
        );
    }

    #[test]
    fn test_create_should_scan_both_active_and_archive_for_max_id() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        seed_active(&active, 2);
        seed_archived(&archive, 3);
        let id = create_workflow_at(&active, &archive, "feat: fourth", WorkflowMode::Fast)
            .expect("create should succeed");
        assert_eq!(id, format!("wf-{}-004", today()));
    }

    #[test]
    fn test_should_not_reuse_id_on_repeated_creates() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        let id1 =
            create_workflow_at(&active, &archive, "feat: a", WorkflowMode::Full).expect("first");
        let id2 =
            create_workflow_at(&active, &archive, "feat: b", WorkflowMode::Full).expect("second");
        assert_ne!(id1, id2, "repeated creates must never share an ID");
        assert!(active.join(format!("{id1}.json")).exists());
        assert!(active.join(format!("{id2}.json")).exists());
    }

    #[test]
    fn test_created_contract_should_match_schema_shape() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        let id = create_workflow_at(&active, &archive, "feat: shape", WorkflowMode::Fast)
            .expect("create should succeed");
        let content =
            std::fs::read_to_string(active.join(format!("{id}.json"))).expect("read contract");
        let contract: WorkflowContract = serde_json::from_str(&content).expect("parse contract");
        assert_eq!(contract.workflow_id, id);
        assert_eq!(contract.title, "feat: shape");
        assert_eq!(contract.current_phase, 1);
        assert!(matches!(contract.mode, WorkflowMode::Fast));
        assert_eq!(contract.phases.len(), 4);
        assert_eq!(
            contract.phases.get("1").expect("phase 1").status,
            PhaseStatus::InProgress
        );
        assert_eq!(
            contract.phases.get("2").expect("phase 2").status,
            PhaseStatus::Pending
        );
    }

    #[test]
    fn test_should_reject_empty_title_on_create() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        assert!(
            create_workflow_at(&active, &archive, "   ", WorkflowMode::Full).is_err(),
            "blank title must be rejected"
        );
    }

    /// Issue #142 衍生问题:归档目标已存在时必须拒绝覆盖。
    #[test]
    fn test_should_reject_archive_when_destination_exists() {
        let tmp = tempfile::TempDir::new().expect("temp dir");
        let active = tmp.path().join("active");
        let archive = tmp.path().join("archive");
        std::fs::create_dir_all(&active).expect("create active");

        let mut contract = base_contract("full");
        contract.current_phase = 4;
        contract.phases.get_mut("4").expect("phase 4").status = PhaseStatus::Complete;
        let id = contract.workflow_id.clone();
        let serialized = serde_json::to_string_pretty(&contract).expect("serialize");
        std::fs::write(active.join(format!("{id}.json")), &serialized).expect("write active");

        // 预置同名归档目标(哨兵内容,验证不被覆盖)
        let month = Utc::now().format("%Y-%m").to_string();
        let month_dir = archive.join(&month);
        std::fs::create_dir_all(&month_dir).expect("create month dir");
        let dst = month_dir.join(format!("{id}.json"));
        std::fs::write(&dst, r#"{"sentinel":"original"}"#).expect("write sentinel");

        let result = archive_workflow_at(&active, &archive, &id);
        assert!(
            result.is_err(),
            "archive must refuse to overwrite an existing destination"
        );
        let preserved = std::fs::read_to_string(&dst).expect("read destination");
        assert_eq!(
            preserved, r#"{"sentinel":"original"}"#,
            "existing archive must be preserved"
        );
        assert!(
            active.join(format!("{id}.json")).exists(),
            "active contract must remain when archive is rejected"
        );
    }

    /// Issue #141:`skill_source`(顶层)与 `ticket_refs`(phase evidence)往返保真。
    #[test]
    fn test_should_roundtrip_skill_source_and_ticket_refs() {
        let mut contract = base_contract("full");
        contract.skill_source = Some("mattpocock".to_string());
        contract
            .phases
            .get_mut("2")
            .expect("phase 2")
            .evidence
            .ticket_refs = Some(vec![
            ".scratch/demo/issues/01-setup.md".to_string(),
            "https://github.com/org/repo/issues/10".to_string(),
        ]);
        let json = serde_json::to_string(&contract).expect("serialize");
        assert!(
            json.contains(r#""skill_source":"mattpocock""#),
            "skill_source must serialize: {json}"
        );
        assert!(
            json.contains(r#""ticket_refs":["#),
            "ticket_refs must serialize: {json}"
        );
        let back: WorkflowContract = serde_json::from_str(&json).expect("deserialize");
        assert_eq!(back.skill_source.as_deref(), Some("mattpocock"));
        let refs = back
            .phases
            .get("2")
            .expect("phase 2")
            .evidence
            .ticket_refs
            .as_ref()
            .expect("ticket_refs");
        assert_eq!(refs.len(), 2);
    }

    /// Issue #141:未设置的新字段不得序列化为 null(与既有 evidence 约定一致)。
    #[test]
    fn test_should_omit_absent_skill_source_and_ticket_refs() {
        let contract = base_contract("full");
        let json = serde_json::to_string(&contract).expect("serialize");
        assert!(
            !json.contains("skill_source"),
            "absent skill_source must be omitted: {json}"
        );
        assert!(
            !json.contains("ticket_refs"),
            "absent ticket_refs must be omitted: {json}"
        );
    }

    /// Issue #141:旧合同(无 `skill_source`)仍可反序列化——向后兼容。
    #[test]
    fn test_should_deserialize_legacy_contract_without_skill_source() {
        let contract: WorkflowContract =
            serde_json::from_str(SCHEMA_EXAMPLE_CONTRACT).expect("legacy contract");
        assert!(contract.skill_source.is_none());
    }
}