gitcortex-indexer 0.2.2

Incremental AST indexer for GitCortex — tree-sitter parsing, git diff, parallel file indexing
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
use std::{
    collections::HashMap,
    path::{Path, PathBuf},
};

use gitcortex_core::{
    error::{GitCortexError, Result},
    graph::{Edge, Node, NodeId, NodeMetadata, Span},
    schema::{EdgeKind, NodeKind, Visibility},
};
use tree_sitter::{Node as TsNode, Parser};

use super::{LanguageParser, ParseResult};

pub struct PythonParser {
    language: tree_sitter::Language,
}

impl PythonParser {
    pub fn new() -> Self {
        Self {
            language: tree_sitter_python::LANGUAGE.into(),
        }
    }
}

impl Default for PythonParser {
    fn default() -> Self {
        Self::new()
    }
}

impl LanguageParser for PythonParser {
    fn extensions(&self) -> &[&str] {
        &["py"]
    }

    fn parse(&self, path: &Path, source: &str) -> Result<ParseResult> {
        let mut parser = Parser::new();
        parser
            .set_language(&self.language)
            .map_err(|e| GitCortexError::Parse {
                file: path.to_owned(),
                message: e.to_string(),
            })?;

        let tree = parser
            .parse(source, None)
            .ok_or_else(|| GitCortexError::Parse {
                file: path.to_owned(),
                message: "tree-sitter returned no parse tree".into(),
            })?;

        let mut visitor = FileVisitor::new(path, source);
        visitor.collect_names(tree.root_node());
        visitor.visit_module(tree.root_node());
        visitor.collect_imports(tree.root_node());

        Ok(ParseResult {
            nodes: visitor.nodes,
            edges: visitor.edges,
            deferred_calls: visitor.deferred_calls,
            deferred_uses: visitor.deferred_uses,
            deferred_implements: visitor.deferred_implements,
            deferred_imports: visitor.deferred_imports,
            deferred_inherits: Vec::new(),
            deferred_throws: Vec::new(),
            deferred_annotated: visitor.deferred_annotated,
        })
    }
}

// ── Internal visitor ──────────────────────────────────────────────────────────

struct FileVisitor<'src> {
    source: &'src [u8],
    file: PathBuf,
    /// NodeId of the file-level Module node (anchor for Imports edges).
    module_id: NodeId,
    nodes: Vec<Node>,
    edges: Vec<Edge>,
    /// class name → NodeId (pass 1)
    class_index: HashMap<String, NodeId>,
    /// function/method name → NodeId (pass 1)
    fn_index: HashMap<String, NodeId>,
    deferred_calls: Vec<(NodeId, String)>,
    deferred_uses: Vec<(NodeId, String)>,
    deferred_implements: Vec<(NodeId, String)>,
    deferred_imports: Vec<(NodeId, String)>,
    deferred_annotated: Vec<(NodeId, String)>,
}

impl<'src> FileVisitor<'src> {
    fn new(file: &Path, source: &'src str) -> Self {
        let module_id = NodeId::new();
        // Derive module name from the file stem (e.g. "auth" from "auth.py").
        let module_name = file
            .file_stem()
            .and_then(|s| s.to_str())
            .unwrap_or("__init__")
            .to_owned();
        let module_node = Node {
            id: module_id.clone(),
            qualified_name: module_name.clone(),
            kind: NodeKind::Module,
            name: module_name,
            file: file.to_owned(),
            span: Span {
                start_line: 1,
                end_line: 1,
            },
            metadata: NodeMetadata {
                loc: source.lines().count() as u32,
                visibility: Visibility::Pub,
                is_async: false,
                is_unsafe: false,
                ..Default::default()
            },
        };
        let nodes = vec![module_node];
        Self {
            source: source.as_bytes(),
            file: file.to_owned(),
            module_id,
            nodes,
            edges: Vec::new(),
            class_index: HashMap::new(),
            fn_index: HashMap::new(),
            deferred_calls: Vec::new(),
            deferred_uses: Vec::new(),
            deferred_implements: Vec::new(),
            deferred_imports: Vec::new(),
            deferred_annotated: Vec::new(),
        }
    }

    fn text<'t>(&self, node: TsNode<'t>) -> &'src str {
        node.utf8_text(self.source).unwrap_or("")
    }

    fn span(node: TsNode<'_>) -> Span {
        Span {
            start_line: node.start_position().row as u32 + 1,
            end_line: node.end_position().row as u32 + 1,
        }
    }

    /// In Python, public = not starting with `_`.
    fn visibility(name: &str) -> Visibility {
        if name.starts_with('_') {
            Visibility::Private
        } else {
            Visibility::Pub
        }
    }

    fn qualified(scope: &[String], name: &str) -> String {
        if scope.is_empty() {
            name.to_owned()
        } else {
            format!("{}.{name}", scope.join("."))
        }
    }

    fn make_node(
        &self,
        id: NodeId,
        kind: NodeKind,
        name: String,
        scope: &[String],
        ts_node: TsNode<'_>,
        is_async: bool,
    ) -> Node {
        let vis = Self::visibility(&name);
        Node {
            id,
            qualified_name: Self::qualified(scope, &name),
            kind,
            name,
            file: self.file.clone(),
            span: Self::span(ts_node),
            metadata: NodeMetadata {
                loc: (ts_node.end_position().row - ts_node.start_position().row + 1) as u32,
                visibility: vis,
                is_async,
                is_unsafe: false,
                ..Default::default()
            },
        }
    }

    // ── Pass 1: pre-allocate NodeIds ──────────────────────────────────────────

    fn collect_names(&mut self, node: TsNode<'_>) {
        let mut cursor = node.walk();
        let children: Vec<TsNode<'_>> = node.named_children(&mut cursor).collect();
        for child in children {
            match child.kind() {
                "class_definition" => {
                    if let Some(name_node) = child.child_by_field_name("name") {
                        let name = self.text(name_node).to_owned();
                        self.class_index.entry(name).or_default();
                    }
                    // Recurse into class body to index nested classes and methods.
                    if let Some(body) = child.child_by_field_name("body") {
                        self.collect_names(body);
                    }
                }
                "function_definition" => {
                    if let Some(name_node) = child.child_by_field_name("name") {
                        let name = self.text(name_node).to_owned();
                        self.fn_index.entry(name).or_default();
                    }
                }
                "decorated_definition" => {
                    let def = child.child_by_field_name("definition");
                    if let Some(def) = def {
                        match def.kind() {
                            "function_definition" => {
                                if let Some(name_node) = def.child_by_field_name("name") {
                                    let name = self.text(name_node).to_owned();
                                    self.fn_index.entry(name).or_default();
                                }
                            }
                            "class_definition" => {
                                if let Some(name_node) = def.child_by_field_name("name") {
                                    let name = self.text(name_node).to_owned();
                                    self.class_index.entry(name).or_default();
                                }
                                // Recurse into decorated nested class body.
                                if let Some(body) = def.child_by_field_name("body") {
                                    self.collect_names(body);
                                }
                            }
                            _ => {}
                        }
                    }
                }
                _ => {}
            }
        }
    }

    // ── Pass 2: emit nodes + edges ────────────────────────────────────────────

    fn visit_module(&mut self, node: TsNode<'_>) {
        let mut cursor = node.walk();
        let children: Vec<TsNode<'_>> = node.named_children(&mut cursor).collect();
        for child in children {
            self.visit_top_level(child, &[]);
        }
    }

    fn visit_top_level(&mut self, node: TsNode<'_>, scope: &[String]) {
        match node.kind() {
            "function_definition" => {
                let is_async = Self::fn_is_async(node);
                self.visit_function(node, scope, None, is_async, &[]);
            }
            "decorated_definition" => {
                let decorators = self.collect_decorators(node);
                let is_async = node
                    .child_by_field_name("definition")
                    .map(Self::fn_is_async)
                    .unwrap_or(false);
                if let Some(def) = node.child_by_field_name("definition") {
                    match def.kind() {
                        "function_definition" => {
                            self.visit_function(def, scope, None, is_async, &decorators)
                        }
                        "class_definition" => self.visit_class(def, scope, &decorators),
                        _ => {}
                    }
                }
            }
            "class_definition" => self.visit_class(node, scope, &[]),
            "expression_statement" => self.maybe_visit_constant(node, scope),
            _ => {}
        }
    }

    fn visit_function(
        &mut self,
        node: TsNode<'_>,
        scope: &[String],
        container_id: Option<NodeId>,
        is_async: bool,
        decorators: &[String],
    ) {
        let Some(name_node) = node.child_by_field_name("name") else {
            return;
        };
        let name = self.text(name_node).to_owned();
        let id = self
            .fn_index
            .get(&name)
            .cloned()
            .unwrap_or_else(NodeId::new);

        // Determine kind and metadata flags from decorators.
        let has_property = decorators.iter().any(|d| d == "property");
        let has_staticmethod = decorators.iter().any(|d| d == "staticmethod");
        let has_classmethod = decorators.iter().any(|d| d == "classmethod");

        let kind = if has_property {
            NodeKind::Property
        } else if container_id.is_some() {
            NodeKind::Method
        } else {
            NodeKind::Function
        };

        // Check if the body contains a `yield` or `yield_from` → generator.
        let is_generator = node
            .child_by_field_name("body")
            .map(|body| Self::body_has_yield(body))
            .unwrap_or(false);

        let mut graph_node = self.make_node(id.clone(), kind, name, scope, node, is_async);
        if has_property {
            graph_node.metadata.is_property = true;
        }
        if has_staticmethod || has_classmethod {
            graph_node.metadata.is_static = true;
        }
        if is_generator {
            graph_node.metadata.is_generator = true;
        }

        if let Some(cid) = container_id {
            self.edges.push(Edge {
                src: cid,
                dst: id.clone(),
                kind: EdgeKind::Contains,
            });
        }
        self.nodes.push(graph_node);

        // Type annotations → Uses edges
        self.extract_param_types(node, &id);
        self.extract_return_type(node, &id);

        // Decorator names → Uses edges (e.g. @property, @staticmethod, @dataclass)
        // and → deferred_annotated edges.
        for dec in decorators {
            self.deferred_uses.push((id.clone(), dec.clone()));
            self.deferred_annotated.push((id.clone(), dec.clone()));
        }

        if let Some(body) = node.child_by_field_name("body") {
            self.collect_calls(body, &id);
        }
    }

    fn visit_class(&mut self, node: TsNode<'_>, scope: &[String], decorators: &[String]) {
        let Some(name_node) = node.child_by_field_name("name") else {
            return;
        };
        let name = self.text(name_node).to_owned();
        let id = self
            .class_index
            .get(&name)
            .cloned()
            .unwrap_or_else(NodeId::new);

        // Determine whether this class inherits from Protocol → Interface.
        let mut is_protocol = false;
        if let Some(bases) = node.child_by_field_name("superclasses") {
            let mut c = bases.walk();
            for base in bases.named_children(&mut c) {
                let base_name = match base.kind() {
                    "identifier" => Some(self.text(base).to_owned()),
                    "attribute" => base
                        .child_by_field_name("attribute")
                        .map(|n| self.text(n).to_owned()),
                    _ => None,
                };
                if base_name.as_deref() == Some("Protocol") {
                    is_protocol = true;
                }
            }
        }

        let class_kind = if is_protocol {
            NodeKind::Interface
        } else {
            NodeKind::Struct
        };

        let mut graph_node =
            self.make_node(id.clone(), class_kind, name.clone(), scope, node, false);
        if is_protocol {
            graph_node.metadata.is_abstract = true;
        }
        self.nodes.push(graph_node);

        // Base classes → Implements edges
        if let Some(bases) = node.child_by_field_name("superclasses") {
            let mut c = bases.walk();
            for base in bases.named_children(&mut c) {
                let base_name = match base.kind() {
                    "identifier" => Some(self.text(base).to_owned()),
                    "attribute" => base
                        .child_by_field_name("attribute")
                        .map(|n| self.text(n).to_owned()),
                    _ => None,
                };
                if let Some(b) = base_name {
                    self.deferred_implements.push((id.clone(), b));
                }
            }
        }

        // Decorator names → Uses edges (e.g. @dataclass) and → deferred_annotated.
        for dec in decorators {
            self.deferred_uses.push((id.clone(), dec.clone()));
            self.deferred_annotated.push((id.clone(), dec.clone()));
        }

        let mut class_scope = scope.to_vec();
        class_scope.push(name.clone());

        if let Some(body) = node.child_by_field_name("body") {
            let mut cursor = body.walk();
            let children: Vec<TsNode<'_>> = body.named_children(&mut cursor).collect();
            for child in children {
                match child.kind() {
                    "function_definition" => {
                        let is_async = Self::fn_is_async(child);
                        self.visit_function(child, &class_scope, Some(id.clone()), is_async, &[]);
                    }
                    "decorated_definition" => {
                        let method_decorators = self.collect_decorators(child);
                        let is_async = child
                            .child_by_field_name("definition")
                            .map(Self::fn_is_async)
                            .unwrap_or(false);
                        if let Some(def) = child.child_by_field_name("definition") {
                            match def.kind() {
                                "function_definition" => {
                                    self.visit_function(
                                        def,
                                        &class_scope,
                                        Some(id.clone()),
                                        is_async,
                                        &method_decorators,
                                    );
                                }
                                "class_definition" => {
                                    self.visit_class(def, &class_scope, &method_decorators);
                                    // Add Contains edge from parent class to nested class.
                                    if let Some(nested_name_node) = def.child_by_field_name("name")
                                    {
                                        let nested_name = self.text(nested_name_node).to_owned();
                                        if let Some(nested_id) =
                                            self.class_index.get(&nested_name).cloned()
                                        {
                                            self.edges.push(Edge {
                                                src: id.clone(),
                                                dst: nested_id,
                                                kind: EdgeKind::Contains,
                                            });
                                        }
                                    }
                                }
                                _ => {}
                            }
                        }
                    }
                    "class_definition" => {
                        self.visit_class(child, &class_scope, &[]);
                        // Add Contains edge from parent class to nested class.
                        if let Some(nested_name_node) = child.child_by_field_name("name") {
                            let nested_name = self.text(nested_name_node).to_owned();
                            if let Some(nested_id) = self.class_index.get(&nested_name).cloned() {
                                self.edges.push(Edge {
                                    src: id.clone(),
                                    dst: nested_id,
                                    kind: EdgeKind::Contains,
                                });
                            }
                        }
                    }
                    _ => {}
                }
            }
        }
    }

    fn maybe_visit_constant(&mut self, node: TsNode<'_>, scope: &[String]) {
        let mut cursor = node.walk();
        for child in node.named_children(&mut cursor) {
            if child.kind() == "assignment" {
                if let Some(left) = child.child_by_field_name("left") {
                    if left.kind() == "identifier" {
                        let name = self.text(left).to_owned();
                        if name
                            .chars()
                            .all(|c| c.is_uppercase() || c == '_' || c.is_ascii_digit())
                            && name.len() > 1
                            && !name.starts_with('_')
                        {
                            let id = NodeId::new();
                            let graph_node =
                                self.make_node(id, NodeKind::Constant, name, scope, node, false);
                            self.nodes.push(graph_node);
                        }
                    }
                }
            }
        }
    }

    // ── Pass 3: collect import statements ────────────────────────────────────

    fn collect_imports(&mut self, node: TsNode<'_>) {
        let mut cursor = node.walk();
        let children: Vec<TsNode<'_>> = node.named_children(&mut cursor).collect();
        for child in children {
            match child.kind() {
                "import_statement" => {
                    // `import foo`, `import foo.bar`, `import foo as f`
                    let mut c = child.walk();
                    for name_node in child.named_children(&mut c) {
                        let leaf = match name_node.kind() {
                            "dotted_name" => {
                                let text = self.text(name_node);
                                text.split('.').next_back().map(|s| s.to_owned())
                            }
                            "aliased_import" => name_node
                                .child_by_field_name("name")
                                .map(|n| self.text(n))
                                .map(|t| t.split('.').next_back().unwrap_or(t).to_owned()),
                            _ => None,
                        };
                        if let Some(name) = leaf {
                            self.deferred_imports.push((self.module_id.clone(), name));
                        }
                    }
                }
                "import_from_statement" => {
                    // `from foo import bar, baz`
                    // Named children: first is the source module (dotted_name or
                    // relative_import), the rest are the imported names.
                    let mut c = child.walk();
                    let all_children: Vec<TsNode<'_>> = child.named_children(&mut c).collect();
                    for name_node in all_children.iter().skip(1) {
                        let leaf = match name_node.kind() {
                            "dotted_name" => {
                                let text = self.text(*name_node);
                                Some(text.split('.').next_back().unwrap_or(text).to_owned())
                            }
                            "aliased_import" => name_node
                                .child_by_field_name("name")
                                .map(|n| self.text(n))
                                .map(|t| t.split('.').next_back().unwrap_or(t).to_owned()),
                            "wildcard_import" => None,
                            _ => None,
                        };
                        if let Some(name) = leaf {
                            self.deferred_imports.push((self.module_id.clone(), name));
                        }
                    }
                }
                _ => {}
            }
        }
    }

    // ── Call collection ───────────────────────────────────────────────────────

    fn collect_calls(&mut self, node: TsNode<'_>, caller_id: &NodeId) {
        let mut cursor = node.walk();
        let children: Vec<TsNode<'_>> = node.named_children(&mut cursor).collect();
        for child in children {
            if child.kind() == "call" {
                if let Some(callee) = self.callee_name(child) {
                    self.record_call(caller_id.clone(), callee);
                }
                if let Some(args) = child.child_by_field_name("arguments") {
                    self.collect_calls(args, caller_id);
                }
            } else {
                self.collect_calls(child, caller_id);
            }
        }
    }

    fn callee_name(&self, call_node: TsNode<'_>) -> Option<String> {
        let func = call_node.child_by_field_name("function")?;
        match func.kind() {
            "identifier" => Some(self.text(func).to_owned()),
            "attribute" => func
                .child_by_field_name("attribute")
                .map(|n| self.text(n).to_owned()),
            _ => None,
        }
    }

    fn record_call(&mut self, caller_id: NodeId, callee_name: String) {
        if callee_name.is_empty() {
            return;
        }
        if let Some(callee_id) = self.fn_index.get(&callee_name).cloned() {
            let edge = Edge {
                src: caller_id,
                dst: callee_id,
                kind: EdgeKind::Calls,
            };
            if !self.edges.contains(&edge) {
                self.edges.push(edge);
            }
        } else if !self
            .deferred_calls
            .iter()
            .any(|(c, n)| c == &caller_id && n == &callee_name)
        {
            self.deferred_calls.push((caller_id, callee_name));
        }
    }

    // ── Helpers ───────────────────────────────────────────────────────────────

    /// Returns true if this `function_definition` node is `async def`.
    fn fn_is_async(node: TsNode<'_>) -> bool {
        let mut c = node.walk();
        // `async` appears as an anonymous child (keyword) before `def`
        let result = node.children(&mut c).any(|n| n.kind() == "async");
        result
    }

    /// Returns true if the body subtree contains a `yield` or `yield_from` expression.
    fn body_has_yield(node: TsNode<'_>) -> bool {
        if node.kind() == "yield" || node.kind() == "yield_from" {
            return true;
        }
        // Don't descend into nested function definitions — their yields are not
        // generators of the outer function.
        if node.kind() == "function_definition" {
            return false;
        }
        let mut c = node.walk();
        let found = node.named_children(&mut c).any(Self::body_has_yield);
        found
    }

    /// Extract decorator names from a `decorated_definition` node.
    fn collect_decorators(&self, node: TsNode<'_>) -> Vec<String> {
        let mut c = node.walk();
        node.named_children(&mut c)
            .filter(|n| n.kind() == "decorator")
            .filter_map(|d| self.decorator_name(d))
            .collect()
    }

    /// Get the callable name from a `decorator` node.
    fn decorator_name(&self, decorator: TsNode<'_>) -> Option<String> {
        let mut c = decorator.walk();
        let child = decorator.named_children(&mut c).next()?;
        match child.kind() {
            "identifier" => Some(self.text(child).to_owned()),
            "attribute" => child
                .child_by_field_name("attribute")
                .map(|n| self.text(n).to_owned()),
            "call" => child
                .child_by_field_name("function")
                .and_then(|f| match f.kind() {
                    "identifier" => Some(self.text(f).to_owned()),
                    "attribute" => f
                        .child_by_field_name("attribute")
                        .map(|n| self.text(n).to_owned()),
                    _ => None,
                }),
            _ => None,
        }
    }

    /// Extract type identifiers from a type-annotation node.
    /// Records all identifiers found (e.g. `List[MyType]` → ["List", "MyType"]).
    fn extract_param_types(&mut self, fn_node: TsNode<'_>, fn_id: &NodeId) {
        let Some(params) = fn_node.child_by_field_name("parameters") else {
            return;
        };
        let mut c = params.walk();
        for param in params.named_children(&mut c) {
            let type_node = match param.kind() {
                "typed_parameter" | "typed_default_parameter" => param.child_by_field_name("type"),
                _ => None,
            };
            if let Some(t) = type_node {
                for name in self.collect_type_names(t) {
                    self.deferred_uses.push((fn_id.clone(), name));
                }
            }
        }
    }

    fn extract_return_type(&mut self, fn_node: TsNode<'_>, fn_id: &NodeId) {
        if let Some(ret) = fn_node.child_by_field_name("return_type") {
            for name in self.collect_type_names(ret) {
                self.deferred_uses.push((fn_id.clone(), name));
            }
        }
    }

    /// Walk a type-annotation subtree and collect all identifier names.
    fn collect_type_names(&self, node: TsNode<'_>) -> Vec<String> {
        let mut names = Vec::new();
        self.walk_type_names(node, &mut names);
        names
    }

    fn walk_type_names(&self, node: TsNode<'_>, out: &mut Vec<String>) {
        match node.kind() {
            "identifier" => {
                let name = self.text(node).to_owned();
                if !is_builtin_type(&name) {
                    out.push(name);
                }
            }
            _ => {
                let mut c = node.walk();
                for child in node.named_children(&mut c) {
                    self.walk_type_names(child, out);
                }
            }
        }
    }
}

/// Returns true for built-in Python types and typing-module generics that do
/// not correspond to user-defined symbols.
fn is_builtin_type(name: &str) -> bool {
    matches!(
        name,
        "int"
            | "str"
            | "bool"
            | "float"
            | "complex"
            | "bytes"
            | "bytearray"
            | "None"
            | "list"
            | "dict"
            | "set"
            | "frozenset"
            | "tuple"
            | "type"
            | "object"
            | "Any"
            | "Optional"
            | "Union"
            | "List"
            | "Dict"
            | "Set"
            | "FrozenSet"
            | "Tuple"
            | "Callable"
            | "Type"
            | "ClassVar"
            | "Final"
            | "Literal"
            | "TypeVar"
            | "Generic"
            | "Protocol"
            | "Sequence"
            | "Iterable"
            | "Iterator"
            | "Generator"
            | "Coroutine"
            | "Awaitable"
            | "AsyncIterator"
            | "AsyncGenerator"
            | "NoReturn"
            | "Never"
            | "Self"
            | "Annotated"
            | "TypeAlias"
            | "ParamSpec"
            | "TypeVarTuple"
            | "overload"
            | "abstractmethod"
            | "staticmethod"
            | "classmethod"
    )
}

// ── Tests ─────────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::PythonParser;
    use crate::parser::LanguageParser;
    use gitcortex_core::schema::{EdgeKind, NodeKind};
    use std::path::Path;

    fn parse(
        src: &str,
    ) -> (
        Vec<gitcortex_core::graph::Node>,
        Vec<gitcortex_core::graph::Edge>,
    ) {
        let r = PythonParser::new()
            .parse(Path::new("test.py"), src)
            .unwrap();
        (r.nodes, r.edges)
    }

    #[allow(clippy::type_complexity)]
    fn parse_full(
        src: &str,
    ) -> (
        Vec<gitcortex_core::graph::Node>,
        Vec<gitcortex_core::graph::Edge>,
        Vec<(gitcortex_core::graph::NodeId, String)>,
        Vec<(gitcortex_core::graph::NodeId, String)>,
        Vec<(gitcortex_core::graph::NodeId, String)>,
        Vec<(gitcortex_core::graph::NodeId, String)>,
    ) {
        let r = PythonParser::new()
            .parse(Path::new("test.py"), src)
            .unwrap();
        (
            r.nodes,
            r.edges,
            r.deferred_calls,
            r.deferred_uses,
            r.deferred_implements,
            r.deferred_imports,
        )
    }

    #[test]
    fn parses_free_function() {
        let (nodes, _) = parse("def greet(name):\n    return name\n");
        // Module node + Function node
        assert_eq!(nodes.len(), 2);
        let fns: Vec<_> = nodes
            .iter()
            .filter(|n| n.kind == NodeKind::Function)
            .collect();
        assert_eq!(fns.len(), 1);
        assert_eq!(fns[0].name, "greet");
    }

    #[test]
    fn parses_class_and_method() {
        let src = "class Person:\n    def greet(self):\n        pass\n";
        let (nodes, edges) = parse(src);
        let classes: Vec<_> = nodes
            .iter()
            .filter(|n| n.kind == NodeKind::Struct)
            .collect();
        let methods: Vec<_> = nodes
            .iter()
            .filter(|n| n.kind == NodeKind::Method)
            .collect();
        assert_eq!(classes.len(), 1);
        assert_eq!(methods.len(), 1);
        let contains: Vec<_> = edges
            .iter()
            .filter(|e| e.kind == EdgeKind::Contains)
            .collect();
        assert!(!contains.is_empty());
    }

    #[test]
    fn detects_call_edges() {
        let src = "def caller():\n    callee()\ndef callee():\n    pass\n";
        let (_, edges) = parse(src);
        let calls: Vec<_> = edges.iter().filter(|e| e.kind == EdgeKind::Calls).collect();
        assert_eq!(calls.len(), 1);
    }

    #[test]
    fn detects_base_class_implements() {
        let src = "class Base:\n    pass\nclass Child(Base):\n    pass\n";
        let (_, _, _, _, implements, _) = parse_full(src);
        assert!(
            implements.iter().any(|(_, name)| name == "Base"),
            "expected Implements edge to Base, got: {implements:?}"
        );
    }

    #[test]
    fn detects_type_annotation_uses() {
        let src = "class Foo:\n    pass\ndef bar(x: Foo) -> Foo:\n    pass\n";
        let (_, _, _, uses, _, _) = parse_full(src);
        let uses_foo: Vec<_> = uses.iter().filter(|(_, n)| n == "Foo").collect();
        assert!(
            uses_foo.len() >= 2,
            "expected at least 2 Uses edges to Foo, got: {uses_foo:?}"
        );
    }

    #[test]
    fn detects_decorator_uses() {
        let src = "class Foo:\n    @property\n    def name(self):\n        return self._name\n";
        let (_, _, _, uses, _, _) = parse_full(src);
        assert!(
            uses.iter().any(|(_, n)| n == "property"),
            "expected Uses edge to 'property' decorator, got: {uses:?}"
        );
    }

    #[test]
    fn detects_import_statement() {
        let src = "import os\nimport sys\n\ndef main():\n    pass\n";
        let (_, _, _, _, _, imports) = parse_full(src);
        assert!(
            imports.iter().any(|(_, n)| n == "os"),
            "expected import 'os', got: {imports:?}"
        );
        assert!(
            imports.iter().any(|(_, n)| n == "sys"),
            "expected import 'sys', got: {imports:?}"
        );
    }

    #[test]
    fn detects_from_import_statement() {
        let src = "from os.path import join, exists\n\ndef main():\n    pass\n";
        let (_, _, _, _, _, imports) = parse_full(src);
        assert!(
            imports.iter().any(|(_, n)| n == "join"),
            "expected import 'join', got: {imports:?}"
        );
        assert!(
            imports.iter().any(|(_, n)| n == "exists"),
            "expected import 'exists', got: {imports:?}"
        );
    }

    #[test]
    fn module_node_is_emitted() {
        let (nodes, _) = parse("x = 1\n");
        let modules: Vec<_> = nodes
            .iter()
            .filter(|n| n.kind == NodeKind::Module)
            .collect();
        assert_eq!(modules.len(), 1);
        assert_eq!(modules[0].name, "test");
    }

    #[test]
    fn async_function_flagged() {
        let src = "async def fetch():\n    pass\n";
        let (nodes, _) = parse(src);
        let fns: Vec<_> = nodes
            .iter()
            .filter(|n| n.kind == NodeKind::Function)
            .collect();
        assert_eq!(fns.len(), 1);
        assert!(fns[0].metadata.is_async);
    }
}