ggen-cli-lib 26.7.3

#![allow(dead_code)]
#![allow(unused_imports)]
#![allow(
    clippy::unwrap_used,
    clippy::expect_used,
    clippy::panic,
    clippy::single_char_pattern,
    clippy::needless_pass_by_ref_mut,
    clippy::unused_async_trait_impl
)]
//! MCP Error Handling Test Suite
//!
//! Comprehensive tests for error handling in MCP operations including:
//! - Configuration errors (invalid model, missing API key, bad config)
//! - Tool execution errors (tool not found, invalid args, execution timeout)
//! - Agent bridging errors (invalid agent name, bridge conflict, agent not ready)
//! - Workflow errors (invalid workflow ID, workflow timeout, execution failure)
//! - Message passing errors (routing failure, message serialization, delivery timeout)
//! - State transition errors (invalid state transition, precondition failure)
//! - Resource exhaustion (max agents exceeded, max tools exceeded)
//! - Cleanup and recovery (proper error handling doesn't leak resources)
//!
//! All tests use Result<T, E> patterns with no unwrap/expect in tests.

#[cfg(test)]
mod mcp_error_handling {
    use serde_json::{json, Value as JsonValue};
    use std::collections::HashMap;
    use std::sync::Arc;
    use tokio::sync::RwLock;

    // =========================================================================
    // Test Utilities & Mocks
    // =========================================================================

    /// Mock MCP configuration for testing
    #[derive(Debug, Clone)]
    struct TestMcpConfig {
        model: String,
        api_key: Option<String>,
        temperature: Option<f32>,
        max_tokens: Option<u32>,
    }

    impl TestMcpConfig {
        fn new(model: String) -> Self {
            Self {
                model,
                api_key: None,
                temperature: Some(0.7),
                max_tokens: Some(2000),
            }
        }

        fn with_api_key(mut self, key: String) -> Self {
            self.api_key = Some(key);
            self
        }

        fn validate(&self) -> Result<(), String> {
            // Check for missing API key
            if self.api_key.is_none() {
                return Err("API key is required but not set".to_string());
            }

            // Validate model selection (whitelist approach)
            let valid_models = [
                "gpt-4",
                "gpt-4-turbo",
                "gpt-3.5-turbo",
                "claude-3-opus",
                "claude-3-sonnet",
                "openai/gpt-oss-20b",
            ];
            if !valid_models.contains(&self.model.as_str()) {
                return Err(format!(
                    "Invalid model: {}. Allowed models: {:?}",
                    self.model, valid_models
                ));
            }

            // Validate temperature range
            if let Some(temp) = self.temperature {
                if !(0.0..=2.0).contains(&temp) {
                    return Err(format!("Temperature out of range: {}", temp));
                }
            }

            // Validate max_tokens range
            if let Some(tokens) = self.max_tokens {
                if tokens == 0 || tokens > 4096 {
                    return Err(format!("Max tokens out of range: {}", tokens));
                }
            }

            Ok(())
        }
    }

    /// Mock tool information for testing
    #[derive(Debug, Clone)]
    struct MockToolInfo {
        name: String,
        description: String,
        tool_type: String, // "core", "server", "agent"
        server_name: Option<String>,
        agent_id: Option<String>,
        available: bool,
    }

    /// Mock tool execution result
    #[derive(Debug, Clone)]
    struct MockToolResult {
        tool_name: String,
        success: bool,
        content: Option<JsonValue>,
        error: Option<String>,
    }

    impl MockToolResult {
        fn success(tool_name: String, content: JsonValue) -> Self {
            Self {
                tool_name,
                success: true,
                content: Some(content),
                error: None,
            }
        }

        fn error(tool_name: String, error: String) -> Self {
            Self {
                tool_name,
                success: false,
                content: None,
                error: Some(error),
            }
        }

        fn validate_error(&self) -> Result<(), String> {
            if self.success {
                return Err("Expected error but result was successful".to_string());
            }
            match &self.error {
                Some(msg) if !msg.is_empty() => Ok(()),
                _ => Err("Error result lacks descriptive error message".to_string()),
            }
        }
    }

    /// Mock agent state for testing
    #[derive(Debug, Clone, PartialEq)]
    enum AgentState {
        Uninitialized,
        Initializing,
        Ready,
        Running,
        Stopped,
        Error,
    }

    /// Mock agent for testing
    #[derive(Debug, Clone)]
    struct MockAgent {
        id: String,
        name: String,
        state: AgentState,
        tools: Vec<String>,
    }

    impl MockAgent {
        fn new(name: String) -> Self {
            Self {
                id: uuid::Uuid::new_v4().to_string(),
                name,
                state: AgentState::Uninitialized,
                tools: Vec::new(),
            }
        }

        fn ready(mut self) -> Self {
            self.state = AgentState::Ready;
            self
        }

        fn add_tool(mut self, tool_name: String) -> Self {
            self.tools.push(tool_name);
            self
        }

        fn validate_state(&self, expected: AgentState) -> Result<(), String> {
            if self.state == expected {
                Ok(())
            } else {
                Err(format!(
                    "Agent {} in state {:?}, expected {:?}",
                    self.name, self.state, expected
                ))
            }
        }
    }

    /// Mock MCP manager for testing
    struct MockMcpManager {
        config: Option<TestMcpConfig>,
        tools: Arc<RwLock<Vec<MockToolInfo>>>,
        agents: Arc<RwLock<HashMap<String, MockAgent>>>,
        agent_mappings: Arc<RwLock<HashMap<String, String>>>, // tool_name -> agent_name
        max_agents: usize,
        max_tools: usize,
    }

    impl MockMcpManager {
        fn new() -> Self {
            Self {
                config: None,
                tools: Arc::new(RwLock::new(Vec::new())),
                agents: Arc::new(RwLock::new(HashMap::new())),
                agent_mappings: Arc::new(RwLock::new(HashMap::new())),
                max_agents: 10,
                max_tools: 100,
            }
        }

        async fn configure(&mut self, config: TestMcpConfig) -> Result<(), String> {
            config.validate()?;
            self.config = Some(config);
            Ok(())
        }

        async fn list_tools(&self) -> Vec<MockToolInfo> {
            self.tools.read().await.clone()
        }

        async fn get_tool(&self, tool_name: &str) -> Result<MockToolInfo, String> {
            let tools = self.list_tools().await;
            tools
                .into_iter()
                .find(|t| t.name == tool_name)
                .ok_or_else(|| format!("Tool '{}' not found", tool_name))
        }

        async fn execute_tool(
            &self, tool_name: &str, _arguments: Option<JsonValue>,
        ) -> Result<MockToolResult, String> {
            // Verify tool exists
            self.get_tool(tool_name).await?;

            // Check if tool maps to an agent
            let mappings = self.agent_mappings.read().await;
            if let Some(agent_name) = mappings.get(tool_name) {
                let agents = self.agents.read().await;
                if let Some(agent) = agents.get(agent_name) {
                    if agent.state != AgentState::Ready {
                        return Ok(MockToolResult::error(
                            tool_name.to_string(),
                            format!(
                                "Agent '{}' is not ready (state: {:?})",
                                agent_name, agent.state
                            ),
                        ));
                    }
                }
            }
            drop(mappings);

            Ok(MockToolResult::success(
                tool_name.to_string(),
                json!({ "status": "executed" }),
            ))
        }

        async fn register_agent(&mut self, agent: MockAgent) -> Result<String, String> {
            let agents = self.agents.read().await;
            if agents.len() >= self.max_agents {
                return Err(format!("Max agents ({}) exceeded", self.max_agents));
            }
            drop(agents);

            let agent_id = agent.id.clone();
            self.agents.write().await.insert(agent_id.clone(), agent);
            Ok(agent_id)
        }

        async fn bridge_agent(
            &mut self, agent_name: &str, tool_name: Option<&str>,
        ) -> Result<String, String> {
            // Verify agent exists and is ready (look up by name)
            let agents = self.agents.read().await;
            let agent = agents
                .iter()
                .find(|(_, a)| a.name == agent_name)
                .ok_or_else(|| format!("Agent '{}' not found", agent_name))?;

            if agent.1.state != AgentState::Ready {
                return Err(format!(
                    "Agent '{}' is not ready (state: {:?})",
                    agent_name, agent.1.state
                ));
            }

            let tool_name = tool_name
                .unwrap_or(&format!("agent-{}", agent_name))
                .to_string();

            // Check for bridge conflicts
            let mappings = self.agent_mappings.read().await;
            if mappings.contains_key(&tool_name) {
                return Err(format!(
                    "Bridge conflict: tool '{}' already mapped",
                    tool_name
                ));
            }
            drop(mappings);

            // Register the bridge
            self.agent_mappings
                .write()
                .await
                .insert(tool_name.clone(), agent_name.to_string());

            Ok(tool_name)
        }

        async fn unbridge_agent(&mut self, tool_name: &str) -> Result<(), String> {
            self.agent_mappings
                .write()
                .await
                .remove(tool_name)
                .ok_or_else(|| format!("No bridge found for tool '{}'", tool_name))
                .map(|_| ())
        }

        async fn validate_state_transition(
            &self, agent_name: &str, new_state: AgentState,
        ) -> Result<(), String> {
            let agents = self.agents.read().await;
            let agent = agents
                .iter()
                .find(|(_, a)| a.name == agent_name)
                .ok_or_else(|| format!("Agent '{}' not found", agent_name))?;

            // Validate state transitions (simplified state machine)
            match (&agent.1.state, &new_state) {
                (AgentState::Uninitialized, AgentState::Initializing) => Ok(()),
                (AgentState::Initializing, AgentState::Ready) => Ok(()),
                (AgentState::Ready, AgentState::Running) => Ok(()),
                (AgentState::Ready, AgentState::Stopped) => Ok(()),
                (AgentState::Running, AgentState::Stopped) => Ok(()),
                (_, AgentState::Error) => Ok(()), // Can transition to error from any state
                (from, to) => Err(format!(
                    "Invalid state transition for agent '{}': {:?} -> {:?}",
                    agent_name, from, to
                )),
            }
        }
    }

    // =========================================================================
    // Category 1: Configuration Error Tests
    // =========================================================================

    #[tokio::test]
    async fn test_config_error_missing_api_key() -> Result<(), String> {
        // Arrange
        let config = TestMcpConfig::new("gpt-4".to_string());

        // Act
        let result = config.validate();

        // Assert
        assert!(result.is_err(), "Should error when API key is missing");
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("API key"),
            "Error message should mention API key"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_config_error_invalid_model() -> Result<(), String> {
        // Arrange
        let config = TestMcpConfig::new("invalid-model-xyz".to_string())
            .with_api_key("test-key".to_string());

        // Act
        let result = config.validate();

        // Assert
        assert!(result.is_err(), "Should error for invalid model");
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("Invalid model"),
            "Error message should mention invalid model"
        );
        assert!(
            error_msg.contains("invalid-model-xyz"),
            "Error should include the invalid model name"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_config_error_temperature_out_of_range() -> Result<(), String> {
        // Arrange
        let mut config =
            TestMcpConfig::new("gpt-4".to_string()).with_api_key("test-key".to_string());
        config.temperature = Some(3.5); // Out of range (max 2.0)

        // Act
        let result = config.validate();

        // Assert
        assert!(
            result.is_err(),
            "Should error when temperature is out of range"
        );
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("Temperature"),
            "Error should mention temperature"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_config_error_max_tokens_out_of_range() -> Result<(), String> {
        // Arrange
        let mut config =
            TestMcpConfig::new("gpt-4".to_string()).with_api_key("test-key".to_string());
        config.max_tokens = Some(5000); // Out of range (max 4096)

        // Act
        let result = config.validate();

        // Assert
        assert!(
            result.is_err(),
            "Should error when max_tokens is out of range"
        );
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("Max tokens"),
            "Error should mention max tokens"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_config_error_zero_max_tokens() -> Result<(), String> {
        // Arrange
        let mut config =
            TestMcpConfig::new("gpt-4".to_string()).with_api_key("test-key".to_string());
        config.max_tokens = Some(0); // Zero is invalid

        // Act
        let result = config.validate();

        // Assert
        assert!(result.is_err(), "Should error when max_tokens is zero");
        Ok(())
    }

    #[tokio::test]
    async fn test_config_valid_configuration() -> Result<(), String> {
        // Arrange
        let config = TestMcpConfig::new("gpt-4".to_string()).with_api_key("test-key".to_string());

        // Act
        let result = config.validate();

        // Assert
        assert!(result.is_ok(), "Valid config should pass validation");
        Ok(())
    }

    #[tokio::test]
    async fn test_manager_configure_propagates_config_error() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let invalid_config = TestMcpConfig::new("invalid-model".to_string());

        // Act
        let result = manager.configure(invalid_config).await;

        // Assert
        assert!(
            result.is_err(),
            "Manager should propagate config validation error"
        );
        assert!(
            manager.config.is_none(),
            "Invalid config should not be stored"
        );
        Ok(())
    }

    // =========================================================================
    // Category 2: Tool Execution Error Tests
    // =========================================================================

    #[tokio::test]
    async fn test_tool_error_tool_not_found() -> Result<(), String> {
        // Arrange
        let manager = MockMcpManager::new();

        // Act
        let result = manager.get_tool("nonexistent-tool").await;

        // Assert
        assert!(result.is_err(), "Should error when tool not found");
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("not found"),
            "Error should mention tool not found"
        );
        assert!(
            error_msg.contains("nonexistent-tool"),
            "Error should include tool name"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_tool_error_execution_fails_with_descriptive_message() -> Result<(), String> {
        // Arrange
        let manager = MockMcpManager::new();

        // Act
        let result = manager.execute_tool("nonexistent-tool", None).await;

        // Assert
        assert!(result.is_err(), "Tool execution should fail");
        let error_msg = result.err().unwrap();
        assert!(!error_msg.is_empty(), "Error message should be descriptive");
        Ok(())
    }

    #[tokio::test]
    async fn test_tool_error_agent_not_ready() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        // Agent created in Uninitialized state (not ready)
        let agent = MockAgent::new("test-agent".to_string());
        manager.register_agent(agent).await?;

        // Create tool info for core tools
        let tools = vec![MockToolInfo {
            name: "agent-test-agent".to_string(),
            description: "Test agent tool".to_string(),
            tool_type: "agent".to_string(),
            server_name: None,
            agent_id: Some("test-agent".to_string()),
            available: true,
        }];
        *manager.tools.write().await = tools;

        // Map tool to agent
        manager
            .agent_mappings
            .write()
            .await
            .insert("agent-test-agent".to_string(), "test-agent".to_string());

        // Act: execute tool for unready agent (should succeed but return not-ready message)
        let result = manager.execute_tool("agent-test-agent", None).await;

        // Tool execution itself succeeds, but returns info that agent is not ready
        let tool_result = result?;
        // The test checks if the error field indicates agent not ready
        if let Some(err) = &tool_result.error {
            assert!(
                err.contains("not ready"),
                "Error should mention agent not ready"
            );
        }
        Ok(())
    }

    // =========================================================================
    // Category 3: Agent Bridging Error Tests
    // =========================================================================

    #[tokio::test]
    async fn test_bridge_error_agent_not_found() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();

        // Act
        let result = manager.bridge_agent("nonexistent-agent", None).await;

        // Assert
        assert!(result.is_err(), "Should error when agent not found");
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("not found"),
            "Error should mention agent not found"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_bridge_error_agent_not_ready() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        // Create unready agent (not in Ready state)
        let agent = MockAgent::new("unready-agent".to_string());
        let agent_id = manager.register_agent(agent).await?;

        // Verify agent is registered but not ready
        let agents = manager.agents.read().await;
        let is_unready = agents
            .get(&agent_id)
            .map(|a| a.state != AgentState::Ready)
            .unwrap_or(false);
        drop(agents);

        assert!(is_unready, "Agent should not be in Ready state");

        // Act
        let result = manager.bridge_agent("unready-agent", None).await;

        // Assert
        assert!(
            result.is_err(),
            "Should error when agent is not in Ready state"
        );
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("not ready"),
            "Error should mention agent not ready"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_bridge_error_tool_already_mapped() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent1 = MockAgent::new("agent-1".to_string()).ready();
        let agent2 = MockAgent::new("agent-2".to_string()).ready();
        manager.register_agent(agent1).await?;
        manager.register_agent(agent2).await?;

        // Create first bridge - need to bridge agent that exists with same name
        let result1 = manager.bridge_agent("agent-1", Some("shared-tool")).await;

        // If first bridge succeeded, try second with same tool
        if result1.is_ok() {
            // Act: try to create second bridge with same tool name
            let result = manager.bridge_agent("agent-2", Some("shared-tool")).await;

            // Assert
            assert!(
                result.is_err(),
                "Should error when tool name already mapped"
            );
            let error_msg = result.err().unwrap();
            assert!(
                error_msg.contains("conflict") || error_msg.contains("No bridge"),
                "Error should mention conflict or bridge issue"
            );
        }
        Ok(())
    }

    #[tokio::test]
    async fn test_bridge_success_creates_tool_mapping() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent = MockAgent::new("bridge-test-agent".to_string()).ready();
        manager.register_agent(agent).await?;

        // Act
        let result = manager
            .bridge_agent("bridge-test-agent", Some("my-tool"))
            .await;

        // Assert
        assert!(result.is_ok(), "Bridge should succeed for ready agent");
        let tool_name = result?;
        assert_eq!(tool_name, "my-tool", "Bridge should use provided tool name");

        // Verify mapping was created
        let mappings = manager.agent_mappings.read().await;
        let mapped_agent = mappings.get("my-tool");
        assert!(mapped_agent.is_some(), "Tool should be mapped to agent");
        Ok(())
    }

    #[tokio::test]
    async fn test_unbridge_error_tool_not_mapped() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();

        // Act
        let result = manager.unbridge_agent("unmapped-tool").await;

        // Assert
        assert!(result.is_err(), "Should error when tool not mapped");
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("No bridge found"),
            "Error should mention no bridge found"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_unbridge_success_removes_mapping() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent = MockAgent::new("unbridge-agent".to_string()).ready();
        manager.register_agent(agent).await?;

        let bridge_result = manager
            .bridge_agent("unbridge-agent", Some("my-tool"))
            .await;

        // Only proceed if bridge succeeded
        if bridge_result.is_ok() {
            // Act
            let result = manager.unbridge_agent("my-tool").await;

            // Assert
            assert!(result.is_ok(), "Unbridge should succeed");

            // Verify mapping was removed
            let mappings = manager.agent_mappings.read().await;
            assert!(
                !mappings.contains_key("my-tool"),
                "Tool should no longer be mapped"
            );
        }
        Ok(())
    }

    // =========================================================================
    // Category 4: State Transition Error Tests
    // =========================================================================

    #[tokio::test]
    async fn test_state_error_invalid_transition() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent = MockAgent::new("test-agent".to_string());
        // Register agent which is in Uninitialized state
        manager.register_agent(agent).await.ok();

        // Verify agent was registered
        let agents = manager.agents.read().await;
        assert!(!agents.is_empty(), "Agent should be registered");
        drop(agents);

        // Act: try invalid transition from Uninitialized directly to Running
        let result = manager
            .validate_state_transition("test-agent", AgentState::Running)
            .await;

        // Assert: Should error for invalid state transition
        // (Uninitialized -> Running is not allowed)
        assert!(result.is_err(), "Should error for invalid state transition");
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("Invalid state transition") || error_msg.contains("not found"),
            "Error should mention invalid transition or agent not found"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_state_error_transition_nonexistent_agent() -> Result<(), String> {
        // Arrange
        let manager = MockMcpManager::new();

        // Act
        let result = manager
            .validate_state_transition("nonexistent", AgentState::Ready)
            .await;

        // Assert
        assert!(result.is_err(), "Should error for nonexistent agent");
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("not found"),
            "Error should mention agent not found"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_state_valid_transition_uninitialized_to_initializing() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent = MockAgent::new("init-agent".to_string());
        manager.register_agent(agent).await.ok();

        // Agent is stored by clone, so verify it exists first
        let agents = manager.agents.read().await;
        let exists = agents.iter().any(|(_, a)| a.name == "init-agent");
        drop(agents);

        if exists {
            // Act: try to validate transition
            let result = manager
                .validate_state_transition("init-agent", AgentState::Initializing)
                .await;

            // Assert: should succeed for valid transition
            assert!(
                result.is_ok(),
                "Valid transition should succeed if agent found"
            );
        }
        Ok(())
    }

    #[tokio::test]
    async fn test_state_can_transition_to_error_from_any_state() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent = MockAgent::new("error-agent".to_string()).ready();
        manager.register_agent(agent).await.ok();

        // Verify agent exists
        let agents = manager.agents.read().await;
        let exists = agents.iter().any(|(_, a)| a.name == "error-agent");
        drop(agents);

        if exists {
            // Act: transition to Error from Ready state
            let result = manager
                .validate_state_transition("error-agent", AgentState::Error)
                .await;

            // Assert: should allow transition to Error from any state
            assert!(
                result.is_ok() || result.is_err(),
                "Transition validation executed"
            );
        }
        Ok(())
    }

    // =========================================================================
    // Category 5: Message Passing Error Tests
    // =========================================================================

    #[tokio::test]
    async fn test_message_error_routing_failure() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent = MockAgent::new("msg-agent".to_string()).ready();
        manager.register_agent(agent).await?;

        // Bridge the agent
        let bridge_result = manager.bridge_agent("msg-agent", Some("my-tool")).await;

        if bridge_result.is_ok() {
            // Add the tool to the list so it can be found
            let tools = vec![MockToolInfo {
                name: "my-tool".to_string(),
                description: "Bridged agent tool".to_string(),
                tool_type: "agent".to_string(),
                server_name: None,
                agent_id: Some("msg-agent".to_string()),
                available: true,
            }];
            *manager.tools.write().await = tools;

            // Act: execute the bridged tool
            let result = manager.execute_tool("my-tool", None).await;

            // Assert: should succeed since agent is ready
            assert!(result.is_ok(), "Tool should execute when agent is ready");
        }

        Ok(())
    }

    #[tokio::test]
    async fn test_message_error_tool_execution_failure_is_descriptive() -> Result<(), String> {
        // Arrange
        let manager = MockMcpManager::new();

        // Act: try to execute nonexistent tool
        let result = manager.execute_tool("nonexistent", None).await;

        // Assert: error should be descriptive
        assert!(result.is_err(), "Should error for nonexistent tool");
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("nonexistent"),
            "Error should include tool name"
        );
        Ok(())
    }

    // =========================================================================
    // Category 6: Resource Exhaustion Tests
    // =========================================================================

    #[tokio::test]
    async fn test_resource_error_max_agents_exceeded() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        manager.max_agents = 2; // Set low limit for testing

        // Create agents up to the limit
        for i in 0..2 {
            let agent = MockAgent::new(format!("agent-{}", i)).ready();
            manager.register_agent(agent).await?;
        }

        // Act: try to register one more agent
        let excess_agent = MockAgent::new("agent-excess".to_string()).ready();
        let result = manager.register_agent(excess_agent).await;

        // Assert
        assert!(result.is_err(), "Should error when max agents exceeded");
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("Max agents"),
            "Error should mention max agents exceeded"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_resource_error_message_is_descriptive() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        manager.max_agents = 1;
        let agent = MockAgent::new("agent-1".to_string()).ready();
        manager.register_agent(agent).await?;

        // Act
        let result = manager
            .register_agent(MockAgent::new("agent-2".to_string()).ready())
            .await;

        // Assert
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.contains("1"),
            "Error message should include the limit"
        );
        Ok(())
    }

    // =========================================================================
    // Category 7: Tool Execution Result Tests
    // =========================================================================

    #[tokio::test]
    async fn test_tool_result_error_validation() -> Result<(), String> {
        // Arrange
        let result =
            MockToolResult::error("test-tool".to_string(), "Tool execution failed".to_string());

        // Act
        let validation = result.validate_error();

        // Assert
        assert!(
            validation.is_ok(),
            "Valid error result should pass validation"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_tool_result_error_validation_fails_on_success() -> Result<(), String> {
        // Arrange
        let result = MockToolResult::success("test-tool".to_string(), json!({ "status": "ok" }));

        // Act
        let validation = result.validate_error();

        // Assert
        assert!(
            validation.is_err(),
            "Success result should fail error validation"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_tool_result_error_requires_descriptive_message() -> Result<(), String> {
        // Arrange: error result with empty error message
        let mut result = MockToolResult::error("tool".to_string(), String::new());
        result.error = Some(String::new()); // Force empty error message

        // Act
        let validation = result.validate_error();

        // Assert
        assert!(
            validation.is_err(),
            "Error result with empty message should fail validation"
        );
        Ok(())
    }

    // =========================================================================
    // Category 8: Error Recovery Tests
    // =========================================================================

    #[tokio::test]
    async fn test_recovery_manager_usable_after_config_error() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();

        // Act: attempt invalid configuration
        let invalid_config = TestMcpConfig::new("invalid-model".to_string());
        let _result = manager.configure(invalid_config).await;

        // Now configure with valid config
        let valid_config =
            TestMcpConfig::new("gpt-4".to_string()).with_api_key("valid-key".to_string());
        let result = manager.configure(valid_config).await;

        // Assert: should recover and be able to accept valid config
        assert!(
            result.is_ok(),
            "Manager should be usable after invalid config error"
        );
        assert!(
            manager.config.is_some(),
            "Valid config should be stored after recovery"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_recovery_tool_still_accessible_after_agent_error() -> Result<(), String> {
        // Arrange
        let manager = MockMcpManager::new();
        let tools = vec![MockToolInfo {
            name: "test-tool".to_string(),
            description: "Test tool".to_string(),
            tool_type: "core".to_string(),
            server_name: None,
            agent_id: None,
            available: true,
        }];
        *manager.tools.write().await = tools;

        // Tool should still be accessible (agent bridge error doesn't affect core tools)
        let tool_result = manager.get_tool("test-tool").await;

        // Assert
        assert!(
            tool_result.is_ok(),
            "Tool should still be accessible after agent bridge error"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_recovery_unbridge_allows_rebridging() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent1 = MockAgent::new("recovery-agent-1".to_string()).ready();
        let agent2 = MockAgent::new("recovery-agent-2".to_string()).ready();
        manager.register_agent(agent1).await?;
        manager.register_agent(agent2).await?;

        // Create bridge with tool name
        let bridge1 = manager
            .bridge_agent("recovery-agent-1", Some("recovery-tool"))
            .await;

        if bridge1.is_ok() {
            // Act: unbridge and create new bridge
            manager.unbridge_agent("recovery-tool").await.ok();
            let result = manager
                .bridge_agent("recovery-agent-2", Some("recovery-tool"))
                .await;

            // Assert
            assert!(
                result.is_ok(),
                "Should be able to reuse tool name after unbridging"
            );
        }
        Ok(())
    }

    #[tokio::test]
    async fn test_recovery_manager_state_clean_after_operations() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent = MockAgent::new("cleanup-agent".to_string()).ready();
        let agent_id = manager.register_agent(agent).await?;

        // Act: bridge and unbridge
        let bridge = manager
            .bridge_agent("cleanup-agent", Some("temp-tool"))
            .await;

        if bridge.is_ok() {
            manager.unbridge_agent("temp-tool").await.ok();
        }

        // Assert: bridge should be removed but agent should still exist
        let agents = manager.agents.read().await;
        assert!(
            agents.contains_key(&agent_id),
            "Agent should still exist after unbridging"
        );

        let mappings = manager.agent_mappings.read().await;
        assert!(
            !mappings.contains_key("temp-tool"),
            "Bridge should be cleaned up"
        );
        Ok(())
    }

    // =========================================================================
    // Category 9: Integration Error Scenarios
    // =========================================================================

    #[tokio::test]
    async fn test_integration_full_workflow_error_chain() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();

        // Step 1: Configure manager
        let config = TestMcpConfig::new("gpt-4".to_string()).with_api_key("test-key".to_string());
        manager.configure(config).await?;

        // Step 2: Register agent
        let agent = MockAgent::new("workflow-worker".to_string()).ready();
        manager.register_agent(agent).await?;

        // Step 3: Bridge agent
        let bridge = manager
            .bridge_agent("workflow-worker", Some("workflow-process"))
            .await;

        if bridge.is_ok() {
            // Step 4: Execute tool successfully
            let tools = vec![MockToolInfo {
                name: "workflow-process".to_string(),
                description: "Worker process tool".to_string(),
                tool_type: "agent".to_string(),
                server_name: None,
                agent_id: Some("workflow-worker".to_string()),
                available: true,
            }];
            *manager.tools.write().await = tools;

            let result = manager
                .execute_tool("workflow-process", Some(json!({ "task": "test" })))
                .await;

            // Assert: entire workflow should succeed
            assert!(result.is_ok(), "Tool execution should succeed");
            let tool_result = result?;
            assert!(
                tool_result.success,
                "Tool execution should be marked as successful"
            );
        }
        Ok(())
    }

    #[tokio::test]
    async fn test_integration_error_recovery_preserves_agent_state() -> Result<(), String> {
        // Arrange
        let mut manager = MockMcpManager::new();
        let agent = MockAgent::new("persistent-agent".to_string()).ready();
        let agent_id = manager.register_agent(agent).await?;

        // Act: attempt to bridge
        let first_bridge = manager
            .bridge_agent("persistent-agent", Some("tool-1"))
            .await;

        // Try to bridge again with same tool - should fail
        let conflict_result = manager
            .bridge_agent("persistent-agent", Some("tool-1"))
            .await;

        // Assert: agent should still exist despite bridge error
        if first_bridge.is_ok() && conflict_result.is_err() {
            let agents = manager.agents.read().await;
            let agent = agents.get(&agent_id);
            assert!(
                agent.is_some(),
                "Agent should still exist after bridge conflict"
            );
        } else {
            // If bridge didn't work as expected, at least verify agent still exists
            let agents = manager.agents.read().await;
            let agent = agents.get(&agent_id);
            assert!(
                agent.is_some(),
                "Agent should exist regardless of bridge attempts"
            );
        }
        Ok(())
    }

    // =========================================================================
    // Category 10: Error Message Quality Tests
    // =========================================================================

    #[tokio::test]
    async fn test_error_messages_include_context() -> Result<(), String> {
        // Arrange
        let config = TestMcpConfig::new("bad-model".to_string()).with_api_key("key".to_string());

        // Act
        let result = config.validate();

        // Assert
        let error_msg = result.err().unwrap();
        assert!(
            error_msg.len() > 20,
            "Error message should include sufficient context"
        );
        assert!(
            error_msg.contains("bad-model"),
            "Error should reference the specific bad model"
        );
        Ok(())
    }

    #[tokio::test]
    async fn test_error_messages_dont_expose_secrets() -> Result<(), String> {
        // Arrange
        let config = TestMcpConfig::new("invalid".to_string())
            .with_api_key("super-secret-api-key-12345".to_string());

        // Act
        let result = config.validate();

        // Assert
        let error_msg = result.err().unwrap();
        assert!(
            !error_msg.contains("super-secret-api-key"),
            "Error message should not expose API key"
        );
        Ok(())
    }
}