gg-cli 0.41.0

GG - Gui for JJ
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
use super::*;
use jj_lib::config::ConfigLayer;

const JJ_TEST_DEFAULTS: &str = r#"
    [user]
    name = "Test User"
    email = "test@example.com"

    [operation]
    hostname = "test-host"
    username = "test-user"

    [signing]
    behavior = "drop"
"#;

/// Create isolated test settings with only gg.toml defaults, no user config.
pub fn settings_with_gg_defaults() -> UserSettings {
    let mut config = StackedConfig::empty();
    config.add_layer(ConfigLayer::parse(ConfigSource::Default, JJ_TEST_DEFAULTS).unwrap());
    config.add_layer(
        ConfigLayer::parse(ConfigSource::Default, include_str!("../config/gg.toml")).unwrap(),
    );
    UserSettings::from_config(config).unwrap()
}

/// Create test settings with custom TOML layered on top of defaults.
fn settings_with_overrides(toml: &str) -> UserSettings {
    let mut config = StackedConfig::empty();
    config.add_layer(ConfigLayer::parse(ConfigSource::Default, JJ_TEST_DEFAULTS).unwrap());
    config.add_layer(
        ConfigLayer::parse(ConfigSource::Default, include_str!("../config/gg.toml")).unwrap(),
    );
    config.add_layer(ConfigLayer::parse(ConfigSource::User, toml).unwrap());
    UserSettings::from_config(config).unwrap()
}

/// Create test settings with gg.* config override extraction applied.
fn settings_with_extracted_overrides(toml: &str) -> UserSettings {
    let mut config = StackedConfig::empty();
    config.add_layer(ConfigLayer::parse(ConfigSource::Default, JJ_TEST_DEFAULTS).unwrap());
    config.add_layer(
        ConfigLayer::parse(ConfigSource::Default, include_str!("../config/gg.toml")).unwrap(),
    );
    config.add_layer(ConfigLayer::parse(ConfigSource::User, toml).unwrap());
    if let Some(overrides) = extract_overrides(&config) {
        config.add_layer(overrides);
    }
    UserSettings::from_config(config).unwrap()
}

#[test]
fn track_recent_workspaces_default_is_true() {
    let settings = settings_with_gg_defaults();
    assert!(settings.ui_track_recent_workspaces());
}

#[test]
fn track_recent_workspaces_can_be_disabled() {
    let settings = settings_with_overrides(
        r#"
            [gg.ui]
            track-recent-workspaces = false
            "#,
    );
    assert!(!settings.ui_track_recent_workspaces());
}

#[test]
fn mark_unpushed_bookmarks_default_is_true() {
    let settings = settings_with_gg_defaults();
    assert!(settings.ui_mark_unpushed_bookmarks());
}

#[test]
fn mark_unpushed_bookmarks_can_be_disabled() {
    let settings = settings_with_overrides(
        r#"
            [gg.ui]
            mark-unpushed-bookmarks = false
            "#,
    );
    assert!(!settings.ui_mark_unpushed_bookmarks());
}

#[test]
fn mark_unpushed_bookmarks_legacy_name_fallback() {
    // without gg.toml to test the fallback behavior
    let mut config = StackedConfig::empty();
    config.add_layer(
        ConfigLayer::parse(
            ConfigSource::Default,
            &format!("{JJ_TEST_DEFAULTS}\n[gg.ui]\nmark-unpushed-branches = false"),
        )
        .unwrap(),
    );
    let settings = UserSettings::from_config(config).unwrap();
    assert!(!settings.ui_mark_unpushed_bookmarks());
}

#[test]
fn mark_unpushed_bookmarks_new_name_takes_precedence() {
    let settings = settings_with_overrides(
        r#"
            [gg.ui]
            mark-unpushed-branches = false
            mark-unpushed-bookmarks = true
            "#,
    );
    assert!(settings.ui_mark_unpushed_bookmarks());
}

#[test]
fn log_page_size_default() {
    let settings = settings_with_gg_defaults();
    assert_eq!(settings.query_log_page_size(), 1000);
}

#[test]
fn log_page_size_can_be_overridden() {
    let settings = settings_with_overrides(
        r#"
            [gg.queries]
            log-page-size = 500
            "#,
    );
    assert_eq!(settings.query_log_page_size(), 500);
}

#[test]
fn large_repo_heuristic_default() {
    let settings = settings_with_gg_defaults();
    assert_eq!(settings.query_large_repo_heuristic(), 100000);
}

#[test]
fn auto_snapshot_default_is_none() {
    let settings = settings_with_gg_defaults();
    assert!(settings.query_auto_snapshot().is_none());
}

#[test]
fn auto_snapshot_can_be_enabled() {
    let settings = settings_with_overrides(
        r#"
            [gg.queries]
            auto-snapshot = true
            "#,
    );
    assert_eq!(settings.query_auto_snapshot(), Some(true));
}

#[test]
fn theme_override_default_is_none() {
    let settings = settings_with_gg_defaults();
    assert!(settings.ui_theme_override().is_none());
}

#[test]
fn theme_override_can_be_set() {
    let settings = settings_with_overrides(
        r#"
            [gg.ui]
            theme-override = "dark"
            "#,
    );
    assert_eq!(settings.ui_theme_override(), Some("dark".to_string()));
}

#[test]
fn recent_workspaces_default_is_empty() {
    let settings = settings_with_gg_defaults();
    assert!(settings.ui_recent_workspaces().is_empty());
}

#[test]
fn recent_workspaces_returns_configured_paths() {
    let settings = settings_with_overrides(
        r#"
            [gg.ui]
            recent-workspaces = ["/path/one", "/path/two"]
            "#,
    );
    assert_eq!(
        settings.ui_recent_workspaces(),
        vec!["/path/one".to_string(), "/path/two".to_string()]
    );
}

#[test]
fn resolve_repo_path_finds_repo_from_subdir() {
    let dir = tempfile::tempdir().unwrap();
    let repo_path = dir.path().join(".jj").join("repo");
    std::fs::create_dir_all(&repo_path).unwrap();
    let subdir = dir.path().join("nested").join("deeper");
    std::fs::create_dir_all(&subdir).unwrap();

    let resolved = resolve_repo_path(Some(&subdir)).expect("repo path should resolve");
    assert_eq!(
        dunce::canonicalize(resolved).unwrap(),
        dunce::canonicalize(repo_path).unwrap()
    );
}

#[test]
fn resolve_repo_path_is_none_outside_workspace() {
    let dir = tempfile::tempdir().unwrap();
    assert!(resolve_repo_path(Some(dir.path())).is_none());
}

mod extract_overrides {
    use super::super::{GGSettings, extract_overrides, native_keys};
    use super::{JJ_TEST_DEFAULTS, settings_with_extracted_overrides};
    use jj_lib::config::{ConfigLayer, ConfigSource, StackedConfig};
    use jj_lib::settings::UserSettings;

    #[test]
    fn override_basic_user_name() {
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.user]
            name = "GG User"
            "#,
        );
        assert_eq!(settings.user_name(), "GG User");
    }

    #[test]
    fn override_beats_regular_setting() {
        let settings = settings_with_extracted_overrides(
            r#"
            [user]
            name = "CLI User"
            [gg.user]
            name = "GG User"
            "#,
        );
        assert_eq!(settings.user_name(), "GG User");
    }

    #[test]
    fn override_with_dotted_key_syntax() {
        let settings = settings_with_extracted_overrides(
            r#"
            gg.user.name = "Dotted GG"
            [user]
            name = "CLI User"
            "#,
        );
        assert_eq!(settings.user_name(), "Dotted GG");
    }

    #[test]
    fn override_nested_table() {
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.snapshot]
            auto-track = "glob:src/**"
            "#,
        );
        assert_eq!(
            settings.get_string("snapshot.auto-track").unwrap(),
            "glob:src/**"
        );
    }

    #[test]
    fn override_multiple_keys() {
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.user]
            name = "GG User"
            email = "gg@example.com"
            [gg.signing]
            behavior = "own"
            "#,
        );
        assert_eq!(settings.user_name(), "GG User");
        assert_eq!(settings.user_email(), "gg@example.com");
        assert_eq!(settings.get_string("signing.behavior").unwrap(), "own");
    }

    #[test]
    fn native_gg_keys_are_not_overrides() {
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.queries]
            log-page-size = 42
            "#,
        );
        // gg.queries.log-page-size is a native GG key, not an override for "queries.log-page-size"
        assert_eq!(settings.query_log_page_size(), 42);
        assert!(settings.get_string("queries.log-page-size").is_err());
    }

    #[test]
    fn no_overrides_is_noop() {
        let settings = settings_with_extracted_overrides(
            r#"
            [user]
            name = "Plain User"
            "#,
        );
        assert_eq!(settings.user_name(), "Plain User");
    }

    #[test]
    fn override_from_higher_layer_wins() {
        // user-level gg.user.name vs repo-level gg.user.name: repo wins
        let mut config = StackedConfig::empty();
        config.add_layer(ConfigLayer::parse(ConfigSource::Default, JJ_TEST_DEFAULTS).unwrap());
        config.add_layer(
            ConfigLayer::parse(ConfigSource::Default, include_str!("../config/gg.toml")).unwrap(),
        );
        config.add_layer(
            ConfigLayer::parse(ConfigSource::User, r#"gg.user.name = "User Level""#).unwrap(),
        );
        config.add_layer(
            ConfigLayer::parse(ConfigSource::Repo, r#"gg.user.name = "Repo Level""#).unwrap(),
        );
        if let Some(overrides) = extract_overrides(&config) {
            config.add_layer(overrides);
        }
        let settings = UserSettings::from_config(config).unwrap();
        assert_eq!(settings.user_name(), "Repo Level");
    }

    #[test]
    fn override_beats_repo_level_regular_setting() {
        // user-level gg.user.name should beat repo-level user.name
        let mut config = StackedConfig::empty();
        config.add_layer(ConfigLayer::parse(ConfigSource::Default, JJ_TEST_DEFAULTS).unwrap());
        config.add_layer(
            ConfigLayer::parse(ConfigSource::Default, include_str!("../config/gg.toml")).unwrap(),
        );
        config.add_layer(
            ConfigLayer::parse(ConfigSource::User, r#"gg.user.name = "GG User""#).unwrap(),
        );
        config.add_layer(
            ConfigLayer::parse(ConfigSource::Repo, r#"user.name = "Repo CLI User""#).unwrap(),
        );
        if let Some(overrides) = extract_overrides(&config) {
            config.add_layer(overrides);
        }
        let settings = UserSettings::from_config(config).unwrap();
        assert_eq!(settings.user_name(), "GG User");
    }

    #[test]
    fn native_keys_discovered_from_gg_toml() {
        let keys = native_keys();
        // leaf keys from gg.toml
        assert!(keys.contains("default-mode"));
        assert!(keys.contains("queries.log-page-size"));
        assert!(keys.contains("queries.large-repo-heuristic"));
        assert!(keys.contains("ui.recent-workspaces"));
        assert!(keys.contains("ui.track-recent-workspaces"));
        assert!(keys.contains("ui.mark-unpushed-bookmarks"));
        assert!(keys.contains("ui.theme-override"));
        assert!(keys.contains("web.default-port"));
        assert!(keys.contains("web.client-timeout"));
        assert!(keys.contains("web.launch-browser"));
        // supplementary keys not in gg.toml
        assert!(keys.contains("queries.auto-snapshot"));
        assert!(keys.contains("ui.mark-unpushed-branches"));
        // table prefixes should NOT be in the set (only leaf keys)
        assert!(!keys.contains("queries"));
        assert!(!keys.contains("ui"));
        assert!(!keys.contains("web"));
    }

    #[test]
    fn mixed_ui_table_native_and_override() {
        // gg.ui.theme-override is native, gg.ui.diff-editor is a jj override
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.ui]
            theme-override = "dark"
            diff-editor = "meld"
            "#,
        );
        // native key stays under gg.ui, not injected as ui.theme-override
        assert_eq!(settings.ui_theme_override(), Some("dark".to_string()));
        assert!(settings.get_string("ui.theme-override").is_err());
        // override key is injected as ui.diff-editor
        assert_eq!(settings.get_string("ui.diff-editor").unwrap(), "meld");
    }

    #[test]
    fn preset_is_native() {
        // custom presets are GG-native, not jj overrides
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.presets]
            my-custom-preset = "bookmarks()"
            "#,
        );
        assert!(settings.get_string("presets.my-custom-preset").is_err());
        assert_eq!(
            settings.get_string("gg.presets.my-custom-preset").unwrap(),
            "bookmarks()"
        );
    }

    #[test]
    fn revset_override_is_forwarded() {
        // gg.revsets.* keys are pure jj overrides now that presets live elsewhere
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.revsets]
            short-prefixes = "trunk()"
            log = "all()"
            "#,
        );
        assert_eq!(
            settings.get_string("revsets.short-prefixes").unwrap(),
            "trunk()"
        );
        assert_eq!(settings.get_string("revsets.log").unwrap(), "all()");
    }

    #[test]
    fn preset_and_revset_override_coexist() {
        // presets stay native, revset overrides get forwarded
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.presets]
            my-preset = "trunk()..@"

            [gg.revsets]
            short-prefixes = "trunk()"
            "#,
        );
        // my-preset is native — not injected
        assert!(settings.get_string("presets.my-preset").is_err());
        assert_eq!(
            settings.get_string("gg.presets.my-preset").unwrap(),
            "trunk()..@"
        );
        // short-prefixes is a jj override — injected
        assert_eq!(
            settings.get_string("revsets.short-prefixes").unwrap(),
            "trunk()"
        );
    }

    #[test]
    fn deep_nesting_override() {
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.signing.backends.gpg]
            program = "/usr/bin/gpg2"
            "#,
        );
        assert_eq!(
            settings.get_string("signing.backends.gpg.program").unwrap(),
            "/usr/bin/gpg2"
        );
    }

    #[test]
    fn cross_layer_merge_preserves_siblings() {
        // user layer sets gg.signing.behavior, repo layer sets gg.signing.backend
        // both should end up in the override doc
        let mut config = StackedConfig::empty();
        config.add_layer(ConfigLayer::parse(ConfigSource::Default, JJ_TEST_DEFAULTS).unwrap());
        config.add_layer(
            ConfigLayer::parse(ConfigSource::Default, include_str!("../config/gg.toml")).unwrap(),
        );
        config.add_layer(
            ConfigLayer::parse(ConfigSource::User, r#"gg.signing.behavior = "own""#).unwrap(),
        );
        config.add_layer(
            ConfigLayer::parse(ConfigSource::Repo, r#"gg.signing.backend = "gpg""#).unwrap(),
        );
        if let Some(overrides) = extract_overrides(&config) {
            config.add_layer(overrides);
        }
        let settings = UserSettings::from_config(config).unwrap();
        assert_eq!(settings.get_string("signing.behavior").unwrap(), "own");
        assert_eq!(settings.get_string("signing.backend").unwrap(), "gpg");
    }

    #[test]
    fn auto_snapshot_not_injected_as_override() {
        // gg.queries.auto-snapshot is native (supplementary list), not a jj override
        let settings = settings_with_extracted_overrides(
            r#"
            [gg.queries]
            auto-snapshot = true
            "#,
        );
        assert_eq!(settings.query_auto_snapshot(), Some(true));
        assert!(settings.get_string("queries.auto-snapshot").is_err());
    }
}