geiserx_ts_runtime 0.6.10

tailscale runtime
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
//! peerAPI listener + request router.
//!
//! Go tsnet runs **one** peerAPI HTTP server per node that multiplexes many routes (`/dns-query`,
//! `/v0/put/<name>`, …). This module is the Rust equivalent: it owns the single TCP listener on the
//! node's overlay IPv4 at [`Config::peerapi_port`][ts_control::Config::peerapi_port], reads each
//! request's headers, and dispatches by path:
//!
//! - `/dns-query` → the exit-node DoH handler ([`crate::peerapi_doh`]), unchanged byte-for-byte.
//! - `/v0/put/<name>` → the Taildrop receive handler ([`handle_taildrop_put`]), writing the file
//!   into the configured [`TaildropStore`](crate::taildrop::TaildropStore).
//! - `POST /v0/ingress` → the client-side Funnel ingress handler ([`handle_ingress`]): a Tailscale
//!   ingress-relay hand-off, membership-gated then `101`-hijacked into a raw stream and pushed to the
//!   active funnel listener's sink (see [`crate::funnel`]); `404` when no funnel listener is active.
//! - anything else → `404`.
//!
//! ## Anti-leak / IPv4-only
//!
//! The listener binds the overlay IPv4 only (`0.0.0.0:port` on the netstack — never a host socket),
//! exactly as the old DoH-only server did. Requests are size-capped; a saturated server drops the
//! flow (fail-closed, [`MAX_INFLIGHT`]); a slow request is timed out ([`REQUEST_TIMEOUT`]).
//!
//! ## Taildrop access gate (fail-closed)
//!
//! A `PUT /v0/put/<name>` is only accepted when **both** hold:
//!
//! 1. A Taildrop store is configured (`taildrop_dir` set; no store ⇒ `403`).
//! 2. This node holds the node-level capability `https://tailscale.com/cap/file-sharing`
//!    ([`FILE_SHARING_NODE_CAP`]), checked against the self node's cap map
//!    ([`Node::has_node_attr`][ts_control::Node::has_node_attr]).
//!
//! **Documented limitation (peer-cap):** Go additionally requires the *sending peer* to hold the
//! `FILE_SHARING_SEND` peer-capability (`https://tailscale.com/cap/file-send`). That datum lives in
//! the packet-filter peer-capability map, which this fork does **not** thread into the runtime's
//! domain [`Node`][ts_control::Node] (only the node-attribute `cap_map` is). So we cannot yet check
//! the per-peer send grant. As a partial substitute we *do* require the source IP to resolve to a
//! known tailnet peer (or this node) — a `PUT` from an unknown source IP is refused (`403`). The
//! transfer still cannot happen unless the node operator opted in by configuring a Taildrop
//! directory AND this node holds the `file-sharing` node cap, so the surface stays fail-closed.
//! See `tracking: thread PeerCapMap into ts_control::Node` to remove this limitation.

use std::{net::SocketAddr, sync::Arc, time::Duration};

use netstack::{netcore::Channel, netsock::TcpStream};
use tokio::{
    io::{AsyncReadExt, AsyncWriteExt},
    sync::{Semaphore, watch},
    time::timeout,
};

use crate::{
    funnel::{FunnelIngressSlot, IngressConn},
    magic_dns::DnsView,
    peerapi_doh::{find_header_end, write_status},
    taildrop::{TaildropError, TaildropStore},
};

/// The node-level capability that authorizes this node to participate in Taildrop file sharing
/// (Go `tailcfg.CapabilityFileSharing`). Checked against the self node's cap map.
pub(crate) const FILE_SHARING_NODE_CAP: &str = "https://tailscale.com/cap/file-sharing";

/// Max concurrent in-flight peerAPI requests served at once. Bounds per-flow spawn fan-out so a
/// flood can't grow tasks without limit; saturated => drop the flow (fail-closed). Mirrors the
/// `fallback_tcp` / forwarder cap (and the old DoH-only server's cap).
const MAX_INFLIGHT: usize = 512;

/// How long one peerAPI connection may take to be fully serviced before we give up (fail-closed: a
/// slow-loris peer can't pin a server task indefinitely). A Taildrop body can be large, so this is
/// generous relative to the small DoH request.
const REQUEST_TIMEOUT: Duration = Duration::from_secs(300);

/// Largest header block we will read before the `\r\n\r\n` terminator. The body is read separately
/// (DoH bounds its own; Taildrop streams the body straight to disk by `Content-Length`). Anything
/// past this with no header terminator is `400` and the connection closed.
const MAX_HEADERS: usize = 16 * 1024;

/// Run the single peerAPI server on `channel`, accepting on `0.0.0.0:port` of the overlay netstack
/// and dispatching each request by path. Returns on bind/accept failure — fail-closed: no server
/// means peers can't use this node's peerAPI at all.
///
/// Binding the unspecified overlay address (rather than this node's specific tailnet IPv4) avoids a
/// startup dependency on the self IP, which isn't known until the first netmap; the interface owns
/// the node's tailnet address, so a peer dialing `<our-tailnet-ipv4>:port` is accepted here. IPv4-only.
///
/// `view_rx` is the live [`DnsView`] shared with the MagicDNS responder (same control/peer state);
/// the DoH handler resolves queries against it and the Taildrop handler reads the self-node cap and
/// peer set from it for the access gate. `forward_exit_egress` gates DoH recursive resolution.
/// `taildrop` is the configured file store, or `None` when Taildrop is disabled (a `PUT` then `403`s).
/// `funnel_ingress` is the shared slot the client-side Funnel listener installs its ingress sink
/// into (see [`crate::funnel`]); a `POST /v0/ingress` is membership-gated, hijacked with
/// `101 Switching Protocols`, and pushed to the sink when one is present, else `404` (fail-closed).
pub(crate) async fn serve(
    channel: Channel,
    port: u16,
    view_rx: watch::Receiver<Arc<DnsView>>,
    forward_exit_egress: bool,
    taildrop: Option<Arc<TaildropStore>>,
    funnel_ingress: FunnelIngressSlot,
) {
    use std::net::Ipv4Addr;

    use netstack::CreateSocket;

    let addr = SocketAddr::new(Ipv4Addr::UNSPECIFIED.into(), port);
    let listener = match channel.tcp_listen(addr).await {
        Ok(l) => l,
        Err(e) => {
            tracing::error!(error = %e, %addr, "peerapi: tcp listen failed; server inert");
            return;
        }
    };
    tracing::debug!(%addr, taildrop = taildrop.is_some(), "peerapi server accepting");

    let inflight = Arc::new(Semaphore::new(MAX_INFLIGHT));

    loop {
        let stream = match listener.accept().await {
            Ok(s) => s,
            Err(e) => {
                tracing::warn!(error = %e, "peerapi: accept failed, stopping server");
                return;
            }
        };

        let Ok(permit) = inflight.clone().try_acquire_owned() else {
            tracing::warn!(
                peer = %stream.remote_addr(),
                "peerapi drop: at max in-flight requests ({MAX_INFLIGHT})"
            );
            // Dropping `stream` closes the flow; fail-closed.
            continue;
        };

        let channel = channel.clone();
        let view_rx = view_rx.clone();
        let taildrop = taildrop.clone();
        let funnel_ingress = funnel_ingress.clone();
        tokio::spawn(async move {
            let _permit = permit;
            if let Err(e) = timeout(
                REQUEST_TIMEOUT,
                route_conn(
                    stream,
                    &channel,
                    &view_rx,
                    forward_exit_egress,
                    taildrop,
                    &funnel_ingress,
                ),
            )
            .await
            {
                tracing::debug!(error = %e, "peerapi: connection timed out");
            }
        });
    }
}

/// Read one request's headers off `stream`, classify the route, and dispatch. Reads only up to the
/// `\r\n\r\n` terminator here; each handler consumes its own body from the already-read `seed` plus
/// the remaining stream.
async fn route_conn(
    mut stream: TcpStream,
    channel: &Channel,
    view_rx: &watch::Receiver<Arc<DnsView>>,
    forward_exit_egress: bool,
    taildrop: Option<Arc<TaildropStore>>,
    funnel_ingress: &FunnelIngressSlot,
) -> std::io::Result<()> {
    let (seed, header_end) = match read_headers(&mut stream).await? {
        Some(v) => v,
        None => return Ok(()), // peer closed before sending anything
    };

    // Parse just the request line + headers to learn the method and path.
    let mut headers = [httparse::EMPTY_HEADER; 32];
    let mut req = httparse::Request::new(&mut headers);
    match req.parse(&seed) {
        Ok(httparse::Status::Complete(_)) => {}
        // We already located \r\n\r\n, so Partial/Err here means malformed headers.
        Ok(httparse::Status::Partial) | Err(_) => {
            return write_status(&mut stream, "400 Bad Request").await;
        }
    }

    let method = req.method.unwrap_or("");
    let full_path = req.path.unwrap_or("");

    match classify_route(method, full_path) {
        Route::TaildropPut { name } => {
            // Extract everything we need from the borrowed `req` into owned values *before* moving
            // `seed` into the handler (the parsed `req` borrows `seed`). `content_length` is `None`
            // when absent/unparseable → the handler answers `400`.
            let offset = parse_range_offset(&req);
            let content_length =
                header_value(&req, "content-length").and_then(|v| v.trim().parse::<u64>().ok());
            let src = stream.remote_addr();
            // `req` (which borrows `seed`) is not used past here, so NLL ends the borrow and `seed`
            // can be moved into the handler below.
            handle_taildrop_put(
                stream,
                seed,
                header_end,
                name,
                offset,
                content_length,
                src,
                view_rx,
                taildrop,
            )
            .await
        }
        Route::TaildropMethodNotAllowed => {
            write_status(&mut stream, "405 Method Not Allowed").await
        }
        Route::Ingress => {
            // Extract the ingress headers into owned values before `req` (which borrows `seed`) is
            // dropped; `handle_ingress` then owns the stream.
            let target = header_value(&req, INGRESS_TARGET_HEADER).map(str::to_owned);
            let src_header = header_value(&req, INGRESS_SRC_HEADER).map(str::to_owned);
            let src = stream.remote_addr();
            handle_ingress(stream, target, src_header, src, view_rx, funnel_ingress).await
        }
        Route::IngressMethodNotAllowed => write_status(&mut stream, "405 Method Not Allowed").await,
        // Everything else is handed to the DoH handler (which itself returns 404 for a path that
        // is not `/dns-query`).
        Route::DohOrOther => {
            crate::peerapi_doh::handle_conn(
                stream,
                seed,
                header_end,
                channel,
                view_rx,
                forward_exit_egress,
            )
            .await
        }
    }
}

/// The `Tailscale-Ingress-Target` request header: the `host:port` the public Funnel client hit (the
/// service this node should TLS-terminate + serve). Go `ipnlocal.serve`'s ingress target.
const INGRESS_TARGET_HEADER: &str = "Tailscale-Ingress-Target";

/// The `Tailscale-Ingress-Src` request header: the public Funnel client's `host:port` (informational
/// — carried through to the embedder, not used for the access decision). Go's ingress source.
const INGRESS_SRC_HEADER: &str = "Tailscale-Ingress-Src";

/// The route a peerAPI request maps to, derived purely from its method and path.
#[derive(Debug, PartialEq, Eq)]
enum Route {
    /// `PUT /v0/put/<name>` — a Taildrop file upload; `name` is the percent-decoded base name.
    TaildropPut { name: String },
    /// A `/v0/put/` path with a non-`PUT` method → `405`.
    TaildropMethodNotAllowed,
    /// `POST /v0/ingress` — a Tailscale ingress-relay Funnel hand-off to hijack + TLS-terminate.
    Ingress,
    /// A `/v0/ingress` path with a non-`POST` method → `405`.
    IngressMethodNotAllowed,
    /// Anything else; handed to the DoH handler (`/dns-query`, else `404`).
    DohOrOther,
}

/// Classify a request by `method` and `full_path` (which may carry a `?query`). Mirrors Go's
/// `strings.CutPrefix(path, "/v0/put/")` for the Taildrop route (percent-decoding the name) and the
/// exact `/v0/ingress` match for the Funnel ingress route. Pure so the routing decision is
/// unit-testable without a live stream.
fn classify_route(method: &str, full_path: &str) -> Route {
    let raw_path = full_path.split('?').next().unwrap_or(full_path);
    if let Some(encoded_name) = raw_path.strip_prefix("/v0/put/") {
        if method != "PUT" {
            return Route::TaildropMethodNotAllowed;
        }
        return Route::TaildropPut {
            name: percent_decode(encoded_name),
        };
    }
    if raw_path == "/v0/ingress" {
        if method != "POST" {
            return Route::IngressMethodNotAllowed;
        }
        return Route::Ingress;
    }
    Route::DohOrOther
}

/// Read from `stream` until the `\r\n\r\n` header terminator, returning the buffered bytes (which
/// may include the start of the body) and the offset just past the terminator. `Ok(None)` if the
/// peer closed before sending any bytes. Caps the header block at [`MAX_HEADERS`].
async fn read_headers(stream: &mut TcpStream) -> std::io::Result<Option<(Vec<u8>, usize)>> {
    let mut buf = Vec::with_capacity(1024);
    let mut tmp = [0u8; 1024];
    loop {
        if let Some(pos) = find_header_end(&buf) {
            return Ok(Some((buf, pos)));
        }
        if buf.len() > MAX_HEADERS {
            // No terminator within the cap: treat as a malformed/abusive request. Returning the
            // oversized buffer with header_end past the end lets the caller emit 400 deterministically
            // — but simpler to signal here by returning an empty header_end sentinel is fragile, so
            // we just return what we have and let httparse fail (Partial) → 400.
            return Ok(Some((buf, 0)));
        }
        let n = stream.read(&mut tmp).await?;
        if n == 0 {
            return Ok(if buf.is_empty() { None } else { Some((buf, 0)) });
        }
        buf.extend_from_slice(&tmp[..n]);
    }
}

/// Look up a request header value case-insensitively.
fn header_value<'a>(req: &'a httparse::Request<'_, '_>, name: &str) -> Option<&'a str> {
    req.headers
        .iter()
        .find(|h| h.name.eq_ignore_ascii_case(name))
        .and_then(|h| std::str::from_utf8(h.value).ok())
}

/// The outcome of the Taildrop access gate.
#[derive(Debug, PartialEq, Eq)]
enum GateDecision {
    /// Accept the transfer.
    Allow,
    /// Reject with `403 Forbidden` (fail-closed): no store, missing node cap, or unknown source.
    Deny,
}

/// Decide whether a `PUT /v0/put/` from `src` is authorized, given the live `view`. Fail-closed:
///
/// - No store configured ⇒ `Deny` (handled by the caller before this, but modeled here for tests).
/// - Self node missing the [`FILE_SHARING_NODE_CAP`] node cap ⇒ `Deny`.
/// - Source IP does not resolve to a known tailnet peer or this node ⇒ `Deny`.
///
/// See the module-level "Documented limitation (peer-cap)" note: the per-peer `FILE_SHARING_SEND`
/// grant is not checkable from runtime state, so the known-source check is the partial substitute.
/// Pure (no I/O) so it is unit-testable without a live stream.
fn gate_taildrop(view: &DnsView, src: SocketAddr, store_configured: bool) -> GateDecision {
    if !store_configured {
        return GateDecision::Deny;
    }

    // Node-level opt-in: this node must hold the file-sharing capability.
    let node_ok = view
        .self_node
        .as_ref()
        .is_some_and(|n| n.has_node_attr(FILE_SHARING_NODE_CAP));
    if !node_ok {
        return GateDecision::Deny;
    }

    // Partial peer check: the source must be a known tailnet node (peer or self). The full
    // FILE_SHARING_SEND peer-cap check is not yet possible (see module docs). Resolve against the
    // shared view's peer DB / self node directly (DnsView's fields are crate-visible).
    if !source_is_known_node(view, src.ip()) {
        return GateDecision::Deny;
    }

    GateDecision::Allow
}

/// Whether `ip` belongs to a known tailnet peer or this node, per the shared view.
fn source_is_known_node(view: &DnsView, ip: std::net::IpAddr) -> bool {
    if view.peers.as_ref().and_then(|p| p.get(&ip)).is_some() {
        return true;
    }
    view.self_node.as_ref().is_some_and(|n| {
        std::net::IpAddr::from(n.tailnet_address.ipv4.addr()) == ip
            || std::net::IpAddr::from(n.tailnet_address.ipv6.addr()) == ip
    })
}

/// Decide whether a `POST /v0/ingress` from `src` is authorized, given the live `view`. Fail-closed,
/// mirroring [`gate_taildrop`]'s membership substitute: the relay is a current tailnet peer, so the
/// source must resolve to a known tailnet node (peer or self); an ingress POST from a non-member is
/// rejected. Pure (no I/O) so it is unit-testable without a live stream.
///
/// **Documented follow-up:** Go additionally requires the source to be the *specific* Tailscale
/// ingress-relay node (a relay-specific capability), not merely any tailnet member. That relay-cap
/// datum is not threaded into the runtime's domain `Node` (same gap as Taildrop's `FILE_SHARING_SEND`
/// peer-cap — see the module docs), so netmap membership is the v1 gate. The transfer still cannot
/// happen unless a funnel listener is active (sink installed) AND the `funnel_access` node-attribute
/// gate passed at `listen_funnel` time, so the surface stays fail-closed.
fn gate_ingress(view: &DnsView, src: SocketAddr) -> GateDecision {
    if source_is_known_node(view, src.ip()) {
        GateDecision::Allow
    } else {
        GateDecision::Deny
    }
}

/// The exact hijack reply written to a `/v0/ingress` connection before it becomes a raw bidi stream:
/// `HTTP/1.1 101 Switching Protocols\r\n\r\n` (Go writes the same to upgrade the relay conn). Pure so
/// the wire bytes are unit-testable.
fn ingress_101_response() -> &'static [u8] {
    b"HTTP/1.1 101 Switching Protocols\r\n\r\n"
}

/// Handle one `POST /v0/ingress` Funnel hand-off from the Tailscale ingress relay.
///
/// Fail-closed in order: (1) the `Tailscale-Ingress-Target` header must be present (a malformed
/// relay POST → `400`); (2) a funnel listener must be active — the shared slot must hold a
/// [`FunnelIngressSink`](crate::funnel::FunnelIngressSink) — else `404` (no `listen_funnel` was
/// called, so we must NOT hijack a conn nothing will serve); (3) the source must be a known tailnet
/// node ([`gate_ingress`]) else `403`. Only then do we write `101 Switching Protocols` to hijack the
/// connection into a raw stream and push it (with the parsed target/src) to the funnel manager's
/// sink. If the sink is full/closed at push time, the (already-hijacked) connection is dropped
/// (fail-closed) — we never fall back to anything.
///
/// Anti-leak: the hijacked stream is the overlay peerAPI connection (never a host socket); TLS is
/// terminated downstream by the funnel manager on that same overlay stream.
async fn handle_ingress(
    mut stream: TcpStream,
    target: Option<String>,
    src_header: Option<String>,
    src: SocketAddr,
    view_rx: &watch::Receiver<Arc<DnsView>>,
    funnel_ingress: &FunnelIngressSlot,
) -> std::io::Result<()> {
    // (1) The target header is mandatory — it names the service this node must serve.
    let Some(target) = target else {
        return write_status(&mut stream, "400 Bad Request").await;
    };

    // (2) A funnel listener must be active (sink installed). Snapshot the sink under the lock, then
    // release it before any await — never hold a std Mutex across `.await`.
    let sink = {
        let guard = funnel_ingress.lock().unwrap_or_else(|e| e.into_inner());
        guard.clone()
    };
    let Some(sink) = sink else {
        return write_status(&mut stream, "404 Not Found").await;
    };

    // (3) Membership gate (fail-closed): the relay must be a current tailnet node.
    {
        let view = view_rx.borrow().clone();
        if gate_ingress(&view, src) == GateDecision::Deny {
            return write_status(&mut stream, "403 Forbidden").await;
        }
    }

    // Hijack: switch the connection into a raw bidirectional stream. From here on the bytes are the
    // public client's TLS, terminated downstream by the funnel manager.
    stream.write_all(ingress_101_response()).await?;
    stream.flush().await?;

    let conn = IngressConn {
        target,
        src: src_header.unwrap_or_default(),
        stream,
    };
    if sink.send(conn).await.is_err() {
        // The funnel manager (or its receiver) is gone, or the sink is saturated and the embedder
        // can't keep up: the connection is already hijacked, so we can only drop it (fail-closed).
        // `conn.stream` is moved into `send`; on error it is returned and dropped here, closing the
        // overlay flow.
        tracing::debug!(%src, "funnel ingress: sink closed/full; dropping hijacked conn");
    }
    Ok(())
}

/// Parse the optional resume `Range: bytes=<start>-` header into a starting offset. Mirrors Go's
/// single-range support: a malformed or absent range yields offset `0` (transfer from the start).
fn parse_range_offset(req: &httparse::Request<'_, '_>) -> u64 {
    let Some(val) = header_value(req, "range") else {
        return 0;
    };
    let val = val.trim();
    let Some(rest) = val.strip_prefix("bytes=") else {
        return 0;
    };
    // Only a single range is supported; `<start>-` (open-ended) is what a resumed Taildrop sends.
    let Some((start, _end)) = rest.split_once('-') else {
        return 0;
    };
    start.trim().parse::<u64>().unwrap_or(0)
}

/// Minimal percent-decode of a URL path segment (`%XX` → byte). Invalid escapes are left verbatim,
/// matching a permissive decoder; the result is handed to [`TaildropStore::put_file`], which
/// validates the name and rejects anything unsafe (so a decode that produces a `/` or `..` is still
/// caught downstream with a `400`). Hand-rolled to avoid pulling a new dependency into this crate.
fn percent_decode(s: &str) -> String {
    let bytes = s.as_bytes();
    let mut out = Vec::with_capacity(bytes.len());
    let mut i = 0;
    while i < bytes.len() {
        if bytes[i] == b'%' && i + 2 < bytes.len() {
            let hi = (bytes[i + 1] as char).to_digit(16);
            let lo = (bytes[i + 2] as char).to_digit(16);
            if let (Some(hi), Some(lo)) = (hi, lo) {
                out.push((hi * 16 + lo) as u8);
                i += 3;
                continue;
            }
        }
        out.push(bytes[i]);
        i += 1;
    }
    String::from_utf8_lossy(&out).into_owned()
}

/// Handle one `PUT /v0/put/<name>` Taildrop transfer.
///
/// On success writes `200 OK` with body `"{}\n"` (Go's `taildropResp`). The access gate
/// ([`gate_taildrop`]) is enforced first (fail-closed `403`). The file name is percent-decoded then
/// handed to [`TaildropStore::put_file`], whose [`validate_base_name`][crate::taildrop::validate_base_name]
/// is the security boundary. Error mapping mirrors Go: `InvalidFileName` → `400`, `FileExists` →
/// `409 Conflict`, `Io` → `500`.
#[allow(clippy::too_many_arguments)]
async fn handle_taildrop_put(
    mut stream: TcpStream,
    seed: Vec<u8>,
    header_end: usize,
    name: String,
    offset: u64,
    content_length: Option<u64>,
    src: SocketAddr,
    view_rx: &watch::Receiver<Arc<DnsView>>,
    taildrop: Option<Arc<TaildropStore>>,
) -> std::io::Result<()> {
    // Access gate first — before any name decode or filesystem path is built.
    let Some(store) = taildrop else {
        return write_status(&mut stream, "403 Forbidden").await;
    };
    {
        let view = view_rx.borrow().clone();
        if gate_taildrop(&view, src, true) == GateDecision::Deny {
            return write_status(&mut stream, "403 Forbidden").await;
        }
    }

    // Content-Length bounds the body. A missing length is a 400 (we don't support chunked uploads).
    let Some(content_length) = content_length else {
        return write_status(&mut stream, "400 Bad Request").await;
    };

    // Stream the body to the store: feed the already-read seed body bytes first, then the rest of
    // the stream, capped at exactly `content_length`. `put_file` reads to EOF, so wrap the source in
    // a reader that yields precisely the declared body length.
    let body_seed = seed[header_end..].to_vec();
    let reader = BodyReader::new(body_seed, &mut stream, content_length);

    match store.put_file(&name, reader, offset).await {
        Ok(_total) => write_taildrop_ok(&mut stream).await,
        Err(TaildropError::InvalidFileName) => write_status(&mut stream, "400 Bad Request").await,
        Err(TaildropError::FileExists) => write_status(&mut stream, "409 Conflict").await,
        Err(TaildropError::Io(e)) => {
            tracing::warn!(error = %e, %src, "taildrop put: I/O error");
            write_status(&mut stream, "500 Internal Server Error").await
        }
    }
}

/// The full Taildrop success response bytes: `200 OK` with body exactly `"{}\n"` and
/// `Content-Length: 3` (Go `taildropResp`). Pure so the exact wire bytes are unit-testable.
fn taildrop_ok_response() -> Vec<u8> {
    const BODY: &[u8] = b"{}\n";
    let head = format!(
        "HTTP/1.1 200 OK\r\nContent-Type: application/json\r\nContent-Length: {}\r\nConnection: close\r\n\r\n",
        BODY.len()
    );
    let mut out = head.into_bytes();
    out.extend_from_slice(BODY);
    out
}

/// Write the Taildrop success response (see [`taildrop_ok_response`]).
async fn write_taildrop_ok(stream: &mut TcpStream) -> std::io::Result<()> {
    stream.write_all(&taildrop_ok_response()).await?;
    stream.flush().await
}

/// An [`AsyncRead`] over a request body that yields exactly `remaining` bytes: first the bytes
/// already buffered while reading headers (`seed`), then bytes pulled from the underlying stream,
/// stopping at the declared `Content-Length`. This gives [`TaildropStore::put_file`] a reader that
/// hits EOF at the body boundary so it never blocks waiting for bytes past the body or over-reads
/// into a (non-existent here) next request.
/// Generic over the underlying byte source so the production `&mut TcpStream` (the netstack stream)
/// works by inference while tests can drive it over any `AsyncRead`, e.g. a `tokio::io::duplex`
/// half — the netstack `TcpStream` is a concrete, privately-constructed type that can't be built in
/// a test, so this is the only way to exercise the cap against a real async stream.
struct BodyReader<S> {
    seed: std::io::Cursor<Vec<u8>>,
    stream: S,
    remaining: u64,
}

impl<S> BodyReader<S> {
    fn new(seed: Vec<u8>, stream: S, content_length: u64) -> Self {
        // The seed may hold more than the body in pathological pipelined cases; cap it.
        let seed = if seed.len() as u64 > content_length {
            seed[..content_length as usize].to_vec()
        } else {
            seed
        };
        let remaining = content_length.saturating_sub(seed.len() as u64);
        Self {
            seed: std::io::Cursor::new(seed),
            stream,
            remaining,
        }
    }
}

impl<S: tokio::io::AsyncRead + Unpin> tokio::io::AsyncRead for BodyReader<S> {
    fn poll_read(
        mut self: std::pin::Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
        buf: &mut tokio::io::ReadBuf<'_>,
    ) -> std::task::Poll<std::io::Result<()>> {
        // Drain the seed first (synchronous, in-memory).
        if (self.seed.position() as usize) < self.seed.get_ref().len() {
            let dst = buf.initialize_unfilled();
            let n = std::io::Read::read(&mut self.seed, dst)?;
            buf.advance(n);
            return std::task::Poll::Ready(Ok(()));
        }

        if self.remaining == 0 {
            // Body fully delivered: report EOF so `put_file`'s copy loop terminates.
            return std::task::Poll::Ready(Ok(()));
        }

        // Read from the stream, but never past the remaining body length. `limited` is a sub-view
        // over `buf`'s unfilled region; read into it in a scope so its mutable borrow of `buf` ends
        // before we advance `buf` by however many bytes landed.
        let want = self.remaining.min(buf.remaining() as u64) as usize;
        let poll = {
            let mut limited = buf.take(want);
            let stream = std::pin::Pin::new(&mut self.stream);
            match tokio::io::AsyncRead::poll_read(stream, cx, &mut limited) {
                std::task::Poll::Ready(Ok(())) => {
                    std::task::Poll::Ready(Ok(limited.filled().len()))
                }
                std::task::Poll::Ready(Err(e)) => std::task::Poll::Ready(Err(e)),
                std::task::Poll::Pending => std::task::Poll::Pending,
            }
        };
        match poll {
            std::task::Poll::Ready(Ok(n)) => {
                buf.advance(n);
                self.remaining -= n as u64;
                std::task::Poll::Ready(Ok(()))
            }
            std::task::Poll::Ready(Err(e)) => std::task::Poll::Ready(Err(e)),
            std::task::Poll::Pending => std::task::Poll::Pending,
        }
    }
}

#[cfg(test)]
mod tests {
    use std::net::{IpAddr, Ipv4Addr};

    use super::*;

    fn req_with<'a>(
        buf: &'a [u8],
        headers: &'a mut [httparse::Header<'a>],
    ) -> httparse::Request<'a, 'a> {
        let mut req = httparse::Request::new(headers);
        let _ = req.parse(buf);
        req
    }

    #[test]
    fn percent_decode_decodes_escapes() {
        assert_eq!(percent_decode("photo.jpg"), "photo.jpg");
        assert_eq!(percent_decode("my%20file.txt"), "my file.txt");
        assert_eq!(percent_decode("a%2Fb"), "a/b"); // decodes to a slash; put_file rejects it
        // Invalid escape left verbatim.
        assert_eq!(percent_decode("100%done"), "100%done");
    }

    #[test]
    fn parse_range_offset_reads_resume_start() {
        let buf = b"PUT /v0/put/x HTTP/1.1\r\nRange: bytes=1024-\r\n\r\n";
        let mut headers = [httparse::EMPTY_HEADER; 8];
        let req = req_with(buf, &mut headers);
        assert_eq!(parse_range_offset(&req), 1024);
    }

    #[test]
    fn parse_range_offset_defaults_zero() {
        let buf = b"PUT /v0/put/x HTTP/1.1\r\nContent-Length: 3\r\n\r\n";
        let mut headers = [httparse::EMPTY_HEADER; 8];
        let req = req_with(buf, &mut headers);
        assert_eq!(parse_range_offset(&req), 0);

        let buf2 = b"PUT /v0/put/x HTTP/1.1\r\nRange: items=1-2\r\n\r\n";
        let mut headers2 = [httparse::EMPTY_HEADER; 8];
        let req2 = req_with(buf2, &mut headers2);
        assert_eq!(parse_range_offset(&req2), 0);
    }

    /// Build a minimal tailnet `Node` at `ipv4` with the given stable id.
    fn node_at(stable: &str, ipv4: &str) -> ts_control::Node {
        use ts_control::{Node, NodeCapMap, StableNodeId, TailnetAddress};
        Node {
            id: 1,
            stable_id: StableNodeId(stable.to_string()),
            hostname: stable.to_string(),
            user_id: 0,
            tailnet: Some("user.ts.net".to_string()),
            tags: vec![],
            tailnet_address: TailnetAddress {
                ipv4: format!("{ipv4}/32").parse().unwrap(),
                ipv6: "fd7a::1/128".parse().unwrap(),
            },
            node_key: [0u8; 32].into(),
            node_key_expiry: None,
            key_signature: vec![],
            machine_key: None,
            disco_key: None,
            accepted_routes: vec![],
            underlay_addresses: vec![],
            derp_region: None,
            cap: Default::default(),
            cap_map: NodeCapMap::new(),
            peerapi_port: None,
            peerapi_dns_proxy: false,
            is_wireguard_only: false,
            exit_node_dns_resolvers: vec![],
            peer_relay: false,
            service_vips: Default::default(),
        }
    }

    /// A `DnsView` whose self node holds (or not) the file-sharing node cap, and a peer DB with the
    /// given peer IPs present.
    fn view_with(node_has_cap: bool, peer_ips: &[Ipv4Addr]) -> DnsView {
        use crate::peer_tracker::PeerDb;

        let mut self_node = node_at("self", "100.64.0.1");
        if node_has_cap {
            self_node
                .cap_map
                .insert(FILE_SHARING_NODE_CAP.to_string(), Vec::new());
        }

        let mut db = PeerDb::default();
        for (i, ip) in peer_ips.iter().enumerate() {
            db.upsert(&node_at(&format!("peer{i}"), &ip.to_string()));
        }

        DnsView {
            self_node: Some(self_node),
            peers: Some(Arc::new(db)),
            ..Default::default()
        }
    }

    fn src(ip: &str) -> SocketAddr {
        SocketAddr::new(IpAddr::V4(ip.parse().unwrap()), 41234)
    }

    #[test]
    fn gate_denies_without_store() {
        let v = view_with(true, &["100.64.0.9".parse().unwrap()]);
        assert_eq!(
            gate_taildrop(&v, src("100.64.0.9"), false),
            GateDecision::Deny
        );
    }

    #[test]
    fn gate_denies_when_node_lacks_file_sharing_cap() {
        // Store configured + known peer source, but the node does NOT hold the file-sharing cap.
        let v = view_with(false, &["100.64.0.9".parse().unwrap()]);
        assert_eq!(
            gate_taildrop(&v, src("100.64.0.9"), true),
            GateDecision::Deny
        );
    }

    #[test]
    fn gate_denies_unknown_source_ip() {
        let v = view_with(true, &["100.64.0.9".parse().unwrap()]);
        // A source IP that is neither a known peer nor this node.
        assert_eq!(
            gate_taildrop(&v, src("198.51.100.7"), true),
            GateDecision::Deny
        );
    }

    #[test]
    fn gate_allows_known_peer_with_node_cap_and_store() {
        let v = view_with(true, &["100.64.0.9".parse().unwrap()]);
        assert_eq!(
            gate_taildrop(&v, src("100.64.0.9"), true),
            GateDecision::Allow
        );
    }

    #[test]
    fn classify_route_maps_put_to_taildrop() {
        assert_eq!(
            classify_route("PUT", "/v0/put/photo.jpg"),
            Route::TaildropPut {
                name: "photo.jpg".to_string()
            }
        );
        // Percent-decoding applies to the name.
        assert_eq!(
            classify_route("PUT", "/v0/put/my%20file.txt"),
            Route::TaildropPut {
                name: "my file.txt".to_string()
            }
        );
        // A query string after the path is ignored when extracting the route.
        assert_eq!(
            classify_route("PUT", "/v0/put/a.bin?x=1"),
            Route::TaildropPut {
                name: "a.bin".to_string()
            }
        );
    }

    #[test]
    fn classify_route_non_put_on_taildrop_is_405() {
        assert_eq!(
            classify_route("GET", "/v0/put/photo.jpg"),
            Route::TaildropMethodNotAllowed
        );
        assert_eq!(
            classify_route("POST", "/v0/put/photo.jpg"),
            Route::TaildropMethodNotAllowed
        );
    }

    #[test]
    fn classify_route_dns_query_falls_through_to_doh() {
        // The DoH path (and anything else) is handed to the DoH handler — the router does not steal
        // `/dns-query`, preserving the existing exit-node DoH behavior.
        assert_eq!(classify_route("POST", "/dns-query"), Route::DohOrOther);
        assert_eq!(
            classify_route("GET", "/dns-query?dns=abc"),
            Route::DohOrOther
        );
        assert_eq!(classify_route("GET", "/something-else"), Route::DohOrOther);
    }

    #[test]
    fn taildrop_ok_response_is_exact() {
        // Success is HTTP 200 with body exactly `{}\n` and Content-Length 3 (Go `taildropResp`).
        let resp = taildrop_ok_response();
        let text = String::from_utf8(resp).unwrap();
        assert!(text.starts_with("HTTP/1.1 200 OK\r\n"));
        assert!(text.contains("Content-Length: 3\r\n"));
        assert!(text.ends_with("\r\n\r\n{}\n"));
    }

    // ---------------------------------------------------------------------------------------------
    // Request → response path coverage.
    //
    // The netstack `netsock::TcpStream` is a concrete struct with a `pub(crate)` constructor that
    // needs a live `netcore::Channel` + `SocketHandle`; it cannot be built from a
    // `tokio::io::duplex` half. `route_conn` / `handle_taildrop_put` are hard-typed to it, so a
    // single end-to-end duplex drive of those two functions is infeasible without changing their
    // production signatures (which we will not do gratuitously). Instead we exercise the request →
    // response path at the seams the types allow:
    //
    //  * `taildrop_request_path` below reproduces exactly the decision sequence that
    //    `route_conn` + `handle_taildrop_put` walk (classify → gate → content-length → name
    //    validation via `put_file`), driving the body over a real `tokio::io::duplex` async stream
    //    through the production `BodyReader` and the production `TaildropStore::put_file`, and
    //    emitting the production response bytes. This covers 200/403/400/405 and the file landing in
    //    the store.
    //  * `body_reader_caps_at_content_length` drives the production `BodyReader` (now generic) over
    //    a `tokio::io::duplex` half whose source is LARGER than the declared length, asserting only
    //    `content_length` bytes are delivered.
    //  * `dns_query_post_is_not_taildrop_405_or_404` asserts the DoH POST still reaches the DoH path
    //    (a `DohOrOther` route, never `405`/Taildrop), the regression guard requested for the
    //    refactor.

    use crate::taildrop::TaildropStore;

    fn tmp_store() -> (std::path::PathBuf, Arc<TaildropStore>) {
        let mut root = std::env::temp_dir();
        root.push(format!(
            "peerapi-test-{}-{}",
            std::process::id(),
            std::time::SystemTime::now()
                .duration_since(std::time::UNIX_EPOCH)
                .unwrap()
                .as_nanos()
        ));
        let store = Arc::new(TaildropStore::new(&root).unwrap());
        (root, store)
    }

    /// Drive the exact decision sequence of `route_conn` → `handle_taildrop_put` against a real
    /// async body stream, returning the production response status line (first line) plus body. This
    /// mirrors the production control flow seam-for-seam: classify the route, run the gate, require a
    /// Content-Length, then stream the `BodyReader` into `TaildropStore::put_file` and map the result
    /// through the same status codes.
    async fn taildrop_request_path(
        method: &str,
        full_path: &str,
        content_length: Option<u64>,
        body: &[u8],
        store: Option<Arc<TaildropStore>>,
        view: &DnsView,
        src: SocketAddr,
    ) -> (String, Vec<u8>) {
        // Status helper mirroring `peerapi_doh::write_status`'s wire shape closely enough for the
        // assertions (status line is what we check).
        fn status(code: &str) -> (String, Vec<u8>) {
            (format!("HTTP/1.1 {code}"), Vec::new())
        }

        match classify_route(method, full_path) {
            Route::TaildropMethodNotAllowed | Route::IngressMethodNotAllowed => {
                status("405 Method Not Allowed")
            }
            // This helper only drives Taildrop request paths; the ingress route is covered by its own
            // pure tests (classify / gate / 101 bytes), so it is not exercised here.
            Route::Ingress => status("INGRESS"),
            Route::DohOrOther => status("DOH"), // would be handed to the DoH handler
            Route::TaildropPut { name } => {
                // Gate (fail-closed): no store → 403; gate Deny → 403.
                let Some(store) = store else {
                    return status("403 Forbidden");
                };
                if gate_taildrop(view, src, true) == GateDecision::Deny {
                    return status("403 Forbidden");
                }
                let Some(content_length) = content_length else {
                    return status("400 Bad Request");
                };

                // Real async stream carrying the body, fed through the production BodyReader.
                let (mut client, server) = tokio::io::duplex(64 * 1024);
                let body = body.to_vec();
                tokio::spawn(async move {
                    client.write_all(&body).await.ok();
                    client.shutdown().await.ok();
                });
                let reader = BodyReader::new(Vec::new(), server, content_length);

                match store.put_file(&name, reader, 0).await {
                    Ok(_) => {
                        let resp = taildrop_ok_response();
                        // Split off the status line + body for the assertions.
                        let text = String::from_utf8_lossy(&resp).into_owned();
                        let line = text.lines().next().unwrap_or("").to_string();
                        (line, b"{}\n".to_vec())
                    }
                    Err(TaildropError::InvalidFileName) => status("400 Bad Request"),
                    Err(TaildropError::FileExists) => status("409 Conflict"),
                    Err(TaildropError::Io(_)) => status("500 Internal Server Error"),
                }
            }
        }
    }

    #[tokio::test]
    async fn put_request_allowed_writes_file_and_200() {
        let (root, store) = tmp_store();
        let view = view_with(true, &["100.64.0.9".parse().unwrap()]);
        let body = b"hello over the wire";

        let (line, resp_body) = taildrop_request_path(
            "PUT",
            "/v0/put/wire.txt",
            Some(body.len() as u64),
            body,
            Some(store.clone()),
            &view,
            src("100.64.0.9"),
        )
        .await;

        assert_eq!(line, "HTTP/1.1 200 OK");
        assert_eq!(resp_body, b"{}\n");
        // The file landed in the store with the exact body.
        assert_eq!(std::fs::read(root.join("wire.txt")).unwrap(), body);

        std::fs::remove_dir_all(&root).ok();
    }

    #[tokio::test]
    async fn put_request_denied_by_gate_is_403() {
        let view = view_with(true, &["100.64.0.9".parse().unwrap()]);

        // No store configured → 403.
        let (line, _) = taildrop_request_path(
            "PUT",
            "/v0/put/x.txt",
            Some(1),
            b"x",
            None,
            &view,
            src("100.64.0.9"),
        )
        .await;
        assert_eq!(line, "HTTP/1.1 403 Forbidden");

        // Store present but node lacks the file-sharing cap → gate Deny → 403.
        let (root, store) = tmp_store();
        let no_cap = view_with(false, &["100.64.0.9".parse().unwrap()]);
        let (line, _) = taildrop_request_path(
            "PUT",
            "/v0/put/x.txt",
            Some(1),
            b"x",
            Some(store),
            &no_cap,
            src("100.64.0.9"),
        )
        .await;
        assert_eq!(line, "HTTP/1.1 403 Forbidden");
        std::fs::remove_dir_all(&root).ok();
    }

    #[tokio::test]
    async fn put_request_with_bad_name_is_400() {
        let (root, store) = tmp_store();
        let view = view_with(true, &["100.64.0.9".parse().unwrap()]);

        // `../escape` percent-encoded as `%2E%2E%2Fescape`; classify percent-decodes it to
        // `../escape`, which `put_file` rejects → InvalidFileName → 400.
        let (line, _) = taildrop_request_path(
            "PUT",
            "/v0/put/%2E%2E%2Fescape",
            Some(1),
            b"x",
            Some(store),
            &view,
            src("100.64.0.9"),
        )
        .await;
        assert_eq!(line, "HTTP/1.1 400 Bad Request");
        // Nothing escaped the store root.
        std::fs::remove_dir_all(&root).ok();
    }

    #[tokio::test]
    async fn get_on_taildrop_path_is_405() {
        let view = view_with(true, &["100.64.0.9".parse().unwrap()]);
        let (root, store) = tmp_store();
        let (line, _) = taildrop_request_path(
            "GET",
            "/v0/put/x.txt",
            Some(1),
            b"x",
            Some(store),
            &view,
            src("100.64.0.9"),
        )
        .await;
        assert_eq!(line, "HTTP/1.1 405 Method Not Allowed");
        std::fs::remove_dir_all(&root).ok();
    }

    #[test]
    fn classify_route_maps_post_to_ingress() {
        assert_eq!(classify_route("POST", "/v0/ingress"), Route::Ingress);
        // A query string after the path is ignored when extracting the route.
        assert_eq!(classify_route("POST", "/v0/ingress?x=1"), Route::Ingress);
    }

    #[test]
    fn classify_route_non_post_on_ingress_is_405() {
        assert_eq!(
            classify_route("GET", "/v0/ingress"),
            Route::IngressMethodNotAllowed
        );
        assert_eq!(
            classify_route("PUT", "/v0/ingress"),
            Route::IngressMethodNotAllowed
        );
    }

    #[test]
    fn ingress_101_response_is_exact() {
        // The hijack reply must be exactly the 101 status line + blank line, nothing else — those
        // bytes are written before the connection becomes the public client's raw TLS stream.
        assert_eq!(
            ingress_101_response(),
            b"HTTP/1.1 101 Switching Protocols\r\n\r\n"
        );
    }

    #[test]
    fn gate_ingress_allows_known_node_denies_unknown() {
        // Mirror the Taildrop membership gate: a source that resolves to a known tailnet node (peer
        // or self) is allowed; an off-tailnet source is denied (fail-closed).
        let v = view_with(true, &["100.64.0.9".parse().unwrap()]);
        assert_eq!(gate_ingress(&v, src("100.64.0.9")), GateDecision::Allow);
        // Self node is at 100.64.0.1 (see `view_with`).
        assert_eq!(gate_ingress(&v, src("100.64.0.1")), GateDecision::Allow);
        // Unknown / off-tailnet source → Deny.
        assert_eq!(gate_ingress(&v, src("198.51.100.7")), GateDecision::Deny);
    }

    #[test]
    fn gate_ingress_denies_when_no_peers_and_no_self() {
        // An empty view (no self node, no peers) denies every source — fail-closed before any
        // funnel listener could ever be reached.
        let v = DnsView::default();
        assert_eq!(gate_ingress(&v, src("100.64.0.9")), GateDecision::Deny);
    }

    #[test]
    fn dns_query_post_is_not_taildrop_405_or_404() {
        // Regression guard for the refactor: a DoH POST must not be stolen by the Taildrop router; it
        // classifies as `DohOrOther` and is handed to the DoH handler (it never short-circuits to
        // 405 or a Taildrop response in `route_conn`).
        assert_eq!(classify_route("POST", "/dns-query"), Route::DohOrOther);
        assert_eq!(classify_route("POST", "/dns-query?x=1"), Route::DohOrOther);
    }

    #[tokio::test]
    async fn body_reader_caps_at_content_length() {
        // Feed a source LARGER than the declared length over a real async duplex stream and assert
        // the production `BodyReader` delivers exactly `content_length` bytes (the cap holds, so a
        // peer can't smuggle bytes past the declared body into `put_file`).
        let declared: u64 = 8;
        let (mut client, server) = tokio::io::duplex(64 * 1024);
        tokio::spawn(async move {
            // 20 bytes available, only 8 should be read.
            client.write_all(b"01234567OVERFLOW1234").await.ok();
            client.shutdown().await.ok();
        });

        let mut reader = BodyReader::new(Vec::new(), server, declared);
        let mut out = Vec::new();
        let mut chunk = [0u8; 4];
        loop {
            let n = tokio::io::AsyncReadExt::read(&mut reader, &mut chunk)
                .await
                .unwrap();
            if n == 0 {
                break;
            }
            out.extend_from_slice(&chunk[..n]);
        }
        assert_eq!(out, b"01234567");
        assert_eq!(out.len() as u64, declared);
    }

    #[tokio::test]
    async fn body_reader_includes_seed_then_caps() {
        // The seed bytes (already read while parsing headers) count toward the cap: seed=3, declared
        // total=6, stream supplies more but is capped so total delivered == 6 (seed first, then 3
        // stream bytes). Drive it with the same fixed-buffer read loop `put_file` uses (production's
        // actual read pattern) rather than `read_to_end`.
        let declared: u64 = 6;
        let (mut client, server) = tokio::io::duplex(64 * 1024);
        tokio::spawn(async move {
            client.write_all(b"XXXXXXXXXX").await.ok(); // plenty, will be capped
            client.shutdown().await.ok();
        });
        let mut reader = BodyReader::new(b"abc".to_vec(), server, declared);
        let mut out = Vec::new();
        let mut chunk = [0u8; 4];
        loop {
            let n = tokio::io::AsyncReadExt::read(&mut reader, &mut chunk)
                .await
                .unwrap();
            if n == 0 {
                break;
            }
            out.extend_from_slice(&chunk[..n]);
        }
        assert_eq!(out.len() as u64, declared);
        assert_eq!(out, b"abcXXX");
    }
}