geezipx-core 0.5.0

Compression/decompression core engine for GeeZipX
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
//! Streaming I/O wrappers with progress tracking.
//!
//! This module provides [`ProgressReader`] and [`ProgressWriter`] wrappers
//! that count bytes transferred and optionally invoke a
//! [`ProgressCallback`] to report progress.  When no callback is attached
//! the overhead is a single `Option` check (branch predictor wins on it).
//!
//! # Example
//!
//! ```ignore
//! use std::io::{Read, Cursor};
//! use geezipx_core::{Phase, ProgressReader};
//!
//! let data = b"hello world";
//! let mut reader = ProgressReader::new(Cursor::new(data))
//!     .with_total(data.len() as u64);
//! let mut buf = Vec::new();
//! reader.read_to_end(&mut buf).unwrap();
//! assert_eq!(reader.bytes_read(), data.len() as u64);
//! ```

use std::fmt;
use std::io::{Read, Write};

// ---------------------------------------------------------------------------
// Phase
// ---------------------------------------------------------------------------

/// Identifies the current phase of an operation.
///
/// Used by [`ProgressEvent`] to distinguish reading from writing (and
/// hashing, reserved for future use).
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum Phase {
    /// Data is being read / decompressed.
    Reading,
    /// Data is being written / compressed.
    Writing,
    /// A checksum or hash is being computed (reserved for future use).
    Hashing,
}

// ---------------------------------------------------------------------------
// ProgressEvent
// ---------------------------------------------------------------------------

/// A single progress notification emitted by a streaming wrapper.
///
/// Delivered via [`ProgressCallback::update`].
#[derive(Debug, Clone, Copy)]
pub struct ProgressEvent {
    /// Bytes processed so far.
    pub current: u64,
    /// Total bytes expected, if known.
    pub total: Option<u64>,
    /// Whether we are reading or writing.
    pub phase: Phase,
}

// ---------------------------------------------------------------------------
// ProgressCallback
// ---------------------------------------------------------------------------

/// Trait for objects that can receive progress events from a streaming
/// wrapper.
///
/// All methods have default implementations so the simplest callback only
/// needs to override [`update`](ProgressCallback::update).
pub trait ProgressCallback: Send {
    /// Called after every successful `read` / `write` to report progress.
    fn update(&mut self, _event: ProgressEvent) {}

    /// Called to check whether the user has requested cancellation.
    ///
    /// Called by `ProgressReader` and `ProgressWriter` before each I/O
    /// operation.  Returns `false` by default.
    fn is_cancelled(&self) -> bool {
        false
    }
}

// ---------------------------------------------------------------------------
// ProgressReader
// ---------------------------------------------------------------------------

/// A `Read` wrapper that counts bytes transferred and optionally
/// reports progress via a callback.
///
/// When no callback is attached the only overhead is a single `Option`
/// check per `read` call.
///
/// # Builder pattern
///
/// ```ignore
/// use std::io::Cursor;
/// use geezipx_core::ProgressReader;
///
/// let reader = ProgressReader::new(Cursor::new(b"data"))
///     .with_total(4)
///     .with_callback(Box::new(MyCallback));
/// ```
pub struct ProgressReader<R: Read> {
    inner: R,
    bytes_read: u64,
    total: Option<u64>,
    callback: Option<Box<dyn ProgressCallback>>,
}

impl<R: Read> ProgressReader<R> {
    /// Create a new wrapper with no callback and no known total.
    pub fn new(inner: R) -> Self {
        ProgressReader {
            inner,
            bytes_read: 0,
            total: None,
            callback: None,
        }
    }

    /// Attach a known total size (sets `total` in emitted events).
    pub fn with_total(mut self, total: u64) -> Self {
        self.total = Some(total);
        self
    }

    /// Attach a progress callback.
    pub fn with_callback(mut self, cb: Box<dyn ProgressCallback>) -> Self {
        self.callback = Some(cb);
        self
    }

    /// Total bytes read so far.
    pub fn bytes_read(&self) -> u64 {
        self.bytes_read
    }

    /// Consume the wrapper and return the inner reader.
    pub fn into_inner(self) -> R {
        self.inner
    }
}

impl<R: Read> Read for ProgressReader<R> {
    fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
        // Check cancellation before I/O
        if let Some(ref cb) = self.callback {
            if cb.is_cancelled() {
                return Err(std::io::Error::new(
                    std::io::ErrorKind::Interrupted,
                    "operation cancelled by user",
                ));
            }
        }

        let n = self.inner.read(buf)?;
        self.bytes_read += n as u64;

        if n > 0 {
            if let Some(ref mut cb) = self.callback {
                cb.update(ProgressEvent {
                    current: self.bytes_read,
                    total: self.total,
                    phase: Phase::Reading,
                });
            }
        }

        Ok(n)
    }
}

impl<R: Read + fmt::Debug> fmt::Debug for ProgressReader<R> {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("ProgressReader")
            .field("inner", &self.inner)
            .field("bytes_read", &self.bytes_read)
            .field("total", &self.total)
            .field("has_callback", &self.callback.is_some())
            .finish()
    }
}

// ---------------------------------------------------------------------------
// ProgressWriter
// ---------------------------------------------------------------------------

/// A `Write` wrapper that counts bytes transferred and optionally
/// reports progress via a callback.
///
/// When no callback is attached the only overhead is a single `Option`
/// check per `write` call.
pub struct ProgressWriter<W: Write> {
    inner: W,
    bytes_written: u64,
    total: Option<u64>,
    callback: Option<Box<dyn ProgressCallback>>,
}

impl<W: Write> ProgressWriter<W> {
    /// Create a new wrapper with no callback and no known total.
    pub fn new(inner: W) -> Self {
        ProgressWriter {
            inner,
            bytes_written: 0,
            total: None,
            callback: None,
        }
    }

    /// Attach a known total size.
    pub fn with_total(mut self, total: u64) -> Self {
        self.total = Some(total);
        self
    }

    /// Attach a progress callback.
    pub fn with_callback(mut self, cb: Box<dyn ProgressCallback>) -> Self {
        self.callback = Some(cb);
        self
    }

    /// Total bytes written so far.
    pub fn bytes_written(&self) -> u64 {
        self.bytes_written
    }

    /// Consume the wrapper and return the inner writer.
    pub fn into_inner(self) -> W {
        self.inner
    }
}

impl<W: Write> Write for ProgressWriter<W> {
    fn write(&mut self, buf: &[u8]) -> std::io::Result<usize> {
        // Check cancellation before I/O
        if let Some(ref cb) = self.callback {
            if cb.is_cancelled() {
                return Err(std::io::Error::new(
                    std::io::ErrorKind::Interrupted,
                    "operation cancelled by user",
                ));
            }
        }

        let n = self.inner.write(buf)?;
        self.bytes_written += n as u64;

        if n > 0 {
            if let Some(ref mut cb) = self.callback {
                cb.update(ProgressEvent {
                    current: self.bytes_written,
                    total: self.total,
                    phase: Phase::Writing,
                });
            }
        }

        Ok(n)
    }

    fn flush(&mut self) -> std::io::Result<()> {
        self.inner.flush()
    }
}

impl<W: Write + fmt::Debug> fmt::Debug for ProgressWriter<W> {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("ProgressWriter")
            .field("inner", &self.inner)
            .field("bytes_written", &self.bytes_written)
            .field("total", &self.total)
            .field("has_callback", &self.callback.is_some())
            .finish()
    }
}

// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------

#[cfg(test)]
mod tests {
    use super::*;
    use std::io::Cursor;

    /// A simple callback that collects every event it receives.
    #[derive(Debug)]
    struct TestCallback {
        events: Vec<ProgressEvent>,
    }

    impl TestCallback {
        fn new() -> Self {
            TestCallback { events: Vec::new() }
        }
    }

    impl ProgressCallback for TestCallback {
        fn update(&mut self, event: ProgressEvent) {
            self.events.push(event);
        }
    }

    // ---------------------------------------------------------------
    // ProgressReader tests
    // ---------------------------------------------------------------

    #[test]
    fn progress_reader_counts_bytes() {
        let data = b"hello, world!";
        let mut reader = ProgressReader::new(Cursor::new(data));
        let mut buf = Vec::new();
        reader.read_to_end(&mut buf).unwrap();
        assert_eq!(reader.bytes_read(), data.len() as u64);
        assert_eq!(&buf, data);
    }

    #[test]
    fn progress_reader_no_callback() {
        let data = b"no callback here";
        let mut reader = ProgressReader::new(Cursor::new(data));
        let mut buf = [0u8; 64];
        let n = reader.read(&mut buf).unwrap();
        assert_eq!(n, data.len());
        assert_eq!(&buf[..n], data);
    }

    #[test]
    fn progress_reader_with_callback() {
        let data = b"callback test data";
        let cb = TestCallback::new();
        let mut reader = ProgressReader::new(Cursor::new(data)).with_callback(Box::new(cb));
        let mut buf = Vec::new();
        reader.read_to_end(&mut buf).unwrap();

        // The callback was moved in, we need to retrieve it.  Since we
        // cannot get it back, we verify the data instead and test event
        // delivery in a separate test that borrows the callback.
        assert_eq!(&buf, data);
        assert_eq!(reader.bytes_read(), data.len() as u64);
    }

    #[test]
    fn progress_reader_with_total() {
        let data = b"known length";
        let total = data.len() as u64;
        let mut reader = ProgressReader::new(Cursor::new(data)).with_total(total);
        let mut buf = Vec::new();
        reader.read_to_end(&mut buf).unwrap();
        assert_eq!(reader.bytes_read(), total);
    }

    #[test]
    fn progress_reader_partial_reads() {
        let data = b"partial reads test";
        let mut reader = ProgressReader::new(Cursor::new(data));
        let mut buf = [0u8; 4];

        assert_eq!(reader.read(&mut buf).unwrap(), 4);
        assert_eq!(reader.bytes_read(), 4);

        assert_eq!(reader.read(&mut buf).unwrap(), 4);
        assert_eq!(reader.bytes_read(), 8);

        // Read remaining
        let mut rest = Vec::new();
        reader.read_to_end(&mut rest).unwrap();
        assert_eq!(reader.bytes_read(), data.len() as u64);
    }

    #[test]
    fn progress_reader_empty_input() {
        let data = b"";
        let cb = TestCallback::new();
        let mut reader = ProgressReader::new(Cursor::new(data)).with_callback(Box::new(cb));
        let mut buf = Vec::new();
        reader.read_to_end(&mut buf).unwrap();
        assert_eq!(reader.bytes_read(), 0);
        assert!(buf.is_empty());
    }

    #[test]
    fn progress_reader_into_inner() {
        let data = b"give it back";
        let inner = Cursor::new(data);
        let reader = ProgressReader::new(inner);
        let recovered = reader.into_inner();
        assert_eq!(recovered.into_inner(), data);
    }

    // ---------------------------------------------------------------
    // ProgressWriter tests
    // ---------------------------------------------------------------

    #[test]
    fn progress_writer_counts_bytes() {
        let data = b"writing test";
        let mut writer = ProgressWriter::new(Vec::new());
        writer.write_all(data).unwrap();
        assert_eq!(writer.bytes_written(), data.len() as u64);
        assert_eq!(&writer.into_inner(), data);
    }

    #[test]
    fn progress_writer_no_callback() {
        let data = b"no callback writer";
        let mut writer = ProgressWriter::new(Vec::new());
        writer.write_all(data).unwrap();
        writer.flush().unwrap();
        assert_eq!(writer.bytes_written(), data.len() as u64);
    }

    #[test]
    fn progress_writer_with_callback() {
        let data = b"writer callback test";
        let mut writer =
            ProgressWriter::new(Vec::new()).with_callback(Box::new(TestCallback::new()));
        writer.write_all(data).unwrap();
        assert_eq!(writer.bytes_written(), data.len() as u64);
    }

    #[test]
    fn progress_writer_flush_and_into_inner() {
        let mut writer = ProgressWriter::new(Vec::new());
        writer.write_all(b"flush test").unwrap();
        writer.flush().unwrap();
        let inner = writer.into_inner();
        assert_eq!(&inner, b"flush test");
    }

    // ---------------------------------------------------------------
    // Event verification — test that callbacks actually receive events
    // ---------------------------------------------------------------

    #[test]
    fn progress_reader_events_are_correct() {
        use std::sync::{Arc, Mutex};

        let data = b"event check";
        let cb = Arc::new(Mutex::new(TestCallback::new()));

        struct EventCollector(Arc<Mutex<TestCallback>>);
        impl ProgressCallback for EventCollector {
            fn update(&mut self, event: ProgressEvent) {
                self.0.lock().unwrap().events.push(event);
            }
        }

        let mut reader = ProgressReader::new(Cursor::new(data))
            .with_total(data.len() as u64)
            .with_callback(Box::new(EventCollector(cb.clone())));

        let mut buf = Vec::new();
        reader.read_to_end(&mut buf).unwrap();

        let events = cb.lock().unwrap().events.clone();
        assert!(!events.is_empty(), "should have received events");

        let last = events.last().unwrap();
        assert_eq!(last.current, data.len() as u64);
        assert_eq!(last.total, Some(data.len() as u64));
        assert_eq!(last.phase, Phase::Reading);
    }

    #[test]
    fn progress_writer_events_are_correct() {
        use std::sync::{Arc, Mutex};

        let data = b"writer events";
        let cb = Arc::new(Mutex::new(TestCallback::new()));

        struct EventCollector(Arc<Mutex<TestCallback>>);
        impl ProgressCallback for EventCollector {
            fn update(&mut self, event: ProgressEvent) {
                self.0.lock().unwrap().events.push(event);
            }
        }

        let mut writer = ProgressWriter::new(Vec::new())
            .with_total(data.len() as u64)
            .with_callback(Box::new(EventCollector(cb.clone())));

        writer.write_all(data).unwrap();

        let events = cb.lock().unwrap().events.clone();
        assert!(!events.is_empty(), "should have received events");

        let last = events.last().unwrap();
        assert_eq!(last.current, data.len() as u64);
        assert_eq!(last.total, Some(data.len() as u64));
        assert_eq!(last.phase, Phase::Writing);
    }

    // ---------------------------------------------------------------
    // Derive / trait checks
    // ---------------------------------------------------------------

    #[test]
    fn progress_event_debug_clone() {
        let event = ProgressEvent {
            current: 42,
            total: Some(100),
            phase: Phase::Reading,
        };
        let debug = format!("{:?}", event);
        assert!(debug.contains("42"));
        assert!(debug.contains("100"));
        assert!(debug.contains("Reading"));
    }

    #[test]
    fn progress_callback_default_is_cancelled() {
        struct Dummy;
        impl ProgressCallback for Dummy {}

        let cb = Dummy;
        assert!(!cb.is_cancelled());
    }

    #[test]
    fn phase_debug_clone_partial_eq() {
        assert_eq!(Phase::Reading, Phase::Reading);
        assert_ne!(Phase::Reading, Phase::Writing);
        assert_ne!(Phase::Hashing, Phase::Writing);
        let _ = format!("{:?}", Phase::Hashing);
    }

    // ---------------------------------------------------------------
    // Gzip roundtrip with progress
    // ---------------------------------------------------------------

    #[test]
    fn gzip_roundtrip_with_progress() {
        use crate::archive::gzip;
        use std::sync::{Arc, Mutex};

        let original = b"gzip progress roundtrip test data!";

        // Count reader events.
        let read_events = Arc::new(Mutex::new(TestCallback::new()));
        struct ReadCollector(Arc<Mutex<TestCallback>>);
        impl ProgressCallback for ReadCollector {
            fn update(&mut self, event: ProgressEvent) {
                self.0.lock().unwrap().events.push(event);
            }
        }

        // Compress with progress reader.
        let mut source = ProgressReader::new(Cursor::new(original))
            .with_total(original.len() as u64)
            .with_callback(Box::new(ReadCollector(read_events.clone())));

        let compressed = {
            let mut buf = Vec::new();
            gzip::gzip_compress(&mut source, &mut buf).unwrap();
            buf
        };

        // Verify reader events.
        {
            let events = read_events.lock().unwrap().events.clone();
            assert!(!events.is_empty(), "reader should have received events");
            let last = events.last().unwrap();
            assert_eq!(last.current, original.len() as u64);
            assert_eq!(last.total, Some(original.len() as u64));
            assert_eq!(last.phase, Phase::Reading);
        }

        // Count writer events.
        let write_events = Arc::new(Mutex::new(TestCallback::new()));
        struct WriteCollector(Arc<Mutex<TestCallback>>);
        impl ProgressCallback for WriteCollector {
            fn update(&mut self, event: ProgressEvent) {
                self.0.lock().unwrap().events.push(event);
            }
        }

        // Decompress with progress writer.
        let mut decompress_target = ProgressWriter::new(Vec::new())
            .with_callback(Box::new(WriteCollector(write_events.clone())));

        let mut compressed_reader = Cursor::new(compressed.as_slice());
        let bytes = gzip::gzip_decompress(&mut compressed_reader, &mut decompress_target).unwrap();

        // Verify content matches.
        let decompressed = decompress_target.into_inner();
        assert_eq!(bytes, original.len() as u64);
        assert_eq!(decompressed, original);

        // Verify writer events.
        {
            let events = write_events.lock().unwrap().events.clone();
            assert!(!events.is_empty(), "writer should have received events");
            let last = events.last().unwrap();
            assert_eq!(last.current, original.len() as u64);
            assert_eq!(last.phase, Phase::Writing);
            // total is None because we didn't set it on the writer
            assert_eq!(last.total, None);
        }
    }

    // ---------------------------------------------------------------
    // Composition tests
    // ---------------------------------------------------------------

    #[test]
    fn progress_reader_bufreader_composition() {
        let data = vec![0u8; 10_000];
        let pr = ProgressReader::new(std::io::Cursor::new(data.clone())).with_total(10_000);
        let mut br = std::io::BufReader::new(pr);
        let mut buf = Vec::new();
        br.read_to_end(&mut buf).unwrap();
        assert_eq!(br.into_inner().bytes_read(), 10_000);
        assert_eq!(buf.len(), 10_000);
    }

    #[test]
    fn progress_writer_bufwriter_composition() {
        let data = vec![0xABu8; 10_000];
        let pw = ProgressWriter::new(Vec::new()).with_total(10_000);
        let mut bw = std::io::BufWriter::new(pw);
        bw.write_all(&data).unwrap();
        bw.flush().unwrap();
        let inner = bw.into_inner().unwrap();
        assert_eq!(inner.bytes_written(), 10_000);
        assert_eq!(inner.into_inner(), data);
    }

    // ---------------------------------------------------------------
    // Error propagation tests
    // ---------------------------------------------------------------

    struct FailingReader {
        reads_before_fail: usize,
        read_count: usize,
    }

    impl std::io::Read for FailingReader {
        fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
            if self.read_count >= self.reads_before_fail {
                return Err(std::io::Error::other("test error"));
            }
            self.read_count += 1;
            if !buf.is_empty() {
                buf[0] = 0x01;
                Ok(1)
            } else {
                Ok(0)
            }
        }
    }

    #[test]
    fn progress_reader_passes_errors() {
        let failing = FailingReader {
            reads_before_fail: 2,
            read_count: 0,
        };
        let mut pr = ProgressReader::new(failing);
        let mut buf = [0u8; 16];
        assert!(pr.read(&mut buf).is_ok());
        assert!(pr.read(&mut buf).is_ok());
        let err = pr.read(&mut buf).unwrap_err();
        assert_eq!(err.kind(), std::io::ErrorKind::Other);
        assert_eq!(err.to_string(), "test error");
    }

    struct FailingWriter {
        writes_before_fail: usize,
        write_count: usize,
    }

    impl std::io::Write for FailingWriter {
        fn write(&mut self, buf: &[u8]) -> std::io::Result<usize> {
            if self.write_count >= self.writes_before_fail {
                return Err(std::io::Error::other("test error"));
            }
            self.write_count += 1;
            Ok(buf.len())
        }

        fn flush(&mut self) -> std::io::Result<()> {
            Ok(())
        }
    }

    #[test]
    fn progress_writer_passes_errors() {
        let failing = FailingWriter {
            writes_before_fail: 2,
            write_count: 0,
        };
        let mut pw = ProgressWriter::new(failing);
        assert!(pw.write(b"aaa").is_ok());
        assert!(pw.write(b"bbb").is_ok());
        let err = pw.write(b"ccc").unwrap_err();
        assert_eq!(err.kind(), std::io::ErrorKind::Other);
        assert_eq!(err.to_string(), "test error");
    }

    // ---------------------------------------------------------------
    // Cancellation tests
    // ---------------------------------------------------------------

    struct CancellingCallback {
        cancel_after: usize,
        calls: usize,
    }

    impl ProgressCallback for CancellingCallback {
        fn update(&mut self, _event: ProgressEvent) {
            self.calls += 1;
        }

        fn is_cancelled(&self) -> bool {
            self.calls >= self.cancel_after
        }
    }

    #[test]
    fn progress_reader_cancelled_before_first_read() {
        struct AlwaysCancel;
        impl ProgressCallback for AlwaysCancel {
            fn update(&mut self, _event: ProgressEvent) {}
            fn is_cancelled(&self) -> bool {
                true
            }
        }

        let data = b"hello world";
        let mut reader =
            ProgressReader::new(Cursor::new(data)).with_callback(Box::new(AlwaysCancel));
        let mut buf = [0u8; 64];
        let err = reader.read(&mut buf).unwrap_err();
        assert_eq!(err.kind(), std::io::ErrorKind::Interrupted);
        assert!(err.to_string().contains("cancelled"));
    }

    #[test]
    fn progress_reader_cancelled_mid_stream() {
        let data = b"1234567890";
        // Cancel after 2 reads (each byte read)
        let mut reader =
            ProgressReader::new(Cursor::new(data)).with_callback(Box::new(CancellingCallback {
                cancel_after: 2,
                calls: 0,
            }));
        let mut buf = [0u8; 1];

        // First read: ok
        let _n = reader.read(&mut buf).unwrap();
        // Second read: ok
        let _n = reader.read(&mut buf).unwrap();
        // Third read: cancelled (2 calls already, cancel_after=2)
        let err = reader.read(&mut buf).unwrap_err();
        assert_eq!(err.kind(), std::io::ErrorKind::Interrupted);
    }

    #[test]
    fn progress_writer_cancelled() {
        struct AlwaysCancel;
        impl ProgressCallback for AlwaysCancel {
            fn update(&mut self, _event: ProgressEvent) {}
            fn is_cancelled(&self) -> bool {
                true
            }
        }

        let mut output = Vec::new();
        let mut writer = ProgressWriter::new(&mut output).with_callback(Box::new(AlwaysCancel));
        let err = writer.write(b"data").unwrap_err();
        assert_eq!(err.kind(), std::io::ErrorKind::Interrupted);
    }

    #[test]
    fn progress_reader_no_callback_still_works() {
        let data = b"no callback, no cancellation check";
        let mut reader = ProgressReader::new(Cursor::new(data));
        let mut buf = [0u8; 64];
        let n = reader.read(&mut buf).unwrap();
        assert_eq!(n, data.len());
    }
}