garrison 0.9.0

Garrison - 面向 Rust 生态的一站式身份认证鉴权框架
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
// Copyright (c) 2026 Kirky.X🌠
// SPDX-License-Identifier: Apache-2.0
//! 二级认证(Safe Auth)瞬态标记实现(`safe-auth` feature)。
//! 为 `GarrisonLogicDefault` 提供 `open_safe` / `is_safe` / `close_safe` inherent method,基于 `TokenSession.safe_services` 记录 service 级瞬态标记。
//! inherent method 模式:mfa.rs 已有 `impl MfaLogic for GarrisonLogicDefault`,E0119 禁止同类型同 trait 多 impl,故不用 trait 覆写;方法解析优先 inherent——启用时走本模块实现,禁用时走 trait default(`Ok(())`)。
//! 已知限制:经 trait 引用调用(`<GarrisonLogicDefault as MfaLogic>::open_safe`)走 trait default;当前调用方均直接经实例调用。

use super::current_token;
use super::GarrisonLogicDefault;
use crate::error::{GarrisonError, GarrisonResult};

impl GarrisonLogicDefault {
    /// 开启指定 service 的二级认证:在 TokenSession.safe_services 记录 service → 过期时间戳。
    /// per-token 锁保护 read-modify-write 防并发 lost update;未登录返回 `Session`,session 不存在返回 `InvalidToken`,DAO 失败透传。
    pub async fn open_safe(&self, service: &str, duration_secs: u64) -> GarrisonResult<()> {
        if service.is_empty() {
            return Err(GarrisonError::InvalidParam(
                "stp-service-empty::".to_string(),
            ));
        }
        let token = current_token()?;
        let token_prefix = if token.len() >= 8 {
            &token[..8]
        } else {
            &token
        };
        let service = service.to_string();
        self.session
            .with_token_session_lock(&token, async {
                let mut ts = self
                    .session
                    .get_token_session(&token)
                    .await?
                    .ok_or_else(|| {
                        GarrisonError::InvalidToken(format!(
                            "stp-token-not-found::{}",
                            token_prefix
                        ))
                    })?;
                let now = chrono::Utc::now().timestamp();
                let expire_at = now + duration_secs as i64;
                ts.safe_services.insert(service.clone(), expire_at);
                self.session.save_token_session(&token, &ts).await
            })
            .await
    }

    /// 检查 service 是否在二级认证有效期内:未开启 / 已过期 / 未登录或无 session 返回 `Ok(false)`(查询方法语义,未认证即不安全),仅 DAO 读取失败返回 `Err`。
    pub async fn is_safe(&self, service: &str) -> GarrisonResult<bool> {
        if service.is_empty() {
            return Err(GarrisonError::InvalidParam(
                "stp-service-empty::".to_string(),
            ));
        }
        let token = match current_token() {
            Ok(t) => t,
            Err(_) => return Ok(false),
        };
        let ts = match self.session.get_token_session(&token).await? {
            Some(ts) => ts,
            None => return Ok(false),
        };
        let now = chrono::Utc::now().timestamp();
        match ts.safe_services.get(service) {
            Some(expire_at) if *expire_at > now => Ok(true),
            Some(_) => {
                // 惰性清理过期条目:移除并持久化,避免过期数据永久残留
                drop(ts);
                let service_owned = service.to_string();
                let _ = self
                    .session
                    .with_token_session_lock(&token, async {
                        let mut ts = match self.session.get_token_session(&token).await? {
                            Some(ts) => ts,
                            None => return Ok(()),
                        };
                        let now = chrono::Utc::now().timestamp();
                        if ts
                            .safe_services
                            .get(&service_owned)
                            .is_some_and(|e| *e <= now)
                        {
                            ts.safe_services.remove(&service_owned);
                            self.session.save_token_session(&token, &ts).await?;
                        }
                        Ok::<(), GarrisonError>(())
                    })
                    .await;
                Ok(false)
            },
            None => Ok(false),
        }
    }

    /// 关闭指定 service 的二级认证(移除瞬态标记):移除后 `is_safe(service)` 返回 `false`;本就未开启时幂等返回 `Ok(())`。
    /// per-token 锁防 lost update;未登录返回 `Session`,session 不存在返回 `InvalidToken`,DAO 失败透传。
    pub async fn close_safe(&self, service: &str) -> GarrisonResult<()> {
        if service.is_empty() {
            return Err(GarrisonError::InvalidParam(
                "stp-service-empty::".to_string(),
            ));
        }
        let token = current_token()?;
        let token_prefix = if token.len() >= 8 {
            &token[..8]
        } else {
            &token
        };
        let service = service.to_string();
        self.session
            .with_token_session_lock(&token, async {
                let mut ts = self
                    .session
                    .get_token_session(&token)
                    .await?
                    .ok_or_else(|| {
                        GarrisonError::InvalidToken(format!(
                            "stp-token-not-found::{}",
                            token_prefix
                        ))
                    })?;
                ts.safe_services.remove(&service);
                self.session.save_token_session(&token, &ts).await
            })
            .await
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::config::GarrisonConfig;
    use crate::dao::tests::MockDao;
    use crate::dao::GarrisonDao;
    use crate::error::GarrisonError;
    use crate::session::GarrisonSession;
    use crate::stp::session::SessionLogic;
    use crate::stp::with_current_token;
    use crate::stp::LoginParams;
    use crate::strategy::GarrisonPermissionStrategy;
    use async_trait::async_trait;
    use std::sync::Arc;

    // MockFirewall:no-op 权限策略,允许所有登录

    struct MockFirewall;

    #[async_trait]
    impl GarrisonPermissionStrategy for MockFirewall {
        async fn get_permission_list(&self, _login_id: &str) -> GarrisonResult<Vec<String>> {
            Ok(vec![])
        }
        async fn get_role_list(&self, _login_id: &str) -> GarrisonResult<Vec<String>> {
            Ok(vec![])
        }
        async fn check_permission(
            &self,
            _login_id: &str,
            _permission: &str,
        ) -> GarrisonResult<bool> {
            Ok(true)
        }
        async fn check_role(&self, _login_id: &str, _role: &str) -> GarrisonResult<bool> {
            Ok(true)
        }
        async fn check_role_any(&self, _login_id: &str, _roles: &[&str]) -> GarrisonResult<bool> {
            Ok(true)
        }
        async fn check_role_all(&self, _login_id: &str, _roles: &[&str]) -> GarrisonResult<bool> {
            Ok(true)
        }
        async fn check_permission_in_tenant(
            &self,
            _tenant_id: i64,
            _login_id: &str,
            _permission: &str,
        ) -> GarrisonResult<bool> {
            // 测试桩与租户无关:任意租户返回相同结果
            Ok(true)
        }
        async fn check_role_in_tenant(
            &self,
            _tenant_id: i64,
            _login_id: &str,
            _role: &str,
        ) -> GarrisonResult<bool> {
            // 测试桩与租户无关:任意租户返回相同结果
            Ok(true)
        }
        #[cfg(any(
            feature = "sms-rate-limit",
            feature = "firewall-ratelimit",
            feature = "firewall-bruteforce",
            feature = "firewall-ddos",
            feature = "firewall",
            feature = "oauth2-server"
        ))]
        async fn check_login_hooks(
            &self,
            _login_id: &str,
            _ctx: &crate::strategy::hooks::LoginContext,
        ) -> GarrisonResult<()> {
            // 测试桩不注入防火墙 hook,显式 no-op
            Ok(())
        }
    }

    // 辅助函数

    /// 创建 GarrisonLogicDefault 并返回 (logic, dao) 便于测试。
    fn make_logic() -> (GarrisonLogicDefault, Arc<MockDao>) {
        let dao = Arc::new(MockDao::new());
        let session = Arc::new(GarrisonSession::new(
            dao.clone() as Arc<dyn GarrisonDao>,
            3600,
            86400,
            0,
        ));
        let mut config = GarrisonConfig::default_config();
        config.throw_on_not_login = false;
        config.token_style = "uuid".to_string();
        let firewall: Arc<dyn GarrisonPermissionStrategy> = Arc::new(MockFirewall);
        let logic = GarrisonLogicDefault::new(
            session,
            Arc::new(config),
            firewall,
            Arc::new(crate::account::disable::DefaultDisableRepository::new(
                dao.clone(),
            )),
        );
        (logic, dao)
    }

    // 6 个单元测试

    /// open_safe 后 TokenSession.safe_services 包含对应 service 和正确的过期时间。
    #[tokio::test]
    async fn t022_open_safe_sets_safe_marker() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-1001", &LoginParams::default())
            .await
            .unwrap();

        with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await.unwrap();
        })
        .await;

        let ts = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        let expire = ts
            .safe_services
            .get("default")
            .expect("default 应在 safe_services 中");
        let now = chrono::Utc::now().timestamp();
        assert!(
            *expire > now,
            "过期时间应在未来,实际: expire={}, now={}",
            expire,
            now
        );
        assert!(
            *expire <= now + 3601,
            "过期时间应在 now+3600 附近,实际: expire={}, now={}",
            expire,
            now
        );
    }

    /// open_safe("default") + open_safe("payment") 后 safe_services 包含 2 个 entry。
    #[tokio::test]
    async fn t022_open_safe_multiple_services_coexist() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-1002", &LoginParams::default())
            .await
            .unwrap();

        with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await.unwrap();
            logic.open_safe("payment", 7200).await.unwrap();
        })
        .await;

        let ts = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        assert_eq!(
            ts.safe_services.len(),
            2,
            "应有 2 个 service 标记,实际: {:?}",
            ts.safe_services
        );

        let default_expire = ts.safe_services.get("default").expect("default 应存在");
        let payment_expire = ts.safe_services.get("payment").expect("payment 应存在");
        let now = chrono::Utc::now().timestamp();
        assert!(
            *default_expire > now && *default_expire <= now + 3601,
            "default 过期时间应在 now+3600 附近,实际: {}, now={}",
            default_expire,
            now
        );
        assert!(
            *payment_expire > now && *payment_expire <= now + 7201,
            "payment 过期时间应在 now+7200 附近,实际: {}, now={}",
            payment_expire,
            now
        );
    }

    /// open_safe("default", 100) 后再 open_safe("default", 200) 后,过期时间更新为 now+200。
    #[tokio::test]
    async fn t022_open_safe_overwrites_existing_marker() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-1003", &LoginParams::default())
            .await
            .unwrap();

        // 第一次 open_safe,duration=100
        with_current_token(token.clone(), async {
            logic.open_safe("default", 100).await.unwrap();
        })
        .await;
        let ts1 = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        let expire1 = *ts1
            .safe_services
            .get("default")
            .expect("第一次 open_safe 后 default 应存在");

        // 第二次 open_safe 同一 service,duration=200
        with_current_token(token.clone(), async {
            logic.open_safe("default", 200).await.unwrap();
        })
        .await;
        let ts2 = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        let expire2 = *ts2
            .safe_services
            .get("default")
            .expect("第二次 open_safe 后 default 应存在");
        let now = chrono::Utc::now().timestamp();

        // 验证过期时间更新为 now+200 附近,而非保留 expire1
        assert!(
            expire2 > expire1,
            "第二次 open_safe 应覆盖第一次,过期时间应更新,实际: expire1={}, expire2={}",
            expire1,
            expire2
        );
        assert!(
            expire2 >= now + 199 && expire2 <= now + 201,
            "过期时间应在 now+200 附近,实际: expire2={}, now={}",
            expire2,
            now
        );
        // safe_services 仍只有 1 个 entry(覆盖而非新增)
        assert_eq!(
            ts2.safe_services.len(),
            1,
            "覆盖后 safe_services 应仍为 1 个 entry,实际: {:?}",
            ts2.safe_services
        );
    }

    /// duration_secs=0 时 safe_services 中有标记但过期时间为 now(已过期)。
    #[tokio::test]
    async fn t022_open_safe_duration_zero_immediate_expiry() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-1004", &LoginParams::default())
            .await
            .unwrap();

        with_current_token(token.clone(), async {
            logic.open_safe("default", 0).await.unwrap();
        })
        .await;

        let ts = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        let expire = ts
            .safe_services
            .get("default")
            .expect("default 应在 safe_services 中");
        let now = chrono::Utc::now().timestamp();
        // duration=0 → expire_at = now(已过期);允许 ±5 秒偏差(测试执行耗时)
        assert!(
            *expire <= now,
            "duration=0 时过期时间应 <= now(已过期),实际: expire={}, now={}",
            expire,
            now
        );
        assert!(
            *expire >= now - 5,
            "过期时间应在 now 附近(允许 5 秒偏差),实际: expire={}, now={}",
            expire,
            now
        );
    }

    /// 不 login 直接调用 open_safe,返回 Err(Session 错误 - 未设置 current_token)。
    #[tokio::test]
    async fn t022_open_safe_no_session_returns_err() {
        let (logic, _dao) = make_logic();
        let result = logic.open_safe("default", 3600).await;

        match result {
            Err(GarrisonError::Session(msg)) => {
                assert!(
                    msg.contains("stp-context-not-set"),
                    "Session 错误消息应说明未设置 current_token,实际: {}",
                    msg
                );
            },
            other => panic!("期望 Err(GarrisonError::Session),实际: {:?}", other),
        }
    }

    /// login 后手动删除 token session,再调用 open_safe 返回 InvalidToken。
    #[tokio::test]
    async fn t022_open_safe_token_not_exist_returns_err() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-1006", &LoginParams::default())
            .await
            .unwrap();

        logic.session.logout(&token).await.unwrap();

        let result = with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await
        })
        .await;

        match result {
            Err(GarrisonError::InvalidToken(msg)) => {
                // token 脱敏:错误消息只包含前 8 字符
                let expected_prefix = if token.len() >= 8 {
                    &token[..8]
                } else {
                    &token
                };
                assert!(
                    msg.contains(expected_prefix),
                    "InvalidToken 错误消息应包含 token 前缀,实际: {}",
                    msg
                );
                assert!(
                    !msg.contains(&token) || token.len() <= 8,
                    "InvalidToken 错误消息不应包含完整 token(脱敏),实际: {}",
                    msg
                );
            },
            other => panic!("期望 Err(GarrisonError::InvalidToken),实际: {:?}", other),
        }
    }

    // is_safe 单元测试

    /// open_safe("default", 3600) 后 is_safe("default") 返回 Ok(true)。
    #[tokio::test]
    async fn t023_is_safe_returns_true_within_validity() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-2001", &LoginParams::default())
            .await
            .unwrap();

        let result = with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await.unwrap();
            logic.is_safe("default").await
        })
        .await;

        assert!(
            result.unwrap(),
            "open_safe 后 3600 秒内 is_safe 应返回 true"
        );
    }

    /// open_safe("default", 0) 后 is_safe("default") 返回 Ok(false)(duration=0 立即过期)。
    #[tokio::test]
    async fn t023_is_safe_returns_false_after_expiry() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-2002", &LoginParams::default())
            .await
            .unwrap();

        let result = with_current_token(token.clone(), async {
            logic.open_safe("default", 0).await.unwrap();
            logic.is_safe("default").await
        })
        .await;

        assert!(
            !result.unwrap(),
            "duration=0 立即过期,is_safe 应返回 false"
        );
    }

    /// open_safe("default") 后 is_safe("payment") 返回 Ok(false)(payment 未开启)。
    #[tokio::test]
    async fn t023_is_safe_returns_false_without_marker() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-2003", &LoginParams::default())
            .await
            .unwrap();

        let result = with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await.unwrap();
            logic.is_safe("payment").await
        })
        .await;

        assert!(
            !result.unwrap(),
            "payment 未 open_safe,is_safe 应返回 false"
        );
    }

    /// 多 service 独立:default + payment 都 open_safe 后两者都 true;
    /// 手动让 payment 过期后,default 仍 true,payment 变 false。
    #[tokio::test]
    async fn t023_is_safe_multi_service_independent() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-2004", &LoginParams::default())
            .await
            .unwrap();

        with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await.unwrap();
            logic.open_safe("payment", 7200).await.unwrap();
        })
        .await;

        let (safe_default, safe_payment) = with_current_token(token.clone(), async {
            (
                logic.is_safe("default").await.unwrap(),
                logic.is_safe("payment").await.unwrap(),
            )
        })
        .await;
        assert!(safe_default, "default 应处于有效期内");
        assert!(safe_payment, "payment 应处于有效期内");

        // 修改 safe_services 模拟 payment 过期
        let now = chrono::Utc::now().timestamp();
        let mut ts = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        ts.safe_services.insert("payment".to_string(), now - 100);
        logic.session.save_token_session(&token, &ts).await.unwrap();

        let (safe_default_after, safe_payment_after) = with_current_token(token.clone(), async {
            (
                logic.is_safe("default").await.unwrap(),
                logic.is_safe("payment").await.unwrap(),
            )
        })
        .await;
        assert!(
            safe_default_after,
            "payment 过期不应影响 default,default 应仍为 true"
        );
        assert!(!safe_payment_after, "payment 过期后 is_safe 应返回 false");
    }

    /// open_safe("default") 后手动删除 safe_services 中的 default 条目(模拟 close_safe),
    /// is_safe("default") 返回 Ok(false)。
    #[tokio::test]
    async fn t023_is_safe_returns_false_after_marker_removed() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-2005", &LoginParams::default())
            .await
            .unwrap();

        with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await.unwrap();
        })
        .await;

        // 删除 default 条目模拟 close_safe 效果
        let mut ts = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        ts.safe_services.remove("default");
        logic.session.save_token_session(&token, &ts).await.unwrap();

        let result =
            with_current_token(token.clone(), async { logic.is_safe("default").await }).await;

        assert!(
            !result.unwrap(),
            "删除 safe_services 标记后 is_safe 应返回 false"
        );
    }

    /// 不 login 直接调用 is_safe,返回 Ok(false)(不报错)。
    #[tokio::test]
    async fn t023_is_safe_returns_false_when_not_logged_in() {
        let (logic, _dao) = make_logic();
        let result = logic.is_safe("default").await;

        assert!(
            result.is_ok(),
            "未登录时 is_safe 应返回 Ok(false) 而非 Err,实际: {:?}",
            result
        );
        assert!(!result.unwrap(), "未登录时 is_safe 应返回 Ok(false)");
    }

    /// is_safe("") 返回 Err(InvalidParam) — service 参数不能为空。
    #[tokio::test]
    async fn t023_is_safe_empty_service_returns_err() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-2007", &LoginParams::default())
            .await
            .unwrap();

        let result = with_current_token(token, async { logic.is_safe("").await }).await;

        match result {
            Err(GarrisonError::InvalidParam(msg)) => {
                assert!(
                    msg.contains("service"),
                    "InvalidParam 错误消息应说明 service 参数问题,实际: {}",
                    msg
                );
            },
            other => panic!("期望 Err(InvalidParam),实际: {:?}", other),
        }
    }

    // close_safe 单元测试

    /// open_safe("default") 后 close_safe("default"),safe_services 中 default 条目被移除(len=0)。
    #[tokio::test]
    async fn t024_close_safe_removes_existing_marker() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-3001", &LoginParams::default())
            .await
            .unwrap();

        with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await.unwrap();
            logic.close_safe("default").await.unwrap();
        })
        .await;

        let ts = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        assert_eq!(
            ts.safe_services.len(),
            0,
            "close_safe 后 default 条目应被移除,safe_services 应为空,实际: {:?}",
            ts.safe_services
        );
        assert!(
            !ts.safe_services.contains_key("default"),
            "default 不应仍在 safe_services 中"
        );
    }

    /// 直接 close_safe("default")(未 open_safe),返回 Ok(()),safe_services 仍为空(幂等)。
    #[tokio::test]
    async fn t024_close_safe_nonexistent_marker_is_noop() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-3002", &LoginParams::default())
            .await
            .unwrap();

        let result =
            with_current_token(token.clone(), async { logic.close_safe("default").await }).await;

        assert!(
            result.is_ok(),
            "close_safe 不存在的标记应幂等返回 Ok(()),实际: {:?}",
            result
        );
        let ts = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        assert_eq!(
            ts.safe_services.len(),
            0,
            "未 open_safe 直接 close_safe 后 safe_services 应仍为空,实际: {:?}",
            ts.safe_services
        );
    }

    /// open_safe("default") 后 is_safe=true,close_safe("default") 后 is_safe=false。
    #[tokio::test]
    async fn t024_close_safe_then_is_safe_returns_false() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-3003", &LoginParams::default())
            .await
            .unwrap();

        let (before, after) = with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await.unwrap();
            let before = logic.is_safe("default").await.unwrap();
            logic.close_safe("default").await.unwrap();
            let after = logic.is_safe("default").await.unwrap();
            (before, after)
        })
        .await;

        assert!(before, "open_safe 后 is_safe 应返回 true");
        assert!(!after, "close_safe 后 is_safe 应返回 false");
    }

    /// open_safe("default") + open_safe("payment") 后 close_safe("default"),
    /// safe_services 中只剩 payment(default 被移除),is_safe("default")=false, is_safe("payment")=true。
    #[tokio::test]
    async fn t024_close_safe_only_removes_specified_service() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-3004", &LoginParams::default())
            .await
            .unwrap();

        with_current_token(token.clone(), async {
            logic.open_safe("default", 3600).await.unwrap();
            logic.open_safe("payment", 7200).await.unwrap();
            logic.close_safe("default").await.unwrap();
        })
        .await;

        let ts = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        assert_eq!(
            ts.safe_services.len(),
            1,
            "close_safe(default) 后应只剩 1 个 service 标记,实际: {:?}",
            ts.safe_services
        );
        assert!(
            !ts.safe_services.contains_key("default"),
            "default 应已被 close_safe 移除"
        );
        assert!(
            ts.safe_services.contains_key("payment"),
            "payment 应仍存在,未被 close_safe(default) 影响"
        );

        let (safe_default, safe_payment) = with_current_token(token.clone(), async {
            (
                logic.is_safe("default").await.unwrap(),
                logic.is_safe("payment").await.unwrap(),
            )
        })
        .await;
        assert!(
            !safe_default,
            "close_safe(default) 后 is_safe(default) 应返回 false"
        );
        assert!(
            safe_payment,
            "close_safe(default) 不应影响 payment,is_safe(payment) 应仍返回 true"
        );
    }

    /// close_safe("") 返回 Err(InvalidParam) — service 参数不能为空。
    #[tokio::test]
    async fn t024_close_safe_empty_service_returns_err() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-3005", &LoginParams::default())
            .await
            .unwrap();

        let result = with_current_token(token, async { logic.close_safe("").await }).await;

        match result {
            Err(GarrisonError::InvalidParam(msg)) => {
                assert!(
                    msg.contains("service"),
                    "InvalidParam 错误消息应说明 service 参数问题,实际: {}",
                    msg
                );
            },
            other => panic!("期望 Err(InvalidParam),实际: {:?}", other),
        }
    }

    // Feature gate 注册验证(编译测试)

    /// safe-auth 启用时 open_safe/is_safe/close_safe inherent methods 可访问且行为正确(验证 feature gate 配置与 Cargo feature 传递)。
    #[cfg(feature = "security-extra")]
    #[tokio::test]
    async fn t026_safe_auth_feature_compiles_when_enabled() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-t026-001", &LoginParams::default())
            .await
            .unwrap();

        with_current_token(token, async {
            logic.open_safe("default", 3600).await.unwrap();
            assert!(
                logic.is_safe("default").await.unwrap(),
                "open_safe 后 is_safe 应返回 true(inherent method 可访问)"
            );
            logic.close_safe("default").await.unwrap();
            assert!(
                !logic.is_safe("default").await.unwrap(),
                "close_safe 后 is_safe 应返回 false(inherent method 可访问)"
            );
        })
        .await;
    }

    /// full feature 隐含 safe-auth(Cargo.toml full 列表包含 "safe-auth"),验证依赖关系配置正确。
    #[cfg(all(feature = "full", feature = "security-extra"))]
    #[tokio::test]
    async fn t026_full_feature_includes_safe_auth() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-t026-003", &LoginParams::default())
            .await
            .unwrap();

        with_current_token(token, async {
            logic.open_safe("default", 3600).await.unwrap();
            assert!(
                logic.is_safe("default").await.unwrap(),
                "full feature 启用时 safe-auth 也启用,is_safe inherent method 应可访问"
            );
            logic.close_safe("default").await.unwrap();
        })
        .await;
    }

    // open_safe/close_safe 并发竞态测试

    /// SlowDao:在 `get` token session key 后插入延迟,放大 read-modify-write 窗口使并发竞态可靠复现(无锁时两个并发 `open_safe` 交错读旧 session,导致 lost update)。
    struct SlowDao {
        inner: Arc<MockDao>,
        delay: std::time::Duration,
    }

    #[async_trait]
    impl GarrisonDao for SlowDao {
        async fn get(&self, key: &str) -> GarrisonResult<Option<String>> {
            let result = self.inner.get(key).await;
            // 仅对 token:session:* key 插入延迟,放大 read-modify-write 窗口
            if key.starts_with("token:session:") {
                tokio::time::sleep(self.delay).await;
            }
            result
        }
        async fn set(&self, key: &str, value: &str, ttl_seconds: u64) -> GarrisonResult<()> {
            self.inner.set(key, value, ttl_seconds).await
        }
        async fn update(&self, key: &str, value: &str) -> GarrisonResult<()> {
            self.inner.update(key, value).await
        }
        async fn expire(&self, key: &str, seconds: u64) -> GarrisonResult<()> {
            self.inner.expire(key, seconds).await
        }
        async fn delete(&self, key: &str) -> GarrisonResult<()> {
            self.inner.delete(key).await
        }
        crate::atomic_test_fallback!();
    }

    /// 创建使用 SlowDao 的 GarrisonSession,放大 token session 读写延迟。
    fn make_slow_session(delay: std::time::Duration) -> (Arc<MockDao>, Arc<GarrisonSession>) {
        let inner = Arc::new(MockDao::new());
        let dao: Arc<dyn GarrisonDao> = Arc::new(SlowDao {
            inner: inner.clone(),
            delay,
        });
        let session = Arc::new(GarrisonSession::new(dao, 3600, 86400, 0));
        (inner, session)
    }

    /// 模拟 open_safe 的 read-modify-write(不依赖 task_local current_token,等价于 open_safe 核心逻辑)。
    async fn simulate_open_safe(
        session: &GarrisonSession,
        token: &str,
        service: &str,
        duration_secs: u64,
    ) -> GarrisonResult<()> {
        let service = service.to_string();
        session
            .with_token_session_lock(token, async {
                let mut ts = session.get_token_session(token).await?.ok_or_else(|| {
                    GarrisonError::InvalidToken(format!("stp-token-not-found::{}", token))
                })?;
                let now = chrono::Utc::now().timestamp();
                let expire_at = now + duration_secs as i64;
                ts.safe_services.insert(service.clone(), expire_at);
                session.save_token_session(token, &ts).await
            })
            .await
    }

    /// 模拟 close_safe 的 read-modify-write 操作(不依赖 task_local current_token)。
    async fn simulate_close_safe(
        session: &GarrisonSession,
        token: &str,
        service: &str,
    ) -> GarrisonResult<()> {
        let service = service.to_string();
        session
            .with_token_session_lock(token, async {
                let mut ts = session.get_token_session(token).await?.ok_or_else(|| {
                    GarrisonError::InvalidToken(format!("stp-token-not-found::{}", token))
                })?;
                ts.safe_services.remove(&service);
                session.save_token_session(token, &ts).await
            })
            .await
    }

    /// 两个并发 `open_safe` 不同 service,safe_services 应完整保留两个(per-token 锁串行化 read-modify-write,防 lost update)。
    #[tokio::test(flavor = "multi_thread", worker_threads = 4)]
    async fn crit001_concurrent_open_safe_different_services_no_lost_update() {
        let (_dao, session) = make_slow_session(std::time::Duration::from_millis(50));
        session.create("user-crit001-001", "T1").await.unwrap();

        let (r1, r2) = tokio::join!(
            simulate_open_safe(&session, "T1", "default", 3600),
            simulate_open_safe(&session, "T1", "payment", 7200),
        );
        r1.expect("open_safe default 应成功");
        r2.expect("open_safe payment 应成功");

        let ts = session.get_token_session("T1").await.unwrap().unwrap();
        assert_eq!(
            ts.safe_services.len(),
            2,
            "并发 open_safe 后 safe_services 应包含 2 个 service(修复前 lost update 导致只剩 1 个),实际: {:?}",
            ts.safe_services
        );
        assert!(
            ts.safe_services.contains_key("default"),
            "default 应在 safe_services 中,实际: {:?}",
            ts.safe_services
        );
        assert!(
            ts.safe_services.contains_key("payment"),
            "payment 应在 safe_services 中,实际: {:?}",
            ts.safe_services
        );
    }

    /// 两个并发 `close_safe` 不同 service,safe_services 应清空(per-token 锁串行化,防已关闭 service 被恢复)。
    #[tokio::test(flavor = "multi_thread", worker_threads = 4)]
    async fn crit001_concurrent_close_safe_different_services_no_lost_update() {
        let (_dao, session) = make_slow_session(std::time::Duration::from_millis(50));
        session.create("user-crit001-002", "T1").await.unwrap();

        simulate_open_safe(&session, "T1", "default", 3600)
            .await
            .unwrap();
        simulate_open_safe(&session, "T1", "payment", 7200)
            .await
            .unwrap();

        let ts = session.get_token_session("T1").await.unwrap().unwrap();
        assert_eq!(ts.safe_services.len(), 2, "前置条件:应有 2 个 service");

        let (r1, r2) = tokio::join!(
            simulate_close_safe(&session, "T1", "default"),
            simulate_close_safe(&session, "T1", "payment"),
        );
        r1.expect("close_safe default 应成功");
        r2.expect("close_safe payment 应成功");

        let ts = session.get_token_session("T1").await.unwrap().unwrap();
        assert_eq!(
            ts.safe_services.len(),
            0,
            "并发 close_safe 后 safe_services 应为空(修复前 lost update 导致残留 1 个),实际: {:?}",
            ts.safe_services
        );
    }

    /// 惰性清理过期条目:写入过期条目 → 调用 is_safe → 返回 false 且条目已删除。
    #[tokio::test]
    async fn t023_is_safe_lazy_removes_expired_entry() {
        let (logic, _dao) = make_logic();
        let token = logic
            .login("user-lazy-001", &LoginParams::default())
            .await
            .unwrap();

        let now = chrono::Utc::now().timestamp();
        let mut ts = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        ts.safe_services
            .insert("expired-service".to_string(), now - 3600);
        ts.safe_services
            .insert("valid-service".to_string(), now + 3600);
        logic.session.save_token_session(&token, &ts).await.unwrap();

        let result = with_current_token(token.clone(), async {
            logic.is_safe("expired-service").await.unwrap()
        })
        .await;
        assert!(!result, "过期条目 is_safe 应返回 false");

        let ts_after = logic
            .session
            .get_token_session(&token)
            .await
            .unwrap()
            .unwrap();
        assert!(
            !ts_after.safe_services.contains_key("expired-service"),
            "过期条目应被惰性删除,实际: {:?}",
            ts_after.safe_services
        );
        assert!(
            ts_after.safe_services.contains_key("valid-service"),
            "未过期条目不应被删除"
        );
    }
}