use std::sync::Arc;
use actix_web::dev::Payload;
use actix_web::error::QueryPayloadError;
use actix_web::{Error, FromRequest, HttpRequest, web};
use derive_more::{AsRef, Deref, DerefMut, Display, From};
use futures::future::{LocalBoxFuture, Ready, err, ok};
use futures::{FutureExt, StreamExt};
use garde::Validate;
use serde::de::DeserializeOwned;
use serde_qs::Config;
use crate::validate_for_request;
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Deref, DerefMut, AsRef, Display, From)]
pub struct QsQuery<T>(pub T);
impl<T> QsQuery<T> {
pub fn into_inner(self) -> T {
self.0
}
}
impl<T: DeserializeOwned> QsQuery<T> {
pub fn from_query(query_str: &str) -> Result<Self, QueryPayloadError> {
serde_urlencoded::from_str::<T>(query_str)
.map(Self)
.map_err(QueryPayloadError::Deserialize)
}
}
impl<T> FromRequest for QsQuery<T>
where
T: DeserializeOwned + Validate + 'static,
T::Context: Default,
{
type Error = Error;
type Future = Ready<Result<Self, Error>>;
#[inline]
fn from_request(req: &HttpRequest, _: &mut Payload) -> Self::Future {
let req_copy = req.clone();
let qs_config = req.app_data::<QsQueryConfig>();
let error_handler = qs_config.and_then(|c| c.err_handler.clone());
let default_qs_config = Config::default();
let qs_config = qs_config.map(|config| &config.qs_config).unwrap_or(&default_qs_config);
qs_config
.deserialize_str::<T>(req.query_string())
.map_err(Into::into)
.and_then(|data: T| {
let req = req_copy;
validate_for_request(data, &req)
})
.map(|val| ok(QsQuery(val)))
.unwrap_or_else(move |e| {
log::debug!(
"Failed during Query extractor deserialization. \
Request path: {:?}",
req.path()
);
let e = if let Some(error_handler) = error_handler {
(error_handler)(e, req)
} else {
e.into()
};
err(e)
})
}
}
#[derive(PartialEq, Eq, PartialOrd, Ord, Debug, Deref, DerefMut, AsRef, Display, From)]
pub struct QsForm<T>(T);
impl<T> QsForm<T> {
pub fn into_inner(self) -> T {
self.0
}
}
impl<T> FromRequest for QsForm<T>
where
T: DeserializeOwned + Validate + 'static,
T::Context: Default,
{
type Error = Error;
type Future = LocalBoxFuture<'static, Result<Self, Self::Error>>;
fn from_request(req: &HttpRequest, payload: &mut Payload) -> Self::Future {
let mut stream = payload.take();
let req_copy = req.clone();
let req_copy2 = req.clone();
let query_config: QsQueryConfig = req
.app_data::<QsQueryConfig>()
.cloned()
.unwrap_or_else(QsQueryConfig::default)
.clone();
async move {
let mut bytes = web::BytesMut::new();
while let Some(item) = stream.next().await {
bytes.extend_from_slice(&item?);
}
query_config
.qs_config
.deserialize_bytes::<T>(&bytes)
.map_err(Into::into)
.and_then(|data: T| {
let req = req_copy;
validate_for_request(data, &req)
})
.map(|val| Ok(QsForm(val)))
.unwrap_or_else(|e| {
let e = if let Some(error_handler) = &query_config.err_handler {
(error_handler)(e, &req_copy2)
} else {
e.into()
};
Err(e)
})
}
.boxed_local()
}
}
type ActixErrorHandler = Option<Arc<dyn Fn(crate::error::Error, &HttpRequest) -> Error + Send + Sync>>;
#[derive(Clone, Default)]
pub struct QsQueryConfig {
err_handler: ActixErrorHandler,
qs_config: Config,
}
impl QsQueryConfig {
pub fn error_handler<F>(mut self, f: F) -> Self
where
F: Fn(crate::error::Error, &HttpRequest) -> Error + Send + Sync + 'static,
{
self.err_handler = Some(Arc::new(f));
self
}
pub fn qs_config(mut self, config: Config) -> Self {
self.qs_config = config;
self
}
}
#[cfg(test)]
mod test {
use actix_http::StatusCode;
use actix_web::error::InternalError;
use actix_web::test::{TestRequest, call_service, init_service};
use actix_web::web::{post, resource};
use actix_web::{App, HttpResponse};
use garde::Validate;
use serde::{Deserialize, Serialize};
use crate::web::{Form, FormConfig, QsQuery, QsQueryConfig};
#[derive(Debug, PartialEq, Validate, Serialize, Deserialize)]
struct QueryData {
#[garde(range(min = 18, max = 28))]
age: u8,
}
#[derive(Debug, PartialEq, Validate, Serialize, Deserialize)]
#[garde(context(NumberContext))]
struct QueryDataWithContext {
#[garde(custom(is_big_enough))]
age: u8,
}
#[derive(Debug, PartialEq, Validate, Serialize, Deserialize)]
struct FormData {
#[garde(range(min = 18, max = 28))]
age: u8,
}
#[derive(Debug, PartialEq, Validate, Serialize, Deserialize)]
#[garde(context(NumberContext))]
struct FormDataWithContext {
#[garde(custom(is_big_enough))]
age: u8,
}
#[derive(Default, Debug)]
struct NumberContext {
min: u8,
}
fn is_big_enough(value: &u8, context: &NumberContext) -> garde::Result {
if value < &context.min {
return Err(garde::Error::new("Number is too low"));
}
Ok(())
}
async fn test_handler(_: QsQuery<QueryData>) -> HttpResponse {
HttpResponse::Ok().finish()
}
async fn test_form_handler(_: Form<FormData>) -> HttpResponse {
HttpResponse::Ok().finish()
}
async fn test_handler_with_context(_: QsQuery<QueryDataWithContext>) -> HttpResponse {
HttpResponse::Ok().finish()
}
async fn test_form_handler_with_context(_: Form<FormDataWithContext>) -> HttpResponse {
HttpResponse::Ok().finish()
}
#[tokio::test]
async fn test_simple_validation() {
let app = init_service(App::new().service(resource("/").route(post().to(test_handler)))).await;
let req = TestRequest::post().uri("/?age=24").to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
let req = TestRequest::post().uri("/?age=30").to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::BAD_REQUEST);
}
#[tokio::test]
async fn test_validation_custom_config() {
let app = init_service(
App::new()
.app_data(
QsQueryConfig::default()
.error_handler(|err, _req| InternalError::from_response(err, HttpResponse::Conflict().finish()).into()),
)
.service(resource("/").route(post().to(test_handler))),
)
.await;
let req = TestRequest::post().uri("/?age=24").to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
let req = TestRequest::post().uri("/?age=30").to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::CONFLICT);
}
#[tokio::test]
async fn test_validation_with_context() {
let number_context = NumberContext { min: 25 };
let app = init_service(
App::new()
.app_data(number_context)
.service(resource("/").route(post().to(test_handler_with_context))),
)
.await;
let req = TestRequest::post().uri("/?age=24").to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::BAD_REQUEST);
let req = TestRequest::post().uri("/?age=30").to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
}
#[tokio::test]
async fn test_validation_with_missing_context() {
let app = init_service(App::new().service(resource("/").route(post().to(test_handler_with_context)))).await;
let req = TestRequest::post().uri("/?age=24").to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
let req = TestRequest::post().uri("/?age=30").to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
}
#[tokio::test]
async fn test_simple_form_validation() {
let app = init_service(App::new().service(resource("/").route(post().to(test_form_handler)))).await;
let req = TestRequest::post()
.uri("/")
.set_form(&FormData { age: 24 })
.to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
let req = TestRequest::post()
.uri("/")
.set_form(&FormData { age: 30 })
.to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::BAD_REQUEST);
}
#[tokio::test]
async fn test_form_validation_custom_config() {
let app = init_service(
App::new()
.app_data(
FormConfig::default()
.error_handler(|err, _req| InternalError::from_response(err, HttpResponse::Conflict().finish()).into()),
)
.service(resource("/").route(post().to(test_form_handler))),
)
.await;
let req = TestRequest::post()
.uri("/")
.set_form(&FormData { age: 24 })
.to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
let req = TestRequest::post()
.uri("/")
.set_form(&FormData { age: 30 })
.to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::CONFLICT);
}
#[tokio::test]
async fn test_form_validation_with_context() {
let number_context = NumberContext { min: 25 };
let app = init_service(
App::new()
.app_data(number_context)
.service(resource("/").route(post().to(test_form_handler_with_context))),
)
.await;
let req = TestRequest::post()
.uri("/")
.set_form(&FormData { age: 24 })
.to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::BAD_REQUEST);
let req = TestRequest::post()
.uri("/")
.set_form(&FormData { age: 30 })
.to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
}
#[tokio::test]
async fn test_form_validation_with_missing_context() {
let app = init_service(App::new().service(resource("/").route(post().to(test_form_handler_with_context)))).await;
let req = TestRequest::post()
.uri("/")
.set_form(&FormData { age: 24 })
.to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
let req = TestRequest::post()
.uri("/")
.set_form(&FormData { age: 30 })
.to_request();
let resp = call_service(&app, req).await;
assert_eq!(resp.status(), StatusCode::OK);
}
}