fynd-core 0.55.0

Core solving logic for Fynd DEX router
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
//! Per-worker readiness tracking for derived data computations.
//!
//! Each worker maintains its own `ReadinessTracker` instance. The tracker is updated
//! when `DerivedDataEvent` messages are received, and queried before solving to
//! determine if required computations are ready.

use std::collections::HashSet;

use super::{
    computation::{ComputationId, ComputationRequirements},
    events::DerivedDataEvent,
};

/// Tracks which derived data computations are ready based on freshness requirements.
///
/// Workers use this to determine when they can safely acquire the `DerivedData`
/// lock and access computed data. The tracker handles two types of requirements:
///
/// - **Fresh requirements**: Must be computed for the current block
/// - **Stale requirements**: Can use data from any past block (just needs to exist)
///
/// TODO: Make staleness configurable by adding a max-block staleness param.
///
/// # Example
///
/// ```ignore
/// let requirements = ComputationRequirements::none()
///     .expect_fresh("spot_prices")?   // Must be current block
///     .expect_stale("token_prices")?; // Any block is fine (current design)
///
/// let mut tracker = ReadinessTracker::new(requirements);
///
/// // Process events from ComputationManager
/// tracker.handle_event(&DerivedDataEvent::NewBlock { block: 100 });
/// tracker.handle_event(&DerivedDataEvent::ComputationComplete {
///     computation_id: "spot_prices",
///     block: 100,
/// });
/// tracker.handle_event(&DerivedDataEvent::ComputationComplete {
///     computation_id: "token_prices",
///     block: 99, // stale is fine
/// });
///
/// // Check if ready to solve
/// if tracker.is_ready() {
///     // Safe to acquire DerivedData lock and solve
/// }
/// ```
#[derive(Debug)]
pub struct ReadinessTracker {
    /// Block number we're currently tracking readiness for (for fresh requirements).
    current_block: Option<u64>,
    /// Set of computation IDs that have completed for current block.
    ready_for_block: HashSet<ComputationId>,
    /// Set of computation IDs that have been computed at least once (any block).
    ever_computed: HashSet<ComputationId>,
    /// `require_fresh` computations that have permanently failed for the current block.
    ///
    /// Cleared on `NewBlock`. A computation in this set will never produce a
    /// `ComputationComplete` for the current block.
    failed_for_block: HashSet<ComputationId>,
    /// Requirements for this worker's algorithm.
    requirements: ComputationRequirements,
}

impl ReadinessTracker {
    /// Creates a new tracker with the given requirements.
    pub fn new(requirements: ComputationRequirements) -> Self {
        Self {
            current_block: None,
            ready_for_block: HashSet::new(),
            ever_computed: HashSet::new(),
            failed_for_block: HashSet::new(),
            requirements,
        }
    }

    /// Creates a tracker with no requirements (always ready).
    #[cfg(test)]
    pub fn no_requirements() -> Self {
        Self::new(ComputationRequirements::none())
    }

    /// Handles a derived data event, updating internal state.
    pub fn handle_event(&mut self, event: &DerivedDataEvent) {
        match event {
            DerivedDataEvent::NewBlock { block } => {
                self.on_new_block(*block);
            }
            DerivedDataEvent::ComputationComplete { computation_id, block, .. } => {
                self.on_computation_complete(computation_id, *block);
            }
            DerivedDataEvent::ComputationFailed { computation_id, block } => {
                self.on_computation_failed(computation_id, *block);
            }
        }
    }

    /// Handles a new block event, clearing per-block readiness state.
    fn on_new_block(&mut self, block: u64) {
        // Only reset if this is actually a new block
        if self
            .current_block
            .is_none_or(|b| block > b)
        {
            self.current_block = Some(block);
            self.ready_for_block.clear();
            self.failed_for_block.clear();
            // Note: ever_computed is NOT cleared - stale data persists
        }
    }

    /// Handles a computation failure event.
    ///
    /// Only tracks failures for `require_fresh` computations on the current block.
    /// `allow_stale` failures are ignored because stale data remains usable.
    fn on_computation_failed(&mut self, computation_id: ComputationId, block: u64) {
        if self
            .requirements
            .require_fresh
            .contains(computation_id) &&
            self.current_block
                .is_some_and(|b| block == b)
        {
            self.failed_for_block
                .insert(computation_id);
        }
    }

    /// Handles a computation completion event.
    fn on_computation_complete(&mut self, computation_id: ComputationId, block: u64) {
        // Always record in ever_computed (for stale requirements)
        self.ever_computed
            .insert(computation_id);

        // For fresh requirements, check block number
        // Ignore events for blocks older than current
        if self
            .current_block
            .is_some_and(|b| block < b)
        {
            return;
        }

        // If this is a newer block, reset per-block state first
        if self
            .current_block
            .is_none_or(|b| block > b)
        {
            self.on_new_block(block);
        }

        self.ready_for_block
            .insert(computation_id);
    }

    /// Returns true if any `require_fresh` computation has failed for the
    /// current block (i.e., it will never produce a `ComputationComplete` this block).
    ///
    /// Workers should return an error immediately rather than waiting for a timeout when
    /// this is true.
    pub fn is_blocked_for_current_block(&self) -> bool {
        self.requirements
            .require_fresh
            .iter()
            .any(|id| self.failed_for_block.contains(id))
    }

    /// Returns true if all requirements are satisfied:
    /// - All `require_fresh` computations are ready for the current block
    /// - All `allow_stale` computations have been computed at least once
    pub fn is_ready(&self) -> bool {
        let fresh_ready = self
            .requirements
            .require_fresh
            .iter()
            .all(|id| self.ready_for_block.contains(id));

        let stale_ready = self
            .requirements
            .allow_stale
            .iter()
            .all(|id| self.ever_computed.contains(id));

        fresh_ready && stale_ready
    }

    /// Returns true if the tracker has any requirements.
    pub fn has_requirements(&self) -> bool {
        self.requirements.has_requirements()
    }

    /// Returns the set of computations that are NOT yet ready.
    ///
    /// For fresh requirements: not ready for current block.
    /// For stale requirements: never computed.
    pub fn missing(&self) -> HashSet<ComputationId> {
        let missing_fresh: HashSet<_> = self
            .requirements
            .require_fresh
            .difference(&self.ready_for_block)
            .copied()
            .collect();

        let missing_stale: HashSet<_> = self
            .requirements
            .allow_stale
            .difference(&self.ever_computed)
            .copied()
            .collect();

        missing_fresh
            .union(&missing_stale)
            .copied()
            .collect()
    }

    /// Returns the current block being tracked.
    #[cfg(test)]
    pub fn current_block(&self) -> Option<u64> {
        self.current_block
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn fresh_requirements(ids: &[&'static str]) -> ComputationRequirements {
        ids.iter()
            .fold(ComputationRequirements::none(), |req, id| {
                req.require_fresh(id)
                    .expect("test ids should not conflict")
            })
    }

    fn stale_requirements(ids: &[&'static str]) -> ComputationRequirements {
        ids.iter()
            .fold(ComputationRequirements::none(), |req, id| {
                req.allow_stale(id)
                    .expect("test ids should not conflict")
            })
    }

    #[test]
    fn new_tracker_not_ready_with_fresh_requirements() {
        let tracker = ReadinessTracker::new(fresh_requirements(&["token_prices"]));

        assert!(!tracker.is_ready());
        assert!(tracker.has_requirements());
        assert_eq!(tracker.current_block(), None);
    }

    #[test]
    fn new_tracker_ready_without_requirements() {
        let tracker = ReadinessTracker::no_requirements();

        assert!(tracker.is_ready());
        assert!(!tracker.has_requirements());
    }

    #[test]
    fn fresh_requirement_needs_current_block() {
        let mut tracker = ReadinessTracker::new(fresh_requirements(&["spot_prices"]));

        // Complete for block 100
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "spot_prices",
            block: 100,
            failed_items: vec![],
        });
        assert!(tracker.is_ready());
        assert_eq!(tracker.current_block(), Some(100));

        // New block clears per-block ready set
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 101 });
        assert!(!tracker.is_ready()); // Not ready until computed for block 101
        assert_eq!(tracker.current_block(), Some(101));
    }

    #[test]
    fn fresh_requirement_ignores_old_blocks() {
        let mut tracker = ReadinessTracker::new(fresh_requirements(&["spot_prices"]));

        // Set current block to 100
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 100 });

        // Event for old block should NOT satisfy fresh requirement
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "spot_prices",
            block: 99,
            failed_items: vec![],
        });

        assert!(!tracker.is_ready());
    }

    #[test]
    fn fresh_requirement_multiple_computations() {
        let mut tracker =
            ReadinessTracker::new(fresh_requirements(&["token_prices", "spot_prices"]));

        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "token_prices",
            block: 100,
            failed_items: vec![],
        });
        assert!(!tracker.is_ready()); // still missing spot_prices

        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "spot_prices",
            block: 100,
            failed_items: vec![],
        });
        assert!(tracker.is_ready());
    }

    #[test]
    fn fresh_requirement_newer_block_resets() {
        let mut tracker =
            ReadinessTracker::new(fresh_requirements(&["token_prices", "spot_prices"]));

        // Complete token_prices for block 100
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "token_prices",
            block: 100,
            failed_items: vec![],
        });

        // Complete spot_prices for block 101 (newer block)
        // This should clear token_prices from per-block ready set
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "spot_prices",
            block: 101,
            failed_items: vec![],
        });

        assert!(!tracker.is_ready()); // token_prices not ready for block 101
        assert_eq!(tracker.current_block(), Some(101));
        assert!(tracker
            .ready_for_block
            .contains(&"spot_prices"));
        assert!(!tracker
            .ready_for_block
            .contains(&"token_prices"));
    }

    #[test]
    fn new_tracker_not_ready_with_stale_requirements() {
        let tracker = ReadinessTracker::new(stale_requirements(&["token_prices"]));

        assert!(!tracker.is_ready());
        assert!(tracker.has_requirements());
    }

    #[test]
    fn stale_requirement_accepts_any_block() {
        let mut tracker = ReadinessTracker::new(stale_requirements(&["token_prices"]));

        // Complete for block 100
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "token_prices",
            block: 100,
            failed_items: vec![],
        });
        assert!(tracker.is_ready());

        // New block does NOT clear stale readiness
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 101 });
        assert!(tracker.is_ready()); // Still ready - stale data persists
    }

    #[test]
    fn stale_requirement_accepts_old_blocks() {
        let mut tracker = ReadinessTracker::new(stale_requirements(&["token_prices"]));

        // Set current block to 100
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 100 });

        // Event for old block SHOULD satisfy stale requirement
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "token_prices",
            block: 99,
            failed_items: vec![],
        });

        assert!(tracker.is_ready()); // Old block is fine for stale
    }

    #[test]
    fn stale_requirement_persists_across_blocks() {
        let mut tracker = ReadinessTracker::new(stale_requirements(&["token_prices"]));

        // Complete for block 100
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "token_prices",
            block: 100,
            failed_items: vec![],
        });
        assert!(tracker.is_ready());

        // Move through several blocks
        for block in 101..=110 {
            tracker.handle_event(&DerivedDataEvent::NewBlock { block });
            assert!(tracker.is_ready()); // Still ready
        }

        // ever_computed should still contain token_prices
        assert!(tracker
            .ever_computed
            .contains(&"token_prices"));
    }

    #[test]
    fn mixed_fresh_and_stale_requirements() {
        let requirements = ComputationRequirements::none()
            .require_fresh("spot_prices") // Must be current block
            .unwrap()
            .allow_stale("token_prices") // Any block is fine
            .unwrap();

        let mut tracker = ReadinessTracker::new(requirements);

        // Complete token_prices for block 100
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "token_prices",
            block: 100,
            failed_items: vec![],
        });
        assert!(!tracker.is_ready()); // Missing fresh spot_prices

        // Complete spot_prices for block 100
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "spot_prices",
            block: 100,
            failed_items: vec![],
        });
        assert!(tracker.is_ready());

        // New block - spot_prices needs refresh, token_prices stays ready
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 101 });
        assert!(!tracker.is_ready()); // spot_prices not ready for 101

        // Refresh spot_prices for block 101
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "spot_prices",
            block: 101,
            failed_items: vec![],
        });
        assert!(tracker.is_ready()); // Both satisfied again
    }

    #[test]
    fn test_fresh_failure_blocks_current_block() {
        let mut tracker = ReadinessTracker::new(fresh_requirements(&["spot_prices"]));
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 100 });

        tracker.handle_event(&DerivedDataEvent::ComputationFailed {
            computation_id: "spot_prices",
            block: 100,
        });

        assert!(tracker.is_blocked_for_current_block());
    }

    #[test]
    fn test_stale_failure_is_ignored() {
        let mut tracker = ReadinessTracker::new(stale_requirements(&["token_prices"]));
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 100 });

        tracker.handle_event(&DerivedDataEvent::ComputationFailed {
            computation_id: "token_prices",
            block: 100,
        });

        // allow_stale failures are ignored — stale data remains usable
        assert!(!tracker.is_blocked_for_current_block());
    }

    #[test]
    fn test_failure_cleared_on_new_block() {
        let mut tracker = ReadinessTracker::new(fresh_requirements(&["spot_prices"]));
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 100 });
        tracker.handle_event(&DerivedDataEvent::ComputationFailed {
            computation_id: "spot_prices",
            block: 100,
        });
        assert!(tracker.is_blocked_for_current_block());

        // New block clears the failure set
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 101 });
        assert!(!tracker.is_blocked_for_current_block());
    }

    #[test]
    fn test_old_block_failure_does_not_block() {
        let mut tracker = ReadinessTracker::new(fresh_requirements(&["spot_prices"]));
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 100 });

        // Failure event for block 99 (old) should not affect current block 100
        tracker.handle_event(&DerivedDataEvent::ComputationFailed {
            computation_id: "spot_prices",
            block: 99,
        });

        assert!(!tracker.is_blocked_for_current_block());
    }

    #[test]
    fn test_failure_recovers_on_next_block() {
        let mut tracker = ReadinessTracker::new(fresh_requirements(&["spot_prices"]));

        // Block 100: failure
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 100 });
        tracker.handle_event(&DerivedDataEvent::ComputationFailed {
            computation_id: "spot_prices",
            block: 100,
        });
        assert!(tracker.is_blocked_for_current_block());
        assert!(!tracker.is_ready());

        // Block 101: success
        tracker.handle_event(&DerivedDataEvent::NewBlock { block: 101 });
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "spot_prices",
            block: 101,
            failed_items: vec![],
        });

        assert!(!tracker.is_blocked_for_current_block());
        assert!(tracker.is_ready());
    }

    #[test]
    fn missing_returns_unready_set() {
        let requirements = ComputationRequirements::none()
            .require_fresh("spot_prices")
            .unwrap()
            .allow_stale("token_prices")
            .unwrap();

        let mut tracker = ReadinessTracker::new(requirements);

        let missing = tracker.missing();
        assert_eq!(missing.len(), 2);
        assert!(missing.contains(&"spot_prices"));
        assert!(missing.contains(&"token_prices"));

        // Complete token_prices (stale)
        tracker.handle_event(&DerivedDataEvent::ComputationComplete {
            computation_id: "token_prices",
            block: 100,
            failed_items: vec![],
        });

        let missing = tracker.missing();
        assert_eq!(missing.len(), 1);
        assert!(missing.contains(&"spot_prices"));
        assert!(!missing.contains(&"token_prices"));
    }
}