fux 0.8.0

Minimal persistent terminal multiplexer built on bevy_ecs
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
//! Socket-facing tasks: attachment viewers, control clients and the manager socket. Each task
//! forwards typed inbound events to the owner loop and writes replies/frames it is handed.

use super::adapter::{Subscriber, ViewerOutbox};
use crate::ecs::{Inbound, ManagerAction, ManagerOutcome, ViewerRequest};
use crate::ids::ViewerId;
use crate::proto::attach::{
    ClientMessage, FRAME_TIMEOUT, MAX_CLIENT_FRAME, MAX_INPUT_CHUNK, MAX_SERVER_FRAME,
    ServerMessage, read_frame, write_frame,
};
use crate::proto::control::{
    self, CONTROL_PREFACE, ErrorCode, MAX_FRAME_BYTES, MAX_SUBSCRIBER_QUEUE, Reply, Request,
};
use std::sync::atomic::{AtomicU64, AtomicUsize, Ordering};
use std::sync::{Arc, Mutex};
use std::time::Duration;
use tokio::io::{AsyncBufReadExt, AsyncReadExt, AsyncWriteExt, BufReader};
use tokio::net::{UnixListener, UnixStream};
use tokio::sync::{Notify, mpsc, oneshot};
use tokio::task::JoinSet;

/// Shared by every accept loop: how to reach the owner and how to hand it reply channels.
#[derive(Clone)]
pub struct Owner {
    pub instance: String,
    pub inbound: mpsc::Sender<Inbound>,
    pub tokens: Arc<AtomicU64>,
    pub control_replies: mpsc::Sender<(u64, oneshot::Sender<Reply>)>,
    pub manager_replies: mpsc::Sender<(u64, oneshot::Sender<ManagerOutcome>)>,
    pub viewer_outboxes: mpsc::Sender<(ViewerId, ViewerOutbox)>,
    pub viewer_ids: Arc<AtomicU64>,
}

impl Owner {
    fn token(&self) -> u64 {
        self.tokens.fetch_add(1, Ordering::Relaxed)
    }
}

fn authenticate(stream: UnixStream) -> std::io::Result<UnixStream> {
    let stream = stream.into_std()?;
    crate::proto::socket::authorize_peer(&stream)?;
    UnixStream::from_std(stream)
}

/// Accepts authenticated connections until `stop` fires or the listener fails; each admitted
/// stream is served on its own task. Returns the tasks still running.
async fn accept_loop<F>(
    listener: UnixListener,
    stop: &Notify,
    admit: impl Fn(&JoinSet<()>) -> bool,
    mut serve: impl FnMut(UnixStream) -> F,
) -> JoinSet<()>
where
    F: Future<Output = ()> + Send + 'static,
{
    let mut tasks = JoinSet::new();
    loop {
        tokio::select! {
            () = stop.notified() => break,
            Some(_) = tasks.join_next(), if !tasks.is_empty() => {}
            accepted = listener.accept() => {
                let Ok((stream, _)) = accepted else { break };
                let Ok(stream) = authenticate(stream) else { continue };
                if !admit(&tasks) {
                    continue;
                }
                tasks.spawn(serve(stream));
            }
        }
    }
    tasks
}

async fn drain(mut tasks: JoinSet<()>) {
    tasks.abort_all();
    while tasks.join_next().await.is_some() {}
}

/// Accepts attachment connections for one workspace until `stop` fires.
pub async fn serve_attachments(
    listener: UnixListener,
    workspace: String,
    owner: Owner,
    stop: Arc<Notify>,
) {
    let active = Arc::new(AtomicUsize::new(0));
    let mut tasks = accept_loop(
        listener,
        &stop,
        |_| active.load(Ordering::Acquire) < crate::proto::attach::MAX_VIEWERS_PER_WORKSPACE,
        |stream| {
            active.fetch_add(1, Ordering::AcqRel);
            let active = Arc::clone(&active);
            let owner = owner.clone();
            let workspace = workspace.clone();
            async move {
                if let Err(error) = serve_viewer(stream, workspace, owner).await {
                    tracing::debug!(%error, "viewer connection ended");
                }
                active.fetch_sub(1, Ordering::AcqRel);
            }
        },
    )
    .await;
    // Viewers were told to exit; let their final frames flush before cutting the connections.
    let grace = tokio::time::sleep(Duration::from_secs(2));
    tokio::pin!(grace);
    while !tasks.is_empty() {
        tokio::select! {
            _ = tasks.join_next() => {}
            () = &mut grace => break,
        }
    }
    drain(tasks).await;
}

async fn serve_viewer(
    mut stream: UnixStream,
    workspace: String,
    owner: Owner,
) -> anyhow::Result<()> {
    let hello: ClientMessage =
        tokio::time::timeout(FRAME_TIMEOUT, read_frame(&mut stream, MAX_CLIENT_FRAME)).await??;
    let (rows, cols) = match hello {
        ClientMessage::Hello { rows, columns } => (rows, columns),
        _ => {
            write_frame(
                &mut stream,
                &ServerMessage::Error {
                    message: "the first attachment frame must be a hello".into(),
                },
                MAX_SERVER_FRAME,
            )
            .await?;
            anyhow::bail!("attachment did not start with a hello");
        }
    };
    write_frame(&mut stream, &ServerMessage::Hello {}, MAX_SERVER_FRAME).await?;
    let viewer = ViewerId(owner.viewer_ids.fetch_add(1, Ordering::Relaxed));
    let outbox = ViewerOutbox::default();
    owner.viewer_outboxes.send((viewer, outbox.clone())).await?;
    owner
        .inbound
        .send(Inbound::ViewerAttached {
            viewer,
            workspace,
            rows,
            cols,
        })
        .await?;
    let (mut reader, mut writer) = stream.into_split();
    let writer_outbox = outbox.clone();
    let mut writer_task = tokio::spawn(async move {
        while let Some(message) = writer_outbox.next().await {
            let exit = matches!(
                message,
                ServerMessage::Exited { .. } | ServerMessage::Error { .. }
            );
            if write_frame(&mut writer, &message, MAX_SERVER_FRAME)
                .await
                .is_err()
            {
                break;
            }
            if exit {
                break;
            }
        }
        let _ = writer.shutdown().await;
    });
    let inbound = owner.inbound.clone();
    let result = async {
        loop {
            let message: ClientMessage = read_frame(&mut reader, MAX_CLIENT_FRAME).await?;
            let request = match message {
                ClientMessage::Input { bytes } => {
                    anyhow::ensure!(bytes.len() <= MAX_INPUT_CHUNK, "oversized input chunk");
                    ViewerRequest::Input(bytes)
                }
                ClientMessage::Mouse { event, generation } => {
                    anyhow::ensure!(event.column > 0 && event.row > 0, "invalid mouse report");
                    ViewerRequest::Mouse { event, generation }
                }
                ClientMessage::Control { request } => ViewerRequest::Control(request),
                ClientMessage::View {
                    request,
                    pane,
                    offset,
                } => ViewerRequest::View {
                    request,
                    pane,
                    offset,
                },
                ClientMessage::Resize { rows, columns } => ViewerRequest::Resize {
                    rows,
                    cols: columns,
                },
                ClientMessage::Detach => {
                    inbound
                        .send(Inbound::ViewerRequest {
                            viewer,
                            request: ViewerRequest::Detach,
                        })
                        .await?;
                    // The owner answers with `exited`; the writer task ends after sending it.
                    return Ok::<(), anyhow::Error>(());
                }
                ClientMessage::Hello { .. } => anyhow::bail!("duplicate hello"),
            };
            inbound
                .send(Inbound::ViewerRequest { viewer, request })
                .await?;
        }
    };
    let outcome = tokio::select! {
        result = result => result,
        _ = &mut writer_task => Ok(()),
    };
    // Detach: wait for the exit frame to flush; otherwise the peer vanished.
    let detached = outcome.is_ok();
    if detached {
        let _ = tokio::time::timeout(FRAME_TIMEOUT, &mut writer_task).await;
    }
    writer_task.abort();
    let _ = owner.inbound.send(Inbound::ViewerGone { viewer }).await;
    outbox.close();
    outcome
}

/// Accepts control connections for one workspace until `stop` fires.
pub async fn serve_control(
    listener: UnixListener,
    workspace: String,
    owner: Owner,
    subscribers: Arc<Mutex<Vec<Subscriber>>>,
    stop: Arc<Notify>,
) {
    let tasks = accept_loop(
        listener,
        &stop,
        |tasks| tasks.len() < control::MAX_CONTROL_CONNECTIONS,
        |stream| {
            let owner = owner.clone();
            let workspace = workspace.clone();
            let subscribers = Arc::clone(&subscribers);
            async move {
                if let Err(error) =
                    serve_control_connection(stream, workspace, owner, subscribers).await
                {
                    tracing::debug!(%error, "control connection ended");
                }
            }
        },
    )
    .await;
    drain(tasks).await;
}

/// Preface exchange with a two-second absolute deadline including idle time.
pub async fn negotiate(stream: &mut UnixStream) -> anyhow::Result<()> {
    tokio::time::timeout(Duration::from_secs(2), async {
        let mut preface = [0_u8; CONTROL_PREFACE.len()];
        stream.read_exact(&mut preface).await?;
        stream.write_all(CONTROL_PREFACE).await?;
        anyhow::ensure!(&preface == CONTROL_PREFACE, "not a fux control preface");
        Ok(())
    })
    .await
    .map_err(|_| anyhow::anyhow!("control negotiation timed out"))?
}

async fn read_line(
    reader: &mut BufReader<tokio::net::unix::OwnedReadHalf>,
) -> anyhow::Result<Option<Vec<u8>>> {
    let mut line = Vec::new();
    let limit = MAX_FRAME_BYTES + 1;
    let count = tokio::time::timeout(Duration::from_secs(30), async {
        (&mut *reader)
            .take(limit as u64)
            .read_until(b'\n', &mut line)
            .await
    })
    .await
    .map_err(|_| anyhow::anyhow!("control frame stalled"))??;
    if count == 0 {
        return Ok(None);
    }
    if line.last() == Some(&b'\n') {
        line.pop();
    } else if line.len() > MAX_FRAME_BYTES {
        anyhow::bail!("control frame exceeds limit");
    }
    Ok(Some(line))
}

async fn serve_control_connection(
    mut stream: UnixStream,
    workspace: String,
    owner: Owner,
    subscribers: Arc<Mutex<Vec<Subscriber>>>,
) -> anyhow::Result<()> {
    negotiate(&mut stream).await?;
    let (reader, mut writer) = stream.into_split();
    let mut reader = BufReader::new(reader);
    while let Some(line) = read_line(&mut reader).await? {
        let request = match control::decode_request_frame(&line) {
            Ok(request) => request,
            Err(error) => {
                write_line(&mut writer, &control::error_reply(&error)).await?;
                continue;
            }
        };
        if request
            .instance()
            .is_some_and(|instance| instance != owner.instance)
        {
            write_line(
                &mut writer,
                &Reply::failed(
                    request.id(),
                    control::ErrorCode::Conflict,
                    "server instance changed; rediscover before retrying",
                ),
            )
            .await?;
            continue;
        }
        if let Request::Subscribe {
            id, events, after, ..
        } = request
        {
            let (sender, mut receiver) = mpsc::channel(MAX_SUBSCRIBER_QUEUE);
            {
                let mut active = subscribers
                    .lock()
                    .unwrap_or_else(std::sync::PoisonError::into_inner);
                active.retain(|subscriber| !subscriber.sender.is_closed());
                active.push(Subscriber {
                    filters: events.clone(),
                    sender,
                    bytes: Arc::new(AtomicUsize::new(0)),
                });
            }
            // Register first, then replay through the authoritative ECS boundary. Events that
            // race this read are either in the replay or in the queue (possibly both).
            let mut boundary = after;
            let mut replay = Vec::new();
            if let Some(after) = after {
                let reply = dispatch_control(
                    &owner,
                    &workspace,
                    Request::Events {
                        id,
                        instance: Some(owner.instance.clone()),
                        after,
                    },
                )
                .await?;
                match reply {
                    Reply::Completed {
                        result:
                            control::CommandResult::Events {
                                cursor,
                                events: entries,
                            },
                        ..
                    } => {
                        boundary = Some(cursor);
                        replay = entries;
                    }
                    other => {
                        write_line(&mut writer, &bounded(other)).await?;
                        return Ok(());
                    }
                }
            }
            write_line(&mut writer, &Reply::Accepted { id }).await?;
            for entry in replay {
                if events.is_empty() || events.contains(&entry.event.kind()) {
                    write_event(&mut writer, entry, id).await?;
                }
            }
            let mut probe = [0_u8; 1];
            loop {
                tokio::select! {
                    event = receiver.recv() => {
                        let Some(event) = event else { break };
                        if boundary.is_some_and(|cursor| cursor.stream == event.entry.cursor.stream
                            && event.entry.cursor.sequence <= cursor.sequence) {
                            continue;
                        }
                        write_event(&mut writer, (*event.entry).clone(), id).await?;
                    }
                    read = reader.read(&mut probe) => {
                        // Any further byte or EOF ends the subscription.
                        let _ = read;
                        break;
                    }
                }
            }
            return Ok(());
        }
        let reply = dispatch_control(&owner, &workspace, request).await?;
        write_line(&mut writer, &bounded(reply)).await?;
    }
    Ok(())
}

async fn dispatch_control(
    owner: &Owner,
    workspace: &str,
    request: Request,
) -> anyhow::Result<Reply> {
    let request_id = request.id();
    // A `wait` replies only when its condition or its own timeout fires, so the reply window
    // must outlast the requested timeout; every other request keeps the fixed 30 s answer cap.
    let answer_window = match &request {
        Request::Wait { timeout_ms, .. } => {
            Duration::from_millis(*timeout_ms).saturating_add(Duration::from_secs(5))
        }
        _ => Duration::from_secs(30),
    };
    let token = owner.token();
    let (sender, receiver) = oneshot::channel();
    owner.control_replies.send((token, sender)).await?;
    owner
        .inbound
        .send(Inbound::ControlRequest {
            workspace: workspace.to_owned(),
            request,
            token,
        })
        .await?;
    let reply = match tokio::time::timeout(answer_window, receiver).await {
        Ok(Ok(reply)) => reply,
        _ => Reply::failed(
            request_id,
            ErrorCode::Internal,
            "control request was not answered",
        ),
    };

    Ok(reply)
}

async fn write_event(
    writer: &mut tokio::net::unix::OwnedWriteHalf,
    mut event: control::SequencedEvent,
    id: u64,
) -> anyhow::Result<()> {
    event.event = event.event.with_id(id);
    let mut bytes = serde_json::to_vec(&event)?;
    anyhow::ensure!(bytes.len() <= MAX_FRAME_BYTES, "event exceeds frame limit");
    bytes.push(b'\n');
    tokio::time::timeout(FRAME_TIMEOUT, writer.write_all(&bytes)).await??;
    Ok(())
}

fn bounded(reply: Reply) -> Reply {
    if serde_json::to_vec(&reply).is_ok_and(|bytes| bytes.len() <= MAX_FRAME_BYTES) {
        reply
    } else {
        Reply::failed(
            reply.id(),
            ErrorCode::FrameTooLarge,
            "control response exceeds the 1 MiB frame limit",
        )
    }
}

/// Writes one newline-delimited JSON frame within the frame timeout.
async fn write_line<T: serde::Serialize>(
    writer: &mut tokio::net::unix::OwnedWriteHalf,
    value: &T,
) -> anyhow::Result<()> {
    let mut bytes = serde_json::to_vec(value)?;
    bytes.push(b'\n');
    tokio::time::timeout(FRAME_TIMEOUT, writer.write_all(&bytes)).await??;
    Ok(())
}

/// Serves the manager socket: one negotiated request per connection.
pub async fn serve_manager(listener: UnixListener, owner: Owner, stop: Arc<Notify>) {
    let tasks = accept_loop(
        listener,
        &stop,
        |tasks| tasks.len() < 64,
        |stream| {
            let owner = owner.clone();
            async move {
                if let Err(error) = serve_manager_connection(stream, owner).await {
                    tracing::debug!(%error, "manager connection ended");
                }
            }
        },
    )
    .await;
    drain(tasks).await;
}

/// Answers one manager request. The descriptor for an attach reply is built by the caller-side
/// hook so the manager task never touches the World.
pub type DescriptorHook = Arc<dyn Fn(&str, u64) -> Option<crate::daemon::Descriptor> + Send + Sync>;

async fn serve_manager_connection(mut stream: UnixStream, owner: Owner) -> anyhow::Result<()> {
    negotiate(&mut stream).await?;
    let (reader, mut writer) = stream.into_split();
    let mut reader = BufReader::new(reader);
    let Some(line) = read_line(&mut reader).await? else {
        return Ok(());
    };
    let request: crate::daemon::ManagerRequest = match serde_json::from_slice(&line) {
        Ok(request) => request,
        Err(error) => {
            let reply = crate::daemon::ManagerReply::Failed {
                message: format!("invalid manager request: {error}"),
            };
            return write_line(&mut writer, &reply).await;
        }
    };
    let action = match request {
        crate::daemon::ManagerRequest::Final { instance, pane } => {
            ManagerAction::Final { instance, pane }
        }
        crate::daemon::ManagerRequest::Create { name } => ManagerAction::Create { name },
        crate::daemon::ManagerRequest::List => ManagerAction::List,
        crate::daemon::ManagerRequest::Info => ManagerAction::Info,
        crate::daemon::ManagerRequest::Resolve { name } => ManagerAction::Resolve { name },
        crate::daemon::ManagerRequest::Kill { name } => ManagerAction::Kill { name },
    };
    if let ManagerAction::Resolve { name: Some(name) }
    | ManagerAction::Kill { name }
    | ManagerAction::Create { name } = &action
        && let Err(error) = crate::ids::validate_workspace_name(name)
    {
        let reply = crate::daemon::ManagerReply::Failed {
            message: error.to_string(),
        };
        return write_line(&mut writer, &reply).await;
    }
    let token = owner.token();
    let (sender, receiver) = oneshot::channel();
    owner.manager_replies.send((token, sender)).await?;
    owner
        .inbound
        .send(Inbound::Manager { action, token })
        .await?;
    let outcome = match tokio::time::timeout(crate::daemon::MANAGER_DEADLINE, receiver).await {
        Ok(Ok(outcome)) => outcome,
        _ => ManagerOutcome::Failed("manager request was not answered".into()),
    };
    let reply = match outcome {
        ManagerOutcome::Final(result) => crate::daemon::ManagerReply::Final { result },
        ManagerOutcome::Names(names) => crate::daemon::ManagerReply::Names { names },
        ManagerOutcome::Info(info) => crate::daemon::ManagerReply::Info { info },
        ManagerOutcome::Failed(message) => crate::daemon::ManagerReply::Failed { message },
        ManagerOutcome::Attach { name, stream, .. } => match (DESCRIPTOR_HOOK.get())(&name, stream)
        {
            Some(descriptor) => crate::daemon::ManagerReply::Attach { descriptor },
            None => crate::daemon::ManagerReply::Failed {
                message: "workspace descriptor unavailable".into(),
            },
        },
    };
    write_line(&mut writer, &reply).await
}

/// Process-wide descriptor lookup installed by the server before serving the manager socket.
pub struct DescriptorLookup(std::sync::OnceLock<DescriptorHook>);

impl DescriptorLookup {
    pub fn install(&self, hook: DescriptorHook) {
        let _ = self.0.set(hook);
    }
    fn get(&self) -> DescriptorHook {
        self.0
            .get()
            .cloned()
            .unwrap_or_else(|| Arc::new(|_, _| None))
    }
}

pub static DESCRIPTOR_HOOK: DescriptorLookup = DescriptorLookup(std::sync::OnceLock::new());

#[cfg(test)]
mod tests {
    use super::*;

    #[tokio::test]
    async fn subscription_replay_deduplicates_queued_overlap_and_filters_both_sides()
    -> anyhow::Result<()> {
        use control::{CommandResult, Event, EventCursor, EventKind, SequencedEvent};
        tokio::time::timeout(Duration::from_secs(5), async {
            let (server, mut client) = UnixStream::pair()?;
            let (inbound, mut inbound_rx) = mpsc::channel(1);
            let (control_replies, mut control_rx) = mpsc::channel(1);
            let (manager_replies, _manager_rx) = mpsc::channel(1);
            let (viewer_outboxes, _viewer_rx) = mpsc::channel(1);
            let owner = Owner {
                instance: "current-server".into(), inbound,
                tokens: Arc::new(AtomicU64::new(1)), control_replies,
                manager_replies, viewer_outboxes,
                viewer_ids: Arc::new(AtomicU64::new(1)),
            };
            let subscribers = Arc::new(Mutex::new(Vec::new()));
            let serving = tokio::spawn(serve_control_connection(server, "default".into(), owner, subscribers.clone()));
            client.write_all(CONTROL_PREFACE).await?;
            let mut preface = [0; CONTROL_PREFACE.len()];
            client.read_exact(&mut preface).await?;
            let (client, mut writer) = client.into_split();
            let mut client = BufReader::new(client);
            let cursor = |sequence| EventCursor { stream: 7, sequence };
            write_line(&mut writer, &Request::Subscribe {
                id: 42, instance: Some("current-server".into()),
                events: vec![EventKind::PaneTitle], after: Some(cursor(0)),
            }).await?;
            let (token, reply) = control_rx.recv().await.ok_or_else(|| anyhow::anyhow!("missing reply channel"))?;
            let request = inbound_rx.recv().await.ok_or_else(|| anyhow::anyhow!("missing replay request"))?;
            assert!(matches!(request, Inbound::ControlRequest { token: actual, request: Request::Events { after, .. }, .. } if actual == token && after == cursor(0)));
            // Registration must already exist before the authoritative replay is answered.
            assert_eq!(crate::os::lock(&subscribers).len(), 1);
            let title = |value: &str| Event::PaneTitle { id: 0, pane: crate::ids::PaneId(1), title: value.into() };
            let publish = |event: Event, cursor: EventCursor| {
                let size = crate::ecs::events::encoded_len(&SequencedEvent { cursor, event: event.clone() });
                super::super::adapter::publish(&subscribers, &event, cursor, size);
            };
            publish(title("overlap"), cursor(2));
            reply.send(Reply::Completed { id: 42, result: CommandResult::Events {
                cursor: cursor(2), events: vec![
                    SequencedEvent { cursor: cursor(1), event: Event::WorkspaceChanged { id: 0 } },
                    SequencedEvent { cursor: cursor(2), event: title("overlap") },
                ],
            }}).map_err(|_| anyhow::anyhow!("replay receiver closed"))?;
            // Queue later filtered and matching events before reading the acceptance/replay.
            publish(Event::WorkspaceChanged { id: 0 }, cursor(3));
            publish(title("later"), cursor(4));
            let accepted = read_line(&mut client).await?.ok_or_else(|| anyhow::anyhow!("accept EOF"))?;
            assert_eq!(serde_json::from_slice::<Reply>(&accepted)?, Reply::Accepted { id: 42 });
            for (sequence, value) in [(2, "overlap"), (4, "later")] {
                let line = read_line(&mut client).await?.ok_or_else(|| anyhow::anyhow!("event EOF"))?;
                let entry: SequencedEvent = serde_json::from_slice(&line)?;
                assert_eq!(entry.cursor, cursor(sequence));
                assert_eq!(entry.event, title(value).with_id(42));
            }
            drop(client);
            drop(writer);
            serving.await??;
            Ok::<_, anyhow::Error>(())
        }).await??;
        Ok(())
    }

    #[tokio::test]
    async fn subscription_checks_incarnation_before_registering() -> anyhow::Result<()> {
        tokio::time::timeout(Duration::from_secs(5), async {
            let (server, client) = UnixStream::pair()?;
            let (inbound, _inbound_rx) = mpsc::channel(1);
            let (control_replies, _control_rx) = mpsc::channel(1);
            let (manager_replies, _manager_rx) = mpsc::channel(1);
            let (viewer_outboxes, _viewer_rx) = mpsc::channel(1);
            let owner = Owner {
                instance: "current-server".into(),
                inbound,
                tokens: Arc::new(AtomicU64::new(1)),
                control_replies,
                manager_replies,
                viewer_outboxes,
                viewer_ids: Arc::new(AtomicU64::new(1)),
            };
            let subscribers = Arc::new(Mutex::new(Vec::new()));
            let serving = tokio::spawn(serve_control_connection(
                server,
                "default".into(),
                owner,
                subscribers.clone(),
            ));
            let mut client = client;
            client.write_all(CONTROL_PREFACE).await?;
            let mut preface = [0; CONTROL_PREFACE.len()];
            client.read_exact(&mut preface).await?;
            assert_eq!(&preface, CONTROL_PREFACE);
            let (client, mut writer) = client.into_split();
            let mut client = BufReader::new(client);
            for (instance, expected) in [
                ("old-server", ErrorCode::Conflict),
                ("bad instance", ErrorCode::InvalidRequest),
            ] {
                write_line(
                    &mut writer,
                    &Request::Subscribe {
                        after: None,
                        id: 1,
                        instance: Some(instance.into()),
                        events: Vec::new(),
                    },
                )
                .await?;
                let line = read_line(&mut client)
                    .await?
                    .ok_or_else(|| anyhow::anyhow!("reply EOF"))?;
                let response: Reply = serde_json::from_slice(&line)?;
                assert!(matches!(response, Reply::Failed { error, .. } if error.code == expected));
                assert!(crate::os::lock(&subscribers).is_empty());
            }
            write_line(
                &mut writer,
                &Request::Subscribe {
                    after: None,
                    id: 2,
                    instance: Some("current-server".into()),
                    events: Vec::new(),
                },
            )
            .await?;
            let line = read_line(&mut client)
                .await?
                .ok_or_else(|| anyhow::anyhow!("reply EOF"))?;
            assert_eq!(
                serde_json::from_slice::<Reply>(&line)?,
                Reply::Accepted { id: 2 }
            );
            assert_eq!(crate::os::lock(&subscribers).len(), 1);
            drop(client);
            drop(writer);
            serving.await??;
            Ok::<_, anyhow::Error>(())
        })
        .await??;
        Ok(())
    }
}