ftr 0.7.0

A fast, parallel ICMP traceroute with ASN lookup, reverse DNS, and ISP detection
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
//! Minimal async DNS resolver
//!
//! Implements A, PTR, and TXT queries over UDP using Tokio.
//! Replaces hickory-resolver for the small set of queries ftr needs.

use std::net::{IpAddr, Ipv4Addr, SocketAddr};
use tokio::net::UdpSocket;
use tokio::time::{timeout, Duration};

/// DNS query types
#[derive(Debug, Clone, Copy)]
enum QType {
    A = 1,
    Ptr = 12,
    Txt = 16,
}

/// DNS response record
#[derive(Debug, Clone)]
pub enum DnsRecord {
    /// A record: IPv4 address
    A(Ipv4Addr),
    /// PTR record: domain name
    Ptr(String),
    /// TXT record: text data
    Txt(String),
}

/// DNS resolver error
#[derive(Debug, thiserror::Error)]
pub enum DnsError {
    /// Network I/O error
    #[error("DNS I/O error: {0}")]
    Io(#[from] std::io::Error),
    /// Query timed out
    #[error("DNS query timed out")]
    Timeout,
    /// Malformed response
    #[error("malformed DNS response")]
    Malformed,
    /// No records found
    #[error("no records found (NXDOMAIN or empty)")]
    NotFound,
}

/// Cloudflare DNS server
const DNS_SERVER: SocketAddr = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(1, 1, 1, 1)), 53);
/// DNS query timeout
const DNS_TIMEOUT: Duration = Duration::from_secs(5);
/// Maximum DNS response size
const MAX_RESPONSE: usize = 4096;

/// Resolve a hostname to IPv4 addresses (A record query).
pub async fn resolve_a(hostname: &str) -> Result<Vec<Ipv4Addr>, DnsError> {
    let records = query(hostname, QType::A).await?;
    let addrs: Vec<Ipv4Addr> = records
        .into_iter()
        .filter_map(|r| match r {
            DnsRecord::A(addr) => Some(addr),
            _ => None,
        })
        .collect();
    if addrs.is_empty() {
        return Err(DnsError::NotFound);
    }
    Ok(addrs)
}

/// Perform a reverse DNS lookup (PTR query).
pub async fn resolve_ptr(ip: IpAddr) -> Result<String, DnsError> {
    let name = match ip {
        IpAddr::V4(v4) => {
            let o = v4.octets();
            format!("{}.{}.{}.{}.in-addr.arpa", o[3], o[2], o[1], o[0])
        }
        IpAddr::V6(v6) => {
            // Build nibble-reversed .ip6.arpa name
            let segments = v6.octets();
            let mut nibbles = String::with_capacity(64 + 9);
            for byte in segments.iter().rev() {
                nibbles.push_str(&format!("{:x}.{:x}.", byte & 0x0f, (byte >> 4) & 0x0f));
            }
            nibbles.push_str("ip6.arpa");
            nibbles
        }
    };
    let records = query(&name, QType::Ptr).await?;
    records
        .into_iter()
        .find_map(|r| match r {
            DnsRecord::Ptr(name) => Some(name),
            _ => None,
        })
        .ok_or(DnsError::NotFound)
}

/// Perform a TXT record lookup.
pub async fn resolve_txt(name: &str) -> Result<Vec<String>, DnsError> {
    let records = query(name, QType::Txt).await?;
    let txts: Vec<String> = records
        .into_iter()
        .filter_map(|r| match r {
            DnsRecord::Txt(s) => Some(s),
            _ => None,
        })
        .collect();
    if txts.is_empty() {
        return Err(DnsError::NotFound);
    }
    Ok(txts)
}

/// Send a DNS query and parse the response.
async fn query(name: &str, qtype: QType) -> Result<Vec<DnsRecord>, DnsError> {
    let packet = build_query(name, qtype);

    let socket = UdpSocket::bind("0.0.0.0:0").await?;
    socket.send_to(&packet, DNS_SERVER).await?;

    let mut buf = vec![0u8; MAX_RESPONSE];
    let n = timeout(DNS_TIMEOUT, socket.recv(&mut buf))
        .await
        .map_err(|_| DnsError::Timeout)??;

    parse_response(&buf[..n], qtype)
}

/// Build a DNS query packet.
fn build_query(name: &str, qtype: QType) -> Vec<u8> {
    let mut pkt = Vec::with_capacity(64);

    // Header: ID, flags, counts
    let id: u16 = (std::process::id() as u16) ^ (qtype as u16);
    pkt.extend_from_slice(&id.to_be_bytes()); // ID
    pkt.extend_from_slice(&[0x01, 0x00]); // flags: RD=1
    pkt.extend_from_slice(&1u16.to_be_bytes()); // QDCOUNT=1
    pkt.extend_from_slice(&[0, 0, 0, 0, 0, 0]); // AN, NS, AR = 0

    // Question: encode name
    for label in name.split('.') {
        pkt.push(label.len() as u8);
        pkt.extend_from_slice(label.as_bytes());
    }
    pkt.push(0); // root label

    pkt.extend_from_slice(&(qtype as u16).to_be_bytes()); // QTYPE
    pkt.extend_from_slice(&1u16.to_be_bytes()); // QCLASS = IN

    pkt
}

/// Parse a DNS response packet and extract records of the requested type.
fn parse_response(data: &[u8], qtype: QType) -> Result<Vec<DnsRecord>, DnsError> {
    if data.len() < 12 {
        return Err(DnsError::Malformed);
    }

    // Check RCODE in flags
    let rcode = data[3] & 0x0F;
    if rcode == 3 {
        // NXDOMAIN
        return Err(DnsError::NotFound);
    }
    if rcode != 0 {
        return Err(DnsError::Malformed);
    }

    let qdcount = u16::from_be_bytes([data[4], data[5]]) as usize;
    let ancount = u16::from_be_bytes([data[6], data[7]]) as usize;

    // Skip header
    let mut pos = 12;

    // Skip questions
    for _ in 0..qdcount {
        pos = skip_name(data, pos)?;
        pos += 4; // QTYPE + QCLASS
        if pos > data.len() {
            return Err(DnsError::Malformed);
        }
    }

    // Parse answers
    let mut records = Vec::new();
    for _ in 0..ancount {
        pos = skip_name(data, pos)?;
        if pos + 10 > data.len() {
            return Err(DnsError::Malformed);
        }

        let rtype = u16::from_be_bytes([data[pos], data[pos + 1]]);
        // skip class (2) + ttl (4)
        let rdlength = u16::from_be_bytes([data[pos + 8], data[pos + 9]]) as usize;
        pos += 10;

        if pos + rdlength > data.len() {
            return Err(DnsError::Malformed);
        }

        let rdata = &data[pos..pos + rdlength];

        if rtype == qtype as u16 {
            match qtype {
                QType::A => {
                    if rdata.len() == 4 {
                        records.push(DnsRecord::A(Ipv4Addr::new(
                            rdata[0], rdata[1], rdata[2], rdata[3],
                        )));
                    }
                }
                QType::Ptr => {
                    if let Ok(name) = read_name(data, pos) {
                        records.push(DnsRecord::Ptr(name));
                    }
                }
                QType::Txt => {
                    // TXT: one or more length-prefixed strings
                    let mut txt_pos = 0;
                    let mut txt = String::new();
                    while txt_pos < rdata.len() {
                        let slen = rdata[txt_pos] as usize;
                        txt_pos += 1;
                        if txt_pos + slen > rdata.len() {
                            break;
                        }
                        txt.push_str(&String::from_utf8_lossy(&rdata[txt_pos..txt_pos + slen]));
                        txt_pos += slen;
                    }
                    records.push(DnsRecord::Txt(txt));
                }
            }
        }

        pos += rdlength;
    }

    Ok(records)
}

/// Skip a DNS name (handling compression pointers) and return the position after it.
fn skip_name(data: &[u8], mut pos: usize) -> Result<usize, DnsError> {
    if pos >= data.len() {
        return Err(DnsError::Malformed);
    }
    loop {
        if pos >= data.len() {
            return Err(DnsError::Malformed);
        }
        let len = data[pos];
        if len == 0 {
            return Ok(pos + 1);
        }
        if len & 0xC0 == 0xC0 {
            // Compression pointer — 2 bytes total, done
            return Ok(pos + 2);
        }
        pos += 1 + len as usize;
    }
}

/// Read a DNS name at the given position, following compression pointers.
fn read_name(data: &[u8], mut pos: usize) -> Result<String, DnsError> {
    let mut name = String::new();
    let mut followed_pointer = false;
    let mut jumps = 0;

    loop {
        if pos >= data.len() || jumps > 10 {
            return Err(DnsError::Malformed);
        }

        let len = data[pos];
        if len == 0 {
            break;
        }

        if len & 0xC0 == 0xC0 {
            // Compression pointer
            if pos + 1 >= data.len() {
                return Err(DnsError::Malformed);
            }
            let offset = ((len as usize & 0x3F) << 8) | data[pos + 1] as usize;
            pos = offset;
            followed_pointer = true;
            jumps += 1;
            continue;
        }

        pos += 1;
        if pos + len as usize > data.len() {
            return Err(DnsError::Malformed);
        }

        if !name.is_empty() {
            name.push('.');
        }
        name.push_str(&String::from_utf8_lossy(&data[pos..pos + len as usize]));
        pos += len as usize;

        if followed_pointer {
            // After following a pointer, we keep reading from the pointed location
        }
    }

    // Remove trailing dot if present
    if name.ends_with('.') {
        name.pop();
    }

    Ok(name)
}

#[cfg(test)]
mod tests {
    use super::*;

    // ---- Helper to build a minimal valid DNS response ----

    /// Build a DNS response with the given answer records.
    /// `question_name` is encoded as labels in the question section.
    /// Each answer is (rtype, rdata).
    fn build_response(question_name: &str, qtype: QType, answers: &[(u16, &[u8])]) -> Vec<u8> {
        let mut pkt = Vec::new();

        // Header
        pkt.extend_from_slice(&[0xAB, 0xCD]); // ID
        pkt.extend_from_slice(&[0x81, 0x80]); // flags: QR=1, RD=1, RA=1
        pkt.extend_from_slice(&1u16.to_be_bytes()); // QDCOUNT=1
        pkt.extend_from_slice(&(answers.len() as u16).to_be_bytes()); // ANCOUNT
        pkt.extend_from_slice(&[0, 0, 0, 0]); // NSCOUNT, ARCOUNT = 0

        // Question section
        let question_start = pkt.len();
        for label in question_name.split('.') {
            pkt.push(label.len() as u8);
            pkt.extend_from_slice(label.as_bytes());
        }
        pkt.push(0); // root
        pkt.extend_from_slice(&(qtype as u16).to_be_bytes());
        pkt.extend_from_slice(&1u16.to_be_bytes()); // QCLASS=IN

        // Answer sections — use compression pointer to question name
        for (rtype, rdata) in answers {
            // Name: compression pointer to question_start
            pkt.push(0xC0 | ((question_start >> 8) as u8));
            pkt.push(question_start as u8);
            pkt.extend_from_slice(&rtype.to_be_bytes()); // TYPE
            pkt.extend_from_slice(&1u16.to_be_bytes()); // CLASS=IN
            pkt.extend_from_slice(&300u32.to_be_bytes()); // TTL
            pkt.extend_from_slice(&(*rdata).len().to_be_bytes()[6..8]); // RDLENGTH (u16)
            pkt.extend_from_slice(rdata);
        }

        pkt
    }

    /// Encode a domain name as DNS labels (for use in rdata).
    fn encode_name(name: &str) -> Vec<u8> {
        let mut buf = Vec::new();
        for label in name.split('.') {
            buf.push(label.len() as u8);
            buf.extend_from_slice(label.as_bytes());
        }
        buf.push(0);
        buf
    }

    // ---- build_query tests ----

    #[test]
    fn test_build_query_structure() {
        let pkt = build_query("example.com", QType::A);
        assert!(pkt.len() > 12);
        assert_eq!(pkt[2], 0x01); // RD=1
        assert_eq!(pkt[5], 1); // QDCOUNT=1
                               // QTYPE at end - 4 should be A=1
        let qtype_pos = pkt.len() - 4;
        assert_eq!(u16::from_be_bytes([pkt[qtype_pos], pkt[qtype_pos + 1]]), 1);
    }

    #[test]
    fn test_build_query_labels() {
        let pkt = build_query("a.b.c", QType::Txt);
        assert_eq!(pkt[12], 1);
        assert_eq!(pkt[13], b'a');
        assert_eq!(pkt[14], 1);
        assert_eq!(pkt[15], b'b');
        assert_eq!(pkt[16], 1);
        assert_eq!(pkt[17], b'c');
        assert_eq!(pkt[18], 0); // root
    }

    #[test]
    fn test_build_query_single_label() {
        let pkt = build_query("localhost", QType::A);
        assert_eq!(pkt[12], 9); // "localhost" is 9 chars
        assert_eq!(&pkt[13..22], b"localhost");
        assert_eq!(pkt[22], 0); // root
    }

    // ---- parse_response: A records ----

    #[test]
    fn test_parse_a_record() {
        let resp = build_response("example.com", QType::A, &[(1, &[93, 184, 216, 34])]);
        let records = parse_response(&resp, QType::A).expect("should parse");
        assert_eq!(records.len(), 1);
        match &records[0] {
            DnsRecord::A(addr) => assert_eq!(*addr, Ipv4Addr::new(93, 184, 216, 34)),
            other => panic!("expected A record, got {other:?}"),
        }
    }

    #[test]
    fn test_parse_multiple_a_records() {
        let resp = build_response(
            "dns.google",
            QType::A,
            &[(1, &[8, 8, 8, 8]), (1, &[8, 8, 4, 4])],
        );
        let records = parse_response(&resp, QType::A).expect("should parse");
        assert_eq!(records.len(), 2);
    }

    #[test]
    fn test_parse_a_wrong_rdlength() {
        // A record with only 3 bytes of rdata (invalid, should be 4)
        let resp = build_response("x.com", QType::A, &[(1, &[1, 2, 3])]);
        let records = parse_response(&resp, QType::A).expect("should parse without panic");
        assert!(records.is_empty(), "invalid A record should be skipped");
    }

    // ---- parse_response: PTR records ----

    #[test]
    fn test_parse_ptr_record() {
        let name_data = encode_name("dns.google");
        let resp = build_response("8.8.8.8.in-addr.arpa", QType::Ptr, &[(12, &name_data)]);
        let records = parse_response(&resp, QType::Ptr).expect("should parse");
        assert_eq!(records.len(), 1);
        match &records[0] {
            DnsRecord::Ptr(name) => assert_eq!(name, "dns.google"),
            other => panic!("expected PTR record, got {other:?}"),
        }
    }

    // ---- parse_response: TXT records ----

    #[test]
    fn test_parse_txt_record_single_string() {
        // TXT rdata: length-prefixed string
        let txt_content = b"15169 | 8.8.8.0/24 | US";
        let mut rdata = vec![txt_content.len() as u8];
        rdata.extend_from_slice(txt_content);

        let resp = build_response("8.8.8.8.origin.asn.cymru.com", QType::Txt, &[(16, &rdata)]);
        let records = parse_response(&resp, QType::Txt).expect("should parse");
        assert_eq!(records.len(), 1);
        match &records[0] {
            DnsRecord::Txt(s) => assert_eq!(s, "15169 | 8.8.8.0/24 | US"),
            other => panic!("expected TXT record, got {other:?}"),
        }
    }

    #[test]
    fn test_parse_txt_record_multiple_strings() {
        // TXT rdata with two concatenated length-prefixed strings
        let s1 = b"hello ";
        let s2 = b"world";
        let mut rdata = vec![s1.len() as u8];
        rdata.extend_from_slice(s1);
        rdata.push(s2.len() as u8);
        rdata.extend_from_slice(s2);

        let resp = build_response("test.example", QType::Txt, &[(16, &rdata)]);
        let records = parse_response(&resp, QType::Txt).expect("should parse");
        assert_eq!(records.len(), 1);
        match &records[0] {
            DnsRecord::Txt(s) => assert_eq!(s, "hello world"),
            other => panic!("expected TXT record, got {other:?}"),
        }
    }

    #[test]
    fn test_parse_txt_empty_string() {
        // TXT with a zero-length string
        let rdata = vec![0u8]; // one empty string
        let resp = build_response("test.example", QType::Txt, &[(16, &rdata)]);
        let records = parse_response(&resp, QType::Txt).expect("should parse");
        assert_eq!(records.len(), 1);
        match &records[0] {
            DnsRecord::Txt(s) => assert_eq!(s, ""),
            other => panic!("expected TXT record, got {other:?}"),
        }
    }

    // ---- parse_response: error cases ----

    #[test]
    fn test_parse_nxdomain() {
        let mut resp = vec![0u8; 12];
        resp[3] = 3; // RCODE = NXDOMAIN
        assert!(matches!(
            parse_response(&resp, QType::A),
            Err(DnsError::NotFound)
        ));
    }

    #[test]
    fn test_parse_servfail() {
        let mut resp = vec![0u8; 12];
        resp[3] = 2; // RCODE = SERVFAIL
        assert!(matches!(
            parse_response(&resp, QType::A),
            Err(DnsError::Malformed)
        ));
    }

    #[test]
    fn test_parse_too_short() {
        assert!(matches!(
            parse_response(&[0; 5], QType::A),
            Err(DnsError::Malformed)
        ));
        assert!(matches!(
            parse_response(&[], QType::A),
            Err(DnsError::Malformed)
        ));
    }

    #[test]
    fn test_parse_zero_answers() {
        // Valid header, NOERROR, but 0 answers
        let mut resp = vec![0u8; 12];
        resp[2] = 0x81;
        resp[3] = 0x80; // QR=1, NOERROR
                        // QDCOUNT=0, ANCOUNT=0
        let records = parse_response(&resp, QType::A).expect("should parse");
        assert!(records.is_empty());
    }

    #[test]
    fn test_parse_skips_wrong_rtype() {
        // Response has a CNAME (type 5) but we asked for A (type 1)
        let cname_data = encode_name("other.example.com");
        let resp = build_response("example.com", QType::A, &[(5, &cname_data)]);
        let records = parse_response(&resp, QType::A).expect("should parse");
        assert!(
            records.is_empty(),
            "CNAME should not be returned for A query"
        );
    }

    // ---- skip_name / read_name tests ----

    #[test]
    fn test_skip_name_plain() {
        // \x07example\x03com\x00
        let data = b"\x07example\x03com\x00extra";
        let pos = skip_name(data, 0).expect("should skip");
        assert_eq!(pos, 13); // 1+7+1+3+1 = 13
    }

    #[test]
    fn test_skip_name_compression_pointer() {
        // Compression pointer at position 0: 0xC0 0x0C -> points to offset 12
        let data = [0xC0, 0x0C, 0xFF];
        let pos = skip_name(&data, 0).expect("should skip pointer");
        assert_eq!(pos, 2);
    }

    #[test]
    fn test_skip_name_empty() {
        assert!(skip_name(&[], 0).is_err());
    }

    #[test]
    fn test_skip_name_truncated_label() {
        // Label says 5 bytes but buffer ends after 3
        let data = [5, b'a', b'b', b'c'];
        assert!(skip_name(&data, 0).is_err());
    }

    #[test]
    fn test_read_name_plain() {
        let data = b"\x03www\x07example\x03com\x00";
        let name = read_name(data, 0).expect("should read");
        assert_eq!(name, "www.example.com");
    }

    #[test]
    fn test_read_name_with_compression() {
        // "example.com" at offset 0, then "www" + pointer to offset 0
        let mut data = Vec::new();
        // offset 0: \x07example\x03com\x00
        data.extend_from_slice(b"\x07example\x03com\x00");
        let ptr_start = data.len();
        // offset 13: \x03www + pointer to 0
        data.extend_from_slice(b"\x03www");
        data.push(0xC0);
        data.push(0x00);

        let name = read_name(&data, ptr_start).expect("should read with compression");
        assert_eq!(name, "www.example.com");
    }

    #[test]
    fn test_read_name_pointer_loop_detection() {
        // Two pointers pointing at each other: infinite loop
        let data = [0xC0, 0x02, 0xC0, 0x00];
        assert!(read_name(&data, 0).is_err(), "should detect pointer loop");
    }

    #[test]
    fn test_read_name_chained_pointers() {
        // Chain: offset 10 -> pointer to offset 5 -> pointer to offset 0
        let mut data = vec![0u8; 20];
        // offset 0: \x01a\x00
        data[0] = 1;
        data[1] = b'a';
        data[2] = 0;
        // offset 5: \x01b + pointer to offset 0
        data[5] = 1;
        data[6] = b'b';
        data[7] = 0xC0;
        data[8] = 0x00;
        // offset 10: \x01c + pointer to offset 5
        data[10] = 1;
        data[11] = b'c';
        data[12] = 0xC0;
        data[13] = 5;

        let name = read_name(&data, 10).expect("should follow chain");
        assert_eq!(name, "c.b.a");
    }

    #[test]
    fn test_read_name_truncated() {
        let data = [3, b'a', b'b']; // says 3 bytes but only 2 available
        assert!(read_name(&data, 0).is_err());
    }

    // ---- PTR name construction ----

    #[test]
    fn test_ipv4_ptr_name() {
        let ip = IpAddr::V4(Ipv4Addr::new(192, 168, 1, 1));
        if let IpAddr::V4(v4) = ip {
            let o = v4.octets();
            let name = format!("{}.{}.{}.{}.in-addr.arpa", o[3], o[2], o[1], o[0]);
            assert_eq!(name, "1.1.168.192.in-addr.arpa");
        }
    }

    #[test]
    fn test_ipv6_ptr_name() {
        let ip: IpAddr = "2001:4860:4860::8888".parse().expect("valid IPv6");
        if let IpAddr::V6(v6) = ip {
            let segments = v6.octets();
            let mut nibbles = String::with_capacity(64 + 9);
            for byte in segments.iter().rev() {
                nibbles.push_str(&format!("{:x}.{:x}.", byte & 0x0f, (byte >> 4) & 0x0f));
            }
            nibbles.push_str("ip6.arpa");
            // Should contain the reversed nibbles
            assert!(nibbles.starts_with("8.8.8.8.0.0.0.0.0.0.0.0.0.0.0.0."));
            assert!(nibbles.ends_with("ip6.arpa"));
        }
    }

    // ---- Error type tests ----

    #[test]
    fn test_error_display() {
        assert!(DnsError::Timeout.to_string().contains("timed out"));
        assert!(DnsError::Malformed.to_string().contains("malformed"));
        assert!(DnsError::NotFound.to_string().contains("no records"));
        let io_err = DnsError::Io(std::io::Error::new(std::io::ErrorKind::Other, "test"));
        assert!(io_err.to_string().contains("test"));
    }

    // ---- Live network tests (gracefully skip on failure) ----

    #[tokio::test]
    async fn test_resolve_a_google() {
        let result = tokio::time::timeout(Duration::from_secs(10), resolve_a("dns.google")).await;
        match result {
            Ok(Ok(addrs)) => {
                assert!(!addrs.is_empty());
                assert!(
                    addrs.contains(&Ipv4Addr::new(8, 8, 8, 8))
                        || addrs.contains(&Ipv4Addr::new(8, 8, 4, 4))
                );
            }
            Ok(Err(e)) => eprintln!("DNS lookup failed (network unavailable): {e}"),
            Err(_) => eprintln!("DNS lookup timed out"),
        }
    }

    #[tokio::test]
    async fn test_resolve_a_nonexistent() {
        let result = tokio::time::timeout(
            Duration::from_secs(10),
            resolve_a("thisdomaindoesnotexist.invalid"),
        )
        .await;
        match result {
            Ok(Err(DnsError::NotFound)) => {} // expected
            Ok(Err(e)) => eprintln!("Got different error (acceptable): {e}"),
            Ok(Ok(_)) => panic!("should not resolve nonexistent domain"),
            Err(_) => eprintln!("timed out"),
        }
    }

    #[tokio::test]
    async fn test_resolve_ptr_google() {
        let result = tokio::time::timeout(
            Duration::from_secs(10),
            resolve_ptr(IpAddr::V4(Ipv4Addr::new(8, 8, 8, 8))),
        )
        .await;
        match result {
            Ok(Ok(name)) => assert!(name.contains("dns.google"), "got: {name}"),
            Ok(Err(e)) => eprintln!("PTR lookup failed (network unavailable): {e}"),
            Err(_) => eprintln!("PTR lookup timed out"),
        }
    }

    #[tokio::test]
    async fn test_resolve_txt_cymru() {
        let result = tokio::time::timeout(
            Duration::from_secs(10),
            resolve_txt("8.8.8.8.origin.asn.cymru.com"),
        )
        .await;
        match result {
            Ok(Ok(txts)) => {
                assert!(!txts.is_empty());
                assert!(
                    txts[0].contains("15169"),
                    "expected AS15169, got: {}",
                    txts[0]
                );
            }
            Ok(Err(e)) => eprintln!("TXT lookup failed (network unavailable): {e}"),
            Err(_) => eprintln!("TXT lookup timed out"),
        }
    }
}