fsqlite-mvcc 0.1.2

MVCC page-level versioning for concurrent writers
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
//! Left-Right wait-free reads for metadata (§14.3).
//!
//! Two copies of the data are maintained; readers access one copy with wait-free
//! guarantees (at most one retry per concurrent swap), while the writer updates
//! the inactive copy, swaps the `active` pointer, waits for old-side readers to
//! drain, then updates the old copy.
//!
//! ## Protocol
//!
//! **Reader**:
//!   1. Load `active` index (0 or 1).
//!   2. Increment reader counter for that side.
//!   3. Re-check `active` — if it changed, decrement and retry (at most once).
//!   4. Read the value(s).
//!   5. Decrement reader counter.
//!
//! **Writer** (serialized via `fsqlite_types::sync_primitives::Mutex`):
//!   1. Update the *inactive* copy.
//!   2. Swap `active`.
//!   3. Spin-wait until reader counter on the *old* active side drains to zero.
//!   4. Update the *old* copy (now inactive) to match.
//!
//! ## Safety
//!
//! No `UnsafeCell` or `unsafe` blocks — all protected state uses `AtomicU64`.
//!
//! ## Tracing & Metrics
//!
//! - **Target**: `fsqlite.left_right`
//!   - `TRACE`: clean reads (zero retries)
//!   - `DEBUG`: reads that retried due to concurrent swap
//! - **Metrics** (global atomics, zero per-op overhead):
//!   - `fsqlite_leftright_reads_total`
//!   - `fsqlite_leftright_swaps_total`
//!   - `fsqlite_leftright_reader_retries_total`

use std::sync::atomic::{AtomicU64, Ordering};

use serde::Serialize;

// ---------------------------------------------------------------------------
// Global metrics (lock-free, Relaxed ordering)
// ---------------------------------------------------------------------------

static FSQLITE_LEFTRIGHT_READS_TOTAL: AtomicU64 = AtomicU64::new(0);
static FSQLITE_LEFTRIGHT_SWAPS_TOTAL: AtomicU64 = AtomicU64::new(0);
static FSQLITE_LEFTRIGHT_READER_RETRIES_TOTAL: AtomicU64 = AtomicU64::new(0);

/// Snapshot of left-right metrics.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize)]
pub struct LeftRightMetrics {
    pub fsqlite_leftright_reads_total: u64,
    pub fsqlite_leftright_swaps_total: u64,
    pub fsqlite_leftright_reader_retries_total: u64,
}

/// Read current left-right metrics.
#[must_use]
pub fn leftright_metrics() -> LeftRightMetrics {
    LeftRightMetrics {
        fsqlite_leftright_reads_total: FSQLITE_LEFTRIGHT_READS_TOTAL.load(Ordering::Relaxed),
        fsqlite_leftright_swaps_total: FSQLITE_LEFTRIGHT_SWAPS_TOTAL.load(Ordering::Relaxed),
        fsqlite_leftright_reader_retries_total: FSQLITE_LEFTRIGHT_READER_RETRIES_TOTAL
            .load(Ordering::Relaxed),
    }
}

/// Reset metrics (for tests).
pub fn reset_leftright_metrics() {
    FSQLITE_LEFTRIGHT_READS_TOTAL.store(0, Ordering::Relaxed);
    FSQLITE_LEFTRIGHT_SWAPS_TOTAL.store(0, Ordering::Relaxed);
    FSQLITE_LEFTRIGHT_READER_RETRIES_TOTAL.store(0, Ordering::Relaxed);
}

// ---------------------------------------------------------------------------
// LeftRight (single u64 value)
// ---------------------------------------------------------------------------

/// A left-right primitive protecting a single `u64` metadata value.
///
/// Readers call [`read`](LeftRight::read) for a wait-free snapshot (at most
/// one retry per concurrent swap). Writers call [`write`](LeftRight::write) or
/// [`update`](LeftRight::update) which serialize via an internal mutex, update
/// both copies, and atomically swap the active pointer.
///
/// All data is stored in atomics — no `UnsafeCell`, no `unsafe`.
pub struct LeftRight {
    left: AtomicU64,
    right: AtomicU64,
    /// 0 = readers use left, 1 = readers use right
    active: AtomicU64,
    left_readers: AtomicU64,
    right_readers: AtomicU64,
    writer_lock: fsqlite_types::sync_primitives::Mutex<()>,
}

impl LeftRight {
    /// Create a new left-right with the given initial value (both copies set).
    pub fn new(initial: u64) -> Self {
        Self {
            left: AtomicU64::new(initial),
            right: AtomicU64::new(initial),
            active: AtomicU64::new(0),
            left_readers: AtomicU64::new(0),
            right_readers: AtomicU64::new(0),
            writer_lock: fsqlite_types::sync_primitives::Mutex::new(()),
        }
    }

    /// Wait-free read. Returns the current value.
    ///
    /// At most one retry if a concurrent writer swaps during the read.
    #[inline]
    pub fn read(&self, data_key: &str) -> u64 {
        let mut retries = 0u32;
        let value = loop {
            let side = self.active.load(Ordering::Acquire);
            let (readers, data) = if side == 0 {
                (&self.left_readers, &self.left)
            } else {
                (&self.right_readers, &self.right)
            };
            readers.fetch_add(1, Ordering::AcqRel);
            // Re-check: if active changed, we incremented the wrong counter.
            if self.active.load(Ordering::Acquire) == side {
                let v = data.load(Ordering::Acquire);
                readers.fetch_sub(1, Ordering::Release);
                break v;
            }
            // Side changed during enter; undo and retry on the new side.
            readers.fetch_sub(1, Ordering::Release);
            retries += 1;
        };
        FSQLITE_LEFTRIGHT_READS_TOTAL.fetch_add(1, Ordering::Relaxed);
        if retries > 0 {
            FSQLITE_LEFTRIGHT_READER_RETRIES_TOTAL.fetch_add(u64::from(retries), Ordering::Relaxed);
        }
        emit_read_trace(data_key, retries);
        value
    }

    /// Set a new value. Serialized with other writers.
    pub fn write(&self, new_val: u64) {
        let _guard = self.writer_lock.lock();
        self.write_inner(new_val);
    }

    /// Read-modify-write via a closure. Serialized with other writers.
    pub fn update<F: FnOnce(u64) -> u64>(&self, f: F) {
        let _guard = self.writer_lock.lock();
        let active = self.active.load(Ordering::Acquire);
        let current = if active == 0 {
            self.left.load(Ordering::Acquire)
        } else {
            self.right.load(Ordering::Acquire)
        };
        self.write_inner(f(current));
    }

    fn write_inner(&self, new_val: u64) {
        let active = self.active.load(Ordering::Acquire);

        // 1. Write to inactive copy.
        if active == 0 {
            self.right.store(new_val, Ordering::Release);
        } else {
            self.left.store(new_val, Ordering::Release);
        }

        // 2. Swap active side.
        let new_active = 1 - active;
        self.active.store(new_active, Ordering::Release);
        FSQLITE_LEFTRIGHT_SWAPS_TOTAL.fetch_add(1, Ordering::Relaxed);

        // 3. Wait for readers on the old active side to drain.
        let old_readers = if active == 0 {
            &self.left_readers
        } else {
            &self.right_readers
        };
        while old_readers.load(Ordering::Acquire) > 0 {
            std::hint::spin_loop();
        }

        // 4. Update old copy (now inactive) to match.
        if active == 0 {
            self.left.store(new_val, Ordering::Release);
        } else {
            self.right.store(new_val, Ordering::Release);
        }

        emit_swap_trace(1);
    }

    /// Returns which side is currently active (0 = left, 1 = right).
    #[must_use]
    pub fn active_side(&self) -> u64 {
        self.active.load(Ordering::Relaxed)
    }
}

#[allow(clippy::missing_fields_in_debug)]
impl std::fmt::Debug for LeftRight {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        let active = self.active.load(Ordering::Relaxed);
        let lr = self.left_readers.load(Ordering::Relaxed);
        let rr = self.right_readers.load(Ordering::Relaxed);
        f.debug_struct("LeftRight")
            .field("active", &if active == 0 { "left" } else { "right" })
            .field("left_readers", &lr)
            .field("right_readers", &rr)
            .finish_non_exhaustive()
    }
}

// ---------------------------------------------------------------------------
// LeftRightPair (two u64 values, consistent snapshot)
// ---------------------------------------------------------------------------

/// A left-right primitive protecting a pair of `u64` values read atomically.
///
/// Useful for metadata that must be read consistently as a unit
/// (e.g., schema_epoch + commit_seq, or min/max version bounds).
pub struct LeftRightPair {
    left_a: AtomicU64,
    left_b: AtomicU64,
    right_a: AtomicU64,
    right_b: AtomicU64,
    active: AtomicU64,
    left_readers: AtomicU64,
    right_readers: AtomicU64,
    writer_lock: fsqlite_types::sync_primitives::Mutex<()>,
}

impl LeftRightPair {
    /// Create a new left-right pair with the given initial values.
    pub fn new(a: u64, b: u64) -> Self {
        Self {
            left_a: AtomicU64::new(a),
            left_b: AtomicU64::new(b),
            right_a: AtomicU64::new(a),
            right_b: AtomicU64::new(b),
            active: AtomicU64::new(0),
            left_readers: AtomicU64::new(0),
            right_readers: AtomicU64::new(0),
            writer_lock: fsqlite_types::sync_primitives::Mutex::new(()),
        }
    }

    /// Wait-free read of the consistent pair.
    #[inline]
    pub fn read(&self, data_key: &str) -> (u64, u64) {
        let mut retries = 0u32;
        let value = loop {
            let side = self.active.load(Ordering::Acquire);
            let (readers, da, db) = if side == 0 {
                (&self.left_readers, &self.left_a, &self.left_b)
            } else {
                (&self.right_readers, &self.right_a, &self.right_b)
            };
            readers.fetch_add(1, Ordering::AcqRel);
            if self.active.load(Ordering::Acquire) == side {
                let va = da.load(Ordering::Acquire);
                let vb = db.load(Ordering::Acquire);
                readers.fetch_sub(1, Ordering::Release);
                break (va, vb);
            }
            readers.fetch_sub(1, Ordering::Release);
            retries += 1;
        };
        FSQLITE_LEFTRIGHT_READS_TOTAL.fetch_add(1, Ordering::Relaxed);
        if retries > 0 {
            FSQLITE_LEFTRIGHT_READER_RETRIES_TOTAL.fetch_add(u64::from(retries), Ordering::Relaxed);
        }
        emit_read_trace(data_key, retries);
        value
    }

    /// Update both values. Serialized with other writers.
    pub fn write(&self, a: u64, b: u64) {
        let _guard = self.writer_lock.lock();
        let active = self.active.load(Ordering::Acquire);

        // Write to inactive side.
        if active == 0 {
            self.right_a.store(a, Ordering::Release);
            self.right_b.store(b, Ordering::Release);
        } else {
            self.left_a.store(a, Ordering::Release);
            self.left_b.store(b, Ordering::Release);
        }

        // Swap.
        self.active.store(1 - active, Ordering::Release);
        FSQLITE_LEFTRIGHT_SWAPS_TOTAL.fetch_add(1, Ordering::Relaxed);

        // Drain old readers.
        let old_readers = if active == 0 {
            &self.left_readers
        } else {
            &self.right_readers
        };
        while old_readers.load(Ordering::Acquire) > 0 {
            std::hint::spin_loop();
        }

        // Update old copy.
        if active == 0 {
            self.left_a.store(a, Ordering::Release);
            self.left_b.store(b, Ordering::Release);
        } else {
            self.right_a.store(a, Ordering::Release);
            self.right_b.store(b, Ordering::Release);
        }

        emit_swap_trace(1);
    }
}

#[allow(clippy::missing_fields_in_debug)]
impl std::fmt::Debug for LeftRightPair {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        let active = self.active.load(Ordering::Relaxed);
        f.debug_struct("LeftRightPair")
            .field("active", &if active == 0 { "left" } else { "right" })
            .finish_non_exhaustive()
    }
}

// ---------------------------------------------------------------------------
// LeftRightTriple (three u64 values)
// ---------------------------------------------------------------------------

/// A left-right primitive protecting a triple of `u64` values.
///
/// Matches the `(commit_seq, schema_epoch, ecs_epoch)` pattern from the
/// shared-memory header.
pub struct LeftRightTriple {
    left_a: AtomicU64,
    left_b: AtomicU64,
    left_c: AtomicU64,
    right_a: AtomicU64,
    right_b: AtomicU64,
    right_c: AtomicU64,
    active: AtomicU64,
    left_readers: AtomicU64,
    right_readers: AtomicU64,
    writer_lock: fsqlite_types::sync_primitives::Mutex<()>,
}

impl LeftRightTriple {
    /// Create a new left-right triple.
    pub fn new(a: u64, b: u64, c: u64) -> Self {
        Self {
            left_a: AtomicU64::new(a),
            left_b: AtomicU64::new(b),
            left_c: AtomicU64::new(c),
            right_a: AtomicU64::new(a),
            right_b: AtomicU64::new(b),
            right_c: AtomicU64::new(c),
            active: AtomicU64::new(0),
            left_readers: AtomicU64::new(0),
            right_readers: AtomicU64::new(0),
            writer_lock: fsqlite_types::sync_primitives::Mutex::new(()),
        }
    }

    /// Wait-free read of the consistent triple.
    #[inline]
    pub fn read(&self, data_key: &str) -> (u64, u64, u64) {
        let mut retries = 0u32;
        let value = loop {
            let side = self.active.load(Ordering::Acquire);
            let (readers, da, db, dc) = if side == 0 {
                (&self.left_readers, &self.left_a, &self.left_b, &self.left_c)
            } else {
                (
                    &self.right_readers,
                    &self.right_a,
                    &self.right_b,
                    &self.right_c,
                )
            };
            readers.fetch_add(1, Ordering::AcqRel);
            if self.active.load(Ordering::Acquire) == side {
                let va = da.load(Ordering::Acquire);
                let vb = db.load(Ordering::Acquire);
                let vc = dc.load(Ordering::Acquire);
                readers.fetch_sub(1, Ordering::Release);
                break (va, vb, vc);
            }
            readers.fetch_sub(1, Ordering::Release);
            retries += 1;
        };
        FSQLITE_LEFTRIGHT_READS_TOTAL.fetch_add(1, Ordering::Relaxed);
        if retries > 0 {
            FSQLITE_LEFTRIGHT_READER_RETRIES_TOTAL.fetch_add(u64::from(retries), Ordering::Relaxed);
        }
        emit_read_trace(data_key, retries);
        value
    }

    /// Update all three values. Serialized with other writers.
    pub fn write(&self, a: u64, b: u64, c: u64) {
        let _guard = self.writer_lock.lock();
        let active = self.active.load(Ordering::Acquire);

        // Write to inactive side.
        if active == 0 {
            self.right_a.store(a, Ordering::Release);
            self.right_b.store(b, Ordering::Release);
            self.right_c.store(c, Ordering::Release);
        } else {
            self.left_a.store(a, Ordering::Release);
            self.left_b.store(b, Ordering::Release);
            self.left_c.store(c, Ordering::Release);
        }

        // Swap.
        self.active.store(1 - active, Ordering::Release);
        FSQLITE_LEFTRIGHT_SWAPS_TOTAL.fetch_add(1, Ordering::Relaxed);

        // Drain old readers.
        let old_readers = if active == 0 {
            &self.left_readers
        } else {
            &self.right_readers
        };
        while old_readers.load(Ordering::Acquire) > 0 {
            std::hint::spin_loop();
        }

        // Update old copy.
        if active == 0 {
            self.left_a.store(a, Ordering::Release);
            self.left_b.store(b, Ordering::Release);
            self.left_c.store(c, Ordering::Release);
        } else {
            self.right_a.store(a, Ordering::Release);
            self.right_b.store(b, Ordering::Release);
            self.right_c.store(c, Ordering::Release);
        }

        emit_swap_trace(1);
    }
}

#[allow(clippy::missing_fields_in_debug)]
impl std::fmt::Debug for LeftRightTriple {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        let active = self.active.load(Ordering::Relaxed);
        f.debug_struct("LeftRightTriple")
            .field("active", &if active == 0 { "left" } else { "right" })
            .finish_non_exhaustive()
    }
}

// ---------------------------------------------------------------------------
// Tracing helpers
// ---------------------------------------------------------------------------

fn emit_read_trace(data_key: &str, retries: u32) {
    if retries > 0 {
        tracing::debug!(
            target: "fsqlite.left_right",
            data_key,
            retries,
            "left_right_read retried"
        );
    } else {
        tracing::trace!(
            target: "fsqlite.left_right",
            data_key,
            retries = 0u32,
            "left_right_read"
        );
    }
}

fn emit_swap_trace(swap_count: u32) {
    tracing::debug!(
        target: "fsqlite.left_right",
        swap_count,
        "left_right_swap"
    );
}

// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------

#[cfg(test)]
mod tests {
    use super::*;
    use std::sync::atomic::AtomicBool;
    use std::sync::{Arc, Barrier};
    use std::thread;
    use std::time::Duration;

    #[test]
    fn basic_read_write() {
        let lr = LeftRight::new(42);
        assert_eq!(lr.read("test"), 42);
        lr.write(99);
        assert_eq!(lr.read("test"), 99);
    }

    #[test]
    fn update_closure() {
        let lr = LeftRight::new(10);
        lr.update(|v| v + 5);
        assert_eq!(lr.read("test"), 15);
        lr.update(|v| v * 2);
        assert_eq!(lr.read("test"), 30);
    }

    #[test]
    fn pair_consistent_snapshot() {
        let lr = LeftRightPair::new(1, 2);
        assert_eq!(lr.read("pair"), (1, 2));
        lr.write(10, 20);
        assert_eq!(lr.read("pair"), (10, 20));
    }

    #[test]
    fn triple_consistent_snapshot() {
        let lr = LeftRightTriple::new(1, 2, 3);
        assert_eq!(lr.read("triple"), (1, 2, 3));
        lr.write(10, 20, 30);
        assert_eq!(lr.read("triple"), (10, 20, 30));
    }

    /// Verify that concurrent readers never observe an inconsistent pair.
    #[test]
    fn no_torn_reads_pair() {
        let lr = Arc::new(LeftRightPair::new(0, 0));
        let stop = Arc::new(AtomicBool::new(false));
        let barrier = Arc::new(Barrier::new(5)); // 1 writer + 4 readers

        let writer_lr = Arc::clone(&lr);
        let writer_stop = Arc::clone(&stop);
        let writer_barrier = Arc::clone(&barrier);
        let writer = thread::spawn(move || {
            writer_barrier.wait();
            let mut val = 0u64;
            while !writer_stop.load(Ordering::Relaxed) {
                val += 1;
                writer_lr.write(val, val);
            }
            val
        });

        let mut readers = Vec::new();
        for _ in 0..4 {
            let rlr = Arc::clone(&lr);
            let rs = Arc::clone(&stop);
            let rb = Arc::clone(&barrier);
            readers.push(thread::spawn(move || {
                rb.wait();
                let mut reads = 0u64;
                while !rs.load(Ordering::Relaxed) {
                    let (a, b) = rlr.read("pair");
                    assert_eq!(a, b, "torn read: a={a}, b={b}");
                    reads += 1;
                }
                reads
            }));
        }

        thread::sleep(Duration::from_millis(500));
        stop.store(true, Ordering::Release);

        let writer_count = writer.join().unwrap();
        let mut total_reads = 0u64;
        for r in readers {
            total_reads += r.join().unwrap();
        }

        assert!(writer_count > 0, "writer must have written");
        assert!(total_reads > 0, "readers must have read");
        println!("[left_right_pair] writes={writer_count} reads={total_reads} no torn reads");
    }

    /// Verify that concurrent readers never observe an inconsistent triple.
    #[test]
    fn no_torn_reads_triple() {
        let lr = Arc::new(LeftRightTriple::new(0, 0, 0));
        let stop = Arc::new(AtomicBool::new(false));
        let barrier = Arc::new(Barrier::new(5));

        let writer_lr = Arc::clone(&lr);
        let writer_stop = Arc::clone(&stop);
        let writer_barrier = Arc::clone(&barrier);
        let writer = thread::spawn(move || {
            writer_barrier.wait();
            let mut val = 0u64;
            while !writer_stop.load(Ordering::Relaxed) {
                val += 1;
                writer_lr.write(val, val, val);
            }
            val
        });

        let mut readers = Vec::new();
        for _ in 0..4 {
            let rlr = Arc::clone(&lr);
            let rs = Arc::clone(&stop);
            let rb = Arc::clone(&barrier);
            readers.push(thread::spawn(move || {
                rb.wait();
                let mut reads = 0u64;
                while !rs.load(Ordering::Relaxed) {
                    let (a, b, c) = rlr.read("triple");
                    assert!(a == b && b == c, "torn read: a={a}, b={b}, c={c}");
                    reads += 1;
                }
                reads
            }));
        }

        thread::sleep(Duration::from_millis(500));
        stop.store(true, Ordering::Release);

        let writer_count = writer.join().unwrap();
        let mut total_reads = 0u64;
        for r in readers {
            total_reads += r.join().unwrap();
        }

        assert!(writer_count > 0);
        assert!(total_reads > 0);
        println!("[left_right_triple] writes={writer_count} reads={total_reads} no torn reads");
    }

    /// Verify multiple writers serialize correctly via the mutex.
    #[test]
    fn multiple_writers_serialize() {
        let lr = Arc::new(LeftRight::new(0));
        let barrier = Arc::new(Barrier::new(4));
        let mut handles = Vec::new();

        for _ in 0..4 {
            let l = Arc::clone(&lr);
            let b = Arc::clone(&barrier);
            handles.push(thread::spawn(move || {
                b.wait();
                for _ in 0..1000 {
                    l.update(|v| v + 1);
                }
            }));
        }

        for h in handles {
            h.join().unwrap();
        }

        assert_eq!(lr.read("counter"), 4000);
    }

    #[test]
    fn metrics_increment() {
        // Delta-based: snapshot before, act, snapshot after.
        let before = leftright_metrics();
        let lr = LeftRight::new(1);
        lr.read("m1");
        lr.read("m2");
        lr.read("m3");

        let after = leftright_metrics();
        let delta = after.fsqlite_leftright_reads_total - before.fsqlite_leftright_reads_total;
        assert_eq!(delta, 3);
    }

    #[test]
    fn swap_count_increments() {
        // Delta-based: snapshot before, act, snapshot after.
        let before = leftright_metrics();
        let lr = LeftRight::new(0);
        lr.write(1);
        lr.write(2);
        lr.write(3);

        let after = leftright_metrics();
        let delta = after.fsqlite_leftright_swaps_total - before.fsqlite_leftright_swaps_total;
        assert!(delta >= 3, "expected at least 3 swaps, got {delta}");
    }

    /// Debug formatting works without deadlock.
    #[test]
    fn debug_format() {
        let lr = LeftRight::new(42);
        let dbg = format!("{lr:?}");
        assert!(dbg.contains("LeftRight"));
        assert!(
            dbg.contains("left") || dbg.contains("right"),
            "debug must show active side"
        );
    }

    /// Stress test: concurrent readers + writers, check no panics/deadlocks.
    #[test]
    fn stress_concurrent_rw() {
        let lr = Arc::new(LeftRight::new(0));
        let stop = Arc::new(AtomicBool::new(false));
        let barrier = Arc::new(Barrier::new(6)); // 2 writers + 4 readers
        let mut handles = Vec::new();

        // 2 writers
        for _ in 0..2 {
            let l = Arc::clone(&lr);
            let st = Arc::clone(&stop);
            let b = Arc::clone(&barrier);
            handles.push(thread::spawn(move || {
                b.wait();
                let mut writes = 0u64;
                while !st.load(Ordering::Relaxed) {
                    l.update(|v| v.wrapping_add(1));
                    writes += 1;
                }
                writes
            }));
        }

        // 4 readers
        for _ in 0..4 {
            let l = Arc::clone(&lr);
            let st = Arc::clone(&stop);
            let b = Arc::clone(&barrier);
            handles.push(thread::spawn(move || {
                b.wait();
                let mut reads = 0u64;
                while !st.load(Ordering::Relaxed) {
                    let _ = l.read("stress");
                    reads += 1;
                }
                reads
            }));
        }

        thread::sleep(Duration::from_millis(500));
        stop.store(true, Ordering::Release);

        let mut total_writes = 0u64;
        let mut total_reads = 0u64;
        for (i, h) in handles.into_iter().enumerate() {
            let count = h.join().unwrap();
            if i < 2 {
                total_writes += count;
            } else {
                total_reads += count;
            }
        }

        assert!(total_writes > 0);
        assert!(total_reads > 0);
        println!("[left_right_stress] writes={total_writes} reads={total_reads}");
    }
}