fslite-cli 0.1.0

Command-line client for fslite: manages named filesystems/workspaces and runs fslite-command verbs against a local database, in-memory database, or remote fslite-server.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
use std::process::Command;

/// Every test in this file gets its own isolated `FSLITE_CONFIG_DIR` (a
/// fresh temp directory) so `create`/`delete`/`use`'s registry/context
/// state never leaks between tests or touches a real `$HOME`.
struct Fixture {
    config_dir: tempfile::TempDir,
    db_dir: tempfile::TempDir,
}

impl Fixture {
    fn new() -> Self {
        Self {
            config_dir: tempfile::tempdir().unwrap(),
            db_dir: tempfile::tempdir().unwrap(),
        }
    }

    fn cli(&self) -> Command {
        let mut command = Command::new(env!("CARGO_BIN_EXE_fslite"));
        command.env("FSLITE_CONFIG_DIR", self.config_dir.path());
        command
    }

    fn db_path(&self, name: &str) -> String {
        self.db_dir.path().join(name).to_str().unwrap().to_string()
    }
}

#[test]
fn create_use_and_verb_dispatch_end_to_end() {
    let fixture = Fixture::new();
    let db_path = fixture.db_path("main.db");

    let create = fixture
        .cli()
        .args([
            "create",
            "filesystem-main",
            "-f",
            &db_path,
            "-w",
            "workspace-main",
        ])
        .output()
        .unwrap();
    assert!(
        create.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&create.stderr)
    );
    let create_stdout = String::from_utf8(create.stdout).unwrap();
    assert!(create_stdout.contains("filesystem-main"));
    assert!(create_stdout.contains("workspace-main"));

    let use_cmd = fixture
        .cli()
        .args(["use", "filesystem-main", "-w", "workspace-main"])
        .output()
        .unwrap();
    assert!(
        use_cmd.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&use_cmd.stderr)
    );

    let mkdir = fixture.cli().args(["mkdir", "/docs"]).output().unwrap();
    assert!(
        mkdir.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&mkdir.stderr)
    );

    let write = fixture
        .cli()
        .args(["write", "/docs/a.txt", "--text=hello context"])
        .output()
        .unwrap();
    assert!(
        write.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&write.stderr)
    );

    let cat = fixture.cli().args(["cat", "/docs/a.txt"]).output().unwrap();
    assert!(cat.status.success());
    assert_eq!(
        String::from_utf8(cat.stdout).unwrap().trim(),
        "hello context"
    );
}

#[test]
fn create_refuses_a_duplicate_name() {
    let fixture = Fixture::new();
    let db_path = fixture.db_path("main.db");

    let first = fixture
        .cli()
        .args(["create", "filesystem-main", "-f", &db_path])
        .output()
        .unwrap();
    assert!(first.status.success());

    let second_db_path = fixture.db_path("other.db");
    let second = fixture
        .cli()
        .args(["create", "filesystem-main", "-f", &second_db_path])
        .output()
        .unwrap();
    assert!(!second.status.success());
    assert!(String::from_utf8_lossy(&second.stderr).contains("already registered"));
}

#[test]
fn create_refuses_to_overwrite_an_existing_file() {
    let fixture = Fixture::new();
    let db_path = fixture.db_path("main.db");
    std::fs::write(&db_path, b"not a real database").unwrap();

    let create = fixture
        .cli()
        .args(["create", "filesystem-main", "-f", &db_path])
        .output()
        .unwrap();
    assert!(!create.status.success());
    assert!(String::from_utf8_lossy(&create.stderr).contains("already exists"));
}

#[test]
fn delete_without_yes_requires_typed_confirmation() {
    let fixture = Fixture::new();
    let db_path = fixture.db_path("main.db");
    fixture
        .cli()
        .args(["create", "filesystem-main", "-f", &db_path])
        .output()
        .unwrap();

    let mut delete = fixture
        .cli()
        .args(["delete", "filesystem-main"])
        .stdin(std::process::Stdio::piped())
        .stdout(std::process::Stdio::piped())
        .stderr(std::process::Stdio::piped())
        .spawn()
        .unwrap();
    use std::io::Write;
    delete
        .stdin
        .as_mut()
        .unwrap()
        .write_all(b"wrong-name\n")
        .unwrap();
    let output = delete.wait_with_output().unwrap();
    assert!(!output.status.success());
    assert!(
        std::path::Path::new(&db_path).exists(),
        "file must survive a mismatched confirmation"
    );
}

#[test]
fn delete_yes_skips_confirmation_and_removes_the_file() {
    let fixture = Fixture::new();
    let db_path = fixture.db_path("main.db");
    fixture
        .cli()
        .args(["create", "filesystem-main", "-f", &db_path])
        .output()
        .unwrap();

    let delete = fixture
        .cli()
        .args(["delete", "filesystem-main", "-y"])
        .output()
        .unwrap();
    assert!(
        delete.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&delete.stderr)
    );
    assert!(!std::path::Path::new(&db_path).exists());
}

#[test]
fn delete_clears_a_matching_context_so_later_verbs_fail_clearly() {
    let fixture = Fixture::new();
    let db_path = fixture.db_path("main.db");
    fixture
        .cli()
        .args([
            "create",
            "filesystem-main",
            "-f",
            &db_path,
            "-w",
            "workspace-main",
        ])
        .output()
        .unwrap();
    fixture
        .cli()
        .args(["use", "filesystem-main", "-w", "workspace-main"])
        .output()
        .unwrap();
    fixture
        .cli()
        .args(["delete", "filesystem-main", "-y"])
        .output()
        .unwrap();

    let mkdir = fixture.cli().args(["mkdir", "/docs"]).output().unwrap();
    assert!(!mkdir.status.success());
    assert!(
        String::from_utf8_lossy(&mkdir.stderr).contains("no filesystem selected"),
        "stderr: {}",
        String::from_utf8_lossy(&mkdir.stderr)
    );
}

#[test]
fn explicit_db_and_workspace_flags_bypass_context_entirely() {
    // Regression guard for the plan's core backward-compatibility claim:
    // an explicit --db/--workspace invocation must work identically
    // whether or not any context/registry state exists at all.
    let fixture = Fixture::new();
    let db_path = fixture.db_path("standalone.db");

    let create = fixture
        .cli()
        .args(["--db", &db_path, "--create-workspace"])
        .output()
        .unwrap();
    assert!(create.status.success());
    let workspace_id = String::from_utf8(create.stdout).unwrap().trim().to_string();

    let mkdir = fixture
        .cli()
        .args([
            "--db",
            &db_path,
            "--workspace",
            &workspace_id,
            "mkdir",
            "/docs",
        ])
        .output()
        .unwrap();
    assert!(
        mkdir.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&mkdir.stderr)
    );
}

#[test]
fn explicit_filesystem_and_workspace_names_bypass_the_persisted_context() {
    // Regression test for the finding where `resolve_workspace` fell back
    // to the *persisted context's* workspace name even when the
    // filesystem name came from an explicit `--filesystem` override on
    // this invocation, silently pairing the wrong workspace with the
    // right filesystem. Creates two named filesystems with different
    // workspaces, `use`s one, then writes through an explicit
    // `--filesystem <other> --workspace <other-workspace-name>` override
    // and confirms it landed in the *other* filesystem, not the one set
    // via `use`.
    let fixture = Fixture::new();
    let db_path1 = fixture.db_path("fs1.db");
    let db_path2 = fixture.db_path("fs2.db");

    let create1 = fixture
        .cli()
        .args(["create", "fs1", "-f", &db_path1, "-w", "ws1"])
        .output()
        .unwrap();
    assert!(
        create1.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&create1.stderr)
    );

    let create2 = fixture
        .cli()
        .args(["create", "fs2", "-f", &db_path2, "-w", "ws2"])
        .output()
        .unwrap();
    assert!(
        create2.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&create2.stderr)
    );

    let use_cmd = fixture
        .cli()
        .args(["use", "fs1", "-w", "ws1"])
        .output()
        .unwrap();
    assert!(
        use_cmd.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&use_cmd.stderr)
    );

    // Write via the explicit override — must land in fs2/ws2, not the
    // `use`'d fs1/ws1.
    let write = fixture
        .cli()
        .args([
            "--filesystem",
            "fs2",
            "--workspace",
            "ws2",
            "write",
            "/only-in-fs2.txt",
            "--text=override worked",
        ])
        .output()
        .unwrap();
    assert!(
        write.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&write.stderr)
    );

    // Reading back through the same override sees it.
    let cat_override = fixture
        .cli()
        .args([
            "--filesystem",
            "fs2",
            "--workspace",
            "ws2",
            "cat",
            "/only-in-fs2.txt",
        ])
        .output()
        .unwrap();
    assert!(
        cat_override.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&cat_override.stderr)
    );
    assert_eq!(
        String::from_utf8(cat_override.stdout).unwrap().trim(),
        "override worked"
    );

    // The `use`'d filesystem (fs1/ws1, reached via the persisted context,
    // no override flags) does not have the file.
    let cat_context = fixture
        .cli()
        .args(["cat", "/only-in-fs2.txt"])
        .output()
        .unwrap();
    assert!(
        !cat_context.status.success(),
        "expected fs1 (the `use`'d filesystem) to not contain the file written via the fs2 override"
    );
}

#[test]
fn explicit_filesystem_without_explicit_workspace_and_a_different_persisted_context_errors_clearly()
{
    // Regression test for the exact scenario the finding described:
    // `use fs1 -w ws1`, then `--filesystem fs2` alone (no --workspace).
    // Before the fix this silently resolved workspace `ws1` (from the
    // persisted context) against `fs2` (the explicit override), producing
    // a misleading "the active workspace ... is no longer registered"
    // error that sounded like data was deleted. After the fix, this must
    // be a clear, distinct error telling the user --workspace is required
    // alongside an explicit --filesystem.
    let fixture = Fixture::new();
    let db_path1 = fixture.db_path("fs1.db");
    let db_path2 = fixture.db_path("fs2.db");

    fixture
        .cli()
        .args(["create", "fs1", "-f", &db_path1, "-w", "ws1"])
        .output()
        .unwrap();
    fixture
        .cli()
        .args(["create", "fs2", "-f", &db_path2, "-w", "ws2"])
        .output()
        .unwrap();
    fixture
        .cli()
        .args(["use", "fs1", "-w", "ws1"])
        .output()
        .unwrap();

    let ls = fixture
        .cli()
        .args(["--filesystem", "fs2", "ls", "/"])
        .output()
        .unwrap();
    assert!(
        !ls.status.success(),
        "expected --filesystem without --workspace to fail, not silently resolve ws1 against fs2"
    );
    let stderr = String::from_utf8_lossy(&ls.stderr);
    assert!(
        !stderr.contains("is no longer registered"),
        "got the old misleading error text, expected the new clear one: {stderr}"
    );
    assert!(
        stderr.contains("--filesystem") && stderr.contains("fs2") && stderr.contains("--workspace"),
        "expected a clear error naming --filesystem, fs2, and --workspace, got: {stderr}"
    );
}

/// Regression test for the finding that `create_filesystem`/
/// `delete_filesystem` printed raw, unescaped `.display()`/`.join()`
/// output to stdout while every other user-controlled string in this file
/// already went through `{name:?}` (Debug, which escapes control bytes).
/// A filesystem name containing a raw ESC byte therefore reached the
/// CLI's own stdout unsanitized via `create`'s "created filesystem ... at
/// <path>" line and `delete`'s confirmation prompt. Mirrors the pattern in
/// `e2e_local.rs`'s `one_shot_mode_never_writes_a_raw_escape_byte_to_stderr_on_error`.
#[test]
fn create_and_delete_never_write_a_raw_escape_byte_to_stdout() {
    let fixture = Fixture::new();
    let db_path = fixture.db_path("main.db");
    let hostile_name = "fs\x1b[31mFAKE\x1b[0mname";

    let create = fixture
        .cli()
        .args(["create", hostile_name, "-f", &db_path, "-w", "ws1"])
        .output()
        .unwrap();
    assert!(
        create.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&create.stderr)
    );
    assert!(
        !create.stdout.contains(&0x1b),
        "raw ESC byte reached stdout on create: {:?}",
        String::from_utf8_lossy(&create.stdout)
    );

    let delete = fixture
        .cli()
        .args(["delete", hostile_name, "-y"])
        .output()
        .unwrap();
    assert!(
        delete.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&delete.stderr)
    );
    assert!(
        !delete.stdout.contains(&0x1b),
        "raw ESC byte reached stdout on delete: {:?}",
        String::from_utf8_lossy(&delete.stdout)
    );
}

/// Sibling of `create_and_delete_never_write_a_raw_escape_byte_to_stdout`
/// specifically exercising `delete`'s interactive confirmation prompt
/// (the `-y`-skipped codepath), which prints the registered *workspace
/// names* via `.join(", ")` — the other unsanitized site the finding
/// called out.
#[test]
fn delete_confirmation_prompt_never_writes_a_raw_escape_byte_to_stdout() {
    let fixture = Fixture::new();
    let db_path = fixture.db_path("main.db");
    let hostile_workspace_name = "ws\x1b[31mFAKE\x1b[0mname";

    let create = fixture
        .cli()
        .args([
            "create",
            "filesystem-main",
            "-f",
            &db_path,
            "-w",
            hostile_workspace_name,
        ])
        .output()
        .unwrap();
    assert!(
        create.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&create.stderr)
    );

    let mut delete = fixture
        .cli()
        .args(["delete", "filesystem-main"])
        .stdin(std::process::Stdio::piped())
        .stdout(std::process::Stdio::piped())
        .stderr(std::process::Stdio::piped())
        .spawn()
        .unwrap();
    use std::io::Write;
    delete
        .stdin
        .as_mut()
        .unwrap()
        .write_all(b"filesystem-main\n")
        .unwrap();
    let output = delete.wait_with_output().unwrap();
    assert!(
        output.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    assert!(
        !output.stdout.contains(&0x1b),
        "raw ESC byte reached stdout from delete's confirmation prompt: {:?}",
        String::from_utf8_lossy(&output.stdout)
    );
}