fsci-conformance 0.3.0

Differential conformance testing harness for FrankenSciPy
#![forbid(unsafe_code)]
//! Live SciPy differential coverage for the nonparametric
//! population-quantile test
//! `scipy.stats.quantile_test(x, q=q, p=p)`.
//!
//! Resolves [frankenscipy-31omx]. Cross-checks the test
//! statistic count and the two-sided p-value (binomial
//! distribution-based) across 3 datasets × 5 (q, p) configs.
//!
//! 3 fixtures × 5 configs × 2 arms (statistic + pvalue) = 30
//! cases via subprocess. Tol 1e-12 abs (closed-form
//! binomial pmf sums). Statistic compared as integer count.

use std::collections::{BTreeMap, HashMap};
use std::fs;
use std::io::Write;
use std::path::PathBuf;
use std::process::Stdio;
use std::time::{Instant, SystemTime, UNIX_EPOCH};

use fsci_conformance::{ArmCounts, CompareLedger};
use fsci_stats::quantile_test;
use serde::{Deserialize, Serialize};

const PACKET_ID: &str = "FSCI-P2C-007";
const PVAL_TOL: f64 = 1.0e-12;
const REQUIRE_SCIPY_ENV: &str = "FSCI_REQUIRE_SCIPY_ORACLE";

#[derive(Debug, Clone, Serialize)]
struct PointCase {
    case_id: String,
    data: Vec<f64>,
    q: f64,
    p: f64,
}

#[derive(Debug, Clone, Serialize)]
struct OracleQuery {
    points: Vec<PointCase>,
}

#[derive(Debug, Clone, Deserialize)]
struct PointArm {
    case_id: String,
    statistic: Option<i64>,
    pvalue: Option<f64>,
}

#[derive(Debug, Clone, Deserialize)]
struct OracleResult {
    points: Vec<PointArm>,
}

#[derive(Debug, Clone, Serialize)]
struct CaseDiff {
    case_id: String,
    arm: String,
    abs_diff: f64,
    pass: bool,
}

#[derive(Debug, Clone, Serialize)]
struct DiffLog {
    test_id: String,
    category: String,
    case_count: usize,
    compared: BTreeMap<String, ArmCounts>,
    max_abs_diff: f64,
    pass: bool,
    timestamp_ms: u128,
    duration_ns: u128,
    cases: Vec<CaseDiff>,
}

fn output_dir() -> PathBuf {
    PathBuf::from(env!("CARGO_MANIFEST_DIR")).join(format!("fixtures/artifacts/{PACKET_ID}/diff"))
}

fn ensure_output_dir() {
    fs::create_dir_all(output_dir()).expect("create quantile_test diff output dir");
}

fn timestamp_ms() -> u128 {
    SystemTime::now()
        .duration_since(UNIX_EPOCH)
        .map_or(0, |d| d.as_millis())
}

fn emit_log(log: &DiffLog) {
    ensure_output_dir();
    let path = output_dir().join(format!("{}.json", log.test_id));
    let json = serde_json::to_string_pretty(log).expect("serialize quantile_test diff log");
    fs::write(path, json).expect("write quantile_test diff log");
}

fn generate_query() -> OracleQuery {
    let datasets: Vec<(&str, Vec<f64>)> = vec![
        ("compact", (1..=20).map(|i| i as f64).collect()),
        (
            "spread",
            vec![
                -3.0, -1.5, -0.7, 0.0, 0.5, 1.2, 2.0, 3.5, 4.7, 6.0, 8.5, 12.0, 15.0, 20.0, 25.0,
                30.0,
            ],
        ),
        (
            "ties",
            vec![
                1.0, 2.0, 2.0, 3.0, 3.0, 3.0, 4.0, 4.0, 5.0, 5.0, 6.0, 7.0, 8.0,
            ],
        ),
    ];
    // (q, p) configs — H0: p-th quantile equals q
    let configs: &[(&str, f64, f64)] = &[
        ("q5_p25", 5.0, 0.25),
        ("q10_p50", 10.0, 0.50),
        ("q15_p75", 15.0, 0.75),
        ("q3_p10", 3.0, 0.10),
        ("q3_p50", 3.0, 0.50),
    ];

    let mut points = Vec::new();
    for (name, data) in &datasets {
        for (cname, q, p) in configs {
            points.push(PointCase {
                case_id: format!("{name}_{cname}"),
                data: data.clone(),
                q: *q,
                p: *p,
            });
        }
    }
    OracleQuery { points }
}

fn scipy_oracle_or_skip(query: &OracleQuery) -> Option<OracleResult> {
    let script = r#"
import json
import math
import sys
import numpy as np
from scipy import stats

def fnone(v):
    try:
        v = float(v)
    except Exception:
        return None
    return v if math.isfinite(v) else None

q = json.load(sys.stdin)
points = []
for case in q["points"]:
    cid = case["case_id"]
    data = np.array(case["data"], dtype=float)
    qv = float(case["q"]); pv = float(case["p"])
    val_stat = None; val_p = None
    try:
        res = stats.quantile_test(data, q=qv, p=pv)
        val_stat = int(res.statistic)
        val_p = fnone(res.pvalue)
    except Exception:
        pass
    points.append({"case_id": cid, "statistic": val_stat, "pvalue": val_p})
print(json.dumps({"points": points}))
"#;
    let query_json = serde_json::to_string(query).expect("serialize quantile_test query");
    let mut child = match fsci_conformance::scipy_oracle_command()
        .arg("-c")
        .arg(script)
        .stdin(Stdio::piped())
        .stdout(Stdio::piped())
        .stderr(Stdio::piped())
        .spawn()
    {
        Ok(c) => c,
        Err(e) => {
            assert!(
                std::env::var(REQUIRE_SCIPY_ENV).is_err(),
                "failed to spawn python3 for quantile_test oracle: {e}"
            );
            eprintln!("skipping quantile_test oracle: python3 not available ({e})");
            return None;
        }
    };
    {
        let stdin = child
            .stdin
            .as_mut()
            .expect("open quantile_test oracle stdin");
        if let Err(err) = stdin.write_all(query_json.as_bytes()) {
            let output = child.wait_with_output().expect("wait for failed oracle");
            let stderr = String::from_utf8_lossy(&output.stderr);
            assert!(
                std::env::var(REQUIRE_SCIPY_ENV).is_err(),
                "quantile_test oracle stdin write failed: {err}; stderr: {stderr}"
            );
            eprintln!("skipping quantile_test oracle: stdin write failed ({err})\n{stderr}");
            return None;
        }
    }
    let output = child
        .wait_with_output()
        .expect("wait for quantile_test oracle");
    if !output.status.success() {
        let stderr = String::from_utf8_lossy(&output.stderr);
        assert!(
            std::env::var(REQUIRE_SCIPY_ENV).is_err(),
            "quantile_test oracle failed: {stderr}"
        );
        eprintln!("skipping quantile_test oracle: scipy not available\n{stderr}");
        return None;
    }
    let stdout = String::from_utf8_lossy(&output.stdout);
    Some(serde_json::from_str(&stdout).expect("parse quantile_test oracle JSON"))
}

#[test]
fn diff_stats_quantile_test() {
    let query = generate_query();
    let Some(oracle) = scipy_oracle_or_skip(&query) else {
        return;
    };
    assert_eq!(oracle.points.len(), query.points.len());

    let pmap: HashMap<String, PointArm> = oracle
        .points
        .into_iter()
        .map(|r| (r.case_id.clone(), r))
        .collect();

    let start = Instant::now();
    let mut diffs = Vec::new();
    let mut max_overall = 0.0_f64;
    let mut ledger = CompareLedger::new("diff_stats_quantile_test", &["statistic", "pvalue"]);

    for case in &query.points {
        let scipy_arm = pmap.get(&case.case_id).expect("validated oracle");
        let result = quantile_test(&case.data, case.q, case.p);

        if let Some((scipy_stat, rust_stat)) = ledger.both(
            "statistic",
            &case.case_id,
            scipy_arm.statistic,
            Some(result.statistic),
        ) {
            let abs_diff = (rust_stat as i64 - scipy_stat).unsigned_abs() as f64;
            max_overall = max_overall.max(abs_diff);
            ledger.compared("statistic", &case.case_id, abs_diff <= PVAL_TOL);
            diffs.push(CaseDiff {
                case_id: case.case_id.clone(),
                arm: "statistic".into(),
                abs_diff,
                pass: abs_diff <= PVAL_TOL,
            });
        }
        if let Some((scipy_p, rust_p)) = ledger.pair(
            "pvalue",
            &case.case_id,
            scipy_arm.pvalue,
            Some(result.pvalue),
        ) {
            let abs_diff = (rust_p - scipy_p).abs();
            max_overall = max_overall.max(abs_diff);
            ledger.compared("pvalue", &case.case_id, abs_diff <= PVAL_TOL);
            diffs.push(CaseDiff {
                case_id: case.case_id.clone(),
                arm: "pvalue".into(),
                abs_diff,
                pass: abs_diff <= PVAL_TOL,
            });
        }
    }

    let all_pass = diffs.iter().all(|d| d.pass);

    let log = DiffLog {
        test_id: "diff_stats_quantile_test".into(),
        category: "scipy.stats.quantile_test".into(),
        case_count: diffs.len(),
        compared: ledger.counts().clone(),
        max_abs_diff: max_overall,
        pass: all_pass,
        timestamp_ms: timestamp_ms(),
        duration_ns: start.elapsed().as_nanos(),
        cases: diffs.clone(),
    };

    emit_log(&log);

    for d in &diffs {
        if !d.pass {
            eprintln!(
                "quantile_test mismatch: {} arm={} abs={}",
                d.case_id, d.arm, d.abs_diff
            );
        }
    }

    assert!(
        all_pass,
        "quantile_test conformance failed: {} cases, max_abs={}",
        diffs.len(),
        max_overall
    );
    ledger.finish(query.points.len());
}