1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
//! Server-side OIDC client for PKCE authorization code flows.
//!
//! This is a minimal, runtime-facing client that:
//! 1. Builds the OIDC `/authorize` redirect URL with PKCE parameters.
//! 2. Exchanges the authorization code + `code_verifier` for tokens.
//!
//! It is intentionally separate from the more general [`crate::oauth::OAuth2Client`] and
//! [`crate::oauth::OIDCClient`] types in `oauth`: those carry JWKS caches and session
//! management state that the PKCE route handlers do not need.
// The client secret is loaded from the environment at runtime and is NEVER
// stored in the compiled schema or TOML config.
use std::{fmt, sync::Arc};
use serde::Deserialize;
use zeroize::Zeroizing;
// ---------------------------------------------------------------------------
// Token response from the provider
// ---------------------------------------------------------------------------
/// Minimal token response from the OIDC `/token` endpoint.
#[derive(Debug, Deserialize)]
pub struct OidcTokenResponse {
/// The access token.
pub access_token: String,
/// The OpenID Connect identity token (if requested).
pub id_token: Option<String>,
/// Seconds until the access token expires.
pub expires_in: Option<u64>,
/// Refresh token (if the provider issued one).
pub refresh_token: Option<String>,
}
// ---------------------------------------------------------------------------
// OidcServerClient
// ---------------------------------------------------------------------------
/// Minimal OIDC client for server-side PKCE code exchange.
///
/// Constructed once at server startup from the compiled schema.
/// The client secret is read from the environment at that time and
/// held in memory — it is never written to disk or emitted in logs.
pub struct OidcServerClient {
client_id: String,
/// Intentionally private: the secret must never be accessible via a field.
/// Stored as `Zeroizing<String>` so the key material is wiped from memory
/// when this struct is dropped.
pub(crate) client_secret: Zeroizing<String>,
server_redirect_uri: String,
authorization_endpoint: String,
token_endpoint: String,
}
/// Custom `Debug` implementation that redacts the client secret.
#[allow(clippy::missing_fields_in_debug)] // Reason: endpoint fields omitted to keep debug concise and avoid leaking config in logs
impl fmt::Debug for OidcServerClient {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
f.debug_struct("OidcServerClient")
.field("client_id", &self.client_id)
.field("client_secret", &"[REDACTED]")
.field("authorization_endpoint", &self.authorization_endpoint)
.finish_non_exhaustive()
}
}
impl OidcServerClient {
/// Maximum byte length for an inbound PKCE `code_verifier` (RFC 7636 §4.1).
///
/// Values longer than 128 characters exceed the RFC ceiling; rejecting them
/// before the outbound token request prevents log injection and memory
/// exhaustion on the provider side.
pub(crate) const MAX_CODE_VERIFIER_BYTES: usize = 128;
/// Maximum byte size accepted from the OIDC token endpoint response.
///
/// A well-formed token response is a few KiB at most. 1 MiB prevents a
/// malicious or compromised OIDC provider from exhausting server memory.
pub(crate) const MAX_OIDC_RESPONSE_BYTES: usize = 1024 * 1024;
/// Minimum byte length for an inbound PKCE `code_verifier` (RFC 7636 §4.1).
///
/// RFC 7636 mandates that the code verifier be between 43 and 128 characters.
/// Rejecting values below this floor prevents malformed verifiers — which
/// a browser extension or man-in-the-browser attack might supply — from
/// reaching the upstream OIDC provider.
pub(crate) const MIN_CODE_VERIFIER_BYTES: usize = 43;
/// Construct a client directly from resolved credentials and endpoints.
///
/// Prefer [`Self::from_compiled_schema`] in production code.
/// This constructor exists for testing and direct wiring.
pub fn new(
client_id: impl Into<String>,
client_secret: impl Into<String>,
server_redirect_uri: impl Into<String>,
authorization_endpoint: impl Into<String>,
token_endpoint: impl Into<String>,
) -> Self {
Self {
client_id: client_id.into(),
client_secret: Zeroizing::new(client_secret.into()),
server_redirect_uri: server_redirect_uri.into(),
authorization_endpoint: authorization_endpoint.into(),
token_endpoint: token_endpoint.into(),
}
}
/// Build an `OidcServerClient` from the compiled schema JSON, resolving the
/// OIDC endpoints by fetching the provider's discovery document **at boot**
/// (#621).
///
/// The compiled `auth` object carries only the client identity and the
/// provider's `discovery_url`; `authorization_endpoint` / `token_endpoint` are
/// resolved here from `discovery_url/.well-known/openid-configuration` under the
/// shared SSRF guards. This keeps the compiler hermetic (no network at compile
/// time) and the endpoints always fresh (no cached discovery going stale).
///
/// Returns `None` if:
/// - `schema_json["auth"]["pkce"]` is absent or malformed, or
/// - the env var named by `client_secret_env` is not set, or
/// - the discovery document cannot be fetched or parsed.
///
/// In all failure cases an explanatory `tracing::error!` is emitted so
/// operators can diagnose startup issues without reading source code.
pub async fn from_compiled_schema(schema_json: &serde_json::Value) -> Option<Arc<Self>> {
// ── Load the [auth] PKCE group (compiled `auth.pkce`, #621/#368) ──
#[derive(Deserialize)]
struct AuthCfg {
discovery_url: String,
client_id: String,
client_secret_env: String,
server_redirect_uri: String,
}
let auth_cfg: AuthCfg = schema_json
.get("auth")
.and_then(|v| v.get("pkce"))
.and_then(|v| serde_json::from_value(v.clone()).ok())?;
// ── Read client secret from env ───────────────────────────────────
let Ok(client_secret) = std::env::var(&auth_cfg.client_secret_env) else {
tracing::error!(
env_var = %auth_cfg.client_secret_env,
"PKCE init failed: env var for OIDC client secret is not set"
);
return None;
};
// ── Resolve endpoints via boot-time discovery (#621) ──────────────
let discovery =
match crate::oidc_provider::fetch_oidc_discovery(&auth_cfg.discovery_url).await {
Ok(discovery) => discovery,
Err(e) => {
tracing::error!(
error = %e,
discovery_url = %auth_cfg.discovery_url,
"PKCE init failed: could not resolve the OIDC discovery document at boot. \
Check [auth] discovery_url and network reachability of the provider."
);
return None;
},
};
Some(Arc::new(Self {
client_id: auth_cfg.client_id,
client_secret: Zeroizing::new(client_secret),
server_redirect_uri: auth_cfg.server_redirect_uri,
authorization_endpoint: discovery.authorization_endpoint,
token_endpoint: discovery.token_endpoint,
}))
}
/// Build the OIDC `/authorize` redirect URL with all required PKCE params.
///
/// The `state`, `code_challenge`, and `redirect_uri` values are
/// percent-encoded so that base64-url characters (+, /, =) do not
/// break query string parsing on the provider side.
#[must_use]
pub fn authorization_url(
&self,
state: &str,
code_challenge: &str,
code_challenge_method: &str,
) -> String {
format!(
"{}?response_type=code\
&client_id={}\
&redirect_uri={}\
&scope=openid%20email%20profile\
&state={}\
&code_challenge={}\
&code_challenge_method={}",
self.authorization_endpoint,
urlencoding::encode(&self.client_id),
urlencoding::encode(&self.server_redirect_uri),
urlencoding::encode(state),
urlencoding::encode(code_challenge),
code_challenge_method,
)
}
// 1 MiB
/// Exchange an authorization code for tokens.
///
/// Sends a `POST` to the provider's `/token` endpoint with the PKCE
/// `code_verifier` and all required OAuth2 fields.
///
/// # Errors
///
/// Returns an error if the HTTP request fails, the provider returns a
/// non-success status, the response exceeds `MAX_OIDC_RESPONSE_BYTES`, or
/// the response body cannot be parsed as JSON.
pub async fn exchange_code(
&self,
code: &str,
code_verifier: &str,
http: &reqwest::Client,
) -> Result<OidcTokenResponse, anyhow::Error> {
// SECURITY: RFC 7636 §4.1 mandates 43–128 ASCII characters for code_verifier.
// Reject out-of-range values before they reach the upstream OIDC provider.
anyhow::ensure!(
code_verifier.len() >= Self::MIN_CODE_VERIFIER_BYTES,
"code_verifier too short ({} bytes, min {})",
code_verifier.len(),
Self::MIN_CODE_VERIFIER_BYTES,
);
anyhow::ensure!(
code_verifier.len() <= Self::MAX_CODE_VERIFIER_BYTES,
"code_verifier too long ({} bytes, max {})",
code_verifier.len(),
Self::MAX_CODE_VERIFIER_BYTES,
);
let resp = http
.post(&self.token_endpoint)
.form(&[
("grant_type", "authorization_code"),
("code", code),
("code_verifier", code_verifier),
("redirect_uri", self.server_redirect_uri.as_str()),
("client_id", self.client_id.as_str()),
("client_secret", self.client_secret.as_str()),
])
.send()
.await?;
let status = resp.status();
// Read body with error propagation — unwrap_or_default() would silently
// discard network errors and return an empty body, masking failures.
let body_bytes = resp
.bytes()
.await
.map_err(|e| anyhow::anyhow!("Failed to read token response: {e}"))?;
// Size guard BEFORE the status check: a compromised provider could exhaust
// memory by sending an oversized non-2xx response that bypassed a later cap.
anyhow::ensure!(
body_bytes.len() <= Self::MAX_OIDC_RESPONSE_BYTES,
"OIDC token response too large ({} bytes, max {})",
body_bytes.len(),
Self::MAX_OIDC_RESPONSE_BYTES
);
if !status.is_success() {
// Body is already bounded by the size check above — no need for .min().
let body = String::from_utf8_lossy(&body_bytes);
anyhow::bail!("token endpoint returned {status}: {body}");
}
Ok(serde_json::from_slice::<OidcTokenResponse>(&body_bytes)?)
}
}
// ---------------------------------------------------------------------------
// Unit tests
// ---------------------------------------------------------------------------