forjar 1.4.2

Rust-native Infrastructure as Code — bare-metal first, BLAKE3 state, provenance tracing
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399

//! FJ-013/1270/266: State management, integrity, and process locking falsification.
//!
//! Popperian rejection criteria for:
//! - FJ-013: Lock file load/save/atomic write, global lock, new_lock
//!   - lock_file_path derivation
//!   - save_lock / load_lock roundtrip
//!   - save_global_lock / load_global_lock roundtrip
//!   - new_lock fields
//!   - new_global_lock fields
//!   - load_lock returns None for missing file
//!   - save_apply_report / load_apply_report roundtrip
//! - FJ-1270: State integrity via BLAKE3 sidecar
//!   - write_b3_sidecar creates sidecar file
//!   - verify_state_integrity: all pass, missing sidecar, hash mismatch
//!   - has_errors predicate
//! - FJ-266: Process locking
//!   - acquire/release process lock roundtrip
//!   - force_unlock
//!
//! Usage: cargo test --test falsification_state_integrity

use forjar::core::state;
use forjar::core::state::integrity;
use forjar::core::types::{ApplyResult, ResourceReport, StateLock};

// ============================================================================
// Helpers
// ============================================================================

fn make_state_dir() -> (tempfile::TempDir, std::path::PathBuf) {
    let dir = tempfile::tempdir().unwrap();
    let state_dir = dir.path().join("state");
    std::fs::create_dir_all(&state_dir).unwrap();
    (dir, state_dir)
}

fn sample_lock(machine: &str) -> StateLock {
    state::new_lock(machine, &format!("{machine}-01"))
}

// ============================================================================
// FJ-013: lock_file_path
// ============================================================================

#[test]
fn lock_file_path_derivation() {
    let path = state::lock_file_path(std::path::Path::new("/state"), "web");
    assert_eq!(path, std::path::PathBuf::from("/state/web/state.lock.yaml"));
}

#[test]
fn lock_file_path_nested_machine() {
    let path = state::lock_file_path(std::path::Path::new("/data/state"), "db-primary");
    assert_eq!(
        path,
        std::path::PathBuf::from("/data/state/db-primary/state.lock.yaml")
    );
}

// ============================================================================
// FJ-013: new_lock
// ============================================================================

#[test]
fn new_lock_fields() {
    let lock = state::new_lock("web", "web-01");
    assert_eq!(lock.machine, "web");
    assert_eq!(lock.hostname, "web-01");
    assert_eq!(lock.schema, "1.0");
    assert!(!lock.generated_at.is_empty());
    assert!(lock.generator.starts_with("forjar"));
    assert!(lock.resources.is_empty());
}

// ============================================================================
// FJ-013: save_lock / load_lock roundtrip
// ============================================================================

#[test]
fn save_load_lock_roundtrip() {
    let (_dir, state_dir) = make_state_dir();
    let lock = sample_lock("web");

    state::save_lock(&state_dir, &lock).unwrap();
    let loaded = state::load_lock(&state_dir, "web").unwrap();

    assert!(loaded.is_some());
    let loaded = loaded.unwrap();
    assert_eq!(loaded.machine, "web");
    assert_eq!(loaded.hostname, "web-01");
    assert_eq!(loaded.schema, "1.0");
}

#[test]
fn load_lock_missing_returns_none() {
    let (_dir, state_dir) = make_state_dir();
    let loaded = state::load_lock(&state_dir, "nonexistent").unwrap();
    assert!(loaded.is_none());
}

#[test]
fn save_lock_creates_machine_dir() {
    let (_dir, state_dir) = make_state_dir();
    let lock = sample_lock("new-machine");

    state::save_lock(&state_dir, &lock).unwrap();
    let machine_dir = state_dir.join("new-machine");
    assert!(machine_dir.exists());
    assert!(machine_dir.join("state.lock.yaml").exists());
}

// ============================================================================
// FJ-013: global lock
// ============================================================================

#[test]
fn new_global_lock_fields() {
    let lock = state::new_global_lock("my-infra");
    assert_eq!(lock.name, "my-infra");
    assert_eq!(lock.schema, "1.0");
    assert!(!lock.last_apply.is_empty());
    assert!(lock.generator.starts_with("forjar"));
    assert!(lock.machines.is_empty());
    assert!(lock.outputs.is_empty());
}

#[test]
fn global_lock_path_derivation() {
    let path = state::global_lock_path(std::path::Path::new("/state"));
    assert_eq!(path, std::path::PathBuf::from("/state/forjar.lock.yaml"));
}

#[test]
fn save_load_global_lock_roundtrip() {
    let (_dir, state_dir) = make_state_dir();
    let lock = state::new_global_lock("test-infra");

    state::save_global_lock(&state_dir, &lock).unwrap();
    let loaded = state::load_global_lock(&state_dir).unwrap();

    assert!(loaded.is_some());
    let loaded = loaded.unwrap();
    assert_eq!(loaded.name, "test-infra");
    assert_eq!(loaded.schema, "1.0");
}

#[test]
fn load_global_lock_missing_returns_none() {
    let (_dir, state_dir) = make_state_dir();
    let loaded = state::load_global_lock(&state_dir).unwrap();
    assert!(loaded.is_none());
}

// ============================================================================
// FJ-013: update_global_lock
// ============================================================================

#[test]
fn update_global_lock_creates_machine_entries() {
    let (_dir, state_dir) = make_state_dir();
    let results = vec![("web".to_string(), 5, 5, 0), ("db".to_string(), 3, 2, 1)];
    state::update_global_lock(&state_dir, "my-infra", &results).unwrap();

    let lock = state::load_global_lock(&state_dir).unwrap().unwrap();
    assert_eq!(lock.name, "my-infra");
    assert_eq!(lock.machines.len(), 2);
    assert_eq!(lock.machines["web"].resources, 5);
    assert_eq!(lock.machines["web"].converged, 5);
    assert_eq!(lock.machines["db"].failed, 1);
}

// ============================================================================
// FJ-013: save/load apply report
// ============================================================================

#[test]
fn save_load_apply_report() {
    let (_dir, state_dir) = make_state_dir();
    let report = ApplyResult {
        machine: "web".into(),
        resources_converged: 1,
        resources_unchanged: 0,
        resources_failed: 0,
        total_duration: std::time::Duration::from_millis(500),
        resource_reports: vec![ResourceReport {
            resource_id: "pkg-nginx".into(),
            resource_type: "package".into(),
            status: "converged".into(),
            duration_seconds: 0.5,
            exit_code: Some(0),
            hash: Some("abc123".into()),
            error: None,
        }],
    };
    state::save_apply_report(&state_dir, &report).unwrap();

    let loaded = state::load_apply_report(&state_dir, "web").unwrap();
    assert!(loaded.is_some());
    let content = loaded.unwrap();
    assert!(content.contains("pkg-nginx"));
    assert!(content.contains("converged"));
}

#[test]
fn load_apply_report_missing() {
    let (_dir, state_dir) = make_state_dir();
    let loaded = state::load_apply_report(&state_dir, "nonexistent").unwrap();
    assert!(loaded.is_none());
}

// ============================================================================
// FJ-1270: BLAKE3 sidecar — write and verify
// ============================================================================

#[test]
fn write_b3_sidecar_creates_file() {
    let (_dir, state_dir) = make_state_dir();
    let lock = sample_lock("web");
    state::save_lock(&state_dir, &lock).unwrap();

    let lock_path = state::lock_file_path(&state_dir, "web");
    // save_lock already writes sidecar, but verify it exists
    let sidecar = std::path::PathBuf::from(format!("{}.b3", lock_path.display()));
    assert!(sidecar.exists(), "BLAKE3 sidecar should exist");

    let hash_content = std::fs::read_to_string(&sidecar).unwrap();
    assert_eq!(hash_content.len(), 64, "BLAKE3 hash should be 64 hex chars");
}

#[test]
fn verify_integrity_all_pass() {
    let (_dir, state_dir) = make_state_dir();
    let lock = sample_lock("web");
    state::save_lock(&state_dir, &lock).unwrap();

    let results = integrity::verify_state_integrity(&state_dir);
    assert!(
        !integrity::has_errors(&results),
        "integrity should pass: {results:?}"
    );
}

#[test]
fn verify_integrity_hash_mismatch() {
    let (_dir, state_dir) = make_state_dir();
    let lock = sample_lock("tampered");
    state::save_lock(&state_dir, &lock).unwrap();

    // Tamper with the lock file
    let lock_path = state::lock_file_path(&state_dir, "tampered");
    let mut content = std::fs::read_to_string(&lock_path).unwrap();
    content.push_str("\n# tampered\n");
    std::fs::write(&lock_path, content).unwrap();

    let results = integrity::verify_state_integrity(&state_dir);
    assert!(
        integrity::has_errors(&results),
        "integrity should detect tampered file"
    );
}

#[test]
fn verify_integrity_missing_sidecar() {
    let (_dir, state_dir) = make_state_dir();

    // Manually create lock file without sidecar
    let machine_dir = state_dir.join("no-sidecar");
    std::fs::create_dir_all(&machine_dir).unwrap();
    std::fs::write(
        machine_dir.join("state.lock.yaml"),
        "schema: \"1.0\"\nmachine: no-sidecar\nhostname: h1\ngenerated_at: now\ngenerator: test\nblake3_version: \"1.8\"\nresources: {}\n",
    )
    .unwrap();

    let results = integrity::verify_state_integrity(&state_dir);
    let has_missing = results
        .iter()
        .any(|r| matches!(r, integrity::IntegrityResult::MissingSidecar(_)));
    assert!(has_missing, "should detect missing sidecar");
    // Missing sidecar is a warning, not an error
    assert!(
        !integrity::has_errors(&results),
        "missing sidecar should not be a hard error"
    );
}

#[test]
fn verify_integrity_empty_state_dir() {
    let (_dir, state_dir) = make_state_dir();
    let results = integrity::verify_state_integrity(&state_dir);
    assert!(results.is_empty());
    assert!(!integrity::has_errors(&results));
}

#[test]
fn has_errors_false_for_ok() {
    let results = vec![integrity::IntegrityResult::Ok];
    assert!(!integrity::has_errors(&results));
}

// ============================================================================
// FJ-266: Process locking
// ============================================================================

#[test]
fn acquire_release_process_lock() {
    let (_dir, state_dir) = make_state_dir();
    state::acquire_process_lock(&state_dir).unwrap();

    // Lock file should exist
    let lock_file = state_dir.join(".forjar.lock");
    assert!(lock_file.exists());
    let content = std::fs::read_to_string(&lock_file).unwrap();
    assert!(content.contains("pid:"));

    state::release_process_lock(&state_dir);
    assert!(!lock_file.exists());
}

#[test]
fn force_unlock_removes_lock() {
    let (_dir, state_dir) = make_state_dir();
    state::acquire_process_lock(&state_dir).unwrap();
    state::force_unlock(&state_dir).unwrap();

    let lock_file = state_dir.join(".forjar.lock");
    assert!(!lock_file.exists());
}

#[test]
fn force_unlock_no_lock_file() {
    let (_dir, state_dir) = make_state_dir();
    // Should succeed even if no lock file
    state::force_unlock(&state_dir).unwrap();
}

// ============================================================================
// FJ-013: resolve_outputs
// ============================================================================

#[test]
fn resolve_outputs_empty() {
    let config = forjar::core::types::ForjarConfig {
        version: "1.0".into(),
        name: "test".into(),
        ..Default::default()
    };
    let resolved = state::resolve_outputs(&config);
    assert!(resolved.is_empty());
}

#[test]
fn resolve_outputs_with_literal() {
    let mut config = forjar::core::types::ForjarConfig {
        version: "1.0".into(),
        name: "test".into(),
        ..Default::default()
    };
    config.outputs.insert(
        "url".into(),
        forjar::core::types::OutputValue {
            value: "https://example.com".into(),
            description: None,
        },
    );
    let resolved = state::resolve_outputs(&config);
    assert_eq!(resolved["url"], "https://example.com");
}

// ============================================================================
// FJ-013: persist_outputs
// ============================================================================

#[test]
fn persist_outputs_non_ephemeral() {
    let (_dir, state_dir) = make_state_dir();
    let mut outputs = indexmap::IndexMap::new();
    outputs.insert("url".into(), "https://example.com".into());

    state::persist_outputs(&state_dir, "test", &outputs, false).unwrap();

    let lock = state::load_global_lock(&state_dir).unwrap().unwrap();
    assert_eq!(lock.outputs["url"], "https://example.com");
}

#[test]
fn persist_outputs_ephemeral_redacts() {
    let (_dir, state_dir) = make_state_dir();
    let mut outputs = indexmap::IndexMap::new();
    outputs.insert("secret_key".into(), "super-secret-value".into());

    state::persist_outputs(&state_dir, "test", &outputs, true).unwrap();

    let lock = state::load_global_lock(&state_dir).unwrap().unwrap();
    // Ephemeral mode replaces values with BLAKE3 hashes
    assert_ne!(lock.outputs["secret_key"], "super-secret-value");
    // Should be a BLAKE3 hash (64 hex chars) or redacted format
    assert!(lock.outputs["secret_key"].len() >= 10);
}