forjar 1.4.2

Rust-native Infrastructure as Code — bare-metal first, BLAKE3 state, provenance tracing
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250

//! Resilience validation — lifecycle hook coverage, secret rotation, dependency depth limits.

use crate::core::types;
use std::collections::{HashMap, HashSet, VecDeque};
use std::path::Path;

// ============================================================================
// Side-effect resource types that benefit from lifecycle hooks
// ============================================================================

const SIDE_EFFECT_TYPES: &[types::ResourceType] = &[
    types::ResourceType::Service,
    types::ResourceType::Package,
    types::ResourceType::Mount,
    types::ResourceType::Docker,
    types::ResourceType::Network,
];

/// Maximum allowed dependency chain depth.
const DEPTH_LIMIT: usize = 10;

// ============================================================================
// FJ-1022: Lifecycle hook coverage for side-effect resources
// ============================================================================

/// Warn if resources with side effects (service, package, mount, docker, network)
/// lack pre/post lifecycle hooks. These resource types modify system state and
/// benefit from hooks for safety.
pub(crate) fn cmd_validate_check_resource_lifecycle_hook_coverage(
    file: &Path,
    json: bool,
) -> Result<(), String> {
    let content = std::fs::read_to_string(file).map_err(|e| e.to_string())?;
    let config: types::ForjarConfig =
        serde_yaml_ng::from_str(&content).map_err(|e| e.to_string())?;

    let warnings = find_lifecycle_hook_coverage_gaps(&config);

    if json {
        let items: Vec<String> = warnings
            .iter()
            .map(|(name, rtype, has_pre, has_post)| {
                format!(
                    "{{\"resource\":\"{name}\",\"type\":\"{rtype}\",\"has_pre_hook\":{has_pre},\"has_post_hook\":{has_post}}}"
                )
            })
            .collect();
        println!("{{\"lifecycle_hook_warnings\":[{}]}}", items.join(","));
    } else if warnings.is_empty() {
        println!("All side-effect resources have lifecycle hooks.");
    } else {
        for (name, rtype, _, _) in &warnings {
            println!("warning: {name} ({rtype}) has no lifecycle hooks");
        }
    }
    Ok(())
}

/// Returns `(resource_name, resource_type, has_pre_hook, has_post_hook)` for
/// each side-effect resource missing at least one hook.
fn find_lifecycle_hook_coverage_gaps(
    config: &types::ForjarConfig,
) -> Vec<(String, String, bool, bool)> {
    let mut warnings = Vec::new();
    for (name, resource) in &config.resources {
        if !is_side_effect_type(&resource.resource_type) {
            continue;
        }
        let has_pre = resource.pre_apply.is_some();
        let has_post = resource.post_apply.is_some();
        if !has_pre && !has_post {
            warnings.push((
                name.clone(),
                resource.resource_type.to_string(),
                has_pre,
                has_post,
            ));
        }
    }
    warnings.sort_by(|a, b| a.0.cmp(&b.0));
    warnings
}

fn is_side_effect_type(rtype: &types::ResourceType) -> bool {
    SIDE_EFFECT_TYPES.contains(rtype)
}

// ============================================================================
// FJ-1025: Encrypted secret rotation review
// ============================================================================

/// Warn if any resource content contains `ENC[age,...]` markers (encrypted
/// secrets using age encryption). This is a static check — we cannot know the
/// actual rotation age, so we flag resources that use encrypted secrets as
/// needing rotation review.
pub(crate) fn cmd_validate_check_resource_secret_rotation_age(
    file: &Path,
    json: bool,
) -> Result<(), String> {
    let content = std::fs::read_to_string(file).map_err(|e| e.to_string())?;
    let config: types::ForjarConfig =
        serde_yaml_ng::from_str(&content).map_err(|e| e.to_string())?;

    let warnings = find_secret_rotation_warnings(&config);

    if json {
        let items: Vec<String> = warnings
            .iter()
            .map(|name| format!("{{\"resource\":\"{name}\",\"has_encrypted_content\":true}}"))
            .collect();
        println!("{{\"secret_rotation_warnings\":[{}]}}", items.join(","));
    } else if warnings.is_empty() {
        println!("No encrypted secrets found in resources.");
    } else {
        for name in &warnings {
            println!("review: {name} contains encrypted secret (rotation recommended)");
        }
    }
    Ok(())
}

/// Returns resource names whose `content` field contains `ENC[age,` markers.
fn find_secret_rotation_warnings(config: &types::ForjarConfig) -> Vec<String> {
    let mut warnings: Vec<String> = config
        .resources
        .iter()
        .filter_map(|(name, resource)| {
            resource
                .content
                .as_ref()
                .filter(|c| c.contains("ENC[age,"))
                .map(|_| name.clone())
        })
        .collect();
    warnings.sort();
    warnings
}

// ============================================================================
// FJ-1028: Dependency depth limit
// ============================================================================

/// Warn if any dependency chain exceeds the maximum depth limit (10).
/// Builds a dependency graph from `depends_on` fields and computes the
/// maximum depth for each resource via BFS from roots.
pub(crate) fn cmd_validate_check_resource_dependency_chain_depth(
    file: &Path,
    json: bool,
) -> Result<(), String> {
    let content = std::fs::read_to_string(file).map_err(|e| e.to_string())?;
    let config: types::ForjarConfig =
        serde_yaml_ng::from_str(&content).map_err(|e| e.to_string())?;

    let violations = find_depth_limit_violations(&config);

    if json {
        let items: Vec<String> = violations
            .iter()
            .map(|(name, depth)| {
                format!("{{\"resource\":\"{name}\",\"depth\":{depth},\"limit\":{DEPTH_LIMIT}}}")
            })
            .collect();
        println!("{{\"depth_limit_warnings\":[{}]}}", items.join(","));
    } else if violations.is_empty() {
        println!("All dependency chains within depth limit ({DEPTH_LIMIT}).");
    } else {
        for (name, depth) in &violations {
            println!("warning: {name} has dependency depth {depth} (limit: {DEPTH_LIMIT})");
        }
    }
    Ok(())
}

/// Returns `(resource_name, depth)` for each resource whose longest
/// dependency chain exceeds `DEPTH_LIMIT`.
fn find_depth_limit_violations(config: &types::ForjarConfig) -> Vec<(String, usize)> {
    let depths = compute_all_depths(config);
    let mut violations: Vec<(String, usize)> = depths
        .into_iter()
        .filter(|(_, depth)| *depth > DEPTH_LIMIT)
        .collect();
    violations.sort_by(|a, b| a.0.cmp(&b.0));
    violations
}

/// Compute the maximum dependency depth for every resource using BFS.
///
/// Depth of a root resource (no dependencies) is 0.
/// Depth of a resource is 1 + max(depth of each dependency).
///
/// Uses Kahn's algorithm (topological BFS) to handle the DAG efficiently
/// and safely handle cycles (cyclic resources get depth 0 — cycles are
/// reported by other validators).
fn compute_all_depths(config: &types::ForjarConfig) -> HashMap<String, usize> {
    let names: HashSet<&String> = config.resources.keys().collect();

    // Build adjacency: for each resource, its valid dependencies.
    // Also track in-degree for topological sort.
    let mut in_degree: HashMap<&String, usize> = HashMap::new();
    let mut dependents: HashMap<&String, Vec<&String>> = HashMap::new();

    for name in &names {
        in_degree.insert(name, 0);
    }

    for (name, resource) in &config.resources {
        let valid_deps: Vec<&String> = resource
            .depends_on
            .iter()
            .filter(|d| names.contains(d))
            .collect();
        *in_degree.entry(name).or_insert(0) += valid_deps.len();
        for dep in valid_deps {
            dependents.entry(dep).or_default().push(name);
        }
    }

    // Kahn's BFS: start from roots (in_degree == 0).
    let mut depths: HashMap<String, usize> = HashMap::new();
    let mut queue: VecDeque<&String> = VecDeque::new();

    for (name, &deg) in &in_degree {
        if deg == 0 {
            queue.push_back(name);
            depths.insert((*name).clone(), 0);
        }
    }

    while let Some(current) = queue.pop_front() {
        let current_depth = depths[current.as_str()];
        if let Some(deps) = dependents.get(current) {
            for dependent in deps {
                let new_depth = current_depth + 1;
                let entry = depths.entry((*dependent).clone()).or_insert(0);
                if new_depth > *entry {
                    *entry = new_depth;
                }
                let Some(deg) = in_degree.get_mut(dependent) else {
                    continue;
                };
                *deg -= 1;
                if *deg == 0 {
                    queue.push_back(dependent);
                }
            }
        }
    }

    depths
}