forjar 1.25.1

Rust-native Infrastructure as Code — bare-metal first, BLAKE3 state, provenance tracing
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400

//! Coverage tests for undo.rs — cmd_undo_resume, cmd_undo edge paths.

use crate::core::types;
use std::collections::HashMap;

// ── cmd_undo_resume: no partial undo ─────────────────────────────────

#[test]
fn undo_resume_no_partial() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(
        &cfg_path,
        "version: '1.0'\nname: t\nmachines:\n  web:\n    hostname: w\n    addr: 127.0.0.1\nresources: {}\n",
    )
    .unwrap();

    let result = super::undo::cmd_undo_resume(&cfg_path, state_dir.path(), None, false, true);
    assert!(result.is_err());
    assert!(result.unwrap_err().contains("no partial undo found"));
}

#[test]
fn undo_resume_dry_run_with_partial() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(
        &cfg_path,
        "version: '1.0'\nname: t\nmachines:\n  web:\n    hostname: w\n    addr: 127.0.0.1\nresources: {}\n",
    )
    .unwrap();

    // Write a partial undo-progress.yaml
    let mut resources = HashMap::new();
    resources.insert(
        "nginx".to_string(),
        types::ResourceProgress {
            status: types::ResourceProgressStatus::Pending,
            at: None,
        },
    );
    resources.insert(
        "app".to_string(),
        types::ResourceProgress {
            status: types::ResourceProgressStatus::Completed,
            at: Some("2026-01-01T00:00:00Z".to_string()),
        },
    );
    let progress = types::UndoProgress {
        generation_from: 5,
        generation_to: 3,
        started_at: "2026-01-01T00:00:00Z".to_string(),
        status: types::UndoStatus::Partial,
        resources,
    };
    super::undo::write_undo_progress(state_dir.path(), "web", &progress);

    let result = super::undo::cmd_undo_resume(&cfg_path, state_dir.path(), None, true, true);
    assert!(result.is_ok());
}

#[test]
fn undo_resume_no_yes_flag() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(
        &cfg_path,
        "version: '1.0'\nname: t\nmachines:\n  web:\n    hostname: w\n    addr: 127.0.0.1\nresources: {}\n",
    )
    .unwrap();

    // Write partial progress with failed resource
    let mut resources = HashMap::new();
    resources.insert(
        "nginx".to_string(),
        types::ResourceProgress {
            status: types::ResourceProgressStatus::Failed {
                error: "timeout".to_string(),
            },
            at: Some("2026-01-01T00:00:00Z".to_string()),
        },
    );
    let progress = types::UndoProgress {
        generation_from: 3,
        generation_to: 1,
        started_at: "2026-01-01T00:00:00Z".to_string(),
        status: types::UndoStatus::Partial,
        resources,
    };
    super::undo::write_undo_progress(state_dir.path(), "web", &progress);

    // Without --yes should fail
    let result = super::undo::cmd_undo_resume(&cfg_path, state_dir.path(), None, false, false);
    assert!(result.is_err());
    assert!(result.unwrap_err().contains("requires --yes"));
}

#[test]
fn undo_resume_machine_filter() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(
        &cfg_path,
        "version: '1.0'\nname: t\nmachines:\n  web:\n    hostname: w\n    addr: 127.0.0.1\n  db:\n    hostname: d\n    addr: 127.0.0.1\nresources: {}\n",
    )
    .unwrap();

    // Write progress only for db
    let mut resources = HashMap::new();
    resources.insert(
        "pg".to_string(),
        types::ResourceProgress {
            status: types::ResourceProgressStatus::Pending,
            at: None,
        },
    );
    let progress = types::UndoProgress {
        generation_from: 2,
        generation_to: 1,
        started_at: "2026-01-01T00:00:00Z".to_string(),
        status: types::UndoStatus::Partial,
        resources,
    };
    super::undo::write_undo_progress(state_dir.path(), "db", &progress);

    // Filter to web — should find no partial
    let result =
        super::undo::cmd_undo_resume(&cfg_path, state_dir.path(), Some("web"), false, true);
    assert!(result.is_err());
    assert!(result.unwrap_err().contains("no partial undo found"));

    // Filter to db — should find partial, dry_run succeeds
    let result =
        super::undo::cmd_undo_resume(&cfg_path, state_dir.path(), Some("db"), true, true);
    assert!(result.is_ok());
}

/// GH-376: `--resume` replays the generation the interrupted undo was heading
/// for, read from the ledger. It used to re-apply the CURRENT config, which is
/// the same defect `cmd_undo` had — so an operator whose first undo failed
/// halfway had one flag that put the machine back where it started.
#[test]
fn undo_resume_replays_the_ledgers_generation_not_the_current_config() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(&cfg_path, WEB_CONFIG).unwrap();

    // Generation 1 exists but recorded no config, so a resume that consults the
    // ledger must refuse. A resume that re-applies `-f` would sail past it.
    std::fs::create_dir_all(state_dir.path().join("generations/1")).unwrap();

    let mut resources = HashMap::new();
    resources.insert(
        "nginx".to_string(),
        types::ResourceProgress {
            status: types::ResourceProgressStatus::Pending,
            at: None,
        },
    );
    let progress = types::UndoProgress {
        generation_from: 2,
        generation_to: 1,
        started_at: "2026-01-01T00:00:00Z".to_string(),
        status: types::UndoStatus::Partial,
        resources,
    };
    super::undo::write_undo_progress(state_dir.path(), "web", &progress);

    let err =
        super::undo::cmd_undo_resume(&cfg_path, state_dir.path(), None, false, true).unwrap_err();
    assert!(
        err.contains("records no config"),
        "resume must consult the ledger's generation, not the current config; got: {err}"
    );
}

// ── cmd_undo: error paths ────────────────────────────────────────────

const WEB_CONFIG: &str =
    "version: '1.0'\nname: t\nmachines:\n  web:\n    hostname: w\n    addr: 127.0.0.1\nresources: {}\n";

const WEB_LOCK: &str = "schema: '1'\nmachine: web\nhostname: w\ngenerated_at: t\ngenerator: g\nblake3_version: b\nresources:\n  nginx:\n    type: package\n    status: converged\n    hash: abc123\n";

/// GH-376: a generation is only a usable undo target if it recorded the config
/// that produced it. These fixtures predate that, so they record one.
fn record_replay_config(gen: &std::path::Path) {
    std::fs::write(gen.join(".applied-config.yaml"), WEB_CONFIG).unwrap();
}

fn setup_generations(state_dir: &std::path::Path, count: u32) {
    let gen_dir = state_dir.join("generations");
    for i in 0..count {
        let g = gen_dir.join(i.to_string());
        std::fs::create_dir_all(&g).unwrap();
        record_replay_config(&g);
    }
    // Create symlink for current → last generation
    if count > 0 {
        let current = gen_dir.join("current");
        std::os::unix::fs::symlink((count - 1).to_string(), &current).unwrap();
    }
}

/// Give a generation a machine lock so it can be an undo target at all.
fn record_lock(dir: &std::path::Path, machine: &str) {
    let d = dir.join(machine);
    std::fs::create_dir_all(&d).unwrap();
    std::fs::write(d.join("state.lock.yaml"), WEB_LOCK).unwrap();
}

#[test]
fn undo_too_many_generations() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(
        &cfg_path,
        "version: '1.0'\nname: t\nmachines: {}\nresources: {}\n",
    )
    .unwrap();

    // Create 1 generation (current=0)
    setup_generations(state_dir.path(), 1);

    let result = super::undo::cmd_undo(&cfg_path, state_dir.path(), 5, None, false, true);
    assert!(result.is_err());
    assert!(
        result.unwrap_err().contains("cannot undo 5 generation(s)"),
        "expected 'cannot undo' error"
    );
}

#[test]
fn undo_target_gen_missing() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(
        &cfg_path,
        "version: '1.0'\nname: t\nmachines: {}\nresources: {}\n",
    )
    .unwrap();

    // Create gen 2 only (target=1 won't exist)
    let gen_dir = state_dir.path().join("generations");
    std::fs::create_dir_all(gen_dir.join("2")).unwrap();
    std::os::unix::fs::symlink("2", gen_dir.join("current")).unwrap();

    let result = super::undo::cmd_undo(&cfg_path, state_dir.path(), 1, None, false, true);
    assert!(result.is_err());
    assert!(
        result.unwrap_err().contains("does not exist"),
        "expected 'does not exist' error"
    );
}

#[test]
fn undo_dry_run_no_changes() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(
        &cfg_path,
        "version: '1.0'\nname: t\nmachines:\n  web:\n    hostname: w\n    addr: 127.0.0.1\nresources: {}\n",
    )
    .unwrap();

    // GH-376: the target generation and the LIVE state hold the same lock, so
    // there genuinely is nothing to undo. This is the control that fails if the
    // fix degenerates into "always re-apply the target".
    setup_generations(state_dir.path(), 2);
    record_lock(&state_dir.path().join("generations/0"), "web");
    record_lock(&state_dir.path().join("generations/1"), "web");
    record_lock(state_dir.path(), "web");

    let result = super::undo::cmd_undo(&cfg_path, state_dir.path(), 1, None, true, true);
    assert!(result.is_ok(), "already-at-target must succeed: {result:?}");
}

/// GH-376: a target generation with no recorded config cannot be replayed, and
/// undo must say so instead of quietly re-applying the CURRENT config.
#[test]
fn undo_refuses_generation_without_recorded_config() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(&cfg_path, WEB_CONFIG).unwrap();

    let gen_dir = state_dir.path().join("generations");
    for i in 0..2 {
        std::fs::create_dir_all(gen_dir.join(i.to_string())).unwrap();
    }
    std::os::unix::fs::symlink("1", gen_dir.join("current")).unwrap();

    let err = super::undo::cmd_undo(&cfg_path, state_dir.path(), 1, None, true, true).unwrap_err();
    assert!(
        err.contains("records no config"),
        "expected a refusal naming the missing snapshot, got: {err}"
    );
}

/// GH-376: an empty diff against a target that recorded no machine state is not
/// a success — undo cannot know what the host should hold.
#[test]
fn undo_refuses_target_generation_with_no_locks() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(&cfg_path, WEB_CONFIG).unwrap();

    setup_generations(state_dir.path(), 2);

    let err = super::undo::cmd_undo(&cfg_path, state_dir.path(), 1, None, true, true).unwrap_err();
    assert!(
        err.contains("records no machine state"),
        "expected a refusal, not a silent Ok, got: {err}"
    );
}

#[test]
fn undo_dry_run_with_changes() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(
        &cfg_path,
        "version: '1.0'\nname: t\nmachines:\n  web:\n    hostname: w\n    addr: 127.0.0.1\nresources: {}\n",
    )
    .unwrap();

    let gen_dir = state_dir.path().join("generations");
    // Gen 0 has a lock with resources
    std::fs::create_dir_all(gen_dir.join("0")).unwrap();
    record_lock(&gen_dir.join("0"), "web");
    record_replay_config(&gen_dir.join("0"));
    // Gen 1 is empty
    std::fs::create_dir_all(gen_dir.join("1")).unwrap();
    record_replay_config(&gen_dir.join("1"));
    std::os::unix::fs::symlink("1", gen_dir.join("current")).unwrap();

    // Undo 1 gen → dry_run shows changes
    let result = super::undo::cmd_undo(&cfg_path, state_dir.path(), 1, None, true, true);
    assert!(result.is_ok());
}

#[test]
fn undo_no_yes_flag() {
    let cfg_dir = tempfile::tempdir().unwrap();
    let state_dir = tempfile::tempdir().unwrap();
    let cfg_path = cfg_dir.path().join("forjar.yaml");
    std::fs::write(
        &cfg_path,
        "version: '1.0'\nname: t\nmachines:\n  web:\n    hostname: w\n    addr: 127.0.0.1\nresources: {}\n",
    )
    .unwrap();

    let gen_dir = state_dir.path().join("generations");
    std::fs::create_dir_all(gen_dir.join("0")).unwrap();
    record_lock(&gen_dir.join("0"), "web");
    record_replay_config(&gen_dir.join("0"));
    std::fs::create_dir_all(gen_dir.join("1")).unwrap();
    record_replay_config(&gen_dir.join("1"));
    std::os::unix::fs::symlink("1", gen_dir.join("current")).unwrap();

    // Without --yes, not dry_run → should err
    let result = super::undo::cmd_undo(&cfg_path, state_dir.path(), 1, None, false, false);
    assert!(result.is_err());
    assert!(result.unwrap_err().contains("requires --yes"));
}

// ── init_undo_progress edge cases ────────────────────────────────────

#[test]
fn init_progress_empty_changes() {
    let progress = super::undo::init_undo_progress(3, 1, &[]);
    assert_eq!(progress.generation_from, 3);
    assert_eq!(progress.generation_to, 1);
    assert_eq!(progress.pending_count(), 0);
    assert_eq!(progress.completed_count(), 0);
    assert!(progress.resources.is_empty());
}

#[test]
fn init_progress_extracts_resource_ids() {
    let changes = vec![
        "  + nginx (web): will be created".to_string(),
        "  ~ app (web): will be updated".to_string(),
        "  - old (web): will be destroyed".to_string(),
    ];
    let progress = super::undo::init_undo_progress(10, 5, &changes);
    assert_eq!(progress.pending_count(), 3);
    assert!(progress.resources.contains_key("nginx"));
    assert!(progress.resources.contains_key("app"));
    assert!(progress.resources.contains_key("old"));
}