forge-runtime 0.9.0

Runtime executors and gateway for the Forge framework
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
//! Integration tests for the signals pipeline.
//!
//! These tests hit a real PostgreSQL database (via testcontainers) and verify
//! the full path: session management, event collection, handler round-trips,
//! and partition management.

use std::sync::Arc;
use std::time::Duration;

use axum::Json;
use axum::extract::State;
use axum::http::{HeaderMap, HeaderValue};
use axum::response::IntoResponse;
use forge_core::signals::{
    ClientContext, ClientEvent, DiagnosticError, DiagnosticReport, IdentifyPayload,
    PageViewPayload, SignalEvent, SignalEventBatch, SignalEventType,
};
use forge_core::testing::IsolatedTestDb;
use sqlx::PgPool;
use uuid::Uuid;

use super::collector::SignalsCollector;
use super::endpoints::SignalsState;
use super::{endpoints, partition, session};

const SYSTEM_SQL: &str = include_str!("../../migrations/system/v001_initial.sql");

async fn setup(name: &str) -> IsolatedTestDb {
    let db = IsolatedTestDb::setup(name, SYSTEM_SQL, std::path::Path::new("nonexistent"))
        .await
        .unwrap();
    // Ensure partitions exist so INSERTs don't fail
    partition::ensure_partitions(db.pool()).await;
    db
}

fn make_signals_state(pool: &PgPool) -> Arc<SignalsState> {
    let collector = SignalsCollector::spawn(
        Arc::new(pool.clone()),
        1, // batch_size=1 for immediate flush
        Duration::from_millis(50),
    );
    Arc::new(SignalsState {
        collector,
        pool: pool.clone(),
        server_secret: "test-secret".to_string(),
        anonymize_ip: false,
        geoip: None,
    })
}

fn make_headers() -> HeaderMap {
    let mut headers = HeaderMap::new();
    headers.insert(
        "user-agent",
        HeaderValue::from_static("TestBrowser/1.0 (Macintosh; Intel Mac OS X) Chrome/120.0"),
    );
    headers.insert("x-forwarded-for", HeaderValue::from_static("1.2.3.4"));
    headers
}

fn make_headers_with_platform(platform: &str) -> HeaderMap {
    let mut headers = make_headers();
    headers.insert("x-forge-platform", HeaderValue::from_str(platform).unwrap());
    headers
}

// ── Session lifecycle ───────────────────────────────────────────────────────

#[tokio::test]
async fn test_session_create_new() {
    let db = setup("session_create").await;
    let pool = db.pool();

    let sid = session::upsert_session(
        pool,
        None,
        "visitor-1",
        None,
        None,
        Some("/home"),
        None,
        Some("Chrome/120"),
        Some("1.2.3.4"),
        false,
        "page_view",
        Some("web"),
        Some("Chrome"),
        Some("macOS"),
    )
    .await;

    assert!(sid.is_some());

    let row = sqlx::query_as::<_, (i32, String, bool)>(
        "SELECT event_count, entry_page, is_bounce FROM forge_signals_sessions WHERE id = $1",
    )
    .bind(sid.unwrap())
    .fetch_one(pool)
    .await
    .unwrap();

    assert_eq!(row.0, 1);
    assert_eq!(row.1, "/home");
    assert!(row.2); // first page view = bounce

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_session_update_existing() {
    let db = setup("session_update").await;
    let pool = db.pool();

    let sid = session::upsert_session(
        pool,
        None,
        "visitor-2",
        None,
        None,
        Some("/page1"),
        None,
        Some("Firefox/121"),
        Some("5.6.7.8"),
        false,
        "track",
        None,
        None,
        None,
    )
    .await
    .unwrap();

    // Update same session
    let sid2 = session::upsert_session(
        pool,
        Some(sid),
        "visitor-2",
        None,
        None,
        Some("/page2"),
        None,
        Some("Firefox/121"),
        Some("5.6.7.8"),
        false,
        "track",
        None,
        None,
        None,
    )
    .await
    .unwrap();

    assert_eq!(sid, sid2);

    let count: (i32,) =
        sqlx::query_as("SELECT event_count FROM forge_signals_sessions WHERE id = $1")
            .bind(sid)
            .fetch_one(pool)
            .await
            .unwrap();

    assert_eq!(count.0, 2);

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_session_bounce_cleared() {
    let db = setup("session_bounce").await;
    let pool = db.pool();

    let sid = session::upsert_session(
        pool,
        None,
        "visitor-bounce",
        None,
        None,
        Some("/"),
        None,
        None,
        None,
        false,
        "page_view",
        None,
        None,
        None,
    )
    .await
    .unwrap();

    // First page view: still a bounce
    let bounce: (bool,) =
        sqlx::query_as("SELECT is_bounce FROM forge_signals_sessions WHERE id = $1")
            .bind(sid)
            .fetch_one(pool)
            .await
            .unwrap();
    assert!(bounce.0);

    // Second page view clears bounce
    session::upsert_session(
        pool,
        Some(sid),
        "visitor-bounce",
        None,
        None,
        Some("/about"),
        None,
        None,
        None,
        false,
        "page_view",
        None,
        None,
        None,
    )
    .await;

    let bounce: (bool,) =
        sqlx::query_as("SELECT is_bounce FROM forge_signals_sessions WHERE id = $1")
            .bind(sid)
            .fetch_one(pool)
            .await
            .unwrap();
    assert!(!bounce.0);

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_session_device_fields_populated() {
    let db = setup("session_device").await;
    let pool = db.pool();

    let sid = session::upsert_session(
        pool,
        None,
        "visitor-device",
        None,
        None,
        Some("/"),
        None,
        Some("Chrome/120"),
        None,
        false,
        "page_view",
        Some("desktop"),
        Some("Chrome"),
        Some("macOS"),
    )
    .await
    .unwrap();

    let row = sqlx::query_as::<_, (Option<String>, Option<String>, Option<String>)>(
        "SELECT device_type, browser, os FROM forge_signals_sessions WHERE id = $1",
    )
    .bind(sid)
    .fetch_one(pool)
    .await
    .unwrap();

    assert_eq!(row.0.as_deref(), Some("desktop"));
    assert_eq!(row.1.as_deref(), Some("Chrome"));
    assert_eq!(row.2.as_deref(), Some("macOS"));

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_identify_links_user() {
    let db = setup("identify_user").await;
    let pool = db.pool();

    let sid = session::upsert_session(
        pool,
        None,
        "visitor-anon",
        None,
        None,
        Some("/"),
        None,
        None,
        None,
        false,
        "page_view",
        None,
        None,
        None,
    )
    .await
    .unwrap();

    // Session starts without user_id
    let user_id_before: (Option<Uuid>,) =
        sqlx::query_as("SELECT user_id FROM forge_signals_sessions WHERE id = $1")
            .bind(sid)
            .fetch_one(pool)
            .await
            .unwrap();
    assert!(user_id_before.0.is_none());

    let user_id = Uuid::new_v4();
    session::identify_session(pool, sid, user_id).await;

    let user_id_after: (Option<Uuid>,) =
        sqlx::query_as("SELECT user_id FROM forge_signals_sessions WHERE id = $1")
            .bind(sid)
            .fetch_one(pool)
            .await
            .unwrap();
    assert_eq!(user_id_after.0, Some(user_id));

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_close_stale_sessions() {
    let db = setup("close_stale").await;
    let pool = db.pool();

    let sid = session::upsert_session(
        pool,
        None,
        "visitor-stale",
        None,
        None,
        Some("/"),
        None,
        None,
        None,
        false,
        "page_view",
        None,
        None,
        None,
    )
    .await
    .unwrap();

    // Backdate both started_at and last_activity so duration > 0
    sqlx::query(
        "UPDATE forge_signals_sessions SET started_at = NOW() - interval '3 hours', last_activity_at = NOW() - interval '2 hours' WHERE id = $1"
    )
    .bind(sid)
    .execute(pool)
    .await
    .unwrap();

    session::close_stale_sessions(pool, 30).await;

    let row = sqlx::query_as::<_, (Option<chrono::DateTime<chrono::Utc>>, Option<i32>)>(
        "SELECT ended_at, duration_secs FROM forge_signals_sessions WHERE id = $1",
    )
    .bind(sid)
    .fetch_one(pool)
    .await
    .unwrap();

    assert!(row.0.is_some(), "ended_at should be set");
    assert!(row.1.is_some(), "duration_secs should be set");
    assert!(row.1.unwrap() > 0, "duration should be positive");

    db.cleanup().await.unwrap();
}

// ── User profiles ───────────────────────────────────────────────────────────

#[tokio::test]
async fn test_upsert_user_creates_profile() {
    let db = setup("upsert_user").await;
    let pool = db.pool();
    let user_id = Uuid::new_v4();
    let traits = serde_json::json!({"plan": "pro", "company": "Acme"});

    session::upsert_user(
        pool,
        user_id,
        &traits,
        Some("https://google.com"),
        Some("google"),
        Some("cpc"),
        Some("spring"),
    )
    .await;

    let row = sqlx::query_as::<_, (serde_json::Value, Option<String>, Option<String>)>(
        "SELECT traits, first_utm_source, first_referrer FROM forge_signals_users WHERE id = $1",
    )
    .bind(user_id)
    .fetch_one(pool)
    .await
    .unwrap();

    assert_eq!(row.0["plan"], "pro");
    assert_eq!(row.1.as_deref(), Some("google"));
    assert_eq!(row.2.as_deref(), Some("https://google.com"));

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_upsert_user_merges_traits() {
    let db = setup("merge_traits").await;
    let pool = db.pool();
    let user_id = Uuid::new_v4();

    session::upsert_user(
        pool,
        user_id,
        &serde_json::json!({"plan": "free"}),
        None,
        None,
        None,
        None,
    )
    .await;
    session::upsert_user(
        pool,
        user_id,
        &serde_json::json!({"company": "Acme"}),
        None,
        None,
        None,
        None,
    )
    .await;

    let traits: (serde_json::Value,) =
        sqlx::query_as("SELECT traits FROM forge_signals_users WHERE id = $1")
            .bind(user_id)
            .fetch_one(pool)
            .await
            .unwrap();

    // JSONB || merges: both keys should be present
    assert_eq!(traits.0["plan"], "free");
    assert_eq!(traits.0["company"], "Acme");

    db.cleanup().await.unwrap();
}

// ── Collector (real DB writes) ──────────────────────────────────────────────

fn make_test_event() -> SignalEvent {
    SignalEvent {
        event_type: SignalEventType::Track,
        event_name: Some("test_event".to_string()),
        correlation_id: Some("corr-1".to_string()),
        session_id: None,
        visitor_id: Some("visitor-test".to_string()),
        user_id: None,
        tenant_id: None,
        properties: serde_json::json!({"key": "value"}),
        page_url: Some("/test".to_string()),
        referrer: None,
        function_name: None,
        function_kind: None,
        duration_ms: None,
        status: None,
        error_message: None,
        error_stack: None,
        error_context: None,
        client_ip: Some("1.2.3.4".to_string()),
        country: None,
        city: None,
        user_agent: Some("TestAgent/1.0".to_string()),
        device_type: Some("web".to_string()),
        browser: Some("Chrome".to_string()),
        os: Some("macOS".to_string()),
        utm: None,
        is_bot: false,
        timestamp: chrono::Utc::now(),
    }
}

#[tokio::test]
async fn test_collector_single_event_flush() {
    let db = setup("collector_single").await;
    let pool = db.pool();

    let collector = SignalsCollector::spawn(
        Arc::new(pool.clone()),
        1, // flush on every event
        Duration::from_secs(60),
    );

    collector.try_send(make_test_event());
    tokio::time::sleep(Duration::from_millis(200)).await;

    let count: (i64,) =
        sqlx::query_as("SELECT COUNT(*) FROM forge_signals_events WHERE event_name = 'test_event'")
            .fetch_one(pool)
            .await
            .unwrap();

    assert_eq!(count.0, 1);

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_collector_batch_trigger() {
    let db = setup("collector_batch").await;
    let pool = db.pool();

    let collector = SignalsCollector::spawn(
        Arc::new(pool.clone()),
        5, // flush at 5 events
        Duration::from_secs(60),
    );

    for i in 0..5 {
        let mut event = make_test_event();
        event.event_name = Some(format!("batch_event_{i}"));
        collector.try_send(event);
    }

    tokio::time::sleep(Duration::from_millis(200)).await;

    let count: (i64,) = sqlx::query_as(
        "SELECT COUNT(*) FROM forge_signals_events WHERE event_name LIKE 'batch_event_%'",
    )
    .fetch_one(pool)
    .await
    .unwrap();

    assert_eq!(count.0, 5);

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_collector_timer_trigger() {
    let db = setup("collector_timer").await;
    let pool = db.pool();

    let collector = SignalsCollector::spawn(
        Arc::new(pool.clone()),
        100,                        // high batch size so it won't trigger
        Duration::from_millis(100), // but short timer
    );

    for i in 0..3 {
        let mut event = make_test_event();
        event.event_name = Some(format!("timer_event_{i}"));
        collector.try_send(event);
    }

    // Wait for timer flush
    tokio::time::sleep(Duration::from_millis(300)).await;

    let count: (i64,) = sqlx::query_as(
        "SELECT COUNT(*) FROM forge_signals_events WHERE event_name LIKE 'timer_event_%'",
    )
    .fetch_one(pool)
    .await
    .unwrap();

    assert_eq!(count.0, 3);

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_collector_drop_flushes_remaining() {
    let db = setup("collector_drop").await;
    let pool = db.pool();

    {
        let collector = SignalsCollector::spawn(
            Arc::new(pool.clone()),
            100,                     // won't trigger batch
            Duration::from_secs(60), // won't trigger timer
        );

        for i in 0..3 {
            let mut event = make_test_event();
            event.event_name = Some(format!("drop_event_{i}"));
            collector.try_send(event);
        }

        // Collector dropped here, channel closes, flush loop flushes remaining
    }

    // Give the flush task time to complete
    tokio::time::sleep(Duration::from_millis(200)).await;

    let count: (i64,) = sqlx::query_as(
        "SELECT COUNT(*) FROM forge_signals_events WHERE event_name LIKE 'drop_event_%'",
    )
    .fetch_one(pool)
    .await
    .unwrap();

    assert_eq!(count.0, 3);

    db.cleanup().await.unwrap();
}

// ── Handler round-trips ─────────────────────────────────────────────────────

#[tokio::test]
async fn test_event_handler_roundtrip() {
    let db = setup("handler_event").await;
    let state = make_signals_state(db.pool());

    let batch = SignalEventBatch {
        events: vec![ClientEvent {
            event: "signup_click".to_string(),
            properties: serde_json::json!({"button": "hero"}),
            correlation_id: Some("corr-abc".to_string()),
            timestamp: None,
        }],
        context: Some(ClientContext {
            page_url: Some("/landing".to_string()),
            referrer: None,
            session_id: None,
        }),
    };

    let response =
        endpoints::event_handler(State(state.clone()), None, make_headers(), Json(batch))
            .await
            .into_response();

    let body: serde_json::Value = axum::body::to_bytes(response.into_body(), 1024)
        .await
        .map(|b| serde_json::from_slice(&b).unwrap())
        .unwrap();

    assert_eq!(body["ok"], true);
    assert!(body["session_id"].is_string());
    let session_id = body["session_id"].as_str().unwrap();
    assert!(Uuid::parse_str(session_id).is_ok());

    // Wait for collector flush
    tokio::time::sleep(Duration::from_millis(200)).await;

    let count: (i64,) = sqlx::query_as(
        "SELECT COUNT(*) FROM forge_signals_events WHERE event_name = 'signup_click'",
    )
    .fetch_one(db.pool())
    .await
    .unwrap();
    assert_eq!(count.0, 1);

    // Verify session was created
    let session_count: (i64,) =
        sqlx::query_as("SELECT COUNT(*) FROM forge_signals_sessions WHERE id = $1")
            .bind(Uuid::parse_str(session_id).unwrap())
            .fetch_one(db.pool())
            .await
            .unwrap();
    assert_eq!(session_count.0, 1);

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_view_handler_with_utm() {
    let db = setup("handler_view_utm").await;
    let state = make_signals_state(db.pool());

    let payload = PageViewPayload {
        url: "/campaign".to_string(),
        referrer: Some("https://google.com".to_string()),
        title: Some("Campaign Page".to_string()),
        utm_source: Some("google".to_string()),
        utm_medium: Some("cpc".to_string()),
        utm_campaign: Some("spring-sale".to_string()),
        utm_term: Some("shoes".to_string()),
        utm_content: Some("banner".to_string()),
        correlation_id: None,
    };

    let response =
        endpoints::view_handler(State(state.clone()), None, make_headers(), Json(payload))
            .await
            .into_response();

    let body: serde_json::Value = axum::body::to_bytes(response.into_body(), 1024)
        .await
        .map(|b| serde_json::from_slice(&b).unwrap())
        .unwrap();
    assert_eq!(body["ok"], true);

    tokio::time::sleep(Duration::from_millis(200)).await;

    let row = sqlx::query_as::<_, (Option<String>, Option<String>, Option<String>, Option<String>)>(
        "SELECT utm_source, utm_medium, utm_campaign, referrer FROM forge_signals_events WHERE page_url = '/campaign'",
    )
    .fetch_one(db.pool())
    .await
    .unwrap();

    assert_eq!(row.0.as_deref(), Some("google"));
    assert_eq!(row.1.as_deref(), Some("cpc"));
    assert_eq!(row.2.as_deref(), Some("spring-sale"));
    assert_eq!(row.3.as_deref(), Some("https://google.com"));

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_report_handler_stores_errors() {
    let db = setup("handler_report").await;
    let state = make_signals_state(db.pool());

    let report = DiagnosticReport {
        errors: vec![
            DiagnosticError {
                message: "TypeError: null is not an object".to_string(),
                stack: Some("at render (app.js:42)".to_string()),
                context: Some(serde_json::json!({"component": "UserList"})),
                correlation_id: Some("corr-err-1".to_string()),
                breadcrumbs: None,
                page_url: Some("/users".to_string()),
            },
            DiagnosticError {
                message: "Unhandled promise rejection".to_string(),
                stack: None,
                context: None,
                correlation_id: None,
                breadcrumbs: None,
                page_url: Some("/dashboard".to_string()),
            },
        ],
    };

    let response =
        endpoints::report_handler(State(state.clone()), None, make_headers(), Json(report))
            .await
            .into_response();

    let body: serde_json::Value = axum::body::to_bytes(response.into_body(), 1024)
        .await
        .map(|b| serde_json::from_slice(&b).unwrap())
        .unwrap();
    assert_eq!(body["ok"], true);

    tokio::time::sleep(Duration::from_millis(200)).await;

    let count: (i64,) =
        sqlx::query_as("SELECT COUNT(*) FROM forge_signals_events WHERE event_type = 'error'")
            .fetch_one(db.pool())
            .await
            .unwrap();
    assert_eq!(count.0, 2);

    // Verify first error has all fields
    let row = sqlx::query_as::<_, (Option<String>, Option<String>, Option<String>)>(
        "SELECT error_message, error_stack, correlation_id FROM forge_signals_events WHERE correlation_id = 'corr-err-1'",
    )
    .fetch_one(db.pool())
    .await
    .unwrap();
    assert_eq!(row.0.as_deref(), Some("TypeError: null is not an object"));
    assert_eq!(row.1.as_deref(), Some("at render (app.js:42)"));
    assert_eq!(row.2.as_deref(), Some("corr-err-1"));

    db.cleanup().await.unwrap();
}

#[tokio::test]
async fn test_user_handler_rejects_invalid_uuid() {
    let db = setup("handler_user_invalid").await;
    let state = make_signals_state(db.pool());

    let payload = IdentifyPayload {
        user_id: "not-a-uuid".to_string(),
        traits: serde_json::json!({}),
    };

    let response =
        endpoints::user_handler(State(state.clone()), None, make_headers(), Json(payload))
            .await
            .into_response();

    let body: serde_json::Value = axum::body::to_bytes(response.into_body(), 1024)
        .await
        .map(|b| serde_json::from_slice(&b).unwrap())
        .unwrap();
    assert_eq!(body["ok"], false);

    db.cleanup().await.unwrap();
}

// ── Device fields through handler pipeline ──────────────────────────────────

#[tokio::test]
async fn test_event_handler_populates_device_fields() {
    let db = setup("handler_device").await;
    let state = make_signals_state(db.pool());

    let batch = SignalEventBatch {
        events: vec![ClientEvent {
            event: "device_test".to_string(),
            properties: serde_json::json!({}),
            correlation_id: None,
            timestamp: None,
        }],
        context: None,
    };

    endpoints::event_handler(
        State(state.clone()),
        None,
        make_headers_with_platform("desktop-macos"),
        Json(batch),
    )
    .await;

    tokio::time::sleep(Duration::from_millis(200)).await;

    let row = sqlx::query_as::<_, (Option<String>, Option<String>, Option<String>)>(
        "SELECT device_type, browser, os FROM forge_signals_events WHERE event_name = 'device_test'",
    )
    .fetch_one(db.pool())
    .await
    .unwrap();

    assert_eq!(row.0.as_deref(), Some("desktop"));
    assert_eq!(row.1.as_deref(), Some("Chrome"));
    assert_eq!(row.2.as_deref(), Some("macOS"));

    db.cleanup().await.unwrap();
}

// ── Partition management ────────────────────────────────────────────────────

#[tokio::test]
async fn test_partition_ensure() {
    let db = setup("partition_ensure").await;

    // Should not error even when called multiple times (idempotent)
    partition::ensure_partitions(db.pool()).await;
    partition::ensure_partitions(db.pool()).await;

    // Verify at least the current month partition exists
    let count: (i64,) = sqlx::query_as(
        "SELECT COUNT(*) FROM pg_tables WHERE tablename LIKE 'forge_signals_events_%' AND schemaname = 'public'",
    )
    .fetch_one(db.pool())
    .await
    .unwrap();

    // At minimum: current month + next month + default = 3 (default created by migration)
    assert!(
        count.0 >= 2,
        "expected at least 2 partitions, got {}",
        count.0
    );

    db.cleanup().await.unwrap();
}