forge-macros 0.10.0

Procedural macros for the Forge framework
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
use proc_macro::TokenStream;
use proc_macro2::TokenStream as TokenStream2;
use quote::quote;
use syn::visit::Visit;
use syn::{FnArg, ItemFn, Pat, ReturnType, Type, parse_macro_input};

use darling::FromMeta;
use darling::ast::NestedMeta;

use crate::attrs::{
    RateLimitMeta, RequireRole, TablesList, default_true, parse_rate_limit_per, reject_reserved,
    validate_rate_limit,
};
use crate::sql_extractor::{
    DbDelegationDetector, ScopeCheckResult, SqlStringExtractor, TableExtractionResult,
    extract_changed_columns_from_sql, extract_tables_from_sql, sql_references_identity_scope,
    sql_scope_requires_tenant,
};
use crate::utils::{parse_duration_secs, parse_size_bytes, to_pascal_case};

/// Attribute keys whose names are reserved for upcoming mutation-coalescing
/// support (cursor positions, autosave, etc). Using one today is a hard
/// compile error to surface that the feature isn't wired up yet.
const RESERVED_MUTATION_KEYS: &[&str] = &["coalesce_window", "coalesce_by"];

/// Darling-parsed mutation attributes.
#[derive(Debug, FromMeta)]
#[darling(and_then = DarlingMutationAttrs::validate)]
#[allow(dead_code)]
struct DarlingMutationAttrs {
    #[darling(default)]
    name: Option<String>,
    #[darling(default)]
    description: Option<String>,
    /// Defaults to `true`. `transactional = false` opts out.
    #[darling(default)]
    transactional: Option<bool>,
    #[darling(default)]
    public: bool,
    #[darling(default)]
    unscoped: bool,
    /// New-style alias for `public`. Accepted values: "none", "required".
    #[darling(default)]
    auth: Option<String>,
    /// New-style alias for `unscoped`. Accepted values: "global", "user".
    #[darling(default)]
    scope: Option<String>,
    #[darling(default)]
    require_role: Option<RequireRole>,
    #[darling(default)]
    timeout: Option<String>,
    #[darling(default)]
    rate_limit: Option<RateLimitMeta>,
    #[darling(default)]
    log: Option<String>,
    #[darling(default)]
    max_size: Option<String>,
    #[darling(default)]
    tables: Option<TablesList>,
    /// Set `register = false` to skip `inventory::submit!` auto-registration.
    #[darling(default = "default_true")]
    register: bool,
    /// Opt out of the compile-time guard against `ctx.http()` inside a
    /// transactional mutation. Use only when the HTTP call is genuinely safe
    /// to leave un-rolled-back on transaction failure (e.g. an idempotent
    /// read-only request).
    #[darling(default)]
    allow_http: bool,
    // Reserved keys
    #[darling(default)]
    coalesce_window: Option<String>,
    #[darling(default)]
    coalesce_by: Option<String>,
}

impl DarlingMutationAttrs {
    fn validate(self) -> darling::Result<Self> {
        reject_reserved(
            RESERVED_MUTATION_KEYS,
            &[
                ("coalesce_window", self.coalesce_window.is_some()),
                ("coalesce_by", self.coalesce_by.is_some()),
            ],
            "mutation",
        )
        .map_err(|e| darling::Error::custom(e.to_string()))?;

        if let Some(ref a) = self.auth
            && !["none", "required"].contains(&a.as_str())
        {
            return Err(darling::Error::custom(format!(
                "invalid auth value \"{a}\": expected \"none\" or \"required\""
            )));
        }

        if let Some(ref s) = self.scope
            && !["global", "user"].contains(&s.as_str())
        {
            return Err(darling::Error::custom(format!(
                "invalid scope value \"{s}\": expected \"global\" or \"user\""
            )));
        }

        Ok(self)
    }
}

struct MutationAttrs {
    /// Override the wire name (default: function name).
    name: Option<String>,
    description: Option<String>,
    required_role: Option<String>,
    is_public: bool,
    is_unscoped: bool,
    timeout: Option<u64>,
    rate_limit_requests: Option<u32>,
    rate_limit_per_secs: Option<u64>,
    rate_limit_key: Option<String>,
    log_level: Option<String>,
    /// Defaults to `true`. Opt out with `transactional = false` for
    /// high-throughput mutations that don't need atomicity.
    transactional: bool,
    max_upload_size_bytes: Option<usize>,
    /// Override auto-detected table dependencies from SQL extraction.
    tables: Option<Vec<String>>,
    register: bool,
    /// Opt out of the compile-time guard against `ctx.http()` inside a
    /// transactional mutation.
    allow_http: bool,
}

impl Default for MutationAttrs {
    fn default() -> Self {
        Self {
            name: None,
            description: None,
            required_role: None,
            is_public: false,
            is_unscoped: false,
            timeout: None,
            rate_limit_requests: None,
            rate_limit_per_secs: None,
            rate_limit_key: None,
            log_level: None,
            transactional: true,
            max_upload_size_bytes: None,
            tables: None,
            register: true,
            allow_http: false,
        }
    }
}

pub fn expand_mutation(attr: TokenStream, item: TokenStream) -> TokenStream {
    let input = parse_macro_input!(item as ItemFn);

    let attr_args = match NestedMeta::parse_meta_list(attr.into()) {
        Ok(v) => v,
        Err(e) => return TokenStream::from(e.into_compile_error()),
    };

    let darling_attrs = match DarlingMutationAttrs::from_list(&attr_args) {
        Ok(v) => v,
        Err(e) => return TokenStream::from(e.write_errors()),
    };

    let attrs = match convert_mutation_attrs(darling_attrs) {
        Ok(a) => a,
        Err(e) => return e.to_compile_error().into(),
    };

    expand_mutation_impl(input, attrs)
        .unwrap_or_else(|e| e.to_compile_error())
        .into()
}

fn convert_mutation_attrs(darling: DarlingMutationAttrs) -> Result<MutationAttrs, syn::Error> {
    let timeout = match darling.timeout {
        Some(ref s) => Some(parse_duration_secs(s).ok_or_else(|| {
            syn::Error::new(
                proc_macro2::Span::call_site(),
                format!(
                    "invalid timeout \"{s}\": use a duration string like \"30s\", \"5m\", or \"1h\""
                ),
            )
        })?),
        None => None,
    };

    let (rate_limit_requests, rate_limit_per_secs, rate_limit_key) =
        if let Some(ref rl) = darling.rate_limit {
            validate_rate_limit(rl)?;
            (rl.requests, parse_rate_limit_per(rl)?, rl.key.clone())
        } else {
            (None, None, None)
        };

    Ok(MutationAttrs {
        name: darling.name,
        description: darling.description,
        required_role: darling.require_role.map(|r| r.0),
        is_public: darling.public || darling.auth.as_deref() == Some("none"),
        is_unscoped: darling.unscoped || darling.scope.as_deref() == Some("global"),
        timeout,
        rate_limit_requests,
        rate_limit_per_secs,
        rate_limit_key,
        log_level: darling.log,
        transactional: darling.transactional.unwrap_or(true),
        max_upload_size_bytes: darling.max_size.and_then(|s| parse_size_bytes(&s)),
        tables: darling.tables.map(|t| t.0),
        register: darling.register,
        allow_http: darling.allow_http,
    })
}

fn expand_mutation_impl(input: ItemFn, attrs: MutationAttrs) -> syn::Result<TokenStream2> {
    let fn_name = &input.sig.ident;
    let fn_name_str = fn_name.to_string();
    let rpc_name = attrs.name.as_deref().unwrap_or(&fn_name_str).to_string();
    let description = match &attrs.description {
        Some(d) => quote! { Some(#d) },
        None => quote! { None },
    };
    let module_name = syn::Ident::new(&format!("__forge_handler_{}", fn_name_str), fn_name.span());
    let struct_name = syn::Ident::new(
        &format!("{}Mutation", to_pascal_case(&fn_name_str)),
        fn_name.span(),
    );

    let vis = &input.vis;
    let asyncness = &input.sig.asyncness;
    let fn_block = &input.block;
    let fn_attrs = &input.attrs;

    // dispatch_job / start_workflow require a transaction so the outbox flush is
    // atomic with the database write. Explicitly opting out of transactions with
    // `transactional = false` while calling these is always a bug.
    //
    // The visitor only fires when the call's receiver chain bottoms out on the
    // mutation context binding (usually `ctx`). A name-only match would treat
    // any third-party `.dispatch_job()` on an unrelated type as a violation.
    let mutation_ctx_ident: Option<syn::Ident> = input.sig.inputs.iter().next().and_then(|arg| {
        if let FnArg::Typed(pat_type) = arg
            && let Pat::Ident(pat_ident) = pat_type.pat.as_ref()
        {
            Some(pat_ident.ident.clone())
        } else {
            None
        }
    });

    let has_dispatch = {
        struct DispatchCallVisitor {
            ctx_ident: Option<syn::Ident>,
            found: bool,
        }
        impl DispatchCallVisitor {
            fn receiver_root_ident(mut expr: &syn::Expr) -> Option<&syn::Ident> {
                loop {
                    match expr {
                        syn::Expr::MethodCall(inner) => expr = &inner.receiver,
                        syn::Expr::Try(inner) => expr = &inner.expr,
                        syn::Expr::Await(inner) => expr = &inner.base,
                        syn::Expr::Paren(inner) => expr = &inner.expr,
                        syn::Expr::Reference(inner) => expr = &inner.expr,
                        syn::Expr::Path(path) => {
                            if path.qself.is_none() && path.path.segments.len() == 1 {
                                return path.path.segments.first().map(|s| &s.ident);
                            }
                            return None;
                        }
                        _ => return None,
                    }
                }
            }

            fn receiver_is_ctx(&self, receiver: &syn::Expr) -> bool {
                let Some(ref ctx) = self.ctx_ident else {
                    return true;
                };
                Self::receiver_root_ident(receiver).is_some_and(|root| root == ctx)
            }
        }
        impl<'ast> syn::visit::Visit<'ast> for DispatchCallVisitor {
            fn visit_expr_method_call(&mut self, node: &'ast syn::ExprMethodCall) {
                let method = node.method.to_string();
                if (method == "dispatch_job" || method == "start_workflow")
                    && self.receiver_is_ctx(&node.receiver)
                {
                    self.found = true;
                }
                syn::visit::visit_expr_method_call(self, node);
            }
        }
        let mut visitor = DispatchCallVisitor {
            ctx_ident: mutation_ctx_ident.clone(),
            found: false,
        };
        syn::visit::visit_block(&mut visitor, fn_block);
        visitor.found
    };
    if has_dispatch && !attrs.transactional {
        return Err(syn::Error::new_spanned(
            &input.sig.ident,
            "Mutations that call `dispatch_job()` or `start_workflow()` cannot use \
             `transactional = false` — jobs dispatched outside a transaction may \
             execute even when the database write is rolled back on error.",
        ));
    }

    // Calling ctx.http() inside a transactional mutation is a footgun:
    //   1. The HTTP request cannot be rolled back if the transaction fails,
    //      so external side-effects may occur even when the DB write is undone.
    //   2. The DB connection is held open for the full HTTP round-trip, which
    //      increases contention on the connection pool under load.
    //
    // Emit a compile error when this is detected. Opt out with
    // `#[mutation(allow_http = true)]` when the HTTP call is genuinely safe to
    // leave un-rolled-back (e.g. an idempotent read-only request).
    //
    // The check is skipped for `transactional = false` mutations — HTTP calls
    // there are fine.
    if attrs.transactional && !attrs.allow_http {
        struct HttpCallVisitor {
            found: bool,
        }
        impl<'ast> syn::visit::Visit<'ast> for HttpCallVisitor {
            fn visit_expr_method_call(&mut self, node: &'ast syn::ExprMethodCall) {
                if node.method == "http" {
                    self.found = true;
                }
                syn::visit::visit_expr_method_call(self, node);
            }
        }
        let mut visitor = HttpCallVisitor { found: false };
        syn::visit::visit_block(&mut visitor, fn_block);
        if visitor.found {
            return Err(syn::Error::new_spanned(
                &input.sig.ident,
                format!(
                    "`{fn_name_str}` calls ctx.http() inside a transactional mutation. \
                     The HTTP request cannot be rolled back if the transaction fails, \
                     and the database connection is held open for the full HTTP round-trip. \
                     To fix: move the HTTP call outside the transaction by using \
                     `#[mutation(transactional = false)]` and dispatching a job for the \
                     DB write, or restructure so http() is called after the mutation returns. \
                     If the HTTP call is intentionally safe un-rolled-back (e.g. an \
                     idempotent read-only request), suppress with \
                     `#[mutation(allow_http = true)]`."
                ),
            ));
        }
    }

    if asyncness.is_none() {
        return Err(syn::Error::new_spanned(
            &input.sig,
            "Mutation functions must be async",
        ));
    }

    let params: Vec<_> = input.sig.inputs.iter().collect();
    if params.is_empty() {
        return Err(syn::Error::new_spanned(
            &input.sig,
            "Mutation functions must have at least a MutationContext parameter",
        ));
    }

    let (ctx_name, ctx_type) = match &params[0] {
        FnArg::Typed(pat_type) => {
            let name = if let Pat::Ident(pat_ident) = &*pat_type.pat {
                pat_ident.ident.clone()
            } else {
                return Err(syn::Error::new_spanned(
                    pat_type,
                    "Expected context parameter to be an identifier",
                ));
            };
            (name, &*pat_type.ty)
        }
        _ => {
            return Err(syn::Error::new_spanned(
                params[0],
                "Expected typed context parameter",
            ));
        }
    };

    let type_str = quote! { #ctx_type }.to_string();
    let is_ref = type_str.starts_with('&');

    let arg_params: Vec<_> = params.iter().skip(1).cloned().collect();

    for p in &arg_params {
        if let FnArg::Typed(pat_type) = p
            && let Some((reason, span)) = crate::utils::check_arg_wire_type(&pat_type.ty)
        {
            return Err(syn::Error::new(span, reason));
        }
    }

    let args_fields: Vec<TokenStream2> = arg_params
        .iter()
        .filter_map(|p| {
            if let FnArg::Typed(pat_type) = p
                && let Pat::Ident(pat_ident) = &*pat_type.pat
            {
                let name = &pat_ident.ident;
                let ty = &pat_type.ty;
                return Some(quote! { pub #name: #ty });
            }
            None
        })
        .collect();

    let arg_names: Vec<TokenStream2> = arg_params
        .iter()
        .filter_map(|p| {
            if let FnArg::Typed(pat_type) = p
                && let Pat::Ident(pat_ident) = &*pat_type.pat
            {
                let name = &pat_ident.ident;
                return Some(quote! { #name });
            }
            None
        })
        .collect();

    let output_type = match &input.sig.output {
        ReturnType::Default => quote! { () },
        ReturnType::Type(_, ty) => {
            if let Type::Path(type_path) = &**ty {
                if let Some(segment) = type_path.path.segments.last() {
                    if segment.ident == "Result" {
                        if let syn::PathArguments::AngleBracketed(args) = &segment.arguments {
                            if let Some(syn::GenericArgument::Type(t)) = args.args.first() {
                                quote! { #t }
                            } else {
                                quote! { #ty }
                            }
                        } else {
                            quote! { #ty }
                        }
                    } else {
                        quote! { #ty }
                    }
                } else {
                    quote! { #ty }
                }
            } else {
                quote! { #ty }
            }
        }
    };

    let timeout = match attrs.timeout {
        Some(t) => quote! { Some(::std::time::Duration::from_secs(#t)) },
        None => quote! { None },
    };
    let http_timeout = timeout.clone();

    let required_role = match &attrs.required_role {
        Some(role) => quote! { Some(#role) },
        None => quote! { None },
    };

    let rate_limit_requests = match attrs.rate_limit_requests {
        Some(n) => quote! { Some(#n) },
        None => quote! { None },
    };

    let rate_limit_per_secs = match attrs.rate_limit_per_secs {
        Some(n) => quote! { Some(#n) },
        None => quote! { None },
    };

    let rate_limit_key = match &attrs.rate_limit_key {
        Some(k) => {
            let key_tokens = match k.as_str() {
                "user" => quote! { forge::forge_core::rate_limit::RateLimitKey::User },
                "ip" => quote! { forge::forge_core::rate_limit::RateLimitKey::Ip },
                "tenant" => quote! { forge::forge_core::rate_limit::RateLimitKey::Tenant },
                "user_action" => quote! { forge::forge_core::rate_limit::RateLimitKey::UserAction },
                "global" => quote! { forge::forge_core::rate_limit::RateLimitKey::Global },
                _ if k.starts_with("custom:") => {
                    let claim = k.trim_start_matches("custom:");
                    quote! { forge::forge_core::rate_limit::RateLimitKey::Custom(#claim.to_string()) }
                }
                _ => quote! { forge::forge_core::rate_limit::RateLimitKey::User },
            };
            quote! { Some(#key_tokens) }
        }
        None => quote! { None },
    };

    let log_level = match &attrs.log_level {
        Some(l) => {
            let level_tokens = match l.as_str() {
                "trace" => quote! { forge::forge_core::LogLevel::Trace },
                "debug" => quote! { forge::forge_core::LogLevel::Debug },
                "info" => quote! { forge::forge_core::LogLevel::Info },
                "warn" => quote! { forge::forge_core::LogLevel::Warn },
                "error" => quote! { forge::forge_core::LogLevel::Error },
                "off" => quote! { forge::forge_core::LogLevel::Off },
                _ => quote! { forge::forge_core::LogLevel::Trace },
            };
            quote! { Some(#level_tokens) }
        }
        None => quote! { None },
    };

    let max_upload_size_bytes = match attrs.max_upload_size_bytes {
        Some(n) => quote! { Some(#n) },
        None => quote! { None },
    };

    let mut extractor = SqlStringExtractor::new();
    extractor.visit_block(fn_block);

    let has_explicit_tables = attrs.tables.is_some();
    let table_dependencies: Vec<String> = if let Some(ref tables) = attrs.tables {
        tables.clone()
    } else {
        match extract_tables_from_sql(&extractor.sql_strings) {
            TableExtractionResult::Ok(tables) => {
                let mut sorted: Vec<String> = tables.into_iter().collect();
                sorted.sort();
                sorted
            }
            TableExtractionResult::ParseFailed(sql) => {
                let preview: String = sql.chars().take(80).collect();
                return Err(syn::Error::new_spanned(
                    &input.sig.ident,
                    format!(
                        "SQL in `{fn_name_str}` could not be parsed: \"{preview}...\"\n\
                         Add #[mutation(tables(\"your_table\"))] to specify table dependencies explicitly."
                    ),
                ));
            }
        }
    };

    let table_deps_tokens = if table_dependencies.is_empty() {
        quote! { &[] }
    } else {
        let deps = &table_dependencies;
        quote! { &[#(#deps),*] }
    };

    let changed_columns_tokens: TokenStream2 = {
        let mut cols: Vec<String> = extract_changed_columns_from_sql(&extractor.sql_strings)
            .into_iter()
            .collect();
        cols.sort();
        if cols.is_empty() {
            quote! { &[] }
        } else {
            quote! { &[#(#cols),*] }
        }
    };

    if !attrs.is_public
        && !attrs.is_unscoped
        && table_dependencies.is_empty()
        && !has_explicit_tables
    {
        let mut delegation = DbDelegationDetector::new();
        delegation.visit_block(fn_block);
        if delegation.found {
            return Err(syn::Error::new_spanned(
                &input.sig.ident,
                format!(
                    "Private mutation `{fn_name_str}` calls .pool() but contains no inline SQL, \
                     so table dependencies and scope cannot be verified. Inline the SQL in the \
                     handler body, or add #[mutation(tables(\"...\"))] to declare dependencies \
                     explicitly."
                ),
            ));
        }
    }

    if !attrs.is_public && !attrs.is_unscoped && !table_dependencies.is_empty() {
        let mut scope_extractor = SqlStringExtractor::new();
        scope_extractor.visit_block(fn_block);
        match sql_references_identity_scope(&scope_extractor.sql_strings) {
            ScopeCheckResult::Scoped => {}
            ScopeCheckResult::Unscoped => {
                let tables_str = table_dependencies.join(", ");
                return Err(syn::Error::new_spanned(
                    &input.sig.ident,
                    format!(
                        "Private mutation `{fn_name_str}` references table(s) [{tables_str}] but \
                         SQL does not filter by user_id or owner_id. Add a WHERE clause scoped to \
                         the authenticated user, or use #[mutation(scope = \"global\")] if this is \
                         intentional."
                    ),
                ));
            }
            ScopeCheckResult::ParseFailed => {
                let tables_str = table_dependencies.join(", ");
                return Err(syn::Error::new_spanned(
                    &input.sig.ident,
                    format!(
                        "Private mutation `{fn_name_str}` references table(s) [{tables_str}] but \
                         SQL could not be parsed to verify scope. Add #[mutation(scope = \"global\")] to \
                         opt out of scope checking, or add #[mutation(tables(\"...\"))] to skip \
                         automatic extraction."
                    ),
                ));
            }
        }
    }

    let requires_tenant_scope = if !attrs.is_public && !attrs.is_unscoped {
        let mut tenant_extractor = SqlStringExtractor::new();
        tenant_extractor.visit_block(fn_block);
        sql_scope_requires_tenant(&tenant_extractor.sql_strings)
    } else {
        false
    };

    let transactional = attrs.transactional;
    let is_public = attrs.is_public;

    // Single non-primitive struct args are passed through directly; primitives and
    // collections are wrapped in a generated #StructNameArgs to keep RPC payloads JSON-named.
    let single_custom_args_type: Option<&Type> = if arg_params.len() == 1 {
        if let FnArg::Typed(pat_type) = &arg_params[0] {
            if crate::utils::is_primitive_arg_type(&pat_type.ty) {
                None
            } else {
                Some(&*pat_type.ty)
            }
        } else {
            None
        }
    } else {
        None
    };

    let (module_struct_defs, args_type, execute_call) = if args_fields.is_empty() {
        (
            quote! { pub struct #struct_name; },
            quote! { () },
            quote! { super::#fn_name(ctx).await },
        )
    } else if let Some(user_args_type) = single_custom_args_type {
        (
            quote! { pub struct #struct_name; },
            quote! { #user_args_type },
            quote! { super::#fn_name(ctx, args).await },
        )
    } else {
        let args_struct_name = syn::Ident::new(&format!("{}Args", struct_name), fn_name.span());
        (
            quote! {
                #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
                pub struct #args_struct_name {
                    #(#args_fields),*
                }
                pub struct #struct_name;
            },
            quote! { #args_struct_name },
            quote! { super::#fn_name(ctx, #(args.#arg_names),*).await },
        )
    };

    let inner_fn = if is_ref {
        if arg_names.is_empty() {
            quote! {
                #(#fn_attrs)*
                #vis async fn #fn_name(#ctx_name: #ctx_type) -> forge::forge_core::Result<#output_type> #fn_block
            }
        } else {
            quote! {
                #(#fn_attrs)*
                #vis async fn #fn_name(#ctx_name: #ctx_type, #(#arg_params),*) -> forge::forge_core::Result<#output_type> #fn_block
            }
        }
    } else if arg_names.is_empty() {
        quote! {
            #(#fn_attrs)*
            #vis async fn #fn_name(#ctx_name: &#ctx_type) -> forge::forge_core::Result<#output_type> #fn_block
        }
    } else {
        quote! {
            #(#fn_attrs)*
            #vis async fn #fn_name(#ctx_name: &#ctx_type, #(#arg_params),*) -> forge::forge_core::Result<#output_type> #fn_block
        }
    };

    let registration = if attrs.register {
        quote! {
            forge::inventory::submit!(forge::AutoHandler(|registries| {
                registries.functions.register_mutation::<#struct_name>();
            }));
        }
    } else {
        quote! {}
    };

    Ok(quote! {
        #inner_fn

        #[doc(hidden)]
        #[allow(non_snake_case)]
        mod #module_name {
            use super::*;

            #module_struct_defs

            impl forge::forge_core::__sealed::Sealed for #struct_name {}

            impl forge::forge_core::ForgeMutation for #struct_name {
                type Args = #args_type;
                type Output = #output_type;

                fn info() -> forge::forge_core::FunctionInfo {
                    forge::forge_core::FunctionInfo {
                        name: #rpc_name,
                        description: #description,
                        kind: forge::forge_core::FunctionKind::Mutation,
                        required_role: #required_role,
                        is_public: #is_public,
                        cache_ttl: None,
                        timeout: #timeout,
                        http_timeout: #http_timeout,
                        rate_limit_requests: #rate_limit_requests,
                        rate_limit_per_secs: #rate_limit_per_secs,
                        rate_limit_key: #rate_limit_key,
                        log_level: #log_level,
                        table_dependencies: #table_deps_tokens,
                        selected_columns: &[],
                        changed_columns: #changed_columns_tokens,
                        transactional: #transactional,
                        consistent: false,
                        max_upload_size_bytes: #max_upload_size_bytes,
                        requires_tenant_scope: #requires_tenant_scope,
                    }
                }

                fn execute(
                    ctx: &forge::forge_core::MutationContext,
                    args: Self::Args,
                ) -> std::pin::Pin<Box<dyn std::future::Future<Output = forge::forge_core::Result<Self::Output>> + Send + '_>> {
                    Box::pin(async move {
                        #execute_call
                    })
                }
            }

            #registration
        }
    })
}

#[cfg(test)]
#[allow(clippy::unwrap_used, clippy::indexing_slicing, clippy::panic)]
mod tests {
    use super::*;

    #[test]
    fn default_attrs_transactional_is_true() {
        let attrs = MutationAttrs::default();
        assert!(attrs.transactional, "transactional defaults to true");
        assert!(!attrs.is_public);
        assert!(attrs.required_role.is_none());
        assert!(attrs.timeout.is_none());
        assert!(attrs.rate_limit_requests.is_none());
        assert!(attrs.rate_limit_per_secs.is_none());
        assert!(attrs.rate_limit_key.is_none());
        assert!(attrs.log_level.is_none());
        assert!(attrs.max_upload_size_bytes.is_none());
        assert!(attrs.tables.is_none());
    }

    #[test]
    fn rejects_dispatch_job_with_transactional_false() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn create_user(ctx: &MutationContext, name: String) -> Result<User> {
                ctx.dispatch_job("send_email", json!({})).await?;
                Ok(User { name })
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs {
            transactional: false,
            ..MutationAttrs::default()
        };
        let result = expand_mutation_impl(input, attrs);
        assert!(result.is_err());
        let err_msg = result.unwrap_err().to_string();
        assert!(
            err_msg.contains("transactional"),
            "Error should mention transactional: {err_msg}"
        );
    }

    #[test]
    fn rejects_start_workflow_with_transactional_false() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn begin_onboarding(ctx: &MutationContext) -> Result<()> {
                ctx.start_workflow("onboarding", json!({})).await?;
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs {
            transactional: false,
            ..MutationAttrs::default()
        };
        let result = expand_mutation_impl(input, attrs);
        assert!(result.is_err());
        let err_msg = result.unwrap_err().to_string();
        assert!(err_msg.contains("transactional"));
    }

    #[test]
    fn accepts_dispatch_job_with_default_transactional() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn create_user(ctx: &MutationContext, name: String) -> Result<User> {
                ctx.dispatch_job("send_email", json!({})).await?;
                Ok(User { name })
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs::default();
        let result = expand_mutation_impl(input, attrs);
        assert!(
            result.is_ok(),
            "Should accept dispatch_job with default transactional=true"
        );
    }

    #[test]
    fn accepts_dispatch_job_with_transactional() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn create_user(ctx: &MutationContext, name: String) -> Result<User> {
                ctx.dispatch_job("send_email", json!({})).await?;
                Ok(User { name })
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs {
            transactional: true,
            ..Default::default()
        };
        let result = expand_mutation_impl(input, attrs);
        assert!(
            result.is_ok(),
            "Should accept dispatch_job with transactional"
        );
    }

    #[test]
    fn accepts_mutation_without_dispatch() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn update_name(ctx: &MutationContext, name: String) -> Result<()> {
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs::default();
        let result = expand_mutation_impl(input, attrs);
        assert!(
            result.is_ok(),
            "Simple mutation without dispatch should work"
        );
    }

    #[test]
    fn rejects_non_async_mutation() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub fn create_user(ctx: &MutationContext) -> Result<()> {
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs::default();
        let result = expand_mutation_impl(input, attrs);
        assert!(result.is_err());
        let err_msg = result.unwrap_err().to_string();
        assert!(
            err_msg.contains("async"),
            "Error should mention async: {err_msg}"
        );
    }

    #[test]
    fn rejects_mutation_without_parameters() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn create_user() -> Result<()> {
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs::default();
        let result = expand_mutation_impl(input, attrs);
        assert!(result.is_err());
        let err_msg = result.unwrap_err().to_string();
        assert!(
            err_msg.contains("MutationContext"),
            "Error should mention context param: {err_msg}"
        );
    }

    #[test]
    fn generates_struct_for_no_arg_mutation() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn reset_all(ctx: &MutationContext) -> Result<()> {
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs::default();
        let output = expand_mutation_impl(input, attrs).expect("should expand");
        let output_str = output.to_string();
        assert!(
            output_str.contains("ResetAllMutation"),
            "Should generate PascalCase struct name"
        );
        assert!(
            output_str.contains("ForgeMutation"),
            "Should implement ForgeMutation trait"
        );
        assert!(
            output_str.contains("inventory"),
            "Should register via inventory"
        );
    }

    #[test]
    fn generates_info_with_attributes() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn create_item(ctx: &MutationContext) -> Result<()> {
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs {
            is_public: true,
            transactional: true,
            required_role: Some("admin".into()),
            ..Default::default()
        };
        let output = expand_mutation_impl(input, attrs).expect("should expand");
        let output_str = output.to_string();
        assert!(output_str.contains("is_public : true"));
        assert!(output_str.contains("transactional : true"));
        assert!(
            output_str.contains(r#"Some ("admin")"#) || output_str.contains(r#"Some("admin")"#)
        );
    }

    #[test]
    fn generates_explicit_table_dependencies() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn create_order(ctx: &MutationContext) -> Result<()> {
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs {
            tables: Some(vec!["users".into(), "orders".into()]),
            is_unscoped: true,
            ..Default::default()
        };
        let output = expand_mutation_impl(input, attrs).expect("should expand");
        let output_str = output.to_string();
        assert!(
            output_str.contains("users") && output_str.contains("orders"),
            "Should include explicit table dependencies in output: {output_str}"
        );
    }

    #[test]
    fn generates_empty_table_dependencies_by_default() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn update_user(ctx: &MutationContext) -> Result<()> {
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs::default();
        let output = expand_mutation_impl(input, attrs).expect("should expand");
        let output_str = output.to_string();
        assert!(
            output_str.contains("table_dependencies : & []"),
            "Should have empty table_dependencies by default: {output_str}"
        );
    }

    #[test]
    fn rejects_http_call_inside_transactional_mutation() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn notify_user(ctx: &MutationContext) -> Result<()> {
                ctx.http().get("https://example.com/ping").send().await?;
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs::default();
        let result = expand_mutation_impl(input, attrs);
        assert!(
            result.is_err(),
            "Should reject ctx.http() in transactional mutation"
        );
        let err_msg = result.unwrap_err().to_string();
        assert!(
            err_msg.contains("http"),
            "Error should mention http: {err_msg}"
        );
        assert!(
            err_msg.contains("transactional"),
            "Error should mention transactional footgun: {err_msg}"
        );
    }

    #[test]
    fn accepts_http_call_when_transactional_false() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn notify_user(ctx: &MutationContext) -> Result<()> {
                ctx.http().get("https://example.com/ping").send().await?;
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs {
            transactional: false,
            ..MutationAttrs::default()
        };
        let result = expand_mutation_impl(input, attrs);
        assert!(
            result.is_ok(),
            "http() in non-transactional mutation is fine: {:?}",
            result.err()
        );
    }

    #[test]
    fn accepts_http_call_with_allow_http() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn notify_user(ctx: &MutationContext) -> Result<()> {
                ctx.http().get("https://example.com/ping").send().await?;
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs {
            transactional: true,
            allow_http: true,
            ..MutationAttrs::default()
        };
        let result = expand_mutation_impl(input, attrs);
        assert!(
            result.is_ok(),
            "http() with allow_http = true should be accepted: {:?}",
            result.err()
        );
    }

    #[test]
    fn accepts_mutation_without_http_call() {
        let input: ItemFn = syn::parse_str(
            r#"
            pub async fn update_user(ctx: &MutationContext, name: String) -> Result<()> {
                Ok(())
            }
            "#,
        )
        .unwrap();

        let attrs = MutationAttrs::default();
        let result = expand_mutation_impl(input, attrs);
        assert!(
            result.is_ok(),
            "Mutation without http() should always be accepted"
        );
    }
}