fluxfox 0.1.0

A library crate for working with floppy disk images for the IBM PC and compatibles.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
/*
    FluxFox
    https://github.com/dbalsom/fluxfox

    Copyright 2024 Daniel Balsom

    Permission is hereby granted, free of charge, to any person obtaining a
    copy of this software and associated documentation files (the “Software”),
    to deal in the Software without restriction, including without limitation
    the rights to use, copy, modify, merge, publish, distribute, sublicense,
    and/or sell copies of the Software, and to permit persons to whom the
    Software is furnished to do so, subject to the following conditions:

    The above copyright notice and this permission notice shall be included in
    all copies or substantial portions of the Software.

    THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
    FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
    DEALINGS IN THE SOFTWARE.

    --------------------------------------------------------------------------

    src/track/metasector.rs

    Implements the MetaSector track type and the Track trait for same.

*/
use super::{Track, TrackConsistency, TrackInfo};

use crate::diskimage::{
    ReadSectorResult, ReadTrackResult, RwSectorScope, ScanSectorResult, SectorDescriptor, SharedDiskContext,
    WriteSectorResult,
};

use crate::structure_parsers::system34::System34Standard;
use crate::structure_parsers::DiskStructureMetadata;

use crate::bitstream::TrackDataStream;
use crate::track::bitstream::BitStreamTrack;
use crate::track::fluxstream::FluxStreamTrack;
use crate::{
    DiskCh, DiskChs, DiskChsn, DiskDataEncoding, DiskDataRate, DiskDataResolution, DiskImageError, FoxHashSet,
    SectorMapEntry,
};
use sha1_smol::Digest;
use std::any::Any;
use std::sync::{Arc, Mutex};

struct SectorMatch<'a> {
    pub(crate) sectors: Vec<&'a MetaSector>,
    pub(crate) sizes: Vec<u8>,
    pub(crate) wrong_cylinder: bool,
    pub(crate) bad_cylinder: bool,
    pub(crate) wrong_head: bool,
}

impl SectorMatch<'_> {
    fn len(&'_ self) -> usize {
        self.sectors.len()
    }
    #[allow(dead_code)]
    fn iter(&'_ self) -> std::slice::Iter<&MetaSector> {
        self.sectors.iter()
    }
}

struct SectorMatchMut<'a> {
    pub(crate) sectors: Vec<&'a mut MetaSector>,
    pub(crate) sizes: Vec<u8>,
    pub(crate) wrong_cylinder: bool,
    pub(crate) bad_cylinder: bool,
    pub(crate) wrong_head: bool,
    pub(crate) shared: Arc<Mutex<SharedDiskContext>>,
}

impl<'a> SectorMatchMut<'a> {
    fn len(&'a self) -> usize {
        self.sectors.len()
    }
    #[allow(dead_code)]
    fn iter_mut(&'a mut self) -> std::slice::IterMut<'a, &'a mut MetaSector> {
        self.sectors.iter_mut()
    }
}

#[derive(Default)]
struct MetaMask {
    has_bits: bool,
    mask: Vec<u8>,
}

impl MetaMask {
    fn empty(len: usize) -> MetaMask {
        MetaMask {
            has_bits: false,
            mask: vec![0; len],
        }
    }
    fn from(mask: &[u8]) -> MetaMask {
        let mut m = MetaMask::default();
        m.set_mask(mask);
        m
    }
    fn set_mask(&mut self, mask: &[u8]) {
        self.mask = mask.to_vec();
        self.has_bits = mask.iter().any(|&x| x != 0);
    }
    #[allow(dead_code)]
    fn or_mask(&mut self, source_mask: &MetaMask) {
        for (i, &m) in source_mask.iter().enumerate() {
            self.mask[i] |= m;
        }
        self.has_bits = self.mask.iter().any(|&x| x != 0);
    }
    fn or_slice(&mut self, source_mask: &[u8]) {
        for (i, &m) in source_mask.iter().enumerate() {
            self.mask[i] |= m;
        }
        self.has_bits = self.mask.iter().any(|&x| x != 0);
    }
    #[allow(dead_code)]
    fn clear(&mut self) {
        self.mask.fill(0);
        self.has_bits = false;
    }
    #[allow(dead_code)]
    fn mask(&self) -> &[u8] {
        &self.mask
    }
    fn has_bits(&self) -> bool {
        self.has_bits
    }
    fn iter(&self) -> std::slice::Iter<u8> {
        self.mask.iter()
    }
    #[allow(dead_code)]
    fn len(&self) -> usize {
        self.mask.len()
    }
}

pub(crate) struct MetaSector {
    id_chsn: DiskChsn,
    address_crc_error: bool,
    data_crc_error: bool,
    deleted_mark: bool,
    missing_data: bool,
    data: Vec<u8>,
    weak_mask: MetaMask,
    hole_mask: MetaMask,
}

impl MetaSector {
    pub fn read_data(&self) -> Vec<u8> {
        if self.missing_data {
            return Vec::new();
        }
        let mut data = self.data.clone();
        for (i, (weak_byte, hole_byte)) in self.weak_mask.iter().zip(self.hole_mask.iter()).enumerate() {
            let mask_byte = weak_byte | hole_byte;
            if mask_byte == 0 {
                continue;
            }
            let rand_byte = rand::random::<u8>();
            data[i] = data[i] & !mask_byte | rand_byte & mask_byte;
        }
        data
    }
}

pub struct MetaSectorTrack {
    pub(crate) ch: DiskCh,
    pub(crate) encoding: DiskDataEncoding,
    pub(crate) data_rate: DiskDataRate,
    pub(crate) sectors: Vec<MetaSector>,
    pub(crate) shared: Arc<Mutex<SharedDiskContext>>,
}

impl Track for MetaSectorTrack {
    fn resolution(&self) -> DiskDataResolution {
        DiskDataResolution::MetaSector
    }
    fn as_any(&self) -> &dyn Any {
        self
    }

    fn as_any_mut(&mut self) -> &mut dyn Any {
        self
    }

    fn as_metasector_track(&self) -> Option<&MetaSectorTrack> {
        self.as_any().downcast_ref::<MetaSectorTrack>()
    }

    fn as_bitstream_track(&self) -> Option<&BitStreamTrack> {
        None
    }

    fn as_fluxstream_track(&self) -> Option<&FluxStreamTrack> {
        None
    }

    fn as_fluxstream_track_mut(&mut self) -> Option<&mut FluxStreamTrack> {
        None
    }

    fn ch(&self) -> DiskCh {
        self.ch
    }

    fn set_ch(&mut self, new_ch: DiskCh) {
        self.ch = new_ch;
    }

    fn encoding(&self) -> DiskDataEncoding {
        self.encoding
    }

    fn info(&self) -> TrackInfo {
        TrackInfo {
            encoding: self.encoding,
            data_rate: self.data_rate,
            density: None,
            rpm: None,
            bit_length: 0,
            sector_ct: self.sectors.len(),
        }
    }

    fn metadata(&self) -> Option<&DiskStructureMetadata> {
        None
    }

    fn get_sector_ct(&self) -> usize {
        self.sectors.len()
    }

    fn has_sector_id(&self, sid: u8, id_chsn: Option<DiskChsn>) -> bool {
        if let Some(_) = &self.sectors.iter().find(|sector| {
            if id_chsn.is_none() && sector.id_chsn.s() == sid {
                return true;
            }
            else if let Some(chsn) = id_chsn {
                if sector.id_chsn == chsn {
                    return true;
                }
            }
            false
        }) {
            true
        }
        else {
            false
        }
    }

    fn get_sector_list(&self) -> Vec<SectorMapEntry> {
        self.sectors
            .iter()
            .map(|s| SectorMapEntry {
                chsn: s.id_chsn,
                address_crc_valid: !s.address_crc_error,
                data_crc_valid: !s.data_crc_error,
                deleted_mark: s.deleted_mark,
                no_dam: false,
            })
            .collect()
    }

    fn add_sector(&mut self, sd: &SectorDescriptor, alternate: bool) -> Result<(), DiskImageError> {
        // Create an empty weak bit mask if none is provided.
        let weak_mask = match &sd.weak_mask {
            Some(weak_buf) => MetaMask::from(weak_buf),
            None => MetaMask::empty(sd.data.len()),
        };

        let hole_mask = match &sd.hole_mask {
            Some(hole_buf) => MetaMask::from(hole_buf),
            None => MetaMask::empty(sd.data.len()),
        };

        let new_sector = MetaSector {
            id_chsn: sd.id_chsn,
            address_crc_error: sd.address_crc_error,
            data_crc_error: sd.data_crc_error,
            deleted_mark: sd.deleted_mark,
            missing_data: sd.missing_data,
            data: sd.data.clone(),
            weak_mask,
            hole_mask,
        };

        if alternate {
            // Look for existing sector.
            let existing_sector = self.sectors.iter_mut().find(|s| s.id_chsn == sd.id_chsn);

            if let Some(es) = existing_sector {
                // Update the existing sector.
                let mut xor_vec: Vec<u8> = Vec::with_capacity(es.data.len());

                // Calculate a bitmap representing the difference between the new sector data and the
                // existing sector data.
                for (i, (ns_byte, es_byte)) in new_sector.data.iter().zip(es.data.iter()).enumerate() {
                    xor_vec[i] = ns_byte ^ es_byte;
                }

                // Update the weak bit mask for the existing sector and return.
                es.weak_mask.or_slice(&xor_vec);
                return Ok(());
            }
        }

        self.sectors.push(new_sector);

        Ok(())
    }

    /// Read the sector data from the sector identified by 'chs'. The data is returned within a
    /// ReadSectorResult struct which also sets some convenience metadata flags where are needed
    /// when handling ByteStream images.
    /// When reading a BitStream image, the sector data includes the address mark and crc.
    /// Offsets are provided within ReadSectorResult so these can be skipped when processing the
    /// read operation.
    fn read_sector(
        &mut self,
        chs: DiskChs,
        n: Option<u8>,
        scope: RwSectorScope,
        debug: bool,
    ) -> Result<ReadSectorResult, DiskImageError> {
        match scope {
            // Add 4 bytes for address mark and 2 bytes for CRC.
            RwSectorScope::DataBlock => unimplemented!("DataBlock scope not supported for ByteStream"),
            RwSectorScope::DataOnly => {}
        };

        let sm = self.match_sectors(chs, n, debug);

        if sm.len() == 0 {
            log::debug!("read_sector(): No sector found for chs: {} n: {:?}", chs, n);
            Ok(ReadSectorResult {
                id_chsn: None,
                data_idx: 0,
                data_len: 0,
                read_buf: Vec::new(),
                deleted_mark: false,
                not_found: true,
                no_dam: false,
                address_crc_error: false,
                data_crc_error: false,
                wrong_cylinder: sm.wrong_cylinder,
                bad_cylinder: sm.bad_cylinder,
                wrong_head: sm.wrong_head,
            })
        }
        else {
            if sm.len() > 1 {
                log::warn!(
                    "read_sector(): Found {} sector ids matching chs: {} (with {} different sizes). Using first.",
                    sm.len(),
                    chs,
                    sm.sizes.len()
                );
            }
            let s = sm.sectors[0];

            Ok(ReadSectorResult {
                id_chsn: Some(s.id_chsn),
                data_idx: 0,
                data_len: s.data.len(),
                read_buf: s.read_data(), // Calling read_data applies the weak bit and hole masks.
                deleted_mark: s.deleted_mark,
                not_found: false,
                no_dam: false,
                address_crc_error: s.address_crc_error,
                data_crc_error: s.data_crc_error,
                wrong_cylinder: sm.wrong_cylinder,
                bad_cylinder: sm.bad_cylinder,
                wrong_head: sm.wrong_head,
            })
        }
    }

    fn scan_sector(&self, chs: DiskChs, n: Option<u8>) -> Result<ScanSectorResult, DiskImageError> {
        let sm = self.match_sectors(chs, n, false);

        if sm.len() == 0 {
            log::debug!("scan_sector(): No sector found for chs: {} n: {:?}", chs, n);
            Ok(ScanSectorResult {
                not_found: true,
                no_dam: false,
                deleted_mark: false,
                address_crc_error: false,
                data_crc_error: false,
                wrong_cylinder: sm.wrong_cylinder,
                bad_cylinder: sm.bad_cylinder,
                wrong_head: sm.wrong_head,
            })
        }
        else {
            log::warn!(
                "read_sector(): Found {} sector ids matching chs: {} (with {} different sizes). Using first.",
                sm.len(),
                chs,
                sm.sizes.len()
            );
            let s = sm.sectors[0];

            Ok(ScanSectorResult {
                deleted_mark: s.deleted_mark,
                not_found: false,
                no_dam: false,
                address_crc_error: s.address_crc_error,
                data_crc_error: s.data_crc_error,
                wrong_cylinder: sm.wrong_cylinder,
                bad_cylinder: sm.bad_cylinder,
                wrong_head: sm.wrong_head,
            })
        }
    }

    fn write_sector(
        &mut self,
        chs: DiskChs,
        n: Option<u8>,
        write_data: &[u8],
        _scope: RwSectorScope,
        write_deleted: bool,
        debug: bool,
    ) -> Result<WriteSectorResult, DiskImageError> {
        let mut sm = self.match_sectors_mut(chs, n, debug);

        if sm.len() > 1 {
            log::error!(
                "write_sector(): Could not identify unique target sector. (Found {} sector ids matching chs: {} n: {:?})",
                sm.len(),
                chs,
                n
            );
            return Err(DiskImageError::UniqueIdError);
        }
        else if sm.len() == 0 {
            log::debug!("write_sector(): No sector found for chs: {} n: {:?}", chs, n);
            return Ok(WriteSectorResult {
                not_found: false,
                no_dam: false,
                address_crc_error: false,
                wrong_cylinder: sm.wrong_cylinder,
                bad_cylinder: sm.bad_cylinder,
                wrong_head: sm.wrong_head,
            });
        }

        let write_data_len = write_data.len();
        if DiskChsn::n_to_bytes(sm.sectors[0].id_chsn.n()) != write_data_len {
            // Caller didn't provide correct buffer size.
            log::error!(
                "write_sector(): Data buffer size mismatch, expected: {} got: {}",
                DiskChsn::n_to_bytes(sm.sectors[0].id_chsn.n()),
                write_data_len
            );
            return Err(DiskImageError::ParameterError);
        }

        if sm.sectors[0].missing_data || sm.sectors[0].address_crc_error {
            log::debug!(
                "write_sector(): Sector {} is unwritable due to no DAM or bad address CRC.",
                sm.sectors[0].id_chsn
            );
        }
        else {
            sm.sectors[0].data.copy_from_slice(write_data);
            sm.sectors[0].deleted_mark = write_deleted;
        }

        sm.shared.lock().unwrap().writes += 1;

        Ok(WriteSectorResult {
            not_found: false,
            no_dam: sm.sectors[0].missing_data,
            address_crc_error: sm.sectors[0].address_crc_error,
            wrong_cylinder: sm.wrong_cylinder,
            bad_cylinder: sm.bad_cylinder,
            wrong_head: sm.wrong_head,
        })
    }

    fn get_hash(&mut self) -> Digest {
        let mut hasher = sha1_smol::Sha1::new();
        let rtr = self.read_all_sectors(self.ch, 0xFF, 0xFF).unwrap();
        hasher.update(&rtr.read_buf);
        hasher.digest()
    }

    /// Read all sectors from the track identified by 'ch'. The data is returned within a
    /// ReadSectorResult struct which also sets some convenience metadata flags which are needed
    /// when handling ByteStream images.
    /// Unlike read_sectors, the data returned is only the actual sector data. The address marks and
    /// CRCs are not included in the data.
    /// This function is intended for use in implementing the Read Track FDC command.
    fn read_all_sectors(&mut self, _ch: DiskCh, n: u8, track_len: u8) -> Result<ReadTrackResult, DiskImageError> {
        let track_len = track_len as u16;
        let sector_data_len = DiskChsn::n_to_bytes(n);
        let mut track_read_vec = Vec::with_capacity(sector_data_len * self.sectors.len());
        let mut address_crc_error = false;
        let mut data_crc_error = false;
        let mut deleted_mark = false;

        let mut not_found = true;
        let mut sectors_read = 0;

        for s in &self.sectors {
            log::trace!("read_all_sectors(): Found sector_id: {}", s.id_chsn,);
            not_found = false;

            // TODO - do we stop after reading sector ID specified by EOT, or
            //        or upon reaching it?
            if sectors_read >= track_len {
                log::trace!(
                    "read_all_sectors(): Reached track_len at sector: {} \
                        sectors_read: {}, track_len: {}",
                    s.id_chsn,
                    sectors_read,
                    track_len
                );
                break;
            }

            track_read_vec.extend(&s.read_data());
            sectors_read = sectors_read.saturating_add(1);

            if s.address_crc_error {
                address_crc_error |= true;
            }

            if s.data_crc_error {
                data_crc_error |= true;
            }

            if s.deleted_mark {
                deleted_mark |= true;
            }
        }
        let read_len = track_read_vec.len();
        Ok(ReadTrackResult {
            not_found,
            sectors_read,
            read_buf: track_read_vec,
            deleted_mark,
            address_crc_error,
            data_crc_error,
            read_len_bits: read_len * 16,
            read_len_bytes: read_len,
        })
    }

    fn get_next_id(&self, chs: DiskChs) -> Option<DiskChsn> {
        let first_sector = self.sectors.first()?;
        let mut sector_matched = false;
        for si in self.sectors.iter() {
            if sector_matched {
                return Some(DiskChsn::new(chs.c(), chs.h(), si.id_chsn.s(), si.id_chsn.n()));
            }
            if si.id_chsn.s() == chs.s() {
                // Have matching sector id
                sector_matched = true;
            }
        }
        // If we reached here, we matched the last sector in the list, so return the first
        // sector as we wrap around the track.
        if sector_matched {
            Some(DiskChsn::new(
                chs.c(),
                chs.h(),
                first_sector.id_chsn.s(),
                first_sector.id_chsn.n(),
            ))
        }
        else {
            None
        }
    }

    fn read_track(&mut self, _overdump: Option<usize>) -> Result<ReadTrackResult, DiskImageError> {
        Err(DiskImageError::UnsupportedFormat)
    }

    fn read_track_raw(&mut self, _overdump: Option<usize>) -> Result<ReadTrackResult, DiskImageError> {
        Err(DiskImageError::UnsupportedFormat)
    }

    fn has_weak_bits(&self) -> bool {
        self.sectors.iter().map(|s| s.weak_mask.has_bits()).any(|x| x)
    }

    fn format(
        &mut self,
        _standard: System34Standard,
        _format_buffer: Vec<DiskChsn>,
        _fill_pattern: &[u8],
        _gap3: usize,
    ) -> Result<(), DiskImageError> {
        // TODO: Implement format for MetaSectorTrack
        Err(DiskImageError::UnsupportedFormat)
    }

    fn get_track_consistency(&self) -> Result<TrackConsistency, DiskImageError> {
        let sector_ct = self.sectors.len();
        let mut consistency = TrackConsistency::default();

        let mut n_set: FoxHashSet<u8> = FoxHashSet::new();
        let mut last_n = 0;
        for (si, sector) in self.sectors.iter().enumerate() {
            if sector.id_chsn.s() != si as u8 + 1 {
                consistency.nonconsecutive_sectors = true;
            }
            if sector.data_crc_error {
                consistency.bad_data_crc = true;
            }
            if sector.address_crc_error {
                consistency.bad_address_crc = true;
            }
            if sector.deleted_mark {
                consistency.deleted_data = true;
            }
            last_n = sector.id_chsn.n();
            n_set.insert(sector.id_chsn.n());
        }

        if n_set.len() > 1 {
            consistency.consistent_sector_size = None;
        }
        else {
            consistency.consistent_sector_size = Some(last_n);
        }

        consistency.sector_ct = sector_ct;
        Ok(consistency)
    }

    fn get_track_stream(&self) -> Option<&TrackDataStream> {
        None
    }
}

impl MetaSectorTrack {
    #[allow(dead_code)]
    fn add_write(&mut self, _bytes: usize) {
        self.shared.lock().unwrap().writes += 1;
    }

    fn match_sectors(&self, chs: DiskChs, n: Option<u8>, debug: bool) -> SectorMatch {
        let mut wrong_cylinder = false;
        let mut bad_cylinder = false;
        let mut wrong_head = false;

        let mut sizes = FoxHashSet::new();
        let matching_sectors: Vec<&MetaSector> = self
            .sectors
            .iter()
            .filter(|s| {
                let matched_s = s.id_chsn.s() == chs.s();
                if s.id_chsn.c() != chs.c() {
                    wrong_cylinder = true;
                }
                if s.id_chsn.c() == 0xFF {
                    bad_cylinder = true;
                }
                if s.id_chsn.h() != chs.h() {
                    wrong_head = true;
                }
                sizes.insert(s.id_chsn.n());
                (debug && matched_s)
                    || ((DiskChs::from(s.id_chsn) == chs) && (n.is_none() || s.id_chsn.n() == n.unwrap()))
            })
            .collect();

        SectorMatch {
            sectors: matching_sectors,
            sizes: sizes.iter().cloned().collect(),
            wrong_cylinder,
            bad_cylinder,
            wrong_head,
        }
    }

    fn match_sectors_mut(&mut self, chs: DiskChs, n: Option<u8>, debug: bool) -> SectorMatchMut {
        let mut wrong_cylinder = false;
        let mut bad_cylinder = false;
        let mut wrong_head = false;

        let mut sizes = FoxHashSet::new();
        let matching_sectors: Vec<&mut MetaSector> = self
            .sectors
            .iter_mut()
            .filter(|s| {
                let matched_s = s.id_chsn.s() == chs.s();
                if s.id_chsn.c() != chs.c() {
                    wrong_cylinder = true;
                }
                if s.id_chsn.c() == 0xFF {
                    bad_cylinder = true;
                }
                if s.id_chsn.h() != chs.h() {
                    wrong_head = true;
                }
                sizes.insert(s.id_chsn.n());
                (debug && matched_s)
                    || ((DiskChs::from(s.id_chsn) == chs) && (n.is_none() || s.id_chsn.n() == n.unwrap()))
            })
            .collect();

        SectorMatchMut {
            sectors: matching_sectors,
            sizes: sizes.iter().cloned().collect(),
            wrong_cylinder,
            bad_cylinder,
            wrong_head,
            shared: self.shared.clone(),
        }
    }
}