flpdf 0.1.7

A pure-Rust PDF toolkit modeled on qpdf — read, rewrite, linearize, and inspect PDFs.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
//! ObjStm eligibility predicate — decides whether an indirect object may be
//! stored inside an object stream (PDF 1.5+, ISO 32000-1 §7.5.7).
//! Also provides the packing planner that groups eligible objects into batches.
//! Provides the body emitter that serialises a list of objects into an ObjStm
//! payload (§7.5.7 body format; compression/dict wrapping is done in a
//! subsequent step).

// These items are consumed by the upcoming ObjStm writer; suppress dead_code
// until that code lands.
#![allow(dead_code)]

use std::collections::{BTreeMap, BTreeSet, HashSet};
use std::num::NonZeroUsize;

use crate::object::{Dictionary, Object, ObjectRef};
use crate::XrefOffset;

// ── Public types ─────────────────────────────────────────────────────────────

/// Context resolved once per document, used to identify objects that must stay
/// outside any ObjStm.
pub(crate) struct EligibilityContext {
    /// The indirect reference of the encryption dictionary, if any.
    pub encryption_ref: Option<ObjectRef>,
    /// The indirect reference of the linearization parameter dictionary, if any.
    pub linearization_param_ref: Option<ObjectRef>,
}

// ── Predicate ────────────────────────────────────────────────────────────────

/// Returns `true` when the object identified by `object_ref` with body
/// `object` may be stored inside an ObjStm.
///
/// Disqualifying conditions (PDF spec + implementation constraints):
/// 1. `object_ref.generation != 0`  — ObjStm members must have generation 0.
/// 2. `object` is a [`Object::Stream`] — streams cannot be embedded in ObjStm.
/// 3. The object is a dictionary with `/Type /ObjStm` — no nested ObjStm.
/// 4. The object is a dictionary with `/Type /XRef` — xref streams must be direct.
/// 5. `object_ref` is the encryption dictionary reference.
/// 6. `object_ref` is the linearization parameter dictionary reference.
pub(crate) fn is_eligible_for_objstm(
    object_ref: ObjectRef,
    object: &Object,
    ctx: &EligibilityContext,
) -> bool {
    // 1. Generation must be 0.
    if object_ref.generation != 0 {
        return false;
    }

    // 2. Stream objects cannot be embedded.
    if matches!(object, Object::Stream(_)) {
        return false;
    }

    // 3 & 4. Check /Type for Dictionary objects.
    if let Some(dict) = object.as_dict() {
        if dict_type_is(dict, b"ObjStm") || dict_type_is(dict, b"XRef") {
            return false;
        }
    }

    // 5. Encryption dictionary must not be embedded.
    if Some(object_ref) == ctx.encryption_ref {
        return false;
    }

    // 6. Linearization parameter dictionary must not be embedded.
    if Some(object_ref) == ctx.linearization_param_ref {
        return false;
    }

    true
}

// ── Context builder ──────────────────────────────────────────────────────────

/// Build an [`EligibilityContext`] by querying `pdf` for the encryption and
/// linearization parameter references.  Must be called once before processing
/// any objects; the result is then used with [`is_eligible_for_objstm`] which
/// is a pure function.
pub(crate) fn eligibility_context<R: std::io::Read + std::io::Seek>(
    pdf: &mut crate::reader::Pdf<R>,
) -> crate::Result<EligibilityContext> {
    Ok(EligibilityContext {
        encryption_ref: pdf.encryption_ref(),
        linearization_param_ref: pdf.linearized_hint_ref()?,
    })
}

// ── Packing planner types ────────────────────────────────────────────────────

/// Controls how the ObjStm packing planner groups objects into batches.
///
/// Mirrors `qpdf --object-streams=preserve|disable|generate`. The default,
/// `Preserve`, matches qpdf's behaviour for a plain `qpdf in.pdf out.pdf`
/// invocation: ObjStms present in the input are reused; their membership is
/// not repartitioned.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
pub enum ObjectStreamMode {
    /// Keep the original ObjStm membership from the source document.
    #[default]
    Preserve,
    /// Emit no ObjStms; all eligible objects become plain indirects.
    Disable,
    /// Pack eligible objects into fresh ObjStms (greedy with cap).
    Generate,
}

/// qpdf's default ObjStm batch size cap.
pub(crate) const DEFAULT_BATCH_SIZE_CAP: NonZeroUsize = match NonZeroUsize::new(100) {
    Some(n) => n,
    None => unreachable!(),
};

/// Configuration for the ObjStm packing planner.
#[derive(Debug, Clone, PartialEq, Eq)]
pub(crate) struct PlannerConfig {
    pub mode: ObjectStreamMode,
    /// Maximum number of members per ObjStm batch. qpdf default is 100.
    pub batch_size_cap: NonZeroUsize,
}

impl Default for PlannerConfig {
    fn default() -> Self {
        Self {
            mode: ObjectStreamMode::Preserve,
            batch_size_cap: DEFAULT_BATCH_SIZE_CAP,
        }
    }
}

/// The output of the packing planner: an ordered list of batches,
/// each of which will become one ObjStm in the output.
#[derive(Debug, Clone, PartialEq, Eq, Default)]
pub(crate) struct PackingPlan {
    /// Each inner `Vec` is one ObjStm batch, members in deterministic order.
    pub batches: Vec<Vec<ObjectRef>>,
}

/// Convert public [`WriteOptions`](crate::WriteOptions) into an internal
/// [`PlannerConfig`].  The conversion is direct: `WriteOptions.object_streams`
/// names the policy, and the planner's batch cap defaults to qpdf's value of
/// 100.  Future writer-side knobs (e.g. an explicit cap override) would be
/// threaded through this conversion.
///
/// When `options.qdf` is `true`, the effective mode is forced to
/// [`ObjectStreamMode::Disable`] regardless of `options.object_streams`.  QDF
/// output must not contain any ObjStm containers.  `options.object_streams` is
/// intentionally left unmodified so that conflicts between
/// `--qdf` and an explicit `--object-streams=generate` flag can be detected.
pub(crate) fn planner_config_from_options(options: &crate::WriteOptions) -> PlannerConfig {
    let mode = if options.qdf {
        ObjectStreamMode::Disable
    } else {
        options.object_streams
    };
    PlannerConfig {
        mode,
        batch_size_cap: DEFAULT_BATCH_SIZE_CAP,
    }
}

// ── Packing planner ──────────────────────────────────────────────────────────

/// Decide how many ObjStms to emit and which objects belong in each.
///
/// - `Disable`  → returns an empty plan (zero batches).
/// - `Preserve` → reconstructs the source document's ObjStm grouping,
///   skipping ineligible members and splitting batches that exceed the cap.
/// - `Generate` → greedily packs all eligible objects in
///   `(number, generation)` ascending order, cap-delimited.
pub(crate) fn plan_object_streams<R: std::io::Read + std::io::Seek>(
    pdf: &mut crate::reader::Pdf<R>,
    config: &PlannerConfig,
) -> crate::Result<PackingPlan> {
    if config.mode == ObjectStreamMode::Disable {
        return Ok(PackingPlan::default());
    }

    let ctx = eligibility_context(pdf)?;
    let length_exclusions = collect_indirect_objstm_length_refs(pdf)?;

    match config.mode {
        ObjectStreamMode::Disable => unreachable!(),
        ObjectStreamMode::Preserve => plan_preserve(pdf, config, &ctx, &length_exclusions),
        ObjectStreamMode::Generate => plan_generate(pdf, config, &ctx, &length_exclusions),
    }
}

/// Eligible objects in qpdf's `QPDF::getCompressibleObjGens` order
/// (libqpdf/QPDF.cc:2392): a depth-first walk from the trailer, descending into
/// dictionary values in ascending key order and array items in order. This
/// traversal order — not object-number order — decides which objects co-locate
/// in a generated object stream when more than one container is needed, so the
/// port must reproduce it exactly.
///
/// Returns each reachable indirect object's reference in first-visit order. A
/// reference with no live cross-reference entry (a dangling/missing ref that
/// resolves to `Null` only because the object is absent) is excluded: qpdf
/// treats such a ref as null, so it never enters the compressible set.
pub(crate) fn compressible_objgens<R: std::io::Read + std::io::Seek>(
    pdf: &mut crate::reader::Pdf<R>,
) -> crate::Result<Vec<ObjectRef>> {
    let mut visited: BTreeSet<u32> = BTreeSet::new();
    let mut result: Vec<ObjectRef> = Vec::new();
    // Live xref entries only (excludes Missing / Deleted / Reserved). A reached
    // ref outside this set is a dangling reference qpdf would treat as null, so
    // it is dropped. A *live* object that resolves to null (a real
    // `n 0 obj null endobj`) stays eligible here — flpdf keeps it as an ObjStm
    // member, whereas qpdf drops every null-resolving object. That residual
    // divergence is out of scope for this filter (which targets only
    // missing/dangling refs) and is tracked separately (flpdf-v58c).
    let live: BTreeSet<ObjectRef> = pdf.live_object_refs().into_iter().collect();
    // The encryption dictionary is excluded from the result, matching qpdf's
    // `m->trailer.getKey("/Encrypt")` guard (QPDF.cc:2402/2437): it must stay a
    // plain indirect object so the rest of the file can be decrypted. Read it
    // from the trailer's `/Encrypt` reference (it is still traversed for any
    // child references, like a stream or signature dictionary).
    let encrypt_ref = match pdf.trailer().get("Encrypt") {
        Some(Object::Reference(r)) => Some(*r),
        _ => None,
    };
    // qpdf seeds the stack with the trailer dictionary itself (a direct object).
    let mut stack: Vec<Object> = vec![Object::Dictionary(pdf.trailer().clone())];

    while let Some(obj) = stack.pop() {
        match obj {
            Object::Reference(r) => {
                if !visited.insert(r.number) {
                    continue;
                }
                // Borrow (do not clone) the resolved object: it is only read
                // within this iteration to test eligibility and push its
                // children, so cloning would needlessly copy a stream's entire
                // data payload (potentially megabytes).
                let resolved = pdf.resolve_borrowed(r)?;
                // Streams, signature value dictionaries, and the encryption
                // dictionary cannot be stored inside an object stream, so they
                // are excluded from the result — but they are still traversed for
                // child references (QPDF.cc:2437-2445).
                if !matches!(resolved, Object::Stream(_))
                    && !is_signature_dict(resolved)
                    && Some(r) != encrypt_ref
                    && live.contains(&r)
                {
                    result.push(r);
                }
                push_children(resolved, &mut stack);
            }
            // Direct (inline) container: traversed for its children but never
            // contributes a reference (it has no object number of its own).
            other => push_children(&other, &mut stack),
        }
    }

    Ok(result)
}

/// Distribute `eligible` objects into object-stream groups using qpdf's
/// `generateObjectStreams` algorithm (QPDFWriter.cc:1969-2005): pick
/// `ceil(n / 100)` streams so none exceeds 100 members, then spread the objects
/// approximately evenly — `n_per = ceil(n / streams)` consecutive members per
/// stream — in the given (traversal) order. Returns one inner `Vec` per stream;
/// an empty input yields no streams. (qpdf is `(n + 99) / 100` then
/// `n / streams` rounded up; `div_ceil` expresses both directly.)
pub(crate) fn even_split_into_streams(eligible: &[ObjectRef]) -> Vec<Vec<ObjectRef>> {
    let n = eligible.len();
    if n == 0 {
        return Vec::new();
    }
    let n_streams = n.div_ceil(100);
    let n_per = n.div_ceil(n_streams);
    eligible.chunks(n_per).map(|chunk| chunk.to_vec()).collect()
}

/// Returns `true` for a signature value dictionary: `/Type /Sig` carrying both
/// `/ByteRange` and `/Contents` (matching qpdf's `isDictionaryOfType("/Sig")`
/// guard at QPDF.cc:2440). The signed byte range must stay outside any object
/// stream.
fn is_signature_dict(obj: &Object) -> bool {
    let Some(dict) = obj.as_dict() else {
        return false; // cov:ignore: callers gate on non-stream resolved dicts
    };
    dict_type_is(dict, b"Sig") && dict.get("ByteRange").is_some() && dict.get("Contents").is_some()
}

/// Push an object's child values onto the DFS stack so they pop in qpdf's
/// traversal order: dictionary values in ascending key order, array items in
/// index order. (A LIFO stack pops in reverse insertion order, so children are
/// pushed reversed.)
fn push_children(obj: &Object, stack: &mut Vec<Object>) {
    match obj {
        Object::Dictionary(d) => push_dict_children(d, stack, false),
        // A stream is traversed via its dictionary; the data bytes are opaque.
        Object::Stream(s) => push_dict_children(&s.dict, stack, true),
        Object::Array(items) => {
            for v in items.iter().rev() {
                stack.push(v.clone());
            }
        }
        _ => {}
    }
}

/// Push a dictionary's values onto the DFS stack in ascending-key pop order.
/// For a stream dictionary (`is_stream`), `/Length` is omitted from the
/// traversal, matching qpdf (QPDF.cc:2451): an indirect length holder must not
/// be pulled into the compressible set via the stream.
fn push_dict_children(d: &Dictionary, stack: &mut Vec<Object>, is_stream: bool) {
    let entries: Vec<(&[u8], &Object)> = d.iter().collect();
    for (key, value) in entries.into_iter().rev() {
        if is_stream && key == b"Length" {
            continue;
        }
        stack.push(value.clone());
    }
}

/// Collect the set of ObjectRefs that serve as indirect /Length targets of any
/// ObjStm stream in the document.  ISO 32000-1 §7.5.7 prohibits those objects
/// from being stored inside an ObjStm themselves.
pub(crate) fn collect_indirect_objstm_length_refs<R: std::io::Read + std::io::Seek>(
    pdf: &mut crate::reader::Pdf<R>,
) -> crate::Result<BTreeSet<ObjectRef>> {
    let mut excluded = BTreeSet::new();
    let refs: Vec<ObjectRef> = pdf.object_refs();
    for r in refs {
        let obj = pdf.resolve_borrowed(r)?;
        if let Some(s) = obj.as_stream() {
            if dict_type_is(&s.dict, b"ObjStm") {
                if let Some(Object::Reference(len_ref)) = s.dict.get("Length") {
                    excluded.insert(*len_ref);
                }
            }
        }
    }
    Ok(excluded)
}

/// Preserve mode: reconstruct source ObjStm grouping.
fn plan_preserve<R: std::io::Read + std::io::Seek>(
    pdf: &mut crate::reader::Pdf<R>,
    config: &PlannerConfig,
    ctx: &EligibilityContext,
    length_exclusions: &BTreeSet<ObjectRef>,
) -> crate::Result<PackingPlan> {
    let entries = pdf.source_xref_entries();

    // Group members by (container_number, index) so we can reconstruct order.
    // Key: container object number; Value: list of (index, ObjectRef).
    let mut groups: BTreeMap<u32, Vec<(u32, ObjectRef)>> = BTreeMap::new();

    for (obj_ref, offset) in &entries {
        if let XrefOffset::Compressed { stream, index } = offset {
            groups.entry(*stream).or_default().push((*index, *obj_ref));
        }
    }

    let cap = config.batch_size_cap.get();
    let mut batches: Vec<Vec<ObjectRef>> = Vec::new();

    // Iterate containers in ascending container-number order.
    for (_container_num, mut members) in groups {
        // Sort by index within the container to get deterministic order.
        members.sort_by_key(|(idx, _)| *idx);

        // Filter ineligible members.
        let mut eligible: Vec<ObjectRef> = Vec::new();
        for (_idx, obj_ref) in members {
            if length_exclusions.contains(&obj_ref) {
                continue;
            }
            let obj = pdf.resolve_borrowed(obj_ref)?;
            if is_eligible_for_objstm(obj_ref, obj, ctx) {
                eligible.push(obj_ref);
            }
        }

        // Split into cap-sized batches (preserving order, same container slot).
        for chunk in eligible.chunks(cap) {
            if !chunk.is_empty() {
                batches.push(chunk.to_vec());
            }
        }
    }

    Ok(PackingPlan { batches })
}

/// Generate mode: greedily pack all eligible objects in number/generation order.
fn plan_generate<R: std::io::Read + std::io::Seek>(
    pdf: &mut crate::reader::Pdf<R>,
    config: &PlannerConfig,
    ctx: &EligibilityContext,
    length_exclusions: &BTreeSet<ObjectRef>,
) -> crate::Result<PackingPlan> {
    // Collect refs, excluding free (deleted) entries — they resolve to Null but
    // are not real objects and must never be placed in an ObjStm.
    let source_entries = pdf.source_xref_entries();
    let free_refs: BTreeSet<ObjectRef> = source_entries
        .iter()
        .filter_map(|(r, offset)| {
            if matches!(offset, XrefOffset::Free { .. }) {
                Some(*r)
            } else {
                None
            }
        })
        .collect();

    let mut refs: Vec<ObjectRef> = pdf
        .object_refs()
        .into_iter()
        .filter(|r| !free_refs.contains(r))
        .collect();
    refs.sort_by_key(|r| (r.number, r.generation));

    let cap = config.batch_size_cap.get();
    let mut current_batch: Vec<ObjectRef> = Vec::new();
    let mut batches: Vec<Vec<ObjectRef>> = Vec::new();

    for obj_ref in refs {
        if length_exclusions.contains(&obj_ref) {
            continue;
        }
        let obj = pdf.resolve_borrowed(obj_ref)?;
        if !is_eligible_for_objstm(obj_ref, obj, ctx) {
            continue;
        }
        current_batch.push(obj_ref);
        if current_batch.len() >= cap {
            batches.push(std::mem::take(&mut current_batch));
        }
    }
    if !current_batch.is_empty() {
        batches.push(current_batch);
    }

    Ok(PackingPlan { batches })
}

// ── ObjStm body emitter ───────────────────────────────────────────────────────

/// The serialised body of an ObjStm (ISO 32000-1 §7.5.7).
///
/// Contains the raw pair table concatenated with the objects section.
/// Compression (FlateDecode) and the stream dictionary wrapping are handled
/// by a subsequent step.
#[derive(Debug, Clone, PartialEq, Eq)]
pub(crate) struct ObjStmBody {
    /// Raw concatenation: pair table || objects section.  To be deflate-wrapped later.
    pub bytes: Vec<u8>,
    /// Offset within `bytes` where the first object body starts.  Matches /First.
    pub first_offset: usize,
    /// Number of members.  Matches /N.
    pub n_members: usize,
}

/// Serialise a list of pre-resolved `(ObjectRef, Object)` pairs into an ObjStm
/// body following ISO 32000-1 §7.5.7.
///
/// This inner function does the real work without touching a `Pdf` reader; it
/// exists primarily to make unit-testing Pdf-free.
pub(crate) fn emit_objstm_body_from_resolved(
    members: &[(ObjectRef, Object)],
) -> crate::Result<ObjStmBody> {
    if members.is_empty() {
        return Ok(ObjStmBody {
            bytes: vec![],
            first_offset: 0,
            n_members: 0,
        });
    }

    // Duplicate detection — fail fast before producing any output.
    let mut seen: HashSet<u32> = HashSet::with_capacity(members.len());
    for (obj_ref, _) in members {
        if !seen.insert(obj_ref.number) {
            return Err(crate::Error::Unsupported(format!(
                "duplicate member in ObjStm batch {}",
                obj_ref.number
            )));
        }
    }

    // Build the objects section and record per-member offsets.
    let mut objects_section: Vec<u8> = Vec::new();
    let mut offsets: Vec<usize> = Vec::with_capacity(members.len());

    for (_, obj) in members {
        offsets.push(objects_section.len());
        obj.write_pdf(&mut objects_section);
        // Append exactly one newline after each object body (write_pdf has no trailing LF).
        objects_section.push(b'\n');
    }

    // Build the pair table: `<number> <offset>` for each member, all
    // space-separated on a single line with one trailing newline before the
    // objects section — qpdf 11.9.0's `/Type /ObjStm` layout (a newline after
    // each pair, as flpdf used to emit, is valid PDF but not byte-identical).
    let mut pair_table: Vec<u8> = Vec::new();
    use std::io::Write as _;
    for (i, ((obj_ref, _), offset)) in members.iter().zip(offsets.iter()).enumerate() {
        if i > 0 {
            pair_table.push(b' ');
        }
        // Write directly into `pair_table` to avoid a temporary `String`
        // allocation per member.
        let _ = write!(pair_table, "{} {}", obj_ref.number, offset);
    }
    pair_table.push(b'\n');

    let first_offset = pair_table.len();

    // Concatenate: pair table || objects section.
    let mut bytes = pair_table;
    bytes.extend_from_slice(&objects_section);

    Ok(ObjStmBody {
        bytes,
        first_offset,
        n_members: members.len(),
    })
}

/// Resolve each member reference from `pdf` then call
/// [`emit_objstm_body_from_resolved`].
pub(crate) fn emit_objstm_body<R: std::io::Read + std::io::Seek>(
    pdf: &mut crate::reader::Pdf<R>,
    members: &[ObjectRef],
) -> crate::Result<ObjStmBody> {
    let resolved: crate::Result<Vec<(ObjectRef, Object)>> = members
        .iter()
        .map(|&r| pdf.resolve(r).map(|obj| (r, obj)))
        .collect();
    emit_objstm_body_from_resolved(&resolved?)
}

// ── ObjStm stream wrapper ────────────────────────────────────────────────────

/// Wrap an [`ObjStmBody`] and build the complete `/Type /ObjStm` stream
/// dictionary (ISO 32000-1 §7.5.7).
///
/// The returned [`crate::Stream`] is ready to be written as an indirect object.
/// Key order follows qpdf parity: `Type → N → First → Length → Filter`.
///
/// The `compress` parameter controls whether the body bytes are compressed with
/// FlateDecode (`CompressStreams::Yes`, the default) or emitted raw
/// (`CompressStreams::No`).  Passing the same [`crate::writer::CompressStreams`]
/// value that drives the surrounding full-rewrite loop ensures the ObjStm
/// container uses the same policy as every other stream in the document.
pub(crate) fn wrap_objstm_body(
    body: &ObjStmBody,
    compress: crate::writer::CompressStreams,
) -> crate::Result<crate::Stream> {
    match compress {
        crate::writer::CompressStreams::Yes => {
            // Build a temporary encode dict with /Filter /FlateDecode.
            let mut encode_dict = Dictionary::new();
            encode_dict.insert("Filter", Object::Name(b"FlateDecode".to_vec()));

            // Compress the body bytes via the existing helper.
            let encoded = crate::filters::encode_stream_data(&encode_dict, &body.bytes)?;

            // Build the final stream dictionary in qpdf-compatible key order.
            let mut dict = Dictionary::new();
            dict.insert("Type", Object::Name(b"ObjStm".to_vec()));
            dict.insert("N", Object::Integer(body.n_members as i64));
            dict.insert("First", Object::Integer(body.first_offset as i64));
            dict.insert("Length", Object::Integer(encoded.len() as i64));
            dict.insert("Filter", Object::Name(b"FlateDecode".to_vec()));

            Ok(crate::Stream {
                dict,
                data: encoded,
            })
        }
        crate::writer::CompressStreams::No => {
            // Emit raw (uncompressed) body bytes without any /Filter.
            let mut dict = Dictionary::new();
            dict.insert("Type", Object::Name(b"ObjStm".to_vec()));
            dict.insert("N", Object::Integer(body.n_members as i64));
            dict.insert("First", Object::Integer(body.first_offset as i64));
            dict.insert("Length", Object::Integer(body.bytes.len() as i64));
            // No /Filter key — body is raw plaintext.

            Ok(crate::Stream {
                dict,
                data: body.bytes.clone(),
            })
        }
    }
}

// ── Helpers ──────────────────────────────────────────────────────────────────

/// Returns `true` when `dict` contains `/Type /<expected>`.
fn dict_type_is(dict: &Dictionary, expected: &[u8]) -> bool {
    matches!(dict.get("Type"), Some(Object::Name(n)) if n.as_slice() == expected)
}

// ── Tests ────────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;
    use crate::object::{Dictionary, Stream};

    fn no_ctx() -> EligibilityContext {
        EligibilityContext {
            encryption_ref: None,
            linearization_param_ref: None,
        }
    }

    fn ref0(n: u32) -> ObjectRef {
        ObjectRef::new(n, 0)
    }

    fn ref1(n: u32) -> ObjectRef {
        ObjectRef::new(n, 1)
    }

    /// Build a minimal classic-xref PDF with `n` pages whose `/Kids` are listed
    /// in DESCENDING object number, so the document's depth-first traversal
    /// order (Catalog, Pages, then kids in array order) differs from numeric
    /// object-number order. Object layout: 1=Catalog, 2=Pages, 3..n+2=Page
    /// dicts. Mirrors `docs/plans/tools/gen_multipage.py --reverse`.
    fn reverse_kids_pdf(n: u32) -> Vec<u8> {
        let page_nums: Vec<u32> = (3..3 + n).collect();
        let mut objs: Vec<(u32, Vec<u8>)> = Vec::new();
        objs.push((1, b"<< /Type /Catalog /Pages 2 0 R >>".to_vec()));
        let kids: Vec<u8> = page_nums
            .iter()
            .rev()
            .flat_map(|k| format!("{k} 0 R ").into_bytes())
            .collect();
        objs.push((
            2,
            format!(
                "<< /Type /Pages /Count {n} /Kids [ {} ] >>",
                String::from_utf8(kids).unwrap().trim_end()
            )
            .into_bytes(),
        ));
        for k in &page_nums {
            objs.push((
                *k,
                format!("<< /Type /Page /Parent 2 0 R /MediaBox [0 0 612 792] /PageMark {k} >>")
                    .into_bytes(),
            ));
        }

        let mut out: Vec<u8> = b"%PDF-1.5\n%\xe2\xe3\xcf\xd3\n".to_vec();
        let total = n + 3; // objects 0..=n+2
        let mut offsets: Vec<usize> = vec![0; total as usize];
        for (num, body) in &objs {
            offsets[*num as usize] = out.len();
            out.extend_from_slice(format!("{num} 0 obj\n").as_bytes());
            out.extend_from_slice(body);
            out.extend_from_slice(b"\nendobj\n");
        }
        let xref_start = out.len();
        out.extend_from_slice(format!("xref\n0 {total}\n").as_bytes());
        out.extend_from_slice(b"0000000000 65535 f \n");
        for num in 1..total {
            out.extend_from_slice(format!("{:010} 00000 n \n", offsets[num as usize]).as_bytes());
        }
        out.extend_from_slice(format!("trailer\n<< /Size {total} /Root 1 0 R >>\n").as_bytes());
        out.extend_from_slice(format!("startxref\n{xref_start}\n%%EOF\n").as_bytes());
        out
    }

    /// qpdf's `QPDF::getCompressibleObjGens` (QPDF.cc:2392) walks the document
    /// from the trailer depth-first, so the eligible objects come back in
    /// traversal order — Catalog, Pages, then page dicts in `/Kids` array order
    /// — NOT object-number order. Verified empirically against qpdf 11.9.0: on a
    /// 130-page reverse-`/Kids` fixture the first object stream holds the pages
    /// reached first in the array walk, not the lowest-numbered pages.
    #[test]
    fn compressible_objgens_is_qpdf_dfs_traversal_order() {
        let bytes = reverse_kids_pdf(3);
        let mut pdf = crate::reader::Pdf::open(std::io::Cursor::new(bytes)).unwrap();
        let order = compressible_objgens(&mut pdf).unwrap();
        // Catalog(1), Pages(2), then kids in array order [5,4,3] (descending).
        assert_eq!(
            order,
            vec![ref0(1), ref0(2), ref0(5), ref0(4), ref0(3)],
            "eligible objects must be in qpdf depth-first traversal order, not numeric order"
        );
    }

    /// Build a classic-xref PDF from pre-formatted object bodies (the bytes
    /// between `N 0 obj\n` and `\nendobj`), `/Root 1 0 R`. Object numbers must be
    /// `1..=bodies.len()` and supplied in ascending order.
    fn pdf_from_bodies(bodies: &[(u32, Vec<u8>)]) -> Vec<u8> {
        let mut out: Vec<u8> = b"%PDF-1.5\n%\xe2\xe3\xcf\xd3\n".to_vec();
        let total = bodies.len() as u32 + 1; // + free object 0
        let mut offsets: Vec<usize> = vec![0; total as usize];
        for (num, body) in bodies {
            offsets[*num as usize] = out.len();
            out.extend_from_slice(format!("{num} 0 obj\n").as_bytes());
            out.extend_from_slice(body);
            out.extend_from_slice(b"\nendobj\n");
        }
        let xref_start = out.len();
        out.extend_from_slice(format!("xref\n0 {total}\n").as_bytes());
        out.extend_from_slice(b"0000000000 65535 f \n");
        for num in 1..total {
            out.extend_from_slice(format!("{:010} 00000 n \n", offsets[num as usize]).as_bytes());
        }
        out.extend_from_slice(format!("trailer\n<< /Size {total} /Root 1 0 R >>\n").as_bytes());
        out.extend_from_slice(format!("startxref\n{xref_start}\n%%EOF\n").as_bytes());
        out
    }

    /// One-page document whose page `/Contents` is a stream (obj 4); the stream
    /// dictionary references obj 5 via `/Meta`, and obj 5 is reachable ONLY
    /// through that stream dictionary.
    fn pdf_with_content_stream() -> Vec<u8> {
        pdf_from_bodies(&[
            (1, b"<< /Type /Catalog /Pages 2 0 R >>".to_vec()),
            (2, b"<< /Type /Pages /Count 1 /Kids [ 3 0 R ] >>".to_vec()),
            (
                3,
                b"<< /Type /Page /Parent 2 0 R /MediaBox [0 0 612 792] /Contents 4 0 R >>".to_vec(),
            ),
            (
                4,
                b"<< /Length 3 /Meta 5 0 R >>\nstream\nq Q\nendstream".to_vec(),
            ),
            (5, b"<< /Type /Metadata /Marker 5 >>".to_vec()),
        ])
    }

    /// qpdf's `getCompressibleObjGens` excludes stream objects from the result
    /// (streams cannot live inside an object stream, QPDF.cc:2439), even though
    /// it still traverses their dictionaries for children.
    #[test]
    fn compressible_objgens_excludes_stream_objects() {
        let mut pdf =
            crate::reader::Pdf::open(std::io::Cursor::new(pdf_with_content_stream())).unwrap();
        let order = compressible_objgens(&mut pdf).unwrap();
        assert!(
            !order.contains(&ref0(4)),
            "the content stream (obj 4) must not be a compressible object; got {order:?}"
        );
    }

    /// qpdf traverses a stream's DICTIONARY for child references (QPDF.cc:2445),
    /// so an object reachable only through a stream dictionary is still found.
    #[test]
    fn compressible_objgens_traverses_stream_dictionary_children() {
        let mut pdf =
            crate::reader::Pdf::open(std::io::Cursor::new(pdf_with_content_stream())).unwrap();
        let order = compressible_objgens(&mut pdf).unwrap();
        assert!(
            order.contains(&ref0(5)),
            "obj 5, reachable only via the stream dict's /Meta, must be found; got {order:?}"
        );
    }

    /// qpdf omits a stream's `/Length` from the traversal (QPDF.cc:2451), so an
    /// object reachable ONLY as an indirect length holder is not pulled into the
    /// compressible set. obj 5 here is the indirect `/Length` target of stream 4
    /// and is reachable nowhere else.
    #[test]
    fn compressible_objgens_omits_indirect_stream_length_holder() {
        let bytes = pdf_from_bodies(&[
            (1, b"<< /Type /Catalog /Pages 2 0 R >>".to_vec()),
            (2, b"<< /Type /Pages /Count 1 /Kids [ 3 0 R ] >>".to_vec()),
            (
                3,
                b"<< /Type /Page /Parent 2 0 R /MediaBox [0 0 612 792] /Contents 4 0 R >>".to_vec(),
            ),
            (4, b"<< /Length 5 0 R >>\nstream\nq Q\nendstream".to_vec()),
            (5, b"3".to_vec()),
        ]);
        let mut pdf = crate::reader::Pdf::open(std::io::Cursor::new(bytes)).unwrap();
        let order = compressible_objgens(&mut pdf).unwrap();
        assert!(
            !order.contains(&ref0(5)),
            "indirect /Length holder (obj 5) must be omitted from the traversal; got {order:?}"
        );
    }

    /// qpdf excludes a signature value dictionary — `/Type /Sig` with both
    /// `/ByteRange` and `/Contents` — from the compressible set (QPDF.cc:2440),
    /// because the signed byte range must not move into an object stream.
    #[test]
    fn compressible_objgens_excludes_signature_dictionaries() {
        let bytes = pdf_from_bodies(&[
            (
                1,
                b"<< /Type /Catalog /Pages 2 0 R /SigTest 4 0 R >>".to_vec(),
            ),
            (2, b"<< /Type /Pages /Count 1 /Kids [ 3 0 R ] >>".to_vec()),
            (
                3,
                b"<< /Type /Page /Parent 2 0 R /MediaBox [0 0 612 792] >>".to_vec(),
            ),
            (
                4,
                b"<< /Type /Sig /ByteRange [0 10 20 30] /Contents <00> >>".to_vec(),
            ),
        ]);
        let mut pdf = crate::reader::Pdf::open(std::io::Cursor::new(bytes)).unwrap();
        let order = compressible_objgens(&mut pdf).unwrap();
        assert!(
            !order.contains(&ref0(4)),
            "signature dictionary (obj 4) must be excluded from the compressible set; got {order:?}"
        );
    }

    /// qpdf's `generateObjectStreams` (QPDFWriter.cc:1981) picks
    /// `ceil(n/100)` streams then spreads objects evenly
    /// (`n_per = ceil(n/streams)`), never greedily filling 100 then spilling.
    #[test]
    fn even_split_stream_counts_and_sizes() {
        let refs = |n: u32| -> Vec<ObjectRef> { (1..=n).map(ref0).collect() };
        let sizes = |n: u32| -> Vec<usize> {
            even_split_into_streams(&refs(n))
                .iter()
                .map(|s| s.len())
                .collect()
        };
        assert_eq!(sizes(0), Vec::<usize>::new(), "no objects -> no streams");
        assert_eq!(sizes(100), vec![100], "exactly 100 -> a single stream");
        assert_eq!(
            sizes(101),
            vec![51, 50],
            "101 -> two even streams, not 100+1"
        );
        assert_eq!(
            sizes(102),
            vec![51, 51],
            "102 -> two even streams, not 100+2"
        );
        assert_eq!(sizes(200), vec![100, 100], "200 -> two full streams");
        assert_eq!(sizes(201), vec![67, 67, 67], "201 -> three even streams");
    }

    /// End-to-end check that the DFS order + even split reproduce qpdf 11.9.0's
    /// measured object-stream partition. On a 130-page reverse-`/Kids` document
    /// (132 eligible objects) qpdf emits two streams of 66; the first holds the
    /// objects reached first in the array walk — Catalog, Pages, and source
    /// pages 69..132 — NOT the lowest-numbered objects.
    #[test]
    fn even_split_matches_qpdf_partition_on_130_page_reverse() {
        let mut pdf =
            crate::reader::Pdf::open(std::io::Cursor::new(reverse_kids_pdf(130))).unwrap();
        let eligible = compressible_objgens(&mut pdf).unwrap();
        let groups = even_split_into_streams(&eligible);

        assert_eq!(groups.len(), 2, "132 eligible -> 2 streams");
        assert_eq!((groups[0].len(), groups[1].len()), (66, 66));

        let nums = |g: &[ObjectRef]| -> BTreeSet<u32> { g.iter().map(|r| r.number).collect() };
        let expected0: BTreeSet<u32> = [1u32, 2].into_iter().chain(69..=132).collect();
        let expected1: BTreeSet<u32> = (3..=68).collect();
        assert_eq!(
            nums(&groups[0]),
            expected0,
            "stream 1 = Catalog,Pages,69..132"
        );
        assert_eq!(nums(&groups[1]), expected1, "stream 2 = pages 3..68");
    }

    /// End-to-end renumber check against qpdf 11.9.0's MEASURED output on the
    /// 130-page reverse-`/Kids` fixture (`--object-streams=generate --static-id`):
    /// each ObjStm container is numbered immediately before its members, and the
    /// members are numbered in ascending SOURCE object order. Measured anchors —
    /// container 1 holds {Catalog,Pages,69..132}; container 68 holds {3..68}:
    /// `Catalog(1)->2`, `Pages(2)->3`, `src69->4`, `src132->67`, `src3->69`,
    /// `src68->134`.
    #[test]
    fn generate_renumber_matches_qpdf_on_130_page_reverse() {
        let mut pdf =
            crate::reader::Pdf::open(std::io::Cursor::new(reverse_kids_pdf(130))).unwrap();
        let eligible = compressible_objgens(&mut pdf).unwrap();
        let groups = even_split_into_streams(&eligible);
        let rn = crate::rewrite_renumber::GenerateRenumber::build(&mut pdf, &groups, true).unwrap();

        let n = |src: u32| rn.new_for_original(ref0(src)).map(|r| r.number);
        assert_eq!(n(1), Some(2), "Catalog");
        assert_eq!(n(2), Some(3), "Pages");
        assert_eq!(n(69), Some(4), "first member of container 1 after Pages");
        assert_eq!(n(132), Some(67), "last member of container 1");
        assert_eq!(n(3), Some(69), "first member of container 2");
        assert_eq!(n(68), Some(134), "last member of container 2");
        assert_eq!(
            rn.container_numbers(),
            vec![1, 68],
            "containers numbered just before their members, in encounter order"
        );
    }

    /// qpdf excludes the encryption dictionary from the compressible set
    /// (`m->trailer.getKey("/Encrypt")`, QPDF.cc:2402/2437): it must stay a
    /// plain indirect so a reader can decrypt the rest of the file. The
    /// `encrypted-r4-three-page` fixture references its `/Encrypt` dictionary at
    /// object 12.
    #[test]
    fn compressible_objgens_excludes_encryption_dictionary() {
        let path = concat!(
            env!("CARGO_MANIFEST_DIR"),
            "/../../tests/fixtures/compat/encrypted-r4-three-page.pdf"
        );
        let bytes = std::fs::read(path).unwrap();
        let mut pdf = crate::reader::Pdf::open(std::io::Cursor::new(bytes)).unwrap();
        let order = compressible_objgens(&mut pdf).unwrap();
        assert!(
            !order.contains(&ref0(12)),
            "the /Encrypt dictionary (obj 12) must be excluded from the compressible set; got {order:?}"
        );
    }

    fn typed_dict(type_name: &[u8]) -> Object {
        let mut d = Dictionary::new();
        d.insert("Type", Object::Name(type_name.to_vec()));
        Object::Dictionary(d)
    }

    #[test]
    fn generation_one_is_ineligible() {
        let obj = Object::Null;
        assert!(!is_eligible_for_objstm(ref1(1), &obj, &no_ctx()));
    }

    #[test]
    fn stream_object_is_ineligible() {
        let obj = Object::Stream(Stream::new(Dictionary::new(), vec![]));
        assert!(!is_eligible_for_objstm(ref0(1), &obj, &no_ctx()));
    }

    #[test]
    fn objstm_typed_dict_is_ineligible() {
        let obj = typed_dict(b"ObjStm");
        assert!(!is_eligible_for_objstm(ref0(1), &obj, &no_ctx()));
    }

    #[test]
    fn xref_typed_dict_is_ineligible() {
        let obj = typed_dict(b"XRef");
        assert!(!is_eligible_for_objstm(ref0(1), &obj, &no_ctx()));
    }

    #[test]
    fn encryption_dict_ref_is_ineligible() {
        let ctx = EligibilityContext {
            encryption_ref: Some(ref0(5)),
            linearization_param_ref: None,
        };
        let obj = Object::Null;
        assert!(!is_eligible_for_objstm(ref0(5), &obj, &ctx));
    }

    #[test]
    fn linearization_param_dict_ref_is_ineligible() {
        let ctx = EligibilityContext {
            encryption_ref: None,
            linearization_param_ref: Some(ref0(7)),
        };
        let obj = Object::Null;
        assert!(!is_eligible_for_objstm(ref0(7), &obj, &ctx));
    }

    #[test]
    fn plain_page_dict_is_eligible() {
        let obj = typed_dict(b"Page");
        assert!(is_eligible_for_objstm(ref0(3), &obj, &no_ctx()));
    }

    #[test]
    fn plain_null_object_is_eligible() {
        let obj = Object::Null;
        assert!(is_eligible_for_objstm(ref0(10), &obj, &no_ctx()));
    }

    // ── Planner tests ────────────────────────────────────────────────────────

    /// Build a zlib-compressed ObjStm payload from (object-number, raw-bytes) pairs.
    /// Returns (compressed_bytes, first_offset).
    #[cfg(test)]
    fn build_objstm_payload(members: &[(u32, &[u8])]) -> (Vec<u8>, usize) {
        use flate2::write::ZlibEncoder;
        use flate2::Compression;
        use std::io::Write;

        let mut header = String::new();
        let mut body = Vec::new();
        for (index, (number, object_data)) in members.iter().enumerate() {
            let offset = body.len();
            header.push_str(&format!("{} {} ", number, offset));
            body.extend_from_slice(object_data);
            if index + 1 < members.len() {
                body.push(b'\n');
            }
        }
        let mut decoded = Vec::new();
        decoded.extend_from_slice(header.as_bytes());
        decoded.extend_from_slice(&body);

        let mut enc = ZlibEncoder::new(Vec::new(), Compression::default());
        enc.write_all(&decoded).unwrap();
        let encoded = enc.finish().unwrap();
        (encoded, header.len())
    }

    fn append_u24_be(bytes: &mut Vec<u8>, value: u32) {
        let b = value.to_be_bytes();
        bytes.extend_from_slice(&b[1..]);
    }

    /// Append a 1+3+1 xref stream entry (W=[1 3 1]).
    fn append_xref_entry(entries: &mut Vec<u8>, entry_type: u8, field1: u32, field2: u8) {
        entries.push(entry_type);
        append_u24_be(entries, field1);
        entries.push(field2);
    }

    /// Build a minimal PDF (PDF-1.5) that contains one ObjStm.
    ///
    /// Fixed object layout (object numbers are consecutive):
    ///   0          free
    ///   1 0 obj    Catalog (plain indirect at offset)
    ///   2 0 obj    Pages   (compressed in ObjStm 4, index 0)
    ///   3..N 0 obj extra compressed members (in ObjStm 4, indices 1..N-2)
    ///   N+1 0 obj  ObjStm (object number = 2 + n_extra + 1 = 3 + n_extra)
    ///   N+2 0 obj  XRef stream
    ///
    /// `n_extra`: how many additional compressed members to include beyond obj 2.
    ///   They receive consecutive object numbers starting at 3.
    ///   Pass `extra_data` as per-object bytes; length must equal `n_extra`.
    fn one_objstm_pdf_n(extra_data: &[&[u8]]) -> Vec<u8> {
        let n_extra = extra_data.len();
        // ObjStm object number = 3 + n_extra
        let objstm_num = 3 + n_extra as u32;
        // XRef stream object number = objstm_num + 1
        let xref_num = objstm_num + 1;
        // Total object count (0-based inclusive up to xref_num)
        let total_size = xref_num + 1;

        let mut bytes = b"%PDF-1.5\n".to_vec();

        // Object 1: Catalog
        let catalog_offset = bytes.len();
        bytes.extend_from_slice(b"1 0 obj\n<< /Type /Catalog /Pages 2 0 R >>\nendobj\n");

        // Build ObjStm payload
        let pages_bytes: &[u8] = b"<< /Type /Pages /Count 0 /Kids [] >>";
        let mut all_members: Vec<(u32, &[u8])> = vec![(2, pages_bytes)];
        for (i, data) in extra_data.iter().enumerate() {
            all_members.push((3 + i as u32, data));
        }
        let n_members = all_members.len() as u32;
        let (stream_data, first) = build_objstm_payload(&all_members);

        // ObjStm object at objstm_num
        let objstm_offset = bytes.len();
        bytes.extend_from_slice(
            format!(
                "{objstm_num} 0 obj\n<< /Type /ObjStm /N {n_members} /First {first} /Length {} /Filter /FlateDecode >>\nstream\n",
                stream_data.len()
            )
            .as_bytes(),
        );
        bytes.extend_from_slice(&stream_data);
        bytes.extend_from_slice(b"\nendstream\nendobj\n");

        let xref_offset = bytes.len();

        // Build xref entries (W=[1 3 1], /Index [0 total_size])
        let mut xref_entries: Vec<u8> = Vec::new();
        // 0: free
        append_xref_entry(&mut xref_entries, 0, 0, 0);
        // 1: Catalog
        append_xref_entry(&mut xref_entries, 1, catalog_offset as u32, 0);
        // 2: Pages compressed in ObjStm, index 0
        append_xref_entry(&mut xref_entries, 2, objstm_num, 0);
        // 3..objstm_num-1: extra members compressed in ObjStm
        for i in 0..n_extra {
            append_xref_entry(&mut xref_entries, 2, objstm_num, (i + 1) as u8);
        }
        // objstm_num: ObjStm stream at offset
        append_xref_entry(&mut xref_entries, 1, objstm_offset as u32, 0);
        // xref_num: XRef stream at xref_offset
        append_xref_entry(&mut xref_entries, 1, xref_offset as u32, 0);

        bytes.extend_from_slice(
            format!(
                "{xref_num} 0 obj\n<< /Type /XRef /Size {total_size} /Root 1 0 R /W [1 3 1] /Index [0 {total_size}] /Length {} >>\nstream\n",
                xref_entries.len()
            )
            .as_bytes(),
        );
        bytes.extend_from_slice(&xref_entries);
        bytes.extend_from_slice(b"\nendstream\nendobj\n");
        bytes.extend_from_slice(format!("startxref\n{xref_offset}\n%%EOF\n").as_bytes());
        bytes
    }

    fn open_pdf(bytes: Vec<u8>) -> crate::reader::Pdf<std::io::Cursor<Vec<u8>>> {
        crate::reader::Pdf::open(std::io::Cursor::new(bytes)).unwrap()
    }

    #[test]
    fn planner_disable_mode_yields_empty_plan() {
        let pdf_bytes = one_objstm_pdf_n(&[]);
        let mut pdf = open_pdf(pdf_bytes);
        let config = PlannerConfig {
            mode: ObjectStreamMode::Disable,
            batch_size_cap: NonZeroUsize::new(100).unwrap(),
        };
        let plan = plan_object_streams(&mut pdf, &config).unwrap();
        assert!(
            plan.batches.is_empty(),
            "Disable mode must produce zero batches"
        );
    }

    #[test]
    fn planner_preserve_mode_reuses_source_membership() {
        // ObjStm has 2 members: object 2 (Pages) at index 0, object 3 (string) at index 1.
        let pdf_bytes = one_objstm_pdf_n(&[b"(hello)"]);
        let mut pdf = open_pdf(pdf_bytes);

        let config = PlannerConfig {
            mode: ObjectStreamMode::Preserve,
            batch_size_cap: NonZeroUsize::new(100).unwrap(),
        };
        let plan = plan_object_streams(&mut pdf, &config).unwrap();

        // Should produce exactly one batch containing refs 2 and 3 (index order).
        assert_eq!(plan.batches.len(), 1, "expected 1 batch");
        let batch = &plan.batches[0];
        assert_eq!(batch.len(), 2);
        assert_eq!(batch[0], ObjectRef::new(2, 0));
        assert_eq!(batch[1], ObjectRef::new(3, 0));
    }

    #[test]
    fn planner_generate_mode_packs_eligible_objects_in_sorted_order() {
        // one_objstm_pdf_n with 1 extra member:
        //   obj 1: Catalog dict  → eligible
        //   obj 2: Pages dict    → eligible (compressed)
        //   obj 3: string (hello)→ eligible (compressed)
        //   obj 4: ObjStm stream → ineligible
        //   obj 5: XRef stream   → ineligible
        let pdf_bytes = one_objstm_pdf_n(&[b"(world)"]);
        let mut pdf = open_pdf(pdf_bytes);

        let config = PlannerConfig {
            mode: ObjectStreamMode::Generate,
            batch_size_cap: NonZeroUsize::new(100).unwrap(),
        };
        let plan = plan_object_streams(&mut pdf, &config).unwrap();

        assert_eq!(plan.batches.len(), 1);
        let batch = &plan.batches[0];
        // Must be in (number, generation) ascending order
        let numbers: Vec<u32> = batch.iter().map(|r| r.number).collect();
        assert!(
            numbers.windows(2).all(|w| w[0] < w[1]),
            "batch must be sorted by object number; got {numbers:?}"
        );
        // Eligible count: 1, 2, 3 → 3 objects
        assert_eq!(batch.len(), 3, "expected 3 eligible objects");
        // All refs must have generation 0
        for r in batch {
            assert_eq!(r.generation, 0);
        }
    }

    #[test]
    fn planner_respects_batch_size_cap() {
        // 5 extra members → obj 2,3,4,5,6,7 are compressed; obj 1 plain Catalog.
        // ObjStm=obj8, XRef=obj9. Eligible: 1,2,3,4,5,6,7 → 7 objects.
        let extra: Vec<&[u8]> = vec![b"(a)" as &[u8], b"(b)", b"(c)", b"(d)", b"(e)"];
        let pdf_bytes = one_objstm_pdf_n(&extra);
        let mut pdf = open_pdf(pdf_bytes);

        let config = PlannerConfig {
            mode: ObjectStreamMode::Generate,
            batch_size_cap: NonZeroUsize::new(3).unwrap(),
        };
        let plan = plan_object_streams(&mut pdf, &config).unwrap();

        // Every batch must have <= 3 members
        for (i, batch) in plan.batches.iter().enumerate() {
            assert!(
                batch.len() <= 3,
                "batch {i} has {} members, exceeds cap of 3",
                batch.len()
            );
        }
        // Total members across all batches: 7 eligible (1,2,3,4,5,6,7)
        let total: usize = plan.batches.iter().map(|b| b.len()).sum();
        assert_eq!(total, 7, "expected 7 eligible objects in total");
        // ceil(7/3) = 3 batches
        assert_eq!(plan.batches.len(), 3);
    }

    /// Verify that an ObjStm whose `/Length` is an indirect reference causes
    /// `plan_object_streams` to return `Err`.
    ///
    /// ## Fixture layout
    ///   0          free
    ///   1 0 obj    Catalog  (plain indirect)
    ///   2 0 obj    Pages    (compressed in ObjStm 3, index 0)
    ///   3 0 obj    ObjStm   with /Length 5 0 R  (plain indirect; parser cannot decode it)
    ///   4 0 obj    XRef stream
    ///   5 0 obj    Integer  (the actual length value; serves as /Length target)
    ///
    /// ## What this test verifies
    ///
    /// The flpdf stream parser (`stream_from_dict`) requires `/Length` to be a
    /// direct integer.  When `collect_indirect_objstm_length_refs` iterates
    /// over all objects and hits ObjStm 3, `pdf.resolve(3 0 R)` calls
    /// `stream_from_dict`, which errors on the indirect `/Length 5 0 R`.
    /// That error propagates through `plan_object_streams` via `?`, so the
    /// function must return `Err`.
    ///
    /// The `Ok` branch is kept for forward-compatibility: if the parser gains
    /// indirect-/Length support in the future, the exclusion rule (object 5 0 R
    /// must not appear in any batch) should still hold.
    #[test]
    fn planner_excludes_indirect_objstm_length_target() {
        // Build ObjStm payload containing only Pages(2,0).  Catalog (1,0) is
        // emitted as a plain indirect object below — putting it in both places
        // would create a ghost member that no xref entry points to.
        let pages_bytes: &[u8] = b"<< /Type /Pages /Count 0 /Kids [] >>";
        let (stream_data, first) = build_objstm_payload(&[(2, pages_bytes)]);
        let stream_len = stream_data.len();

        // We will write the length holder (5 0 obj) as a plain integer.
        // The ObjStm dict references /Length as "5 0 R".
        let mut bytes = b"%PDF-1.5\n".to_vec();

        // 1 0 obj — Catalog (plain indirect, so we can reference it easily)
        let catalog_offset = bytes.len();
        bytes.extend_from_slice(b"1 0 obj\n<< /Type /Catalog /Pages 2 0 R >>\nendobj\n");

        // 3 0 obj — ObjStm with /Length 5 0 R (indirect)
        let objstm_offset = bytes.len();
        let objstm_header = format!(
            "3 0 obj\n<< /Type /ObjStm /N 1 /First {first} /Length 5 0 R /Filter /FlateDecode >>\nstream\n"
        );
        bytes.extend_from_slice(objstm_header.as_bytes());
        bytes.extend_from_slice(&stream_data);
        bytes.extend_from_slice(b"\nendstream\nendobj\n");

        // 5 0 obj — the actual length value
        let len_holder_offset = bytes.len();
        bytes.extend_from_slice(format!("5 0 obj\n{stream_len}\nendobj\n").as_bytes());

        // 4 0 obj — XRef stream (W=[1 3 1], /Index [0 6])
        let xref_offset = bytes.len();
        // 6 objects: 0 free, 1 catalog, 2 Pages (compressed), 3 ObjStm, 4 XRef, 5 LenHolder
        let mut xref_entries: Vec<u8> = Vec::new();
        // 0: free
        append_xref_entry(&mut xref_entries, 0, 0, 0);
        // 1: Catalog at catalog_offset
        append_xref_entry(&mut xref_entries, 1, catalog_offset as u32, 0);
        // 2: Pages compressed in ObjStm 3, index 0
        append_xref_entry(&mut xref_entries, 2, 3, 0);
        // 3: ObjStm at objstm_offset
        append_xref_entry(&mut xref_entries, 1, objstm_offset as u32, 0);
        // 4: XRef at xref_offset (self-referential)
        append_xref_entry(&mut xref_entries, 1, xref_offset as u32, 0);
        // 5: LenHolder at len_holder_offset
        append_xref_entry(&mut xref_entries, 1, len_holder_offset as u32, 0);

        let xref_header = format!(
            "4 0 obj\n<< /Type /XRef /Size 6 /Root 1 0 R /W [1 3 1] /Index [0 6] /Length {} >>\nstream\n",
            xref_entries.len()
        );
        bytes.extend_from_slice(xref_header.as_bytes());
        bytes.extend_from_slice(&xref_entries);
        bytes.extend_from_slice(b"\nendstream\nendobj\n");
        bytes.extend_from_slice(format!("startxref\n{xref_offset}\n%%EOF\n").as_bytes());

        let mut pdf = open_pdf(bytes);

        let config = PlannerConfig {
            mode: ObjectStreamMode::Generate,
            batch_size_cap: NonZeroUsize::new(100).unwrap(),
        };
        let result = plan_object_streams(&mut pdf, &config);

        // As of 2026-05, stream_from_dict requires /Length to be a direct integer,
        // so plan_object_streams returns Err for this fixture.  The Err branch is
        // the expected path.  The Ok branch is kept for forward-compatibility only.
        match result {
            Err(_) => {
                // Expected: parser rejects indirect /Length, plan_object_streams
                // returns Err.  This documents the known limitation.
            }
            Ok(plan) => {
                // Forward-compat path: if indirect /Length support lands, the
                // exclusion rule must still hold — object (5,0) must not appear
                // in any batch because it is the /Length target of an ObjStm.
                let holder = ObjectRef::new(5, 0);
                for (i, batch) in plan.batches.iter().enumerate() {
                    assert!(
                        !batch.contains(&holder),
                        "batch {i} must not contain the indirect /Length holder (5,0); got {batch:?}"
                    );
                }
            }
        }
    }

    #[test]
    fn planner_preserve_mode_skips_ineligible_members() {
        // ObjStm has 3 compressed members:
        //   obj 2: Pages dict          → eligible
        //   obj 3: /Type /XRef dict    → ineligible (is_eligible_for_objstm rejects XRef-typed dicts)
        //   obj 4: plain string        → eligible
        //
        // Preserve mode must include only obj 2 and obj 4 in the output batch,
        // skipping obj 3 even though it is recorded as compressed in the source xref.
        let pdf_bytes = one_objstm_pdf_n(&[
            b"<< /Type /XRef /Size 1 >>", // obj 3: XRef-typed dict — ineligible
            b"(eligible-string)",         // obj 4: plain string — eligible
        ]);
        let mut pdf = open_pdf(pdf_bytes);
        let config = PlannerConfig {
            mode: ObjectStreamMode::Preserve,
            batch_size_cap: NonZeroUsize::new(100).unwrap(),
        };
        let plan = plan_object_streams(&mut pdf, &config).unwrap();
        assert_eq!(plan.batches.len(), 1, "expected 1 batch");
        let batch = &plan.batches[0];
        // Only obj 2 (Pages) and obj 4 (string) are eligible; obj 3 (/Type /XRef) is filtered.
        assert_eq!(
            batch.len(),
            2,
            "expected 2 eligible members; got {:?}",
            batch
        );
        assert_eq!(batch[0], ObjectRef::new(2, 0));
        assert_eq!(batch[1], ObjectRef::new(4, 0));
    }

    // ── ObjStm body emitter tests ────────────────────────────────────────────

    #[test]
    fn emit_objstm_body_empty_batch_returns_empty() {
        let body = emit_objstm_body_from_resolved(&[]).unwrap();
        assert_eq!(body.bytes, Vec::<u8>::new());
        assert_eq!(body.first_offset, 0);
        assert_eq!(body.n_members, 0);
    }

    #[test]
    fn emit_objstm_body_single_member_layout() {
        let obj_ref = ObjectRef::new(12, 0);
        let obj = Object::Integer(42);

        // Serialize expected object bytes manually.
        let mut expected_obj_bytes = Vec::new();
        obj.write_pdf(&mut expected_obj_bytes);
        // write_pdf has no trailing LF; emitter appends one.
        expected_obj_bytes.push(b'\n');

        let body = emit_objstm_body_from_resolved(&[(obj_ref, obj)]).unwrap();

        // Pair table: "12 0\n"
        let expected_pair_table = b"12 0\n";
        assert_eq!(
            &body.bytes[..expected_pair_table.len()],
            expected_pair_table,
            "pair table mismatch"
        );

        // first_offset matches pair table length.
        assert_eq!(body.first_offset, expected_pair_table.len());

        // Objects section starts at first_offset.
        let objects_section = &body.bytes[body.first_offset..];
        assert_eq!(
            objects_section, expected_obj_bytes,
            "objects section mismatch"
        );

        assert_eq!(body.n_members, 1);
    }

    #[test]
    fn emit_objstm_body_multiple_members_offsets_are_correct() {
        let members: Vec<(ObjectRef, Object)> = vec![
            (ObjectRef::new(5, 0), Object::Integer(100)),
            (ObjectRef::new(7, 0), Object::Boolean(true)),
            (ObjectRef::new(9, 0), Object::Null),
        ];

        let body = emit_objstm_body_from_resolved(&members).unwrap();

        assert_eq!(body.n_members, 3);

        // The pair table is qpdf's single-line, space-separated `num offset`
        // sequence terminated by one newline (not one pair per line).
        let pair_table_bytes = &body.bytes[..body.first_offset];
        assert_eq!(pair_table_bytes.last(), Some(&b'\n'));
        assert!(!pair_table_bytes[..pair_table_bytes.len() - 1].contains(&b'\n'));
        let pair_table_str = std::str::from_utf8(pair_table_bytes).unwrap();
        let tokens: Vec<&str> = pair_table_str.split_whitespace().collect();
        assert_eq!(tokens.len(), 6, "3 members -> 6 tokens (num + offset each)");
        let reported_offsets: Vec<usize> =
            tokens.chunks(2).map(|p| p[1].parse().unwrap()).collect();
        assert_eq!(reported_offsets.len(), 3);

        // Verify that each reported offset matches the actual start position
        // of each serialized object in the objects section.
        let objects_section = &body.bytes[body.first_offset..];
        for (i, (_, obj)) in members.iter().enumerate() {
            let mut expected_obj = Vec::new();
            obj.write_pdf(&mut expected_obj);
            let start = reported_offsets[i];
            let end = start + expected_obj.len();
            assert!(
                end <= objects_section.len(),
                "object {i} offset {start} + len {} out of range",
                expected_obj.len()
            );
            assert_eq!(
                &objects_section[start..end],
                expected_obj.as_slice(),
                "object {i} body mismatch at offset {start}"
            );
        }
    }

    #[test]
    fn emit_objstm_body_rejects_duplicate_member_numbers() {
        let members: Vec<(ObjectRef, Object)> = vec![
            (ObjectRef::new(5, 0), Object::Integer(1)),
            (ObjectRef::new(5, 0), Object::Integer(2)),
        ];
        let result = emit_objstm_body_from_resolved(&members);
        assert!(result.is_err(), "expected Err for duplicate member");
        let err_msg = result.unwrap_err().to_string();
        assert!(
            err_msg.contains("duplicate member") || err_msg.contains("5"),
            "error message should mention duplicate/number: {err_msg}"
        );
    }

    #[test]
    fn emit_objstm_body_round_trip_with_reader() {
        // Build a body with three integer objects and parse each back via
        // parse_object_stream_entry (no Pdf construction needed — no /Filter).
        let members: Vec<(ObjectRef, Object)> = vec![
            (ObjectRef::new(10, 0), Object::Integer(111)),
            (ObjectRef::new(20, 0), Object::Integer(222)),
            (ObjectRef::new(30, 0), Object::Integer(333)),
        ];

        let body = emit_objstm_body_from_resolved(&members).unwrap();

        // Construct a synthetic Stream with no /Filter (data is already plain).
        let mut dict = crate::object::Dictionary::new();
        dict.insert("Type", Object::Name(b"ObjStm".to_vec()));
        dict.insert("N", Object::Integer(body.n_members as i64));
        dict.insert("First", Object::Integer(body.first_offset as i64));
        dict.insert("Length", Object::Integer(body.bytes.len() as i64));
        let stream = crate::Stream {
            dict,
            data: body.bytes.clone(),
        };

        for (index, (_, expected_obj)) in members.iter().enumerate() {
            let parsed = crate::reader::parse_object_stream_entry(&stream, index as u32).unwrap();
            assert_eq!(
                &parsed, expected_obj,
                "round-trip mismatch at index {index}"
            );
        }
    }

    // ── wrap_objstm_body tests ────────────────────────────────────────────────

    #[test]
    fn wrap_objstm_body_dict_layout() {
        let body = ObjStmBody {
            bytes: b"1 0\n42\n".to_vec(),
            first_offset: 4,
            n_members: 1,
        };
        let stream = wrap_objstm_body(&body, crate::writer::CompressStreams::Yes).unwrap();

        assert_eq!(
            stream.dict.get("Type"),
            Some(&Object::Name(b"ObjStm".to_vec())),
            "/Type must be /ObjStm"
        );
        assert_eq!(
            stream.dict.get("N"),
            Some(&Object::Integer(1)),
            "/N must be 1"
        );
        assert_eq!(
            stream.dict.get("First"),
            Some(&Object::Integer(4)),
            "/First must be 4"
        );
        assert_eq!(
            stream.dict.get("Length"),
            Some(&Object::Integer(stream.data.len() as i64)),
            "/Length must equal compressed data length"
        );
        assert_eq!(
            stream.dict.get("Filter"),
            Some(&Object::Name(b"FlateDecode".to_vec())),
            "/Filter must be /FlateDecode"
        );
    }

    #[test]
    fn wrap_objstm_body_round_trip_via_decode() {
        let members: Vec<(ObjectRef, Object)> = vec![
            (ObjectRef::new(5, 0), Object::Integer(10)),
            (ObjectRef::new(6, 0), Object::Integer(20)),
        ];
        let body = emit_objstm_body_from_resolved(&members).unwrap();
        let original_bytes = body.bytes.clone();

        let stream = wrap_objstm_body(&body, crate::writer::CompressStreams::Yes).unwrap();

        let decoded = crate::filters::decode_stream_data(&stream.dict, &stream.data).unwrap();
        assert_eq!(
            decoded, original_bytes,
            "decoded bytes must equal original body bytes"
        );
    }

    #[test]
    fn wrap_objstm_body_round_trip_via_parse_object_stream_entry() {
        let ref1 = ObjectRef::new(11, 0);
        let obj1 = Object::Integer(42);
        let ref2 = ObjectRef::new(22, 0);
        let obj2 = Object::Integer(99);

        let body =
            emit_objstm_body_from_resolved(&[(ref1, obj1.clone()), (ref2, obj2.clone())]).unwrap();
        let stream = wrap_objstm_body(&body, crate::writer::CompressStreams::Yes).unwrap();

        let parsed0 = crate::reader::parse_object_stream_entry(&stream, 0).unwrap();
        let parsed1 = crate::reader::parse_object_stream_entry(&stream, 1).unwrap();

        assert_eq!(parsed0, obj1, "index 0 must parse to Integer(42)");
        assert_eq!(parsed1, obj2, "index 1 must parse to Integer(99)");
    }

    #[test]
    fn wrap_objstm_body_no_compression_round_trips_without_filter() {
        // CompressStreams::No must emit an uncompressed ObjStm (no /Filter)
        // whose /N, /First and member offsets still let the reader resolve
        // every member.
        let ref1 = ObjectRef::new(11, 0);
        let obj1 = Object::Integer(42);
        let ref2 = ObjectRef::new(22, 0);
        let obj2 = Object::Integer(99);

        let body =
            emit_objstm_body_from_resolved(&[(ref1, obj1.clone()), (ref2, obj2.clone())]).unwrap();
        let stream = wrap_objstm_body(&body, crate::writer::CompressStreams::No).unwrap();

        assert!(
            stream.dict.get("Filter").is_none(),
            "CompressStreams::No ObjStm must have no /Filter"
        );

        let parsed0 = crate::reader::parse_object_stream_entry(&stream, 0).unwrap();
        let parsed1 = crate::reader::parse_object_stream_entry(&stream, 1).unwrap();
        assert_eq!(parsed0, obj1, "index 0 must parse to Integer(42)");
        assert_eq!(parsed1, obj2, "index 1 must parse to Integer(99)");
    }

    #[test]
    fn wrap_objstm_body_empty_members_still_valid() {
        let body = ObjStmBody {
            bytes: vec![],
            first_offset: 0,
            n_members: 0,
        };
        let stream = wrap_objstm_body(&body, crate::writer::CompressStreams::Yes).unwrap();

        assert_eq!(
            stream.dict.get("N"),
            Some(&Object::Integer(0)),
            "/N must be 0"
        );
        assert_eq!(
            stream.dict.get("First"),
            Some(&Object::Integer(0)),
            "/First must be 0"
        );
        assert_eq!(
            stream.dict.get("Length"),
            Some(&Object::Integer(stream.data.len() as i64)),
            "/Length must equal compressed data length"
        );
        // Even empty input produces some deflate bytes (header + checksum).
        assert!(
            !stream.data.is_empty(),
            "compressed empty input must produce non-empty deflate bytes"
        );
    }

    // ── Mode dispatch (flpdf-9hc.5.5) ────────────────────────────────────────

    #[test]
    fn write_options_default_is_preserve_mode() {
        let options = crate::WriteOptions::default();
        assert_eq!(options.object_streams, ObjectStreamMode::Preserve);
    }

    #[test]
    fn object_stream_mode_default_is_preserve() {
        assert_eq!(ObjectStreamMode::default(), ObjectStreamMode::Preserve);
    }

    #[test]
    fn planner_config_from_options_maps_preserve() {
        let options = crate::WriteOptions {
            object_streams: ObjectStreamMode::Preserve,
            ..Default::default()
        };
        let config = planner_config_from_options(&options);
        assert_eq!(config.mode, ObjectStreamMode::Preserve);
        assert_eq!(config.batch_size_cap, DEFAULT_BATCH_SIZE_CAP);
    }

    #[test]
    fn planner_config_from_options_maps_disable() {
        let options = crate::WriteOptions {
            object_streams: ObjectStreamMode::Disable,
            ..Default::default()
        };
        let config = planner_config_from_options(&options);
        assert_eq!(config.mode, ObjectStreamMode::Disable);
    }

    #[test]
    fn planner_config_from_options_maps_generate() {
        let options = crate::WriteOptions {
            object_streams: ObjectStreamMode::Generate,
            ..Default::default()
        };
        let config = planner_config_from_options(&options);
        assert_eq!(config.mode, ObjectStreamMode::Generate);
    }

    // ── QDF forces Disable mode (flpdf-9hc.6.2) ─────────────────────────────

    #[test]
    fn qdf_flag_forces_disable_mode_over_preserve() {
        let options = crate::WriteOptions {
            qdf: true,
            object_streams: ObjectStreamMode::Preserve,
            ..Default::default()
        };
        let config = planner_config_from_options(&options);
        assert_eq!(
            config.mode,
            ObjectStreamMode::Disable,
            "qdf=true must force effective mode to Disable (was Preserve)"
        );
        // original field must be unchanged
        assert_eq!(options.object_streams, ObjectStreamMode::Preserve);
    }

    #[test]
    fn qdf_flag_forces_disable_mode_over_generate() {
        let options = crate::WriteOptions {
            qdf: true,
            object_streams: ObjectStreamMode::Generate,
            ..Default::default()
        };
        let config = planner_config_from_options(&options);
        assert_eq!(
            config.mode,
            ObjectStreamMode::Disable,
            "qdf=true must force effective mode to Disable (was Generate)"
        );
        // original field must be unchanged so layer 6.6 can detect the conflict
        assert_eq!(options.object_streams, ObjectStreamMode::Generate);
    }

    #[test]
    fn qdf_false_does_not_override_generate() {
        let options = crate::WriteOptions {
            qdf: false,
            object_streams: ObjectStreamMode::Generate,
            ..Default::default()
        };
        let config = planner_config_from_options(&options);
        assert_eq!(
            config.mode,
            ObjectStreamMode::Generate,
            "qdf=false must not change the object_streams mode"
        );
    }
}